a7e65d98a9
FIX: mutex to avoid race condition with double notify
2017-05-26 17:04:40 -04:00
81c18fc0bd
UX: Add link to the user's preferences page next to the avatar
2017-05-26 15:00:49 -04:00
aa24bcbcc9
correct annotation
2017-05-26 09:04:54 -04:00
0aed2533ac
Revert unread optimisation, has too many edge cases
2017-05-26 09:04:13 -04:00
e57d2f5cb8
FIX: Don't do anything if avatar url returns an invalid status code.
2017-05-26 13:02:40 +08:00
7d59ff67b8
adjust qurey to include messages, once everything is read
...
then mark first_topic_unread_at to be current time
2017-05-25 18:40:32 -04:00
39e1948174
FIX: If the error is 401 unauthorized or such, just do nothing
2017-05-25 15:42:05 -04:00
b584264d82
FIX: Don't show "resend email" option when user approval is on
2017-05-25 15:29:05 -04:00
29fac1ac18
PERF: improve performance of unread queries
...
Figuring out what unread topics a user has is a very expensive
operation over time.
Users can easily accumulate 10s of thousands of tracking state rows
(1 for every topic they ever visit)
When figuring out what a user has that is unread we need to join
the tracking state records to the topic table. This can very quickly
lead to cases where you need to scan through the entire topic table.
This commit optimises it so we always keep track of the "first" date
a user has unread topics. Then we can easily filter out all earlier
topics from the join.
We use pg functions, instead of nested queries here to assist the
planner.
2017-05-25 15:07:30 -04:00
6eb6c25816
FIX: Keep the flash when redirecting for login_required
2017-05-25 14:10:15 -04:00
ca965f83c3
Revert "FIX: If login is required, redirect to the `/login` route instead of root"
...
This reverts commit 8a8dec550b
2017-05-25 14:04:28 -04:00
8a8dec550b
FIX: If login is required, redirect to the `/login` route instead of root
2017-05-25 13:35:15 -04:00
f8584e28d7
UX: improved layout of flag handling UI on mobile
2017-05-24 15:52:29 -04:00
f481708348
FIX: Sometimes the duplicate link text made no sense
2017-05-24 14:07:29 -04:00
0a08c18a14
FIX: Don't rate limit gravatar downloads
2017-05-24 13:54:26 -04:00
cdbe027c1c
Refactor `FileHelper` to use keyword arguments.
2017-05-24 13:54:26 -04:00
87ac758f05
FIX: Don't raise an error when the upload can't be retrieved
2017-05-24 13:54:26 -04:00
e8c89b4535
Merge pull request #4865 from chrisgavin/login-button-fix
...
Fix the padding on the login and register buttons.
2017-05-24 12:41:07 -04:00
4266828c62
FIX: incorrect margins on buttons in modals on mobile
2017-05-24 11:57:26 -04:00
d0f84aa14e
FIX: missing to_i which breaks selector component for anon
2017-05-24 11:39:10 -04:00
b78b010757
FIX: Fixes to grant new user of the month badge
2017-05-24 11:36:24 -04:00
0756602dfa
UX: h1, h2, etc css reset should give them a bottom margin
2017-05-24 10:38:25 -04:00
c9028f517a
UX: headings in banners had no margins
2017-05-23 11:25:40 -04:00
9edc490d3f
FIX: remove memoized values in jobs
2017-05-22 16:26:30 -04:00
b23fc2bf84
Helper to find the final destination for a URL
2017-05-22 15:52:41 -04:00
f350dd4fd1
FIX: possible data leaking from one site to another in multisite in PendingFlagsReminder
2017-05-22 15:18:13 -04:00
decb432740
FIX: fill date input with default date range
2017-05-22 21:54:28 +05:30
773445b8df
FIX: Topic Crawling should only crawl HTTP/S urls
2017-05-22 11:57:20 -04:00
08c36fa968
REFACTOR: Clean up some code associated with topic timers.
2017-05-22 18:10:29 +08:00
604aaf8686
FIX: N+1 query in suggested topics list.
2017-05-22 18:05:38 +08:00
238a156300
FIX: `TopicTimestampChanger` should not allow timestamps in the future.
2017-05-22 16:03:49 +08:00
4382a0bb07
Rename `PostTimestampChanger` -> `TopicTimestampChanger`.
2017-05-22 15:01:33 +08:00
393c060047
use moon glyph to denote "later today"
2017-05-19 17:02:00 -07:00
ea9f93dcc5
FIX: Don't crawl non-http/s links
2017-05-19 16:57:41 -04:00
558a274187
UX: flag custom message description is too close to textarea on mobile
2017-05-19 16:08:28 -04:00
908433a7a0
SECURITY: Validate the `entity` when downloading a CSV
2017-05-19 16:00:51 -04:00
0a8e16d049
UX: show short flag descriptions in the flag modal on mobile
2017-05-19 15:35:10 -04:00
c0c6cb8124
mobile like count css rules being ignored
2017-05-19 11:10:18 -04:00
3681b350cd
FIX: new topics alert wasn't covering the entire topic list column headings
2017-05-19 11:05:38 -04:00
387cad693e
"next month" doesn't need time fidelity
2017-05-18 23:29:37 -07:00
e93535e239
Add "Next month" to topic timer selection options.
2017-05-19 14:09:53 +08:00
8ab9f30bbd
FIX: User can't remove bookmark from a deleted post.
2017-05-19 12:25:12 +08:00
870c584e25
Merge pull request #4876 from techAPJ/upload-error
...
FIX: better uploads error page
2017-05-19 07:24:15 +05:30
ef2811f39a
simplify time formats for set topic timer
2017-05-18 17:14:07 -07:00
5e88794a65
remove box-shadows around radio buttons and checkboxes on mobile
2017-05-18 18:04:47 -04:00
fa77bbf04f
FIX: mobile modal close button position, mobile layout of radio buttons and checkboxes
2017-05-18 17:08:52 -04:00
ed4b2b6d8d
FIX: Don't incluide a trailing `<br>` in the bio excerpt
2017-05-18 16:40:07 -04:00
3065b7db4c
FIX: label positioning on mobile forms
2017-05-18 16:38:35 -04:00
c2579c5916
FIX: layout of buttons and modals on mobile
2017-05-18 16:11:52 -04:00
1ef43c33d8
Don't pre-minifiy autoellipsis
2017-05-18 15:16:15 -04:00
1fd8e426f2
FIX: better uploads error page
2017-05-18 23:29:37 +05:30
dbb814ec6a
FIX: allow pasting links into title field that are longer than the max title length
2017-05-18 12:32:47 -04:00
13e489b4ca
replace the upload type whitelist with a sanitizer
2017-05-18 12:13:13 +02:00
8e5b0c79ae
FIX: allow images to be uploaded in wizard
2017-05-18 13:53:23 +05:30
2a5a01af2e
improve error on theme upload, add gif to allowed uploads
2017-05-17 16:29:09 -04:00
a0f03936ff
FIX: saving invisible primary group field that you don't belong to
2017-05-17 12:46:50 -04:00
f8c503186e
FIX: If there's an error downloading, don't raise it
2017-05-17 12:38:18 -04:00
9090c7b05b
FIX: Admin groups editor was showing extra page when exactly 50 records
2017-05-17 11:50:17 -04:00
6d5fe73422
FIX: Sometimes the topic timeline wasn't docking
2017-05-17 11:05:58 -04:00
e4d557cdb9
Partially revert 92118dd1d1.
2017-05-17 21:42:31 +08:00
db06dd8032
remove labels from tag edit buttons in header
2017-05-17 01:18:31 -07:00
92118dd1d1
FIX: Use observer to rerender widget instead.
2017-05-17 10:29:50 +08:00
5d494cf158
FIX: Broken back button on account URLs
2017-05-16 17:21:52 -04:00
68df8f4427
FIX: only trigger notification level change if it actually changes
...
avoids double ajax call every time notification level changes
2017-05-16 16:52:39 -04:00
733b0009cb
FIX: Don't memoize the currentUser in case some plugins use it too early
2017-05-16 16:35:18 -04:00
763f156d91
FIX: require re-activation if SSO changes email and updates it
2017-05-16 16:18:18 -04:00
4424fd81b8
add a tiny bit of extra protection
2017-05-16 16:08:42 -04:00
4b449914b8
FIX: admins could never remove self from messages
2017-05-16 16:06:24 -04:00
6ddd8d9166
FIX: when entering topics "tracking" would not be set
...
There was a timing issue when subscribing to messages for topics.
Old flow:
- We generate JSON for topic
- We subscribe to messages for topic
New flow:
- We keep track of last id in the topic message bus channel
- We generate JSON
- We subscribe to messages for topic starting at saved message id
This ensures that there is complete overlap for message consumption
and that there are no cases where an update may go missing due to timing
2017-05-16 15:04:21 -04:00
7821400141
FEATURE: staff can set a timer to remind them about a topic
2017-05-16 14:49:50 -04:00
59922ce0a4
FEATURE: remove table wrapping posts in notification emails
2017-05-16 10:37:53 -04:00
941adca958
FIX: If you refresh New, clear the incoming topics text
2017-05-15 16:57:09 -04:00
c40ac5abe6
FIX: resize events for ace were not triggered correctly
2017-05-15 16:10:07 -04:00
7a4e825671
we should use fancy title if available
2017-05-15 15:45:29 -04:00
be8dd403df
FEATURE: use fancy title in notifications
2017-05-15 15:38:30 -04:00
f7c46df804
FIX: Only mark all as rendered after *everything* is rendered
2017-05-15 15:12:10 -04:00
f114d63de4
correctly pick the selected theme based on what is loaded
2017-05-15 14:34:24 -04:00
bd0bb879e5
FIX: Don't count likes from system users in the new user of the month
2017-05-15 13:14:32 -04:00
e1dd543a93
FEATURE: allow users to select theme on single device
2017-05-15 12:48:16 -04:00
a0c936dadb
UX: Take header height into account when positioning the timeline
2017-05-15 12:08:42 -04:00
44d7fe89ed
FIX: unescape emoji in pretty title
...
This makes emoji in title consistent, it is later escaped back when needed
2017-05-15 10:28:05 -04:00
dfc9a27dc4
FIX: Quote button broken on windows.
2017-05-15 08:26:48 +08:00
42de1cc977
FIX: Don't warn if the link is in the post you are editing
2017-05-12 20:05:30 -04:00
dd0c34c4b9
move background photo user prefs to be lower in the profile tab
2017-05-12 15:43:21 -04:00
ff6b9aee47
no opacity rule for btn-primary
2017-05-12 15:11:44 -04:00
baf011cbf6
annotate models
2017-05-12 14:47:08 -04:00
a9d5d2aee6
UX: Fix improper aspect ratio for xkcd oneboxes
2017-05-12 13:21:44 -04:00
b92b654ea3
FIX: collapse mobile nav on outside click
2017-05-12 13:15:04 -04:00
3113a6a18a
FIX: hide theme selector if only 1 theme
2017-05-12 12:50:56 -04:00
2d96a0785d
FEATURE: theme selection is now global per-user
2017-05-12 12:41:34 -04:00
b301b69d00
FIX: Don't warn users about duplicate links for:
...
- The original post
- If the post is older than (x) (Two Weeks for now)
2017-05-12 12:37:02 -04:00
ee71786057
PERF: we do not need to ship down the total number of unread
...
Total number of unread notification from the beginning of time
is not an interesting number
2017-05-12 11:11:38 -04:00
e232f87cde
PERF: avoid query as admin
...
As admin no need to query categories over and over
2017-05-12 11:09:41 -04:00
fca166524b
Fix the padding on the login and register buttons.
2017-05-12 09:51:48 +01:00
8eecd42856
FIX: Delete topic timer after completion.
2017-05-12 10:28:51 +08:00
e63614024d
FIX: Users can't request to join group due to alias level restriction.
...
https://meta.discourse.org/t/request-to-join-group-not-working/62371
2017-05-12 09:26:26 +08:00
55b61e9bea
rename topic_status_update to topic_timer
2017-05-11 18:27:53 -04:00
92d63b59a7
FIX: Videos were missing from expanded quotes
2017-05-11 16:54:32 -04:00
f3c535b945
PERF: Dirty checking was broken and re-rendering too often
2017-05-11 16:22:15 -04:00
ea0ecb67f3
UX: Move delete button to end and mark it as dangerous
2017-05-11 16:22:15 -04:00
52ae63d5d7
FIX: when searching PMs also search group PMs
...
Users belonging to a group could not search for PMs unless explicitly added
to the PM unless admin
2017-05-11 15:59:03 -04:00
aa009dd2b5
Add @embeddable_css_class from embed_controller
2017-05-11 15:16:16 -04:00
18de62b015
Add get_embeddable_css_class to assist multi-site embed styling
...
If present, pass embeddable_host.class_name to view for inclusion
on the <html> element as a class for targeted styling.
2017-05-11 15:16:16 -04:00
4bf8548dc5
Add embed class name setup for embeddable hosts
2017-05-11 15:16:16 -04:00
5bbc477baa
UX: Better looking bulk actions modal
2017-05-11 14:48:06 -04:00
1019bbda46
FEATURE: set a timer to delete a topic
2017-05-11 12:52:29 -04:00
21238692d9
Remove unused file
2017-05-11 12:36:57 -04:00
3ade46de0b
FIX: Don't send system message for new user of the month if disabled
2017-05-11 11:33:16 -04:00
006b35d2f3
FIX: Don't redirect for `users/account-created` path
2017-05-11 11:04:45 -04:00
f4b2677a19
FEATURE: ask for confirmation before resending all invites
2017-05-11 18:07:28 +05:30
ce9fe213fd
FIX: Can't quote last paragraph.
2017-05-11 16:49:46 +08:00
8c337ecf82
FIX: allow uploading of category logo and background
2017-05-11 12:48:54 +05:30
214939bb87
freeze array constants
2017-05-11 09:08:59 +02:00
4b7be137cb
don't generate errors if 'upload_id' is invalid
2017-05-11 09:07:04 +02:00
9641d2413d
REFACTOR: upload workflow creation into UploadCreator
...
- Automatically convert large-ish PNG/BMP to JPEG
- Updated fast_image to latest version
2017-05-11 00:16:57 +02:00
a5c4ddd334
oops my linter is not running automatically
2017-05-10 16:09:33 -04:00
2e13c2453b
FIX: maximize css editor not working
2017-05-10 15:47:11 -04:00
04b5516bf2
improve upload functionality
2017-05-10 15:47:11 -04:00
bc0b9af576
FEATURE: support uploads for themes
...
This allows themes to bundle various assets
2017-05-10 15:47:11 -04:00
f709899a1d
Allow theme field object model to support uploads
2017-05-10 15:46:42 -04:00
26209354e3
Don't hardcode code button index and remove the for loop and use .some()
2017-05-10 14:53:54 -04:00
2f8b1e33f4
FEATURE: bulk relist
2017-05-10 14:53:54 -04:00
f7e8bc6216
UX: Tweak explanations for multiple_grant and allow_title
2017-05-10 14:39:23 -04:00
4db76796b9
FEATURE: Setting to poll feeds more frequently
2017-05-10 14:30:12 -04:00
5be7a2dad4
FIX: invalid html in notification emails when template has been customized
2017-05-10 14:01:26 -04:00
41fb76cc66
Don't rescue all errors.
2017-05-10 09:12:44 +08:00
907f6cd76b
FIX: Select2 retina icons were broken
2017-05-09 15:51:39 -04:00
a1baf73956
FIX: Better error message for when your bookmark rate limit is exceeded
2017-05-09 15:42:55 -04:00
ae15b10cf8
FIX: The keyboard shortcut to bookmark the first post wasn't refreshing
2017-05-09 15:37:36 -04:00
6e4ba8a33e
Catch RSS Parsing errors
2017-05-09 15:07:06 -04:00
c2bf525a06
Make CloseTopic a no-op just in case
2017-05-09 15:02:05 -04:00
24e1892d28
Silence logs for OptimizedImage failures
2017-05-09 14:59:46 -04:00
ba1868b051
FIX: There are still jobs enqueued for CloseTopic
2017-05-09 14:58:37 -04:00
da92f35e08
Don't log a gravatar failure that is a socket error
2017-05-09 14:44:53 -04:00
bcf1a9d43f
We don't need to log when we can't download a Gravatar
2017-05-09 14:43:39 -04:00
6fdbd29882
FIX: Dismiss all button was not updating the UI
2017-05-09 13:46:26 -04:00
e6e0025326
FIX: handle BOM in bulk import CSV file
2017-05-09 22:38:07 +05:30
c2829dce22
FIX: base sql vanishes after badge creation
2017-05-09 09:25:57 -04:00
94683b33b8
FIX: sanitize bulk invite error log
2017-05-09 17:41:59 +05:30
afe04b8bbb
FIX: Possible 500 error if category saved incorrectly
2017-05-08 15:17:58 -04:00
4f6e5fed2a
We don't need to raise an error when no post is present. Just noop.
2017-05-08 15:08:29 -04:00
7a0501c0c0
UX: Wrap really long titles on user stream pages
2017-05-08 14:45:34 -04:00
96c59c5b82
FIX: Don't notify or return flags on system users
2017-05-08 13:13:35 -04:00
a7471fe85f
FIX: page scroll lock not clearing properly on chrome
...
For some reason Chrome renamed "mousewheel" to "wheel"
2017-05-08 09:50:07 -04:00
257c0dea70
Merge pull request #4852 from tgxworld/pull_the_plug_on_daily_mailing_list
...
Remove daily mailing mode option as it doesn't scale.
2017-05-08 09:10:46 -04:00
e89d0a6b20
FIX: importing a theme via file was broken
2017-05-08 12:03:24 +05:30
cfb30bca80
UX: simplify delete gap style
2017-05-05 17:06:13 -07:00
27e52bc66d
user page stats too "buttony"
2017-05-05 15:36:13 -07:00
b7322b05a0
FIX: some changes in composer affect all visible text editors
2017-05-05 12:59:45 -04:00
3edea3d226
automatically unpin topics setting doesn't need its own section
2017-05-05 10:25:02 -04:00
Sam
Robin Ward
Guo Xiang Tan
Neil Lalonde
Arpit Jalan
Jeff Atwood
Régis Hanol
Leo McArdle
Chris Gavin
Pat David
OsamaSayegh
osamasayegh