607998af33
FEATURE: dropdown to filter staff action logs
2017-05-30 11:25:42 -04:00
6d1fafaff6
Add rspec tests for advanced search by tags.
2017-05-30 13:01:17 +02:00
0aed2533ac
Revert unread optimisation, has too many edge cases
2017-05-26 09:04:13 -04:00
4d9481bf47
Fix build.
2017-05-26 16:04:59 +08:00
56f98de7b2
Use webmock to stub external web requests.
2017-05-26 15:19:09 +08:00
f8f1548fd4
Revert "FIX: Use Excon to do its own stubbing"
...
This reverts commit 80af54460a
2017-05-26 13:04:25 +08:00
e57d2f5cb8
FIX: Don't do anything if avatar url returns an invalid status code.
2017-05-26 13:02:40 +08:00
b584264d82
FIX: Don't show "resend email" option when user approval is on
2017-05-25 15:29:05 -04:00
29fac1ac18
PERF: improve performance of unread queries
...
Figuring out what unread topics a user has is a very expensive
operation over time.
Users can easily accumulate 10s of thousands of tracking state rows
(1 for every topic they ever visit)
When figuring out what a user has that is unread we need to join
the tracking state records to the topic table. This can very quickly
lead to cases where you need to scan through the entire topic table.
This commit optimises it so we always keep track of the "first" date
a user has unread topics. Then we can easily filter out all earlier
topics from the join.
We use pg functions, instead of nested queries here to assist the
planner.
2017-05-25 15:07:30 -04:00
cdbe027c1c
Refactor `FileHelper` to use keyword arguments.
2017-05-24 13:54:26 -04:00
f12490eae0
FIX: order:latest not working for search within topic
...
FEATURE: use 'l' as a shorthand for order:latest
2017-05-24 11:24:41 -04:00
3b0cbf7013
FIX: Always allow downloads from CDN
2017-05-23 16:32:54 -04:00
d2121ca272
FIX: Missing HTTP stub
2017-05-23 15:08:19 -04:00
b81e7be9a1
FEATURE: Rate limit how often we'll crawl a destination IP
2017-05-23 15:03:04 -04:00
36e477750c
FIX: Use same code path for downloading images
2017-05-23 14:51:30 -04:00
e5e7a15a85
SECURITY: Never crawl by IP
2017-05-23 13:07:18 -04:00
93a5fc62bf
FEATURE: A site setting to prevent crawling on private IP blocks
2017-05-23 11:56:06 -04:00
80af54460a
FIX: Use Excon to do its own stubbing
2017-05-22 18:19:20 -04:00
b51126dd5e
FIX: Reset the WebMock after before every test
2017-05-22 17:52:31 -04:00
9dddb81cf6
FIX: remove memoization on class method used in a job
2017-05-22 23:35:41 +02:00
4e8beda332
Merge pull request #4866 from JaredReisinger/admin-user-pagination
...
Add pagination to /admin/users/list API
2017-05-22 15:12:59 -06:00
d4b16b487e
FIX: Another onebox head request
2017-05-22 17:00:19 -04:00
a8d1e44943
FIX: Onebox will do a HEAD request first for redirects
2017-05-22 16:52:26 -04:00
4c690f7089
Use `FinalDestination` to ensure public redirects for onebox
2017-05-22 16:42:49 -04:00
b23fc2bf84
Helper to find the final destination for a URL
2017-05-22 15:52:41 -04:00
6231318462
Merge pull request #4877 from rimian/plugin_helper
...
FEATURE: Require spec helpers for plugins
2017-05-22 15:22:55 -04:00
a7f337fa93
FIX: CDN wasn't properly applied to category background images when using S3
2017-05-22 18:37:01 +02:00
76229535ac
Remove old test case.
2017-05-22 18:23:09 +08:00
08c36fa968
REFACTOR: Clean up some code associated with topic timers.
2017-05-22 18:10:29 +08:00
238a156300
FIX: `TopicTimestampChanger` should not allow timestamps in the future.
2017-05-22 16:03:49 +08:00
4382a0bb07
Rename `PostTimestampChanger` -> `TopicTimestampChanger`.
2017-05-22 15:01:33 +08:00
2b5dfb6e8e
avoid double lookup for plugin helpers
2017-05-22 14:50:53 +10:00
330338af3a
FIX: Don't hardcode text in smoke test.
2017-05-22 08:01:33 +08:00
908433a7a0
SECURITY: Validate the `entity` when downloading a CSV
2017-05-19 16:00:51 -04:00
28f486cb7a
FIX: Regular users shouldn't be able to invite to PMs if disabled
2017-05-19 12:57:21 -04:00
2b66918199
Wrong function call.
2017-05-19 22:33:06 +08:00
130e7f214b
Account for sites using text site logo in smoke test.
2017-05-19 22:25:08 +08:00
8ab9f30bbd
FIX: User can't remove bookmark from a deleted post.
2017-05-19 12:25:12 +08:00
8febaa8be7
FEATURE: Require spec helpers for plugins
...
* Follows any symlinked plugins
2017-05-19 12:38:36 +10:00
4fb335f1f0
FIX: don't process the same incoming email more than once
2017-05-18 16:43:07 +02:00
13e489b4ca
replace the upload type whitelist with a sanitizer
2017-05-18 12:13:13 +02:00
f4cc71d643
Allow username and password to be passed via ENV for smoke test.
2017-05-18 12:17:31 +08:00
cbe8e05f79
disable test that fails randomly
2017-05-17 12:46:50 -04:00
a0f03936ff
FIX: saving invisible primary group field that you don't belong to
2017-05-17 12:46:50 -04:00
a1b8a3b52b
FIX: supports bare <li> when converting html to markdown
2017-05-17 15:05:11 +02:00
92036616db
Make test less vulnerable to changes.
2017-05-17 19:30:13 +08:00
b0e4555a86
Allow Basic Authentication to be set in smoke test.
2017-05-17 19:24:43 +08:00
3df46833b3
Fix the build.
2017-05-17 16:14:06 +08:00
6a1f579c6e
FIX: don't search for plugins in nested subdirectories
2017-05-16 17:28:56 -04:00
645f648ea7
Merge remote-tracking branch 'upstream/master' into admin-user-pagination
2017-05-16 13:36:47 -07:00
763f156d91
FIX: require re-activation if SSO changes email and updates it
2017-05-16 16:18:18 -04:00
4b449914b8
FIX: admins could never remove self from messages
2017-05-16 16:06:24 -04:00
7821400141
FEATURE: staff can set a timer to remind them about a topic
2017-05-16 14:49:50 -04:00
dd0cb6a117
FIX: Add missing test
2017-05-15 16:57:09 -04:00
bd0bb879e5
FIX: Don't count likes from system users in the new user of the month
2017-05-15 13:14:32 -04:00
e1dd543a93
FEATURE: allow users to select theme on single device
2017-05-15 12:48:16 -04:00
44d7fe89ed
FIX: unescape emoji in pretty title
...
This makes emoji in title consistent, it is later escaped back when needed
2017-05-15 10:28:05 -04:00
8491f8c48b
add smoke test for visiting categories
2017-05-12 17:42:38 -04:00
62d245dde3
Try bumping the timeout for the smoke test
2017-05-12 16:40:38 -04:00
1dcd61fa34
Add pagination to /admin/users/list API
...
Prior to this, only the first 100 active/new/etc. users were available
via the `/admin/users/list` API. This change adds support for a
`page=#` querystring parameter so that *all* of the users can be
retrieved. Requests for pages past the last user result in an
empty-list response; requests for negative pages (or zero) just return
the first page.
Added tests to cover pagination.
2017-05-12 13:28:35 -07:00
1fb08d24d9
FIX: Latest onebox adds more attributes to links for security
2017-05-12 15:49:56 -04:00
8b9799507c
fix deploy problems due to renamed table
2017-05-12 15:17:25 -04:00
2d96a0785d
FEATURE: theme selection is now global per-user
2017-05-12 12:41:34 -04:00
47ce674798
PERF: bypass wizard check after 15 topics are created
2017-05-12 10:18:43 -04:00
b479aa0598
Set custom fields before saving in fabricator.
2017-05-12 14:01:31 +08:00
41711e53b7
Fix typo.
2017-05-12 10:31:31 +08:00
8eecd42856
FIX: Delete topic timer after completion.
2017-05-12 10:28:51 +08:00
55b61e9bea
rename topic_status_update to topic_timer
2017-05-11 18:27:53 -04:00
52ae63d5d7
FIX: when searching PMs also search group PMs
...
Users belonging to a group could not search for PMs unless explicitly added
to the PM unless admin
2017-05-11 15:59:03 -04:00
10f2db67ba
Add test for class_name in EmbedController
2017-05-11 15:16:16 -04:00
9b84cd832c
confirm in:private works for non staff
2017-05-11 15:06:45 -04:00
1019bbda46
FEATURE: set a timer to delete a topic
2017-05-11 12:52:29 -04:00
3ade46de0b
FIX: Don't send system message for new user of the month if disabled
2017-05-11 11:33:16 -04:00
9641d2413d
REFACTOR: upload workflow creation into UploadCreator
...
- Automatically convert large-ish PNG/BMP to JPEG
- Updated fast_image to latest version
2017-05-11 00:16:57 +02:00
7d9b5514ba
FIX: correctly invalidate theme css cache on scheme change
2017-05-10 15:47:11 -04:00
04b5516bf2
improve upload functionality
2017-05-10 15:47:11 -04:00
27362c5a4b
improve spec
2017-05-10 15:47:11 -04:00
bc0b9af576
FEATURE: support uploads for themes
...
This allows themes to bundle various assets
2017-05-10 15:47:11 -04:00
f709899a1d
Allow theme field object model to support uploads
2017-05-10 15:46:42 -04:00
4db76796b9
FEATURE: Setting to poll feeds more frequently
2017-05-10 14:30:12 -04:00
b57b635d30
FIX: Extract `div` tags within `span`s
2017-05-09 12:33:54 -04:00
c2829dce22
FIX: base sql vanishes after badge creation
2017-05-09 09:25:57 -04:00
55d3547540
Fix random test failure.
2017-05-09 11:27:05 +08:00
fc00032ec8
Check for 404 from spec rather than failure
2017-05-08 16:33:43 -04:00
addc85cd08
FIX: Don't let users edit wiki posts unless they can reply
2017-05-08 16:23:11 -04:00
009e120e13
FIX: Don't raise an error when the img attribute cannot be found
2017-05-08 15:35:31 -04:00
afe04b8bbb
FIX: Possible 500 error if category saved incorrectly
2017-05-08 15:17:58 -04:00
4f6e5fed2a
We don't need to raise an error when no post is present. Just noop.
2017-05-08 15:08:29 -04:00
96c59c5b82
FIX: Don't notify or return flags on system users
2017-05-08 13:13:35 -04:00
257c0dea70
Merge pull request #4852 from tgxworld/pull_the_plug_on_daily_mailing_list
...
Remove daily mailing mode option as it doesn't scale.
2017-05-08 09:10:46 -04:00
e89d0a6b20
FIX: importing a theme via file was broken
2017-05-08 12:03:24 +05:30
e61959e6a8
FIX: `CustomEmoji` may contain an invalid upload_id.
...
https://meta.discourse.org/t/white-screen-after-deleting-custom-emoji/61608
2017-05-05 14:53:38 +08:00
2b21e5ea7e
UX: Display translated group name for automatic groups.
2017-05-05 14:34:47 +08:00
71a266b673
Remove daily mailing mode option as it doesn't scale.
...
https://meta.discourse.org/t/daily-updates-option-for-mailing-list-mode/45029/14?u=tgxworld
2017-05-05 12:21:50 +08:00
441e0059af
Fix tests that was testing the wrong class.
2017-05-05 10:59:07 +08:00
777f1f0f47
FIX: Return a 404 if the auth session is not present
2017-05-04 15:35:24 -04:00
4ebbad991e
FIX: properly clean up related color schemes on delete
2017-05-04 14:03:17 -04:00
7a15b44ac3
rename on_remove, on_drop
2017-05-04 14:03:17 -04:00
6a6eed4ed2
DEV: column dropper class for cleaner removal of superflous columns
...
Also fixes issues during deploy cause target column was renamed in
theme_fields
2017-05-04 10:15:41 -04:00
4101db8b36
FIX: Invalid creation of `Theme` in wizard builder.
2017-05-04 11:44:23 +08:00
Sam
Jakub Macina
Guo Xiang Tan
Robin Ward
Régis Hanol
Blake Erickson
Rimian Perkins
Neil Lalonde
Jared Reisinger
Pat David
Arpit Jalan