74eaa5e7ec
FIX: For API consumption it's easier if the lings are the full URL
2019-05-31 14:04:54 -04:00
75fc126224
DEV: Change path for extra scss files in themes ( #7664 )
...
The preferred path is `/stylesheets/...`, to match core and plugins. The old `/scss/...` path will continue to function
2019-05-31 15:40:41 +01:00
03363d03e8
FEATURE: Load theme setting descriptions from theme locale files
...
Previously theme setting descriptions were defined in the `settings.yml` file like this:
```
setting_name:
default: "My Default Value"
description:
en: "English description"
fr: "French description"
```
This commit allows developers to store the localised descriptions in the theme locale files instead:
```
en:
theme_metadata:
description: Theme Description
settings:
setting_name: "The localised description for setting_name"
```
2019-05-31 14:49:59 +01:00
a0a2823536
DEV: Fix indentation
2019-05-31 10:19:19 -03:00
1db7fd6f9b
REFACTOR: topic-list model ( #7658 )
2019-05-31 13:15:45 +02:00
63264158cf
REFACTOR: user-posts-stream model ( #7657 )
2019-05-31 13:02:15 +02:00
3b8819f0ab
FEATURE: add support for defer topic functionality
...
This feature allows end users to "defer" topics by marking them unread
The functionality is default disabled. This also introduces the new site
setting default_other_enable_defer: to enable this by default on new user
accounts.
2019-05-31 15:44:35 +10:00
077dcc0642
FEATURE: add autocomplete discourse on full page search
...
This teaches chrome not to try autocompleting it.
2019-05-31 10:27:44 +10:00
2e0a40007b
FIX: Category topics should not be deletable via review queue
2019-05-30 16:43:23 -04:00
c169456ee5
DEV: Create new component to reify the user fields ( #7655 )
2019-05-30 16:17:16 -03:00
c4fa20d644
FIX: Broken test, also typoed property
2019-05-30 14:27:28 -04:00
5e89714f77
FIX: Linting via prettier
2019-05-30 13:58:06 -04:00
7a9e85b1d7
FIX: Don't show the "Flag to delete" message to staff
...
If they can't delete, flagging should not either.
2019-05-30 13:31:40 -04:00
7a21f78f8c
prettier ( #7653 )
2019-05-30 17:28:07 +02:00
0fbbff86ab
REFACTOR: rest model ( #7652 )
2019-05-30 17:11:17 +02:00
8196af165d
FIX: Add Chromebook detection.
2019-05-30 16:29:51 +03:00
f54a865846
DEV: refactor cleaning up of user export topics
2019-05-30 10:24:45 +05:30
bfb26b720b
FIX: the en_US locale depends on en
2019-05-30 08:46:43 +08:00
2fa8df7cd2
New: can_see_groups? method for better perf
2019-05-30 08:45:20 +08:00
e7ee556e87
Support multi-group user search
2019-05-30 08:45:20 +08:00
b24938b5ff
UX: Minor composer button alignment adjustments, simplification
2019-05-29 14:37:32 -04:00
227c45107d
FEATURE: Implement Onebox for posts including polls. ( #7539 )
2019-05-29 17:05:52 +02:00
c77bc525cb
REFACTOR: new-topic route ( #7639 )
2019-05-29 16:46:58 +02:00
ba66d6fd82
FIX: icon deprecation s/group/users ( #7638 )
2019-05-29 16:29:01 +02:00
034502af21
FIX: incorrectly removed moveTypes array ( #7637 )
2019-05-29 16:23:32 +02:00
bb6337d6c6
REFACTOR: choose-topic component ( #7636 )
2019-05-29 16:21:13 +02:00
b2fc80e4b7
REFACTOR: build-topic-selection mixin ( #7635 )
2019-05-29 16:09:19 +02:00
468cfa39f7
REFACTOR: rename-tag controller ( #7634 )
2019-05-29 15:58:12 +02:00
f2858e03c8
REFACTOR: preferences/email controller ( #7633 )
2019-05-29 15:53:42 +02:00
5e7e32510a
FIX: lookup should be done against locale of reference ( #7632 )
2019-05-29 15:45:44 +02:00
05206a61ab
FIX: displays text of asset-version changed modal ( #7631 )
2019-05-29 15:38:14 +02:00
a3938f98f8
Revert changes to `FileStore::S3Store#path_for` in f0620e7118.
...
There are some places in the code base that assumes the method should
return nil.
2019-05-29 18:39:07 +08:00
04fdada96a
annotate models
2019-05-29 14:26:24 +10:00
5c524ea8a4
FEATURE: introduce dedicated storage and DB constraints for anon users
...
Previously we used custom fields to denote a user was anonymous, this was
risky in that custom fields are prone to race conditions and are not
properly dedicated, missing constraints and so on.
The new table `anonymous_users` is properly protected. There is only one
possible shadow account per user, which is enforced using a constraint.
Every anonymous user will have a unique row in the new table.
2019-05-29 14:26:24 +10:00
f0620e7118
FEATURE: Support `[description|attachment](upload://<short-sha>)` in MD take 2.
...
Previous attempt was missing `post_uploads` records.
2019-05-29 09:26:32 +08:00
63292cecd9
PERF: Prefer joins over `IN ()` queries.
2019-05-29 09:00:15 +08:00
76569b2018
FIX: ensures post-small-action is using timezone to display dates
2019-05-29 08:45:28 +08:00
a93aa5bbce
Add "further reading for themes" step to wizard
2019-05-29 08:28:03 +08:00
43e33302e1
FIX: Position emoji-picker around d-editor.
2019-05-29 08:27:14 +08:00
7a08e23b4b
FIX: Bump search index version.
2019-05-29 08:20:59 +08:00
7c9fb95c15
Temporarily revert "FEATURE: Support `[description|attachment](upload://<short-sha>)` in MD. ( #7603 )"
...
This reverts commit b1d3c678ca
2019-05-28 16:37:01 -04:00
f3c07e27d9
FIX: correct translations for logs error rate notice ( #7622 )
...
The problem here is that hour and minute were passed to the %{duration} variable which made them impossible to translate in other languages.
I wonder if it's worth having 2 almost identical translations just for "reached" and "exceeded"? Perhaps we could combine them in one copy?
2019-05-28 22:10:51 +03:00
91ff8684fd
FIX: Use the right property for post ID.
2019-05-28 22:00:58 +03:00
67d8ceedf1
Remove unused variable
2019-05-28 14:31:52 -04:00
c57ab12238
UX: Move preview button to bottom right of mobile composer
2019-05-28 14:19:33 -04:00
bc14452585
FIX: ensures events have access to correct context ( #7621 )
2019-05-28 19:40:28 +02:00
b1d3c678ca
FEATURE: Support `[description|attachment](upload://<short-sha>)` in MD. ( #7603 )
2019-05-28 11:18:21 -04:00
9bdfaa195e
FIX: We shouldn't memoize the last time something is read
2019-05-28 10:51:18 -04:00
028121b95b
FIX: delete system generated message when user_export record is deleted ( #7595 )
...
FIX: system generated message for user export should be closed by default
2019-05-28 16:38:41 +05:30
6decdfce5c
DEV: reduces memory footprint of tests - step 1 ( #7591 )
2019-05-28 12:15:12 +02:00
07b80d491b
FIX: Refresh automatic groups after inviting moderators.
2019-05-28 17:19:34 +08:00
0d9fdbf8fe
FEATURE: Allow import of hidden site settings ( #7601 )
...
* Allow optional import of hidden site settings
* Always import hidden settings
2019-05-28 16:20:18 +10:00
315a38e0e3
FEATURE: Allow running message_bus in a different redis instance ( #7616 )
...
Adds `DISCOURSE_MESSAGE_BUS_REDIS_ENABLED` env var, that when set
to true, will allow Discourse to connect to a different redis
instance for MessageBus needs.
When enabled you can configure the same env vars user for redis,
but prefixed by `MESSAGE_BUS`, eg:
`DISCOURSE_MESSAGE_BUS_REDIS_HOST`
2019-05-28 15:52:43 +10:00
7429700389
FIX: ensure we can download maxmind without redis or db config
...
This also corrects FileHelper.download so it supports "follow_redirect"
correctly (it used to always follow 1 redirect) and adds a `validate_url`
param that will bypass all uri validation if set to false (default is true)
2019-05-28 10:28:57 +10:00
b85fa62882
FIX: Don't send replies to flags that are ignored by expiry
...
The `AutoQueueHandler` will ignore really old flags. In that case, don't
notify the user that the moderator is looking into it. They probably
never saw it because it didn't meet the reviewable minimum priority.
2019-05-27 17:24:36 -04:00
03b4131933
FIX: When deleting a user via queued posts, block urls, ip and email
2019-05-27 15:54:01 -04:00
d26c4509ea
FIX: Adding a user to a group twice under concurrency
...
This prevents an error from being raised / logged.
2019-05-27 15:42:40 -04:00
dfcc2e7ad8
Revert "FEATURE: Send notification when member was accepted to group. ( #7503 )"
...
This reverts commit 42c82d544e
2019-05-27 15:19:59 -04:00
c108131ad4
Revert "Fix JS error in group summary notification message"
...
This reverts commit b1268e00b8
2019-05-27 15:19:38 -04:00
b1268e00b8
Fix JS error in group summary notification message
2019-05-27 14:54:51 -04:00
d95a68b837
FEATURE: When suspending a user, allow the Delete + Replies action
...
Previously you could only delete the post
2019-05-27 12:27:16 -04:00
192562745f
DEV: uses focus helper for d-editor tests ( #7610 )
2019-05-27 17:31:11 +02:00
42c82d544e
FEATURE: Send notification when member was accepted to group. ( #7503 )
2019-05-27 17:28:41 +03:00
395f0ca126
FIX: attempts to prevent stacked-chart from being cut off ( #7608 )
2019-05-27 15:43:27 +02:00
e284b6e075
FIX: Update tags on change. ( #7581 )
2019-05-27 16:04:26 +03:00
d93f753b17
apply prettier on gigantic find and replace ( #7604 )
2019-05-27 10:42:53 +02:00
bfea922167
DEV: global s/this.get\("(\w+)"\)/this.$1 ( #7592 )
2019-05-27 10:15:39 +02:00
da39d66e83
DEV: Improve support for plugins. ( #7332 )
...
* DEV: Allow NewPostManager handlers handle PMs.
* DEV: Add custom fields topic option to PostCreator.
* DEV: Add topic_id to serializer data.
* DEV: Wrap topic title from notification item in a span.
2019-05-25 16:53:03 +03:00
6398ded798
Revert "FIX: ensures selection is lookedup into async content ( #7586 )"
...
This reverts commit c238f0d223
2019-05-25 15:50:41 +02:00
d6aacadc4e
make 🤖 happy
2019-05-25 00:32:29 +02:00
4b796eebe0
UX: Try tweaking how soon images are lazily loaded
2019-05-24 15:52:48 -04:00
89b84651c3
Migrate score settings to use sensitivities
...
We hide scores so these settings no longer made sense.
2019-05-24 15:44:24 -04:00
fad5d9c49b
Use an Enum class for the Reviewable Priority Site Setting
2019-05-24 15:44:24 -04:00
dbd14a805c
UX: Wrap long names on user admin page
2019-05-24 13:39:16 -04:00
963f6fbd40
Add icon for "Move to Inbox" footer button
2019-05-24 11:53:14 -04:00
e20c30987c
FEATURE: detect theme errors and catch them ( #7589 )
...
* FEATURE: detect theme errors and catch them
* Bump COMPILER_VERSION
* Feedback
* Override eslint no console for one line
* Can't use our ajax method
* remove emoji from translation file
2019-05-24 17:25:55 +03:00
049561ac49
FIX: introduces onSelectAny (regroup onSelect and onSelectNone) ( #7594 )
2019-05-24 13:11:33 +02:00
f4a471f0eb
FIX: Correctly cache hash of extra translations
2019-05-24 11:38:26 +02:00
c1e9a70d59
FIX: Fallback locale was not available for extra translations
...
Translations from fallback locales were not sent to the client
for admin_js and wizard_js.
2019-05-24 11:38:26 +02:00
fd0eff6ce3
Revert "FIX: Add missing unique index on user_id for user_profiles."
...
Oops `user_id` is the primary key.
This reverts commit 5478aa63ab
2019-05-24 12:58:36 +08:00
5aed463649
Update annotation.
2019-05-24 12:58:26 +08:00
5478aa63ab
FIX: Add missing unique index on user_id for user_profiles.
2019-05-24 12:11:49 +08:00
4f5c9bb8d3
DEV: Prefer `create!` over `create`.
...
We want to know when stuff fails.
2019-05-24 12:07:22 +08:00
1fbe078ae0
FIX: Undefined method when serializing a user
...
Apparently is is possible to have a user without a user_profile. This
fix will return nil for any user_profile fields during serialization
(like the after delete web hook) instead of blowing up.
2019-05-23 19:44:55 -06:00
1babc3bec6
Follow up to 3388872991.
2019-05-24 09:02:39 +08:00
3388872991
UX: Separate section for 2FA settings, more consistent layout
2019-05-24 08:58:12 +08:00
648af78298
FIX: Linting
2019-05-23 12:16:45 -04:00
f73988acd2
Remove unused computed property.
2019-05-23 12:06:18 -04:00
e74cd54fc6
REFACTOR: Replace score bonuses with low/med/high priorities
...
We removed score from the UX so it makes more sense to have sites set
priorities instead of score bonuses.
2019-05-23 11:54:45 -04:00
30961dd875
Revert "UX: Prevent long names from overflowing on user admin"
...
This reverts commit 6207b71c36
2019-05-23 16:56:30 +02:00
943fdc1762
make eslint happy
2019-05-23 12:51:40 +02:00
0cc81f95a5
FIX: popover should use target when no data attributes
2019-05-23 12:41:36 +02:00
ca6c919299
DEV: Remove unused variable.
...
Follow up to df1e6eed5a07f49eeda4c0bbd8c63d539aefdb3b..
2019-05-23 16:42:42 +08:00
f0a776f05d
FIX: allows scrolling when a lot of categories are used ( #7590 )
2019-05-23 10:04:53 +02:00
df1e6eed5a
FIX: Pull hotlinked images for lightbox links as well.
2019-05-23 15:44:37 +08:00
553ffbfcb5
FEATURE: add OpenGraph data to /login page
2019-05-23 07:03:01 +05:30
954293655f
FEATURE: rake posts:destroy_old_user_data_exports
...
Historically we would keep the user data export posts around but delete
the uploads.
This leaves a lot of broken uploads in the system.
This rake task allows us to clean up old mess.
2019-05-23 11:11:37 +10:00
6207b71c36
UX: Prevent long names from overflowing on user admin
2019-05-22 15:10:09 -04:00
9f6af5f8a7
UX: Prevent long names from overflowing on user profiles
2019-05-22 15:03:50 -04:00
881c832a2f
UX: Remove padding from empty row
2019-05-22 14:27:17 -04:00
ca03baf2b2
UX: Hide pending score statuses
2019-05-22 11:26:17 -04:00
cf63a9bb53
FIX: exception when pressing backspace on empty selection ( #7587 )
2019-05-22 17:18:46 +02:00
c238f0d223
FIX: ensures selection is lookedup into async content ( #7586 )
2019-05-22 17:11:19 +02:00
58f72cd439
Remove duplicate translations
2019-05-22 16:15:22 +02:00
40c903ec23
FIX: ie11 exception on new category popup ( #7585 )
2019-05-22 15:17:28 +02:00
e224100023
FIX: Don't convert :) into Emoji when emojis or emoji shurtcuts are disabled
2019-05-22 11:44:39 +02:00
d9413a61d2
PERF: move crawl_topic_links to the low queue
...
Crawling topic links can be somewhat delayed no need to run it in the default
queue.
2019-05-22 10:18:49 +10:00
0ed1cfd8d9
FIX: ensures we have an elementFromPoint before using it ( #7583 )
2019-05-21 21:26:54 +02:00
793915fe6a
DEV: should ignore missing post uploads when a user export destroyed
2019-05-21 13:32:36 +05:30
236adc9ccb
FIX: shows parent category name in title anchor ( #7576 )
2019-05-21 08:33:22 +02:00
0b5924d61e
Refactor keyboard shortcuts modal to fix RTL locales ( #7545 )
...
* Refactor keyboard shortcuts modal to fix RTL locales
* Feedback
* Remove lowercase modifier keys
2019-05-21 06:39:32 +03:00
bc8c77723e
FIX: puts focus-event at application level ( #7568 )
...
Also attempts to use simpler and newer APIs
2019-05-20 13:48:03 +02:00
b788948985
FEATURE: English locale with international date formats
...
Makes en_US the new default locale
2019-05-20 13:47:20 +02:00
9bbf421125
FIX: better node check for clickoutside in widgets ( #7573 )
2019-05-20 12:45:33 +02:00
0ddfeb9c64
FIX: ensures mousetrap is reset with the application ( #7569 )
2019-05-20 10:45:31 +02:00
14bae6d52d
Make `email_excerpt` method take an optional `post` param ( #7570 )
...
The spoiler alert plugin replaces spoiler text found in email excerpts with posts URL, which means it needs to have a reference to the post it's processing.
This change makes `email_excerpt` accepts an optional post param, which calls `PrettyText.format_for_email` which then triggers the `reduce_cooked` event that the plugin subscribes to.
2019-05-20 10:04:23 +02:00
7eea2e35e4
Upload image preview needs width on desktop
2019-05-17 11:25:35 -04:00
b05d7042ae
FIX: prevents events on toolbar when in form ( #7567 )
...
If a button is not of type button, pressing enter inside an `<input>` inside a `<form>` without the action attribute will trigger the first available `<button>` as most browsers default the type of an unspecified button to submit.
This commit also prevents d-editor-modal to be filled when it's hidden.
2019-05-17 11:14:09 +02:00
148bfc9be5
DEV: Simplify client and server side code to support removing tags.
...
Follow up to 834c86678f
2019-05-17 16:39:20 +08:00
5666316285
FEATURE: Display 'last updated' on dashboard, improve release notes link ( #7560 )
2019-05-17 15:42:45 +10:00
834c86678f
FIX: Missing post revision when editing the first post.
2019-05-17 12:54:27 +08:00
e2444e0d31
DEV: Fix another frozen string error.
2019-05-17 10:07:37 +08:00
25137554ed
FIX: _.include is no longer imported from lodash
...
Instead use toArray and indexOf which is also clearer
2019-05-17 08:58:39 +10:00
80b3560050
IE11: Login form needs full flex shorthand
2019-05-16 14:07:49 -04:00
225593d445
FIX: Small tweak to percentiles based on feedback
2019-05-16 13:45:36 -04:00
ad4d01233b
DEV: attempts to make d-editor tests more resilient ( #7556 )
2019-05-16 14:42:01 +02:00
244c03573a
FIX: btn class was duplicated on admin-menu-buttons ( #7555 )
2019-05-16 14:37:53 +02:00
0c6ebe66ce
EXPERIMENTAL: clicks outside seem unreliable with absolute nodes ( #7557 )
2019-05-16 14:37:37 +02:00
1afe6d0aee
FIX: share-and-invite modal was too narrow ( #7559 )
2019-05-16 14:37:19 +02:00
0e677daaee
FIX: include posts with data-orig-src attribute in have_uploads scope query.
2019-05-16 16:39:38 +05:30
56ada8374f
DEV: wrap find_missing_uploads method in distributed mutex
...
And skip posts with deleted topics.\ne8fafbc123170dd1f7d2a8adea4e7810585d3e76
2019-05-16 15:17:53 +05:30
a5a4f9dc1a
DEV: make prettier happy
...
(cc @jjaffeux)
2019-05-16 11:38:47 +02:00
d47bf8b6c4
SECURITY: updates lodash from 1.3.0 to 4.17.5 ( #7546 )
2019-05-16 10:34:19 +02:00
a36fe019bb
DEV: Fix race condition when enqueuing edit wiki-ed notification.
2019-05-16 13:48:46 +08:00
636b75fa16
REFACTOR: remove duplicate reject loop and implicit return
...
e8fafbc123
2019-05-16 10:04:04 +05:30
227bedebf7
DEV: Fix modifying a frozen string.
2019-05-16 11:30:31 +08:00
7cd1067f3d
FIX: Select-kit too narrow in topic timer
2019-05-15 17:58:40 -04:00
501bee56b7
Make prettier happy
2019-05-15 23:46:50 +02:00
7eea55d564
PERF: remove "new posts" stat from summary email
...
It performs horribly and isn't a personalized stat like the others.
2019-05-15 16:28:21 -04:00
db89722a98
UX: ignore leading/trailing whitespaces in site settings search
2019-05-15 22:22:20 +02:00
b9fcb2bcdf
DEV: Add before button hook in post-menu. ( #7550 )
2019-05-15 22:48:23 +03:00
0ef25f7a66
prettier
2019-05-15 13:35:58 -04:00
a3f6c7d6af
REFACTOR: Remove table layout from modals, clean up styles ( #7549 )
2019-05-15 13:26:25 -04:00
9a17b19636
FIX: don't hide back button at the bottom of timeline ( #7544 )
2019-05-15 19:02:48 +02:00
fc5bb39096
FIX: Do not send duplicate alerts for the same post ( #7476 )
2019-05-15 18:47:36 +02:00
1299c94a52
FIX: Make serverside and clientside omniauth origin redirects consistent
...
Previously external domains were allowed in the client-side redirects, but not the server-side redirects. Now the behavior is to only allow local origins.
2019-05-15 12:40:51 +01:00
1d3375b176
FEATURE: Preserve notifications levels when splitting topics. ( #7494 )
2019-05-15 17:29:29 +10:00
42b10a646d
FIX: return 404 only if upload url also not internal.
2019-05-15 02:06:54 +05:30
e0fe01925e
FIX: make frozen string mutable in incoming_domain
2019-05-14 17:44:53 +02:00
d127119549
REFACTOR: user-selector take 2 ( #7540 )
2019-05-14 09:43:29 +02:00
624184560e
PERF: improve performance of publish_notifications_state
...
User.publish_notifications_state is called every time a notification is
created, this can become a very critical code path.
On some heavy notification related sites this can be a major CPU user on PG
This index makes it much cheaper to publish notification state, cause a
simple index lookup does the trick.
2019-05-14 16:02:55 +10:00
6f747c6b71
FIX: don't allow username to be changed to same as password
...
We were blocking user registrations with same username and password,
but allowing usernames to be changed to be same as password later.
Also disallow names to be the same as password.
2019-05-13 16:43:40 -04:00
bbab60fa9b
FIX: Don’t try to delete inactive moderators
...
follow-up to 6d77156a
2019-05-13 21:44:03 +02:00
7707d5db2d
Revert "REFACTOR: user-selector ( #7529 )"
...
This reverts commit 9a56df89f0
2019-05-13 19:39:30 +02:00
a2b1789c3e
FIX: do not log username change if the save process was unsuccessful
2019-05-13 22:20:27 +05:30
fb1da53dff
FIX: Issue with incorrect heights when cloaking plugin content in posts
...
We noticed this with the house ads plugin. It inserted content after a
post, which was not taken into account when calculating and memoizing
the height of the element.
Co-authored-by: nlalonde
Co-authored-by: pmusaraj
2019-05-13 11:29:21 -04:00
7326ddea6d
REFACTOR: tags mixin ( #7533 )
2019-05-13 17:05:21 +02:00
b8db702a02
REFACTOR: admin-user-index route ( #7534 )
2019-05-13 17:04:41 +02:00
717aa764b6
FIX: more efficient topic-footer-button-api ( #7535 )
2019-05-13 17:04:24 +02:00
750c125707
DEV: Include foreign keys in model annotations
2019-05-13 15:53:42 +01:00
607c671003
Fix string literal when switching theme in dev env
2019-05-13 10:25:51 -04:00
f1b0782624
UI: Adjust footer nav bar size in iOS app
2019-05-13 10:25:51 -04:00
1bff81419e
DEV: Update annotations
2019-05-13 15:24:24 +01:00
53d2232731
FIX: Remove trailing slash from topic URL
...
this lead to duplicate slashes in concatenated URLs
2019-05-13 14:51:45 +02:00
df18243827
FIX: prevents exception if report doest define filters ( #7532 )
2019-05-13 13:34:28 +02:00
9a56df89f0
REFACTOR: user-selector ( #7529 )
2019-05-13 13:03:12 +02:00
25b39b86ae
FIX: reload the user record instead of fetching via email
2019-05-13 15:16:53 +05:30
e64ed9dbc1
REFACTOR: edit-category controller ( #7527 )
2019-05-13 11:30:32 +02:00
64c117519e
Fix modifying frozen strings errors take 3.
2019-05-13 16:45:23 +08:00
74989783da
Fix modifying frozen strings error in `OneboxController`.
2019-05-13 16:25:52 +08:00
b584e30902
Fix modifying frozen strings error take 2.
2019-05-13 16:23:45 +08:00
9b75320d63
FIX: track mutations on topic edit category-chooser only on select ( #7528 )
2019-05-13 10:22:28 +02:00
d643294c9d
FIX: delete duplicate invites earlier in the process
...
There was a race condition when 2 invites existed for 1 user where in some
cases data from both invites would be used for the redeem. Depending on DB
ordering.
Fix is to delete duplicate invites earlier in the process prior to
`redeem_from_email` being called.
2019-05-13 17:42:39 +10:00
81c329fbb8
FIX: Customizing missing pluralized translations didn't work
2019-05-13 09:36:05 +02:00
d369b84ced
Fix modifying frozen strings error.
2019-05-13 14:31:20 +08:00
8165ceb320
Make rubocop happy.
2019-05-13 09:55:44 +08:00
30990006a9
DEV: enable frozen string literal on all files
...
This reduces chances of errors where consumers of strings mutate inputs
and reduces memory usage of the app.
Test suite passes now, but there may be some stuff left, so we will run
a few sites on a branch prior to merging
2019-05-13 09:31:32 +08:00
a859ddc77e
Improve theme/component delete modal warning
2019-05-10 14:14:12 -04:00
c093fa0376
PERF: reduces cpu/memory consumption of sk in some cases ( #7525 )
2019-05-10 17:12:10 +02:00
643c75c419
FIX: Don't increment version if the reviewable operation fails
...
In fact, roll back the entire operation in the database.
2019-05-10 09:53:25 -04:00
abbe812a0d
FIX: Correct CSS for instagram video play icon
2019-05-10 10:46:07 +01:00
4096d559b5
REFACTOR: user-stream model ( #7515 )
2019-05-10 10:05:43 +02:00
a85b7feef4
REFACTOR: composer controller ( #7516 )
2019-05-10 10:05:29 +02:00
7aedc92a35
REFACTOR: login-controller ( #7514 )
2019-05-10 10:05:11 +02:00
63a3caa516
FIX: Don't display option for users to flag and notify a bot.
2019-05-10 10:05:03 +08:00
0ab6c6e24e
PERF: speed up spec suite, avoid featuring topics
...
Before: 6:05
After: 5:42
Featuring topics for `list/categories` is a very expensive operation that
happened each time we created a topic. This introduces a test only bypass
2019-05-10 11:37:53 +10:00
34684af195
FIX: Show error message if message exists
2019-05-09 22:12:51 +02:00
b380ed5282
FEATURE: Claim Reviewables by Topic
...
This is a feature that used to be present in discourse-assign but is
much easier to implement in core. It also allows a topic to be assigned
without it claiming for review and vice versa and allows it to work with
category group reviewers.
2019-05-09 13:40:36 -04:00
8dfb15a2e5
FIX: Do not show self edits in Post Edits report. ( #7510 )
2019-05-09 20:39:17 +03:00
ea3004ef11
UX: Save scroll position in tags topic list. ( #7511 )
2019-05-09 20:39:03 +03:00
2a45933ff2
FIX: reduce iPad app nav padding
2019-05-09 10:25:22 -04:00
c06b00a54e
FIX: Hide Uncategorized in site menu when disabled. ( #7509 )
2019-05-09 14:08:10 +03:00
4e91839c97
FIX: Remove default val for colors step if a default theme has been set.
...
Running through the wizard after a default theme has been configured
will always revert the default theme to the light theme.
2019-05-09 17:25:09 +08:00
977ffa20f4
FIX: variable is different from key ( #7512 )
2019-05-09 10:03:33 +02:00
427979e7e5
FEATURE: use full screen login by default for social login methods ( #7481 )
2019-05-09 10:03:01 +05:30
8ec1f8cf07
DEV: Correct naming convention for JS file.
2019-05-09 10:18:29 +08:00
8c07c272f2
make rubocop happy.
2019-05-09 05:25:44 +05:30
87cd4701b8
FEATURE: option to skip posts with ignored missing uploads
2019-05-09 05:11:15 +05:30
e6cfc584d0
Revert "FIX: frozen string exception ( #7506 )"
...
This reverts commit c4b7fb2754
2019-05-08 17:27:09 +02:00
497c0ba418
Revert "FIX: frozen string exception ( #7505 )"
...
This reverts commit 2938e3f033
2019-05-08 17:27:03 +02:00
24ca074f3f
FIX: short description title on client side when empty description
...
follow-up 77af097c
2019-05-08 17:07:12 +02:00
e84531a6a6
FIX: Correctly clear theme stylesheet cache when changing color scheme
2019-05-08 16:02:55 +01:00
54c2f24ee9
REFACTOR: composer model ( #7499 )
2019-05-08 16:53:12 +02:00
2938e3f033
FIX: frozen string exception ( #7505 )
...
Initial backtrace:
```
/var/www/discourse/app/mailers/user_notifications.rb:554:in `send_notification_email'
/var/www/discourse/app/mailers/user_notifications.rb:459:in `notification_email'
/var/www/discourse/app/mailers/user_notifications.rb:318:in `user_private_message'
```
* this might fail too
2019-05-08 16:52:38 +02:00
4aaee7ee35
REFACTOR: change-timestamp controller ( #7498 )
2019-05-08 16:26:51 +02:00
c4b7fb2754
FIX: frozen string exception ( #7506 )
...
Initial backtrace:
```
/var/www/discourse/app/models/incoming_domain.rb:29:in `to_url'
/var/www/discourse/app/models/incoming_link.rb:83:in `referer'
/var/www/discourse/app/models/incoming_link.rb:106:in `referer_valid'
```
2019-05-08 16:25:54 +02:00
b409dab77f
Rename `flags_default_topics` to `reviewable_default_topics`
...
This functionality regressed with the reviewable update. I took the
opporunity to rename it when fixing it for clarity.
2019-05-08 10:07:10 -04:00
77af097ce0
FIX: add short description to title on client side
2019-05-08 15:03:33 +02:00
b717e23ceb
FIX: Dynamically adjust scale when rendering wizard canvases
...
This was a typo in fd0de64
2019-05-08 13:14:28 +01:00
861023f0d6
FIX: Skip attachments in click track.
2019-05-08 11:55:31 +03:00
f04518fdf9
DEV: Reduce number of jobs enqueued.
...
Apply code review suggestion from
405ba00c08
2019-05-08 15:58:08 +08:00
405ba00c08
FEATURE: Create notifications on wiki edits for watching users.
...
* Moves creation of notification into background job.
2019-05-08 15:31:10 +08:00
46ea69a73c
UX: Initialize client side category model with right search_priority.
...
This is strictly a UX change since the default value of the column is 0.
2019-05-08 14:16:20 +08:00
5af7c90bab
FEATURE: Hide Reviewable scores, change score filter to Priority
...
We found score hard to understand. It is still there behind the scenes
for sorting purposes, but it is no longer shown.
You can now filter by minimum priority (low, med, high) instead of
score.
2019-05-07 14:05:23 -04:00
5b5b5a5931
FIX: return an error if a user tries to whisper
...
This commit fixes a bug where a user creates a whisper post via the api
but is posted as a regular message because they don't have access to
whisper. Now a 403 unauthorized will be returned instead of the whisper
param just being ignored for regular users. Staff users should not be
affected by this change.
https://meta.discourse.org/t/a-whisper-is-posted-as-a-message-if-the-user-is-not-staff-moderator-admin-when-using-the-api/116601
2019-05-07 11:42:26 -06:00
626534ad94
FIX: lighten instead of adding transparency to consolidated pageviews ( #7495 )
2019-05-07 18:14:13 +02:00
0a66065774
FIX: Move default options that were in the bufferedRender function. This will fix shortcut navigation for discourse-assign ( #7497 )
2019-05-07 12:25:10 -03:00
e20f13ebb7
fix css of prev and next page links, move them to bottom of page ( #7465 )
...
Thanks 👍
2019-05-07 17:04:27 +02:00
446ec1b44a
Set input and textarea font size to 16px on iOS ( #7480 )
2019-05-07 10:44:43 -04:00
98a75906c8
FIX: Close topics deleted by users and ensure topic stubs are destroyed. ( #7430 )
2019-05-07 16:25:52 +03:00
ed70595314
UX: add information about the use of permalinks
2019-05-07 17:13:26 +05:30
71fb8a4195
DEV: Fix failing click-track tests.
2019-05-07 13:54:12 +03:00
4bbb34f7cb
REFACTOR: admin-user ( #7475 )
2019-05-07 10:53:21 +02:00
f73ed45429
REFACTOR: color-scheme model ( #7477 )
2019-05-07 10:51:52 +02:00
9507eff927
REFACTOR: resumable-upload ( #7474 )
2019-05-07 10:51:11 +02:00
4ff1195537
FEATURE: Use Beacon API for tracking clicks. ( #7483 )
2019-05-07 16:37:43 +10:00
cf99431c18
Fix like and flag button count alignment ( #7487 )
2019-05-07 16:34:29 +10:00
abbc639e0d
FIX: Only unregister service workers that belongs to Discourse.
2019-05-07 13:08:06 +08:00
03169401ff
UX: correct order of site statistics on /about page
2019-05-07 09:50:41 +05:30
451f7842ff
DEV: More `send` -> `public_send`.
2019-05-07 10:05:58 +08:00
cac80cdc3b
DEV: more send -> public_send changes
...
This is a work in progress commit for more send to public_send conversions
Also adds some comments for cases where we need to keep send
2019-05-07 11:58:06 +10:00
61cc0f8c5f
Follow up to 152238b4cf.
2019-05-07 09:57:27 +08:00
152238b4cf
DEV: Prefer `public_send` over `send`.
2019-05-07 09:33:21 +08:00
9be70a22cd
DEV: introduce new API to look up dynamic site setting
...
This removes all uses of both `send` and `public_send` from consumers of
SiteSetting and instead introduces a `get` helper for dynamic lookup
This leads to much cleaner and safer code long term as we are always explicit
to test that a site setting is really there before sending an arbitrary
string to the class
It also removes a couple of risky stubs from the auth provider test
2019-05-07 11:00:30 +10:00
47995d2d89
FIX: Your own likes were missing on posts
2019-05-06 20:03:50 -04:00
31e100530f
FEATURE: Flag count in post menu
...
This change shows a notification number besides the flag icon in the
post menu if there is reviewable content associated with the post.
Additionally, if there is pending stuff to review, the icon has a red
background.
We have also removed the list of links below a post with the flag
status. A reviewer is meant to click the number beside the flag icon to
view the flags. As a consequence of losing those links, we've removed
the ability to undo or ignore flags below a post.
2019-05-06 16:13:31 -04:00
5e546ba7d1
Standardize viewport rules for mobile and desktop
...
Also removes`maximum-scale` on non-mobile devices, better for accessibility.
2019-05-06 10:28:29 -04:00
e2e72f4e8e
DEV: rename ReadOnly module to ReadOnlyHeader
2019-05-06 16:07:49 +02:00
33e06dd796
FIX: Make select all and below skip small actions. ( #7425 )
2019-05-06 16:22:11 +03:00
a40dcbde9b
FIX: Do not move hidden post actions. ( #7424 )
...
Hidden (staff-only) post actions are whisper posts with no content, that
are later transformed by the client into post actions (discourse-assign
uses this).
2019-05-06 16:21:42 +03:00
8217d5be78
UX: Switch mobile header back for 5s when notification comes in.
2019-05-06 16:58:25 +08:00
f8eddd40ad
PERF: remove avg_time calculations and regular jobs from posts and topics
...
After careful analysis of large data-sets it became apparent that avg_time
had no impact whatsoever on "best of" topic scoring. Calculating avg_time
was a very costly operation especially on large databases.
We have some longer term plans of introducing other weighting that is read
time based into our scoring for "best of" and "top" topics, but in the
interim to stop a large amount of work that is not achieving any value we
are removing the jobs.
Column removal will follow once we decide on a new replacement metric.
2019-05-06 15:59:01 +10:00
ba3cf7109c
DEV: Remove unused lines of code.
2019-05-06 13:48:51 +08:00
267d129f38
FEATURE: only scroll to bottom for discobot
...
Non discobot replies on PMs triggering scroll cause confusion.
2019-05-06 10:55:58 +10:00
99a2a769d4
FIX: Conflict error (version was already used)
2019-05-03 16:36:37 -04:00
e8fafbc123
List and restore missing post uploads from S3 inventory.
2019-05-04 01:16:20 +05:30
d82da69c2c
FIX: Fail gracefully if username parameter is missing when creating user
2019-05-03 17:17:06 +01:00
15c9b00307
FEATURE: Show edit indicator on review queue
...
If a flagged post has edits, show the pencil icon and pop up the history
window when clicked.
2019-05-03 11:21:33 -04:00
5f78bbebe9
FIX: forces a reload of emoji list if clicked on more ( #7473 )
...
This is a bit hacky but it's much more simple and reliable than many other solutions and doesnt involve having to manage some variable state.
2019-05-03 16:11:03 +02:00
0d41d58d27
FIX: add ReadOnly hear to /srv/status
2019-05-03 12:21:07 +02:00
Robin Ward
David Taylor
romanrizzi
Joffrey JAFFEUX
Sam Saffron
Bianca Nenciu
Arpit Jalan
Daniel Waterworth
Kris
Bianca Nenciu
Guo Xiang Tan
Penar Musaraj
Dan Ungureanu
Osama Sayegh
Ralph Rooding
Rafael dos Santos Silva
Régis Hanol
Gerhard Schlager
Blake Erickson
Vinoth Kannan
Neil Lalonde
Maja Komel
Saurabh Patel
Joe