bd034485d7
SECURITY: Disable MessageBus::Diagnostics.
...
MessageBus::Diagnostics allows anyone with access to carry out certain
operations that may result in a denial of service. The impact of this is
greater on multisiite clusters.
2021-12-17 14:45:26 +08:00
e6480bbb04
DEV: Remove iOS 9.3 polyfills ( #15343 )
...
We're on iOS 15.2 now. 🙂
2021-12-17 02:47:13 +01:00
5eab90e0f8
FIX: Incorrect header offset calculation ( #15341 )
...
I somehow changed the sign before committing #15221 🤦
2021-12-17 09:46:31 +08:00
2114dd53ef
DEV: Tweak smooth-scroll polyfill speed ( #15342 )
...
The polyfill was scrolling much slower than browser that actually support the feature. See: https://github.com/iamdustan/smoothscroll/issues/13
This commit is based on 1baba758a7
2021-12-17 02:38:04 +01:00
60851037d8
DEV: Remove unused composer editor preview sync ( #15322 )
2021-12-16 17:18:54 -05:00
d9c511f734
DEV: Refactor animation for invalid inputs in wizard ( #15334 )
2021-12-16 17:17:36 -05:00
a9a9dc64fe
Build(deps): Bump fastimage from 2.2.5 to 2.2.6 ( #15338 )
...
Bumps [fastimage](https://github.com/sdsykes/fastimage ) from 2.2.5 to 2.2.6.
- [Release notes](https://github.com/sdsykes/fastimage/releases )
- [Changelog](https://github.com/sdsykes/fastimage/blob/master/CHANGELOG )
- [Commits](https://github.com/sdsykes/fastimage/compare/v2.2.5...v2.2.6 )
---
updated-dependencies:
- dependency-name: fastimage
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-12-16 23:04:39 +01:00
ca0eb8041d
PERF: Prefabricate more parts of users_controller_spec ( #15335 )
2021-12-16 13:36:49 -06:00
92bff4df93
FIX: Add smooth scrolling polyfill ( #15333 )
2021-12-16 14:07:52 -05:00
48b7696dbc
DEV: Remove jQuery animate calls ( #15321 )
...
Affects j/k navigation and PM interaction with @discobot.
2021-12-16 11:00:09 -05:00
9365c4b364
DEV: make sure we handle staged users correctly in DiscourseConnect ( #15320 )
...
Some time ago, we made this fix to external authentication – https://github.com/discourse/discourse/pull/13706 . We didn't address Discourse Connect (https://meta.discourse.org/t/discourseconnect-official-single-sign-on-for-discourse-sso/13045 ) at that moment, so I wanted to fix it for Discourse Connect as well.
Turned out though that Discourse Connect doesn't contain this problem and already handles staged users correctly. This PR adds tests that confirm it. Also, I've extracted two functions in Discourse Connect implementation along the way and decided to merge this refactoring too (the refactoring is supported with tests).
2021-12-16 19:44:07 +04:00
c46b351888
DEV: Make i18n spec ignore these test-only settings ( #15329 )
...
Fixes flakyness introduced in #15324
2021-12-16 15:49:20 +01:00
81b0ac1766
FIX: uses new format for search tag endpoint to prevent issues ( #15328 )
...
Due to our usage of fixtures, backend changes didn't get catch.
2021-12-16 11:57:47 +01:00
2a4df93b8e
FEATURE: Allow to modify topic-backed static pages ( #15324 )
...
A plugin API that allows customizing existing topic-backed static pages, like:
faq, tos, privacy (see: StaticController) The block passed to this
method has to return a SiteSetting name that contains a topic id.
```
add_topic_static_page("faq") do |controller|
current_user&.locale == "pl" ? "polish_faq_topic_id" : "faq_topic_id"
end
```
You can also add new pages in a plugin, but remember to add a route,
for example:
```
get "contact" => "static#show", id: "contact"
```
2021-12-16 04:24:11 +01:00
ad4faf637c
UX: Always show avatar on mobile topic lists ( #15323 )
2021-12-15 20:31:03 -05:00
7039046d9e
Build(deps-dev): Bump minitest from 5.14.4 to 5.15.0 ( #15326 )
...
Bumps [minitest](https://github.com/seattlerb/minitest ) from 5.14.4 to 5.15.0.
- [Release notes](https://github.com/seattlerb/minitest/releases )
- [Changelog](https://github.com/seattlerb/minitest/blob/master/History.rdoc )
- [Commits](https://github.com/seattlerb/minitest/compare/v5.14.4...v5.15.0 )
---
updated-dependencies:
- dependency-name: minitest
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-12-15 23:37:57 +01:00
414382ffa7
Build(deps-dev): Bump fabrication from 2.23.0 to 2.23.1 ( #15325 )
...
Bumps [fabrication](https://github.com/paulelliott/fabrication ) from 2.23.0 to 2.23.1.
- [Release notes](https://github.com/paulelliott/fabrication/releases )
- [Changelog](https://github.com/paulelliott/fabrication/blob/master/Changelog.markdown )
- [Commits](https://github.com/paulelliott/fabrication/commits )
---
updated-dependencies:
- dependency-name: fabrication
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-12-15 23:37:49 +01:00
1c9a0fe18e
UX: let mobile post controls scroll on overflow ( #15305 )
2021-12-15 15:36:10 -05:00
a2fcc360dd
UX: Show group card with animated loading state ( #15253 )
...
* Remove _calculateTopOffset entirely
* Show group card with animated loading state
Showing the animated loading state before rending the actual content prevents an
awkward scroll position jump when displaying this card.
This mimics the behaviour of the user card (which uses the same `CardContentsBase` mixin).
* Fix two user card issues
1. A JS console error (with no consequences) when clicking a group mention
2. User cards weren't being loaded from the header (for example, for PMs)
Co-authored-by: Penar Musaraj <pmusaraj@gmail.com>
2021-12-15 13:47:31 -05:00
9fd92f329e
DEV: remove `showHtml` jQuery plugin ( #15316 )
2021-12-15 13:13:06 -05:00
102fa71ef3
PERF: Speed up the tests by pre-fabricating more things ( #15318 )
2021-12-15 11:41:14 -06:00
6120dde65c
DEV: Cleanup `for` attributes in category edit screens ( #15284 )
2021-12-15 12:37:11 -05:00
0335c9d77f
FEATURE: Add topic-navigation plugin outlet and popup component ( #15081 )
...
Adds a plugin outlet that can be used to insert a popup over topic timeline.
2021-12-15 17:16:14 +02:00
9fd1a00eef
DEV: Remove customer flair from being an official plugin ( #15315 )
2021-12-15 22:30:50 +08:00
3b3e572ce6
allow themes to change the lock icon easily ( #15309 )
2021-12-15 09:13:10 -05:00
6afab87d50
DEV: migrate more routes away from the old `actions:` pattern ( #15275 )
2021-12-15 18:06:10 +04:00
a09b6fe114
FEATURE: Save scroll position on bookmarks page ( #15296 )
...
Clicking on a bookmark and then back will preserve the scrolling
position.
2021-12-15 15:27:09 +02:00
0719531bd3
FIX: Notify group members when someone quotes or replies to their post. ( #15295 )
...
When a member set a group PM notification level to Normal, we didn't notify group members if someone quoted or replied to one of their posts.
2021-12-15 09:07:39 -03:00
666d291b24
DEV: minor refactoring or jump-to-post ( #15312 )
...
- replaces alias by reads
- drops jquery usage
- autofocus should already be done; so remove custom code
- uses @action
2021-12-15 12:09:26 +01:00
88fa8b5848
DEV: Skip Ember OnError validation for plugin qunit tests ( #15314 )
...
If the Ember OnError validation test is added, it breaks the "no tests were run" detection (since at least 1 test is always run). This is particularly important when running tests scoped to a single plugin, because there is no indication that you have typo'd the `qunit_single_plugin` query parameter.
2021-12-15 10:59:38 +00:00
77781f9a11
FEATURE: Extend plugin API to add multiple poster icons ( #15311 )
2021-12-15 18:09:26 +08:00
6fe4c8ae58
DEV: Fix intermittent failing spec. ( #15308 )
2021-12-15 09:51:46 +01:00
e37f0eb240
DEV: Add DropTarget options function for Uppy mixins ( #15307 )
...
This is so the target element for file drag + drop is
not always just this.element for the component, and
provides a way to hook into onDragOver and onDragLeave.
By default also adds a .uppy-is-drag-over class to the target
element.
2021-12-15 15:43:07 +10:00
4519f3f137
FIX: Add more actions to the uploads API key scope ( #15306 )
...
The uploads API key create scope did not cover the
external upload API endpoints, or the direct S3
multipart endpoints, and this commit adds them.
cf. https://meta.discourse.org/t/upload-create-api-key-insufficient/211896
2021-12-15 14:08:11 +10:00
15752da957
Revert "A11Y: Focus last viewed topic in topic lists ( #15300 )" ( #15304 )
...
This reverts commit 76aeee6735
2021-12-15 12:33:33 +11:00
38e17ab106
Update translations ( #15302 )
2021-12-15 10:03:20 +11:00
76aeee6735
A11Y: Focus last viewed topic in topic lists ( #15300 )
2021-12-15 10:02:31 +11:00
091ca9dbb1
UX: prevent timeline overflow in extreme cases ( #15303 )
2021-12-15 10:02:02 +11:00
d66eb984e4
Build(deps): Bump css_parser from 1.10.0 to 1.11.0
...
Bumps [css_parser](https://github.com/premailer/css_parser ) from 1.10.0 to 1.11.0.
- [Release notes](https://github.com/premailer/css_parser/releases )
- [Changelog](https://github.com/premailer/css_parser/blob/master/CHANGELOG.md )
- [Commits](https://github.com/premailer/css_parser/compare/v1.10.0...v1.11.0 )
---
updated-dependencies:
- dependency-name: css_parser
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2021-12-14 16:25:09 -05:00
dba16391ad
DEV: cleanup `for` attributes in search filters ( #15283 )
2021-12-14 14:47:03 -05:00
948574b978
DEV: Update GitHub workflows to use slim discourse_test images ( #15298 )
2021-12-14 18:30:25 +00:00
61e449379c
PERF: Prefabricate posters in topics_controller_spec ( #15297 )
...
It would be clearer to prefabricate posts, but that changes redis and
enabling snapshotting for all the tests in topics_controller_spec is
expensive.
2021-12-14 12:09:07 -06:00
0e87f882a7
DEV: Use discourse image for postgres in GitHub Actions ( #15291 )
...
The discourse base image already contains a postgres installation, so pulling a separate postgres image is a little wasteful. Using the copy of Postgres in the discourse image saves about 20 seconds on every GitHub actions run.
This commit sets up Postgres with a few performance-improving flags, which we were already using for the `rake docker:test` task (used on our internal CI system).
2021-12-14 17:20:06 +00:00
031f4f06d5
DEV: update and improvements to json editor ( #15294 )
...
- changes on how errors are handled to prevent weird cases
- uses didInsert/willDestroy to setup/clean state
- updates json editor library to 2.6.1
2021-12-14 17:21:49 +01:00
27fda37a8f
DEV: removes jQuery usage from extend-for-poll ( #15289 )
2021-12-14 16:52:18 +01:00
ce7c821aa9
UX: Extend user hyperlink in staff action logs ( #15293 )
...
The avatar hyperlink redirected to admin user page and the username
hyperlink applied a filter. Now both hyperlinks redirect to admin user
page.
2021-12-14 17:14:18 +02:00
175ced5096
DEV: Add chat invitation notification type ( #15288 )
2021-12-14 09:01:53 -06:00
4afd6f0189
Update translations ( #15292 )
2021-12-14 14:53:35 +01:00
1c42b36c89
DEV: Use slim container for backend tests in GitHub Actions ( #15290 )
2021-12-14 11:32:35 +00:00
eb3eae2fcc
DEV: Cache database in GitHub actions tests ( #15279 )
...
A cached database (and its uploads) will only be used if the current run has exactly the same set of migration files. Otherwise, the database will be migrated from scratch
This saves approximately 75s on the core backend specs and 45s on other runs.
2021-12-14 09:40:16 +00:00
Alan Guo Xiang Tan
Jarek Radosz
Penar Musaraj
dependabot[bot]
Daniel Waterworth
Andrei Prigorshnev
Joffrey JAFFEUX
Kris
jbrw
Bianca Nenciu
Natalie Tay
Joe
Roman Rizzi
David Taylor
Martin Brennan
Sam
Discourse Translator Bot
Osama Sayegh
Mark VanLandingham