c6409fd2cc
FIX: pass correct date arguments to server when exporting CSV
2019-05-01 10:46:30 +05:30
002e1f560a
FIX: initialize empty object if no custom filters are present
2019-05-01 10:27:19 +05:30
539723f8ff
FEATURE: Added unlisted topics option to advanced search ( #7447 )
2019-05-01 12:31:13 +10:00
0876248130
dev: Reenable skipped test
2019-04-30 18:09:17 -03:00
404b35bd04
FEATURE: Category Reviewable by Group
...
Allow a group to review content in a particular category.
2019-04-30 15:23:06 -04:00
dd29af4475
REFACTOR: `{{avatar}}` and `{{date}}` helpers in vdom templates
...
This is a step towards a nicer flag display under posts.
2019-04-30 15:22:38 -04:00
404666c9e9
DEV: Export the default behaviour of a topic-list-item so it can be reused by the discourse-assign plugin ( #7433 )
2019-04-30 15:36:54 -03:00
e0db323efb
Remove whitespace and revert unintended change
2019-04-30 15:07:03 -03:00
84a3459af6
DEV: Mark flaky tests as pending
2019-04-30 15:01:21 -03:00
812905cbb6
FIX: Recursively delete nested replies
...
Previously we were only deleting top level replies
2019-04-30 12:54:53 -04:00
5edb5c8b03
FIX: Mark invited admins as 'approved' ( #7459 )
...
This prevents invited admins appearing as no-op reviewables in the queue when invite_only or require_approval is enabled.
2019-04-30 17:26:39 +01:00
583226d295
FIX: Linking to `/new-topic` from `/latest`
...
`/new-topic` redirects back to `/latest`, so the ember router considers this to be a 'refresh'. This triggers the `resetParams()` logic, which would cause the transition to abort, and the composer would never open.
This commit fixes the `resetParams()` logic so that it uses the default values, instead of setting everything to `null`. Therefore the transition is no longer aborted, and the composer opens successfully.
Unfortunately I have not been able to reproduce the issue in a QUnit test.
2019-04-30 16:25:25 +01:00
8e68244eea
FIX: prevents google to track certain pages ( #7463 )
2019-04-30 15:57:51 +02:00
2ebe9e3a8b
Bump onebox version
2019-04-30 10:07:48 -03:00
bc8b7b13ef
DEV: Recompile theme fields after db:migrate
2019-04-30 11:52:30 +01:00
726dd0fe37
Revert "FIX: prevents google to track certain pages ( #7455 )"
...
This reverts commit c863e62998
2019-04-30 10:17:12 +02:00
587cfd4545
DEV: Use `frozen_string_literal: true` on `models/theme.rb`.
2019-04-30 16:02:55 +08:00
c863e62998
FIX: prevents google to track certain pages ( #7455 )
2019-04-30 13:59:55 +08:00
1fdeec564b
PERF: Move `where` clause up to speed up CalculateAvgTime daily job ( #7462 )
...
Cuts down affected posts earlier in the query, so the generated plan
deals with less rows, and runs faster.
https://meta.discourse.org/t/post-calculate-avg-time-taking-up-a-long-time/49750/13?u=falco
2019-04-30 13:34:46 +10:00
dca7f8ecf2
FIX: Loading more broken on groups page.
...
Regressed in 1f17d52f55
2019-04-30 10:35:17 +08:00
75a6c440f7
DEV: Spec clarification example ( #7458 )
2019-04-30 09:41:24 +08:00
7b1783bae8
FIX: cache_critical_dns was never caching pg replica ( #7461 )
...
* it's DISCOURSE_DB_REPLICA_HOST not DISCOURSE_DB_BACKUP_HOST
2019-04-30 08:42:51 +08:00
4ea21fa2d0
DEV: use #frozen_string_literal: true on all spec
...
This change both speeds up specs (less strings to allocate) and helps catch
cases where methods in Discourse are mutating inputs.
Overall we will be migrating everything to use #frozen_string_literal: true
it will take a while, but this is the first and safest move in this direction
2019-04-30 10:27:42 +10:00
0a5a6dfded
DEV: stop mutating inputs as a side effect
...
We had quite a few cases in core where inputs are being mutated as a side
effect of calling a method.
This handles all the cases where specs caught this.
Mutating inputs makes code harder to reason about. Eg:
```
frog = "frog"
jump(frog)
puts frog
"fly" # ?????
```
This commit is part of a followup commit that adds # frozen_string_literal
to all our specs.
2019-04-30 10:25:53 +10:00
442111af91
DEV: remove a couple of warnings from spec
2019-04-30 08:41:28 +10:00
a00354f11f
Prettier site-settings/group-list.js.es6
2019-04-29 16:26:13 -04:00
1ba72ccab8
DEV: add site setting type group_list for a list of groups
...
Add a js test
2019-04-29 16:15:22 -04:00
526e76ced2
FIX: Use PostgreSQL 'ON CONFLICT' to deal with race condition
...
On busy sites, concurrent requests to insert into post_timings can
occur, which was dealt with using Ruby exceptions.
This moves the handling to PostgreSQL which makes it a bit faster,
and prevents a spam of ERROR in the database logs.
2019-04-29 16:34:42 -03:00
bfadb1fabc
FIX: use more specific target for ".tag-box"
...
This avoids tags named "box" from receiving styling aimed at this specific element on the tag list page.
2019-04-29 13:55:40 -04:00
f8f7091e57
FIX: staff-only tags visible on /tags page when restricted to a category
...
If a tag group is set to only be visible to staff, and is restricted
to a category that is visible by everyone, the tags in the group were
being shown on the /tags page. They weren't visible anywhere else.
This commit fixes it so they don't show on the /tags page.
2019-04-29 12:38:28 -04:00
56f6065393
FIX: Generate ASCII slug with default locale
2019-04-29 18:29:58 +02:00
b75720d911
FIX: skip click-tracking for mentions
2019-04-29 12:05:47 -04:00
876c4f20b3
FIX: Remove duplicate Emoji names from blurb
...
The blurb contained the value of the alt and title attribute of Emojis. Both values are always the same.
2019-04-29 17:26:39 +02:00
71d19f6e1f
FIX: Reduce mentions in blurbs to @username or @groupname
...
The link to the user profile or group is useless and the URL encoded username or group name looks awful for Unicode names
2019-04-29 17:26:39 +02:00
5d4aa256be
FIX: category logo upload error in Discuz importer.( #7453 )
2019-04-29 17:01:15 +02:00
5768011cad
FIX: prevents exception in the composer with regexp flags
2019-04-29 16:58:17 +02:00
629ae7a5b7
FIX: Revert tracking links in quotes
2019-04-29 10:30:04 -04:00
aef35faefc
FIX: Open links in external tabs. ( #7444 )
2019-04-29 10:27:29 -04:00
ca9fd95a08
FIX: Respect "open external links in new window" in quotes and edit history
2019-04-29 10:13:53 -04:00
7a27c93c03
FIX: URL encode username and first letter in avatar URL
...
And it adds specs as a follow-up to aadb7da7
2019-04-29 15:08:14 +02:00
286f2abc65
FIX: prevents exception when clicking directly on site text
2019-04-29 12:07:30 +02:00
7afc36420c
Revert "PERF: Call web hook events in a new thread ( #7451 )" ( #7456 )
...
This reverts commit 09ae12bd5d
2019-04-29 18:50:34 +10:00
09ae12bd5d
PERF: Call web hook events in a new thread ( #7451 )
2019-04-29 18:50:12 +10:00
82a6cf8afd
Take 2 of 0f5161af19.
2019-04-29 16:41:35 +08:00
0f5161af19
DEV: Fix invalid constant after upgrading lograge to 0.11.0.
2019-04-29 16:19:29 +08:00
1d784c7a18
FEATURE: adds support for dates in polls ( #7450 )
2019-04-29 10:01:19 +02:00
ac3dab93f5
DEV: lint the files
2019-04-29 17:40:53 +10:00
45285f1477
DEV: remove update_attributes which is deprecated in Rails 6
...
See: https://github.com/rails/rails/pull/31998
update_attributes is a relic of the past, it should no longer be used.
2019-04-29 17:32:25 +10:00
3b95f34e7b
DEV: Rails 6 compatability
...
Without forcing a reload on start internal state in the accelerator can be
off. In Rails 5 not translation is being called so this is not an issue but
in 6 it is called earlier on.
2019-04-29 17:13:30 +10:00
1b1cfd4507
add no_subcategories query param in url only if its true ( #7439 )
2019-04-29 15:10:59 +08:00
Arpit Jalan
Tim Lange
romanrizzi
Robin Ward
David Taylor
Joffrey JAFFEUX
Guo Xiang Tan
Rafael dos Santos Silva
Daniel Waterworth
Michael Brown
Sam Saffron
Neil Lalonde
Penar Musaraj
Gerhard Schlager
MMX
Bianca Nenciu
Vinoth Kannan
Saurabh Patel