d7bd9aa3d0
Update translations ( #11385 )
2020-12-01 14:34:25 +01:00
b7490e894f
FIX: don't error-index category job when missing category
...
When the category is missing we should not throw an error but just finish the job.
2020-12-01 09:30:53 +08:00
99240476cb
Version bump to v2.7.0.beta1
2020-11-30 17:46:05 -05:00
aa09d83453
DEV: remove PR numbers from release_note:generate output
2020-11-30 17:46:05 -05:00
c60084a8f1
Build(deps-dev): Bump simplecov from 0.19.1 to 0.20.0
...
Bumps [simplecov](https://github.com/simplecov-ruby/simplecov ) from 0.19.1 to 0.20.0.
- [Release notes](https://github.com/simplecov-ruby/simplecov/releases )
- [Changelog](https://github.com/simplecov-ruby/simplecov/blob/main/CHANGELOG.md )
- [Commits](https://github.com/simplecov-ruby/simplecov/compare/v0.19.1...v0.20.0 )
Signed-off-by: dependabot[bot] <support@github.com>
2020-11-30 13:07:19 -05:00
e7bad9f05d
FIX: Ensure directory items appear in a consistent order ( #11370 )
...
User directory items are sorted by some activity metric. If those metrics have the same value, postgres does not guarantee the order in which they will be returned. This can cause issues in pagination - some users may appear twice, and some may be missed. To illustrate
```
pry(main)> query = DirectoryItem.where(period_type: DirectoryItem.period_types[:weekly]).order(:likes_received).limit(50);
pry(main)> page1 = query.offset(0).pluck(:id);
pry(main)> page2 = query.offset(50).pluck(:id);
pry(main)> (page1 & page2).count # users on both pages
=> 29
```
If we use the primary key to tie-break matching metrics, things are much more reliable
```
pry(main)> query = DirectoryItem.where(period_type: DirectoryItem.period_types[:weekly]).order(:likes_received, :id).limit(50);
pry(main)> page1 = query.offset(0).pluck(:id);
pry(main)> page2 = query.offset(50).pluck(:id);
pry(main)> (page1 & page2).count # users on both pages
=> 0
```
This most commonly effects new sites where all the directory metrics are zero.
The fact that the ordering is indeterminate makes it difficult to write a reliable test case for this.
2020-11-27 18:12:49 +00:00
65eec147fc
FEATURE: Add plugin js / plugin test js to bootstrap.json
...
This allows 3rd party clients (such as Ember CLI) to run plugins and
their tests.
2020-11-27 12:31:17 -05:00
7af663ca63
Build(deps): Bump loofah from 2.7.0 to 2.8.0
...
Bumps [loofah](https://github.com/flavorjones/loofah ) from 2.7.0 to 2.8.0.
- [Release notes](https://github.com/flavorjones/loofah/releases )
- [Changelog](https://github.com/flavorjones/loofah/blob/master/CHANGELOG.md )
- [Commits](https://github.com/flavorjones/loofah/compare/v2.7.0...v2.8.0 )
Signed-off-by: dependabot[bot] <support@github.com>
2020-11-27 10:50:19 -05:00
5448f3ed9e
Hide imports commit from blame ( #11367 )
2020-11-27 11:46:27 -03:00
1c2358ba16
DEV: Tidy up imports. ( #11364 )
...
Only allow one import definition per file and add a new eslint rule to enforce it.
2020-11-27 11:30:16 -03:00
2e5e4dbf19
DEV: Make it easier to customize link attributes in quick access menu ( #11365 )
...
This allows themes to customize link attributes:
```
api.reopenWidget("quick-access-item", {
_linkAttributes(href) {
const attributes = this._super(...arguments);
// do stuff
return attributes;
}
}
```
2020-11-27 12:26:47 +01:00
eeae657ca5
FIX: No tags should be set if tag chooser is hidden ( #11362 )
...
If a user could not set tags because they had a trust level lower than
min_trust_level_to_tag_topics site setting, the "Create Topic" button
from a tag page would still show up and be enabled. Clicking it caused
the composer model to silently have the tags set.
2020-11-27 13:03:37 +02:00
a0c457120a
Revert "FIX: bump nokogumbo to 2.0.3 with patch ( #11357 )" ( #11366 )
...
This reverts commit 2fee4ee7f3
2020-11-27 17:14:12 +11:00
2fee4ee7f3
FIX: bump nokogumbo to 2.0.3 with patch ( #11357 )
...
PR lodged to nokogumbo so later we should be able to drop freedom patch - https://github.com/rubys/nokogumbo/pull/158
2020-11-27 08:32:18 +11:00
dab2f2fdf4
REFACTOR: We can't use Ember.HTMLBars.compile in Ember CLI
...
Instead we use the inline `hbs` helper. Note in the non-Ember CLI
version this will not actually inline compile, but it will still work
for all our tests.
2020-11-26 09:27:20 -05:00
6ac270aa94
Build(deps): Bump regexp_parser from 1.8.2 to 2.0.0
...
Bumps [regexp_parser](https://github.com/ammar/regexp_parser ) from 1.8.2 to 2.0.0.
- [Release notes](https://github.com/ammar/regexp_parser/releases )
- [Changelog](https://github.com/ammar/regexp_parser/blob/master/CHANGELOG.md )
- [Commits](https://github.com/ammar/regexp_parser/compare/v1.8.2...v2.0.0 )
Signed-off-by: dependabot[bot] <support@github.com>
2020-11-26 09:26:57 -05:00
eecff3d15b
DEV: Ensures mobile RTL stylesheets are loaded ( #11360 )
...
This PR only makes CSS changes that have no visual impact, but they fix an issue in the compiler that causes some stylesheets not to load on mobile RTL.
Full context here
https://meta.discourse.org/t/user-card-will-not-open-on-the-mobile/171268/6?u=johani
2020-11-26 21:03:25 +08:00
f56c4b78da
FEATURE: Add users:log_out API key scope ( #11359 )
2020-11-26 10:39:38 +00:00
97eae4e3ad
PERF: avoid using destroy_all when removing stats ( #11358 )
...
destroy_all will load all the active record relation and iterate, this
can get extremely expensive.
2020-11-26 15:29:39 +10:00
c9df679ba1
FIX: Only use full slugs when compiling category backgrounds. ( #11353 )
...
If a category and a sub-category have the same slug, adding a background to one of them will also show it on the other one. This was introduced in 8e3f667214b4c3
2020-11-25 15:40:16 -03:00
059e9cb1d2
REFACTOR: Remove `.erb` from emoji-picker
...
We can't use erb in ember-cli, and it seems the emoji groups rarely
change anyway. This commit migrates the ERB to pre-rendered javascript
that is updated via the `rake javascript:update_constants` task.
2020-11-25 11:23:02 -05:00
9ec0359022
Build(deps): Bump rubocop from 1.4.1 to 1.4.2 ( #11349 )
...
Bumps [rubocop](https://github.com/rubocop-hq/rubocop ) from 1.4.1 to 1.4.2.
- [Release notes](https://github.com/rubocop-hq/rubocop/releases )
- [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop-hq/rubocop/compare/v1.4.1...v1.4.2 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-11-25 12:42:36 +01:00
834d71d1f7
Build(deps): Bump rails_failover from 0.6.1 to 0.6.2 ( #11350 )
...
Bumps rails_failover from 0.6.1 to 0.6.2.
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-11-25 11:21:50 +00:00
f5945efae7
DEV: watch more test directories ( #11346 )
...
Much has moved and autospec stopped picking up certain tests.
2020-11-25 11:12:23 +00:00
abb89475a3
FIX: issues with frowning/grinning ( #11235 )
...
- frowning was using slighty_frowning
- slightly_frowning was using frowning
- grinning_face_with_smiling_eyes was not defined
- fronwing_face_with_open_mouth was not defined
2020-11-25 09:09:35 +01:00
5028aaf446
FIX: Add secure media url to SERVER_SIDE_ONLY list ( #11348 )
2020-11-25 15:31:31 +11:00
2348a7972e
FIX: When quoting an attachment, keep the |attachment in markdown ( #11347 )
2020-11-25 15:31:14 +11:00
3e1b94c227
PERF: avoid checking card background and user background when not supplied ( #11299 )
...
Previously we were performing a bunch of needless work when SSO failed
to supply profile and card backgrounds.
2020-11-25 10:53:44 +11:00
51f9a56137
FEATURE: Onebox local categories ( #11311 )
...
* FEATURE: onebox for local categories
This commit adjusts the category onebox to look more like the category boxes do on the category page.
Co-authored-by: Jordan Vidrine <jordan@jordanvidrine.com>
2020-11-25 10:53:05 +11:00
416f984c5e
FEATURE: Update onebox and add styling for githubfolder onebox ( #11313 )
2020-11-25 10:51:29 +11:00
436d68d54f
UX: Don't show selected posts interface twice on mobile ( #11328 )
...
Note to reproduce you need a topic with over 3 posts.
2020-11-25 10:50:05 +11:00
f9ff51870b
FIX: Rebake theme fields if upload changes ( #11341 )
...
Updating SVG sprites of a theme did not take effect immediately because
the cache was not cleared.
2020-11-25 10:49:12 +11:00
e527741577
Build(deps): Bump rubocop-ast from 1.1.1 to 1.2.0 ( #11343 )
...
Bumps [rubocop-ast](https://github.com/rubocop-hq/rubocop-ast ) from 1.1.1 to 1.2.0.
- [Release notes](https://github.com/rubocop-hq/rubocop-ast/releases )
- [Changelog](https://github.com/rubocop-hq/rubocop-ast/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop-hq/rubocop-ast/compare/v1.1.1...v1.2.0 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-11-25 09:17:55 +11:00
ad1a10e6e9
FIX: hides votes from regular users when poll is staff only ( #11342 )
2020-11-24 22:19:06 +01:00
a6613d15f4
Adds discourse-gifs to suggested components ( #11339 )
2020-11-24 14:58:45 -03:00
9c901ee978
Update translations ( #11336 )
2020-11-24 17:25:37 +01:00
0e0c70019b
FIX: Suggested Topics was being set inside a computed property
...
This is bad because changing the `suggested_topics` proeprty could cause
a `set` on `suggested_topics`.
2020-11-24 11:08:11 -05:00
67979b2b21
Remove "Alternative Logos" from popular themes list ( #11337 )
...
Core has had support for dark theme logos for a while now.
2020-11-24 10:13:16 -05:00
0c685a46de
FEATURE: Add user update, anonymize and delete API scopes ( #11335 )
2020-11-24 12:54:24 +00:00
7ad2c2bdd8
FIX: Exclude muted results when suggested related topics at random. ( #11290 )
...
We already do this for new and unread results, but not for randomly suggested topics.
2020-11-24 09:16:10 -03:00
123107c28f
UX: Add group name to error message ( #11333 )
...
The group name used to be part of the error message, but was removed
in a past commit.
2020-11-24 13:06:52 +02:00
2742595b00
FIX: Checkbox value should not leak between themes ( #11327 )
...
This commit includes a hack to ensure didInsertElement is called only
once.
2020-11-24 12:10:28 +02:00
4b538e7cb9
DEV: Skip missing icon warnings in production ( #11334 )
...
The list of SVG icons is unavailable in production, and the previous
refactor here was causing incorrect and noisy console warnings.
This also parses the `svgIconList` string in a dev environment, icons
should now match more accurately.
2020-11-23 21:41:54 -05:00
0d8d568654
Build(deps-dev): Bump parallel_tests from 3.3.0 to 3.4.0 ( #11331 )
...
Bumps [parallel_tests](https://github.com/grosser/parallel_tests ) from 3.3.0 to 3.4.0.
- [Release notes](https://github.com/grosser/parallel_tests/releases )
- [Changelog](https://github.com/grosser/parallel_tests/blob/master/CHANGELOG.md )
- [Commits](https://github.com/grosser/parallel_tests/compare/v3.3.0...v3.4.0 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-11-23 22:27:27 +01:00
5a4811ede8
Build(deps): Bump rubocop from 1.3.1 to 1.4.1 ( #11332 )
...
Bumps [rubocop](https://github.com/rubocop-hq/rubocop ) from 1.3.1 to 1.4.1.
- [Release notes](https://github.com/rubocop-hq/rubocop/releases )
- [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop-hq/rubocop/compare/v1.3.1...v1.4.1 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-11-23 22:24:48 +01:00
de2d323ccf
UX: Slightly adjust onebox alignment ( #11326 )
...
* fixed header/favicon's vertical alignment
* slightly increased header margin
* made the onebox padding symmetrical
* increased the right margin on small image elements
* removed extraneous pre bottom margin
2020-11-23 22:16:50 +01:00
defbae4007
FIX: Force string conversions to UTF-8 "bytes" ( #11315 )
...
https://meta.discourse.org/t/cant-create-poll-with-some-chinese-options/170836
2020-11-23 17:51:05 +01:00
3394d994e9
FIX: Tests were using jQuery selectors
...
For the most part `querySelectorAll` will work with jQuery selectors,
but the big exception is `:eq(0)` and similar. Those needed to be
replaced.
2020-11-23 11:36:07 -05:00
60bc38e6a8
FIX: Gracefully handle force pushes for remote themes ( #11325 )
...
Force pushing a commit to a theme repository used to break the updater,
because the system was not able to count the commits behind the old and
new version. This operation failed because a force push deleted the old
commits.
The user was prompted with a simple "500 server error" message.
2020-11-23 15:29:22 +02:00
139c5dc356
FIX: use `tag` model instead of tagId property. ( #11298 )
...
In a recent commit 866fa008d42d5bb516a6
2020-11-23 16:40:15 +05:30
Discourse Translator Bot
Krzysztof Kotlarek
Neil Lalonde
dependabot[bot]
David Taylor
Robin Ward
Roman Rizzi
Gerhard Schlager
Bianca Nenciu
Joe
Sam
Joffrey JAFFEUX
Martin Brennan
jbrw
Rafael dos Santos Silva
Penar Musaraj
Dan Ungureanu
Jarek Radosz
chenyxuan
Vinoth Kannan