Guo Xiang Tan
758e3e52f7
FIX: Mobile topic timeline broken on Chrome 56.
...
* See https://developers.google.com/web/updates/2017/01/scrolling-intervention .
From Chrome 56 onwards, `touchstart` event listeners are treated as passive
by default which does not call `preventDefault` resulting in the page
scrolling when topic timeline handle is being dragged.
2017-02-27 11:39:57 +08:00
Sam Saffron
7e8f0dc967
FIX: attempt to handle ios edge case where token is seen but unsaved
...
This relaxes our security in the following way
- prev auth token is always accepted as long as rotation
date is within our window of SiteSetting.maximum_session_age.hours
(previously old token expired within a minute of new one being seen)
- new auth token is marked unseen if we are presented with an old token
after we already saw new one
This attempts to fix an issue where ios webkit is not committing new cookies
2017-02-26 17:09:57 -05:00
Blake Erickson
0a41da6bad
FEATURE: Add order logic to admin users controller
...
Added order and direction parameters for sorting admin user pages. This
commit only includes backend api changes.
https://meta.discourse.org/t/make-admin-users-list-sortable-suggestion/47649
Now you can pass in `order` and `asc` parameters to the
`/admin/users/list/<query>.json` endpoint.
Example:
`/admin/users/list/active.json?&order=post_count` which defaults to desc
and
`/admin/users/list/active.json?order=post_count&asc=true`
2017-02-24 17:11:17 -07:00
Régis Hanol
fdf749770b
remove unecessary '.limit(1)'
2017-02-24 12:56:13 +01:00
Régis Hanol
a2c04be718
FIX: eradicate I18n fallback issues 💣
...
FIX: client's translation overrides were not working when the current locale was missing a key
FIX: ExtraLocalesController.show was not properly handling multiple translations
FIX: JsLocaleHelper#output_locale was not properly handling multiple translations
FIX: ExtraLocalesController.show's spec which was randomly failing
FIX: JsLocaleHelper#output_locale was muting cached translations hashes
REFACTOR: move 'enableVerboseLocalization' to the 'localization' initializer
REFACTOR: remove unused I18n.js methods (getFallbacks, localize, parseDate, toTime, strftime, toCurrency, toPercentage)
REFACTOR: remove all I18n.pluralizationRules and instead use MessageFormat's pluralization rules
TEST: add tests for localization initializer
TEST: add tests for I18n.js
2017-02-24 11:31:21 +01:00
Guo Xiang Tan
1060239e2d
SECURITY: Ensure oAuth authenticated email is the same as created user's email.
2017-02-24 13:13:10 +08:00
Guo Xiang Tan
0847b4258a
Revert "SECURITY: Ensure that user has been authenticated."
...
This reverts commit fbe51d68a7
.
Changing the commit message to correctly reflect what we're actually
fixing.
2017-02-24 13:12:29 +08:00
Guo Xiang Tan
fbe51d68a7
SECURITY: Ensure that user has been authenticated.
2017-02-24 10:47:48 +08:00
Sam Saffron
3754b038e8
fix brotli origin
2017-02-23 18:26:40 -05:00
Sam
f15f61da0a
FEATURE: add immutable caching to rails site of things
2017-02-23 13:05:00 -05:00
Jeff Atwood
ad6cb3c638
force all iOS editors to minimum height for compat
2017-02-22 16:56:19 -08:00
Jeff Atwood
22fc761cc3
tweak iOS composer heights a bit
2017-02-22 15:48:39 -08:00
Neil Lalonde
c00ffabac3
search scope checkbox is default checked for your messages too
2017-02-22 17:45:12 -05:00
Neil Lalonde
0551b3f5ee
FEATURE: replace emoji with unicode in title and description meta tags
2017-02-22 16:24:13 -05:00
Sam Saffron
0fc2b64f65
attempt 2 at adjusting class definition so its more easily extensible
2017-02-22 14:18:43 -05:00
Sam Saffron
08d56952df
revert change, it is required
2017-02-22 14:10:55 -05:00
Sam Saffron
d0d60ffa89
make is slightly easier to extend
2017-02-22 14:06:18 -05:00
Neil Lalonde
57784ddf2b
remove unused setting import
2017-02-22 13:05:57 -05:00
Neil Lalonde
00700da6b8
remove null class
2017-02-22 12:23:45 -05:00
Neil Lalonde
53ec4c44f4
FIX: N+1 in topic_list
2017-02-22 12:20:50 -05:00
Neil Lalonde
a702330ccd
FEATURE: make show_subcategory_list a per-category setting
2017-02-22 11:42:36 -05:00
Arpit Jalan
2f657b0e32
FIX: do not refresh staff action logs every time the page is loaded
2017-02-22 17:25:39 +05:30
Arpit Jalan
213a496203
FIX: show all staff events related to the target user
2017-02-22 13:31:40 +05:30
Jeff Atwood
c191e2e84c
more conservative editor heights on iOS
2017-02-21 16:25:46 -08:00
Neil Lalonde
c94fdcea38
FIX: admin dashboard posts count should not include system posts and whispers
2017-02-21 14:45:41 -05:00
Arpit Jalan
c216f59eaa
fix the build
2017-02-22 00:43:37 +05:30
Sam Saffron
ce7c3bfc14
FIX: refresh header if message bus updates topic
2017-02-21 11:43:44 -05:00
Arpit Jalan
046cbad10b
FEATURE: add a button on admin user page that links to action log
2017-02-21 21:38:37 +05:30
Neil Lalonde
b19dfba497
FIX: tag link in breadcrumbs on subfolder installs
2017-02-21 10:41:08 -05:00
Arpit Jalan
068ce19ae2
FEATURE: linked topics should be rendered under posts for crawlers
2017-02-21 12:43:24 +05:30
Neil Lalonde
1dda998a4e
FEATURE: search should default scope to current category or user
2017-02-20 17:02:02 -05:00
Neil Lalonde
476ae57af3
FEATURE: primary group class on avatars in topic list
2017-02-20 15:55:10 -05:00
Jakub Macina
4a2f13348a
ADD: Append tags bulk action for topics
2017-02-20 18:14:32 +01:00
Neil Lalonde
aa2c527c60
Remove "From" from every post in Popular Posts section of summary emails
2017-02-20 11:04:12 -05:00
Régis Hanol
3ce3abef8f
FIX: add Content-Disposition and Content-Type headers when downloading attachments
2017-02-20 15:59:01 +01:00
Régis Hanol
fd62909819
UX: prevent post submission when uploading
2017-02-20 15:12:33 +01:00
Régis Hanol
97116c9276
Merge pull request #4714 from gdpelican/expose-safari-ua
...
Allow access to safari hack applicable function
2017-02-20 14:58:33 +01:00
James Kiesel
7dc0e11360
Rename exported function
2017-02-21 02:53:16 +13:00
Régis Hanol
f51e3b2131
FIX: should not be able to rename a system badge
2017-02-20 14:35:05 +01:00
James Kiesel
ffe41c9ae8
Allow access to safari hack applicable function
2017-02-21 02:32:01 +13:00
Régis Hanol
cb99f59ec3
reset bounce score when email is successfully changed
2017-02-20 10:37:01 +01:00
Victor van Poppelen
b501c3c6c6
desktop/topic.scss: fix responsive width
...
#topic-closing-info max-width fix for responsive issues below 757px
2017-02-19 18:30:19 -08:00
Neil Lalonde
a6ebe495bf
FEATURE: links that can't have no onebox can be used as featured topic links
2017-02-17 18:35:19 -05:00
Robin Ward
bebc55eebd
FIX: Users page wasn't loading more on mobile
2017-02-17 16:36:45 -05:00
Robin Ward
41db9e0d94
FIX: Silence CSS errors in Safari
2017-02-17 16:21:35 -05:00
Sam
1b6a801d35
forgot import
2017-02-17 16:17:44 -05:00
Sam
7d8a11f636
Add header-topic-info:after-tags extension point
2017-02-17 15:59:52 -05:00
Robin Ward
e62c0a42fa
FIX: Support multiple embeddable host records with the same host
2017-02-17 12:41:34 -05:00
Sam
1935f624b8
FEATURE: reset active record cache in sidekiq if needed
...
This can happen in multisite environments after restores
2017-02-17 12:09:53 -05:00
Neil Lalonde
3fb50d587d
FIX: invited users and new TL1 users will see their first notification highlighted
2017-02-17 10:30:29 -05:00
Jeff Atwood
a6dd1a2cd4
onebox last para needs less bottom margin
2017-02-16 15:39:46 -08:00
Neil Lalonde
868c489d5e
FIX: plugin outlets in navigation bar need to be li elements instead of div and span
2017-02-16 15:08:13 -05:00
Neil Lalonde
6bb9c5ceee
remove old code for global username registry
2017-02-16 13:06:37 -05:00
Régis Hanol
269f6e8c30
UX: top referrers headings are not numbers
2017-02-16 15:58:45 +01:00
Jeff Atwood
1444025e9c
remove CSS table layout from user prefs page
2017-02-16 02:01:20 -08:00
Jeff Atwood
e6c6a9e2d3
minor user card spacing tweak
2017-02-16 01:49:29 -08:00
Jeff Atwood
34223dca4e
minor CSS fix for custom user fields on user cards
2017-02-16 01:45:20 -08:00
Jeff Atwood
311b983c59
minor copyedit
2017-02-16 01:31:21 -08:00
Neil Lalonde
3e4dd513c9
show that password is optional on label
2017-02-15 19:59:16 -05:00
Jeff Atwood
f831e92c42
copyedit to improved invite page
2017-02-15 16:11:34 -08:00
Sam Saffron
040e10a627
reduce duplication
2017-02-15 17:27:10 -05:00
Neil Lalonde
4b28bfaa15
Merge pull request #4710 from ento/fix-s3-config-check
...
FIX: admin dashboard shouldn't complain when using IAM profile for S3 access
2017-02-15 17:02:07 -05:00
Neil Lalonde
d0fbb27f3e
FEATURE: new invite acceptance page, where username can be chosen and password can be set
2017-02-15 16:51:57 -05:00
Sam
3818c196e0
remove disallowed params
2017-02-15 16:47:14 -05:00
Sam
023bd0e9e7
FEATURE: allow client side of topic list to accept custom params
...
- Also normalize API version to use a version comparison function instead of float
2017-02-15 16:14:43 -05:00
Sam
74d4209d24
FEATURE: allow plugins to register custom topic list filters
2017-02-15 15:25:43 -05:00
Sam
9c51e3e8e7
amend preloader api to supply topic list
2017-02-15 12:04:02 -05:00
Sam
2c59ffeb2c
FIX: token rotation not accounting for overlapping tokens correctly
...
also... freeze_time has no block form, correct all usages and specs
2017-02-15 10:58:18 -05:00
Marica Odagaki
a9a585f66a
Use && and || consistently so that there's less chance of copy paste errors in the future
2017-02-15 00:25:49 -08:00
Marica Odagaki
3bb1b98b0e
FIX: admin dashboard shouldn't complain when using iam profile for s3 access
...
Previous code wasn't working as intended because it was parsed as
(bad_keys = (access_key or secret_key)) and !use_iam_profile
because of Ruby's operator precedence: `=` binds more eagerly than `and`.
http://ruby-doc.org/core-2.3.1/doc/syntax/precedence_rdoc.html
See also: https://github.com/bbatsov/ruby-style-guide#no-and-or-or
2017-02-15 00:22:14 -08:00
Sam
8409f42352
Add outlet for injecting custom tags
2017-02-14 17:40:13 -05:00
Sam
f2099c3811
adjust API
2017-02-14 16:32:33 -05:00
Sam
89d5e8ab4b
FEATURE: allow plugins to preload data in topic list
2017-02-14 16:29:06 -05:00
Sam
5346cd3514
correct the test
2017-02-14 09:34:39 -05:00
Sam
c52784f9d2
FIX: race condition when marking tokens as seen
...
- in rare conditions can lead to users being logged off
2017-02-14 09:34:09 -05:00
Sam
0ab96a7691
FEATURE: add hidden setting for verbose auth token logging
...
This is only needed to debug auth token issues, will result in lots
of logging
2017-02-13 14:01:09 -05:00
Robin Ward
0e58e393a1
FIX: === and a better constant, thanks @ZogStriP
2017-02-13 13:14:19 -05:00
Robin Ward
9d4405d602
Don't add an empty class to the list elements in the hamburger
2017-02-13 11:28:10 -05:00
Sam
07b9c351a4
Merge pull request #4705 from vinothkannans/dev
...
new: server plugin outlet for indexable robots.txt
2017-02-13 11:18:51 -05:00
Robin Ward
e1d358ffbf
FIX: Don't clear the login hint when the system user is saved
2017-02-13 10:54:20 -05:00
Vinoth Kannan
08c14dd689
new: server plugin outlet for indexable robots.txt
2017-02-13 17:31:10 +05:30
Nicolas
1deec95ccb
Use `natural` orientation for web app manifest.
...
The `any` orientation forces the rotation even when the device's screen
rotation is disabled. Using `natural` respects that and restores the
expected behaviour.
2017-02-12 18:04:06 +00:00
Jeff Atwood
22c83b0a20
Merge pull request #4700 from gsambrotta/replay-btn-position
...
fix replay btn position on mobile and desktop
2017-02-11 22:21:11 -08:00
Jeff Atwood
3ee7a9266c
Merge pull request #4686 from tgxworld/group_is_visible_if_user_is_group_owner
...
FIX: Show groups that user is owner of on groups page.
2017-02-11 22:18:44 -08:00
Vinoth Kannan
1b43c209eb
'Article' to 'DiscussionForumPosting' schema type
...
topic => https://meta.discourse.org/t/invalid-article-schema/57037
Replacing '[Article](https://schema.org/Article )' schema type with '[DiscussionForumPosting](https://schema.org/DiscussionForumPosting )'
2017-02-11 18:44:40 +05:30
Sam
675cb1c715
FEATURE: allow registrations of custom small action icons via plugins
2017-02-10 12:55:21 -05:00
giorgia
8c6d0ecd64
fix replay btn position on mobile and desktop
2017-02-10 17:11:10 +01:00
Sam Saffron
4332f0dde1
FEATURE: allow user search API to restrict to group
2017-02-09 18:45:39 -05:00
Neil Lalonde
d68dd5b967
Revert "UX: Observe changes to plugin to hide/show plugin admin link without refresh."
2017-02-09 12:11:53 -05:00
Jeff Atwood
77033f4855
simpler twitter onebox CSS that works everywhere
2017-02-08 17:18:53 -08:00
Jeff Atwood
933af0b40e
align onebox twitter date
2017-02-08 17:14:11 -08:00
Jeff Atwood
485c36141c
onebox right padding should not be asymmetric
2017-02-08 17:11:19 -08:00
Jeff Atwood
fe32c64dd9
FIX: twitter onebox styling was poor on mobile
2017-02-08 17:08:40 -08:00
Jeff Atwood
3b4248b454
add primary class to password reset button
2017-02-08 16:11:24 -08:00
Neil Lalonde
e077b3f141
FIX: composer should only feature links to external sites
2017-02-08 15:34:54 -05:00
Neil Lalonde
581d477ff3
add a comment because I can never find the mailing list summary email
2017-02-08 12:13:29 -05:00
Régis Hanol
f07b4b310a
should not have renamed this setting in 460665895c
2017-02-08 18:11:34 +01:00
Sam
53ea8942e8
action to be reserved for assigned plugin
2017-02-08 12:10:16 -05:00
Arpit Jalan
75f154b177
bump onebox
2017-02-08 12:08:41 +05:30
Jeff Atwood
7c9f8cb245
attempt to manually revert PR https://github.com/discourse/discourse/pull/4600
...
I hate that PR with the fire of a thousand suns
2017-02-07 17:15:12 -08:00