5c476f639c
REFACTOR: user-invited-show ( #7078 )
2019-02-27 12:59:57 +01:00
8ff3fc20a6
REFACTOR: tags-show ( #7079 )
2019-02-27 12:59:39 +01:00
7d2ea2d4dd
FEATURE: image resizing discoverability ( #6804 )
2019-02-27 11:46:16 +01:00
f68a7a16a4
FIX: Use field name to name files in theme export. ( #7009 )
2019-02-27 10:45:22 +01:00
6f427589b2
FIX: make it possible to use backup code everywhere where 2FA required ( #7010 )
2019-02-27 10:37:33 +01:00
e1d1073273
FIX: use * when apply italics in the editor instead of _ ( #7063 )
2019-02-27 10:36:14 +01:00
326d892f5e
Aadd 'secondary_emails' field in users export
...
FIX: escape_comma wasn't working in CSV exports
FIX: group_names field wasn't properly serialized
2019-02-27 10:12:20 +01:00
ef9b249cd2
UX: More consistent table header styles, removing duplicate styles
2019-02-26 21:40:17 -05:00
1d4e9b08ad
UX: Don't override unset flair color
2019-02-26 12:49:54 -05:00
59c66fd226
REFACTOR: Improve the readability of code ( #7076 )
2019-02-26 23:03:49 +05:30
fbedaea5ed
FIX: prevents double network calls and other quirks on admin emails ( #7074 )
2019-02-26 17:53:52 +01:00
75aaae5d5c
FEATURE: Allow wildcard in allowed_user_api_auth_redirects setting ( #6779 )
2019-02-26 17:03:20 +01:00
8c706b0ff7
fix tests ( #7073 )
2019-02-26 16:49:29 +01:00
2a8da03951
FIX: prevents autocomplete from going over search input ( #7075 )
2019-02-26 15:48:02 +01:00
a8ffc02d06
PERF: Reduce N+1s on theme admin page
2019-02-26 14:22:02 +00:00
d04c4bf8e7
UX: puts back share-panel as floating pane on post actions ( #7066 )
2019-02-26 14:15:25 +01:00
6ea9f5c9c5
FIX: do not update tag name on /tags/intersection
2019-02-26 16:43:39 +05:30
1cee8a86f6
fix prettier ( #7071 )
2019-02-26 11:24:02 +01:00
7ccb0b882f
FIX: ensures topic’s category allows topics tags ( #7060 )
2019-02-26 11:21:55 +01:00
a206c7f5d5
FIX: attempts to fix an error with EXTEND_PROTOTYPES ( #7067 )
2019-02-26 11:04:05 +01:00
71360436ff
FIX: users list show was loading multiple times with different params ( #7058 )
...
A first load was happening in route, which was setting properties on controller. These properties were observed on the controller and were triggering a reload of the AdminUser model.
Not only was it doing loading two times it was also sometimes resulting on the controller model refresh end to happen after route has been changed, resulting in a wrong model.
2019-02-26 10:43:24 +01:00
ed0120171c
FIX: Hide 'show associated accounts' button if moderators can't see emails
...
And minor prettier code alignments
2019-02-26 13:49:27 +05:30
c742d42031
FIX: rtl topic progress wrapper position ( #7070 )
...
* Set left/right topic-progress-wrapper CSS from text-direction
* Remove unnecessary CSS rule
2019-02-25 20:56:52 -05:00
d6875a77fb
UX: Apply new-user color to full name and username
2019-02-25 17:09:41 -05:00
34d0cc6ad5
UX: Better alignment of similar topics in composer
2019-02-25 17:04:11 -05:00
d5efe2d7ee
UX: make composer resize work on touch devices ( #7068 )
...
* UX: make composer resize work on touch devices
This also replaces a vendor dependency with a small built-in resize mechanism.
* Make blue bar's larger padding specific to touch devices
2019-02-26 08:04:14 +11:00
90c09d17b6
FIX: Heisentest - don't memoize on a class variable
...
Repeated usage of the same class will have the same memoized results
even if the data has changed.
2019-02-25 14:49:01 -05:00
dc961fecb9
FIX: Outgoing emails were not disabled after restoring backup
2019-02-25 16:07:24 +01:00
5952a6c0ad
DEV: uses find() helper instead of this.$() in js tests ( #7062 )
2019-02-25 16:04:55 +01:00
c0dd171cf1
REFACTOR: bread-crumbs ( #7064 )
2019-02-25 14:51:14 +01:00
6930706830
REFACTOR: new message route ( #7061 )
2019-02-25 14:01:00 +01:00
91e771ece6
FIX: send test email doesn't show a status
2019-02-25 17:42:58 +05:30
900e187627
DEV: removing blank files ( #7057 )
2019-02-25 09:52:44 +01:00
919839fd97
FIX: allows {{d-button}} to set a form attribute ( #7056 )
...
This attribute is used when a submit button is out of a form. It makes it explicit which form this button is submitting.
It's currently used in our login modal form.
2019-02-25 09:49:49 +01:00
2d031a1beb
UX: Improve moderator icon alignment
2019-02-22 21:29:39 -05:00
87f4ee13ef
UX: puts more emphasis on the shared url on share panel ( #7055 )
2019-02-22 23:22:11 +01:00
260398d706
FIX: Live refresh parent themes when editing child themes
2019-02-22 21:13:07 +00:00
8be7878656
FEATURE: add ability to clear previously set mobile_view with mobile_view=auto
2019-02-22 10:44:49 -08:00
8aca26cce3
FIX: allows right-click on post-date sharing link ( #7054 )
2019-02-22 15:18:05 +01:00
d1bad881ea
FEATURE: Allow moderators to change topic timestamps ( #7053 )
2019-02-22 14:33:52 +05:30
87b5003453
UX: Increase width of hamburger menu to 320px
2019-02-21 21:52:21 -05:00
f44ef82b53
UX: Better wrapping of group header elements
2019-02-21 21:42:39 -05:00
667d3a3fd6
PERF: include content-length header for CDN
...
Attempt to force NGINX to include content length when doing X-SendFile
This does not seem to be required when bypassing NGINX.
Without this header some CDNs may have issues caching
2019-02-22 11:21:07 +11:00
31d41f532e
PERF: do not include suggested topics when loading new posts
...
When a new post is triggered via message bus post stream will attempt to load
it, previously the `/topic/TOPIC_ID/posts.json` would unconditionally include
suggested topics, this caused excessive load on the server.
New pattern defaults to exclude suggested and related topics from this API
unless people explicitly ask for suggested.
2019-02-22 10:37:18 +11:00
74ed72e825
DEV: Remove `d-checkbox` component
...
Replaces the last occurrence of `d-checkbox` with a regular input element.
Includes a minor refactor of admin site text search.
2019-02-21 09:54:54 -05:00
1dee71d760
UX: Disabled lightbox expand button when loading image meta.
2019-02-21 22:30:57 +08:00
f8e498f6ad
DEV: Fix random build error
2019-02-21 14:53:29 +01:00
090acb5b11
FIX: s/isMessage/isPM ( #7048 )
...
Regression due to refactoring
2019-02-21 13:53:50 +01:00
8d779db270
FIX: allows invite modal from topic-map post-actions ( #7047 )
2019-02-21 13:48:03 +01:00
46e62c0d22
UX: Default user facing routes to `/g` instead of `/groups`. ( #7042 )
2019-02-21 13:44:25 +08:00
07b856700d
REFACTOR: remove disallowEmails option from user-selector
...
Negative option was leading to a fair amount of confusion, going forward
if we want to allow selection of emails from user selector it must be
supplied with `allowEmails=true`
This corrects a regression in 1f4ace4f
2019-02-21 16:37:26 +11:00
79841cf7dd
FEATURE: add missing autocomplete suppressions
...
Following 1f4ace4f
2019-02-21 16:37:26 +11:00
d3cd314a98
Make eslint happy.
2019-02-21 10:26:56 +08:00
58b0e945bd
UX: Lightbox support for image uploader. ( #7034 )
2019-02-21 10:13:37 +08:00
e3a23116d2
FIX: don't update gravatar if the user has no email
2019-02-20 22:34:43 +01:00
cc1f9e7be6
Fix share button in post menu
2019-02-20 16:27:59 -05:00
353eeef72a
fix prettier offense ( #7041 )
2019-02-20 22:22:38 +01:00
cafe637407
UX: List popular themes and components in admin panel ( #6997 )
...
Reorganizes theme create/upload flows into one install flow
Adds quick list of popular themes/components with one-click installation
2019-02-20 14:58:31 -05:00
4955ab1689
DEV: add replaceTagRenderer to pluginApi
2019-02-20 14:52:56 -05:00
18296b4211
FIX: more reliable native sharing ( #7039 )
2019-02-20 20:43:48 +01:00
9618300d69
s/share/nativeShare ( #7038 )
2019-02-20 20:03:30 +01:00
994a09e5e8
FIX: stricter window.navigator.share check ( #7037 )
2019-02-20 19:40:51 +01:00
2e0342dba7
UX: more spacing between social links ( #7036 )
2019-02-20 19:37:08 +01:00
28c24631b8
FIX: ensures panel's shareUrl is not erased by topic's shareUrl ( #7035 )
2019-02-20 19:33:54 +01:00
66901f67f6
UX: Moderator post wasn't completely translatable
2019-02-20 16:37:47 +01:00
04a63cfaaa
[WIP] FEATURE: merge share and invite actions together ( #7021 )
...
This commit also:
- removes [+ New Topic] behaviour from share, this feature has been duplicated in composer actions, months ago
- introduces our new experimental spacing standard for css: eg: `s(2)`
- introduces a new panel UI for modals
2019-02-20 15:42:44 +01:00
6a8007e5fb
FEATURE: Improve handling of backup storage errors
2019-02-20 15:16:49 +01:00
33269c4172
FEATURE: do no search for groups unless a term is specified
...
Do not allow `/u/search/users.json` to list any group matches unless a
specific `term` is specified in the API call.
Adding groups should always be done when an actual search term exists,
blank search is only supported for users within a topic
2019-02-20 17:28:22 +11:00
31ffa5f64e
UX: Allow users to see filename in image-uploader component. ( #7022 )
...
https://meta.discourse.org/t/downsides-of-the-new-logo-ui-in-site-settings/102247/23?u=tgxworld
2019-02-20 13:55:55 +08:00
1f4ace4f56
FEATURE: autocomplete usernames early in topic based on participation
...
Following this change when a user hits `@` and is replying to a topic they
will see usernames of people who were last seen and participated in the topic
This is somewhat experimental, we may tweak this, or make it optional.
Also, a regression in a423a938
2019-02-20 13:34:43 +11:00
918a0ea3a4
FIX: use autocomplete="discourse" to disable Chrome address autofill
...
https://stackoverflow.com/a/47822599/17174
Chrome 63 and up start ignoring `autofill="off"`
Per: https://bugs.chromium.org/p/chromium/issues/detail?id=468153#c164
> The tricky part here is that somewhere along the journey of the web autocomplete=off become a default for many form fields, without any real thought being given as to whether or not that was good for users. This doesn't mean there aren't very valid cases where you don't want the browser autofilling data (e.g. on CRM systems), but by and large, we see those as the minority cases. And as a result, we started ignoring autocomplete=off for Chrome Autofill data
So to work around this decision we now explicitly say: autocomplete="discourse"
when we don't want Chrome to randomly fill in addressed (aka. always)
2019-02-20 10:15:59 +11:00
246997dbd9
FIX: an `<a>` with a target of _blank wants a new window
2019-02-19 14:44:30 -08:00
49e7073438
FIX: Hide advanced theme fields behind a flag, pending UI improvement
2019-02-19 22:25:00 +00:00
d08939ab05
FIX: Should be possible to save an empty theme_field in the editor
...
Removing the theme_field JS object when the value was empty caused the server to maintain the previous value, making it impossible to delete the content of a field.
2019-02-19 21:49:31 +00:00
5d75bd4831
FIX: Don't try to rename group when username is taken
...
FIX: Always rename groups with the default locale instead of using the user's locale
2019-02-19 22:31:03 +01:00
dbcf05d62c
DEV: Code style improvements following review
...
Followup to 05ee1d1aba
2019-02-19 20:02:29 +00:00
7878e5007a
FIX: Refactor to prevent themes affecting core stylesheets ( #7029 )
...
If a theme setting contained invalid SCSS, it would cause an error 500 on the site, with no way to recover. This commit stops loading theme settings in the core stylesheets, and instead only loads the color scheme variables. This change also makes `common/foundation/variables.scss` available to themes without an explicit import.
2019-02-19 15:55:59 +00:00
9ade04b709
FIX: removes legacy browsers-refresh button ( #7028 )
2019-02-19 16:38:21 +01:00
84c56e16f9
REFACTOR: Use keyword argument for fallback_to_english flag
2019-02-19 15:28:47 +01:00
05ee1d1aba
FEATURE: Added settings/translations support to theme editor UI ( #7026 )
...
- These advanced fields are hidden behind an 'advanced' button, so will not affect normal use
- The editor has been refactored into a component, and styling cleaned up so menu items do not overlap on small screens
- Styling has been added to indicate which fields are in use for a theme
- Icons have been added to identify which fields have errors
2019-02-19 12:56:01 +00:00
0616837a5d
UX: moves wizard's "Finish" button to the left of back and next ( #7027 )
...
This was done to avoid clicking finish when clicking fast on next.
2019-02-19 13:32:01 +01:00
8a4cd15e46
REFACTOR: topic model ( #7020 )
2019-02-19 10:13:46 +01:00
15fd875855
REFACTOR: color-scheme-color model ( #7019 )
2019-02-19 09:31:26 +01:00
cba0dd33ee
REFACTOR: admin-customize-color ( #7018 )
2019-02-19 09:31:11 +01:00
2c6bf184bc
REFACTOR: admin-badge-preview ( #7017 )
2019-02-19 09:30:52 +01:00
3bf61fca66
REFACTOR: admin-user-field-item ( #7016 )
2019-02-19 09:30:38 +01:00
ee692414ce
REFACTORING: admin-edit-badge-groupings ( #7015 )
2019-02-19 09:30:24 +01:00
27e7f2bee0
DEV: call 'enqueue_hooks' method only if active webhooks exist
2019-02-19 12:43:08 +05:30
f2c3415548
FIX: Should not generate payload until active webhooks are exist
2019-02-19 12:23:42 +05:30
4f5aebc338
UX: reduce subcategory badge spacing
2019-02-18 19:04:36 -05:00
50f833def0
fix the build
...
JsPrettier on Sublime was failing because: https://github.com/jonlabelle/SublimeJsPrettier/issues/157#issuecomment-458175837
2019-02-18 11:52:11 +05:30
dc2776bcdd
FIX: do not show "move to new PM" option to moderators
2019-02-18 11:35:00 +05:30
052eaed16a
lighten embed blockquote style for consistency
2019-02-17 21:00:46 -08:00
dfba36fdca
remove bgcolor from embed quotes for consistency
2019-02-17 20:57:27 -08:00
7da7a30e02
PERF: Restore `exists?` in favor of `blank?`.
...
Regression from dcd7b92532
2019-02-18 10:04:21 +08:00
f04471e422
REFACTOR: Proxy letter avatars in rails instead of nginx
...
Co-authored-by: Sam Saffron <sam.saffron@gmail.com>
Co-authored-by: David Taylor <david@taylorhq.com>
This gives more control over the request. In particular we can easily
lookup DNS dynamically, instead of only upon NGINX startup.
Previously, NGINX was looking up IP for the letter avatar service and
caching the CDN IP address, this caused issues if CDN changed IP, in
which letter avatars would be broken till a container restarted.
NGINX config has been updated to add caching. This change will require
a container rebuild.
The proxy will now function in development environments, so the patch
for `letter_avatar_proxy` has been removed.
2019-02-18 08:46:56 +11:00
b0862bd15d
FIX: Push notifications could fail with UnauthorizedRegistration
...
The webpush gem by default sets the expiration date of the JWT token to exactly 24 hours in the future. That's not really needed because the token isn't reused. And it might cause UnauthorizedRegistration if the server's clock isn't 100% correct, because the maximum allowed value is 24 hours.
2019-02-15 21:12:09 +01:00
17f1a76570
FIX: Delete push subscription on MismatchSenderId error
...
This should prevent repeated MismatchSenderId warnings when the VAPID keys have changed.
2019-02-15 21:12:09 +01:00
159dd69fcb
UX: make adding permissions more visible and intuitive to click. ( #6999 )
2019-02-15 12:01:10 -05:00
99c6db21e6
FEATURE: allow blocking emojis ( #7011 )
...
https://meta.discourse.org/t/blocking-emojis-wont-work/105853
2019-02-15 20:55:48 +05:30
a423a9383f
FIX: Stop autocomplete for invalid usernames. ( #7005 )
2019-02-15 11:29:26 +11:00
f8b70f4ca3
FIX: unable to create new categories
...
Previous attempt at 70adb940
2019-02-15 10:24:29 +11:00
3d11064a33
UX: Reduce font size on about pages
2019-02-14 11:01:17 -05:00
70adb94008
SECURITY: Do not leak private group names. ( #7008 )
2019-02-14 15:35:58 +01:00
fc14847c14
PERF: only require aws-sdk-sns gem when it's being used
2019-02-14 11:08:21 +01:00
ebd4140492
FIX: logspam due to 404s on CSS files
...
We had a missing formats: string on our render partial that caused logs to
spam when CSS files got 404s.
Due to magic discourse_public_exceptions.rb was actually returning the
correct 404 cause it switched format when rendering the error.
2019-02-14 17:58:16 +11:00
39522659a6
FIX: validate parent category/subcategories permissions
...
See: https://meta.discourse.org/t/subcategories-do-not-inherit-permissions-from-parent-category/17174/23 for more details
This ensures users with access to child category can always at least see parent
2019-02-14 16:38:52 +11:00
090e9c8432
FIX: make composer full screen shortcut work when inputs have focus ( #6907 )
...
- Uses a Mousetrap plugin for global shortcuts
- Implemented for search `ctrl+alt+f` and composer fullscreen `shift+f11` shortcuts
2019-02-14 00:19:27 -05:00
ed6f4dfc40
FEATURE: trigger user profile create and update event ( #6958 )
...
Adds `user_profile_created` DiscourseEvent on profile creation and `user_profile_updated` on profile update
2019-02-14 15:45:12 +11:00
b651605d6e
FIX: tags added while editing a pending approval topic do not show up ( #6959 )
2019-02-14 15:42:40 +11:00
37666c3d18
UX: Signup form labels were too constrained, minor cleanup
2019-02-13 21:07:34 -05:00
484bd82278
FIX: Add onceoff job to remove double quotes from s3 etags
2019-02-14 05:19:41 +05:30
0476169692
make prettier happy
2019-02-13 22:16:38 +01:00
94fe0af900
FIX: upload emojis sequentially to prevent rate limit
2019-02-13 22:07:37 +01:00
4d674acc25
FEATURE: AWS SNS bounce notifications webhooks
2019-02-13 21:26:40 +01:00
560cc4e73e
FIX: sets categoryId but do not scope when replying as new topic ( #7002 )
2019-02-13 15:19:58 +01:00
fe4254b8f3
FIX: reverse consolidated pageviews stacked chart order ( #7001 )
2019-02-13 12:24:18 +01:00
641b079c78
FIX: add support for missing verbs in user api key
...
Previously "write" scope was missing put and delete verbs which should be
allowed.
Also closes : #6982
2019-02-13 15:49:43 +11:00
1328a127ee
FIX: translate bootbox confirmation dialog ( #6981 )
2019-02-13 14:04:56 +11:00
467cfc9e08
FIX: remove extra periods ( #6998 )
...
Periods are belong in the translation files not in our templates, if we have them in the templates sentences can not be localized properly.
2019-02-13 12:54:34 +11:00
47fe34d794
FEATURE: makes create-account userfields using dropdowns accessible ( #6991 )
2019-02-13 12:52:55 +11:00
3da35081e5
UX: Embedded post collapse button hover color fix
2019-02-12 17:21:33 -05:00
c23411cc69
FIX: Heisentest - suspicious logins report was not ordered by date
...
The specs needed an order even though none was supplied.
2019-02-12 13:17:29 -05:00
86fe423f5e
FIX: Clear the cache after destroying theme_fields
2019-02-12 16:39:40 +00:00
91f0468f4e
FIX: Allow unbaked theme fields to be destroyed
...
The after_commit hook was attempting to re-bake theme_fields after they were destroyed, which caused an exception to be thrown
2019-02-12 16:14:43 +00:00
59640ef373
DEV: Add additional hooks for theme-creator plugin
2019-02-12 14:17:34 +00:00
b8b1759de9
UX: show envelope when tag is only used in PM
...
UX: use regular envelope instead of solid envelope
REFACTOR: %s/enveloppe/envelope/g
2019-02-12 11:34:25 +01:00
90ce448675
PERF: Cache build_not_found_page
2019-02-12 21:20:33 +11:00
d997b01a24
FIX: Scale down swipe in detection to 20px from edge of the screen
...
...and slightly increase velocity required for menu actions
2019-02-11 21:22:50 -08:00
c3cbff55be
FIX: only respond to menu open swipes on Andorid
2019-02-11 20:56:25 -08:00
e0c16d3a8a
minor refactoring to improve code readability
2019-02-11 17:24:02 +05:30
dcd7b92532
FIX: some posters were not getting added to topic_allowed_users when moving posts to a new PM
...
If a user posted twice in a topic then subsequent posters were not getting added as topic_allowed_users.
2019-02-11 17:05:21 +05:30
2c12336c6b
FIX: Display post updated date in non-JS view for crawler
2019-02-11 16:48:22 +05:30
c50db76f5d
FIX: do not treat TIFF, BMP, WEBP as images
...
Treating TIFF and BMP as images cause us to add them to IMG tags, this is very inconsistent across browsers.
You can still upload these files they will simply not be displayed in IMG tags.
2019-02-11 16:28:43 +11:00
c719658f9f
`human?` helper method on a user
...
This is cleaner than hard coding `id > 0` in ruby code.
2019-02-08 13:34:54 -05:00
60fa4fe692
DEV: Make interface route/controller more resilient to missing values
2019-02-08 16:54:15 +00:00
0d1fa54957
compensate for border overhang in category list alignment
2019-02-08 11:49:06 -05:00
72b5ab0454
Don't wrap exceptions in test mode unless specifically requested.
...
This helps debugging reports with invalid SQL, which would otherwise
return no results instead of a useful error message while running
tests.
2019-02-08 11:26:26 -05:00
7c55de6e6f
UX: Alignment fix for names with emoji
2019-02-08 11:07:04 -05:00
747fea8458
DEV: Remove unused import
2019-02-08 16:05:39 +00:00
95eb4c67f2
FIX: Allow reverting theme/text settings from cookie back to default
2019-02-08 15:39:44 +00:00
62043e6904
UX: Hide branch/private repo options in admin theme import modal
2019-02-08 10:17:29 -05:00
7aecd3c2f5
Update app/services/user_silencer.rb
...
Co-Authored-By: eviltrout <robin.ward@gmail.com>
2019-02-08 08:50:50 -05:00
bc3efab816
FIX: When disagreeing with a flag that silenced a user, unsilence them
...
Previously it would unhide their post but leave them silenced.
This fix also cleans up some of the helper classes to make it easier
to pass extra data to the silencing code (for example, a link to the
post that caused the user to be silenced.)
This patch also refactors the auto_silence specs to avoid using
stubs.
2019-02-08 08:50:50 -05:00
44d9bc12c9
FEATURE: color-palettes component ( #6992 )
2019-02-08 14:01:14 +01:00
babd80dfd1
FIX: Allow subexpressions in raw handlebars helpers
...
Helpers registered via `registerUnbound` did not receive parameters if they were subexpressions.
For example: `{{helper1 key=(helper2 value)}}`
2019-02-08 12:58:10 +00:00
95b5c5898e
FIX: Prevent duplicate params for raw template theme handlebars helpers
2019-02-08 12:54:00 +00:00
e3324737ee
FIX: position invite footer button before archive ( #6990 )
2019-02-08 12:21:51 +01:00
e9ec5238fc
DEV: Remove ignored columns
2019-02-08 12:12:38 +01:00
8a152566e3
FIX: improves positioning of footer buttons on mobile ( #6989 )
2019-02-08 12:09:56 +01:00
Joffrey JAFFEUX
Maja Komel
Dan Ungureanu
Erick Guan
Régis Hanol
Kris
Vinoth Kannan
Davide Porrovecchio
David Taylor
Arpit Jalan
Vinoth Kannan
Simon Cossar
Osama Sayegh
Robin Ward
Gerhard Schlager
Jeff Wong
Sam
Penar Musaraj
Guo Xiang Tan
Guo Xiang Tan
Jeff Atwood
peterlamber
Bianca Nenciu
Saurabh Patel