d4c02d738b
DEV: Add topicNotificationLevel fn to post model ( #24723 )
2023-12-05 12:08:29 -06:00
a5fc8f3253
FIX: Account activation under ember-5 build ( #24722 )
...
We were previously relying on Ember's 'vendor' bundle to make the jquery global available on the activate_account route. That no longer happens under our Ember 5 build.
This commit updates our activate-account script to remove the need for jquery, so that it works under both Ember 3 and Ember 5 builds.
2023-12-05 17:49:40 +00:00
6aeddad333
DEV: Add `search-menu-before-advanced-search` plugin outlet ( #24720 )
2023-12-05 10:08:27 -07:00
8fb5b1fe7c
DEV: Fix assertion in embedding test ( #24694 )
...
The modified test used to be the same as the test above. The bad test
was introduced in commit 77d4c4d8dc
2023-12-05 18:30:52 +02:00
863c0cdecc
FIX: Ensure slugless topic URLs are correctly redirected ( #24719 )
...
Using `DiscourseURL.routeTo` with `replaceURL: true` wouldn't cause a true Ember redirect. That meant that the transition source would be be replaced in the browser's history stack, and the 'back' button wouldn't work as expected. Instead, we can use the router service to perform a proper redirect.
2023-12-05 15:37:01 +00:00
cae2b83af8
Update translations ( #24716 )
2023-12-05 14:39:08 +01:00
ad77a6876c
UX: fix alignment ( #24718 )
2023-12-05 14:19:21 +01:00
3d710fa0b8
UX:; scope details change ( #24715 )
2023-12-05 13:56:17 +01:00
a6c79aa27a
DEV: Fix readonly admin login spec ( #24714 )
...
"prevents login by admins" should test with an admin.
2023-12-05 06:49:22 -06:00
c5aa6b5e16
FIX: correctly update replies_count on chat_threads ( #24711 )
...
The previous query would look at the existing messages, count them, and update the associated thread.
But, if for some reason messages were **ALL** deleted without updating the `replies_count`, then the query wouldn't find any message, and wouldn't update any thread's `replies_count`.
2023-12-05 13:46:58 +01:00
707acbe696
UX: details tag background colour ( #24710 )
2023-12-05 12:52:00 +01:00
094d597ec8
FIX: increments message version when processed ( #24713 )
...
Incrementing version, ensures the message will re-play decorators.
Also removes a debugging line which had been forgotten.
2023-12-05 12:34:19 +01:00
9362949687
Build(deps): Bump regexp_parser from 2.8.2 to 2.8.3 ( #24701 )
...
Bumps [regexp_parser](https://github.com/ammar/regexp_parser ) from 2.8.2 to 2.8.3.
- [Changelog](https://github.com/ammar/regexp_parser/blob/master/CHANGELOG.md )
- [Commits](https://github.com/ammar/regexp_parser/compare/v2.8.2...v2.8.3 )
---
updated-dependencies:
- dependency-name: regexp_parser
dependency-type: indirect
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-12-05 11:50:48 +01:00
9a10f9d240
Build(deps): Bump terser from 5.24.0 to 5.25.0 in /app/assets/javascripts ( #24703 )
...
* Build(deps): Bump terser in /app/assets/javascripts
Bumps [terser](https://github.com/terser/terser ) from 5.24.0 to 5.25.0.
- [Changelog](https://github.com/terser/terser/blob/master/CHANGELOG.md )
- [Commits](https://github.com/terser/terser/compare/v5.24.0...v5.25.0 )
---
updated-dependencies:
- dependency-name: terser
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
* Update lockfiles for ember version flag
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: discoursebuild <build@discourse.org>
2023-12-05 11:50:29 +01:00
c6ee647b12
DEV: skip failing spec du to refactoring modal for now ( #24712 )
2023-12-05 11:47:39 +01:00
c7667f791e
DEV: Fix chat notifier deprecation warnings from job arguments ( #24708 )
...
We're seeing some deprecation warnings in production. This is because we're passing a raw Ruby timestamp, which gets stringified implicitly when written to Redis. As per #15842 , this conversion needs to be done explicitly.
2023-12-05 18:03:30 +08:00
de983796e1
FIX: Introduce Guardian::BasicUser for oneboxing checks ( #24681 )
...
Through internal discussion, it has become clear that
we need a conceptual Guardian user that bridges the
gap between anon users and a logged in forum user with
an absolute baseline level of access to public topics,
which can be used in cases where:
1. Automated systems are running which shouldn't see any
private data
1. A baseline level of user access is needed
In this case we are fixing the latter; when oneboxing a local
topic, and we are linking to a topic in another category from
the current one, we need to operate off a baseline level of
access, since not all users have access to the same categories,
and we don't want e.g. editing a post with an internal link to
expose sensitive internal information.
2023-12-05 09:25:23 +10:00
7756c210da
FIX: Flaky table builder spec ( #24700 )
2023-12-04 12:14:07 -08:00
b9110c5a71
FIX: Don't refresh on topic search result click ( #24697 )
...
Fixes an issue where when selecting a topic search result we were refreshing the page rather than letting `DiscourseURL` redirect us to the given topic. This was because we were leaning on a `a` tag and it's href to handle the redirect
3aeff56faf/app/assets/javascripts/discourse/app/components/search-menu/results/types.hbs (L15-L16)
2023-12-04 11:27:38 -07:00
87d850948f
PERF: Only apply terser to production assets ( #24699 )
...
We funnel vendored javascript through ember-cli, but that's only used for the testem environment. Therefore, there's no need to minify it in production builds. In my tests, this reduces peak RSS of a production build from 3.53GB to 3.15GB.
2023-12-04 18:05:55 +00:00
c4381e0265
FIX: don't apply extraClassName to all popup menus ( #24695 )
2023-12-04 11:40:57 -06:00
c805bcc7ba
DEV: adds a chat-join-channel-button outlet ( #24698 )
...
This outlet allows to redefine the button displayed when asking the user to join a channel.
The following outletArgs are sent to the outlet:
```
onJoinChannel
channel
icon
title
label
disabled
```
2023-12-04 18:11:33 +01:00
3aeff56faf
DEV: Run assets:precompile ember build with `CI=1` ( #24696 )
...
This will improve the output to print the current step (rather than the existing behavior which just says 'building...')
2023-12-04 15:49:50 +00:00
fa35ce9caa
DEV: remove duplicate spec ( #24691 )
2023-12-04 15:45:11 +00:00
037622fc7f
DEV: reviewable_user spec should assert on delete_user_block instead of delete_user ( #24692 )
2023-12-04 12:44:32 -03:00
0af8bbd378
FIX: Multiple nested threads and duplicated messages in chat transcripts ( #24685 )
2023-12-04 12:43:04 -03:00
cf8961e1c1
DEV: Correct forums_controller success spec ( #24690 )
...
The implementation did not match the name of the spec
2023-12-04 14:26:29 +00:00
9479b30ada
FIX: Ensure 'untagged' document title is set correctly ( #24689 )
...
https://meta.discourse.org/t/286130/4
2023-12-04 13:43:02 +00:00
7196613e2e
DEV: Fix various spec linting issues ( #24672 )
...
Duplicated specs, incorrect descriptions, incorrect assertions, incorrect filenames, old todo
2023-12-04 13:45:19 +01:00
c2887d3f8c
DEV: Remove unused Ember::Handlebars freedom patch ( #24688 )
...
We no longer compile Ember templates in ruby, so this is unused
2023-12-04 12:40:08 +00:00
cdb904a1b0
DEV: Remove unused htmlbars-inline-precompile shim ( #24687 )
...
Since 4425e99bf9
2023-12-04 12:34:45 +00:00
e0c876696a
DEV: Fix some qunit linting issues ( #24686 )
...
`qunit/literal-compare-order`
`qunit/no-compare-relation-boolean`
`qunit/assert-args`
2023-12-04 13:32:16 +01:00
2029777b86
DEV: Replace AdminWrapper with body-class/html-class ( #24683 )
...
AdminWrapper isn't used (directly) in all-the*
Co-authored-by: David Taylor <david@taylorhq.com>
2023-12-04 12:53:07 +01:00
3ed1528327
FIX: failing spec in sidebar tags ( #24682 )
...
The modal is now larger and more tags will be shown by default, we need more tags to correctly test the scroll behavior.
2023-12-04 12:46:53 +01:00
e9e6c4e5d6
Build(deps): Bump nio4r from 2.6.1 to 2.7.0 ( #24678 )
...
Bumps [nio4r](https://github.com/socketry/nio4r ) from 2.6.1 to 2.7.0.
- [Release notes](https://github.com/socketry/nio4r/releases )
- [Changelog](https://github.com/socketry/nio4r/blob/main/changes.md )
- [Commits](https://github.com/socketry/nio4r/compare/v2.6.1...v2.7.0 )
---
updated-dependencies:
- dependency-name: nio4r
dependency-type: indirect
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-12-04 10:36:34 +01:00
ec4491cc3b
Build(deps-dev): Bump rubocop from 1.57.2 to 1.58.0 ( #24675 )
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.57.2 to 1.58.0.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.57.2...v1.58.0 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: indirect
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-12-04 10:13:20 +01:00
364216cab3
Build(deps): Bump rbtrace from 0.4.14 to 0.5.0 ( #24677 )
...
Bumps [rbtrace](https://github.com/tmm1/rbtrace ) from 0.4.14 to 0.5.0.
- [Changelog](https://github.com/tmm1/rbtrace/blob/master/CHANGELOG )
- [Commits](https://github.com/tmm1/rbtrace/compare/v0.4.14...v0.5.0 )
---
updated-dependencies:
- dependency-name: rbtrace
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-12-04 10:11:55 +01:00
af30d3dc7c
Build(deps-dev): Bump shoulda-matchers from `7e069cf` to `3654e5c` ( #24679 )
...
Bumps [shoulda-matchers](https://github.com/thoughtbot/shoulda-matchers ) from `7e069cf` to `3654e5c`.
- [Release notes](https://github.com/thoughtbot/shoulda-matchers/releases )
- [Commits](7e069cf205...3654e5ca7f
2023-12-04 10:11:15 +01:00
1df1a9490d
UX: fix sidebar modal ( #24646 )
...
* UX: fix modal width
2023-12-04 08:10:17 +01:00
adb75cf3a9
DEV: Delete redundant bookmark test ( #24680 )
...
Cases were identical and also already covered on L63
2023-12-04 12:27:35 +10:00
74011232e9
FIX: Request html when fetching inline onebox data ( #24674 )
...
We do expect to receive html
2023-12-04 11:36:42 +10:00
eada155dcd
DOCS: Update INSTALL-email to point to Brevo correctly
...
Brevo changed their DNS Names
2023-12-04 11:46:33 +11:00
d9ac0c33ff
FIX: update tag description field placeholder ( #24644 )
...
Improvements after https://github.com/discourse/discourse/pull/24561
1. Make placeholder more descriptive
2. Respect new line breaks in description
2023-12-04 09:38:20 +11:00
56795f5c07
UX: improve btn-transparent styling ( #24666 )
2023-12-02 14:21:22 +11:00
aba3acf4cc
DEV: Correct deprecation id for discovery-controller-shims ( #24671 )
2023-12-01 19:11:48 +00:00
fb06cd6712
DEV: Add JS API to adjust desktop topic timeline min/max height ( #24669 )
2023-12-01 10:29:12 -06:00
d636ff216a
DEV: Resolve transitionTo deprecation in chat-channel route ( #24668 )
2023-12-01 16:01:59 +00:00
9f9c82ea97
DEV: Only add ember-global deprecation for Ember 3 ( #24667 )
...
(otherwise, we're accidentally extending support into Ember 5!)
Followup to 106c1c317f
2023-12-01 14:50:15 +00:00
f8bf4bda00
UX: fix info text color on custom field for login ( #24665 )
2023-12-01 14:41:44 +01:00
106c1c317f
DEV: Restore ember-global deprecation in production ( #24664 )
...
Even with our patch to the deprecate() macro, this is optimized out of the production build because it's wrapped in an `if(DEBUG)` statement. (https://github.com/davidtaylorhq/ember.js/blob/14c02f53b8/packages/%40ember/-internals/bootstrap/index.ts#L19-L19 )
2023-12-01 13:07:57 +00:00
Mark VanLandingham
David Taylor
Isaac Janzen
Bianca Nenciu
Discourse Translator Bot
chapoi
Daniel Waterworth
Joffrey JAFFEUX
dependabot[bot]
Ted Johansson
Martin Brennan
Keegan George
Kris
Roman Rizzi
Jan Cernik
Jarek Radosz
PhilippRenner
Krzysztof Kotlarek