discourse

Author SHA1 Message Date

Author	SHA1	Message	Date
Sam Saffron	4ea21fa2d0	DEV: use #frozen_string_literal: true on all spec This change both speeds up specs (less strings to allocate) and helps catch cases where methods in Discourse are mutating inputs. Overall we will be migrating everything to use #frozen_string_literal: true it will take a while, but this is the first and safest move in this direction	2019-04-30 10:27:42 +10:00
Gerhard Schlager	2bdbca3801	DEV: Remove unnecessary `to_not raise_error` from specs Follow-up to `01cdbd3a13`	2018-12-17 16:10:10 +01:00
Gerhard Schlager	01cdbd3a13	FEATURE: Prohibit S3 bucket reusage This validation makes sure that the s3_upload_bucket and the s3_backup_bucket have different values. The backup bucket is allowed to be a subfolder of the upload bucket. The other way around is forbidden because the backup system searches by prefix and would return all files stored within the backup bucket and its subfolders.	2018-12-17 11:35:28 +01:00

Sam Saffron

4ea21fa2d0

DEV: use #frozen_string_literal: true on all spec

This change both speeds up specs (less strings to allocate) and helps catch
cases where methods in Discourse are mutating inputs.

Overall we will be migrating everything to use #frozen_string_literal: true
it will take a while, but this is the first and safest move in this direction

2019-04-30 10:27:42 +10:00

Gerhard Schlager

2bdbca3801

DEV: Remove unnecessary `to_not raise_error` from specs

Follow-up to 01cdbd3a13

2018-12-17 16:10:10 +01:00

Gerhard Schlager

01cdbd3a13

FEATURE: Prohibit S3 bucket reusage

This validation makes sure that the s3_upload_bucket and the
s3_backup_bucket have different values. The backup bucket is
allowed to be a subfolder of the upload bucket. The other way
around is forbidden because the backup system searches by
prefix and would return all files stored within the backup
bucket and its subfolders.

2018-12-17 11:35:28 +01:00

3 Commits