Commit Graph

2297 Commits

Author SHA1 Message Date
Joffrey JAFFEUX 398f98c568
FIX: ensures reports links are correct on subfolder installs 2018-10-26 12:32:02 +02:00
Bianca Nenciu 2a77550f8c FIX: Do not track right clicks. (#6530) 2018-10-25 09:46:04 +00:00
Jeff Wong 0ead513fb0 PERF: remove total unread notifications from message bus (#6529) 2018-10-25 12:14:34 +11:00
Matthew Campbell 05438d99a8 FIX: Ensure the like button always has a title, for accessibility (#6525)
The like button previously didn't have a title for anonymous users,
because the `canToggleLike` flag wasn't set, but the `liked` flag wasn't
set either. This made the button inaccessible to blind users.
2018-10-24 13:58:42 +00:00
David Taylor 37b7afa522 FIX: Sanitize tags before creation 2018-10-22 10:53:42 +01:00
David Taylor 0dd717e641 Revert "FIX: Sanitize tags before creation"
This reverts commit 18ae8de9e5.
2018-10-19 15:49:05 +01:00
David Taylor 18ae8de9e5 FIX: Sanitize tags before creation 2018-10-19 15:43:31 +01:00
Bianca Nenciu 22ada32d4d FIX: Strip @ when searching for users and groups. (#6506) 2018-10-19 11:56:10 +11:00
Guo Xiang Tan 287e780f22 DEV: Skip tests instead of commenting out. 2018-10-18 11:06:03 +08:00
Bianca Nenciu 69dbd9b069 DEV: Comment test causing issues. 2018-10-17 20:29:21 +03:00
Bianca Nenciu 21d804fc92 DEV: Fix build. (#6500) 2018-10-17 17:39:25 +02:00
Bianca Nenciu f60b10d090 UX: Warn users if the post that's currently edited has changed. (#6498) 2018-10-17 15:35:32 +02:00
Maja Komel 27e732a58d FEATURE: allow multiple secrets for Discourse SSO provider
This splits off the logic between SSO keys used incoming vs outgoing, it allows to far better restrict who is allowed to log in using a site.

This allows for better auditing of the SSO provider feature
2018-10-15 16:03:53 +11:00
Maja Komel 57b52cd1de FIX: keep emoji syntax for custom emojis in quotes (#6488) 2018-10-15 10:57:15 +08:00
Guo Xiang Tan 84d4c81a26 FEATURE: Support backup uploads/downloads directly to/from S3.
This reverts commit 3c59106bac.
2018-10-15 09:43:31 +08:00
Bianca Nenciu ded5ff90aa FIX: Groups list does not refresh when query changes. (#6481) 2018-10-11 21:20:17 +08:00
Bianca Nenciu 6275e745a7 FIX: Fix open quote links in new window. (#6477) 2018-10-11 15:51:14 +08:00
Guo Xiang Tan 3c59106bac Revert "FEATURE: Support backup uploads/downloads directly to/from S3."
This reverts commit c29a4dddc1.

We're doing a beta bump soon so un-revert this after that is done.
2018-10-11 11:08:23 +08:00
Gerhard Schlager c29a4dddc1 FEATURE: Support backup uploads/downloads directly to/from S3. 2018-10-11 10:38:43 +08:00
Bianca Nenciu 1d26a473e7 FEATURE: Show "Recently used devices" in user preferences (#6335)
* FEATURE: Added MaxMindDb to resolve IP information.

* FEATURE: Added browser detection based on user agent.

* FEATURE: Added recently used devices in user preferences.

* DEV: Added acceptance test for recently used devices.

* UX: Do not show 'Show more' button if there aren't more tokens.

* DEV: Fix unit tests.

* DEV: Make changes after code review.

* Add more detailed unit tests.

* Improve logging messages.

* Minor coding style fixes.

* DEV: Use DropdownSelectBoxComponent and run Prettier.

* DEV: Fix unit tests.
2018-10-09 22:21:41 +08:00
Guo Xiang Tan 43512e9865
Merge pull request #6457 from pmusaraj/yarn-manage-test-vendor-dependencies
DEV: Use Yarn managed test vendor dependencies
2018-10-08 09:26:26 +08:00
David Taylor 75488257c5 FIX: Redirect users to top when `latest` is the homepage 2018-10-05 12:14:57 +01:00
David Taylor 9bf522f227
FEATURE: Mixed case tagging (#6454)
- By default, behaviour is not changed: tags are made lowercase upon creation and edit.

- If force_lowercase_tags is disabled, then mixed case tags are allowed.

- Tags must remain case-insensitively unique. This is enforced by ActiveRecord and Postgres.

- A migration is added to provide a `UNIQUE` index on `lower(name)`. Migration includes a safety to correct any current tags that do not meet the criteria.

- A `where_name` scope is added to `models/tag.rb`, to allow easy case-insensitive lookups. This is used instead of `Tag.where(name: "blah")`.

- URLs remain lowercase. Mixed case URLs are functional, but have the lowercase equivalent as the canonical.
2018-10-05 10:23:52 +01:00
David Taylor 9554d657c5 DEV: Remove underscore from tags-test 2018-10-04 21:14:52 +01:00
Penar Musaraj 4ae9cb28e4 remove probes.js, highlight.pack.js 2018-10-04 13:50:54 -04:00
Penar Musaraj cd82107976 use yarn to manage test vendor dependencies, upgrade sinon to v6.3.5 2018-10-04 11:06:14 -04:00
David Taylor 3c2608d41c
FIX: Correctly censor strings starting or ending with non-word characters (#6445) 2018-10-04 15:15:10 +01:00
Bianca Nenciu 6ad13e5ae9 FIX: Avoid redirection when not leaving forum. (#6419)
* FIX: Avoid redirection when not leaving forum.

* DEV: Updated click-track's tests.
2018-10-04 22:06:31 +08:00
Sam 41eacd859e temporarily comment out test 2018-10-03 14:07:30 +10:00
Maja Komel 73443d889c FIX: keep files in order when adding multiple uploads (#6306)
* FIX: keep files in order when adding multiple uploads

* use filename in the placeholder when uploading files

* add tests

* add consecutive nr to the placeholder when multiple uploads with the same filename
2018-10-03 11:12:36 +10:00
Kris cb519a3bec Fix test 2018-10-02 15:20:11 -04:00
Bianca Nenciu 719a433c03 FIX: Sync client & server rules regarding tag names. (#6400) 2018-10-01 21:45:44 -07:00
Kyle Zhao 4b517d460d FIX: dashboard test depended on the last month has 31 days 2018-10-01 12:31:27 +08:00
Kyle Zhao 373d6e3fe6
always `loadScript` with a script tag (#6411)
to avoid Content Security Policy unsafe-line violations
2018-10-01 10:06:01 +08:00
Joffrey JAFFEUX a713c0d366
FIX: ensures onSelect/onDeselect are called
This commit also add a FIX and a test for toolbar-popup-menu-options which had a behavior slightly specific.
2018-09-18 11:31:23 +02:00
Joffrey JAFFEUX 2ff2c49908 Revert "FIX: ensures onSelect/onDeselect are called"
This reverts commit 52eed73294.
2018-09-17 22:14:41 +02:00
Joffrey JAFFEUX 52eed73294
FIX: ensures onSelect/onDeselect are called 2018-09-17 10:36:14 +02:00
Sam e15a1e7c38 lint code 2018-09-17 11:10:09 +10:00
pmusaraj 03edb31a4d add tag-drop component test 2018-09-17 10:40:47 +10:00
Sam bc4e2aa07c correct prettier offence 2018-09-17 10:30:36 +10:00
Bianca Nenciu 8f39cf6bfc FIX: Permit unpinning an unlisted topic. 2018-09-17 10:03:06 +10:00
OsamaSayegh ca28548762 feedback (see commit description for details)
* fill blank space when no theme is selected
* animate row's height in themes/components list when selecting, and hide children list
* show warning when you move to a different page and have unsaved changes
* refactor `adminCustomizeThemes.show` controller
* allow collapsing/expanding children lists
* fix a bug when adding components to a theme (changed the way it works slightly)
* a bunch of other minor things
2018-09-17 09:49:53 +10:00
OsamaSayegh a4f057a589 UX: improvements to admin theme UI 2018-09-17 09:49:53 +10:00
Joffrey JAFFEUX 754d5b62a8
makes mini-tag-chooser test use can_create_tag (#6402) 2018-09-14 13:30:55 +02:00
Joffrey JAFFEUX d2ea618af1
adds a test for mini-tag-chooser 2018-09-14 12:13:00 +02:00
Joffrey JAFFEUX 38668818a5
FIX: allows forcing unsafe string in select-kit (#6386)
forceEscape will be defaulted to true before next release.
2018-09-12 12:19:04 +02:00
Guo Xiang Tan a033327b93 Manage qunit via yarn. 2018-09-11 15:07:28 +08:00
Guo Xiang Tan d788555994 DEV: Manage pretender with yarn. 2018-09-07 16:01:49 +08:00
Guo Xiang Tan 039afe0d2c Apply prettier. 2018-09-07 15:19:34 +08:00
Joffrey JAFFEUX 6c1e70d554
FIX: do no reset tags selection on category selection (#6369)
We will instead implement a server side solution to this in the future.
2018-09-06 10:35:07 +02:00
Joffrey JAFFEUX 17087eff2a
FIX: Reset tags on category change (#6363) 2018-09-05 17:18:52 +02:00
Sam fcae21c4fc remove test that is no longer relevant 2018-09-04 10:52:12 +10:00
Sam 3748d3e281 UX: hide associate accounts if second factor is enabled
Once second factor is enabled all login via associated accounts is banned
showing this section just leads to confusion
2018-09-04 10:42:39 +10:00
Bianca Nenciu f5e0356fb2 correct miscellaneous issues with user login history 2018-09-02 17:24:54 +10:00
Gerhard Schlager 16974df1e9 FIX: Resetting site setting didn't remove "overriden" state 2018-09-01 02:09:23 +02:00
Joffrey JAFFEUX ceae3d0a93
fix js tests (#6343) 2018-08-30 15:09:08 +02:00
Guo Xiang Tan f39c38d281 DEV: Support stable branch tests for `discourse-spoiler`. 2018-08-30 17:20:42 +08:00
Guo Xiang Tan 0f812aa768 Make prettier happy. 2018-08-30 15:56:30 +08:00
Vinoth Kannan 092fb0c170
Merge pull request #6333 from vinothkannans/rich-text-pasting
FIX: Use tight list format for GDocs html to markdown
2018-08-30 12:14:50 +05:30
Bianca Nenciu c1a5a7504e FIX: Reset email preferences controller. (#6316) 2018-08-29 23:10:56 +02:00
Vinoth Kannan 4c99acea1b FIX: Use tight list format for GDocs html to markdown 2018-08-29 16:21:31 +00:00
Kris afec673c2b Fixing test 2018-08-29 11:44:04 -04:00
Vinoth Kannan 26f17150e1
Merge pull request #6327 from vinothkannans/rich-text-pasting
FIX: Keep emojis and remove clicks count on html to markdown
2018-08-29 13:38:55 +05:30
Vinoth Kannan fb35b0b3c3 FIX: Keep emojis and remove clicks count 2018-08-29 07:26:25 +00:00
Sam 9ab1fb7dfc FEATURE: correctly store width and height on uploads
Previously we used width and height for thumbnails, new code ensures

1. We auto correct width and height
2. We added extra columns for thumbnail_width and height, this is determined
 by actual upload and no longer passed in as a side effect
3. Optimized Image now stores filesize which can be used for analysis, decisions

Also

- fixes Android image manifest as a side effect
- fixes issue where a thumbnail generated that is smaller than the upload is no longer used
2018-08-28 12:59:22 +10:00
Kris faf09bb8c8 Replacing default brown category color 2018-08-24 14:18:14 -04:00
Joffrey JAFFEUX 82dcc5cbfa
FEATURE: makes reports loadable in bulk (#6309) 2018-08-24 15:28:01 +02:00
Osama Sayegh e0cc29d658 FEATURE: themes and components split
* FEATURE: themes and components split

* two seperate methods to switch theme type

* use strict equality operator
2018-08-24 11:30:00 +10:00
Arpit Jalan 7a91df3248
Merge pull request #6290 from techAPJ/latest-full-name
UX: show full name on /latest page
2018-08-23 17:34:54 +05:30
Arpit Jalan 1a7cd6648b UX: show full name on /latest page 2018-08-23 14:41:06 +05:30
Joffrey JAFFEUX 07e11a223c
FIX: prefills username for new message on first post (#6305) 2018-08-23 11:09:35 +02:00
Guo Xiang Tan bd66fbef7f FIX: Post time query filter not set correctly when loaded from params.
https://meta.discourse.org/t/before-and-after-are-not-implemented-right-in-search/92515
2018-08-23 14:06:28 +08:00
James Kiesel b2ce33be26 FIX: tag intersection not populating (#6296)
* Fix for tag intersection not populating

* Fix prettier

* Add acceptance test for tags intersection
2018-08-23 14:22:47 +10:00
Joffrey JAFFEUX 87d443f070
FIX: counters were showing future instead of past (#6299) 2018-08-22 12:37:05 +02:00
Joffrey JAFFEUX 599cebf8ad
FIX: better message if request for report is rate limited (#6298) 2018-08-22 11:25:12 +02:00
Sam 5d96809abd FIX: improve support for subfolder S3 CDN 2018-08-22 12:31:13 +10:00
Guo Xiang Tan de2243319e Fix the build. 2018-08-20 16:25:59 +08:00
Guo Xiang Tan 658b55c406 FIX: Search does not retrigger when context has changed. Take 2.
https://meta.discourse.org/t/using-the-search-this-topic-check-box-blocks-search-on-other-pages/56832/6?u=tgxworld
2018-08-20 15:46:02 +08:00
Guo Xiang Tan 9c3ba98ef1 FIX: User can't save gravatar as profile picture after refresh.
https://meta.discourse.org/t/gravatar-issue-cant-save-changes/95076
2018-08-20 10:29:50 +08:00
Joffrey JAFFEUX 37d4f27c44
FIX: quality/bugfix dashboard/reports pass (#6283) 2018-08-17 16:19:25 +02:00
Joffrey JAFFEUX edf26a0931
uses emoji version for tests (#6277) 2018-08-16 14:06:56 +02:00
Gerhard Schlager 448e95b97d UX: Show anchor icon instead of text when topic bump is disabled 2018-08-11 21:51:13 +02:00
Gerhard Schlager ef4b9f98c1 FEATURE: Allow admins to reply without topic bump 2018-08-10 10:48:30 +10:00
Neil Lalonde f7b4a2b3ba FIX: ensure URLs include subfolder in admin emails UI 2018-08-08 16:48:03 -04:00
Joffrey JAFFEUX 7f2f3b8b22
FIX: improves reports resilience (#6239)
This commit makes most of the reports now lazy loaded, and making them benefits from graceful failures.
2018-08-06 16:57:40 -04:00
Joffrey JAFFEUX c301111461
FIX: display select kit body if no choices (#6237) 2018-08-06 11:22:48 -04:00
David Taylor 812add18bd REFACTOR: Serve auth provider information in the site serializer.
At the moment core providers are hard-coded in Javascript, and plugin providers get added to the JS payload at compile time. This refactor means that we only ship enabled providers to the client.
2018-08-06 09:25:48 +01:00
Joffrey JAFFEUX 066010db7d
FEATURE: introduces list/compact_list components 2018-08-03 16:41:37 -04:00
Joffrey JAFFEUX 9073e11943
FIX: improves number/percent support in reports 2018-08-01 18:40:59 -04:00
Penar Musaraj 1f45215537 FEATURE: Drafts view in user profile
* add drafts.json endpoint, user profile tab with drafts stream

* improve drafts stream display in user profile

* truncate excerpts in drafts list, better handling for resume draft action

* improve draft stream SQL query, add rspec tests

* if composer is open, quietly close it when user opens another draft from drafts stream; load PM draft only when user is in /u/username/messages (instead of /u/username)

* cleanup

* linting fixes

* apply prettier styling to modified files

* add client tests for drafts, includes a fixture for drafts.json

* improvements to code following review

* refresh drafts route when user deletes a draft open in the composer while being in the drafts route; minor prettier scss fix

* added more spec tests, deleted an acceptance test for removing drafts that was too finicky, formatting and code style fixes, added appEvent for draft:destroyed

* prettier, eslint fixes

* use "username_lower" from users table, added error handling for rejected promises

* adds guardian spec for can_see_drafts, adds improvements following code review

* move DraftsController spec to its own file

* fix failing drafts qunit test, use getOwner instead of deprecated this.container

* limit test fixture for draft.json testing to new_topic request only
2018-08-01 16:34:54 +10:00
Guo Xiang Tan b6939093eb Fix JS tests. 2018-08-01 11:21:46 +08:00
Joffrey JAFFEUX 2b2a506a7b
FIX: makes dashboard more resilient to errors (#6217)
This commit is an attempt to limit cases where the dashboard will generate a full exception page and also make it easier to track the error.
2018-07-31 21:23:28 -04:00
Joffrey JAFFEUX 0715aa18da
UI: uses tiny avatars for reports (#6215) 2018-07-31 18:57:00 -04:00
Joffrey JAFFEUX 37252c1a5e
UI: improves dashboard table reports
- support for avatars
- support for topic/post/user type in reports
- improved totals row UI
- minor css tweaks
2018-07-31 17:35:13 -04:00
Vinoth Kannan ece3cb73df Rename humburger_menu_categories_count site setting to header_dropdown_category_count 2018-07-31 09:12:30 +05:30
Vinoth Kannan b852275ced Test method for site categories random order fix 2018-07-31 01:36:37 +05:30
Vinoth Kannan c54b5824d4 REFACTOR: Prioritize unread categories in hamburger menu 2018-07-30 20:20:10 +05:30
Maja Komel c7c84606d9 fix prettier offense 2018-07-30 12:43:10 +02:00
Maja Komel 04baddf731 DEV: migrate tests to async/await 2018-07-30 12:21:05 +02:00
Vinoth Kannan 249b16e8e3 FIX: Hide muted categories from hamburger menu top categories block 2018-07-30 15:37:41 +05:30
Vinoth Kannan 78d91b1daf
UX: Changes in top categories of hamburger menu (#6200) 2018-07-30 14:13:00 +05:30
Arpit Jalan fc3b904e1f remove "track external right clicks" feature 2018-07-29 15:01:33 +05:30
Vinoth Kannan dac29b5ebc
UX: Display only top categories in hamburger menu (#6146) 2018-07-27 12:11:07 +05:30
Joffrey JAFFEUX 330cf78c83
FIX: don’t break browser history on dashboard visit (#6186) 2018-07-26 14:59:28 -04:00
Maja Komel a89dd51cae DEV: migrate acceptance tests to async/await 2018-07-26 12:51:16 +02:00
Kyle Zhao 1ed3a89ac9 UX: clear topic timer text when manually closing/opening (#6123)
* UX: clear topic timer text when manually closing/opening

* added test for clearing topic timer status text
2018-07-26 11:48:38 +10:00
Joffrey JAFFEUX ad95c24307
FEATURE: displays a notice if report has no data (#6178) 2018-07-25 14:28:41 -04:00
Régis Hanol 637850d867 REFACTOR: new 'show-avatar-select' app event to trigger the avatar selector modal 2018-07-25 12:38:15 +02:00
Dan Ungureanu 44a5c29d42 Clear old text and URL when showing up the "Insert Hyperink" modal. (#6138) 2018-07-25 17:12:49 +10:00
Maja Komel 3a52c2fa64 DEV: migrate widgets tests to async/await 2018-07-24 23:22:03 +02:00
Maja Komel d16a2c776a DEV: migrate components tests to async/await 2018-07-24 22:41:14 +02:00
Sam 95720e3873 lint files 2018-07-24 10:57:16 +10:00
Kyle Zhao c9d4288214 UX: auto fix order when reordering categories (#6149)
* set correct position number when moving up/down

* UX: drop 'fix order' and auto re-order subcategory

- auto "fix position" on save
- place subcategories after parent category and maintain the relative
positions on save
2018-07-24 10:25:40 +10:00
David Taylor eda1462b3b
FEATURE: List, revoke and reconnect associated accounts. Phase 1 (#6099)
Listing connections is supported for all built-in auth providers. Revoke and reconnect is currently only implemented for Facebook.
2018-07-23 16:51:57 +01:00
Joffrey JAFFEUX 9ed4071713
fixes dashboard next spec (#6132) 2018-07-21 10:29:58 -04:00
Guo Xiang Tan 863de8cb76 Make prettier happy. 2018-07-21 18:03:39 +08:00
Guo Xiang Tan 096e8ee21c Disable broken JS test for now. 2018-07-21 17:48:20 +08:00
Arpit Jalan 44e7f63d65 temporarily disable test for new-topic page 2018-07-20 17:49:16 +05:30
Joffrey JAFFEUX 194844fc66
fixes tests 2018-07-19 14:44:42 -04:00
Joffrey JAFFEUX 1a78e12f4e
FEATURE: part 2 of dashboard improvements
- moderation tab
- sorting/pagination
- improved third party reports support
- trending charts
- better perf
- many fixes
- refactoring
- new reports

Co-Authored-By: Simon Cossar <scossar@users.noreply.github.com>
2018-07-19 14:33:11 -04:00
Maja Komel 73739060f3
DEV: migrate acceptance tests to async await - plugin, reports, user, topic 2018-07-19 16:40:12 +02:00
Maja Komel 2e96646659 DEV: migrate acceptance tests to async await - invite, login, mobile 2018-07-19 16:38:37 +02:00
Joffrey JAFFEUX a2281fbb19
FEATURE: allows to jump to a date in a topic 2018-07-19 16:00:13 +02:00
Maja Komel 7f7944bc3a DEV: migrate acceptance tests to async await - dashboard, emoji, group 2018-07-19 14:00:03 +02:00
Maja Komel e36d1c72f1 DEV: migrate acceptance tests to async await - badges, category, composer, customHTML 2018-07-19 13:52:48 +02:00
Maja Komel 6aa2eb19d4 DEV: migrate acceptance tests to async await - admin, about, account created (#6111) 2018-07-19 17:35:10 +08:00
Maja Komel fa38891a98 FEATURE: show modal when user without permissions tries to delete their own topic (#6086) 2018-07-18 23:31:37 +02:00
Neil Lalonde afc94ac9e4 FEATURE: add a Top Categories section to the user summary page, showing the categories in which a user has the most activity 2018-07-18 16:39:16 -04:00
Régis Hanol f55ac892e4 make code prettier 🎀 2018-07-18 13:09:16 +02:00
Régis Hanol 6d6e026e3c FEATURE: selectable avatars 2018-07-18 12:57:43 +02:00
Philipp Rudloff 79b08b2679 Set result.target for update (matching _saveNew) (#6094)
* Set result.target for update (matching _saveNew)

* Add tests for update result including a target property
2018-07-17 11:56:32 -04:00
Sam e7102c73fb correct test and move to async 2018-07-17 09:10:55 +10:00
Sam ac0053f491 FEATURE: navigate to first post and auto bump category settings
### navigate_to_first_post_after_read setting for categories

When enabled on categories logged on users will return to OP after
reading the entire category. (useful for documentation categories)

### num_auto_bump_daily

Set a number of topics that will automatically bump daily on a category.

- Every 15 minutes we will check if any category has this setting
- Categories with the setting are shuffled
- We exclude pinned, closed, category description and archived topics
- Maximum of 1 topic for the list of categories is bumped till limit reached per category
- We always try to bump oldest first
- Limit is elastic using a RateLimiter that ensures that we only bump N per day

Also some minor organisation on category settings

Froze strings on category.rb
2018-07-16 18:10:35 +10:00
Guo Xiang Tan 767395449f Make prettier happy. 2018-07-16 11:31:23 +08:00
Leo McArdle 21ebb1cd54 FEATURE: Secondary emails support. 2018-07-16 11:09:49 +08:00
Neil Lalonde 8ceed642cb FIX: wrong url for default logos in header on subfolder installs 2018-07-13 14:21:15 -04:00
Guo Xiang Tan 711371e8c8 FIX: Select+below will ask server for post ids on megatopics. 2018-07-13 15:10:39 +08:00
Guo Xiang Tan 409a30ce1c FIX: Selecting & moving posts not working on megatopics. 2018-07-13 11:16:43 +08:00
Guo Xiang Tan 18e281606a UX: Clicking admin menu does not hide select posts box. 2018-07-13 10:56:14 +08:00
Sam 1f0bbca87e FIX: on initial load category subcategories were not mapped correctly 2018-07-12 17:59:56 +10:00
Guo Xiang Tan 258e9e35ca PERF: Make mega topics work without a stream.
There are tradeoffs that we took here. For the complete
story see
https://meta.discourse.org/t/performance-improvements-on-long-topics/30187/27?u=tgxworld.
2018-07-12 12:46:12 +08:00
OsamaSayegh f13a7226db FIX: display tables in posts history diff (#6032) 2018-07-12 14:13:52 +10:00
Guo Xiang Tan 8f4cb1a742 UX: Timeline lookup on mega topics should use date of current post. 2018-07-10 16:43:20 +08:00
Sam d9a9682f72 FIX: also count sub categories in hamburger when needed
previously there were cases where we suppress subcategories yet don't count them
this leads to confusion
2018-07-09 16:52:55 +10:00
Maja Komel 7cba4cbcc6 FEATURE: allow selecting a tag when moving posts to a new topic (#6074) 2018-07-06 18:21:00 +02:00
Joe 98478d78d7
FIX: update test to match new admin layout 2018-07-03 17:03:43 +08:00
Joe 9834263687
FIX: update test to match admin layout changes 2018-07-03 16:28:57 +08:00
Joffrey JAFFEUX c754ece8f5
FEATURE: drops with-email-link and replaces it by with-email-button 2018-07-02 14:35:50 +02:00
Maja Komel 3ddfc12307 unify user preferences views 2018-07-02 15:38:36 +10:00
Guo Xiang Tan d1c3eb6bfa FIX: Recovering a post does not insert it back into the stream correctly. 2018-06-29 11:41:44 +08:00
Joffrey JAFFEUX 9f4e814dbc
tests for XSS injection in tooltips 2018-06-28 14:24:21 +02:00
Maja Komel ec3e6a81a4 FEATURE: Second factor backup 2018-06-28 10:12:32 +02:00
Jeff Atwood 7dce8290ed copyedit on category drop down 2018-06-26 12:43:45 -07:00
OsamaSayegh d81f8ea378
fix prettier 2018-06-26 15:31:43 +03:00
OsamaSayegh bfe0178270 FIX: use the correct notification levels titles for PMs 2018-06-26 14:01:52 +02:00
Joffrey JAFFEUX eb9b99e519
FIX: makes select-kit match searches with accents (filter and content) 2018-06-26 12:19:14 +02:00
Joffrey JAFFEUX f2dbe66367
FEATURE: adds a /admin/reports route to list all reports 2018-06-18 12:31:56 +02:00
Joffrey JAFFEUX 60ff0e9b8c
missing prettified files 2018-06-15 18:42:20 +02:00
Joffrey JAFFEUX 2268e29c26
fix linting removed by prettier 2018-06-15 18:18:45 +02:00
Joffrey JAFFEUX 03a7d532cf
DEV: introduces prettier for es6 files 2018-06-15 17:03:24 +02:00
OsamaSayegh 629a2fbc2b add JS tests 2018-06-15 14:04:14 +10:00
Joffrey JAFFEUX eddcb07f03 FEATURE: adds plugin sharing api 2018-06-13 13:25:51 +02:00
Joffrey JAFFEUX 3381a0a42a
UX: reworks dashboard problems section to be in line with new style 2018-06-12 12:47:03 +02:00
kleinfreund 4ce1d230c7 Prefer throwing a new Error object instead of just a string expression 2018-06-12 12:56:22 +10:00
Jeff Wong b7d92061e2 FEATURE: add an option to create undismissable modals 2018-06-07 20:49:33 -07:00
Joffrey JAFFEUX 1071aa21ab
FIX: slightly safer rounding 2018-06-07 10:59:17 +02:00
Joffrey JAFFEUX ab089cd68b
FIX: makes format number round the value before using parseInt 2018-06-07 10:44:21 +02:00
Joffrey JAFFEUX 43b1768987
UX: ceil dahsboard values 2018-05-30 16:32:43 +02:00
Joffrey JAFFEUX 82e5727287
UX: -2/+2% change in stats should be no-change in dashboard 2018-05-28 10:55:42 +02:00
Guo Xiang Tan 0b55416742 UX: Don't display `all groups` option if group directory is disabled.a
https://meta.discourse.org/t/all-groups-option-leads-to-access-denied-page/88464
2018-05-28 11:32:55 +08:00
Joffrey JAFFEUX 1be76d066c
FIX: forces boolean when content is only "true" && "false" 2018-05-24 23:41:39 +02:00
Sam 70179290f3 clean up callbacks during acceptance tests 2018-05-24 15:28:54 +10:00
Sam 4194886b62 correct failing test 2018-05-24 13:02:20 +10:00
Joffrey JAFFEUX db91d71bf1
fix category chooser spec 2018-05-23 21:07:39 +02:00
Joffrey JAFFEUX ae004d8b2b
attempts of making composer actions test more resilient 2018-05-23 19:57:12 +02:00
Joffrey JAFFEUX 7232a6e5a9
FIX: do not show composer actions if irrelevant 2018-05-23 18:25:58 +02:00
Joffrey JAFFEUX d2efd338e6
rewrites all composer actions tests using await 2018-05-23 15:52:15 +02:00
Joffrey JAFFEUX dd76ba90b3
FIX: bbcode regex was greedy and preventing quotes 2018-05-23 11:55:02 +02:00
Sam 930ebb5684 skip failing test 2018-05-23 13:26:42 +10:00
Sam 41d37fd498 improve erratic test 2018-05-23 10:16:52 +10:00
Sam 8e9531657a skip erratic test 2018-05-23 08:28:00 +10:00
Joffrey JAFFEUX a0c5b48558
fix failing spec 2018-05-22 10:50:54 +02:00
Sam 9e2131ace8 improve erratic test 2018-05-22 13:58:12 +10:00
Sam 99088f4d77 skip slow erratic test 2018-05-22 13:03:26 +10:00
Jeff Atwood 4329b484e8 minor copyedit on dashboard chart title 2018-05-18 16:04:33 -07:00
Joffrey JAFFEUX af548c23c4
new dashboard quality pass (code, tests and UI) 2018-05-17 22:44:33 +02:00
Sam 17a7bb8e23 use async test 2018-05-17 17:18:22 +10:00
Régis Hanol 674318e127 UX: don't show 'auto delete' option for TL4 2018-05-17 00:42:48 +02:00
Régis Hanol 938934f5e9 FIX: keep '<kbd>' formatting when quoting posts 2018-05-16 17:40:45 +02:00
Joffrey JAFFEUX 9554d9c56a
UX: tooltips and improvements to new dashboard
- tooltips
- revert chart title UI
- reduce period chooser font-size
- localize dates of data points
- fix a bug where multiple reports were loaded at the same time
- fix a bug where % was not showing anymore
- remove spacing at the top
- remove loadingTitle feature (Loading...%report name%) incompatible with new hijack design
2018-05-16 16:45:21 +02:00
Joe Buhlig 3cd4c82c49 Allow parameters for group and username filters on directory (#5815) 2018-05-16 16:20:17 +02:00
Sam f08ff84c5c missing a fixture for acceptance test 2018-05-15 15:34:40 +10:00
Joffrey JAFFEUX e474351ae4
inactive users report is not used anymore 2018-05-14 21:31:14 +02:00
Régis Hanol b004503c62 fix the build 2018-05-14 20:07:00 +02:00
Sam e1d7f3bb94 correct fixture 2018-05-14 15:46:58 +10:00
Sam a6aa986d3b correct spec 2018-05-14 15:41:19 +10:00
Régis Hanol 81f4da7dd2 FIX: remove unneeded escape when building a Quote 2018-05-12 01:16:05 +02:00
Sam 8a783412b7 UX: improvements to new dashboard
- remove inactive user report and replace with posts
- clean up internals so grouping by week happens on client
- when switching periods old report was not destroyed leading to bugs
- calculate trend based on previous interval ... not previous 30 days
- show percentages for mau/dau
- be more careful about utc date usage
- show uniqu and click through rate on search panel
- publish key of report with report so we only load the correct one
- subscribe earlier in channel in case of concurrency issues
2018-05-11 13:30:32 +10:00
Régis Hanol deaf3682e9 FIX: clicking a group mention on mobile was 404ing
(cc @featheredtoast)
2018-05-09 17:27:59 +02:00
Régis Hanol 3483c7bc58 FIX: supports user/group mentions and category hashtags when quoting posts 2018-05-09 12:42:12 +02:00
Guo Xiang Tan 32147d4ff9 FIX: Search term scoped to topic should be highlighted in widget dom era.
https://meta.discourse.org/t/highlight-the-search-results/10322/4?u=tgxworld
2018-05-07 15:17:34 +08:00
Neil Lalonde 3a145b7551 fix group-test.js 2018-05-03 16:00:56 -04:00
Joffrey JAFFEUX 980972182f
dashboard next: caching, mobile support and new charts 2018-05-03 15:41:41 +02:00
Joffrey JAFFEUX 37a0ceb4e7
Adds fixture for new contributors 2018-04-26 17:39:00 +02:00
Joffrey JAFFEUX a9c3437d51
dashboard next: adds basic spec 2018-04-25 10:28:41 +02:00
Joffrey JAFFEUX 59d4123316
PERFORMANCE: disables jquery animations during testing 2018-04-24 18:29:26 +02:00
Sam 54d153068a DEV: remove qunit rails fork and add a couple of async tests 2018-04-23 16:42:40 +10:00
Jeff Wong 252dd32895 show card on preview panel.
refactor user and group cards

refactor userLoading to loading

add logic to display cards above mentions for fixed placements
2018-04-20 12:28:24 -07:00
Guo Xiang Tan 6cce839f0a FIX: Missing action to trigger add group members modal for group owners.
https://meta.discourse.org/t/unable-to-add-members-to-a-group-as-group-owner-who-is-not-staff/85346?u=tgxworld
2018-04-16 09:09:47 +08:00
Neil Lalonde 0e2584b841 fix cursor on disabled composer 2018-04-12 11:32:13 -04:00
Guo Xiang Tan a389baeb07 FIX: Group pages should work when group name contains periods.
https://meta.discourse.org/t/group-name-cant-have-dot-inside/48658
2018-04-12 17:11:36 +08:00
Guo Xiang Tan c0595ebe99 FIX: Disable save button when new group form is empty.
https://meta.discourse.org/t/adding-owners-members-ux-is-inconsistent-and-misleading/58084/26?u=tgxworld
2018-04-12 10:29:36 +08:00
Guo Xiang Tan 66abd340db Fix randomly failing JS build.
For some reason, the test rack server would block on
a `/letter_avatar_proxy` route causing ajax requests to
stack up.
2018-04-11 22:23:49 +08:00
Neil Lalonde 6e6892c88e FEATURE: when uncategorized topics are not allowed, disable the post input until a category is chosen 2018-04-10 19:31:28 -04:00
Joffrey JAFFEUX d9ac0152e4
fixes search-full-test for revamped search page 2018-04-10 09:59:24 +02:00
Neil Lalonde d7ea6f93e7 FIX: preference page error when badges are disabled 2018-04-09 14:27:00 -04:00
Régis Hanol 1b351a3355 disable full page search acceptance tests (cc @jjaffeux) 2018-04-09 20:14:57 +02:00
Guo Xiang Tan c82b2dcc24 Remove admin group management pages. 2018-04-09 15:14:50 +08:00
Guo Xiang Tan 4319273cf5 UX: Split up group form into smaller sections. 2018-04-09 15:14:50 +08:00
Claas Augner ba905b24ca FIX: differentiate one/other select-kit maximumLabel/minimumLabel 2018-04-09 09:12:01 +02:00
Joffrey JAFFEUX f0fe16d824
FEATURE: implements minimum selection for select-kit 2018-04-05 16:45:19 +02:00
Guo Xiang Tan e36e9de28a Allow admin to view logs of automatic groups. 2018-04-05 16:31:55 +08:00
Robin Ward 895bca5f5b FIX: Broken JS tests 2018-04-02 14:18:10 -04:00
Joffrey JAFFEUX 3287ac77e0
FIX: reverts combobox placeholder and introduces noneLabel
noneLabels works almost like none but instead of actually adding a row in the list, it will only change the text displayed in the header, when there's no selection.
2018-03-29 13:42:00 +02:00
Guo Xiang Tan 52e75eaee9 UX: Tweaks to group pages. 2018-03-29 17:04:48 +08:00
Guo Xiang Tan baa383b7f1 Fix the build. 2018-03-28 09:42:12 +08:00
Joffrey JAFFEUX 15aa712227
fix category-row regressions 2018-03-27 14:11:05 +02:00
Guo Xiang Tan f6b6ddd73c REFACTOR: Extract group form into a component. 2018-03-27 19:26:05 +08:00
Guo Xiang Tan bc4de7b5ec Make eslint happy. 2018-03-27 17:44:04 +08:00
Guo Xiang Tan 7edab1c0b9 UX: Add `groups/custom/new` route for admins to create a new group. 2018-03-27 17:39:05 +08:00
Guo Xiang Tan 2ecd234e27 UX: Consolidation group manangement into a single tab. 2018-03-27 13:34:46 +08:00
Guo Xiang Tan dcd1d422d1 UX: Allow admins to set users as owners while adding users.
https://meta.discourse.org/t/adding-owners-members-ux-is-inconsistent-and-misleading/58084/9
2018-03-26 17:33:50 +08:00
Guo Xiang Tan 27e60c78d4 Remove obsolete JS tests. 2018-03-26 16:26:42 +08:00
Guo Xiang Tan 35745166b5 UX: New group membership management workflow.
https://meta.discourse.org/t/adding-owners-members-ux-is-inconsistent-and-misleading/58084
2018-03-26 16:15:02 +08:00
Joffrey JAFFEUX d48542796e
FIX: select-kit refactoring
- improve mini-tag-chooser keyboard behavior
- all multil select now respond to select all and left/right arrows
- improve events handling
- many minor tweaks
2018-03-22 11:29:55 +01:00
Guo Xiang Tan f3b402ffd5 UX: Allow users to filter members on group page.
* Only admins are allowed to filter users by email.
2018-03-22 14:02:41 +08:00
Guo Xiang Tan be866dbe6e UX: Allow group owners to manage members from group members page. 2018-03-21 18:22:55 +08:00
Robin Ward b9abd7dc9e FEATURE: Shared Drafts
This feature can be enabled by choosing a destination for the
`shared drafts category` site setting.

* Staff members can create shared drafts, choosing a destination
category for the topic when it is published.

* Shared Drafts can be viewed in their category, or above the
topic list for the destination category where it will end up.

* When the shared draft is ready, it can be published to the
appropriate category by clicking a button on the topic view.

* When published, Drafts change their timestamps to the current
time, and any edits to the original post are removed.
2018-03-20 17:15:26 -04:00
Neil Lalonde a9de712eed FIX: not found message when trying to log in with a link, even though the email with the link was successfully sent 2018-03-19 16:08:10 -04:00
Guo Xiang Tan 2b7fb43d84 Fix the build. 2018-03-19 18:47:17 +08:00
Guo Xiang Tan fe96ef6ed2 UX: Use topic list for displaying group messages on group page.
https://meta.discourse.org/t/group-inbox-on-a-groups-page-mockup/71319
2018-03-16 11:56:40 +08:00
Guo Xiang Tan a35227918f UX: Display group topics in a topic list. 2018-03-15 11:37:55 +08:00
Gerhard Schlager 243ee565dc Reset widget decorators after each test 2018-03-12 14:22:50 +01:00
Sam b57d4c87a4 FEATURE: update CommonMark to version 0.28 2018-03-08 12:19:53 +11:00
Gerhard Schlager 8e48b339fa Drop unused tables (#5630) 2018-03-05 17:27:30 -05:00
Joffrey JAFFEUX 6d4ff05cf0
FIX: makes sure [999500..999999] is correctly shown as 999k 2018-03-02 11:00:48 +01:00
Guo Xiang Tan b9ff6d60b9 Fix the build. 2018-03-02 14:43:02 +08:00
Guo Xiang Tan d9b4b12694 UX: Display warning message about social logins disabled when 2FA is enabled. 2018-03-02 14:22:52 +08:00
Arpit Jalan 841e58fc46 delete extra blank lines 2018-02-27 15:51:50 +05:30
Arpit Jalan ec8cc833c6 fix the build 2018-02-27 15:48:36 +05:30
Arpit Jalan 4010d8d9f9 FEATURE: show "edit message" button on message footer for staff
Show "Edit Message" button on personal message footer for staff if PM tagging is enabled.
2018-02-27 14:22:03 +05:30
Guo Xiang Tan 24bd310d7b Fix the build. 2018-02-27 10:15:13 +08:00
Neil Lalonde 3313072957 Remove censored_pattern site setting, which is replaced by watched words 2018-02-26 16:29:27 -05:00
Joffrey JAFFEUX ac701696b3
FEATURE: replaces tag-chooser/tag-group-chooser with select-kit component
These component were also the last using select2. As a consequence select2 is removed from Discourse in this commit.
2018-02-26 11:42:57 +01:00
Joffrey JAFFEUX 6f5acfe783 Login with email/forget password UI refactoring
* move button into login modal with social buttons
* adds email link next to login field when filling it
* adds proper validation messages
* improves forgot password flash clearing
* more tests
2018-02-22 08:06:15 +08:00
Guo Xiang Tan 14f3594f9f Review Changes for f4f8a293e7. 2018-02-21 14:55:49 +08:00
Jeff Wong f4f8a293e7 FEATURE: Implement 2factor login TOTP
implemented review items.

Blocking previous codes - valid 2-factor auth tokens can only be authenticated once/30 seconds.
I played with updating the “last used” any time the token was attempted but that seemed to be overkill, and frustrating as to why a token would fail.
Translatable texts.
Move second factor logic to a helper class.
Move second factor specific controller endpoints to its own controller.
Move serialization logic for 2-factor details in admin user views.
Add a login ember component for de-duplication
Fix up code formatting
Change verbiage of google authenticator

add controller tests:
second factor controller tests
change email tests
change password tests
admin login tests

add qunit tests - password reset, preferences

fix: check for 2factor on change email controller
fix: email controller - only show second factor errors on attempt
fix: check against 'true' to enable second factor.

Add modal for explaining what 2fa with links to Google Authenticator/FreeOTP

add two factor to email signin link

rate limit if second factor token present

add rate limiter test for second factor attempts
2018-02-21 09:04:07 +08:00
OsamaSayegh f3815cd785 FEATURE: New site setting for additional allowed filetypes for staff (#5364)
* FEATURE: New site setting for additional allowed filetypes for staff

* Problematic variable name

* feedback

* small issues

* fix indentation

* failing tests

* Remove message bus and fix minor issues

* Missed this message bus
2018-02-19 10:44:24 +01:00
Joffrey JAFFEUX 25dd8ff62a
FIX: broken composer-actions spec 2018-02-14 11:32:20 +01:00
Erick Guan 03b3e57a44 FEATURE: login by a link from email
Co-authored-by: tgxworld <tgx@discourse.org>
2018-02-13 16:14:39 +08:00
Sam b34b1b6fe3 FIX: invite to message was not allowing groups
Previously we were incorrectly checking mentionable instead of messageable

Also fix edge case where multiple groups sharing a name mean that exact match override is not working

Also cleans up params sent to user selector
2018-02-13 13:28:46 +11:00
Vinoth Kannan 91beedd0ca FEATURE: Composer HTML pasting ul tag support for MS Word 2018-02-10 01:18:56 +05:30
Joffrey JAFFEUX 190d208631
FEATURE: improves composer-actions toggle menu
* only toggles
* fix a bug with presence
* more tests
* do not duplicate `continuing discussion...` text
* persist state to allow switching between toggles
2018-02-08 11:46:55 +01:00
Robin Ward 80ea2e5107 FIX: Enable personal messages in tests 2018-02-02 17:06:02 -05:00
Robin Ward 8ff4104555 Many enhancements to the flagging / suspending interface. 2018-02-01 17:13:02 -05:00
Joffrey JAFFEUX f7df68c9a3
FIX: makes composer-actions toggling whisper instead of replying 2018-02-01 23:07:37 +01:00
Joffrey JAFFEUX 97ddaeeae8
FIX: use css instead of js to fix select-kit-collection max-height 2018-02-01 16:56:07 +01:00
Joffrey JAFFEUX 9923829402
FEATURE: Menu toggle for different reply modes
Allow users to access different reply modes from the composer.

Actions introduced:

- reply_as_new_topic
- reply_as_private_message
- reply_to_topic
- reply_as_whisper/not
2018-02-01 16:42:56 +01:00
Robin Ward 96710754d9
Merge pull request #5540 from discourse/mixed-text-direction-support
FEATURE: Mixed text direction support
2018-02-01 07:29:15 -08:00
Arpit Jalan 49424fd798 rename private to personal 2018-02-01 13:25:29 +05:30
Arpit Jalan ff0376a80b rename 'enable_private_messages' to 'enable_personal_messages' 2018-02-01 13:25:29 +05:30
Arpit Jalan 25ec077eca rename 'min_private_message_{post/title}_length' to 'min_personal_message_{post/title}_length' 2018-02-01 13:25:29 +05:30
Sam 187b0031c5 correct specs 2018-02-01 16:16:14 +11:00
Vinoth Kannan 10ed4c0078 FEATURE: Composer HTML pasting support for complex table formats 2018-01-31 01:39:11 +05:30
scossar 843d88c5d0 Remove unused imports 2018-01-29 20:11:12 -08:00
scossar 5d18f72b8c Add tests for text-direction functions 2018-01-29 19:16:35 -08:00
scossar 41f1e7430c Refactor code; add tests 2018-01-29 17:42:19 -08:00
Gerhard Schlager eb52c5469e FEATURE: Allow plugins to register a new locale 2018-01-25 14:57:41 +01:00
Neil Lalonde dc97239040 FIX: censored regex words were replacing other text that shouldn't be censored 2018-01-24 12:33:47 -05:00
Sam 3b083ca0bd correct spec 2018-01-24 13:23:27 +11:00
Vinoth Kannan 86e142b39f UX: Copy selected text to the link building modal 2018-01-24 02:02:12 +05:30
Régis Hanol c425a2d335 fix js suite 2018-01-22 17:48:03 +01:00
Kyle Zhao 83c549bd31 FEATURE: grant badges in post admin wrench (#5498)
* FEATURE: grant badges in post admin wrench

* only grant manually grantable badges

* extract GrantBadgeController mixin
2018-01-22 14:10:53 +11:00
Régis Hanol f674b9e86e FIX: encode image filename so '[', ']' and '|' doesn't break the markdown 2018-01-19 19:52:03 +01:00
Jeff Atwood 7ed41fae2b
Merge pull request #5493 from notriddle/home_logo_h1
Change the text-only home logo to an H1
2018-01-18 16:14:36 -08:00
Arpit Jalan 79eb9d7086 FEATURE: show header search results on search log term details page 2018-01-17 12:47:16 +05:30
Arpit Jalan bd7e21fa99 fix the build 2018-01-15 14:35:11 +05:30
Arpit Jalan 785d063a6b
Merge pull request #5496 from techAPJ/admin-graphs
FIX: graphs should go to zero for missing dates
2018-01-15 11:10:29 +05:30
Arpit Jalan b7ba490df7 FIX: graphs should go to zero for missing dates 2018-01-15 10:16:34 +05:30
Michael Howell f29d233287 Fix test case for site logo as `<h2>` 2018-01-12 23:34:31 +00:00
Neil Lalonde 2493648f9c PERF: calculate topic_counts for tags in an async job so tag queries that include counts are much faster 2018-01-12 11:03:03 -05:00
Joffrey JAFFEUX e9fd4f271a
FIX: fix category-link spec failure 2018-01-11 13:43:05 +01:00
Joffrey JAFFEUX 3ee7b18886
FIX: disable by default limitMatches 2018-01-11 09:54:39 +01:00
Joffrey JAFFEUX 3ec2024466
select-kit refactoring
* improve events naming/handling
* do not explicitly check for true/Fasle
* make sure header is re-computed on toggle
2018-01-11 09:39:51 +01:00
Neil Lalonde edb3a7f646 FIX: support for watched_words_regular_expressions when censoring words 2018-01-10 14:11:23 -05:00
Neil Lalonde ad62f1099c FIX: censored words should support * as wildcard 2018-01-09 15:53:40 -05:00
Joffrey JAFFEUX c9921869f1
FIX: adds select-kit api to modify header computed content (#5476)
This api would allow to simply modify header text or icons, eg:

```
      api.modifySelectKit("select-kit")
        .modifyHeaderComputedContent((context, computedContent) => {
          computedContent.title = "Not so evil";
          return computedContent;
        });
```
2018-01-09 10:52:32 +01:00
Robin Ward fb863e18ec FIX: Broken test 2018-01-08 17:22:53 -05:00
Vinoth Kannan d18c42abd5 FIX: Ignore if the default localization node is not an object (#5439) 2017-12-27 16:53:53 +11:00
Vinoth Kannan 035f96d25f Allow linked images inside table cells in HTML to Markdown conversion 2017-12-23 22:48:39 +05:30
Vinoth Kannan 3ae9d91d86 UX: Use tight list by default in HTML to Markdown conversion 2017-12-22 21:34:55 +05:30
Vinoth Kannan ac1e93e82a Minor fix to correctly trim spaces in HTML to Markdown conversion 2017-12-22 19:05:40 +05:30
Joffrey JAFFEUX 315b9d796d
select-kit refactoring
* better test helper
* more reliable tests
* more consistent use of data-value/data-name/title/aria-label everywhere: header and rows
2017-12-22 13:08:12 +01:00
Vinoth Kannan 4935ae4338 Remove unwanted spaces between HTML tags and support Word documents 2017-12-22 09:28:24 +05:30
Sam ab2215e629 fix broken test 2017-12-21 20:19:15 +11:00
Vinoth Kannan 129d924c0d Dont support single row or column tables in HTML to Markdown conversion 2017-12-21 12:58:57 +05:30
Vinoth Kannan ac1d3a761e Support for table & ol tags for HTML pasting in composer 2017-12-20 19:24:55 +05:30
Guo Xiang Tan 87c334c063 Fix randomly failing JS acceptance tests. 2017-12-20 11:04:47 +08:00
Arpit Jalan eab66065d1 FEATURE: search log term details page (#5445) 2017-12-20 13:41:31 +11:00
Vinoth Kannan 6272f35eec blockquote tag support for HTML pasting in composer 2017-12-19 20:59:55 +05:30
Guo Xiang Tan dfed56cb57 Disable JS test that fails in headless mode. 2017-12-19 20:50:39 +08:00
Guo Xiang Tan 6a4f391e38 Switch to chrome headless mode instead of phantomjs. 2017-12-19 16:00:43 +08:00
Vinoth Kannan ad41523895 FEATURE: Converting code tags to Markdown while pasting 2017-12-18 22:12:05 +05:30
Vinoth Kannan 0588edbc96 FEATURE: Keep supported HTML tags in HTML to Markdown conversion 2017-12-18 12:48:17 +05:30
Vinoth Kannan 4f2f42d710 PERF: Better handling of headings in HTML inline pasting 2017-12-17 00:45:21 +05:30
Vinoth Kannan dc159d7fa6 Grab dimention of the clipboard images 2017-12-15 17:28:38 +05:30
Guo Xiang Tan 0f011e1c1c Update fixtures to fix JS test. 2017-12-15 13:42:17 +08:00
Vinoth Kannan f0497ee9c4
FEATURE: HTML to Markdown conversion using native JavaScript ES6 classes (#5425) 2017-12-15 10:28:20 +05:30
Régis Hanol 2f792bc59f FIX: a topic should be visited when you've read everything and there's deleted posts at the end 2017-12-15 00:00:48 +01:00
Régis Hanol cad122993a eslint 😲 🔫 2017-12-13 22:24:02 +01:00
Régis Hanol 1b4483c942 FEATURE: Added 'select +below' and 'select +all replies' options to selecting posts 2017-12-13 22:12:06 +01:00
Joffrey JAFFEUX c1c31b99ce
Replaces toolbar popup-menu with select-kit 2017-12-13 10:49:32 +01:00
Robin Ward 74b9828731 FIX: Remove mentions filters from user and groups
Additionally return no data if disabled
2017-12-07 16:29:02 -05:00
Joffrey JAFFEUX fd99e1ef56 FEATURE: site setting enable_mentions to turn on/off mentions 2017-12-07 16:27:58 -05:00
Neil Lalonde 23ea4b6739 FIX: don't create featured link if title includes more than a url 2017-12-04 14:21:08 -05:00
Neil Lalonde fb08441802 Revert "FIX: don't create featured link if title includes more than a url" 2017-12-04 12:53:12 -05:00
Neil Lalonde cde42c3f69 FIX: don't create featured link if title includes more than a url 2017-12-04 12:03:41 -05:00
Joffrey JAFFEUX dbadebacd1
FIX: allows select-kit to search by null value 2017-12-01 20:02:00 +01:00
Arpit Jalan 496cd3b4df
Merge pull request #5385 from techAPJ/search-logs-improvements
FEATURE: support search click through tracking for user, category and tags
2017-12-01 12:08:38 +05:30
Arpit Jalan e3925278e2 FEATURE: support search click through tracking for user, category and tags
https://meta.discourse.org/t/search-logs-page/73281/11?u=techapj

This commit adds following features:

- support for tracking click through to user, tag and category
- new filter for search type (header, full page)

This commit also removes "most viewed topic" field from search logs page because we are now tracking multiple click through entities, so topic is not a special entity anymore. This also improves query perf. The query now takes `20.5ms` to runs, as opposed to `655.9ms` previously.
2017-12-01 12:04:55 +05:30
Arpit Jalan fb735d78ef fix the build 2017-11-30 17:28:36 +05:30
Sam 610d7a9412 teach acceptance test to work on the last day of the month 2017-11-30 13:20:04 +11:00
Gerhard Schlager 41e70c410c
FEATURE: replace GUID in image name uploaded from iOS (#5370) 2017-11-28 11:05:34 +01:00
Joffrey JAFFEUX 49b1df40fc
FIX: various issues when editing category permissions
This commit also adds multiple tests
2017-11-27 19:50:04 +01:00
Joffrey JAFFEUX 87ada55e67
FIX: avoids test failing at some times of the day 2017-11-27 10:49:35 +01:00
Joffrey JAFFEUX 96cdc4e66e
FIX: makes allowInitialValueMutation more restrictive 2017-11-24 13:15:02 +01:00
Joffrey JAFFEUX 63307c303a
FIX: regression preventing to set number of hours before closing
This commit also adds a full test suite for editing topic timer.
2017-11-24 02:48:45 +01:00
Joffrey JAFFEUX 9208909b26 tweak icon-library generation 2017-11-23 18:24:26 +01:00
Neil Lalonde ac4b4e30dc remove the test that only works in a browser 2017-11-22 15:23:06 -05:00
Neil Lalonde 6c86e0c94a FEATURE: remove the featured link by editing the topic 2017-11-22 14:53:35 -05:00
Joffrey JAFFEUX b14d9529b8
FIX: adds support for name changes tracking 2017-11-22 13:49:45 +01:00
Joffrey JAFFEUX b2b565c2fb
select-kit initial plugin api implementation (0.8.13)
```
api.modifySelectKit("identifier-of-the-select-targeted")
  .modifyContent((context, existingContent) => {})
  .appendContent(() => {})
  .prependContent(() => {})
  .onSelect((context, val) => {});
```
2017-11-22 10:34:12 +01:00
Neil Lalonde 33feb62673 FIX: times showing as < 1m instead of blank 2017-11-21 14:33:49 -05:00
Robin Ward 7533e5b541 UX: Use date picker on full page search 2017-11-21 12:52:23 -05:00
Joffrey JAFFEUX 39f3dbd945
Introduces select-kit
* renames `select-box-kit` into `select-kit`
* introduces `single-select` and `multi-select` as base components
* introduces {{search-advanced-category-chooser}} as a better component for selecting category in advanced search
* improves events handling in select-kit
* recreates color selection inputs using {{multi-select}} and a custom {{selected-color}} component
* replaces category-selector by a component using select-kit and based on multi-select
* improves positioning of wrapper
* removes the need for offscreen, and instead use `select-kit-header` as a base focus point for all select-kit based components
* introduces a formal plugin api for select-kit based components
* introduces a formal pattern for loading and updating select-kit based components:

```
computeValue()
computeContent()
mutateValue()
```
2017-11-21 11:53:09 +01:00
Guo Xiang Tan edc4b30f82 Remove tests that are no longer being used. 2017-11-21 18:07:23 +08:00
Robin Ward b9595966d4 FIX: Error applying quotes with blank lines in front 2017-11-20 13:46:19 -05:00
Neil Lalonde b37e40eea9 FEATURE: show read time in last 60 days 2017-11-16 15:46:51 -05:00
Arpit Jalan 3831663fea FEATURE: search logs page (#5313) 2017-11-15 11:13:50 +11:00
Joffrey JAFFEUX 680696fc04
Replaces delete flag modal by a dropdown 2017-11-14 07:55:08 -08:00
Sam 38c103c75e correct spec 2017-11-13 18:09:24 +11:00
Robin Ward 1f14350220 Rename "Blocked" to "Silenced" 2017-11-10 14:10:27 -05:00
Joffrey JAFFEUX 6d3ed966cd
FEATURE: replace admin flags modal by a select-box 2017-11-09 12:33:36 -08:00
Michael Howell 38b8d68c68 FEATURE: Allow the user to select a custom home page (#5268)
* Add user_home configuration option

* Use the new user_home preference to actually show the right home page

* Fix trailing whitespace

* Update user_option_serializer.rb

* Fix JavaScript default homepage tests

* Use an object instead of a giant switch

* Remove trailing whitespace

* Make the default `user_home` set to `null` instead of `0`

* Rename user_home to homepage_id
2017-11-10 06:45:19 +11:00
Joffrey JAFFEUX 0da529010a
FEATURE: support for multi-combo-box 2017-11-09 10:57:53 -08:00
Robin Ward 3093074398 UX: Include the flagged person's username on the flagged post 2017-11-09 13:18:33 -05:00
Neil Lalonde 814502f7bb FEATURE: add a Dismiss link to user menu that dismisses all notifications 2017-11-07 10:41:21 -05:00
Guo Xiang Tan abdfac9cb5 FIX: Allow group members to freely exit group option incorrectly disabled.
https://meta.discourse.org/t/cannot-check-allow-members-to-leave-group-freely-when-group-is-configured-to-allow-users-to-send-membership-requests-to-group-owners/73400
2017-11-06 10:30:58 +08:00
ckeboss 93633865d9 Adds primary user group as a class to quote (#5285)
* Adds primary user group as a class to quote

This feature addition will add the class `group-PRIMARY_USER_GROUP` to
the quote `aside`. `PRIMARY_USER_GROUP` will be the primary user group
of the user being quoted. This is similar to the class that is added to
a `topic-post`.

* Remove trailing whitespace

* Fix avatar in test

* Address PR comments

* Fix trailing whitespace
2017-11-03 09:51:40 -04:00
Gerhard Schlager c107e99138 clear localStorage after each test 2017-11-02 23:39:24 +01:00
Robin Ward 05a61fa8e1 FIX: CSS class names changed on group posts 2017-11-02 15:05:41 -04:00
Robin Ward 0a69f2bc77 REFACTOR: Remove many `Discourse.Category.list()` calls 2017-11-01 15:25:35 -04:00
Neil Lalonde 7dc3671490 FEATURE: remove obsolete settings ga_tracking_code and ga_domain_name. Use ga_universal_tracking_code and ga_universal_domain_name instead. 2017-11-01 11:41:51 -04:00
OsamaSayegh 55095bc44e FEATURE: Use ACE for badge queries (#5269)
* FEATURE: Use ACE for badge queries

* Forgot disabled

* When disabled, cursor should be `not-allowed`

* Tests + prefix custom attribute with `data-`
2017-10-30 18:07:49 +11:00
Robin Ward fbd5f1e411 REFACTOR: Rename `store:main` to `service:store` so we can inject it 2017-10-27 13:59:45 -04:00
Joffrey JAFFEUX ae1e4de286 [FIX] better control on value mutation 2017-10-20 13:40:56 -07:00
Régis Hanol 62156885ec UX: remove 🔥heading and ruler button from composer toolbar 2017-10-20 10:59:31 +02:00
Joffrey JAFFEUX 4d041d5b87 [FIX] Fix wizard spec
This commit introduces a mutation on input value given to select-box-kit when value is empty. The refactoring required to avoid this would be too heavy atm, but ultimately we would want to avoid this.
2017-10-19 17:34:56 -07:00
Joffrey JAFFEUX d77ef05ee1 Fix broken tests 2017-10-19 14:32:37 -07:00
Joffrey JAFFEUX ae1743c61f [WIP] select-box-kit refactoring 2017-10-19 12:51:08 -07:00
Robin Ward fb2e581b26 FIX: Headings must begin with `heading--` to avoid some griefing 2017-10-16 11:53:47 -04:00
Robin Ward 5572d1d5f7 Refactor user summary page to use more components 2017-10-13 16:05:40 -04:00
Robin Ward f4decf9193 The `quote-other-topic` class has been removed 2017-10-06 15:16:06 -04:00
Guo Xiang Tan 91c5f928c2 FIX: `Group#mentionable` and `Group#messageable` not fully working. 2017-10-02 16:50:58 +08:00
Guo Xiang Tan a370d7c7fd FIX: Compatibility between Client and Server routing.
mend
2017-09-29 10:34:50 -04:00
Robin Ward df81d109e5 The ability to attach `attrs` when embedding widgets 2017-09-28 16:08:43 -04:00
Guo Xiang Tan 793ccd144e Fix broken JS tests. 2017-09-26 16:15:25 +08:00
Robin Ward b3ffa19f95 FIX: Make sure `Post` records have access to `Site` 2017-09-25 13:18:26 -04:00
Robin Ward 09ed2ed749 Add Suspend User to flags page 2017-09-25 12:28:00 -04:00
Robin Ward 079f108ceb UX: Improve interface for flagging with many flaggers 2017-09-25 12:28:00 -04:00
Robin Ward 6bce3004d9 UX: Nicer selection of suspend duration 2017-09-25 12:28:00 -04:00
Robin Ward 2a56cf8bb6 Tests + Refactoring for Suspension Modal 2017-09-25 12:26:06 -04:00
Robin Ward 6e48884274 Extract out common "cancel" link functionality from modals 2017-09-25 12:25:15 -04:00
Robin Ward 4020409bbf Add support for suspension message 2017-09-25 12:25:14 -04:00
Robin Ward daceeb9700 Refactor user suspension modal 2017-09-25 12:25:14 -04:00
Robin Ward d7c37d9369 Add front end service for staff controls 2017-09-25 12:25:14 -04:00
Robin Ward 5cf50f0034 Adjust flagged posts to use the store 2017-09-25 12:25:14 -04:00
Robin Ward cc1a461254 Convert flags admin to flexbox 2017-09-25 12:25:14 -04:00
Robin Ward 1af4acbb3d Add tests to flagged topics 2017-09-25 12:25:14 -04:00
Robin Ward 40eba8cd93 FEATURE: View flags grouped by topic 2017-09-25 12:25:14 -04:00
Régis Hanol 8ed318c4fe display 'similar to' earlier when composing a post 2017-09-16 01:03:29 +02:00
Joffrey JAFFEUX e6385e4527 attempts to fix broken spec only on CI 2017-09-14 20:34:37 +02:00
Joffrey JAFFEUX 562e48dfb7 adds a dsl to simplify testing of the select-box 2017-09-14 19:50:32 +02:00
Robin Ward 8c2d6118ff Remove some of the last few `fa-icon` helpers 2017-09-14 11:20:36 -04:00
Robin Ward 4f9ba874a9 API so that you don't have to use a global variable for pretender 2017-09-13 11:55:58 -04:00
Joffrey JAFFEUX c06c88b479 cleaner title attribute for select-box 2017-09-12 01:36:58 +02:00
Joffrey JAFFEUX e924920bec uses select-box for pinned-button
This commit also moves more logic in dropdown-select-box instead of
duplicating it for notifications-options and pinned-options
2017-09-11 19:14:22 +02:00
Joffrey JAFFEUX 7f9220a2cd minor select-box fixes
- select row when using tab
- makes sure tab order is correct
- highlight first row when filtering
2017-09-11 00:38:32 +02:00
Joffrey JAFFEUX a0f36a0401 fix broken spec 2017-09-10 21:07:13 +02:00
Joffrey JAFFEUX 4b558638c8 FEATURE: improves keyboard handling of select-box
- arrow keys
- escape key
2017-09-10 19:12:03 +02:00
Joffrey JAFFEUX 950b9e9eaf FIX: keeps as much as possible the same api for select-box components 2017-09-09 20:29:07 +02:00
Joffrey JAFFEUX cf6fb7622e Replaces all notification-options like dropdowns with select-box 2017-09-08 20:47:39 +02:00
Joffrey JAFFEUX dd27c0c80e FIX: supports emojis in pinned topic excerpt 2017-09-07 11:06:04 +02:00
Joffrey JAFFEUX ccf5005feb FEATURE: uses select-box for topic-notifications-button component
- Introduces ComponentConnector to use a component inside a widget
- Use css to set size of components instead of properties
- Smarted positionning
- Style tweaks
2017-09-06 16:58:00 +02:00
Sam Saffron 46ebd0ee40 correct spec and allow for zero allowed iframes 2017-09-01 12:08:55 -04:00
Robin Ward dffb1fc4ee FEATURE: Use Glimmer compiler for widget templates
Widgets can now specify a template which is precompiled using Glimmer's
AST and then converted into our virtual dom code.

Example:

```javascript
createWidget('post-link-arrow', {
  template: hbs`
    {{#if attrs.above}}
      <a class="post-info arrow" title={{i18n "topic.jump_reply_up"}}>
        {{fa-icon "arrow-up"}}
      </a>
    {{else}}
      <a class="post-info arrow" title={{i18n "topic.jump_reply_down"}}>
        {{fa-icon "arrow-down"}}
      </a>
    {{/if}}
  `,

  click() {
    DiscourseURL.routeTo(this.attrs.shareUrl);
  }
});
```
2017-09-01 09:28:16 -04:00
Robin Ward 70706897f4 FIX: Test was failing on high DPI monitor 2017-08-30 15:32:58 -04:00
Robin Ward 3d95bac3fb Migrate away from `#discourse-modal` to `.d-modal` 2017-08-30 15:29:51 -04:00
Robin Ward b100ea1baa FIX: Broken acceptance test 2017-08-30 12:35:02 -04:00
Robin Ward b210c801a4 FIX: Linting error 2017-08-30 11:30:57 -04:00
Joffrey JAFFEUX 746c5927e1 Replaces remaining {{category-chooser}} by {{category-select-box}}
To achieve replacement, this commit also adds support for:
- clearSelectionLabel which will allows to unselect any chosen category
- select-box inside a modal
- fixes minor css positioning issues

Note: {{category-chooser}} will be removed in the next weeks.
2017-08-30 17:04:17 +02:00
Guo Xiang Tan 0a53c589c4 Fix linting. 2017-08-30 15:36:45 +08:00
Joffrey JAFFEUX 1ea5205022 FIX: tests helper do not use es6 2017-08-29 16:16:51 +02:00
Joffrey JAFFEUX 1bcfa87d18 FIX: select-box broken spec
Introduces a test helper for selectBox to simplify these cases.
2017-08-29 15:51:25 +02:00
Joffrey JAFFEUX f101fec19c FIX: improves uncategorized support for category-select-box 2017-08-29 12:48:26 +02:00
Joffrey JAFFEUX 861dbe3b51 select-box refactoring
- more flexibility (allows custom title)
- less re-render
- more robustness
2017-08-29 12:25:54 +02:00
Joffrey JAFFEUX b83c0747d9 FIX: select-box improvments
- more tests for category-select-box
- allows to clear selection
- fix positioning on safari
- focus on click
- do not display uncategorized if not allowed in settings
- fix component state impacting other specs
- better texts
- higher category-select-box on mobile
2017-08-28 14:34:04 +02:00
Joffrey JAFFEUX 14f06c2740 select-box minor fixes 2017-08-25 19:56:57 +02:00
Neil Lalonde 2c56f8df7c FEATURE: show tags in search results 2017-08-25 11:52:59 -04:00
Joffrey JAFFEUX d05df4a337 FIX: better headerText handling on select-box 2017-08-24 18:31:33 +02:00
Joffrey JAFFEUX d52048ad34 Revert "Revert "FEATURE: improves select-box to support category selection on new topic""
This reverts commit 1d90f6016a.
2017-08-24 16:04:47 +02:00
Robin Ward 16b67745d8 FIX: `store:main` error when running QUnit tests checking disabled plugins 2017-08-23 19:34:31 -04:00
Joffrey JAFFEUX 1d90f6016a Revert "FEATURE: improves select-box to support category selection on new topic"
This reverts commit 7b4e302677.
2017-08-23 16:33:03 +02:00
Joffrey JAFFEUX 7b4e302677 FEATURE: improves select-box to support category selection on new topic 2017-08-23 15:08:19 +02:00
Guo Xiang Tan 93fe76fc02 Make eslint happy. 2017-08-21 21:56:22 +09:00
Guo Xiang Tan 9f11223250 Fix `select-box` Qunit tests to use the proper Ember test helpers. 2017-08-16 09:35:56 +09:00
Joffrey JAFFEUX cad6107624 refactors select-box
Note: this commit also now uses select-box for mobile topics controls
2017-08-16 00:41:56 +02:00
Neil Lalonde d506e577a5 FEATURE: if full search returns no results, show google search form 2017-08-15 16:46:41 -04:00
Kyle Zhao c3249f6e93 FEATURE: add full editing access to queued posts (#5047)
For pending new topics: the body of the post, title, categories
and the tags are editable.

For pending new replies: only the body is applicable and thus
editable

DISCUSSION: https://meta.discourse.org/t/66754
2017-08-15 12:44:05 -04:00
Joffrey JAFFEUX 482924b161 FEATURE: initial implementation of an ember native select 2017-08-13 14:34:50 +02:00
Régis Hanol 05a74d2534 FIX: navigation item counters weren't updating properly 2017-08-10 12:22:15 +02:00
Guo Xiang Tan 705f75dd8c Merge pull request #5032 from xrav3nz/ux-hide-options-in-adv-search
UX: exclude irrelevant search filters for anonymous users
2017-08-09 18:21:44 +09:00
Kyle Zhao 9c6c4a7705 restructure search-test to test all filters w/ variable visibiltiy 2017-08-09 04:42:50 -04:00
Guo Xiang Tan a9613163b5 FEATURE: Force user to enter reason when requesting for group membership. 2017-08-09 15:45:28 +09:00
Kyle Zhao cea2a9fe53 UX: exclude irrelevant search filters for anonymous users
On the advanced search page, filters like "I've read", "I'm watch
-ing", etc, are irrelevant to anonymous users and should be hidden
2017-08-08 15:25:40 -04:00
Robin Ward 8dd7c0c984 UX: Convert buttons to `d-button` 2017-08-01 17:24:06 -04:00
Robin Ward 75d10a4098 UX: Add consistent classes to buttons 2017-08-01 17:24:06 -04:00
Neil Lalonde ec85b41078 UX: Move watched words to the Logs section of admin 2017-07-31 17:06:50 -04:00
Sam a13d146251 Correct post deletion spec so it is async 2017-07-28 10:50:18 -04:00
Guo Xiang Tan 4620dfe92d FEATURE: Add group settngs to allow users to leave a group freely.
https://meta.discourse.org/t/split-join-leave-freely-setting-on-groups/65565
2017-07-28 15:00:25 +09:00
Robin Ward 5b590b9637 REFACTOR: Replace some `fa-*` uses with helpers 2017-07-27 14:55:41 -04:00
Guo Xiang Tan 75374c76b3 UX: Display button to message group on group page.
https://meta.discourse.org/t/make-it-easier-to-send-a-message-to-groups/65065
2017-07-27 17:51:25 +09:00
Guo Xiang Tan 9c93a20cf1 Fix incorrect assertion in JS tests. 2017-07-27 17:05:08 +09:00
Neil Lalonde 24cb950432 FEATURE: Watched Words: when posts contain words, do one of flag, require approval, censor, or block 2017-07-26 11:01:09 -04:00
David Taylor febd7621ea Qunit plugin rake tasks (#4985)
* Allow running specific plugin tests using ENV variables

* Add a `rake plugin:qunit` task to match the existing `rake plugin:spec` task

* Improve docker.rake to allow running specific plugin qunit tests

* Purge cache before and after qunit tests

* Stop module auto-loader trying to auto-load tests

* Use URL query parameters to pass config into Qunit, avoiding caching issues

* Oops, searchParams doesn’t work in phantomJS. Parse the URL manually.

* Escape ampersands before passing URL to phantomJS, otherwise multiple parameters go wrong
2017-07-26 09:07:46 -04:00
Sam 17d56a4cb7 FEATURE: use Markdown for image pasted in as opposed to IMG tags 2017-07-25 15:11:38 -04:00
Joffrey JAFFEUX 22c5fb20b4 FIX: emoji-picker broken and skipped specs 2017-07-25 12:23:38 +02:00
Robin Ward bc3a32385c FIX: Empty lines should be selected for block quotes 2017-07-21 16:32:29 -04:00
Arpit Jalan 6d09fbde44 UX: use down chevron icon to expand "show more links.." 2017-07-22 00:10:37 +05:30
Joffrey JAFFEUX c2db2c5c78 FIX: do not store scroll position in local storage 2017-07-21 20:18:32 +02:00
Joffrey JAFFEUX e36d9f55c3 replaces links/imgs by buttons in the emoji-picker 2017-07-21 19:42:50 +02:00
Joffrey JAFFEUX 36b6ed7d8c fix broken specs 2017-07-21 15:57:32 +02:00
Joffrey JAFFEUX 6754205c51 es-lints errors 2017-07-21 14:27:18 +02:00
Joffrey JAFFEUX c906bd3f22 emoji-picker refactoring 2017-07-21 13:35:29 +02:00
Joffrey JAFFEUX bb7241ccc2 simplify emoji-picker recent usage logic 2017-07-19 22:54:56 +02:00
Joffrey JAFFEUX a7090c15ad Skip emoji-picker tests
They are currently failing when using the rake task and not when
loading qunit directly from web ui
2017-07-19 17:07:53 +02:00
Joffrey JAFFEUX be379596e6 skip random failures on travis ci 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX 7718141ee0 not applicable anymore 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX c99a5bce8f faster tests 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX e5d81597b6 removes tests causing timeouts on travais 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX 6de258d4cf FEATURE: Introduces new emoji-picker 2017-07-19 16:48:23 +02:00
Sam d7d22554ca correct js test 2017-07-17 18:06:11 -04:00
Robin Ward cdb3706025 Track clicks on topics in search results 2017-07-17 15:42:32 -04:00
Sam Saffron d0c5205a52 Feature: Change markdown engine to markdown it
This commit removes the old evilstreak markdownjs engine.

- Adds specs to WhiteLister and changes it to stop using globals
    (Fixes large memory leak)
- Fixes edge cases around bbcode handling
- Removes mdtest which is no longer valid (to be replaced with
    CommonMark)
- Updates MiniRacer to correct minor unmanaged memory leak
- Fixes plugin specs
2017-07-17 11:41:34 -04:00
Sam 79a084dd58 Revert "remove old markdown engine work-in-progress"
This reverts commit ee470b5317.
2017-07-12 18:10:51 -04:00
Sam bcbb9f208d Revert "Integrate new engine, correct old specs"
This reverts commit f1b38ba4fb.
2017-07-12 18:10:07 -04:00
Sam 8caaa6a56e Revert "Remove mdtest, the plan is to use commonmark spec instead"
This reverts commit c64aabc964.
2017-07-12 18:10:03 -04:00
Sam c64aabc964 Remove mdtest, the plan is to use commonmark spec instead 2017-07-12 17:44:40 -04:00
Sam f1b38ba4fb Integrate new engine, correct old specs
corrects edge cases with

- full quotes
- [url] with nested tags
- engine overrides
- onebox applying to non http srcs
2017-07-12 17:44:40 -04:00
Sam Saffron ee470b5317 remove old markdown engine work-in-progress 2017-07-12 17:44:40 -04:00
Robin Ward 754c1e5438 Upgrade to Babel 6 2017-07-05 15:25:23 -04:00
Sam Saffron b8b4970481 correct some tests 2017-07-04 10:01:36 -04:00
Sam e2f57a154b FIX: blockquote button implementation
Previously clicking on blockquote in the middle of sentence
would result in incorrect formatting
2017-06-27 13:32:20 -04:00
Sam 8967d50dc2 Clean up sanitization code
- remove html table test, this is soon to be deprecated
- move sanitization tests into pretty text.rb
- fix up whitelister so it makes a copy of options
2017-06-26 15:21:47 -04:00
Sam 234694b50f Feature: CommonMark support
This adds the markdown.it engine to Discourse.
https://github.com/markdown-it/markdown-it

As the migration is going to take a while the new engine is default
disabled. To enable it you must change the hidden site setting:
enable_experimental_markdown_it.

This commit is a squash of many other commits, it also includes some
improvements to autospec (ability to run plugins), and a dev dependency
on the og gem for html normalization.
2017-06-23 12:01:33 -04:00
Robin Ward cc525b1a8d Upgrade QUnit to latest version 2017-06-15 10:12:07 -04:00
Régis Hanol f943efe1a9 remove use of soon-to-be-deprecated 'Discourse.SiteSettings' (cc @eviltrout) 2017-06-14 10:02:13 +02:00
Robin Ward 867cefc492 Ember.K was deprecated, so let's remove it. 2017-06-13 15:59:48 -04:00
Sam 826f332766 Merge pull request #4901 from jjaffeux/emoji-5.0
Emoji next
2017-06-13 11:12:41 -04:00
Régis Hanol 54e8fb0d89 FEATURE: new 'allow_staff_to_upload_any_file_in_pm' site setting 2017-06-12 22:41:29 +02:00
Arpit Jalan b9c94aa234 FEATURE: add required user fields to invite accept form
UX: make "accept invitation" page consistent with sign up modal
2017-06-12 20:43:07 +05:30
Guo Xiang Tan 684b05f510 FIX: Strip zero-width characters from search terms. 2017-06-07 18:19:47 +09:00
Joffrey JAFFEUX 64336a8c75 Emoji 5.0 support 2017-06-05 14:06:23 +02:00
Robin Ward e66fa82f3a FIX: Don't load JS via SCRIPT tag in QUnit mode 2017-05-31 15:31:24 -04:00
Sam febc2c571f add a test for customize theme controller 2017-05-31 11:18:17 -04:00
Neil Lalonde 0c2a54dbb5 fix failing js test 2017-05-30 15:13:56 -04:00
Arpit Jalan d2c2139da8 FEATURE: require name when accepting invite if 'full name required' setting is enabled 2017-05-29 21:46:43 +05:30
Robin Ward 2820cf2b50 FIX: Broken Acceptance test 2017-05-25 15:56:11 -04:00
Neil Lalonde 0a8e16d049 UX: show short flag descriptions in the flag modal on mobile 2017-05-19 15:35:10 -04:00
Neil Lalonde 019f954c44 fix js test failure 2017-05-18 13:36:45 -04:00
Neil Lalonde dbb814ec6a FIX: allow pasting links into title field that are longer than the max title length 2017-05-18 12:32:47 -04:00
Guo Xiang Tan accd78cd8c Make eslint happy. 2017-05-12 09:31:23 +08:00
Guo Xiang Tan e63614024d FIX: Users can't request to join group due to alias level restriction.
https://meta.discourse.org/t/request-to-join-group-not-working/62371
2017-05-12 09:26:26 +08:00
Sam bc0b9af576 FEATURE: support uploads for themes
This allows themes to bundle various assets
2017-05-10 15:47:11 -04:00
Neil Lalonde b7322b05a0 FIX: some changes in composer affect all visible text editors 2017-05-05 12:59:45 -04:00
Guo Xiang Tan 2b21e5ea7e UX: Display translated group name for automatic groups. 2017-05-05 14:34:47 +08:00
Neil Lalonde c98601129b Move name, avatar, and title fields from profile tab to account tab 2017-05-04 12:04:07 -04:00
Guo Xiang Tan 489c3bc1cd Disable failing JS tests first. 2017-05-04 16:49:12 +08:00
Guo Xiang Tan 94c8410521 FIX: Show share popup only for valid buttons. 2017-05-04 10:31:09 +08:00
Neil Lalonde 7f09bc9a09 Merge pull request #4849 from discourse/prefs
User preferences in tabs
2017-05-03 16:53:26 -04:00
Neil Lalonde 47b816c168 comment test failing on theme widget 2017-05-03 15:33:25 -04:00
Neil Lalonde 96aee443fa wip js test 2017-05-03 13:49:16 -04:00
Robin Ward 12fb20fe1b FEATURE: Allow users to resend/update email from confirmation page 2017-05-03 11:18:01 -04:00
Robin Ward b381372184 Use Ember.js for the `/u/account-created` path so we can add controls 2017-05-03 11:18:01 -04:00
Neil Lalonde 2503241ce5 FEATURE: rebuild user preferences page to use tabs 2017-05-02 16:52:18 -04:00
Sam f5f4c36795 Increase autospec qunit timeout to 600 seconds
Correct it so it refocuses on correct runner after running a test
JS tests can not focus on line so skip in vim mode
2017-05-02 16:02:14 -04:00
Sam 556ef4cfbd FIX: case sensitive unconditional add of exact match in user search 2017-05-01 14:37:16 -04:00
Sam a5fc51a967 improve QUNIT support for autospec 2017-05-01 13:50:28 -04:00
Guo Xiang Tan 59b906ab0d FEATURE: Disable minimum post length check when in PM with non human users.
https://meta.discourse.org/t/discourse-narrative-bot-beta-feedback/58621/65?u=tgxworld
2017-04-27 16:00:22 +08:00
James Kiesel 48c0f3faf3 Use image gallery feature of magnific
commit cc7061e9458d04dd02aad9c02ba3a89306e0fae7
Author: James Kiesel <james.kiesel@gmail.com>
Date:   Tue Apr 25 11:21:08 2017 +0900

    ;

commit 9233be7e432daff605812e6b49042f69d348b6e7
Author: James Kiesel <james.kiesel@gmail.com>
Date:   Tue Apr 25 10:01:26 2017 +0900

    Don't break if $elem is undefined

commit 598a694c070c86df8d9f5ffa1ed84e2f8756e65f
Author: James Kiesel <james.kiesel@gmail.com>
Date:   Tue Apr 25 04:51:14 2017 +0900

    .

commit 1711685a33ccd236011f54d3e652991728530b3a
Author: James Kiesel <james.kiesel@gmail.com>
Date:   Tue Apr 25 04:34:11 2017 +0900

    ;

commit 81703f36c0593250aeac3418fde86660fd307092
Author: James Kiesel <james.kiesel@gmail.com>
Date:   Tue Apr 25 04:12:37 2017 +0900

    Use image gallery functionality in magnific
2017-04-25 11:23:15 +09:00
Guo Xiang Tan 5c39c8f24b UX: Improve the way users set timers for `TopicStatusUpdate`. 2017-04-20 14:25:45 +08:00
Guo Xiang Tan f322f3a6cf Fix the build. 2017-04-12 16:32:39 +08:00
Guo Xiang Tan 5cb64810cd FIX: Changing notification level in topic footer buttons was not updating timeline. 2017-04-12 14:54:03 +08:00
Robin Ward 40ab2e5667 FEATURE: Let users update their emails before confirming
This allows users who entered a typo or invalid email address when
signing up an opportunity to fix it and resending the confirmation
email to that address.
2017-04-05 16:44:49 -04:00
Robin Ward 0829671963 FIX: Nested quotes weren't rendered properly with BBCode 2017-04-03 14:38:30 -04:00
Robin Ward 7b6242bfbb Minor cleanup of `/users/` rename 2017-03-30 10:23:24 -04:00
Robin Ward 14410b71fb Convert server side paths to use `/u/` 2017-03-30 10:23:24 -04:00
Robin Ward 45a257815a Convert front end paths from `/users/` to `/u/` 2017-03-30 10:23:24 -04:00
Robin Ward 6b976433c9 Support for both `/users/` and `/u/` paths 2017-03-30 10:23:24 -04:00
Robin Ward a4b658920e FIX: Clear `sessionStorage` between click track tests 2017-03-27 16:16:14 -04:00
Arpit Jalan ec2a66d1f0 FEATURE: make summary as first tab on user page
https://meta.discourse.org/t/custom-user-fields-show-on-activity-but-not-summary-page/59196/3?u=techapj
2017-03-21 23:12:28 +05:30
Neil Lalonde 22f197c153 FEATURE: subcategory list style: boxes with featured topics 2017-03-16 11:54:45 -04:00
Guo Xiang Tan bb85795934 FIX: Leave group membership button not updating.
https://meta.discourse.org/t/leave-group-button-on-groups-page-doesnt-give-any-feedback/57359/4
2017-03-16 11:33:55 +08:00
Guo Xiang Tan 83d2e63771 Make eslint happy. 2017-03-14 11:47:35 +08:00
Guo Xiang Tan 8e45322b09 FIX: Only group admins can see group edit page. 2017-03-14 11:45:58 +08:00
Neil Lalonde 6d7e968e30 FEATURE: box-style rendering of sub-categories 2017-03-13 15:25:52 -04:00
Régis Hanol dd60cb82c3 UX: add client-side rate limit on click counters 2017-03-13 11:31:37 +01:00
Guo Xiang Tan b419a5765e FEATURE: Add seen/unseen filters to advanced search UI.
https://meta.discourse.org/t/advanced-search-posts-that-i-have-seen/57966
2017-03-09 10:46:06 +08:00
Robin Ward c310a32ac1 FIX: Broken tests. :( 2017-03-07 12:36:31 -05:00
Guo Xiang Tan 2a35abf757 Fix the build. 2017-03-02 12:36:15 +08:00
Neil Lalonde 262016604d FEATURE: each category can control how many topics to show on categories page 2017-03-01 15:12:57 -05:00
Régis Hanol b20b568039 FIX: allow for empty translated strings 2017-03-01 11:30:44 +01:00
Régis Hanol 3f5d8b8000 make eslint happy 2017-02-28 10:33:16 +01:00
Régis Hanol 5738253998 FIX: locale fallback with pluralized strings 2017-02-28 10:02:29 +01:00
Guo Xiang Tan ac37bd3dbc FIX: Search menu results does not refresh when search context is changed. 2017-02-27 12:23:41 +08:00
Régis Hanol a2c04be718 FIX: eradicate I18n fallback issues 💣
FIX: client's translation overrides were not working when the current locale was missing a key
FIX: ExtraLocalesController.show was not properly handling multiple translations
FIX: JsLocaleHelper#output_locale was not properly handling multiple translations

FIX: ExtraLocalesController.show's spec which was randomly failing
FIX: JsLocaleHelper#output_locale was muting cached translations hashes

REFACTOR: move 'enableVerboseLocalization' to the 'localization' initializer
REFACTOR: remove unused I18n.js methods (getFallbacks, localize, parseDate, toTime, strftime, toCurrency, toPercentage)
REFACTOR: remove all I18n.pluralizationRules and instead use MessageFormat's pluralization rules

TEST: add tests for localization initializer
TEST: add tests for I18n.js
2017-02-24 11:31:21 +01:00
Neil Lalonde a702330ccd FEATURE: make show_subcategory_list a per-category setting 2017-02-22 11:42:36 -05:00
Neil Lalonde 1dda998a4e FEATURE: search should default scope to current category or user 2017-02-20 17:02:02 -05:00
Neil Lalonde a6ebe495bf FEATURE: links that can't have no onebox can be used as featured topic links 2017-02-17 18:35:19 -05:00
Robin Ward e089515dab FIX: Don't try to load avatars in test mode 2017-02-17 16:21:35 -05:00
Robin Ward c6a0e74945 FIX: Remove errors when running phantomjs 2017-02-17 16:21:35 -05:00
Neil Lalonde d0fbb27f3e FEATURE: new invite acceptance page, where username can be chosen and password can be set 2017-02-15 16:51:57 -05:00
Robin Ward 9d4405d602 Don't add an empty class to the list elements in the hamburger 2017-02-13 11:28:10 -05:00
Rimian Perkins 432b08f296 remove personal email from fixtures
I'm writing acceptance tests against the user fixture in my plugin. It would be a good idea to use a generic email address as I'd like to respect eviltrout's privacy :)
2017-02-13 11:29:03 +11:00
Neil Lalonde e077b3f141 FIX: composer should only feature links to external sites 2017-02-08 15:34:54 -05:00
Neil Lalonde 8643620172 automatically redirect when password reset completes successfully 2017-02-06 15:04:58 -05:00
Neil Lalonde e82240fbd9 autofocus password field on password reset page, and remove static password length message 2017-02-06 12:46:02 -05:00
Neil Lalonde 5613e3b82b fix travis build. use indexOf instead of includes in js tests. 2017-02-06 11:21:29 -05:00
Neil Lalonde c4e10f2a9d FEATURE: redesign the change password page to use javascript and validations 2017-02-03 16:09:24 -05:00
Guo Xiang Tan 0988420b48 Fix broken qunit tests. 2017-02-03 12:09:30 +08:00
Guo Xiang Tan 058df4329d FIX: Escape escape regexp characters. 2017-01-31 10:39:45 +08:00
Leo McArdle c76f6856ea FEATURE: reply as new message to the same recipients 2017-01-27 12:24:31 +08:00
Guo Xiang Tan 156a00af47 UX: Show edit button on post revision modal as long as user can edit. 2017-01-27 10:49:17 +08:00
Guo Xiang Tan ee396edd9c Add edit post button to post revision modal for wiki-ed posts. 2017-01-25 14:36:00 +08:00
Guo Xiang Tan 32846aad2a FIX: Toggling post's wiki status should not create a new version. 2017-01-20 15:42:33 +08:00
Neil Lalonde 222125de10 oops here's the test 2017-01-18 12:13:55 -05:00
Guo Xiang Tan c76ee788a7 Merge pull request #4656 from tgxworld/dont_display_an_extra_button_for_wiki_post
UX: Display wiki icon on post edits indicator.
2017-01-17 06:34:43 +08:00
Guo Xiang Tan 17da0bd11f UX: Display wiki icon on post edits indicator. 2017-01-17 06:33:58 +08:00
Neil Lalonde 60a9030d25 UX: don't show search and hamburger menus to anon visitors on login-required sites 2017-01-16 16:33:14 -05:00
Guo Xiang Tan d793a0fbfc Fix JS tests. 2017-01-06 16:00:29 +08:00
Guo Xiang Tan 389e1d0bd5 Add acceptance JS tests for group membership button. 2017-01-06 11:56:10 +08:00
Robin Ward 7c8095294d FIX: Raw plugin outlets were broken 2017-01-05 11:38:57 -05:00
Guo Xiang Tan 3aed15c99e FIX: Group membership button now showing properly. 2017-01-03 14:36:56 +08:00
Guo Xiang Tan f1beef43a8 Merge pull request #4618 from tgxworld/fix_invalid_emails
FIX: Don't allow invalid email to be saved.
2016-12-30 07:11:48 +08:00
Régis Hanol f71040dc23 Merge pull request #4630 from caugner/feature-preserve-cursor-in-editor-upload
FEATURE: Preserve cursor in editor upload
2016-12-29 14:46:10 +01:00
Claas Augner 37386faff2
Fix eslint nits. 2016-12-29 10:05:07 +01:00
Claas Augner 43c1dd82f6
Add cursor tests, fix algorithm and extract method. 2016-12-29 09:54:15 +01:00
Guo Xiang Tan 6d00650972 Fix JS tests. 2016-12-29 13:47:11 +08:00
Guo Xiang Tan a481bf048f FIX: Incorrect membership action buttons shown for non logged in users. 2016-12-29 12:51:36 +08:00
Guo Xiang Tan 3c4920d234 FIX: Group admin tabs showing for non logged in users. 2016-12-29 11:52:07 +08:00
Guo Xiang Tan a5fead3857 UX: Redesign group page to follow user page. 2016-12-22 13:08:59 +08:00
Neil Lalonde 783490f763 FIX: with featured links enabled and uncategorized topic not allowed, allow featued links behaviour before choosing a category 2016-12-21 13:40:05 -05:00
Guo Xiang Tan 13c6191e89 FIX: Don't allow invalid email to be saved. 2016-12-21 17:47:11 +08:00
Robin Ward e03d5e2140 Reapply Ember 2.10 for good this time!
This reverts commit ddd299f4aa.
2016-12-19 11:19:10 -05:00
Guo Xiang Tan 51679ef6b2 Fix JS tests. 2016-12-17 00:51:40 +08:00
Robin Ward ddd299f4aa Revert "Revert "Revert Ember 2.10+ for a short while""
This reverts commit 76bbc481cb.
2016-12-16 10:29:30 -05:00
Robin Ward 76bbc481cb Revert "Revert Ember 2.10+ for a short while"
This reverts commit 21682fd60b.
2016-12-16 09:52:29 -05:00
Robin Ward 21682fd60b Revert Ember 2.10+ for a short while 2016-12-15 16:43:38 -05:00
Robin Ward 28699e66d8 Revert "REVERT: Ember 2.10 -- it's not building properly"
This reverts commit 600541c623.
2016-12-15 10:28:15 -05:00
Guo Xiang Tan 0ab52b127b Fix JS tests. 2016-12-15 16:52:47 +08:00
Guo Xiang Tan 50aa9ba396 Fix JS tests. 2016-12-15 14:17:15 +08:00
Guo Xiang Tan 4b940dc8bd FEATURE: Add groups page. 2016-12-14 17:27:47 +08:00
Neil Lalonde 1f0793ac50 Improvements to automatic topic title based on pasted link 2016-12-13 13:11:52 -05:00
Guo Xiang Tan eefd286f71 Fix JS tests. 2016-12-13 16:45:49 +08:00
Guo Xiang Tan 43ee9f884e FEATURE: Add `Group#full_name`. 2016-12-13 16:16:26 +08:00
Guo Xiang Tan 7bfabb029b UX: Move editing group from into an individual tab. 2016-12-13 15:15:20 +08:00
Robin Ward 600541c623 REVERT: Ember 2.10 -- it's not building properly 2016-12-12 16:19:05 -05:00
Arpit Jalan ec5615033d Add acceptance test for escaping search term 2016-12-13 01:55:39 +05:30
Robin Ward 9a7998a930 Various fixes for Ember 2.10 2016-12-12 14:44:29 -05:00
Robin Ward 2efe4900cf Plugin Outlets need their arguments to be explicit 2016-12-12 14:44:29 -05:00
Robin Ward 765e5e9186 Upgrade to Ember 2.9 2016-12-12 14:44:29 -05:00
Guo Xiang Tan 3089752b13 Make eslint happy. 2016-12-12 22:52:57 +08:00
Guo Xiang Tan da7009a968 FEATURE: Add request membership button for allowed groups. 2016-12-12 22:48:08 +08:00
Guo Xiang Tan beb8245d04 Correct tests. 2016-12-12 17:32:16 +08:00
Guo Xiang Tan 05f55dbc10 FEATURE: Group logs. 2016-12-12 17:29:54 +08:00
Guo Xiang Tan be5b5f6bea FEATURE: Public groups. 2016-12-12 17:00:30 +08:00
Neil Lalonde fb2633366a FIX: featured link topics shouldn't require the same min post length 2016-12-09 15:46:26 -05:00
Neil Lalonde a4c4f13901 Remove the topic_featured_link_onebox setting. We will always try to onebox a link and add it to the body if topic_featured_link_enabled is enabled. 2016-12-09 13:28:12 -05:00
Neil Lalonde fbd8e6ed4a FEATURE: pasting a link into the title of the composer can automatically onebox it and update the title 2016-12-08 16:09:46 -05:00
Robin Ward a9acced4ca FIX: Broken tests after removing attribute 2016-12-08 11:45:27 -05:00
Guo Xiang Tan 545dfa7191 FEATURE: Allow group owners to edit title. 2016-12-07 10:26:28 +08:00
Guo Xiang Tan 8c7a0b7684 UX: Display group title if it exists. 2016-12-07 10:20:13 +08:00
Erick Guan 52763f5115
FEATURE: Allow posting a link with topics 2016-12-05 17:20:54 +01:00
Guo Xiang Tan adb7fcb6b3 FEATURE: Add bio to group page. 2016-12-05 16:58:04 +08:00
Guo Xiang Tan e0c28d6fd5 REFACTOR: Stop mixing users page and groups page CSS. 2016-12-05 14:27:47 +08:00
Guo Xiang Tan 31acd311e5 FEATURE: Allow group owners to edit group name and avatar flair. 2016-12-05 14:27:46 +08:00
Guo Xiang Tan 0d4f71e90b FIX: Display group avatar flair on user page. 2016-11-29 13:47:45 +08:00
Sam 0631a84ca0 Merge pull request #4576 from cpradio/min-posts-search
FEATURE: Add min_post_count search filter
2016-11-29 10:19:33 +11:00
cpradio 66ca6d622e FEATURE: Add min_post_count search filter 2016-11-28 11:43:12 -05:00
Robin Ward 6aa5722d2b Remove Ember 1.x specific code 2016-11-25 15:38:45 -05:00
Guo Xiang Tan 5794f1619d PERF: Fix N+1 queries when loading groups. 2016-11-26 02:20:26 +08:00
Robin Ward ae4fd06444 Add acceptance tests for `custom-html` 2016-11-23 13:02:22 -05:00
Robin Ward 91c21dad28 Reset plugins before tests too 2016-11-23 10:41:21 -05:00
Robin Ward 9afa55a3fd FIX: Random failing plugin tests 2016-11-22 15:36:18 -05:00
Robin Ward b07a2baedc FIX: Clear the outlet cache before and after tests 2016-11-22 14:50:03 -05:00
Robin Ward 217007ff54 Add acceptance tests for plugin outlets 2016-11-22 14:03:01 -05:00
Erick Guan fb3c5bcd0f
FIX: activy column title shows the non-i18n datetime 2016-11-16 22:15:34 +01:00
Robin Ward 2567fdc402 FIX: Wrong path to loader 2016-11-15 12:41:20 -05:00
Sam 7d531910a4 fix tests 2016-11-15 13:30:03 +11:00
Robin Ward a9ed15e11a FIX: Remove more of those pesky View classes 2016-11-11 17:03:15 -05:00
Robin Ward cc93cd76ef Replace quote button with a component 2016-11-11 16:00:28 -05:00
Robin Ward 93403b0af6 Replace the share popup with a component 2016-11-11 14:13:19 -05:00
Robin Ward 01a8ef590a Remove more view classes 2016-11-10 16:27:15 -05:00
Robin Ward d98aa48f0d Remove some preferences views, add extra tests 2016-11-10 15:54:21 -05:00
Robin Ward a94f06ff78 Remove the `ScrollTop` Mixin 2016-11-10 15:25:04 -05:00
Robin Ward 0904ad5537 Migrate `createViewWithBodyClass` helper to components 2016-11-10 14:28:04 -05:00
Neil Lalonde 86522a52b7 FEATURE: add censored_pattern setting to censor posts using regex 2016-11-08 16:39:26 -05:00
Robin Ward 7d560ea3d5 More ember-qunit fixes 2016-11-08 14:42:10 -05:00
Robin Ward 6a1c05a268 Upgrade ember-qunit 2016-11-08 14:29:50 -05:00
Robin Ward 151597bf0f Update code so Ember 2.3 can have more tests passing 2016-11-08 13:40:35 -05:00
Robin Ward 24ad68e765 Use `this.registry` in `component-test` 2016-11-07 15:12:16 -05:00
Robin Ward e18ae34493 Don't try injecting into the Resolver. Use options instead. 2016-11-04 10:23:24 -04:00
Robin Ward a9d7569dda Replace computed properties for topic query params 2016-11-03 13:09:43 -04:00
cpradio f59c11b4ab FIX: Advanced Search to utilize Category Selector so it can distinguish uncategorized from no category selected 2016-10-31 17:27:57 -04:00
David McClure 9bbab6e64e FIX: Auto-link URLs that are inside parentheses 2016-10-29 18:57:25 -07:00
Robin Ward a319cfe77a Final set of backwards compatible fixes for Ember 1.13 2016-10-28 15:51:39 -04:00
Robin Ward 622dc82481 Replace deprecated `render(buffer)` with a custom buffered renderer 2016-10-25 14:00:21 -04:00
Guo Xiang Tan adfd9733c6 FIX: Advanced search should retain search term. 2016-10-25 11:47:11 +08:00
Guo Xiang Tan 299800f524 Make eslint happy. 2016-10-24 12:21:02 +08:00
Guo Xiang Tan 3eae668e64 Set up pretender inside test file. 2016-10-24 12:17:17 +08:00
Sam f083994f5a FIX: exact group match always should be added 2016-10-24 12:43:38 +11:00
Neil Lalonde 761cc688b4 FEATURE: add a setting to allow url schemes other than http(s) 2016-10-21 12:21:31 -04:00
Robin Ward bf91532260 Fixes some Ember Deprecations for 1.13:
- Remove ArrayController
- Remove {{view}} from templates
- Replace many cases of needs: [‘controller’] with inject
- Enable Ember Legacy Views
2016-10-21 11:06:07 -04:00
Régis Hanol 35a79a70c3 FIX: uploading custom avatar was always hidden 2016-10-20 19:53:41 +02:00
Régis Hanol 9f7b529495 FIX: properly detect when attachments are allowed 2016-10-19 18:42:24 +02:00
cpradio ddacda0388 Update based on review comments
Found a few javascript errors when visiting the search page with ?expanded=true and no query.
2016-10-17 00:02:58 -04:00
cpradio 1e7c69044c FIX: Improve removing advanced filters
Prior:
Entering `test after:5` and then removing the 5 via the search text field would result in the UI not updating

After:
UI updates after half a second

Removing it from the UI, removes it from the search field immediately.

Change the regex to detect filter words. This now matches what happens in search.rb, which gives a lot more flexibility (such as iterating over multiple `in:` terms)

Return [] when searchTerm is empty

Move .trim() to this.set('searchTerm', searchTerm) so it doesn't run twice (which was very obvious when watching the search term field)

More refactoring to make this a bit less complex

Update code based on review comments

FEATURE: Add common `in:` options
2016-10-14 19:04:10 -04:00
Guo Xiang Tan ae0db10e2d Fix full page search tests. 2016-10-13 15:03:58 +08:00
cpradio ff74bd7e28 FIX: comment out tests for UI elements removed from HTML markup 2016-10-11 17:50:16 -04:00
cpradio ca4130f30d FIX: Use @username instead of user:username 2016-10-11 17:41:04 -04:00
cpradio a7507dad63 Add Acceptance Tests (which found an error)
Tests for populating category and tags

Added acceptance tests for populating the Username and Category through the Advanced Search UI (will work on the other fields later)

Give the combo-box elements ids
Add acceptance tests for the rest of the advanced search UI (except for Tags, tags are evil)
2016-10-08 09:09:37 -04:00
Robin Ward be1d74d207 Split out common functions into `discourse-common` module 2016-09-22 09:52:19 -04:00
Neil Lalonde 48e4f88b08 fix js test 2016-09-16 15:33:51 -04:00
Erick Guan 9ce61b4586 FEATURE: Webhooks. 2016-09-05 18:44:00 +08:00
Régis Hanol e064e6f7a3 FEATURE: new 'categories_and_latest' endpoint 2016-08-29 22:47:44 +02:00
Régis Hanol 87f6aadb7e FIX: topic discovery tests 2016-08-24 22:53:43 +02:00
Guo Xiang Tan 90571f0364 FIX: Format selection as multiline code only when selection spans multiple lines. 2016-08-23 15:00:16 +08:00
Guo Xiang Tan f32d8e2882 FIX: Code fences shortcut did not insert newlines before and after backticks. 2016-08-23 09:51:01 +08:00
Régis Hanol 4d6028ea2d UX: new 'category_page_style' site setting 2016-08-22 23:01:43 +02:00
Robin Ward 78e8aa823d UX: Just show "1m" if less than 1m 2016-08-18 12:47:00 -04:00
Régis Hanol 6d1d7b7c8f UX: new /categories layout 2016-08-17 23:23:16 +02:00
Neil Lalonde d079f69b7b FEATURE: add flair to avatars using new settings in the groups admin UI 2016-08-17 15:13:15 -04:00
Robin Ward 4d8584f427 FIX: Support `div dir=` in sanitizer 2016-08-15 11:19:10 -04:00
Robin Ward b2134aa173 Refactor full page search for style, remove lookups 2016-08-09 14:49:46 -04:00
Robin Ward d8808aa9ab Add back acceptance tests for full page search 2016-08-09 14:49:46 -04:00
Robin Ward 3d62e5dd98 SECURITY: XSS issue on Admin users list 2016-08-05 12:01:16 -04:00
Robin Ward 857d54162b Redirect to Summary when viewing yourself 2016-08-02 13:21:24 -04:00
Robin Ward 9cb8d5d19e FIX: Whitelist the `big` tag 2016-07-29 16:11:18 -04:00
Robin Ward efc6408b1d FIX: Regression with escaping on badge page 2016-07-28 15:57:06 -04:00
Robin Ward cf5b756b1a SECURITY: Cross-Site Scripting in Category and Group Settings 2016-07-28 11:57:59 -04:00
Robin Ward 2f8ab8cd30 SECURITY: XSS in "Account Suspended" Messages and Badge Descriptions 2016-07-28 11:38:12 -04:00
Guo Xiang Tan 36ddb1787e FEATURE: Add toggle topic visibility button in popup menu. 2016-07-28 16:57:04 +08:00
Robin Ward fbfd3124a0 Whitelist some more tags and add extra tests 2016-07-26 11:02:09 -04:00
Jeff Atwood 1379bd5053 fix all v=2 spec / test errors for emoji 2016-07-25 15:53:48 -07:00
Robin Ward 3200d836f7 FIX: After uploading an image the selection was not in the correct spot 2016-07-25 15:31:21 -04:00
Robin Ward b9177af1eb FIX: Protocol-less links that begin with `a` shouldn't error 2016-07-20 13:44:12 -04:00
Robin Ward 7dd4470075 FIX: Allow `div align` 2016-07-20 12:39:12 -04:00
Robin Ward e7e6840803 FIX: I shouldn't commit while tired :) 2016-07-20 10:42:35 -04:00
Robin Ward 8b314304f2 FIX: We don't sanitize h ids anymore 2016-07-19 17:39:34 -04:00
Robin Ward ad7e2f15c7 Support linking to anchored headings in the first post 2016-07-19 17:05:45 -04:00
Robin Ward 81500e6f40 FIX: Move details tests into the plugin directory 2016-07-19 16:20:59 -04:00
Robin Ward 8141e1d9bc FIX: details fixes with extra formatting 2016-07-19 15:14:55 -04:00
Robin Ward 4d65370797 FIX: `<strike>` was no longer whitelisted 2016-07-11 12:57:05 -04:00
Robin Ward 6d7e8bd68b FIX: Customizations were broken 2016-07-11 12:57:05 -04:00
Robin Ward a291944835 FIX: Add `kbd` support to the sanitizer 2016-07-11 12:57:05 -04:00
Robin Ward bba0fd0654 REFACTOR: PreloadStore to ES6 2016-07-11 12:57:05 -04:00
Robin Ward 25d6915cac Migrate discourse.js to ES6 2016-07-11 12:57:05 -04:00
Robin Ward 7ff5b228cd REFACTOR: Raw Handlebars ported to ES6 2016-07-11 12:57:05 -04:00
Robin Ward b8125b3512 REFACTOR: Remove `Discourse.Ajax` 2016-07-11 12:57:05 -04:00
Robin Ward a546395397 REFACTOR: Migrate markdown functionality in ES6 2016-07-11 12:57:05 -04:00
Robin Ward 21684c98be FIX: Don't remove the `id` from the input to `createRecord` 2016-07-06 13:52:30 -04:00
Neil Lalonde 1fd27bdbb3 FIX: js test error "Unhandled request /tag_groups" 2016-07-05 14:59:00 -04:00
Guo Xiang Tan 7e076d63ba
Fix failing tests. 2016-07-05 12:17:29 +08:00
Sam c665607f72 FIX: not doing non leading word match in emoji autocomplete 2016-07-04 19:16:08 +10:00
Mark Wingerd e4074f75b1 Stop URLs from being censored (#4288)
URLs that contained a censored word were being altered by
censored-words.js and ulimately this broke the links. As an example
www.expertsexchange.com would get censored when it would link to a
legitimate website.  This URL blocking functionality should be
handled through other settings.
2016-06-29 10:41:54 -04:00
Arpit Jalan 83309752ae FEATURE: new site setting 'code formatting style' 2016-06-27 01:00:11 +05:30
Guo Xiang Tan 1a6624960d
FIX: Failing test. 2016-06-20 12:50:22 +08:00
Guo Xiang Tan a891125b92
Add tests from discourse-tagging. 2016-06-20 11:25:05 +08:00
Régis Hanol a1c875986a fix spec 2016-06-08 11:48:26 +02:00
Sam 6d10812b26 FEATURE: auto expand incoming/outgoing links 2016-06-08 16:49:01 +10:00
Sam b2f26eaa60 correct test case and add condition 2016-06-08 14:57:13 +10:00
Robin Ward 67303d7679 REFACTOR: Composer messages to use new ember idioms 2016-06-07 14:47:22 -04:00
Arpit Jalan c9689d4dad fix the build 2016-06-02 18:51:43 +05:30
Robin Ward 90330d30f4
FIX: Error in smart short date function 2016-05-31 10:51:47 -04:00
Robin Ward 559fa36c18
FEATURE: Topic timeline widget 2016-05-31 10:51:39 -04:00
Robin Ward 751e354ca6
Refactor `topic-progress` into a component 2016-05-31 10:51:39 -04:00
Robin Ward 4a7567b485
UX: Move links from gutter to below posts 2016-05-31 10:51:37 -04:00
Régis Hanol c4f93846f9 add linebreaks when uploading a file 2016-05-20 11:35:47 +02:00
Jeff Atwood 80082f0e2b UX: hide flag behind ellipsis by default 2016-05-18 16:50:43 -07:00
Robin Ward 47720ba1ca
UX: Clicking a participant in the topic map should just show the card 2016-05-11 15:09:36 -04:00
Robin Ward 0fcfc6bed9
Add acceptance tests for all mobile templates 2016-05-05 12:49:12 -04:00
Régis Hanol ad15049ef0 FIX: don't track clicks on links in quotes 2016-05-03 18:47:01 +02:00
Arpit Jalan 706ea28ef9 FIX: prepend 'continue discussion' link to topic template 2016-05-03 15:01:02 +05:30
cpradio b7b5caa50e FEATURE: Apply external window setting to Revision History (#4207) 2016-05-02 14:48:34 -04:00
cpradio 5c583ff5bb FEATURE: Extend clicking tracking to the user profile page. (#4203)
* Extend clicking tracking to the user profile page.
Added qunit tests
Fixed click-track-test so it uses the correct data attribute for topic_id in its fixture

* Added a second excerpt to verify test pulls from the appropriate one.
2016-05-02 11:43:58 -04:00
Robin Ward 1a3b63e07d
`createWithMixins` is deprecated. 2016-04-29 16:50:52 -04:00
Robin Ward 400c061046
`Ember.keys` is deprected in favor of `Object.keys` 2016-04-28 16:37:20 -04:00
Robin Ward 187d7d6f96
Remove more views and deprecations. 2016-04-28 16:17:18 -04:00
Robin Ward 2f911d9435
FIX: Broken test, `data-auto-route` is no longer needed 2016-04-27 14:03:45 -04:00
Robin Ward 514c3976f0
PERF: Migrate header to discourse widgets 2016-04-25 10:48:04 -04:00
Régis Hanol 4960b62110 FEATURE: new 'block_auto_generated_emails' site setting 2016-04-20 21:29:27 +02:00
Guo Xiang Tan 256d7a00e9 Update sprockets. (#4167)
* Update sass-rails.

* FIX: Tilt dependency has been removed from Ember::Handlebars::Template.

* Update `DiscourseIIFE` to new Sprockets API.

* `Rails.application.assets` returns `nil` in production.

* Move sprockets-rails out of the assets group.

* Pin ember-rails to 0.18.5 which works with Sprockets 3.x.

* Update sprockets to 3.6.0.

* Make `DiscourseSassCompiler` work with Sprockets 3.

* Use `Sass::Rails::SassImporterGlobbing` instead of haxxing our own.

* Moneky patch so that we don't add dependencies for our custom css.

* FIX: Missing class.

* Upgrade ember-handlebars-template.

* FIX: require path needs to share the same root as the folder's path.

* Bump discourse-qunit-rails.

* Update ember-template-compiler.js to 1.12.2.

* `prepend` is private in Ruby 2.0.0.
2016-04-18 10:47:52 +08:00
Sam 9e50f36c50 Merge pull request #4137 from cpradio/add-warning-to-flag
FEATURE: Add warning input to flag dialog when notifying a user
2016-04-15 16:23:22 +10:00
Régis Hanol 6ee11adf58 FIX: 'Discourse.isInternal' wasn't working with protocol-less URLs 2016-04-11 22:21:39 +02:00
Robin Ward f6c460c207 Add tests for groups pages, DRY html into a component 2016-04-11 13:17:34 -04:00
Peter Lejeck 9bba68ed74 Allow disabling link tracking with .no-track-link (#4160) 2016-04-11 11:39:49 -04:00
Robin Ward c948d53d91
UX: Use separate input fields for link and description in d-editor 2016-04-08 16:13:42 -04:00
cpradio 67cd08af9b Add qunit tests 2016-04-03 20:26:42 -04:00
Sam fe51f84aa7 FEATURE: allow admins to enter badge long descriptions
FIX: fallback to description if badge long description is missing

Also moves all badge localization into server.en, this slims the client down

serializers pass down localized names/descriptions/long descriptions
2016-03-28 18:38:57 +11:00
Jeff Atwood 0f11bc0beb fix tests 2016-03-27 09:58:16 -07:00
Jeff Atwood b3a028acc0 remove built-in support for bbcode size 2016-03-27 09:29:27 -07:00
Robin Ward 27c793a990 UX: Show badges as cards on the badges index and show page 2016-03-25 15:33:06 -04:00
Robin Ward e51259ee7b FIX: Broken test 2016-03-24 13:50:45 -04:00
Robin Ward db15772ab1 UX: Make user info rendering more consistent 2016-03-24 13:49:35 -04:00
Robin Ward d1b9a9370a PERF: Render logo significantly faster 2016-03-21 15:14:31 -04:00
Robin Ward a9daa33953 Add tests to `home-logo` component 2016-03-21 14:16:33 -04:00
Robin Ward fbf45426e4 Autoload widgets since they are named when created, not by file 2016-03-18 16:31:59 -04:00
Jared Reisinger 973f8a5254 FIX: plugin links.
Change from `https://meta.discourse.org/category/extensibility/plugin` to `https://meta.discourse.org/c/plugin` so that they actually work!  Note that `/category/...` would continue to work (it just redirects to `/c/...`), but since the site itself appears to normalize to `/c/`, it makes sense for the links to follow the same pattern.
2016-03-16 11:42:39 -07:00
Sam Saffron 7be90a885c FIX: bolding text when selection has a leading space 2016-03-10 22:43:48 +11:00
Sam Saffron f3efe657fa FEATURE: Automatically add http:// when adding links without them via composer 2016-03-10 18:25:02 +11:00
Robin Ward 396713718b FEATURE: Adds ~200 more emoji
This includes all new emoji from Unicode 7 and Unicode 8 with the
exception of skin tones which will require a new interface.
2016-03-04 15:10:14 -05:00
Régis Hanol 71911a4c67 fix build 2016-03-04 10:52:23 +01:00
Robin Ward 79cc602bcc FIX: Broken test :fired: 2016-03-03 11:40:35 -05:00
Neil Lalonde c1aea91d63 FEATURE: More digest email frequency options. Digests can be sent as often as every 30 minutes. 2016-03-02 15:43:47 -05:00
Robin Ward 627ef54efe New PluginAPI for widget settings 2016-02-26 14:26:29 -05:00
Robin Ward 98ab64dc89 FIX: Some re-render functionality in widgets, added more coverage 2016-02-26 14:01:20 -05:00
Robin Ward 6b46092aa2 FIX: Disable cloaking in the test environment 2016-02-24 17:44:01 -05:00
Robin Ward 026bba1876 Merge branch 'master' into vdom 2016-02-22 15:28:07 -05:00
Jeff Atwood f6b1238d6c reduce maximum_backups default from 7 to 5 2016-02-22 00:56:26 -08:00
Robin Ward f6aa1ac37a Migrate `onToolbarCreate` to the DiscourseAPI 2016-02-18 15:23:43 -05:00
Robin Ward f77ec0b610 FIX: broken tests 2016-02-18 12:19:00 -05:00
Robin Ward 849c99f83d Remove `Discourse.Mobile` constants 2016-02-18 12:19:00 -05:00
Sam 1e131a120c Merge branch 'master' into vdom 2016-02-17 18:39:11 +11:00
Sam 8981ca41f0 correct acceptance test 2016-02-17 18:38:57 +11:00
Robin Ward 482a65821b FIX: Latest eslint doesn't recognize TypedArray 2016-02-15 11:12:57 +01:00
Robin Ward 878ced8920 FIX: Latest eslint doesn't recognize TypedArray 2016-02-12 13:31:26 -05:00
Robin Ward 960f9ed132 FIX: Broken test 2016-02-11 16:51:50 -05:00
Robin Ward d1e85bdd8b FEATURE: Use virtual dom framework for faster post rendering 2016-02-11 11:00:40 -05:00
Guo Xiang Tan c0feea4629 Add tests for category hashtag. 2016-02-04 15:52:40 +08:00
Guo Xiang Tan 4cd07fbb29 Fix broken tests. 2016-02-04 15:24:49 +08:00
Guo Xiang Tan 2c19e7f73d Fix the build. 2016-01-29 17:52:30 +08:00
Guo Xiang Tan 07b244741c FIX: the build. 2016-01-21 16:21:54 +08:00
Guo Xiang Tan bd86e88b05 UX: Remove category hashtag decoration. 2016-01-21 12:27:52 +08:00
Guo Xiang Tan fa794ef59d FIX: Deleting characters on category hashtag was not triggering autocomplete. 2016-01-20 17:18:04 +08:00
Guo Xiang Tan 9652c3df4f FIX: Don't track category-badges links. 2016-01-20 12:48:00 +08:00
Guo Xiang Tan 4a7f560a35 FEATURE: Decorate category hashtag links. 2016-01-19 10:58:15 +08:00
Robin Ward 57c3d65777 Change `d-editor` to use `_` instead of `*` for italics. 2016-01-18 14:54:54 -05:00
Guo Xiang Tan f519834824 FIX: Don't include child categories when term is black. 2016-01-08 11:26:06 +08:00
Guo Xiang Tan c947c75de3 FIX: Make eslint happy. 2016-01-05 15:22:29 +08:00
Guo Xiang Tan 0fa9a50378 FIX: Ignore case when comparing category name and search term. 2016-01-05 15:15:04 +08:00
Guo Xiang Tan d6b5b9436c UX: Prioritize categories autocomplete with new rules. 2016-01-05 14:59:18 +08:00
Guo Xiang Tan a549229a0d Remove unused code. 2016-01-05 09:37:46 +08:00
Guo Xiang Tan c1dbf5c1c4 FEATURE: Autolinking to category using hashtags. 2016-01-05 00:12:24 +08:00
Régis Hanol bebeeffc30 FIX: ico are images too 2015-12-31 11:40:23 +01:00
Robin Ward fd6bbc69e2 FIX: On chrome, focusing on a recently changed textarea would scroll 2015-12-29 14:59:12 -05:00
Jeff Atwood e03861da7e change all emoji image tests to use ?v=1 2015-12-22 14:36:21 -08:00
Robin Ward 67c08e8aae FIX: Broken tests for slightly_smiling 2015-12-22 16:07:28 -05:00
Sam 33df5372f6 comment out some tests for now 2015-12-20 17:49:35 +11:00
Sam d20f6e0cb0 fix test and comment out js test for now 2015-12-20 17:34:15 +11:00
Sam Saffron f97a754b30 Revert "Try adding an ALT tag for avatars" 2015-12-15 19:57:54 +11:00
Sam Saffron dd6e38133a correct tests and implemenation 2015-12-15 19:46:00 +11:00
Sam Saffron b7f6df7d0c fix specs and tests 2015-12-15 18:18:20 +11:00
Robin Ward 4e80323567 FIX: Remove useless stub tests 2015-12-07 14:27:43 -05:00
Robin Ward 255a5be015 Revert "Cleaner implementation of `postsWithPlaceholders` and more tests."
This reverts commit 4c0670a109.
2015-12-04 15:59:46 -05:00
Robin Ward a51c91ac05 Revert "FIX: Errors with summary views and placeholders"
This reverts commit 5be3bf80eb.
2015-12-04 15:59:39 -05:00
Robin Ward 5be3bf80eb FIX: Errors with summary views and placeholders 2015-12-04 15:10:13 -05:00
Robin Ward 4c0670a109 Cleaner implementation of `postsWithPlaceholders` and more tests. 2015-12-04 15:10:13 -05:00
Robin Ward 40c8d39137 FEATURE: Reply Placeholders in Stream 2015-12-04 10:02:58 -05:00
Robin Ward 949f51ffe0 Remove ajax stubbing from post-stream tests 2015-12-04 10:02:37 -05:00
Robin Ward 2006be41cf Split up pretender a bit. It was getting unwieldly. 2015-12-01 15:31:15 -05:00
Robin Ward de88be2fbc Support for "Only show overridden" in site text customization 2015-11-30 15:25:08 -05:00
Sam ad3dd161e7 FEATURE: first class group mentions built in
If you allow a group to be mentioned it can be mentioned with the @ symbol.

Keep in mind as a safety mechanism max_users_notified_per_group_mention is set to 100
2015-11-30 17:08:43 +11:00
Robin Ward 5e93140f85 FEATURE: Can override any translation via an admin interface 2015-11-27 11:35:19 -05:00
Sam 0844350308 correct production mode due to ember loading changes 2015-11-25 13:57:10 +11:00
Robin Ward 49bda0b17d FIX: Improve windows double clicking on words in editor 2015-11-24 13:42:22 -05:00
Robin Ward c76caca109 FIX: Perform the same operation on multilines in d-editor 2015-11-24 13:03:37 -05:00
Sam 5c899c765b Revert "Revert "REFACTOR: support booting discourse with DISCOURSE_NO_CONSTANTS""
This reverts commit c21457d6a7.
2015-11-21 12:27:06 +11:00
Arpit Jalan e25ee74209 FIX: handle topic/post creation when the language highlighting is turned off 2015-11-21 02:10:54 +05:30
Robin Ward c21457d6a7 Revert "REFACTOR: support booting discourse with DISCOURSE_NO_CONSTANTS"
This reverts commit c0b277d273.
2015-11-20 10:00:12 -05:00
Sam c0b277d273 REFACTOR: support booting discourse with DISCOURSE_NO_CONSTANTS
This change is discussed here: https://meta.discourse.org/t/deprecating-es6-compatibility-layer/35821

Prior to this change we were not booting correctly with DISCOURSE_NO_CONSTANTS
2015-11-21 00:14:50 +11:00