8e6a903f9b
Merge pull request #1046 from house9/admin-user-index-2
...
extract Admin::UsersController#index to its own query class
2013-06-20 07:52:22 -07:00
2e7c5a674c
Merge pull request #1049 from ZogStriP/admin-alerts
...
Admin alerts
2013-06-20 07:51:40 -07:00
a546472775
remove extra box around TH on topic lists
...
this is mostly to make /categories less visually noisy
2013-06-20 01:39:32 -07:00
70683c1f09
Merge pull request #1034 from chrishunt/rebake-oneboxes
...
Optionally rebake oneboxes with posts:rebake task
2013-06-20 01:18:57 -07:00
14db3869ba
Merge pull request #1050 from abbat/master
...
Russian translation (actual version)
2013-06-20 01:17:53 -07:00
cb1b956ac2
we need overflow auto on code blocks
2013-06-20 17:46:18 +10:00
08df4c41cc
Merge branch 'master' of github.com:discourse/discourse
2013-06-20 17:42:29 +10:00
4a8a663a67
flagging workflow changes per http://meta.discourse.org/t/we-need-an-archive-flag-notification-button/7450
2013-06-20 17:42:15 +10:00
f1a1b8ca11
Russian translation (actual version)
2013-06-20 03:44:07 +04:00
6424a3d3e1
remove max-width on h1, seems unnecessary?
2013-06-19 16:31:18 -07:00
da582fc202
switch bookmark from yellow to blue
2013-06-19 16:01:39 -07:00
e0ff74ead0
extract Admin::UsersController#index to its own query class
...
- move query to its own class
- use postgres ILIKE case insensitive
- removed duplicated list of trust levels
2013-06-19 13:48:45 -07:00
e263bb3c0a
Anons should be able to see post history
2013-06-19 16:43:16 -04:00
8a26b86739
added image magick alert
2013-06-19 22:36:56 +02:00
9036738ba2
added s3 file uploads alert
2013-06-19 22:11:11 +02:00
4a17d6dca6
added a rake task to clean orphan uploaded files
2013-06-19 21:51:41 +02:00
8b9b87f42e
Remove extra padding at top of posts
2013-06-19 14:30:05 -04:00
3e0f47705a
Remove some extra padding on the right of post info
2013-06-19 13:35:44 -04:00
5ef6714d48
New site setting: `minimum_topics_similar`, allows you to specify a minimum amount
...
of topics that need to be in the database before it will suggest similar topics as
a user creates a post.
2013-06-19 13:14:24 -04:00
6491bda4ab
fix the positioning for replies
...
fix stubs
2013-06-19 18:23:01 +10:00
ef76e18215
Optionally invalidate onebox in PostAnalyzer#cook
2013-06-19 00:19:42 -07:00
6a9484155d
oops forgot to reorder this
2013-06-19 17:04:34 +10:00
31bcabd5e1
minor UI fixes for site customisations
2013-06-19 15:18:22 +10:00
e7d6b25998
shuffle around the topic metadata so we don't need absolute positioning
2013-06-19 14:44:36 +10:00
799b402778
fix horribly broken invite code, could lead to inviting the wrong person to a conversation
2013-06-19 10:31:19 +10:00
66c18a0bec
I missed one td that needs the activity class
2013-06-18 18:53:34 -04:00
21efbc7d92
Edits link is same colour as date when at lowest heatmap level
2013-06-18 18:45:26 -04:00
b7efd0be50
Move post date and edits link to top right of content area
2013-06-18 17:35:37 -04:00
c9556b4bb8
Remove bookmark from top right of post; move its functionality to the post menu button
2013-06-18 17:35:37 -04:00
87024c8676
Allow reply by email for admins in PMs
2013-06-18 17:26:33 -04:00
8af9952b25
Change all headers to X-Discourse-* instead of Discourse-*
2013-06-18 15:54:02 -04:00
60fce196c7
More Qunit tests including a CLI runner
2013-06-18 13:44:20 -04:00
8e96299653
FIX: `Discourse.Presence` was broken on arrays. The flag button was showing for anonymous users.
2013-06-18 11:36:48 -04:00
7544e231c5
Make edit category modal a little taller so scroll bar is not rendered
2013-06-18 11:00:20 -04:00
eea00afb80
tos and privacy urls redirect based on site settings
2013-06-18 10:52:04 -04:00
b9a2469774
Merge pull request #1041 from vipulnsward/refactor_topics_controller
...
Refactor `TopicsController` and remove code duplication
2013-06-18 06:35:32 -07:00
6989851cd4
Merge pull request #1038 from ZogStriP/keep-uploads-reverse-index-up-to-date
...
Keep uploads reverse index up to date
2013-06-18 00:43:31 -07:00
14e7bb4a08
improve style a tiny bit
2013-06-18 17:22:37 +10:00
80c42753e1
fix up find as you type for the invite into PM function
...
allow mods to remove users from a PM
2013-06-18 17:17:01 +10:00
531587c5ca
Refactor `TopicsController` and remove code duplication
2013-06-18 11:22:09 +05:30
7abb20928b
Merge pull request #1033 from chrishunt/move-dynamic-favicon-to-user
...
Move 'dynamic favicon' setting to User preference
2013-06-17 17:31:02 -07:00
8acdc18bc8
First stab at polling support for POP3S / reply by email
2013-06-17 16:49:02 -04:00
ae3543872c
renamed the `sha` column to the proper `sha1`
2013-06-17 22:16:14 +02:00
281a08a99f
Allow people to capitalize a word when ninja-editing a post
2013-06-17 15:57:13 -04:00
014db4c2e9
Discourse.Site.instance now returns a singleton object; add js test for NavItem
2013-06-17 13:05:08 -04:00
3c7eb3a4e8
FIX: null dates crashed the client app. `last_posted_at` was not updating properly on split topic.
2013-06-17 13:02:50 -04:00
c2d9d95237
FIX: Dates in the history window shouldn't wrap in spans
2013-06-17 11:56:50 -04:00
797b99db7c
Moved a bunch of tests to QUnit. Added basic `Discourse.Site` support to test suite.
2013-06-17 11:38:30 -04:00
2174c0d661
improve code highlight formatting, pre is still messed up though, it should wrap
2013-06-17 17:49:02 +10:00
a15ab2a0a6
flag type summary
2013-06-17 17:15:56 +10:00
4714d31c01
fix scrolling while clicking up and down on search results
2013-06-17 16:23:03 +10:00
7ca5ab3da3
allow api for restricted by global password sites
2013-06-17 16:09:59 +10:00
30df1b1815
fix positioning regression
2013-06-17 16:05:41 +10:00
80c03b7b1e
case sensitive where it should not be
2013-06-17 15:47:18 +10:00
8c7519df86
missing pluralization
2013-06-17 15:37:46 +10:00
dd5cd1df4f
Merge pull request #1037 from ZogStriP/imagineering
...
Imagineering
2013-06-16 22:01:10 -07:00
f13f6adc0b
cursor pointer should always be the case for <a> ... not being pointer is an exception
2013-06-17 13:43:30 +10:00
0052e78bfe
render error when people attempt to save an invalid group name
...
hide controls when we showing an automatic group
2013-06-17 13:43:06 +10:00
b97d186cb5
automatic groups should not allow you to muck with the listed users in the group
2013-06-17 12:54:25 +10:00
7c73140674
offsets for find as you type names for PMS and Groups were crazy, change it so it renders the autocomplete below.
2013-06-17 12:14:59 +10:00
dbfd40da84
order group member by username, bump up max count to 200 for now
2013-06-17 12:02:48 +10:00
af45b5a11e
proper column naming
...
silly schemaless database habits are hard to kill
2013-06-17 04:02:17 +02:00
fe979b7299
correct suggested list trigger to perform all work AFTER it is debounced, avoids incorrect new/unread items
2013-06-17 12:00:06 +10:00
454636abf1
annotate models
2013-06-17 02:49:34 +02:00
510bac4b27
refactored a bit & tested thumbnails creation
2013-06-17 02:49:34 +02:00
cc9e0ec80a
create thumbnails when needed
2013-06-17 02:49:34 +02:00
d4c3fe4e6a
added `create_thumbnails?` site setting
...
defaults to `false`
2013-06-17 02:49:34 +02:00
5de03814fb
created `optimized_image` model
2013-06-17 02:49:34 +02:00
2c3f757951
moved `has_been_uploaded` and `uploaded_regex` to the `Upload` model
2013-06-17 02:49:34 +02:00
8a98310cf9
make sure we only do the work once
2013-06-17 02:49:34 +02:00
6c4554b941
identifies all uploads with the SHA1 hash of the file content
2013-06-17 02:49:33 +02:00
6ea91b4416
remove useless upload topic direct association
2013-06-17 02:49:33 +02:00
b545a49d32
Merge pull request #1025 from ZogStriP/reverse-index-take-2
...
Reverse index take 2
2013-06-16 16:49:57 -07:00
4b250dfd33
Merge pull request #1028 from vipulnsward/mute_variable_suppression
...
`toggle_mute` doesn't require a param
2013-06-16 12:50:53 -07:00
d6069092b2
DRY up preference loading in Discourse.User#save
2013-06-15 00:05:55 -07:00
09d3800701
Move 'dynamic favicon' from Server to User pref
2013-06-14 23:58:24 -07:00
ce82d18df5
fix unescaped string
...
improve tab "active" detection for categories
2013-06-15 15:45:22 +10:00
06b7085287
Add classes to the th elements for everything in topic list too
2013-06-14 18:26:49 -04:00
247ef08799
Add distinct classes to posts, likes, and views td elements in topic lists
2013-06-14 17:45:05 -04:00
07e4cba281
Move the render replies button into the post-controls div with the other buttons
2013-06-14 17:38:43 -04:00
a650593f89
Add classes to all post menu buttons
2013-06-14 17:15:21 -04:00
002d4b4e23
Fix for using non-ascii category name as a link in top_menu
2013-06-14 15:49:48 -04:00
f198c814a8
Add explanations for deactivate user and block user buttons in admin
2013-06-14 11:34:03 -04:00
f62c421c91
Render category descriptions differently on the categories page
2013-06-14 11:18:44 -04:00
8298a07fd9
`toggle_mute` doesn't require a param
2013-06-14 11:08:59 +05:30
037f62928b
add proper post_uploads reverse index
2013-06-13 23:44:24 +02:00
5193ddc72f
Super basic test support for listing topics
2013-06-13 15:08:42 -04:00
cb6774a895
FIX: Impersonate was hidden when navigating to user details page in admin from list.
2013-06-13 13:47:31 -04:00
4db8204a15
Remove topic links when a post is deleted
2013-06-13 13:41:54 -04:00
49c09898e2
The EmailBuilder now creates the Reply by Email Key if necessary.
2013-06-13 12:40:06 -04:00
cf9b6beb13
Add specs for all user notifications, including whether they support
...
reply by email.
2013-06-13 12:40:01 -04:00
e29f4a3496
Work in Progress: Reply By Email:
...
- Add support classes and settings to enable reply by email
- Split out Email builder to be more OO, add many specs
2013-06-13 12:39:56 -04:00
7f7ef29e42
Fix for message saying 'There are no more 29-category topics.'
2013-06-13 12:18:11 -04:00
ef18a3ad5c
Locales should be sorted in dropdown
2013-06-13 12:18:11 -04:00
3f03ce3c8c
Merge pull request #1018 from abbat/patch-1
...
pluralizationRules for Russian translation
2013-06-13 07:21:35 -07:00
cb40ceb9e8
Merge pull request #1019 from ZogStriP/reverse-index-of-user-uploads
...
added a reverse index of user uploads + rake task
2013-06-13 07:20:55 -07:00
f7de9f17d5
refactor validators
...
add a new setting for min pm body length
use that setting for flags
scale entropy check down for pms
2013-06-13 18:18:43 +10:00
875ee62d45
we don't need these move events, they always get in the way of me profiling cause they flood the uis with event
2013-06-13 13:17:26 +10:00
28853177fd
fix autoclose to work with jquery 1.9 and moment js
2013-06-13 12:03:44 +10:00
e6e81efe85
correct information leak in page not found
2013-06-13 10:27:17 +10:00
770c1faeb1
added a reverse index of user uploads + rake task
2013-06-13 01:43:50 +02:00
246148d4ff
Make topics invisible when first post is automatically hidden because of spam flags
2013-06-12 16:02:11 -04:00
77b218a142
FIX: Do not suggest similar topics from secure categories you can't see.
2013-06-12 13:45:11 -04:00
2c68dd1c12
Put h3 footer messages inside the footer tag for easier styling
2013-06-12 13:02:48 -04:00
848bd01ecd
pluralizationRules for Russian translation
2013-06-12 20:04:40 +04:00
28ac110a3c
Add eu-west-1 to s3 regions
2013-06-12 12:02:47 -04:00
a104c37d63
Experiment: QUnit for integration Ember integration tests
2013-06-12 11:56:59 -04:00
8c888f424b
Fix change username
2013-06-12 11:24:32 -04:00
1a1115321d
Remove a console.log
2013-06-12 10:45:07 -04:00
5d7f22ed63
Include the latest class on the a tag in posters list
2013-06-12 10:45:07 -04:00
1ecdd73a71
Merge pull request #1016 from abbat/master
...
Russian translation (draft)
2013-06-12 07:44:51 -07:00
ae1f5b3de0
goodbye NaNy
2013-06-12 16:38:02 +10:00
2a43d70869
refactor
2013-06-12 16:00:43 +10:00
165751e71b
compact is better
2013-06-12 15:47:58 +10:00
d5b07464ea
partial fix for suggested js error
2013-06-12 15:24:45 +10:00
201891f51f
refactor and fix bug I introduced
2013-06-12 14:56:31 +10:00
eca2931a63
double notification is not really something we need.
2013-06-12 14:14:15 +10:00
f6060d5ff6
Russian translation (draft)
2013-06-12 06:58:16 +04:00
74041be23b
bring back some instrumentation
2013-06-12 11:47:03 +10:00
c1f6169b48
hidden and deleted state in user stream
2013-06-12 11:14:08 +10:00
6bf2f15610
use lodash cause we like lodash (faster and we can remove templating easily)
2013-06-12 10:23:47 +10:00
eb91a0c9df
Merge pull request #1012 from ZogStriP/extract-imgur-support-to-a-gem
...
Extract imgur support to a gem
2013-06-11 16:59:53 -07:00
334194ef82
Merge pull request #1013 from ZogStriP/replaced-lightbox-with-magnific-popup
...
replaced colorbox with magnific popup lightbox
2013-06-11 16:58:59 -07:00
48ee32f23e
Get value for each property in i18n helper
2013-06-11 16:42:12 -07:00
a362d62b42
Do not return mail password in EmailController
2013-06-11 16:00:13 -07:00
ba3d07ddcb
replaced colorbox with magnific popup lightbox
2013-06-12 00:32:48 +02:00
bddc9dd4b8
FIX: Replace modal with an empty view when closed. Fixes the bug where you'd edit a category, close
...
and then click edit again.
2013-06-11 16:41:09 -04:00
8a2d635e62
removed imgur support
2013-06-11 21:51:41 +02:00
a53f958c78
Fix error when trying to edit a category with empty slug
2013-06-11 15:43:07 -04:00
82b5f57e40
Make it possible to set a site setting to empty string
2013-06-11 14:31:38 -04:00
811a0df68b
Make s3 region site setting a drop down
2013-06-11 14:24:04 -04:00
ffde23f09f
FIX: Header was sometimes being shown twice in a topic
2013-06-11 13:31:07 -04:00
0cbf7c2417
FIX: Error viewing user page when not logged in.
2013-06-11 12:58:12 -04:00
82116d5db5
FIX: Change username view was not loading. Also you can always edit yourself.
2013-06-11 12:35:46 -04:00
8b4e3402c2
Small improvements to digest emails and preview mechanism.
2013-06-11 12:27:11 -04:00
45cff9c674
Merge pull request #1011 from chrishunt/add-parens
...
Add missing parentheses to moment()
2013-06-11 09:01:04 -07:00
d5c7e6b5f4
Add missing parentheses to moment()
2013-06-11 08:46:14 -07:00
5ff7e570ac
Add support for enum site settings that render as a dropdown; use a dropdown for default_locale
2013-06-11 11:40:14 -04:00
c27d5dc2bd
regression, empty suggested list after posting a topic
2013-06-11 18:10:28 +10:00
c2cfbce9ce
automatically updating times for posts on topic
...
moved moment.js into localization file (we need to localize it)
added helpers for date formatting use, moment().shortDate() moment().longDate() moment().shortDateNoYear()
2013-06-11 17:25:50 +10:00
6d85dc1724
bring in unread items to "latest" as well as new items.
2013-06-11 15:51:43 +10:00
4d7a520a8c
don't render 0 ... also this file needs some love
2013-06-11 15:27:26 +10:00
4e01b84695
fix digest
2013-06-11 15:27:26 +10:00
fa8a84f20c
removed sugar.js, port functionality to moment and underscore.js
...
bring in latest ace from local so we don't mess up with https
2013-06-11 15:27:26 +10:00
eed5875505
fix bug with wrapping
2013-06-11 15:27:26 +10:00
a92bb46966
edit date to use formatter, compensate for invalid local time (at least don't blow up)
2013-06-11 15:27:26 +10:00
850123dce8
FIX: User Pill errors
2013-06-10 18:51:25 -04:00
ab5507ac06
Merge pull request #1002 from chrishunt/add-stack-exchange-onebox
...
Add Stack Exchange onebox
2013-06-10 12:38:03 -07:00
93bbe190c0
Moved Email components into a module
2013-06-10 15:34:10 -04:00
78000fe870
Fix category delete
2013-06-10 14:20:06 -04:00
9b1d0baf45
Send a message to moderators when a newuser_spam_host_threshold is exceeded. Send it no more than once per day per user.
2013-06-10 13:17:32 -04:00
0d83f373b8
Add some logic to jumpTop/jumpBottom when best of is enabled
2013-06-10 13:07:54 -04:00
1fb0b424ed
Add Stack Exchange onebox
2013-06-10 09:27:13 -07:00
3b7d3aa487
FIX: Search wasn't using the lowercase username for finding the context.
2013-06-10 10:42:06 -04:00
ad6705cca7
Update Ember to latest master (RC5)
2013-06-10 10:14:42 -04:00
b4a4774165
extend consumer email warning to yahoo & outlook
2013-06-10 00:08:06 -07:00
4f606ffd8e
Some minor cleanups
...
1. Change map to keys
2. Remove overshadow
3. Remove var
2013-06-10 10:38:10 +05:30
6a6496eedf
Merge pull request #995 from novemberkilo/master
...
Refactoring Post model
2013-06-09 16:19:06 -07:00
2d14b54096
Merge pull request #988 from chrishunt/add-dynamic-favicon
...
Add 'dynamic favicon' setting
2013-06-09 16:13:54 -07:00
3fdba0019b
Extract callbacks and validations for Post
...
Move Post create callbacks to PostCreate
Extract Post validations
Move stripped_length_validator to lib/validators
2013-06-09 20:47:04 +02:00
26f378e022
Merge pull request #989 from chrishunt/redirect-when-cant-edit
...
Fix RestrictedUserRoute
2013-06-08 07:16:22 -07:00
1756f713d6
SECURITY HOLE, upgrade right away if you are using Secure Groups.
2013-06-08 23:52:06 +10:00
3bdfdd7c04
Redirect when can_edit === false or undefined
2013-06-07 22:09:51 -07:00
af1c14939e
Add 'dynamic favicon' setting
2013-06-07 17:15:49 -07:00
eab38b5c34
JSHint fix :(
...
)
2013-06-07 18:08:08 -04:00
b46b533e70
Create the composer view with the defaultContainer. This is in prep for redeploying
...
on RC5. Ideally we'll change how the composer is instantiated altogether but that will
have to wait for a future release.
2013-06-07 18:04:51 -04:00
a6f67d85eb
also should have caught this earlier
2013-06-08 07:47:48 +10:00
1e725629cd
no idea how this was even working
2013-06-08 07:45:45 +10:00
fa4cfa1269
ScreenTrack refactor - removes logic from TopicView didInsertElement
2013-06-07 17:20:10 -04:00
34e1f376f6
Add [PM] to subject of email notifications for private messages
2013-06-07 15:50:11 -04:00
463be6fadf
Merge pull request #982 from jd-erreape/add_scopes_to_roleable
...
Added role scopes to roleable
2013-06-07 12:08:26 -07:00
cdc3a57a91
Merge pull request #983 from ZogStriP/fix-combobox-not-working-properly
...
FIX: combobox were not working properly
2013-06-07 12:08:04 -07:00
3f5c12ca1b
FIX: combobox were not working properly
2013-06-07 20:45:31 +02:00
169125e96d
Fix a case where a random topic with null slug will be rendered instead of 404
2013-06-07 14:30:26 -04:00
668a4a3042
Move MessageBus subscribing/unsubscribing out of view
2013-06-07 14:28:33 -04:00
5217602ec3
FIX: RSS paths render a 404 for missing topics.
2013-06-07 12:52:12 -04:00
36fe8fbc6d
Added role scopes to roleable
2013-06-07 18:26:06 +02:00
3ae72259a6
Merge pull request #979 from iancmyers/strong-parameters
...
All parameters for #create in PostsController pass through strong_parameters
2013-06-07 09:17:29 -07:00
7c715e76e8
Refactor: Light pass of didInsertElement calls of views
2013-06-07 12:13:46 -04:00
1b92d9d7f8
Added roleable module for User model
2013-06-07 12:33:48 +02:00
b61e10f9ad
All parameters for #create in PostsController pass through strong_parameters.
...
We are now explicitly whitelisting all parameters for Post creation. A nice side-effect is that it cleans up the #create action in PostsController. We can now trust that all parameters entering PostCreator are of a safe scalar type.
2013-06-07 01:29:25 -07:00
d1784f1f87
more moment goodness
2013-06-07 18:27:42 +10:00
000847b8d2
date helper uses the formatter now
2013-06-07 18:27:42 +10:00
5fa20ce357
more progress towards full migration to moment.js
2013-06-07 18:27:42 +10:00
2f59c5c513
Set line height on entire row, not two columns
2013-06-06 18:37:25 -07:00
d50a598e62
Notify admin of successful user approval
2013-06-06 18:37:25 -07:00
f6ce985121
Send activation email after user approved
2013-06-06 18:37:25 -07:00
41b0692543
Show 'waiting approval' and don't send email
...
When 'must approve users' in enabled, we don't want to send an
activation email to users after they sign up. Instead, we will show them
'waiting approval' and not take an action until their account is
approved by an admin.
2013-06-06 18:36:16 -07:00
1eed1e240b
Merge pull request #977 from chrishunt/add-apple-touch-icon
...
Add 'apple touch icon url' site setting
2013-06-06 17:40:12 -07:00
7ff42377ac
$.browser is gone from jQuery 1.9 ... and this is a check for ie7 and 6 ... don't care
2013-06-07 10:38:39 +10:00
6ed79e66bc
jquery 1.9.1 upgrade ... remove jquery rails
2013-06-07 09:12:46 +10:00
564d242832
Notify moderators when someone is automatically blocked because of spam flags
2013-06-06 18:49:19 -04:00
11afa0c11b
work in progress migrate to moment
2013-06-07 08:49:22 +10:00
268a5debbf
Add 'apple touch icon url' site setting
2013-06-06 14:43:05 -07:00
a151bfc7ec
Store when a topic was first set to auto-close and report that amount of time when it closes. And do some refactoring.
2013-06-06 17:04:21 -04:00
b758427572
Fix annoying jshint :)
2013-06-06 16:48:15 -04:00
ba5f2d23a1
Fixed ContainerView code to build views correctly
2013-06-06 16:45:25 -04:00
8f32aed944
Only use HTML templates for the digest email.
2013-06-06 15:08:56 -04:00
7bc80c2dcf
Changed HTML Digest template. Removed margins, shrunk logo.
2013-06-06 14:45:32 -04:00
62041da7e0
Handle /t/only-the-slug urls by trying to find the topic by slug (second try)
2013-06-06 14:41:37 -04:00
f268b882fd
The posts rebake task should regenerate links too.
2013-06-06 13:52:30 -04:00
526f2af69a
FIX: Touch events conflicted on mobile safari with `{{action}}`s, preventing admin menu
...
option from working. Mobile Safari works with click so this seems to fix it.
2013-06-06 13:16:36 -04:00
06e83c9e6a
FIX: Hitting enter while the invite dialog is up should submit the form, not refresh the
...
entire page :)
2013-06-06 12:06:43 -04:00
bac03a3369
Merge pull request #975 from jd-erreape/username_refactor
...
[WIP] Refactored user_name suggestion methods into a module
2013-06-06 08:12:29 -07:00
96d23ddd8d
Refactored user_name suggestion methods into a module to reduce the complexity of User model
2013-06-06 16:40:10 +02:00
0d01c33482
Enabled strong_parameters across all models/controllers.
...
All models are now using ActiveModel::ForbiddenAttributesProtection, which shifts the responsibility for parameter whitelisting for mass-assignments from the model to the controller. attr_accessible has been disabled and removed as this functionality replaces that.
The require_parameters method in the ApplicationController has been removed in favor of strong_parameters' #require method.
It is important to note that there is still some refactoring required to get all parameters to pass through #require and #permit so that we can guarantee that parameter values are scalar. Currently strong_parameters, in most cases, is only being utilized to require parameters and to whitelist the few places that do mass-assignments.
2013-06-06 00:30:59 -07:00
a3d62fdf69
Temporarily roll back ember rc5. We identified some things we need to fix.
2013-06-06 01:25:43 -04:00
255a614142
keep /srv/status exposed
2013-06-06 14:40:10 +10:00
7b70330e85
FIX: Javascript errors when navigating to some topics
2013-06-05 20:53:48 -04:00
2ca734c118
Merge pull request #964 from chrishunt/exclusive-club
...
Add 'invite only' site setting
2013-06-05 16:38:47 -07:00
6384518599
Allow images in the daily digest for top scoring posts
2013-06-05 18:55:27 -04:00
4d1e8356b8
FIX: Again, try to get a flexible absolute logo_url
2013-06-05 18:23:43 -04:00
8328aa97fd
FIX: HTML email should use image_tag to get the correct path to the image
2013-06-05 18:01:40 -04:00
0b97ea6345
Better HTML emails, smarter email digests, new email section in admin with digest preview
2013-06-05 17:47:25 -04:00
f030d9b420
Make default_logo_check more smarter
2013-06-05 16:59:19 -04:00
4e8ff74b99
Show dashboard warning when favicon and/or logo urls contain the same filename as the shipped defaults
2013-06-05 16:43:39 -04:00
b55182b983
Use PostDestroyer when deleting all of a user's posts; deleting a post removes its flags and resets its flag counts
2013-06-05 16:05:13 -04:00
dfba2b6e0a
FIX: Strip links from google indexed bios when the users are new.
2013-06-05 15:28:10 -04:00
eb673c7e5d
Merge pull request #963 from chrishunt/chrishunt/refresh-user-list-after-approval
...
Refresh admin user list after approval
2013-06-05 12:07:49 -07:00
112d57e899
Merge pull request #960 from iancmyers/strong-parameters
...
Began implementing strong_parameters
2013-06-05 12:03:17 -07:00
469bf044c3
Remove superfluous }
2013-06-05 21:54:07 +03:00
a523fa56ac
Don't require authentication for invites
2013-06-05 11:12:37 -07:00
acf147ef88
Disable OmniAuth account creation if 'invite only'
2013-06-05 11:11:02 -07:00
d432798ff8
Silently fail if user tries to sneak in
...
When 'invite only' is enabled, there's no way for a user to create an
account unless they try and sneak in by POSTing to /users/. We will
silently fail if this happens.
2013-06-05 11:08:21 -07:00
8f14e46964
Hide registration on login modal if 'invite only'
2013-06-05 11:06:54 -07:00
24da1ab07e
Add 'invite only' site setting
2013-06-05 11:06:05 -07:00
7d089fdfb5
FIX: Compile templates properly with the latest handlebars
2013-06-05 14:00:02 -04:00
07cd87f941
FIX: Couldn't navigate to Categories list via link
2013-06-05 12:40:06 -04:00
a0bd51862e
Upgrade Ember to RC5. Disabled a deprecation warning that I believe is in error.
2013-06-05 12:07:18 -04:00
f05c30ab8d
Refresh admin user list after approval
2013-06-05 08:57:25 -07:00
f0d4a38433
Admin flags UI shows when it's loading and when there are no results
2013-06-05 10:24:50 -04:00
41528f5d11
Implemented strong_parameters for Upload/UploadsController.
...
The topic_id param is now required using strong_parameters' #require method. If the parameter is missing ActionController::ParameterMissing will be raised instead of Discourse::InvalidParameters.
2013-06-05 00:55:55 -07:00
f50b648844
Implemented strong_parameters for PostAction/PostActionsController.
...
PostActionsController now uses strong_parameters' #require to require certain parameters. ActionController::ParameterMissing is now thrown when a reqired parameter is missing, rather than Discourse::InvalidParameters.
2013-06-05 00:23:51 -07:00
3b245031a4
Implemented strong_parameters for Invite/InvitesController.
...
The email parameter is now required using strong parameters and will throw ActionController::ParameterMissing if it is missing. If the email address is incorrect or invalid, Discourse::InvalidParameters will still be thrown.
2013-06-05 00:04:03 -07:00
130d837952
Implemented strong_parameters for Category/CategoriesController.
...
Category now requires parameters to be permitted by strong_parameters using #require or #permit for mass-assignment. Missing required parameters now throw a ActionController::ParameterMissing execption instead of the Discourse::InvalidParameters execption.
2013-06-04 23:45:25 -07:00
870e59883b
secure the links on the topic pages, eliminated deleted topics as well.
2013-06-05 16:10:26 +10:00
913a607528
need to punch through account creation stuff
2013-06-05 14:01:24 +10:00
2dfba8d6de
we need to be able to do username checks for registration to work
2013-06-05 12:50:42 +10:00
2509d0f4fa
Merge pull request #959 from chrishunt/chrishunt/login-required-fixes
...
'login required' site setting improvements
2013-06-04 19:09:40 -07:00
93be638d93
message format is awesome, remove 0 unread and 0 new links.
2013-06-05 12:04:54 +10:00
3074300f76
Allow customization of 'login required' message
2013-06-04 18:53:36 -07:00
3774808a6e
Redirect to '/' if OmniAuth login from '/login'
2013-06-04 18:35:20 -07:00
e52e46a609
fix blank created_at .. date is unbound, we should rename it to unboundDate
2013-06-05 11:32:53 +10:00
9a57aaaaa9
fix encoding for category excerpt
...
fix missing secure category topics in categories page
2013-06-05 11:22:47 +10:00
28aeb1d36c
Remove static navigation from login page
2013-06-04 18:20:03 -07:00
5e305eaf0a
missing skip filter for omniauth
2013-06-05 10:30:51 +10:00
21b3359ea4
Merge pull request #957 from chrishunt/chrishunt/lock-down-the-base
...
Add 'login required' site setting
2013-06-04 17:22:08 -07:00
56ee7cdc1f
Merge pull request #956 from ZogStriP/fix-image-upload-to-s3
...
fix image uploads on s3/imgur
2013-06-04 16:34:42 -07:00
5f85aaee1d
correct message bus regression
...
implement automatically updating dates in list
2013-06-05 09:32:44 +10:00
122f9188c9
Redirect Ember routes to login if login required
2013-06-04 16:10:10 -07:00
Robin Ward
Jeff Atwood
Sam
Anton Batenev
Jesse House
Neil Lalonde
Régis Hanol
Chris Hunt
Vipul A M
Chris Hunt
Navin
Juan de Dios Herrero
Ian Christian Myers
Stephan Kaag