Commit Graph

52155 Commits

Author SHA1 Message Date
Martin Brennan d40c0b698c
FIX: Word wrap for quote buttons (#24620)
The button text was becoming multiline unnecessarily
2023-11-29 10:43:52 +10:00
Martin Brennan dfd9c9b8d0
DEV: Fix flagging post flaky (#24619)
Followup to 91ec3323dd,
remove DB check and check actual UI.
2023-11-29 08:16:52 +10:00
dependabot[bot] 71ae565229
Build(deps): Bump excon from 0.104.0 to 0.105.0 (#24618)
Bumps [excon](https://github.com/excon/excon) from 0.104.0 to 0.105.0.
- [Changelog](https://github.com/excon/excon/blob/master/changelog.txt)
- [Commits](https://github.com/excon/excon/compare/v0.104.0...v0.105.0)

---
updated-dependencies:
- dependency-name: excon
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-11-28 23:15:34 +01:00
dependabot[bot] 33d0b9375a
Build(deps): Bump json_schemer from 2.1.0 to 2.1.1 (#24617)
Bumps [json_schemer](https://github.com/davishmcclurg/json_schemer) from 2.1.0 to 2.1.1.
- [Changelog](https://github.com/davishmcclurg/json_schemer/blob/main/CHANGELOG.md)
- [Commits](https://github.com/davishmcclurg/json_schemer/compare/v2.1.0...v2.1.1)

---
updated-dependencies:
- dependency-name: json_schemer
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-11-28 23:14:55 +01:00
Isaac Janzen 8f6e8344aa
DEV: Remove unused search plugin outlets (#24614) 2023-11-28 14:55:22 -07:00
Isaac Janzen 9a909758ac
FIX: Escape topic titles when `use_pg_headlines_for_excerpt` true (#24608) 2023-11-28 14:32:22 -07:00
Kris 9576f3ec97
UX: create category doesn't always need a dropdown (#24610) 2023-11-28 16:28:07 -05:00
dependabot[bot] 2d2fd15636
Build(deps-dev): Bump the embroider group in /app/assets/javascripts with 1 update (#24615)
* Build(deps-dev): Bump the embroider group

Bumps the embroider group in /app/assets/javascripts with 1 update: [@embroider/compat](https://github.com/embroider-build/embroider/tree/HEAD/packages/compat).

- [Release notes](https://github.com/embroider-build/embroider/releases)
- [Changelog](https://github.com/embroider-build/embroider/blob/main/CHANGELOG.md)
- [Commits](https://github.com/embroider-build/embroider/commits/HEAD/packages/compat)

---
updated-dependencies:
- dependency-name: "@embroider/compat"
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: embroider
...

Signed-off-by: dependabot[bot] <support@github.com>

* Update lockfiles for ember version flag

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: discoursebuild <build@discourse.org>
2023-11-28 22:23:13 +01:00
Kris 18a0783643
FIX: use correct color for inputs (#24616) 2023-11-28 16:21:36 -05:00
Jordan Vidrine 178c1f74ae
UX: Place login button text in span tag (#24613) 2023-11-28 15:02:30 -06:00
Isaac Janzen e4499d98e6
DEV: Update `search-menu-before-term-input` outlet args (#24573) 2023-11-28 13:47:23 -07:00
Bianca Nenciu fae3b89818
FIX: Add setters for some group properties (#24572)
These properties are set on the "Manage > Categories" group page. It
used to work, but only because it overridden the properties and it did
not update the IDs too.
2023-11-28 21:38:49 +02:00
Kris 19378cc068
FIX: lint unlinted file (#24612) 2023-11-28 14:11:55 -05:00
Kris 6d624c6f1a
UX: fix disabled input styles (#24603) 2023-11-28 14:10:41 -05:00
Jordan Vidrine 35dde2da21
FIX: Add more specificity to outline (#24611) 2023-11-28 12:44:45 -06:00
Jordan Vidrine 12902c1fc1
FEATURE: Add search menu outlet (#24609) 2023-11-28 12:12:09 -06:00
Joffrey JAFFEUX ee5bdb3436
DEV: refactor flag message (#24604)
- Uses a chat service: `Chat::FlatMessage`
- Moves logic inside chat api controllers
- Create a javascript chat api helper: `chatApi.flagMessage(...)`
2023-11-28 18:24:09 +01:00
Jan Cernik de0c761516
DEV: Skip flaky chat transcript specs (#24607) 2023-11-28 14:13:25 -03:00
Isaac Janzen feb5eda0d1
DEV: Make `theme-qunit` discoverable from `/tests` (#24606)
https://github.com/discourse/discourse/assets/50783505/c6db8c35-1473-4ccd-aca2-bfb71af9e73e
2023-11-28 10:04:23 -07:00
Jarek Radosz d7f618807e
DEV: Don't warn about clearing tmp/cache (#24602)
No reason to print it out every time 😅 (plus, use the ruby method)
2023-11-28 18:02:27 +01:00
Jordan Vidrine 8f901cdd38
UX: Change direction of focus outline (#24605) 2023-11-28 10:58:16 -06:00
Bianca Nenciu e85a81f33c
FIX: Make category-drop work with lazy_load_categories (#24187)
The category drop was rerendered after every category async change
because it updated the categories list. This is not necessary and
categories can be referenced indirectly by ID instead.
2023-11-28 17:58:47 +02:00
Blake Erickson 21d614215b
DEV: Use staged user check instead (#24578)
This change refactors the check `user.groups.any?` and instead uses
`user.staged?` to check if the user is staged or not.

Also fixes several tests to ensure the users have their auto trust level
groups created.

Follow up to:

- 8a45f84277
- 447d9b2105
- c89edd9e86
2023-11-28 07:34:02 -07:00
Jarek Radosz 2a3418fe24
DEV: Don't use the deprecated `createEvent()` (#24601) 2023-11-28 15:05:51 +01:00
Jarek Radosz 9d44d833d5
DEV: Remove unnecessary `getURL()` calls (#24591)
`ajax()` already uses it
2023-11-28 14:32:15 +01:00
Alan Guo Xiang Tan 91ec3323dd
DEV: Temporary fix for flaky system test (#24598)
Why this change?

Asserting against records of the database in system tests can be flaky
because those assertions can run against the database before the server
has actually saved the necessary changes to the database.

What does this change do?

While the assertion is not ideal, we are working around this as a
temporary fix by using `try_until_success` which will retry the
assertion up till the default capybara timeout.
2023-11-28 21:00:56 +08:00
Jarek Radosz 0cad82ef55
DEV: Update click-track tests (#24597) 2023-11-28 13:54:30 +01:00
David Taylor 5783f231f8
DEV: Introduce `DISCOURSE_ASSET_URL_SALT` (#24596)
This value is included when generating static asset URLs. Updating the value will allow site operators to invalidate all asset urls to recover from configuration issues which may have been cached by CDNs/browsers.
2023-11-28 11:28:40 +00:00
Natalie Tay 22ce638ec3
FIX: Use subfolder-safe url for category in html view (#24595)
Use subfolder-safe url for category in html view
2023-11-28 19:08:14 +08:00
dependabot[bot] 1eaf774f47
Build(deps): Bump actions/setup-node from 3 to 4 (#24594) 2023-11-28 10:57:28 +01:00
Jarek Radosz 4953bced64
DEV: Remove unused searchTags param (#24590) 2023-11-28 10:56:36 +01:00
Jarek Radosz 4c7793940a
DEV: Fix "no-dupe-keys" lint (#24589) 2023-11-28 10:55:52 +01:00
Jarek Radosz e9356c2ec9
DEV: Fix "no-empty" lint (#24588) 2023-11-28 10:55:02 +01:00
Jarek Radosz 70dc6bcfd3
DEV: Fix "no-unsafe-finally" lint (#24587) 2023-11-28 10:54:13 +01:00
Jarek Radosz 916e1371b3
DEV: Fix "ember/no-global-jquery" lint (#24586) 2023-11-28 10:53:38 +01:00
Jarek Radosz 22210a9c15
DEV: Fix "no-setter-return" lint (#24585) 2023-11-28 10:49:49 +01:00
Jarek Radosz cfa7dcaf0a
DEV: Remove unnecessary `await settled()` (#24584) 2023-11-28 10:45:20 +01:00
Jarek Radosz b2dfc320aa
DEV: Fix `super` calls in native chat classes (#24583) 2023-11-28 10:44:47 +01:00
Jarek Radosz a80e32fe75
DEV: Fix `no-extra-boolean-cast` lint (#24582) 2023-11-28 10:37:23 +01:00
David Taylor cbc5694b77
DEV: Remove RAILS_MASTER flag from Gemfile (#24574)
We don't use this flag, and it prevents Dependabot from being able to automatically create PRs for Rails gem updates
2023-11-28 09:36:23 +00:00
Jarek Radosz cd69891b14
DEV: Fix `no-unnecessary-curly-parens` lint rule (#24581) 2023-11-28 10:35:36 +01:00
Jarek Radosz 103fab37e3
DEV: Fix `no-unnecessary-curly-strings` lint rule (#24580) 2023-11-28 10:35:09 +01:00
Martin Brennan 3e639e4aa7
FIX: Add higher read & open timeouts for group SMTP emails (#24593)
When sending SMTP for group SMTP functionality, we
are running into timeouts for both read and open
when sending mail occassionally, which can cause issues
like the email only being sent to _some_ of the recipients
or to fail altogether.

The defaults of 5s are too low, so bumping them up to
the defaults of the `net-smtp` gem.
2023-11-28 15:32:59 +10:00
Martin Brennan 1fc0ce1ac2
FIX: with_secure_uploads? could return nil in some cases (#24592)
When we check upload security, one of the checks is to
run `access_control_post.with_secure_uploads?`. The problem
here is that the `topic` for the post could be deleted,
which would make the check return `nil` sometimes instead
of false because of safe navigation. We just need to be
more explicit.
2023-11-28 13:12:28 +10:00
dependabot[bot] b21a559663
Build(deps-dev): Bump fabrication from 2.30.0 to 2.31.0 (#24579)
Bumps [fabrication](https://gitlab.com/fabrication-gem/fabrication) from 2.30.0 to 2.31.0.
- [Changelog](https://gitlab.com/fabrication-gem/fabrication/blob/master/Changelog.markdown)
- [Commits](https://gitlab.com/fabrication-gem/fabrication/compare/2.30.0...2.31.0)

---
updated-dependencies:
- dependency-name: fabrication
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-11-27 23:05:16 +01:00
Krzysztof Kotlarek 5551a71c55
FEATURE: increase tag description limit to 1000 (#24561)
Admin can add tag description up to 1000 characters.

Full description is displayed on tag page, however on topic list it is truncated to 80 characters.
2023-11-28 08:45:40 +11:00
Penar Musaraj 633deb5af8
UX: Submit security key edit form on Enter (#24532)
Co-authored-by: Jarek Radosz <jradosz@gmail.com>
2023-11-27 16:11:12 -05:00
David Taylor cda86e63bb
DEV: Run ember enforcement on merge-result ref (#24577)
Checking out the raw PR branch was only needed for the dependabot-helper workflow, but then I copy/pasted it here 🤦‍♂️

Followup to 16b6e86932
2023-11-27 20:27:32 +00:00
Blake Erickson 52617e7425
DEV: Auto link video placeholder posts (#24576)
* DEV: Auto link video placeholder posts

Followup to 91232847e3

Adds a migration to auto-link any video placeholder posts so that upload
references will be created.

Co-authored-by: Jarek Radosz <jradosz@gmail.com>
2023-11-27 13:22:42 -07:00
David Taylor 6f3b087907 DEV: Generate Ember5 lockfile 2023-11-27 16:40:22 +00:00