10d0320532
FIX: Allow expanding posts when anonymous, add specs
2014-04-03 11:30:43 -04:00
079123f008
Allow the `content_sha1` column of `topic_embed` to be nullable
2014-04-02 16:18:51 -04:00
558a06a117
Adds better reusable error message support. Added to fetching remote
...
posts. /cc @riking
2014-04-02 13:22:10 -04:00
f5c7ccb4e6
New field: Whether or not to include an expandable first post for
...
embedded content.
2014-04-02 10:26:46 -04:00
eff20fdda7
fix bust spec
2014-04-02 16:22:12 +11:00
317f9bcd08
Use custom DiscourseSassImporter for site customization SCSS compilation.
2014-04-01 23:05:02 +05:30
77a8a4083a
Revert "Merge pull request #2125 from vikhyat/css-variables"
...
This reverts commit b537de3ca5b925827e5b
2014-04-01 16:24:29 +02:00
df5ef38085
Use custom DiscourseSassImporter for site customization SCSS compilation.
2014-04-01 17:25:35 +05:30
a3f270f0e9
BUGFIX: broken spec
2014-04-01 16:08:18 +11:00
706fd3c59a
Merge pull request #2206 from riking/posted
...
Fix the 'posted' view so that it actually does something
2014-03-31 23:05:48 +02:00
ef24a4c71c
FEATURE: add redirect_users_to_top_page site setting (default to true)
2014-03-31 21:53:38 +02:00
379f4a87d5
FIX: remove likes and other post actions before nuking a user
2014-03-31 14:06:35 -04:00
8fc2549873
Stop using global vars where not needed
...
Simplify local process site setting provider
Stop setting up methods over and over
Centralize cache clearing
2014-03-31 12:34:13 +11:00
64b0d7e0ea
PERF: use before suite vs before file
...
BUGFIX: correctly punch through settings to local provider
2014-03-31 12:34:13 +11:00
f3cc7360e0
BUGFIX: Correct after_fork semantics
...
After fork SiteSettings was not getting a new process id,
causing site settings not to refresh properly in unicorn
This code also centralizes the logic
2014-03-31 12:34:13 +11:00
df5229a399
Add spec for posted list
...
The test fails on 956b14a
2014-03-30 14:21:35 -07:00
3ee8b087ca
Merge pull request #2197 from aslakknutsen/feed_url_case
...
Normalize URL from Feed Entry after adding link to original in Topic
2014-03-28 15:09:55 +01:00
e6989b5313
Merge pull request #2192 from jorgemanrubia/configurable-emails-prefix
...
Option to change the subject prefix in emails
2014-03-28 15:08:50 +01:00
fd504e741f
FIX: reply by email can handle emails with attachments. Attachments are still ignored, but a post or topic can be created from the email now.
2014-03-28 09:57:20 -04:00
f011fbdca9
Normalize URL from Feed Entry after adding link to original in Topic
...
Since a URL might be case sensitive, adding a link to the original
Feed Entry with changed case to the Topic could end in 404.
2014-03-27 20:48:01 +01:00
806924dd7e
Option to change the email subject prefix
...
It adds a new setting 'email_prefix' to configure which [label] will be used in the subject of emails. Discourse currently uses '[title]'. The problem is that sometimes you need to set a longer title, that doesn't really work well for emails. I think this is very common since the HTML `<title>` tag is very important for SEO.
It will default to '[title]' if this setting is not used.
See: https://meta.discourse.org/t/where-to-change-the-email-subject-prefix/11989
2014-03-26 23:06:00 +01:00
38882eb1a7
Remove threequals from ruby files
2014-03-26 12:20:41 -07:00
be06156629
SECURITY: when enabled_local_logins is false users could log in via API
...
thanks @Nicholas Blanco
2014-03-26 15:39:44 +11:00
5897d3419c
BUGFIX: identity_url was not fished out correctly
...
If I user logged in with Google and then changed email,
they would no longer be able to log in with google
2014-03-26 14:52:50 +11:00
4191972afe
Merge pull request #2173 from vikhyat/badge-system
...
Forgot to specify "dependent: destroy" for UserBadges
2014-03-25 08:25:31 +11:00
ea86cfd4ef
FIX: categories with non-ascii names will have broken next page urls
2014-03-24 13:36:23 -04:00
b1e524e9c3
Specify `dependent: destroy` for UserBadges.
2014-03-24 22:39:58 +05:30
539890afdf
Let's not show tons of extra information about invites unless you're the
...
person who invited them.
2014-03-21 14:16:11 -04:00
dcaa069bb5
Log badge grant/revoke to the staff actions log.
2014-03-21 11:10:07 +05:30
342d09bc34
FIX: support sso_url that has query params
2014-03-19 17:14:31 -04:00
d3f1eb395d
Updated import for TypePad
2014-03-19 15:02:49 -04:00
c708d6fcb8
FIX: post_mover_spec needs to order posts
2014-03-19 11:05:18 -04:00
9fc31932cf
BUGFIX: don't alery myself when I link to myself
2014-03-19 12:07:48 +11:00
0b1550f9d4
Add excerpt column to topics table to remove N+1 query in ListableTopicSerializer
2014-03-18 15:24:29 -04:00
5c26b3dad1
FIX: broken specs after new link alerting code
2014-03-18 15:22:53 +11:00
2c725e2779
FEATURE: Trust level 4 abilities: pin/unpin, close, archive, make invisible, split/merge topic
2014-03-17 14:50:28 -04:00
e63b9b362e
allow apps to give custom admin javascripts
2014-03-17 13:19:08 +01:00
798b8444cf
BUGFIX: work correctly if process forks
2014-03-17 15:22:11 +11:00
90139efc6f
Fix spec, remove pointless have_many etc preamble
2014-03-17 12:47:47 +11:00
2c8ae22b87
FEATURE: add a simple queue Scheduler::Defer.later {}
...
For quick jobs that do not need to be sent to sidekiq,
runs inline in a single thread but does not block
2014-03-17 12:16:19 +11:00
fe63db7953
Merge pull request #2115 from vikhyat/badge-system
...
Initial badge system implementation
2014-03-17 10:06:37 +11:00
f4c2fef407
Merge pull request #2121 from LessonPlanet/disable-name-edit-for-sso
...
Adding name to the list of uneditable items in preferences UI
2014-03-17 10:05:11 +11:00
e3702ecb30
Improved crawler detection: add Twitterbot, Facebook, curl, Bing, Baidu.
2014-03-16 19:30:20 +05:30
98284d771f
Mark failing spec as pending for Robin to investigate
2014-03-14 18:13:45 -04:00
e22f1ae186
Support for a daily job at a certain hour. Convert backup job to run at
...
3am instead of randomly during the day.
2014-03-14 13:02:45 -04:00
9b26c8584e
Initial badge system implementation.
2014-03-14 21:49:26 +05:30
e904b2faad
Adding name to the list of uneditable items in preferences UI
...
* If enable_names, enable_sso, and sso_overrides_name settings are true.
* Added serialization of can_edit_name so the UI has access to the right.
2014-03-13 13:26:40 -07:00
9f8477d0c1
Add support for categories page to smoke tests
2014-03-13 15:03:34 -04:00
fd1c824187
Revert "Merge pull request #2116 from LessonPlanet/disable-name-edit-for-sso"
...
This reverts commit 91aa21671af19596af0d
2014-03-13 18:17:59 +01:00
283dc7dd2d
Trust level 4: add ability to edit any post and see edit history
2014-03-13 10:47:49 -04:00
e8c7c6fab7
Adding name to the list of uneditable items in preferences UI
...
* If enable_names, enable_sso, and sso_overrides_name settings are true.
2014-03-12 17:09:53 -07:00
085f7997a2
FEATURE: Upload backups to S3 when complete.
2014-03-12 16:24:45 -04:00
42ca83ece5
FEATURE: New site setting to enable a daily automatic backup
2014-03-12 13:30:47 -04:00
9ca516e58d
Rename nickname to username in the code. Use new hub routes. (Old routes still exist as aliases for old Discourse instances.)
2014-03-12 12:39:36 -04:00
dc1d6decf5
Support for removal of old backups automatically via a site setting
2014-03-12 12:24:35 -04:00
cf630207b7
Remove an unused variable in check_reviving_old_topic spec
2014-03-12 10:46:50 -04:00
659e7fa4ce
FEATURE: Warn when reviving a topic that has been inactive for X days. Setting warn_reviving_old_topic_age controls when the warning is shown. Set it to 0 to disable this feature.
2014-03-12 10:44:12 -04:00
363fabd3e7
add tests for ListController.best_period_for
2014-03-12 12:58:41 +01:00
2838e1c3b5
FIX: don't show option to flag with notify_user to trust level 0 users. they can't send private messages.
2014-03-10 11:48:40 -04:00
680197200e
Add support for arrays to PluginStore
2014-03-10 14:59:59 +01:00
1b66ed903f
Merge pull request #2091 from Xenograph/fix-sso-override
...
Added spec for SSO override username/email changes
2014-03-10 13:11:25 +11:00
a1e70ac57e
Added spec for SSO override username/email changes
2014-03-09 21:38:36 -04:00
3f0964bf60
BUGFIX: spec would blow up when DST kicked in
2014-03-10 10:12:09 +11:00
8214536614
BUGFIX: don't show redirect reason if you aren't redirected
...
Move the redirect to top page logic server-side and make sure the reason
is not shown when top is not in the navigation menu (top_menu).
2014-03-07 18:58:53 +01:00
c3e5ee1d7e
FIX: Failing specs
2014-03-07 12:06:20 -05:00
f618278b42
make sure topic specs aren't DST sensitive
2014-03-07 11:38:24 +01:00
73ef91cf27
junk code removed
2014-03-07 19:00:36 +11:00
b19400726f
BUGFIX/FEATURE: store topic changes in post revisions
...
History + edit notifications for title and category changes
2014-03-07 19:00:36 +11:00
11d91328ab
Merge pull request #2056 from vikhyat/pm-likes
...
Don't suppress like notifications in private messages
2014-03-06 14:53:27 +01:00
944246f4af
Add test to ensure creation of like notification in a PM.
2014-03-06 19:07:26 +05:30
ac99947979
BUGFIX: topic specs were dependent on Time.now
...
which would fail when DST was around
2014-03-06 12:44:52 +01:00
bce4130d39
Merge pull request #2036 from ArmedGuy/profile-backgrounds
...
FEATURE: Profile Backgrounds
2014-03-05 16:00:49 +01:00
98c479c3c4
FEATURE: Profile Backgrounds
...
Shares a modified codebase with avatars called "user_image"
2014-03-05 15:10:44 +01:00
edf86a207b
fix build
2014-03-05 14:26:42 +11:00
adb6541635
FEATURE: mailing list mode always available
2014-03-05 14:21:53 +11:00
69b498da24
Merge pull request #2034 from birarda/custom_username_length
...
allow for custom username length via site setting
2014-03-05 12:06:23 +11:00
4a2dab9c5e
allow for custom min_username_length
...
change constant in user to be global range and not default
2014-03-04 16:37:05 -08:00
ea553202f0
Merge pull request #2033 from birarda/master
...
add option to override user attributes from SSO payload
2014-03-05 11:33:32 +11:00
aa3f7f764d
You can only reuse email tokens within 24 hours.
2014-03-04 14:03:04 -05:00
c3eb2025d8
add option to override user attributes from SSO payload
...
add an external_username attribute for username from SSO payload
repair the field name in SingleSignOnRecord migration
move setting of external_username for sso to controller
add settings toggle to override username/email from SSO payload
fix changing of external username after override toggle
complete tests and logic for sso override
add some extra context to username override option
add external_email and external_name to single sign on record
add setting for name override from SSO payload
complete override with stored external_email and external_name
add missing checks to tests
remove an unneeded describe block
break up a monster method for single sign on
fixes for sso attribute override after failed tests
2014-03-04 09:52:21 -08:00
5e6764e9c9
FIX: Remove update, should fix issue with broken specs
2014-03-04 12:47:14 -05:00
a2b0e2b50f
BUGFIX: Fix ailing tests
2014-03-03 16:24:20 -05:00
f9cd354a2c
FEATURE: Button to reset new
2014-03-03 15:47:01 -05:00
3abe84941f
FEATURE: Add `new_since` column to `UserStat` so we can reset the "New"
...
date.
2014-03-03 15:47:00 -05:00
5c3f2feed4
BUGFIX: recovery code in case an unknown job is scheduled
2014-03-04 07:37:12 +11:00
172e517b31
Merge pull request #2012 from ligthyear/incoming-emails
...
Advanced New-Topic via Email Feature
2014-03-03 10:58:10 +11:00
b40313559b
FIX: moderators should not be able to see site setting changes in the staff action logs. Fixes #2027
2014-02-28 16:30:54 -05:00
024597e643
Switch to proper exception handling system for better user feedback
...
- Replace implicit return code-system in Email::Receiver with proper exception system
- Update tests to check for exceptions instead
- Test the PollMailbox for expected failures
- Add proper email-handling of problematic emails
"
2014-02-28 17:02:58 +01:00
d32cb55837
Add public-inbox to Email-In-Feature
...
- Adds the advanced option to accept email from non-users per category email-address
- Adds tests covering the new feature
- Adds UI to configure this feature in the frontend
2014-02-28 16:53:58 +01:00
37cea49459
Add Email-In-Per-Category
...
- allow the configuration of an inbox-email-address per category
- post emails to that email into that category instead of global
- Adds UI for configuration
- Adds Documentation for configuration
- Adds Tests for new feature
2014-02-28 16:53:58 +01:00
4af2cf3f23
Refactor and clean up New-Topic via Email
...
With the new email_in admin configuration setting, emails to the email_in_address fetched via POP will now be processed and posted as new topics to the forum.
With the email_in_min_trust you can control the trust level the user needs to have at least to be able to post an email as a new topic.
Also contains tests for the email-in feature and minor clean ups
2014-02-28 16:53:58 +01:00
1992271bf9
FEATURE: white_listed_spam_host_domains for domains that are not blocked for spam
...
BUGFIX: bypass host spam detection for current host
2014-02-27 15:43:57 +11:00
ed7c051fcc
BUGFIX: no need for mock central here
2014-02-27 12:15:41 +11:00
a4d7942dbd
BUGFIX: Don't blow up on junk referers
2014-02-27 12:03:38 +11:00
9551f4aeea
PERF: calculate scores for topics/posts faster
...
Only look at topics that changed in last day for 15 minuted schedule
Do a full recalc weekly, just in case
2014-02-27 11:45:40 +11:00
557af84ae2
FIX: broken spec
2014-02-26 10:52:11 +11:00
50a8d3caae
BUGFIX: sso to send welcome emails
2014-02-26 10:28:03 +11:00
440435f023
FEATURE: SSO to handle return_path automatically
2014-02-26 09:58:30 +11:00
9ebcdfba1f
Merge pull request #2005 from eriko/plugin_store_delete
...
clean up plugin store when removing data instead of setting the value to...
2014-02-25 11:36:05 -05:00
6f31d3f0e5
FEATURE: single sign on support
...
Added support for outsourcing auth to a different website, documentation on meta
2014-02-25 14:31:03 +11:00
db411860c2
clean up plugin store when removing data instead of setting the value to nil.
2014-02-24 16:11:31 -08:00
4cd5ccdf1f
BUGFIX: Don't return child categories if you can't see the parent
...
category.
2014-02-24 14:52:41 -05:00
3151f59bc9
REFACTOR: We don't cache the json for the Site model anymore, so let's
...
rename and remove the methods leftover from that.
2014-02-24 14:25:37 -05:00
d555df28f2
PostsController tests clean up.
2014-02-24 18:14:35 +01:00
7aaa70770b
Remove old onebox fixtures
2014-02-21 16:04:15 -05:00
1aa27ade17
FEATURE: If you don't select any topics to "Dissmiss Read" it does all
...
by filter.
2014-02-21 15:18:45 -05:00
a07e9f7e71
FEATURE: Bulk `reset read` status.
2014-02-21 15:18:45 -05:00
5fd390c600
FIX: nuke spammer from flags page
2014-02-21 14:14:30 -05:00
451598c511
BUGFIX: regresses correct job execution
2014-02-21 16:05:19 +11:00
9a3af8997b
BUGFIX: handle partial job failure in multisite
...
log all failures
2014-02-21 15:31:15 +11:00
2ab76f60d1
FEATURE: Discoruse.handle_exception
...
to report exception via sidekiq helper, adds extra context
2014-02-21 14:30:25 +11:00
d95887c57d
CHANGE: We now include the `_escaped_fragment_` support by default, but
...
only if the crawler check fails. It is a fallback for non-google search
engines that support the Ajax crawling API.
2014-02-20 17:02:26 -05:00
c4b5455c21
REFACTOR: Rename `GooglebotDetection` to `CrawlerDetection` because we
...
will likely whitelist more crawlers in the future.
2014-02-20 16:07:02 -05:00
b8448b6e39
Merge pull request #1982 from velesin/posts_controller_replies_tests
...
Adds tests for PostsController#replies.
2014-02-20 13:36:31 -05:00
b696c96a19
Look at the age of a user's first post to determine if the user can be nuked, instead of looking at when the user registered.
2014-02-20 12:29:40 -05:00
cfbeba84d2
Adds tests for PostsController#replies.
2014-02-20 17:38:13 +01:00
e781a758ad
Preserve spoiler tags in post excerpts.
2014-02-20 15:01:44 +05:30
d443ddd43d
Merge pull request #1922 from joallard/language-toggle
...
Allow users to toggle interface language in their preferences
2014-02-19 18:28:00 +01:00
5e8db5ce14
Adds specs for PostsController#by_number.
2014-02-19 17:41:17 +01:00
2a8734f0d5
Suppress search in topic unless we have more than 10 posts
...
(configurable in site setting)
2014-02-19 08:59:18 +11:00
18e98851e3
Use lower case group names in URLs
2014-02-18 16:43:19 -05:00
43612e9fde
Merge pull request #1971 from velesin/posts_controller_refactoring
...
Refactors PostsController and adds unit tests.
2014-02-19 08:34:40 +11:00
f19b0b5fe0
Include members count on groups page.
2014-02-18 16:17:04 -05:00
997a7c676e
If flagging a topic with only one post, flag the post instead
2014-02-18 15:18:31 -05:00
0592420e52
Add a site setting to allow users to toggle I18n.locale
...
It is false by default.
2014-02-18 14:54:00 -05:00
c513725f26
Allow users to toggle interface language in their preferences
2014-02-18 14:53:59 -05:00
3f3c07f136
FEATURE: Can bulk update the notification level of topics
2014-02-18 13:02:22 -05:00
d0ecccb7e4
Translate asterisks in ip addresses to mask format so people can enter things like 127.*.*.* in screened ip addresses form
2014-02-18 13:00:55 -05:00
5b9a4d3581
Refactors PostsController and adds unit tests.
2014-02-18 17:19:38 +01:00
6c23a1903e
FIX: show ip address with mask again on /admin/logs/screened_ip_addresses
2014-02-18 10:33:08 -05:00
884346cbea
Merge pull request #1951 from thoughtbot/bb-erb
...
Use ERB to pull conf files into app
2014-02-18 16:23:55 +11:00
f12925887c
Drop Rails3 support
2014-02-17 19:42:08 +01:00
77e0096142
Merge pull request #1959 from chris-ramon/patch-1
...
fix typos in posts_controller_spec.
2014-02-17 09:48:04 +01:00
abb2de22ab
BUGFIX: search could break when expanding
2014-02-17 14:34:14 +11:00
2b10fdc97f
FEATURE: search auto scopes on topic first
2014-02-17 13:54:51 +11:00
23af46a66c
Merge pull request #1960 from verg/subcategory-search-links
...
Fix subcategories links from search
2014-02-17 10:33:35 +11:00
f723f11443
Fix subcategories links from search
2014-02-16 12:49:20 -05:00
566d25ea75
fix typos in posts_controller_spec.
...
fixing 'suceeds' typo.
2014-02-16 12:17:36 -05:00
d298e2e065
Detect Googlebot from user agent and use a different layout that doesn't load javascript
2014-02-15 17:54:34 -05:00
60e1a5aa69
Use ERB when importing conf files into app
2014-02-14 16:14:55 -08:00
3f3c9ca7cb
FEATURE: add filters on email logs
2014-02-15 00:50:08 +01:00
2f78dc775d
FIX: double periods. How did that work??
2014-02-14 17:57:38 -05:00
16c6759818
FIX: i18n integrity check was not ignoring comments properly
2014-02-14 14:47:52 -05:00
35dae76bbd
Log when and why an email was not sent in email_logs
2014-02-14 13:06:39 -05:00
b89d328de2
display/preload the logs of the last/current operation
2014-02-13 13:31:14 -08:00
e7472dc374
readonly mode
2014-02-13 13:31:13 -08:00
3be1b5569a
backups controller & specs
2014-02-13 13:31:13 -08:00
8344f0d8fd
remove old import/export code
2014-02-13 13:31:13 -08:00
8711762143
Users who have made no more than one post can delete their own accounts from their user preferences page.
2014-02-13 13:52:06 -05:00
e8aa85d783
FEATURE: unread pms go in front of notification report
...
also refactor fat controller
2014-02-13 17:27:50 +11:00
4ff6780758
Merge pull request #1935 from eriko/remove_cas
...
Remove cas
2014-02-13 17:26:20 +11:00
81a4b4d97e
Merge pull request #1939 from lukemelia/patch-1
...
Fixed typo in test name
2014-02-13 17:15:49 +11:00
f73a3f252a
FIX: Don't allow parent categories to be deleted. Also, remove
...
duplicated logic and rely on the server response for `can_delete`
status.
2014-02-12 17:24:25 -05:00
a963dd9081
Support `embeddable_host` values that contain a HTTP/HTTPs protocol
2014-02-12 15:56:06 -05:00
e4ff06baad
Fixed typo in test name
2014-02-12 15:24:44 -05:00
669247977b
FEATURE: Show the posts count on the groups page. It seems a bit odd
...
that it uses a new AJAX call, but I wanted to keep the count separate
from the group object itself.
2014-02-12 14:01:36 -05:00
318e692290
FIX: If there is an exception when parsing one email, don't stop all
...
work, return an error code and continue.
2014-02-12 12:08:34 -05:00
9ec52d9425
BUGFIX: mailing list mode broke regular email
2014-02-12 16:51:26 +11:00
6fbd73d0eb
include rb_trace to help debugging any hanging specs
2014-02-12 13:33:24 +11:00
71a38542a4
FEATURE: automatic orphan recovery
...
BUGFIX: improve scheduler robustness, in case redis is disconnected during operation
If sidekiq is terminated while task is running, it will be picked up and ran again
New owner on tasks to help debugging
better #stop semantics for tests
2014-02-12 13:33:24 +11:00
557d1886bb
remove what little CAS testing there was.
2014-02-11 17:53:20 -08:00
b035c050d2
Merge pull request #1920 from nickborromeo/list-controller
...
Extract queries to keep logic in the Categories Model
2014-02-11 15:48:20 -05:00
fd34932068
use discourse redis, not redis
2014-02-11 16:11:51 +11:00
4a35d055bc
correct spec to account for category definition topics
2014-02-11 10:50:14 +11:00
ca17f8a437
FIX: Wrong text. Thanks @riking
2014-02-10 17:36:13 -05:00
b61df08d1b
FEATURE: Admin selector to choose a primary group for a user, display it
...
and apply a CSS class to their posts.
2014-02-10 17:00:15 -05:00
b51bebb200
Extract queries to keep logic in the Categories Model
...
This creates two methods in the Category model. This moves the model
logic to the model and just calls the Category class methods in
ListController.
This also adds tests for the two methods created in the Category
model. The motivation for this refactor is the code climate score of the
this class and readability of the code.
Please enter the commit message for your changes. Lines starting
2014-02-08 14:10:48 -08:00
90ae4c6224
Try to fix random failing spec
2014-02-09 07:55:11 +11:00
5f992ae34c
Merge pull request #1913 from davidcelis/default-category-fields
...
Default values for posts/topics fields on Category
2014-02-07 11:27:57 -05:00
2490837929
Added some specs for the group controller methods
2014-02-07 11:07:23 -05:00
cef2d8dc82
BUGFIX: make sure moderators can't view topics they aren't allowed to
2014-02-07 07:08:56 -08:00
e47f462f54
Merge pull request #1916 from vikhyat/pm-dominating
...
Don't notify about dominating private messages
2014-02-07 00:28:27 -08:00
585fae0541
another try fixing this test
2014-02-07 14:38:00 +11:00
93434be16d
SECURITY: reduce moderator rights
...
You can now hide particular categories from certain moderators
2014-02-07 14:11:52 +11:00
2f38316bfc
Don't notify about dominating private messages.
2014-02-07 05:49:45 +05:30
227873df78
FEATURE: proper mailing list mode
...
once enable_mailing_list_mode is enabled any user can elect
to get every post via email unless they opt out of category or topic
2014-02-07 11:07:52 +11:00
e751b8d58f
Default values for posts/topics fields on Category
...
When creating categories (or, at least, subcategories), certain integer
values are set to a default of NULL: topics_week, topics_month,
topics_year, posts_week, posts_month, and posts_year. This causes
consistent exceptions when trying to visit `/categories`, with the
offending line being in
`CategoryDetailedSerializer#count_with_subcategories`. This attempts to
coerce nil into Fixnum.
A fix could be to convert to 0 in the code, but these attributes should
really never be NULL. If there are no posts or topics, they should be 0
to maintain data integrity.
Signed-off-by: David Celis <me@davidcel.is>
2014-02-06 12:04:03 -08:00
e1f293ad66
FEATURE: new scheduler
...
Removed sidetiq, introduced new scheduler
- add basic UI
- add schedule discover
- add scheduling in initializer
2014-02-06 10:26:16 +11:00
aff16f372b
FIX: Show a nicer error when a user tries to access a category they
...
can't see.
2014-02-05 15:33:52 -05:00
1dac3cfd64
API endpoint for retrieving the current user
2014-02-05 13:46:24 -05:00
6acc5c19e7
Use LOAD_PLUGINS=1 instead of LOAD_PLUGINS=true for consistency.
2014-02-05 10:50:28 +05:30
7b46cc0962
Don't clear DiscoursePluginRegistry if LOAD_PLUGINS=true.
2014-02-05 08:05:35 +05:30
659546c4e4
CHANGE: Hide category definition topics unless you are viewing that
...
category.
2014-02-04 15:55:30 -05:00
4fb274fb9d
BUGFIX: history link doesn't work on deleted posts
2014-02-04 20:05:50 +01:00
9601684405
Suggested topics includes closed and archived in new and unread, but not in random results
2014-02-04 12:26:49 -05:00
6c3c9345df
use consistent style
2014-02-04 12:57:52 +11:00
5267e5bea6
BUGFIX: emails sent from "2 replies" as opposed to correct user
2014-02-04 12:56:28 +11:00
d2974c2a15
BUGFIX: proper handling of top_menu_items
2014-02-03 16:08:00 +01:00
d0a6dd88df
FEATURE: exclude muted categories from the latest and new tabs
2014-02-03 16:05:49 +11:00
6205240a56
minor style fix
2014-02-03 14:50:19 +11:00
ae401f0dc7
BUGFIX: JSON requests don't exclude categories from filters
2014-01-31 14:36:00 +01:00
51c06dea03
BUGFIX: hidden posts not absent from context
2014-01-31 16:37:40 +11:00
6f23870327
Bulk close operation
2014-01-30 12:44:40 -05:00
7564d9a20c
Server side implementation for bulk editing categories
2014-01-30 11:44:29 -05:00
b315a5c28f
Delegate bulk operations to a `TopicsBulkAction` object.
2014-01-30 11:44:29 -05:00
ed45a1dce3
FEATURE: new scheduler so we can deprecate sidetiq
...
This is a work in progress, should have it finished tomorrow.
2014-01-30 16:21:38 +11:00
d343e9f360
Add DiscourseLocalOnebox
2014-01-29 14:14:07 -05:00
e453bfa073
Work in progress: Swap out onebox code for onebox gem
2014-01-29 14:14:07 -05:00
2892153712
REMOVE: Get rid of the `hotness` control for good.
2014-01-29 11:54:34 -05:00
cce5fb3303
BUGFIXES: improved performance of import an export
...
we no longer generate the entire dump in memory, instead we generate one table at a time
added some basic progress
2014-01-29 16:49:01 +11:00
74f1c553e3
FIX: 1868 Security: Dangerous Send
2014-01-27 13:05:51 -05:00
7cc5da08fe
Track how many posts a user reads each day in user_visits
2014-01-27 11:20:19 -05:00
748e1e0748
Allow using the API when Login required site setting is on.
2014-01-24 14:02:49 +01:00
245bc19379
BUGFIX: PMs could be created with a category
...
BUGFIX: hide category column when displaying the list of private messages
2014-01-24 12:57:48 +01:00
bfc9664231
BUGFIX: site_contact_username was case-sensitive
2014-01-23 11:26:31 +01:00
7e5a17f277
FEATURE: mute/watch/track buttons for private conversations
2014-01-22 17:46:52 +11:00
da825451d0
Invite link can't be used to log in after you set a password or sign in with 3rd party
2014-01-21 16:56:41 -05:00
1dbc1c56b4
FIX: inviting a user again after the first invite expires will create a new invite
2014-01-21 16:56:40 -05:00
963793549c
FIX: Remove failing ruby tests. The same thing is tested in JS and
...
passes due to the ability to create a document fragment.
2014-01-20 15:28:46 -05:00
b85e5dc191
FEATURE: collapse PM notifications
2014-01-20 16:18:43 +11:00
8d2e5041bc
BUGFIX: proper handling of /none subcategory
2014-01-18 19:27:25 +01:00
4981525047
REFACTOR: Fixes poor class hierarchy for listing topics
...
- Upgrades Ember to latest
- Fixes a bunch of bugs with page titles and missing "active" states
2014-01-18 19:26:24 +01:00
5fa464e10b
force_encoding according to the charset in mail, this solve encoding problem when not using ‘utf-8’ charset.
2014-01-19 02:12:38 +08:00
8c29ed870e
Non-staff users may not delete their posts in archived topics.
2014-01-17 17:42:12 -05:00
1806a7d4b3
Trust Level 3: invited users start at default_invitee_trust_level + 1, unless default_invitee_trust_level is 2 or higher
2014-01-17 11:12:00 -05:00
7c8ea8c166
Trust level 3 users can edit topic titles and change category
2014-01-16 11:59:26 -05:00
89908cdb47
Admins don't see uncategorized on /categories if it has no topics and allow_uncategorized_topics is false
2014-01-15 14:11:36 -05:00
4f6b208e8d
Posts by trust level 3 users do not have nofollow on their external links.
2014-01-15 11:40:51 -05:00
ad8755aa70
BUGFIX: inline spoiler for text, block spoiler for images
2014-01-15 00:53:06 +01:00
b024bebbe2
BUGFIX: emoji's url were relatives (was breaking the wordpress plugin)
2014-01-14 23:51:36 +01:00
4f6283ba56
FIX: Accept HTTPS or HTTP urls on redirect
2014-01-14 15:02:05 -05:00
e7a05c54e8
FIX: suggested topics sometimes adds new topics from other categories before new topics of the current category
2014-01-13 15:02:15 -05:00
2b64118df1
Merge pull request #1782 from ligthyear/group-mention
...
Allow groups to be used as aliases for user mentions
2014-01-12 14:36:45 -08:00
70161498b6
BUGFIX: spoiler tag on lightboxed images wasn't working
2014-01-12 19:38:46 +01:00
52580f09af
Rename favorite to starred everywhere
2014-01-10 14:54:19 -05:00
ca26d6d0d6
FIX: Uncaught promise on link click; fixes broken build
2014-01-09 16:31:26 -05:00
259295d865
Add post_edit_time_limit site setting to limit the how long a post can be edited and deleted by the author. Default is 1 year.
2014-01-09 11:55:04 -05:00
74c1555885
BUGFIX: fix broken spec
2014-01-09 15:11:04 +11:00
1533a1163c
use_ssl is just confusing, it means use_https , fix name of setting
2014-01-09 10:51:38 +11:00
e732aa8a86
BUGFIX: we should not store absolute urls for locally uploaded avatar templates
...
Highly recommended to run: `RAILS_ENV=production bundle exec rake avatars:regenerate` to fix the avatar templates stored in the database.
2014-01-07 17:45:06 +01:00
c743a985a4
Allow groups to be used as aliases for user mention
...
when configured by the admin a group can be found through the @mentions
feature in both the compose/reply and the private message user-selectors
and once selected the mention will be replaced by the list of users in
the group
2014-01-08 02:36:24 +11:00
660d87a108
BUGFIX: cache did not support non strings
...
also reduced mocking in tests
2014-01-07 17:36:47 +11:00
6e2797112d
Attempt to fix spec under vagrant
2014-01-07 09:26:30 +11:00
8d73b7f94d
BUGFIX: hide sensitive site settings
2014-01-06 13:03:53 +01:00
6befdceabf
BUGFIX: UserStat spec was over ambitious with its mocking
2014-01-06 16:50:55 +11:00
b703d8c77a
BUGFIX: redis-rails has always been a problem child
...
implemented an ActiveSupport::Cache::Store for our internal use.
* allows for expire by family
* works correctly in multisite
* namespaced correctly
Removed redis-rails from the project, no longer needed
2014-01-06 16:50:04 +11:00
7b7d6f3fa7
Merge pull request #1464 from GarantiaData/single_redis_db
...
Support single redis DB.
2014-01-05 16:30:41 -08:00
1ffcf39448
Make embedded comments look nicer
2014-01-03 12:52:42 -05:00
f145060315
Don't employ the "too many replies" if the user is staff, or if they created the topic.
...
See: http://meta.discourse.org/t/what-is-the-point-of-limiting-new-users-to-three-replies-per-topic/11696
2014-01-02 12:57:40 -05:00
2da5d2311b
FEATURE: Added UI for adding and removing watched and muted categories
2014-01-02 17:59:08 +11:00
b482b280d6
FEATURE: Basic backend support for muted and watched categories
2014-01-02 12:00:29 +11:00
126433cf65
Merge pull request #1744 from verg/prevent_delete_uncategorized
...
Prevent deleting 'uncategorized' category
2014-01-01 16:09:49 -08:00
2ad190b9f6
FEATURE: allow for additional plugin defined global settings
2014-01-02 10:46:09 +11:00
4f8aed295a
FEATURE: Embeddable Discourse comments, now with simple-rss instead of feedzirra
2013-12-31 15:01:22 -05:00
62db063e1e
Revert "Support for Embeddable Comments via IFRAME" - it depends on Curl
...
which not every server has. Have to rethink this.
This reverts commit e3e4c62887
2013-12-31 12:52:31 -05:00
e3e4c62887
Support for Embeddable Comments via IFRAME
2013-12-31 12:26:24 -05:00
8a830fb8e3
Prevent deleting 'uncategorized' category
2013-12-31 11:22:44 -06:00
c6577fb98e
Added a reload to fix a test broken on master
...
I am not sure why this is wokring on Rails 4, but the problem is that `post3`
here is holding on to an old reference of some associations so `PostDestroyer`
is not doing the right thing.
2013-12-30 14:36:51 -08:00
47e1d00f96
Check that common passwords list is greater than 0
2013-12-30 14:26:02 -05:00
1915f292ad
BUGFIX: invalid referer would cause 500 errors
2013-12-30 14:05:44 +11:00
db1d01d1a2
Discourse as a Mailing List improvements
...
FEATURE: context is not emailed if we previously emailed you the post
FEATURE: site setting to enable_watch_new_topics , false by default.
When enables users can elect to watch everything by default
FIX: Custom email subjects (x quoted you in [title], x replied to [title])
was removed, this broke email grouping. TBD, include info in footer somehow
FIX: topic user specs were messy, reduce side effects
2013-12-30 13:02:12 +11:00
293b7e5857
add spec to demo blanking props
2013-12-30 08:42:55 +11:00
2c19d8a136
Fix password_validator_spec
2013-12-27 11:15:53 -05:00
ab12695d63
Block passwords that are in the top 5000 most common passwords. Site setting block_common_passwords can disable this feature.
2013-12-27 11:00:21 -05:00
567d2bd23c
add top page
2013-12-24 00:50:36 +01:00
0c45eba037
FIX: Users can edit posts when they've reached the `newuser_max_replies_per_topic` threshold.
2013-12-20 11:30:51 -05:00
f5f09933df
Merge branch 'master' of github.com:discourse/discourse
2013-12-20 16:17:52 +11:00
7b8d2547d0
globals now implemented and documented
2013-12-20 16:17:21 +11:00
854d9c8fc6
Minimum password length is configurable with the min_password_length site setting. FIX: reset password needs to validate password length.
2013-12-19 16:15:47 -05:00
33c6997ded
Move password validation into PasswordValidator
2013-12-19 16:15:47 -05:00
1cac9fa257
New users can only post `newuser_max_replies_per_topic` times per topic.
2013-12-19 13:45:55 -05:00
c35af5d755
FIX: When re-opening a topic that auto-closed, make sure it won't auto-close again
2013-12-19 11:25:05 -05:00
1f0a59584b
Revert "Re-apply with fixes: Stop using user agent to detect mobile devices. Use a media query and yepnope to load the appropriate css and customizations."
2013-12-18 14:47:22 -05:00
3cc634d37b
FIX: category_list_spec should not expect deterministic order
2013-12-17 12:53:29 -05:00
ea307931a7
fix spec, categories without position are now always at the end of the list
2013-12-17 14:36:07 +11:00
2ce75a8523
FIX: canonical url should not use the CDN
2013-12-17 00:35:34 +01:00
341adc93a4
Allow categories with null position, which means sort them based on activity. Mix absolutely positioned (position is not null) categories with null position categories.
2013-12-16 15:13:57 -05:00
acf262b631
Support for "no subcategories"
2013-12-16 13:06:35 -05:00
ccd0f9c371
add onpdiff tests
2013-12-16 18:39:49 +01:00
206ef3dc08
add discourse_diff tests
2013-12-16 18:11:46 +01:00
c6fb60e0a0
FIX: S3 upload when using dots in bucket name
2013-12-16 11:44:59 +01:00
d93e4fc65d
add more info to rss feeds
2013-12-15 01:17:39 -08:00
49c3482464
Show topic and post counts by day/week/month/year on categories page
2013-12-13 15:37:45 -05:00
06e9cbc6cb
FIX: Look up a url without the query string if it couldn't be found with it.
2013-12-13 12:56:20 -05:00
05a3c8090f
Merge pull request #1658 from salbertson/sa-refactor-users-controller-create
...
Refactor UsersController#create
2013-12-12 22:16:50 -08:00
1884bd959f
make sure extension-based oneboxes are first to run
2013-12-13 00:56:48 +01:00
1457a3792d
that fix should have been in the emoji plugin
2013-12-12 16:42:27 +01:00
be835785f8
FIX: allow new user to post emojis
2013-12-12 15:05:18 +01:00
06dd7ffe3c
better revision history
2013-12-12 03:41:34 +01:00
5171a23a9c
Re-apply with fixes: Stop using user agent to detect mobile devices. Use a media query and yepnope to load the appropriate css and customizations.
2013-12-11 11:19:22 -05:00
ed3d3ae1e1
Upgrade font-awesome to version 4
2013-12-11 10:31:09 -05:00
6853f37bee
Show estimated reading time near summarize button.
2013-12-10 13:47:36 -05:00
561961eff6
FIX: can grant titles to regular users. Guardian initializer needs current_user, not the target user.
2013-12-10 12:46:35 -05:00
2596f7dec2
Revert "Stop using user agent to detect mobile devices. Use a media query and yepnope to load the appropriate css and customizations."
2013-12-09 16:28:11 -05:00
ca5d4d5e54
Stop using user agent to detect mobile devices. Use a media query and yepnope to load the appropriate css and customizations.
2013-12-09 13:28:42 -05:00
9a24d2651d
Allow category to auto-close topics in X hours instead of days. FIX: the system message that says a topic was automatically closed was only counting in days.
2013-12-06 16:39:35 -05:00
79427732b2
Show Gaps in the post stream when filters are active
...
Conflicts:
app/assets/javascripts/discourse/templates/topic.js.handlebars
2013-12-05 16:46:59 -05:00
51eff92170
Refactor UsersController#create
...
* Simplify controller action
* Extract service classes
2013-12-05 10:11:16 -08:00
abed146cc7
FIX: Category description topics shouldn't auto-close
2013-12-04 10:31:25 -05:00
9584ecb295
fixing gender sensitive pronouns
2013-12-03 10:19:54 +05:30
5150376e12
add wrapper class for lightboxes
2013-12-02 10:06:48 +01:00
1a2114d87d
Don't abuse as_json, it's not meant for consumption
...
The `as_json` API is a hook for JSON encoders to call, not meant for
consumption like this, and the result is not guarenteed to be stable
across Rails versions.
There might be other cases like this that we should revisit later, but
this one in particular is causing a test to fail on Rails master.
2013-11-29 21:58:09 -08:00
298b54c0e7
add download link in lightbox
2013-11-29 20:03:39 +01:00
8c8645f158
FIX: Code and Emoticon formatting in HTML emails.
2013-11-28 17:21:14 -05:00
4ec0543362
FIX: emails with embedded posts should always use absolute URLs
2013-11-28 15:57:21 -05:00
1cc72d564f
Add specs for topic create with auto_close_time. Just ignore auto_close_time from users who are not authorized to use it instead of raising an error.
2013-11-28 11:06:04 -05:00
52160179f8
add a tombstone for extra safety
2013-11-27 22:05:11 +01:00
a9ab98ef9e
Auto-close time can be entered in 3 ways, so a topic can close at any time
2013-11-27 09:52:35 -05:00
6b6c3d05dd
FIX stretched thumbnails
2013-11-25 18:36:13 +01:00
d208be14d2
FIX: Ruby 1.9.3 UTF-8 bug
2013-11-25 11:29:58 -05:00
82b78ec6ba
schemaless avatar urls
2013-11-22 19:18:45 +01:00
3cf5a363f7
do not destroy uploads when destroying a user
2013-11-22 18:29:07 +01:00
49b48e1eb6
ensure we have a bigint id
2013-11-22 17:51:36 +11:00
f65cde3cda
do not bump posts when rebaking
2013-11-22 01:52:26 +01:00
bcfbacec16
Don't show category descriptions as suggested topics
2013-11-21 16:43:22 -05:00
69cc1dd689
FIX: don't suggest a username that's already taken, even if hub finds a match
2013-11-20 14:56:21 -05:00
5055da76e6
Abort triggers for email body processing
2013-11-20 13:30:01 -05:00
31fd5b85bc
FIX markdown hotlinked images were not properly pulled
2013-11-20 13:10:08 +01:00
981d8f6aea
Signup form: prefill username if Discourse Hub has a match for the email address. Also, fix some bad specs in username_checker_service_spec that were passing...
2013-11-19 14:15:28 -05:00
ae58a7db95
Add a warning on dashboard if enforce_global_nicknames is checked, but access key is blank.
2013-11-18 13:45:10 -05:00
4ce81e1b01
Rename "Best Of" to "Summary"
2013-11-18 12:48:26 -05:00
ad3e276b4b
Rename TopicSummary -> TopicMap
2013-11-18 12:08:21 -05:00
639394e38a
FIX: Pinned topics within a category weren't working without a refresh
2013-11-18 10:52:01 -05:00
482b752046
add edit reason when editing a post
2013-11-15 23:28:49 +01:00
fc180ccd71
Site settings: move category into the opts hash so that it's compatibale with existing plugins
2013-11-15 14:32:33 -05:00
34bba737ff
Refactor SessionController#create, reduce complexity.
...
Don't compromise readablity
2013-11-15 22:09:03 +05:30
8a83f1a88f
add disk space usage failsafe
2013-11-15 16:48:38 +01:00
e03ae73c5d
Merge pull request #1653 from ScotterC/uri-addressable
...
URI adapter should use Addressable
2013-11-15 07:24:57 -08:00
16267e4887
add download_remote_images_to_local site setting
2013-11-15 15:22:18 +01:00
1e37abc310
Add site setting category support
2013-11-14 16:02:13 -05:00
791f5ac94e
Load site settings from config/site_settings.yml
2013-11-14 16:02:13 -05:00
968c0672ef
Enable column sorting main topic list
2013-11-14 15:50:36 -05:00
67041d1c6d
Support for tracking the count of unique participants in a topic
2013-11-14 14:32:41 -05:00
32e414690a
Handle ugly url targets
2013-11-14 13:14:02 -05:00
bda5a72c6a
Server side support for custom ordering of topics
2013-11-13 14:17:06 -05:00
7207cef7aa
TopicQuery cleanup in advance of custom sorting:
...
- Move SQL method constants into a module
- Removed unused count methods
- Moved methods that don't return a TopicList into Topic
- Replaced some confusing method signatures
2013-11-13 12:26:32 -05:00
77b59b54ce
Refactor UsersController#invited
...
* Add test coverage
* Simplify controller action
* Move finder code to Invite class
2013-11-11 13:23:49 -08:00
2f8866add5
Change admin display-row css so that multiple lines can fit in the control column. Don't hard-code a height on the rows.
2013-11-11 15:03:17 -05:00
d65cd0f97e
Merge pull request #1637 from railsaholic/refactor_users_upload_avatar_action
...
Refactor Users#upload_avatar method
2013-11-11 09:59:30 -08:00
58f78e9001
Refactor Users#upload_avatar method
...
Moved avatar file upload to ```AvatarUploadService``` class and
```AvatarUploadPolicy```
Address review comments + require missing file in spec
2013-11-11 23:21:14 +05:30
d1d661f6e1
add logic that auto closes any topics that missed the queued job (due to redis flush or whatever)
2013-11-11 10:52:44 +11:00
a9c5d843f7
remove problem spec that does not work properly in rails 4 mode into application controller and correct it
2013-11-11 10:50:48 +11:00
af67284995
User ctrl refactor - breaks up large methods, moves some logic into model
...
Includes missing methods from backup for travis to pass
fix missing code, failing specs
keep params handling in the controller.
2013-11-09 18:44:13 +05:30
6e43372e7c
Merge pull request #1610 from salbertson/sa-refactor-users-update
...
Move logic for updating a user to a service class
2013-11-07 12:29:19 -08:00
0c6f794eb0
Used the term suspended instead of banned.
2013-11-07 13:53:49 -05:00
72bfa4471f
Move logic for updating a user into a service class
2013-11-07 08:39:39 -08:00
948a545cb1
Category descriptions should not appear in digests
2013-11-06 15:05:06 -05:00
de30af9302
Support for inviting to a forum from a user's invite page.
2013-11-06 12:56:50 -05:00
8d47215ea5
Fixed Youtube videos appearing on top of compose panel (props to @hrobertson)
2013-11-06 17:19:02 +01:00
f8e2ecfa94
keep track of the user who revised a post
2013-11-06 11:43:40 +01:00
3992aa971d
ninja_edit_window is is seconds, not minutes
2013-11-06 11:08:57 +01:00
25ef66c60b
User invites page now has search, displays first `invites_shown` records
2013-11-05 17:53:26 -05:00
37fd7ab574
pull hotlinked images
2013-11-05 19:07:29 +01:00
415d4df648
work around bust encodings passed in to method
2013-11-05 13:40:39 +11:00
bd9b85f076
Screened Urls page shows results for each domain instead of each url
2013-11-04 16:24:48 -05:00
c86b06e3fa
Fix for non-english email polling.
2013-11-04 15:30:24 -05:00
ede59a4386
FIX: issue 1538. After upgrading and before a new version check request has been made, dashboard might still say that an update is available.
2013-11-04 12:51:09 -05:00
b474babe26
Merge pull request #1602 from salbertson/sa-refactor-users-update-specs
...
Refactor specs for UsersController#update
2013-11-04 07:16:18 -08:00
895d801669
Dont call `SiteSetting.uncategorized_category_id` twice
2013-11-03 15:36:59 +05:30
b56b11d96a
add qunit to autospec
2013-11-01 23:57:50 +01:00
Robin Ward
Sam
Vikhyat Korrapati
Régis Hanol
Neil Lalonde
riking
Aslak Knutsen
Jorge Manrubia
Thomas Cioppettini
Benjamin Kampmann
Forest Carlisle
Douglas Browne
Johan Jatko
Stephen Birarda
Erik Ordway
Wojciech Zawistowski
Jonathan Allard
Stephan Kaag
verg
Christian Ramón
Britt Ballard
Luke Melia
Nick Borromeo
David Celis
slainer68
Herb Jiang
Godfrey Chan
Alexander
Scott Albertson
Jithu Gopal
railsaholic
Scott Carleton
sirMackk
Vipul A M