discourse

Commit Graph

Author	SHA1	Message	Date
David Taylor	c9dab6fd08	DEV: Automatically require 'rails_helper' in all specs (#16077 ) It's very easy to forget to add `require 'rails_helper'` at the top of every core/plugin spec file, and omissions can cause some very confusing/sporadic errors. By setting this flag in `.rspec`, we can remove the need for `require 'rails_helper'` entirely.	2022-03-01 17:50:50 +00:00
Jarek Radosz	0fe9a36e89	DEV: Fix another flaky spec The error was: ``` 1) ExtraLocalesController.client_overrides_exist? returns true if there are client-side translation overrides Failure/Error: expect(ExtraLocalesController.client_overrides_exist?).to eq(false) expected: false got: true (compared using ==) Diff: @@ -1 +1 @@ -false +true # ./spec/requests/extra_locales_controller_spec.rb:162:in `block (3 levels) in <main>' # ./spec/rails_helper.rb:279:in `block (2 levels) in <top (required)>' # .gem/ruby/2.7.3/gems/webmock-3.13.0/lib/webmock/rspec.rb:37:in `block (2 levels) in <top (required)>' ``` Minimal repro: ``` bin/rspec './spec/models/trust_level_and_staff_setting_spec.rb[1:1:1]' './spec/requests/extra_locales_controller_spec.rb[1:3:2]' --tag ~type:multisite --seed 33616 ```	2021-06-08 09:54:37 +08:00
Gerhard Schlager	41ee5b7c86	FIX: Don't store translated trust level names in anonymous cache (#13224 ) Refactors `TrustLevel` and moves translations from server to client Additional changes: * "staff" and "admin" wasn't translatable in site settings * it replaces a concatenated string with a translation * uses translation for trust levels in users_by_trust_level report * adds a DB migration to rename keys of translation overrides affected by this commit	2021-06-01 22:11:48 +02:00

Author

SHA1

Message

Date

David Taylor

c9dab6fd08

DEV: Automatically require 'rails_helper' in all specs (#16077 )

It's very easy to forget to add `require 'rails_helper'` at the top of every core/plugin spec file, and omissions can cause some very confusing/sporadic errors.

By setting this flag in `.rspec`, we can remove the need for `require 'rails_helper'` entirely.

2022-03-01 17:50:50 +00:00

Jarek Radosz

0fe9a36e89

DEV: Fix another flaky spec

The error was:

```
  1) ExtraLocalesController.client_overrides_exist? returns true if there are client-side translation overrides
     Failure/Error: expect(ExtraLocalesController.client_overrides_exist?).to eq(false)

       expected: false
            got: true

       (compared using ==)

       Diff:
       @@ -1 +1 @@
       -false
       +true

     # ./spec/requests/extra_locales_controller_spec.rb:162:in `block (3 levels) in <main>'
     # ./spec/rails_helper.rb:279:in `block (2 levels) in <top (required)>'
     # .gem/ruby/2.7.3/gems/webmock-3.13.0/lib/webmock/rspec.rb:37:in `block (2 levels) in <top (required)>'
```

Minimal repro:

```
bin/rspec './spec/models/trust_level_and_staff_setting_spec.rb[1:1:1]' './spec/requests/extra_locales_controller_spec.rb[1:3:2]' --tag ~type:multisite --seed 33616
```

2021-06-08 09:54:37 +08:00

Gerhard Schlager

41ee5b7c86

FIX: Don't store translated trust level names in anonymous cache (#13224 )

Refactors `TrustLevel` and moves translations from server to client

Additional changes:
  * "staff" and "admin" wasn't translatable in site settings
  * it replaces a concatenated string with a translation
  * uses translation for trust levels in users_by_trust_level report
  * adds a DB migration to rename keys of translation overrides affected by this commit

2021-06-01 22:11:48 +02:00

3 Commits