f683c5d0e0
DEV: Check English locale for errors in CI
...
Moves the most important checks into a linter. It gets executed by Lefthook as well as the docker rake task and Github actions. Doing those checks in rspec takes too long and it produces errors when the discourse:test Docker image contains old, invalid locale files.
2020-06-03 21:54:58 +02:00
fc640f31df
DEV: Skip interpolation key specs until build scripts can be fixed
...
Currently the build fails because it runs the specs for all plugins even though the current source of those plugins isn't pulled from git.
2020-06-02 19:51:47 +02:00
0cf297725f
DEV: Use consistent interpolation key format in translations
...
From now on client strings can easily be reused on the server and you don’t have to think about choosing the right format anymore.
2020-06-02 19:05:10 +02:00
0afcad148a
DEV: Always use %{count} in pluralized strings
2019-05-20 23:26:22 +02:00
b788948985
FEATURE: English locale with international date formats
...
Makes en_US the new default locale
2019-05-20 13:47:20 +02:00
4ea21fa2d0
DEV: use #frozen_string_literal: true on all spec
...
This change both speeds up specs (less strings to allocate) and helps catch
cases where methods in Discourse are mutating inputs.
Overall we will be migrating everything to use #frozen_string_literal: true
it will take a while, but this is the first and safest move in this direction
2019-04-30 10:27:42 +10:00
24e5be3f0c
FIX: Relative links in translations should work with subfolder
2018-11-08 23:31:05 +00:00
5012d46cbd
Add rubocop to our build. ( #5004 )
2017-07-28 10:20:09 +09:00
b9fbc95ef4
Add spec to notify us when translations have invalid interpolation keys.
2017-06-19 12:39:30 +09:00
ecdae9f863
FIX: i18n integrity specs
...
FIX: check all .yml files in the project for integrity
FIX: ensure localized yamls are compatible with english
2017-02-24 11:35:33 +01:00
c94e6f1b96
Add locale step
2016-09-22 09:52:19 -04:00
3a4615c205
Wizard: Step 1
2016-09-22 09:48:58 -04:00
2005565c9c
Server side code for Watching First Post Only
2016-07-07 11:21:50 -04:00
64df98e348
Adds integrity check for badge descriptions
2016-04-12 12:55:49 -04:00
a764cc3a42
FEATURE: by default users track a group (as opposed to watch)
...
FEATURE: a rollup counting number of messages in the group inbox to tracking users
2016-01-27 21:38:33 +11:00
3e50313fdc
Prepare for separation of RSpec helper files
...
Since rspec-rails 3, the default installation creates two helper files:
* `spec_helper.rb`
* `rails_helper.rb`
`spec_helper.rb` is intended as a way of running specs that do not
require Rails, whereas `rails_helper.rb` loads Rails (as Discourse's
current `spec_helper.rb` does).
For more information:
https://www.relishapp.com/rspec/rspec-rails/docs/upgrade#default-helper-files
In this commit, I've simply replaced all instances of `spec_helper` with
`rails_helper`, and renamed the original `spec_helper.rb`.
This brings the Discourse project closer to the standard usage of RSpec
in a Rails app.
At present, every spec relies on loading Rails, but there are likely
many that don't need to. In a future pull request, I hope to introduce a
separate, minimal `spec_helper.rb` which can be used in tests which
don't rely on Rails.
2015-12-01 20:39:42 +00:00
5f9b7c67cd
Add tests to ensure correct pluralization
2015-11-13 21:18:41 +01:00
49dc470a28
Add spec to check locale files for duplicate keys
2015-09-19 00:14:26 +02:00
ad12db3fb3
correct invalid spec
2015-06-15 16:34:35 +10:00
b8cbe51026
Convert specs to RSpec 2.99.2 syntax with Transpec
...
This conversion is done by Transpec 3.1.0 with the following command:
transpec
* 424 conversions
from: obj.should
to: expect(obj).to
* 325 conversions
from: == expected
to: eq(expected)
* 38 conversions
from: obj.should_not
to: expect(obj).not_to
* 15 conversions
from: =~ /pattern/
to: match(/pattern/)
* 9 conversions
from: it { should ... }
to: it { is_expected.to ... }
* 5 conversions
from: lambda { }.should_not
to: expect { }.not_to
* 4 conversions
from: lambda { }.should
to: expect { }.to
* 2 conversions
from: -> { }.should
to: expect { }.to
* 2 conversions
from: -> { }.should_not
to: expect { }.not_to
* 1 conversion
from: === expected
to: be === expected
* 1 conversion
from: =~ [1, 2]
to: match_array([1, 2])
For more details: https://github.com/yujinakayama/transpec#supported-conversions
2015-04-25 11:18:35 -04:00
9fbc763902
Replace Hash#keys.each with Hash#each_key for some perf boost
2015-04-18 21:53:53 +10:00
2f78dc775d
FIX: double periods. How did that work??
2014-02-14 17:57:38 -05:00
16c6759818
FIX: i18n integrity check was not ignoring comments properly
2014-02-14 14:47:52 -05:00
c98d58378c
prevent double work in the i18n integrity specs
2013-03-23 15:49:31 +01:00
624649ddc2
adding i18n integrity check for valid YAML and valid content
2013-03-23 08:57:31 +01:00
3d4fb43c73
Re-enable integrity check
2013-03-22 12:49:46 -04:00
8b6dbfc1c6
Make spec pending for now -- jenkins does not like it
2013-03-20 18:10:52 -04:00
6dab9927c6
ensure locales are not overwritten
2013-03-20 10:51:28 +01:00
bfeb75a60f
Revert "ensure locales are not overwritten"
...
breaking now
2013-03-19 21:23:03 -07:00
e61ca1f67f
ensure locales are not overwritten
2013-03-20 03:07:45 +01:00
0c99dea153
introduce Enum
2013-03-01 21:16:36 +03:00
cafc75b238
remove trailing whitespaces ❤️
2013-02-26 07:31:35 +03:00
21b5628528
Initial release of Discourse
2013-02-05 14:16:51 -05:00
Gerhard Schlager
Sam Saffron
Guo Xiang Tan
Guo Xiang Tan
Régis Hanol
Robin Ward
Andy Waite
Arthur Neves
Tan Le
Kuba Brecka
Gosha Arinich