0a5a6dfded
DEV: stop mutating inputs as a side effect
...
We had quite a few cases in core where inputs are being mutated as a side
effect of calling a method.
This handles all the cases where specs caught this.
Mutating inputs makes code harder to reason about. Eg:
```
frog = "frog"
jump(frog)
puts frog
"fly" # ?????
```
This commit is part of a followup commit that adds # frozen_string_literal
to all our specs.
2019-04-30 10:25:53 +10:00
3d9981ac5c
FIX: strip invalid byte sequences
2019-02-26 10:09:51 +01:00
eacbe28f55
FIX: Skip gsub for normalizing whitespaces when text is nil ( #6631 )
2018-11-20 09:12:32 +01:00
4881fb028f
FIX: allow_uppercase_posts didn't work for topic titles
2018-10-08 23:50:06 +02:00
a4bc54a686
FIX: strip zero width spaces from topic title
2018-02-21 00:12:39 +05:30
5324c9817f
FIX: Title prettify shoundn't downcase all non-ascii titles
2017-08-08 14:03:24 -03:00
fd87f59bbb
Test for existing title
2016-03-21 23:06:39 -03:00
adae5d78f5
Rewrite capitalize for readability
...
Makes capitalize logic more clear with @sam suggestion
2016-03-20 08:35:48 -04:00
decb744c76
Fix capitalize
2016-03-10 00:44:44 -03:00
3e6ae45a93
Handle Capitalize too
...
Handles capitalize too, using the same lib
2016-03-07 22:09:30 -03:00
71b026bc01
FIX: Properly downcase unicode chars
...
Fix to https://meta.discourse.org/t/title-prettify-does-not-correctly-lowercase-non-english-characters-when-removing-all-caps/16645
This adds a dependency on Active Support Multibyte to downcase on other languages.
2016-03-07 17:07:36 -03:00
58c95f64d2
FIX: stop stripping zero-width-whitespace
...
This char is used for formatting khmer words
2015-03-27 13:03:24 +11:00
f4208ae83f
FEATURE: normalize whitespaces in topic title/post content
2014-08-12 00:01:58 +02:00
8bc4264c98
Thread title fixer should ignore special cases like iLetter
2013-05-23 21:31:08 +02:00
e76f629df8
Text Cleaner now removes all periods from the end of the title
2013-04-18 00:19:42 +02:00
c5cf8be864
auto replace rules in titles
2013-04-10 11:00:50 +02:00
Sam Saffron
Maja Komel
Rishabh
Gerhard Schlager
Arpit Jalan
Rafael dos Santos Silva
Régis Hanol
Konrad Borowski