f772ecc597
DEV: Correct missing output detailing failure
...
uploads:s3_migration_status was failing but not returning proper output
2019-05-22 12:58:54 +10:00
5429c9b5e9
DEV: Fix incorrectly hardcoded value in rake task.
2019-05-22 09:01:25 +08:00
a9af77d650
PERF: ensure priority for rake rebake tasks is ultra low
...
Flooding the default queue with lots of jobs is never a good thing. This
reduces the risk of sidekiq going into a bad state post rebake
2019-05-22 10:31:49 +10:00
d6daa60d0a
FEATURE: multisite support for posts:rebake_uncooked_posts
2019-05-22 10:04:54 +10:00
a2428bd862
FEATURE: warn about sidekiq overload prior to migrating
...
Also makes pre-flight check ensure there is no giant backlog of posts that
need to be cooked
2019-05-22 10:04:33 +10:00
5fdc7b7ca2
Correct 59012fc0
...
Logic was flipped here by mistake, oops
2019-05-22 09:48:03 +10:00
73f178a634
FEATURE: posts:rebake_uncooked_posts to look at mismatching baked_version
...
also amends flagging onebox updates to set baked_version to nil
2019-05-22 09:43:31 +10:00
4f296608da
FEATURE: add uploads:s3_migration_status for looking at current status
...
Also a few minor cleanups and better progress reporting
2019-05-22 09:00:32 +10:00
59012fc0f7
PERF: mark posts for rebake vs forcing a rebake inline when migrating to s3
...
Rebaking posts can be expensive instead of blocking here simply mark posts
for rebake.
We can then work through them faster in other jobs, plus this should not
hold of a datacenter migration.
2019-05-22 08:39:25 +10:00
338b927f95
DEV: include local uploads while finding missing uploads
...
in rake task 'posts:missing_uploads'
2019-05-21 22:07:08 +05:30
7b82850f66
FIX: migrate_to_s3 task should remap attachment links too.
2019-05-21 21:58:11 +05:30
8360415453
FEATURE: big warning for uploads missing which can be very very slow on S3
2019-05-21 16:11:56 +10:00
cb86d8279a
FEATURE: add toggle for uploads:missing so it can skip external
...
Validating s3 uploads in uploads:missing can be very expensive, allow to
bypass.
2019-05-21 16:11:56 +10:00
f4d4f7871e
FEATURE: make posts:missing_uploads multisite friendly
...
Previously this rake job would only run on a single site which is a bit
misleading
This also adds `VERBOSE=1 rake posts:missing_uploads` that will provide a
full report of missing uploads
2019-05-21 12:45:51 +10:00
0f76e3090c
FIX: use tar -xzvf to extract maxmind vs Ruby wrappers
...
The tar/gz extractor in Ruby is somewhat buggy, instead rely on battle
tested `tar` and `gzip` Linux commands
2019-05-21 10:48:18 +10:00
2941c77abc
FIX: skip upload recovery if file not found in s3
2019-05-21 00:06:36 +05:30
0fbff66d97
DEV: Correct rake task syntax error
2019-05-20 17:43:30 +01:00
31902159af
DEV: Allow skipping failed migrations when running S3 migration
...
Use the SKIP_FAILED environment variable to skip failed sites. Use with caution - make sure you go back and re-run the failed migrations afterwards.
2019-05-20 17:25:56 +01:00
a15cca9a0f
DEV: Improve error message for posts:missing_uploads during S3 migration
2019-05-20 16:09:22 +01:00
2bfc0cf145
FIX: skip old scheme upload URLs while validating s3 uploads remap
2019-05-20 19:13:41 +05:30
9f43852609
FIX: remove the unwanted code.
2019-05-20 19:10:21 +05:30
41bc90dd3e
DEV: Add progress indicator for post rebake during s3 migration
...
Now that we run sidekiq jobs synchronously, this is important
2019-05-20 14:19:58 +01:00
77a06209cb
DEV: Skip S3 migration if all uploads are already migrated
...
This makes the task resumable in a multisite context
2019-05-20 14:17:37 +01:00
b788948985
FEATURE: English locale with international date formats
...
Makes en_US the new default locale
2019-05-20 13:47:20 +02:00
bc0c4b7253
FIX: should not migrate the system uploads to s3
2019-05-20 14:27:34 +05:30
be3fb85a04
DEV: add post migration checks and raise error if failed.
2019-05-20 14:18:28 +05:30
50e6ee55a9
DEV: add "WAIT_FOR_URL" env to smoke test
...
This allows you to wait up to N seconds for the smoke test url to come up
in some cases you want to kick off the smoke test prior to having the smoke
test env ready to accept connections
2019-05-20 17:23:09 +10:00
08371db0cc
FIX: ensure we don't queue any jobs during s3 migration
...
Previously we could flood sidekiq with jobs which is not ideal.
This ensures we are 100% done when the job is done.
2019-05-20 16:28:50 +10:00
2a7065c505
FIX: skip uploads without etag in s3 inventory check.
2019-05-20 00:09:52 +05:30
7696b92c8c
FIX: handle clicks counters in full quotes
2019-05-17 14:17:29 +02:00
ef660d5a3e
FIX: Return consistent character encodings when downloading S3 uploads
...
Net::HTTP always returns ASCII-8BIT encoding. File.read auto-detects the encoding. This leads to an encoding inconsistency between a fresh download, and a cached download. This commit ensures all downloaded files are treated equally, by always returning the cached version from the filesystem, even during initial download.
One symptom of this problem is during theme exports: https://meta.discourse.org/t/116907
Related ruby ticket: https://bugs.ruby-lang.org/issues/2567
2019-05-17 11:27:00 +01:00
105359e54a
FIX: Only delete theme folder if it has been created
...
If an exception is raised before the folder is created, then this `ensure` block is still run
2019-05-17 09:45:11 +01:00
148bfc9be5
DEV: Simplify client and server side code to support removing tags.
...
Follow up to 834c86678f
2019-05-17 16:39:20 +08:00
5666316285
FEATURE: Display 'last updated' on dashboard, improve release notes link ( #7560 )
2019-05-17 15:42:45 +10:00
b5dd4478e5
FIX: Blocked watched words should apply to staff ( #7547 )
...
Having different behavior for staff and regular users can make it confusing for admins to understand how their configuration changes affect regular users
2019-05-16 15:19:41 +01:00
9ce9d72e71
DEV: makes hidepassed default when running qunit ( #7558 )
...
Mostly useful when not running headless, but I endup doing it a lot when debugging, one less thing to check.
2019-05-16 14:37:01 +02:00
3172172b52
remove unused local variable
...
ec84c87ddb
2019-05-16 15:39:13 +05:30
ec84c87ddb
FIX: skip validation while recovering uploads from s3
...
TODO: add tests
2019-05-16 15:37:11 +05:30
5dd97d6d38
DEV: prevent already defined global warning
2019-05-16 11:32:10 +02:00
4a9756ff3f
DEV: sets rack server to test env when using rake qunit:test ( #7554 )
2019-05-16 10:44:29 +02:00
cabc203885
Followup to a8fbb19e
...
Correct edge condition where no available names are found
- increase search space
- search for 10 extra names
2019-05-16 18:15:56 +10:00
a8fbb19e7c
FEATURE: allow a huge number of users to share common prefix
...
Previously username suggester would give up after 100 attempts at getting
a username and fallback to random string.
This amends the logic so we do all the work of figuring out a good username
in SQL and avoids a large amount of queries in cases where a lot of usernames
were used up.
This corrects an issue on sites with large numbers of anon users
2019-05-16 17:15:16 +10:00
40328f055e
FIX: retrieve original filename from s3 object's content disposition header
2019-05-16 09:47:22 +05:30
dd49be27d3
DEV: Fix undefined variable.
...
Follow up to e8fafbc123
2019-05-16 11:28:48 +08:00
fd5c5e326f
FIX: remove full quote on direct replies when "typographed"
...
Use the cooked version of the post and the quote to compare their content in
order to take into account the "typographer" option of the markdown pipeline.
2019-05-15 17:49:29 +02:00
be0555cc17
FIX: Add bucket folder path only if not exists
2019-05-15 15:37:40 +05:30
6f747c6b71
FIX: don't allow username to be changed to same as password
...
We were blocking user registrations with same username and password,
but allowing usernames to be changed to be same as password later.
Also disallow names to be the same as password.
2019-05-13 16:43:40 -04:00
5605dba85c
DEV: Automatically annotate plugin models alongside core models
2019-05-13 16:37:47 +01:00
750c125707
DEV: Include foreign keys in model annotations
2019-05-13 15:53:42 +01:00
999fdb95db
DEV: Mark `discourse-login-with-amazon` as official plugin.
2019-05-13 16:13:20 +08:00
427cf295d9
DEV: Always require %{count} in French pluralized strings
2019-05-13 09:36:05 +02:00
6d44be5142
FIX: Catch InvalidPluralizationData exception in fallback locales
...
It shouldn't raise an exception when a pluralized string in a fallback locale is only partially translated.
2019-05-13 09:36:05 +02:00
a3e4f43a4d
DEV: Remove patch for I18n.exists?
...
It was merged upstream a long time ago
2019-05-13 09:36:05 +02:00
73015521e2
FIX: Correctly calculate fallback locale list
...
* English shouldn't fallback to any other locale
* Calculate fallback for default locale if it isn't English (useful for en_US)
* Reuse the fallback locale list when outputting translations to JavaScript
2019-05-13 09:36:05 +02:00
3fbab595d9
FEATURE: use the exact name provided by auth provider
...
Previously we would attempt to titleize it causing names like McDonald's
not to work as expected
2019-05-13 16:45:24 +10:00
ba913a24db
Add steam login to official plugin list.
2019-05-13 12:39:35 +08:00
c00dab89e4
Fix the build take 2.
2019-05-13 11:22:48 +08:00
8c4caac2e4
Fix frozen string error in `plugin:install_all_official`.
2019-05-13 10:19:02 +08:00
8165ceb320
Make rubocop happy.
2019-05-13 09:55:44 +08:00
888e68a163
FIX: When mutating a string to build a diff. Duplicate it first
...
Co-authored-by: Roman Rizzi <rizziromanalejandro@gmail.com>
2019-05-13 09:31:32 +08:00
982c4496ee
Correct some missing spots for frozen_string_literal
2019-05-13 09:31:32 +08:00
30990006a9
DEV: enable frozen string literal on all files
...
This reduces chances of errors where consumers of strings mutate inputs
and reduces memory usage of the app.
Test suite passes now, but there may be some stuff left, so we will run
a few sites on a branch prior to merging
2019-05-13 09:31:32 +08:00
20daa76829
DEV: Change priority to ultra_low for post-s3-migration rebake
2019-05-10 18:37:45 +08:00
2c6b595eed
FIX: Process image onebox correctly when image is wrapped in a link
...
The instagram onebox sometimes surrounds the image with an `<a>` tag, which was breaking the aspect ratio logic, and therefore causing posts to change height on load.
2019-05-10 10:02:40 +01:00
ce15f085c6
DEV: Return the right response code and error message.
...
Follow up to d1dbafebbc867c1a5ac9
2019-05-10 07:33:02 +08:00
4a1755b780
FIX: Don't create staged users when processing forwarded email fails
2019-05-09 23:47:47 +02:00
ccc1e85bf4
REFACTOR: Shorten up category param check
...
Follow up to d1dbafebbc
2019-05-09 14:35:36 -06:00
b380ed5282
FEATURE: Claim Reviewables by Topic
...
This is a feature that used to be present in discourse-assign but is
much easier to implement in core. It also allows a topic to be assigned
without it claiming for review and vice versa and allows it to work with
category group reviewers.
2019-05-09 13:40:36 -04:00
9758857a78
FIX: escape Vimeo iframe URL
2019-05-09 23:01:50 +05:30
d1dbafebbc
FIX: Return error if new topic category not found take 2
...
If creating a topic via the api as an admin and the category you specify
cannot be found an error will now be returned instead of just creating
the topic with no category. This will prevent accidental public topic
creation originally intended for a private category.
This commit is follow up to 535c594891
2019-05-09 11:27:45 -06:00
b5c8f5f900
SPEC: ensure never remap readonly columns
...
Follow-up to bfcbfd78
2019-05-09 18:01:35 +02:00
4e91839c97
FIX: Remove default val for colors step if a default theme has been set.
...
Running through the wizard after a default theme has been configured
will always revert the default theme to the light theme.
2019-05-09 17:25:09 +08:00
414a36184b
DEV: Prefer `create!` over `create` when not checking return value.
2019-05-09 15:10:24 +08:00
626808e100
Fix incorrect condition in `groups:grant_badge` rake task.
...
`#find` raises an error if the id given to it is invalid. As a result,
the conditional to check whether a `group` or `badge` is `present?` will
not be executed if any of the ids are invalid.
Follow up to
6ba914033c
2019-05-09 14:53:13 +08:00
742decc2a1
PERF: Avoid looking up the same category twice in `TopicCreator`.
2019-05-09 14:53:13 +08:00
535c594891
Revert "FIX: Return error if new topic category not found"
...
This reverts commit 9c606dd99a
2019-05-09 14:53:13 +08:00
87cd4701b8
FEATURE: option to skip posts with ignored missing uploads
2019-05-09 05:11:15 +05:30
9c606dd99a
FIX: Return error if new topic category not found
...
If creating a topic via the api as an admin and the category you specify
cannot be found an error will now be returned instead of just creating
the topic with no category. This will prevent accidental public topic
creation originally intended for a private category.
2019-05-08 15:02:00 -06:00
a92c925378
Use faster Brotli compression for non-default locale files
2019-05-08 14:55:24 -04:00
d9ab722d05
Revert "Revert "PERF: Skip compressing locales for faster rebuilds ( #7501 )" ( #7502 )"
...
This reverts commit 6ea811c923
2019-05-08 14:55:06 -04:00
a4eb523af6
Track Discourse user agent pageviews as crawler
...
Since 5bfe051e
2019-05-08 10:38:55 -04:00
6ea811c923
Revert "PERF: Skip compressing locales for faster rebuilds ( #7501 )" ( #7502 )
2019-05-08 07:54:21 +02:00
22d6203eb7
DEV: Use moment-timezone with 10-year range data
...
We do not need to use the full timezone dataset (it is a 950kb file!), only previous/next 5 years should suffice.
2019-05-07 23:42:49 -04:00
5c0bb29461
DEV: re-enable compression for node asset compilation
...
#b9d82818 makes enormous improvements to our bootstrap time, however going
to still keep compress for now despite the cost and watch it for a few weeks
2019-05-08 10:24:57 +10:00
b9d8281818
PERF: Skip compressing locales for faster rebuilds ( #7501 )
...
* Do not brotli all locales in precompile
* Try without gzip
* uglify without compressing, always gzip
* skip uglify for unused locales
* FIX: Uglifier needs harmony for ES6 compatibility
* Use node uglifier if available
* Minor refactor
2019-05-08 10:22:19 +10:00
5af7c90bab
FEATURE: Hide Reviewable scores, change score filter to Priority
...
We found score hard to understand. It is still there behind the scenes
for sorting purposes, but it is no longer shown.
You can now filter by minimum priority (low, med, high) instead of
score.
2019-05-07 14:05:23 -04:00
5b5b5a5931
FIX: return an error if a user tries to whisper
...
This commit fixes a bug where a user creates a whisper post via the api
but is posted as a regular message because they don't have access to
whisper. Now a 403 unauthorized will be returned instead of the whisper
param just being ignored for regular users. Staff users should not be
affected by this change.
https://meta.discourse.org/t/a-whisper-is-posted-as-a-message-if-the-user-is-not-staff-moderator-admin-when-using-the-api/116601
2019-05-07 11:42:26 -06:00
1ddd4a44d5
FIX: Wrong color palette after backup restore
2019-05-07 17:02:57 +02:00
2487e01c73
FIX: Optimized site icons were missing after backup restore
2019-05-07 17:02:57 +02:00
446ec1b44a
Set input and textarea font size to 16px on iOS ( #7480 )
2019-05-07 10:44:43 -04:00
98a75906c8
FIX: Close topics deleted by users and ensure topic stubs are destroyed. ( #7430 )
2019-05-07 16:25:52 +03:00
f5a217be92
Fix typo in condition value.
2019-05-07 17:09:08 +05:30
c487dff776
early preview of new emojis ( #7486 )
2019-05-07 10:49:15 +02:00
2adbec1b3c
PERF: Speed up migrate_to_s3 rake task by deleting optimized image record.
...
No point moving all optimized image files to tombstone when the store is
changing. Also, `destroy_all` can easily blow memory since we are no
loading in batches.
2019-05-07 16:10:32 +08:00
e4abc51866
DEV: avoid using send when we can simply call the method
2019-05-07 16:50:45 +10:00
9adfd66a8b
Revert "FIX: When mutating a string to build a diff. Duplicate it first ( #7482 )" ( #7484 )
...
This reverts commit 20d4093a67
2019-05-07 16:36:23 +10:00
e2bcf55077
DEV: move send => public_send in lib folder
...
This handles most of the cases in `lib` where we were using send instead
of public_send
2019-05-07 12:25:44 +10:00
451f7842ff
DEV: More `send` -> `public_send`.
2019-05-07 10:05:58 +08:00
1e7c4592dc
Fix rebase fail in 152238b4cf.
2019-05-07 09:46:07 +08:00
152238b4cf
DEV: Prefer `public_send` over `send`.
2019-05-07 09:33:21 +08:00
Sam Saffron
Guo Xiang Tan
Vinoth Kannan
David Taylor
Gerhard Schlager
Régis Hanol
Joffrey JAFFEUX
Neil Lalonde
Blake Erickson
Robin Ward
Arpit Jalan
Penar Musaraj
Bianca Nenciu
Roman Rizzi