Joe
8531056ad5
UX: style fixes for admin digest email preview page ( #7959 )
...
* code formatting: Nothing changed in this commit except code formatting
* adds classes to digest refresh button
* adds margins to digest refresh button
* removes line break tags and uses CSS margins instead
2019-08-01 14:37:42 +08:00
David Taylor
d1434b6600
DEV: Remove unused imports
2019-07-31 16:21:02 +01:00
David Taylor
49bce0ccdb
DEV: Remove unused action from user preferences controller
...
This is no longer used following d8ff94ecaa
2019-07-31 16:15:23 +01:00
David Taylor
a49b7bb84a
FIX: Prevent user-notifications-dropdown from causing unintended changes
...
It was setting the `onClose` property of the singleton modal controller, which would then persist until the next full page reload
2019-07-31 15:38:47 +01:00
Osama Sayegh
13e74151a9
FEATURE: list category moderators on the about page ( #7916 )
...
https://meta.discourse.org/t/category-group-review-moderation/116478?u=osama
2019-07-31 16:46:58 +03:00
Neil Lalonde
9656a21fdb
FEATURE: customization of html emails ( #7934 )
...
This feature adds the ability to customize the HTML part of all emails using a custom HTML template and optionally some CSS to style it. The CSS will be parsed and converted into inline styles because CSS is poorly supported by email clients. When writing the custom HTML and CSS, be aware of what email clients support. Keep customizations very simple.
Customizations can be added and edited in Admin > Customize > Email Style.
Since the summary email is already heavily styled, there is a setting to disable custom styles for summary emails called "apply custom styles to digest" found in Admin > Settings > Email.
As part of this work, RTL locales are now rendered correctly for all emails.
2019-07-30 15:05:08 -04:00
tshenry
7ebb3503a3
UX: Make profile views consistent with other elements ( #7956 )
...
* UX: Make profile views consistent with other elements
* Spaces not tabs
2019-07-30 09:23:37 -04:00
Osama Sayegh
70bd8e2dad
UX: Show a warning when admin clicks save without adding group when changing category permissions ( #7947 )
...
* UX: Show a warning when admin clicks save without adding group when changing category permissions
* Use div rather than pseudo element
* Don't pass controller to component
* Use observer instead of a delay
* Refactor
* Rename to validator
* validator is much better than saveValidator
2019-07-29 21:53:31 +03:00
David Taylor
d4acd35466
FEATURE: Sync unread state live to topic lists ( #7933 )
2019-07-29 10:28:42 +01:00
Guo Xiang Tan
49d9557337
Revert commit that was pushed by mistake.
...
This reverts commit c7516c42e9
.
2019-07-29 11:04:38 +08:00
Guo Xiang Tan
c7516c42e9
Revert "FIX: reverts #18e2816 ( #7940 )"
...
This reverts commit c7b146cbdf
.
2019-07-29 09:18:53 +08:00
David Taylor
3324747afe
UX: Improve account association when account description is missing
2019-07-27 16:37:21 +01:00
Rafael dos Santos Silva
1922d4bf78
PERF: Add more constraint on the Cache Storage usage
...
Only restricting cache per age wasn't enough for instances with lots of
multimedia usage and high number of posts.
MaxEntries is also more effective on cleanup, and purgeOnQuotaError
advertise that Discourse cache can be purged if necessary.
https://developers.google.com/web/tools/workbox/guides/storage-quota
2019-07-27 11:52:21 -03:00
Penar Musaraj
042f7184f1
DEV: Display FA 4.7 deprecation notice in all environments
...
FA 4.7 icon mapping will be removed soon.
2019-07-26 15:25:20 -04:00
Joffrey JAFFEUX
fe7f0982af
DEV: attemps to limit Discourse.User.current() usage ( #7943 )
2019-07-26 11:20:11 +02:00
David Taylor
4f1382a54a
FIX: Hide live-loaded posts from ignored users
2019-07-25 12:01:29 +01:00
Joffrey JAFFEUX
0c7df55686
DEV: uses router.currentRouteName instead of application ( #7942 )
...
https://deprecations.emberjs.com/v3.x/#toc_application-controller-router-properties
2019-07-25 12:50:30 +02:00
Joffrey JAFFEUX
1dde6a5355
DEV: prevents post.siteSettings computed property to be overridden ( #7941 )
...
This happens when loading a post from a json object and is a behavior which will be impossble in future Ember updates.
2019-07-25 11:54:23 +02:00
Joffrey JAFFEUX
c7b146cbdf
FIX: reverts #18e2816 ( #7940 )
2019-07-25 11:14:23 +02:00
Joffrey JAFFEUX
c1d2fb115c
DEV: prevents staff computed property to be overridden ( #7931 )
2019-07-24 22:01:08 +02:00
Kris
2ab022494a
UX: Add expanded/collapsed class to post-controls ( #7932 )
2019-07-24 10:08:59 -04:00
Joffrey JAFFEUX
1d38bf7e2c
DEV: removes deprecated property() usage from topic-footer-button api ( #7930 )
2019-07-24 13:55:18 +02:00
Joffrey JAFFEUX
e83dcfdb7b
DEV: ensures application.hbs is using router currentPath ( #7929 )
2019-07-24 13:33:59 +02:00
Joffrey JAFFEUX
e444ce7ccd
REFACTOR: this.$() deprecation ( #7928 )
2019-07-24 13:17:36 +02:00
David Taylor
0a6cae654b
SECURITY: Add confirmation screen when connecting associated accounts
2019-07-24 10:28:15 +01:00
Kris
3fdc10337d
follow up fix to 7d27b8b
2019-07-23 11:37:34 -04:00
Kris
7d27b8bb8c
add class for extra post buttons
2019-07-23 11:32:04 -04:00
Joffrey JAFFEUX
8a9ce7336d
FIX: removes uncategorized context if not allowed in composer ( #7922 )
2019-07-23 17:05:49 +02:00
Saurabh Patel
4bc5ccf7e4
BUG: send featuredLink as featured_link to backend to update correct … ( #7915 )
...
* BUG: send featuredLink as featured_link to backend to update correct value
https://meta.discourse.org/t/editing-a-topic-link-does-not-change-its-featured-link/123007
* review fix
2019-07-23 09:49:04 -04:00
Osama Sayegh
5fc5a7f5ae
FEATURE: Add search operator to see all direct messages from a user ( #7913 )
...
* FEATURE: Add search operator to see all direct messages from a user
* Only show message if related messages >= 5
* Make "all messages" the hyperlink
* Review
2019-07-22 10:55:49 -04:00
Osama Sayegh
f14c6d81f4
FEATURE: Watched words improvements ( #7899 )
...
This commit contains 3 features:
- FEATURE: Allow downloading watched words
This introduces a button that allows admins to download watched words per action in a `.txt` file.
- FEATURE: Allow clearing watched words in bulk
This adds a "Clear All" button that clears all deleted words per action (e.g. block, flag etc.)
- FEATURE: List all blocked words contained in the post when it's blocked
When a post is rejected because it contains one or more blocked words, the error message now lists all the blocked words contained in the post.
-------
This also changes the format of the file for importing watched words from `.csv` to `.txt` so it becomes inconsistent with the extension of the file when watched words are exported.
2019-07-22 14:59:56 +03:00
Joffrey JAFFEUX
67650328b4
FIX: allows to specify camelCased attributes in wrap component ( #7919 )
2019-07-22 09:24:27 +02:00
Roman Rizzi
eb26bee046
DEV: group_list site settings should store IDs instead of group names ( #7860 )
...
* DEV: group_list site settings should store IDs instead of group names
* Ship site setting to know when we should migrate group_list settings
* Migrate existing group_list site settings
* Bump migration timestamp and don't set null when migrating is not possible.
2019-07-19 15:17:58 -03:00
Robin Ward
e47e0af123
FEATURE: Allow viewing of raw emails for reviewable queued posts ( #7910 )
...
If a post arrives via email but must be reviewed, we now show an
icon that can be clicked to view the raw contents of the email.
This is useful if Discourse's email parser is acting odd and the user
reviewing the post wants to know what the original contents were before
approving/rejecting the post.
2019-07-19 11:56:14 -04:00
Robin Ward
8dd3cbfcb9
FEATURE: Allow choice of category when making a PM public ( #7907 )
...
* FEATURE: Allow choice of category when making a PM public
Previously it would default to uncategorized, which was not ideal on
some forums. This gives the staff member more choice about what they'd
like to do.
* Make the optional category more explicit
* Joffrey's feedback
2019-07-19 11:52:50 -04:00
Kris
9075789783
IE11 fix for b73bd7f
2019-07-19 11:46:20 -04:00
Bianca Nenciu
9ba2c7cd8b
FIX: Set a minimum reading time per post. ( #7842 )
...
Topics containing only images could generate a reading time of zero minutes.
2019-07-19 18:15:38 +03:00
Kris
5a3a6824c4
UX: Refactor avatar upload modal for better mobile spacing
2019-07-19 10:39:38 -04:00
Bianca Nenciu
9f500a4ff4
FIX: Show same username or name for post notices. ( #7862 )
2019-07-19 11:05:48 +03:00
Joffrey JAFFEUX
533f5172d7
fix tests ( #7912 )
2019-07-18 23:15:36 +02:00
Joffrey JAFFEUX
8dfd0e0374
DEV: uses private API for currentPath ( #7911 )
...
* DEV: uses with private API for currentPath
router.currentRouteName as a slightly different API and application.currentPath is deprecated
* another fix
2019-07-18 17:00:39 -04:00
Joffrey JAFFEUX
9cdc059a99
fix tests ( #7908 )
2019-07-18 19:48:12 +02:00
Joffrey JAFFEUX
f9c7d5a4bd
DEV: removes application.currentPath deprecation ( #7905 )
...
See https://deprecations.emberjs.com/v3.x#toc_application-controller-router-properties for more context
2019-07-18 13:29:37 -04:00
Joffrey JAFFEUX
617c74bc79
DEV: remove .property() deprecations ( #7906 )
...
More context at https://deprecations.emberjs.com/v3.x#toc_function-prototype-extensions-property
2019-07-18 13:28:23 -04:00
Robin Ward
5e50a24d3a
Fix typo
...
It's jump-to not jumpt-to
2019-07-18 12:44:35 -04:00
Joffrey JAFFEUX
cb84133855
FIX: bugs preventing to close delete account modal with button ( #7904 )
2019-07-18 18:16:29 +02:00
Joffrey JAFFEUX
95ad4f9077
FEATURE: new date/time components ( #7898 )
2019-07-18 17:29:41 +02:00
Neil Lalonde
194a2b612f
FIX: string that can't be translated in watched words UI
2019-07-18 11:07:02 -04:00
Roman Rizzi
f5c707c97a
FEATURE: Gz to zip for exports ( #7889 )
...
* Revert "Revert "FEATURE: admin/user exports are compressed using the zip format (#7784 )""
This reverts commit f89bd55576
.
* Replace .tar.zip with .zip
2019-07-18 09:34:48 -03:00
Joe
c1b58613a2
UX: adds <a> tag with href category box titles ( #7901 )
...
This Ensures that category titles in category-boxes can be opened in a new tab.
2019-07-18 19:25:39 +08:00
Arpit Jalan
d4d81515d2
Fix the build.
2019-07-17 12:03:45 +05:30
Arpit Jalan
e4d743910d
FIX: respect `logout_redirect` setting on 'Log out all'
2019-07-17 11:58:04 +05:30
Rafael dos Santos Silva
2a0cd066a7
FIX: Remove all service workers from Apple devices *again*
...
There is a bug that when Safari starts up, and reloads the tabs from
the previous session **and** there is a service worker registered for
the scope of the document, all cookies marked as `SameSite=Lax` won't be
sent in the request.
This puts Discourse in a **very** broken state, where:
- You appear as a anon user
- Subsequent xhr requests will come with logged in data
- Refreshing doesn't log you in (cookies are still not sent)
- Clicking on the address bar and hitting enter, will log you in (as it
will finally send those damn `SameSite=Lax` cookies.
Looks a lot like a corner case missed by the fix at
https://trac.webkit.org/changeset/241918/webkit
2019-07-16 19:30:38 -03:00
Penar Musaraj
a571efba35
FIX: Rename deprecated icons, allow custom icons in badges
...
- adds a migration renaming FA4 icon names in badges
- allows all icons to be used in badges (previously was limited to icons prefixed with fa-)
- renames remaining FA 4.7 icons equivalents
2019-07-16 11:13:44 -04:00
Joffrey JAFFEUX
b3eb67976d
DEV: Upgrades to Ember 3.10 ( #7871 )
...
Co-Authored-By: majakomel <maja.komel@gmail.com>
2019-07-16 12:45:15 +02:00
David Taylor
e2fa5704e9
UX: Remove duplicate copy in two-factor preferences
2019-07-16 10:57:11 +01:00
romanrizzi
12e71f1fb2
UX: Swap ignore and mute sections to move the 'Save changes' button to the bottom
2019-07-15 17:30:01 -03:00
Rafael dos Santos Silva
b505d1d700
DEV: Force workboxjs debug to false on dev env too
2019-07-15 16:07:49 -03:00
Osama Sayegh
6515ff19e5
FEATURE: Allow customization of robots.txt ( #7884 )
...
* FEATURE: Allow customization of robots.txt
This allows admins to customize/override the content of the robots.txt
file at /admin/customize/robots. That page is not linked to anywhere in
the UI -- admins have to manually type the URL to access that page.
* use Ember.computed.not
* Jeff feedback
* Feedback
* Remove unused import
2019-07-15 20:47:44 +03:00
Penar Musaraj
90e0f1b378
UX: rearrange controls in edit modals
...
Allows users to see the controls even after scrolling contents of edit modal.
2019-07-15 13:44:44 -04:00
Rafael dos Santos Silva
1221d34284
FEATURE: Make Discourse work offline with WorkboxJS ( #7870 )
2019-07-15 13:05:55 -03:00
Vinoth Kannan
839916aa49
DEV: Debundle plugin javascript assets and don't load if disabled ( #7566 )
...
And don't load javascript assets if plugin is disabled.
* precompile auto generated plugin js assets
* SPEC: remove spec test functions
* remove plugin js from test_helper
Co-Authored-By: Régis Hanol <regis@hanol.fr>
* DEV: using equality is slightly easier to read than inequality
Co-Authored-By: Régis Hanol <regis@hanol.fr>
* DEV: use `select` method instead of `find_all` for readability
Co-Authored-By: Régis Hanol <regis@hanol.fr>
2019-07-15 20:22:54 +05:30
Guo Xiang Tan
4b0cf7f6dd
SECURITY: XSS when displaying watched words in admin panel.
...
The XSS here is only possible if CSP is disabled. Low impact since CSP
is enabled by default in SiteSettings.
2019-07-15 10:55:50 +08:00
Bianca Nenciu
c4d1833588
FIX: Do not show bootbox if post has no replies. ( #7866 )
...
When we delete a post that has replies, we show a modal asking if the user wants to delete the post, the post and its direct replies or the post and all its replies.
If replies are deleted before a post, that modal would ask the user if they want to delete the post and 0 replies.
That commit ensure we skip the modal and directly delete the post in this case.
2019-07-12 11:42:57 +02:00
Gerhard Schlager
4a095b286b
Follow-up for 9a11a8b3
to fix qunit tests
2019-07-11 23:56:22 +02:00
Gerhard Schlager
9a11a8b33b
FEATURE: Site setting for typographic quotation marks
...
Adds locale defaults for German and French
2019-07-11 23:19:28 +02:00
Arpit Jalan
e0562a8172
UX: update placeholder for Tags Groups
2019-07-11 12:34:11 +05:30
Kris
aa7181820c
UX: Add title attribute and aria-label to PM icon link
2019-07-10 23:05:57 -04:00
Kris
bdaf07adcf
Hide empty anchor tag from screen readers
2019-07-10 22:39:25 -04:00
Kris
1983f0d06e
Don't load PM icon in title unless topic is a PM
2019-07-10 22:38:32 -04:00
Kris
b848bd4ddc
True should be a string to display properly in aria-haspopup
2019-07-10 22:02:21 -04:00
Joffrey JAFFEUX
bd35a8f334
FIX: ensures spinner is showing on tags/show when loading more ( #7876 )
...
Context: https://meta.discourse.org/t/issue-while-scrolling-down-after-selecting-a-tag-on-the-home-page/122542
2019-07-10 21:37:31 +02:00
Joffrey JAFFEUX
142344e45d
FIX: ensures routing with hash doesn't stuck history ( #7872 )
...
* FIX: ensures routin with hash doesnt stuck history
Original issue: https://meta.discourse.org/t/hash-anchor-in-url-prevents-further-url-updates/122068/4
Basically when the path has a hash, state would be null, and nothing would happen.
* Update app/assets/javascripts/discourse/lib/discourse-location.js.es6
Co-Authored-By: Régis Hanol <regis@hanol.fr>
2019-07-10 20:43:03 +02:00
romanrizzi
f89bd55576
Revert "FEATURE: admin/user exports are compressed using the zip format ( #7784 )"
...
This reverts commit 8b2580e20f
.
2019-07-10 11:38:51 -03:00
Dan Ungureanu
90fcdad3cd
UX: Discard selected post if it is not in viewport. ( #7869 )
...
This way, users can combine keyboard shortcuts with mouse scrolling.
2019-07-10 10:22:09 -04:00
Roman Rizzi
8b2580e20f
FEATURE: admin/user exports are compressed using the zip format ( #7784 )
...
* FEATURE: admin/user exports are compressed using the zip format
* Update translations. Theme exporter now exports .zip file. Theme importer supports .zip and .gz files
* Fix controller test, updated locale and skip saving the csv export to disk
2019-07-10 11:13:03 -03:00
Robin Ward
629bb8adf2
SECURITY: XSS with title selector on preferences page
...
Note this is very low severity as the group needs to be created with a
default title that contains HTML, and group creation is restricted to
staff members right now.
2019-07-09 15:49:24 -04:00
Dan Ungureanu
9f5cfa192e
FEATURE: Allow Markdown in post notices. ( #7864 )
2019-07-09 14:42:02 +03:00
Penar Musaraj
f4dc6de9f1
FIX: Clear theme editor content on switching tabs
...
Issue happens when sending a null value to ACE Editor.
Fixed by sending an empty string to ACE instead of null.
2019-07-08 20:06:56 -04:00
Penar Musaraj
7b0517895e
FEATURE: Add "Group owners" to posting options for groups
...
Context: https://meta.discourse.org/t/121589
This new setting option lets group owners message/mention large groups
without granting that privilege to all members.
2019-07-08 17:14:11 -04:00
Penar Musaraj
b690fc3d98
FEATURE: Add new group visibility option for "logged on users" ( #7814 )
...
Groups can now be marked as visible to "logged on users". All automatic groups (except `everyone`) are now visible to "logged on users", previously they were marked as public but suppressed in the group page for non-staff.
2019-07-08 15:09:50 -04:00
Robin Ward
de6edf9e4e
FIX: Back button would go to previous topic instead of list
...
See related topic:
https://meta.discourse.org/t/back-button-history-not-properly-working/122183
The issue here is the transition was not completing properly which meant
if you backed out of a topic quickly and entered a new one, hitting back
in the second topic would sometimes take you to the previous one instead
of back to the topic list.
2019-07-05 15:53:14 -04:00
Arpit Jalan
bd084b2147
FIX: do not show invite button if local logins are disabled
2019-07-05 15:16:20 +05:30
Joffrey JAFFEUX
f140c4d499
FIX: ensures routing to / with query string works ( #7859 )
2019-07-05 09:40:19 +02:00
Vinoth Kannan
1bb258ab49
DEV: use upload short-url in html to markdown conversion if 'base62-sha1' data attr available.
2019-07-05 10:06:41 +05:30
Penar Musaraj
c78634284c
UI: when in a different topic context, allow dismissing draft without destroying it
...
This changes the label and behaviour of the "No, keep" button in the confirmation modal when user cancels a draft while on a different topic. The new button label is "No, save draft", and when clicked, the composer will be dismissed without destroying the draft.
2019-07-04 11:45:57 -04:00
Mario Santos
c5625b70f1
FIX: Prevent emoji-picker from not showing ( #7856 )
...
If an external plugin inserts an element with class "emoji-picker", something probable if they extend EmojiPicker, it could cause troubles as css is added depending on the emoji-picker height. Just by adding a class of a parent <div> as could be d-editor, we prevent this from happening.
2019-07-04 11:46:21 +02:00
Gerhard Schlager
a5e80079d6
FEATURE: Add Belarusian language
2019-07-04 11:37:37 +02:00
Joffrey JAFFEUX
71bf9ec1b2
FEATURE: opt-in guidance on topics for users without access ( #7852 )
...
Co-Authored-By: majakomel <maja.komel@gmail.com>
Co-Authored-By: Robin Ward <robin.ward@gmail.com>
2019-07-04 10:12:39 +02:00
David Taylor
5fdf228db6
FIX: Respect the full_screen_login parameter from plugin auth providers ( #7855 )
...
This behavior was regressed in 427979e7e5
2019-07-04 09:06:29 +01:00
Bianca Nenciu
459932f4e2
FIX: Use title attribute for notification items. ( #7840 )
2019-07-03 10:48:13 -04:00
romanrizzi
9ca1bbe900
Revert "FIX: remove misplaced save button"
...
This reverts commit 4f468ef210
.
2019-07-03 10:56:08 -03:00
Joffrey JAFFEUX
f9f1df7611
DEV: prevents reports key to be time dependant when testing ( #7850 )
2019-07-03 15:43:01 +02:00
romanrizzi
4f468ef210
FIX: remove misplaced save button
2019-07-03 10:39:01 -03:00
Bianca Nenciu
bfdf740a05
FIX: Show 'Export' button for all tabular reports. ( #7838 )
2019-07-03 14:47:36 +02:00
Osama Sayegh
3d64532273
FEATURE: allow disabling theme components ( #7812 )
...
This allows you to temporarily disable components without having to remove them from a theme.
This feature is very handy when doing quick fix engineering.
2019-07-03 18:18:11 +10:00
Joffrey JAFFEUX
ecf0215ee7
DEV: resets page tracking state between tests ( #7847 )
2019-07-03 10:08:05 +02:00
Joffrey JAFFEUX
0733ed3a2b
FIX: ensures /t/TOPIC_ID/POST_NUMBER is correctly routing ( #7841 )
2019-07-03 09:23:23 +02:00
Penar Musaraj
6e3e0685fb
DEV: add useBlockMode option for toolbar button text selection
...
Allows buttons to switch selection to block mode if needed.
2019-07-02 18:02:40 -04:00
Rafael dos Santos Silva
c422520b4a
FEATURE: Add CSS classes to associated accounts rows
2019-07-02 16:56:15 -03:00
Joffrey JAFFEUX
72441e2c7c
FIX: page starts at 1 ( #7844 )
2019-07-02 17:26:23 +02:00
romanrizzi
8404921b91
FIX: Remove misplaced outlet
2019-07-02 11:26:40 -03:00
Arpit Jalan
ccb3ba509d
FIX: creating new badge is failing on empty SQL query ( #7837 )
2019-07-02 15:12:53 +05:30
Penar Musaraj
fca2f0f212
FIX: Only show remove timer button to users with permission to do so
2019-07-01 22:17:02 -04:00
Osama Sayegh
f1c67729de
Different fix ( #7815 )
2019-07-02 11:53:16 +10:00
Sam Saffron
4dcc5f16f1
FEATURE: when under extreme load disable search
...
The global setting disable_search_queue_threshold
(DISCOURSE_DISABLE_SEARCH_QUEUE_THRESHOLD) which default to 1 second was
added.
This protection ensures that when the application is unable to keep up with
requests it will simply turn off search till it is not backed up.
To disable this protection set this to 0.
2019-07-02 11:22:01 +10:00
Arpit Jalan
f56d86a852
FIX: use normal title instead of fancy title for prefilled composer
2019-07-01 17:55:24 +05:30
Joffrey JAFFEUX
7b52a110b8
DEV: removes DOMTokenList polyfill ( #7831 )
...
Creates more issues than it solves especially on IOS, I dont trust it anymore. Will reconsider if this is an issue in the future.
2019-07-01 14:08:38 +02:00
Arpit Jalan
997250586c
FEATURE: prefill title for direct messages from topic
...
https://meta.discourse.org/t/default-re-title-title-for-direct-messages-from-topic/121413
2019-07-01 17:14:08 +05:30
Joffrey JAFFEUX
af58049eeb
UX: puts tags and categories on same line in search-menu-results ( #7830 )
2019-07-01 13:11:43 +02:00
Joffrey JAFFEUX
384f5cea05
FIX: ensures static pages are using absolute path ( #7828 )
2019-07-01 11:25:45 +02:00
Joffrey JAFFEUX
11ae5c78db
FEATURE: adds infite scroll on admin users list page ( #7821 )
2019-07-01 11:00:06 +02:00
Bianca Nenciu
4f97f85178
DEV: Fix lint. ( #7824 )
2019-06-28 20:24:09 +02:00
Joffrey JAFFEUX
5bab4f8007
UX: gives each info its own line in search-menu-results ( #7825 )
2019-06-28 11:14:38 +02:00
Joffrey JAFFEUX
61438c825a
fix prettier ( #7823 )
2019-06-28 09:36:38 +02:00
Bianca Nenciu
b2eb0f4ad6
FEATURE: Export any type of report supporting table mode. ( #7662 )
2019-06-28 08:50:31 +02:00
Kris
82f2af8a0d
UX: Move link to show tracked topics, simplify translation
2019-06-27 21:36:24 -04:00
Ralph Rooding
4ba35472e6
Don't check for second factor when switching to anonymous account ( #7803 )
2019-06-27 15:01:26 -07:00
Joffrey JAFFEUX
a61147d838
FEATURE: displays tags in search menu results when enabled ( #7819 )
2019-06-27 19:26:14 +02:00
Robin Ward
ed936bcb01
FIX: Fix a navigation bug
...
To reproduce:
1. Visit a url in a new tab such as `/latest?order=views`
2. Click a topic link
3. Click the back button
Before this patch, you would not be sent back to the latest list.
Now, I am somewhat hesitant to delete code like this, but the [original
commit](b2b7f4d905
)
explains a situation that I cannot reproduce with the code missing.
I cannot seem to keep the filters as sticky even if I try. At the very
least this is better to commit right now than the currently known broken
situation.
2019-06-27 09:06:10 -04:00
Sam Saffron
5bc5c02af6
FIX: mark topics in sub categories as unread when dismissing parent
...
Previously we would only dismiss the parent category and leave the
child categories unread
2019-06-27 13:26:48 +10:00
Jeff Wong
88ef5e55fe
FEATURE: add ability to have multiple totp factors ( #7626 )
...
Adds a second factor landing page that centralizes a user's second factor configuration.
This contains both TOTP and Backup, and also allows multiple TOTP tokens to be registered and organized by a name. Access to this page is authenticated via password, and cached for 30 minutes via a secure session.
2019-06-26 16:58:06 -07:00
Joffrey JAFFEUX
c63268467e
DEV: prettier 1.18.2 ( #7810 )
2019-06-26 17:09:52 +02:00
Penar Musaraj
76307611dc
UX: new inline button to remove a topic timer ( #7790 )
2019-06-26 11:08:53 -04:00
Gerhard Schlager
13f38055ac
SECURITY: XSS in routes
...
Co-authored-by: Guo Xiang Tan <tgx_world@hotmail.com>
Co-authored-by: David Taylor <david@taylorhq.com>
2019-06-26 16:34:15 +02:00
Joffrey JAFFEUX
56b76f31dc
fix prettier linting ( #7809 )
2019-06-26 15:26:02 +02:00
Daniel Waterworth
65a6e2c860
Change Widget#attach signature
...
Take a fallback option instead of a list of names
2019-06-26 09:01:25 -04:00
Daniel Waterworth
37b8f5d989
Use dasherize instead of replace
2019-06-26 09:01:25 -04:00
Daniel Waterworth
d025e188e8
Make the linter happy
2019-06-26 09:01:25 -04:00
Daniel Waterworth
70e27641eb
Pass data to description to prevent duplication
2019-06-26 09:01:25 -04:00
Daniel Waterworth
8c349101c5
Pass data to text method to prevent duplication
2019-06-26 09:01:25 -04:00
Daniel Waterworth
86d5208b31
Pass data to url method to avoid duplication
2019-06-26 09:01:25 -04:00
Daniel Waterworth
ac6f7b3625
Remove notificationType argument from text
2019-06-26 09:01:25 -04:00
Daniel Waterworth
a3254b8446
Pull invitee accepted notification behaviour into its own class
2019-06-26 09:01:25 -04:00
Daniel Waterworth
7c52ba1431
Pull liked consolidated notification behaviour into its own class
2019-06-26 09:01:25 -04:00
Daniel Waterworth
42143a874e
Pull custom notification behaviour into its own class
2019-06-26 09:01:25 -04:00
Daniel Waterworth
305562bf66
Pull title logic into its own method
2019-06-26 09:01:25 -04:00
Daniel Waterworth
d83147d137
Rename "title" variable to more apt "description"
2019-06-26 09:01:25 -04:00
Daniel Waterworth
02deaa4bc6
Pull icon choosing into its own method
2019-06-26 09:01:25 -04:00
Daniel Waterworth
36d7abed0b
Pull group message summary behaviour into its own class
2019-06-26 09:01:25 -04:00
Daniel Waterworth
396e13aaa7
Pull liked notification behaviour in its own class
2019-06-26 09:01:25 -04:00
Daniel Waterworth
bd062fcbef
Export DefaultNotificationItem
2019-06-26 09:01:25 -04:00
Daniel Waterworth
04a75b1cb3
Change the way notification items are created
...
Look for the specialised version first, before falling back to the
default. This allows the behaviour to be customised based on the type of
notification.
2019-06-26 09:01:25 -04:00
Daniel Waterworth
cdf0cd3ecd
`createWidgetFrom` creates a new widget with an arbitrary base class
2019-06-26 09:01:25 -04:00
Daniel Waterworth
01a7fd4225
Make `attach` optionally take a list of widget names to try
2019-06-26 09:01:25 -04:00
Daniel Waterworth
41129f933d
Rename notification-item to default-notification-item
2019-06-26 09:01:25 -04:00
Daniel Waterworth
7e70db3fb7
s/notName/notificationName/g
2019-06-26 09:01:25 -04:00
Joffrey JAFFEUX
7c9d62c280
FIX: prevents failure when TL was mutated on internal object ( #7808 )
2019-06-26 14:51:45 +02:00
Joffrey JAFFEUX
01de7e1444
FIX: calling action with a string is deprecated ( #7807 )
2019-06-26 12:42:46 +02:00
Joffrey JAFFEUX
e64544ae44
icon s/trash/trash-alt ( #7806 )
2019-06-26 12:31:49 +02:00
Joffrey JAFFEUX
ea2a9bc4fc
FIX: closes search-menu on escape ( #7804 )
2019-06-26 11:53:39 +02:00
Osama Sayegh
2eece2c41b
UX: add shortcut for deferring topics ( #7798 )
2019-06-25 07:20:55 +03:00
Joffrey JAFFEUX
c1ca942a77
REFACTOR: removes self pattern from safari-hacks lib ( #7795 )
2019-06-24 11:12:06 +02:00
Joffrey JAFFEUX
e064db35d9
REFACTOR: removes self pattern from eyeline lib ( #7796 )
2019-06-24 10:58:59 +02:00
Joffrey JAFFEUX
cea3a027f3
FIX: category-chooser search should be scoped to category ( #7794 )
2019-06-24 10:45:30 +02:00
Joffrey JAFFEUX
7cabc47945
UX: improves change-timestamp modal datepicker ( #7771 )
2019-06-24 10:24:54 +02:00
Robin Ward
02f6db4e59
FIX: Back button shenanigans when redirecting from `index` routes
...
This is a problem that has long plagued Discourse. The root issue here
is that we have to implement our own link click handler, because
Discourse allows users to create HTML blobs of content with links, and
when those links are clicked they must be handled by the Ember router.
This always involved a certain amount of use of private Ember APIs which
of course evolved over time.
The API has more or less stabilized in the last two years, however we
have hacks in our URLs to handle a dynamic root path, depending on how
forums have set up their filters and in what order.
This patch adds a special case for the root path so we needn't update
the URL ourselves otherwise, which preserves the back button on index
routes. The update call would otherwise insert an extra history event if
a route redirected on transition, breaking the back button.
2019-06-21 14:42:01 -04:00
Penar Musaraj
e51de4cc25
FEATURE: Add endpoint to individually update a theme setting ( #7789 )
...
- also adds a new staff action type called "change theme setting" for easier logging of staff changes to theme settings
2019-06-21 13:49:14 -04:00
Arpit Jalan
2738d11f60
UX: show like icon on archived posts ( #7775 )
2019-06-21 20:47:32 +05:30
Joffrey JAFFEUX
1cbe2dd2ce
DEV: adds polyfill to fully support DOMTokenList in IE ( #7765 )
2019-06-21 09:59:28 +02:00
Robin Ward
fc026e12a5
FIX: Some toolbar operations weren't triggering the `change` event
...
This would mean that some simple edits to queued posts did not get
saved.
2019-06-20 13:35:12 -04:00
Penar Musaraj
0e26c57afa
FIX: Do not refresh all settings on save for all settings, limit to only a few
...
- Followup to 0e303c7f5d
- Automatically reloads site settings after saving only for the logo, logo_small and large_icon settings.
2019-06-20 10:57:31 -04:00
Vinoth Kannan
56b7777705
FIX: 'status' param change not filtering the topics in tag route.
...
Use existing 'filterQueryParams' helper method to set 'queryParams' value for tag route.
2019-06-20 17:27:32 +05:30
Penar Musaraj
f096c994de
FIX: use correct name for selectable_avatars_enabled site setting
2019-06-19 13:18:16 -04:00
Robin Ward
6fec4982d9
FIX: Couldn't modify a widget that wasn't in the registry
2019-06-18 12:28:18 -04:00
Sam Saffron
03ba1d49fb
DEV: lint file
...
We no longer need that isAppleDevice require
2019-06-18 17:12:55 +10:00
Maja Komel
506de13896
FIX: remove temporary hack for fixed iOS bug ( #7773 )
...
A bug where input focus is displaced on modals was fixed in iOS 11.3 update. This hack was causing problems on topic page since hiding main-outlet results in lost read position after opening and closing a modal.
2019-06-18 16:25:29 +10:00
David Taylor
52387be4a4
SECURITY: Add confirmation screen when logging in via email link
2019-06-17 16:18:37 +01:00
David Taylor
5f6f707080
Revert "Merge pull request from GHSA-hv9p-jfm4-gpr9"
...
This reverts commit b8340c6c8e
.
2019-06-17 16:17:10 +01:00
David Taylor
b8340c6c8e
Merge pull request from GHSA-hv9p-jfm4-gpr9
...
* SECURITY: Add confirmation screen when logging in via email link
* SECURITY: Add confirmation screen when logging in via user-api OTP
* FIX: Correct translation key in session controller specs
* FIX: Use .email-login class for page
2019-06-17 15:59:41 +01:00
Arpit Jalan
102be5a9e3
DEV: optimize fix for sub-categories not getting pre-filled.
2019-06-17 13:28:08 +05:30
tshenry
c909033f2b
Add plugin outlets to login/create-account modals ( #7770 )
2019-06-17 16:22:00 +10:00
Arpit Jalan
48b9e0d749
FIX: sub-categories was not getting selected for pre-filled topics
2019-06-15 13:46:15 +05:30
Arpit Jalan
efc05e7224
FIX: remove topic timer info on completion
2019-06-13 17:01:43 +05:30
Joffrey JAFFEUX
19ca2d4772
DEV: reset widget clean callback between tests ( #7761 )
2019-06-12 17:49:02 +02:00
Robin Ward
13b979cb71
FIX: Performing actions on a particular reviewable was displaying an error
...
It was expecting a method to remove the reviewable from the current
list, only we were not displaying a list.
Instead, we refresh the reviewable model with the latest result.
2019-06-12 10:56:30 -04:00
David Taylor
0ebe5ec1f8
FIX: Check `postStream.gaps` exists before trying `postSteam.gaps.after`
2019-06-11 23:48:21 +01:00
Robin Ward
f6e0c79742
FIX: Trigger change event when inserting text
...
This would normally not fire and result in odd behavior in the review
queue when inserting links.
2019-06-11 17:27:34 -04:00
Robin Ward
3d7c26c15e
FIX: Memory Leaks w/ Container ( #7750 )
...
Gives instance initializers the ability to add a `teardown` method that
will be called between tests to clean up after themselves.
2019-06-11 18:41:27 +02:00
Robin Ward
47095a7fa1
FIX: Memory leak when adding ajax prefilter repeatedly.
2019-06-11 11:50:35 -04:00
Robin Ward
c322cccd53
FIX: Memory Leaks when decorating posts ( #7749 )
...
* Remove long-deprecated method
* FIX: Memory Leaks when decorating posts
Previously we'd keep creating mixins dynamically when decorating the
same class.
This code changes the API to recommend an `id` parameter for each
decorator which will avoid leaks. All plugins should be updated to
include this parameter, although if they don't in the meantime it'll
just mean a warning in the console (and a continued leak.)
2019-06-11 17:21:23 +02:00
David Taylor
f4fd75aea4
DEV: Rename variable to avoid conflict
2019-06-11 13:02:40 +01:00
David Taylor
f1d5b992bf
DEV: Correct linting error
2019-06-11 12:51:18 +01:00
Joffrey JAFFEUX
dc15486f0a
Revert "DEV: resets csrf ajax prefilter only if present ( #7747 )"
...
This reverts commit 6612218a4e
.
2019-06-11 13:34:25 +02:00
David Taylor
61b587f66e
FIX: Mark ignored posts as 'read', if last visible post is read ( #7739 )
2019-06-11 12:16:28 +01:00
David Taylor
000a35b219
FIX: Do not live-load posts from ignored users
2019-06-11 12:07:14 +01:00
Joffrey JAFFEUX
6612218a4e
DEV: resets csrf ajax prefilter only if present ( #7747 )
2019-06-11 12:50:20 +02:00
Joffrey JAFFEUX
ebf77f74b7
Revert "DEV: prevents csrf token to leak state between tests ( #7746 )"
...
This reverts commit b29d63a52d
.
2019-06-11 12:19:49 +02:00
Joffrey JAFFEUX
b29d63a52d
DEV: prevents csrf token to leak state between tests ( #7746 )
2019-06-11 11:54:23 +02:00
Joffrey JAFFEUX
e6714d3531
Revert "DEV: attempts to prevent session object to be retain in csrf init ( #7743 )"
...
This reverts commit 62c56b6e59
.
2019-06-11 10:58:32 +02:00
Joffrey JAFFEUX
4deb0f6d59
DEV: prevents post-cooked decorators to leak between tests ( #7744 )
2019-06-11 10:02:10 +02:00
Joffrey JAFFEUX
62c56b6e59
DEV: attempts to prevent session object to be retain in csrf init ( #7743 )
2019-06-11 09:59:14 +02:00
Joffrey JAFFEUX
c407e32368
DEV: should check on object and not length ( #7742 )
2019-06-11 09:45:45 +02:00
Guo Xiang Tan
e5cace9185
FIX: File size text should not be part of link.
2019-06-11 15:21:06 +08:00
Guo Xiang Tan
06d974d55c
FEATURE: Add base62 sha1 to cooked data attribute
...
* FEATURE: Add base62 sha1 to data attribute in `Post#cooked`.
* FIX: Use `Upload#short_url` when quoting an image.
2019-06-11 11:15:45 +10:00
Guo Xiang Tan
bd538f7437
FIX: Composer preview not caching inline onebox.
2019-06-11 09:14:53 +08:00
Bianca Nenciu
9168ffc201
PERF: Use already loaded post when quoting or opening draft.
2019-06-11 08:21:38 +08:00
Roman Rizzi
ace6ce0462
FIX: Add 'deleted' to the list of status filters ( #7738 )
2019-06-10 15:43:49 -03:00
Robin Ward
bdfa55ee5d
UX: Copyedits on reviewable filters
2019-06-10 13:45:38 -04:00
Robin Ward
86f3e74799
DEV: Allow `{{d-button}}` to include a href
2019-06-10 13:24:40 -04:00
Robin Ward
8b31b812f8
UX: Use a glyph to indicate a new topic instead of "New Topic:"
...
In the review queue it was easy to miss "New Topic:" so let's try a font
awesome glyph instead.
2019-06-10 12:43:20 -04:00
Robin Ward
8c4e16eafd
FIX: In reply to would sometimes have a broken link
2019-06-10 11:33:10 -04:00
Joffrey JAFFEUX
af08ab5b7b
Revert "DEV: prevents csrf-token initializer to leak session object ( #7730 )"
...
This reverts commit da5255e560
.
2019-06-07 18:31:16 +02:00
Joffrey JAFFEUX
ebecd0b7d1
Revert "fix tests, crsf token meta is not present on tests ( #7733 )"
...
This reverts commit 240b61e844
.
2019-06-07 18:31:13 +02:00
Joffrey JAFFEUX
2dce650b72
FIX: prevents screen-track from leaking object ( #7734 )
2019-06-07 17:18:27 +02:00
Joffrey JAFFEUX
240b61e844
fix tests, crsf token meta is not present on tests ( #7733 )
2019-06-07 17:11:16 +02:00
Joffrey JAFFEUX
dfb66334c1
DEV: prevents global-notice events to leak ( #7732 )
2019-06-07 16:49:59 +02:00
Joffrey JAFFEUX
55325679ac
DEV: prevents share-popup to leak events ( #7731 )
2019-06-07 16:48:45 +02:00
Joffrey JAFFEUX
da5255e560
DEV: prevents csrf-token initializer to leak session object ( #7730 )
2019-06-07 16:46:55 +02:00
Joffrey JAFFEUX
df01249db4
FIX: removes leaking handler in select-kit ( #7729 )
2019-06-07 16:12:22 +02:00
Joffrey JAFFEUX
fca90106b9
FIX: select-kit events were sometimes not cleaned up ( #7728 )
2019-06-07 15:20:01 +02:00
Gerhard Schlager
d1228f47bb
FIX: Handle missing plural keys on client
2019-06-07 10:24:17 +02:00
Joffrey JAFFEUX
a652d620f6
FIX: safari desktop doesnt support input[time] ( #7719 )
...
This commit attempts to improve the experience by:
- showing time input as disabled on any platform if date hasn't been set
- showing a placeholder --:-- to emphasize the expected format
2019-06-07 15:50:43 +10:00
Maja Komel
9db1fef4e3
FIX: add support for custom/plugin notification title attribute
2019-06-07 09:09:16 +08:00
Bianca Nenciu
35da531f1d
FIX: Do not resize images in Onebox while lazy loading.
...
Follow-up to 35d0fd0
.
2019-06-06 18:36:18 +03:00
Joffrey JAFFEUX
48b6391777
FIX: s/thumb-tack/thumbtack ( #7718 )
2019-06-06 14:43:16 +02:00
Joffrey JAFFEUX
c462c2f271
FIX: prevents appEvents to leak ( #7714 )
2019-06-06 12:33:52 +02:00
Guo Xiang Tan
782da448a2
FIX: Missing `title` attribute when quoting an image.
2019-06-06 16:45:12 +08:00
Guo Xiang Tan
2265c5102f
DEV: Remove unnecessary condition.
...
Follow up to 21876d46d6
.
2019-06-06 15:55:49 +08:00
Guo Xiang Tan
21876d46d6
DEV: Missing loading spinner for staff action logs.
...
Follow up to e0c821ebb0
.
2019-06-06 15:41:55 +08:00
Bianca Nenciu
e0c821ebb0
FEATURE: Make staff action logs page support infinite loading
2019-06-06 13:02:53 +10:00
Roman Rizzi
c3a38d2304
DEV: Make groups/new extensible by plugins ( #7642 )
...
* Expose a new plugin outlet. Pass group model to the group-member-dropdown so it can be accessed by plugins
* Added controller tests for group custom fields. update custom fields when updating a group
2019-06-06 12:05:33 +10:00
Guo Xiang Tan
7bd8f715bc
DEV: Prefer `this.site.notification_types`.
2019-06-06 09:39:59 +08:00
Guo Xiang Tan
d9d36f241d
DEV: Use `this.site.get("notification_types")` instead.
...
Follow up to fcb7422213
.
2019-06-06 08:18:25 +08:00
Robin Ward
58ff7216ca
UX: Display "Queued Topic" if a Queued Post will create a topic
2019-06-05 14:11:28 -04:00
Robin Ward
d902c4eb9f
FEATURE: Can sort reviewable queue
...
Choices are Priority / Created At (and desc versions.)
2019-06-05 13:21:05 -04:00
Bianca Nenciu
35d0fd038e
FIX: Add unit to width and height CSS properties.
2019-06-05 19:51:31 +03:00
Robin Ward
f1d547c301
FEATURE: Show "in reply to" on the review queue
...
We now show if a queued or flagged post is a reply to another when in
the review queue. It's especially helpful for queued posts where
normally they are linked to the topic where they are created, and you
have no context about the reply.
Note that this will only apply to new queued posts going forward.
Previously queued posts will not show the "in reply to"
2019-06-05 12:34:41 -04:00
Robin Ward
ad876880e1
FIX: Ember was raising an error without a `.set` here
2019-06-05 10:23:39 -04:00
Joffrey JAFFEUX
0082a57718
REFACTOR: computed lib ( #7702 )
2019-06-05 15:50:22 +02:00
Joffrey JAFFEUX
f506843074
REFACTOR: user route ( #7704 )
2019-06-05 13:05:27 +02:00
Joffrey JAFFEUX
1178f4865b
REFACTOR: login-method model ( #7703 )
2019-06-05 12:35:41 +02:00
Joffrey JAFFEUX
80459d83a4
REFACTOR: discourse-location lib ( #7700 )
2019-06-05 11:46:36 +02:00
Joffrey JAFFEUX
faef660631
REFACTOR: invite model ( #7699 )
2019-06-05 11:24:06 +02:00
Joffrey JAFFEUX
df6d46b235
FIX: regression and attempts to have clearer naming ( #7701 )
2019-06-05 11:23:30 +02:00
Joffrey JAFFEUX
0fd7f74664
REFACTOR: post model ( #7659 )
2019-06-05 11:04:35 +02:00
Joffrey JAFFEUX
69f75b2a81
REFACTOR: preferences/account controller ( #7698 )
2019-06-05 10:37:51 +02:00
Bianca Nenciu
b2b66d645b
UX: Move archive button in topic controls dropdown (mobile view). ( #7681 )
2019-06-05 11:30:06 +10:00
Joffrey JAFFEUX
f03a547a89
REFACTOR: topic-entrance component ( #7694 )
2019-06-04 17:50:02 +02:00
Joffrey JAFFEUX
6de3824b46
REFACTOR: group model ( #7692 )
2019-06-04 17:41:46 +02:00
Joffrey JAFFEUX
68147cedd1
REFACTOR: username-validation mixin ( #7693 )
2019-06-04 17:41:33 +02:00
Joffrey JAFFEUX
7b19e63ce7
REFACTOR: badge model ( #7690 )
2019-06-04 17:12:02 +02:00
Penar Musaraj
e66024bd3b
Update theme component URL
2019-06-04 10:04:27 -04:00
Joffrey JAFFEUX
4201329f1e
REFACTOR: topic-from-params route ( #7689 )
2019-06-04 15:51:22 +02:00
Maja Komel
87bf0ec7ae
FIX: fix locale key
2019-06-04 13:35:17 +02:00
Guo Xiang Tan
fcb7422213
DEV: Avoid hard-coding notification types integer in client side code.
...
Co-authored-by: Bianca Nenciu <nenciu.bianca@gmail.com>
2019-06-04 17:30:46 +08:00
Joffrey JAFFEUX
9585a16264
FIX: ensures correct i18n key is used ( #7686 )
2019-06-04 11:22:44 +02:00
Joffrey JAFFEUX
4283281397
FIX: ensures we have data to compute average ( #7685 )
2019-06-04 11:21:55 +02:00
Joffrey JAFFEUX
b79d02ff48
FEATURE: displays average for 2 columns tables which support average
2019-06-04 11:08:26 +02:00
Maja Komel
c9a34aa10c
FIX: add title attribute for notifications
2019-06-04 17:02:12 +08:00
Joffrey JAFFEUX
497a1d2d9f
FEATURE: uses native date picker on mobile ( #7541 )
2019-06-04 10:44:55 +02:00
Joffrey JAFFEUX
c4419b7369
REFACTOR: badge-selector component ( #7683 )
2019-06-04 10:30:56 +02:00
Maja Komel
2863e7c181
FIX: fix select badge as user title on badge page ( #7682 )
2019-06-04 18:19:30 +10:00
Guo Xiang Tan
1991af2abb
DEV: Switch `InlineUploads` to a regexp based implementation.
2019-06-04 15:54:25 +08:00
Joffrey JAFFEUX
0c5498c9a4
REFACTOR: exception controller ( #7675 )
2019-06-03 23:34:23 +02:00
Régis Hanol
b792db9d92
FIX: redirect to top was always redirecting to 'All'
2019-06-03 20:18:14 +02:00
Kris
9a3dd6b59a
UX: Add missing classes to user preferences
2019-06-03 13:35:40 -04:00
Penar Musaraj
16982d2a69
Update UI for wizard themes further reading step ( #7669 )
2019-06-03 10:47:17 -04:00
Dan Ungureanu
c1e7a1b292
UX: Merge settings related to muted tags. ( #7656 )
2019-06-03 12:23:23 +10:00
Dan Ungureanu
28dcf445b7
DEV: Pass editor to plugin hook handling composer uploads. ( #7673 )
2019-06-03 12:07:25 +10:00
romanrizzi
a0a2823536
DEV: Fix indentation
2019-05-31 10:19:19 -03:00
Joffrey JAFFEUX
1db7fd6f9b
REFACTOR: topic-list model ( #7658 )
2019-05-31 13:15:45 +02:00
Joffrey JAFFEUX
63264158cf
REFACTOR: user-posts-stream model ( #7657 )
2019-05-31 13:02:15 +02:00
Sam Saffron
3b8819f0ab
FEATURE: add support for defer topic functionality
...
This feature allows end users to "defer" topics by marking them unread
The functionality is default disabled. This also introduces the new site
setting default_other_enable_defer: to enable this by default on new user
accounts.
2019-05-31 15:44:35 +10:00
Sam Saffron
077dcc0642
FEATURE: add autocomplete discourse on full page search
...
This teaches chrome not to try autocompleting it.
2019-05-31 10:27:44 +10:00
Roman Rizzi
c169456ee5
DEV: Create new component to reify the user fields ( #7655 )
2019-05-30 16:17:16 -03:00
Robin Ward
c4fa20d644
FIX: Broken test, also typoed property
2019-05-30 14:27:28 -04:00
Robin Ward
5e89714f77
FIX: Linting via prettier
2019-05-30 13:58:06 -04:00
Robin Ward
7a9e85b1d7
FIX: Don't show the "Flag to delete" message to staff
...
If they can't delete, flagging should not either.
2019-05-30 13:31:40 -04:00
Joffrey JAFFEUX
7a21f78f8c
prettier ( #7653 )
2019-05-30 17:28:07 +02:00
Joffrey JAFFEUX
0fbbff86ab
REFACTOR: rest model ( #7652 )
2019-05-30 17:11:17 +02:00
Daniel Waterworth
bfb26b720b
FIX: the en_US locale depends on en
2019-05-30 08:46:43 +08:00
romanrizzi
e7ee556e87
Support multi-group user search
2019-05-30 08:45:20 +08:00
Kris
b24938b5ff
UX: Minor composer button alignment adjustments, simplification
2019-05-29 14:37:32 -04:00
Joffrey JAFFEUX
c77bc525cb
REFACTOR: new-topic route ( #7639 )
2019-05-29 16:46:58 +02:00
Joffrey JAFFEUX
ba66d6fd82
FIX: icon deprecation s/group/users ( #7638 )
2019-05-29 16:29:01 +02:00
Joffrey JAFFEUX
034502af21
FIX: incorrectly removed moveTypes array ( #7637 )
2019-05-29 16:23:32 +02:00
Joffrey JAFFEUX
bb6337d6c6
REFACTOR: choose-topic component ( #7636 )
2019-05-29 16:21:13 +02:00
Joffrey JAFFEUX
b2fc80e4b7
REFACTOR: build-topic-selection mixin ( #7635 )
2019-05-29 16:09:19 +02:00
Joffrey JAFFEUX
468cfa39f7
REFACTOR: rename-tag controller ( #7634 )
2019-05-29 15:58:12 +02:00
Joffrey JAFFEUX
f2858e03c8
REFACTOR: preferences/email controller ( #7633 )
2019-05-29 15:53:42 +02:00
Joffrey JAFFEUX
5e7e32510a
FIX: lookup should be done against locale of reference ( #7632 )
2019-05-29 15:45:44 +02:00
Joffrey JAFFEUX
05206a61ab
FIX: displays text of asset-version changed modal ( #7631 )
2019-05-29 15:38:14 +02:00
Guo Xiang Tan
f0620e7118
FEATURE: Support `[description|attachment](upload://<short-sha>)` in MD take 2.
...
Previous attempt was missing `post_uploads` records.
2019-05-29 09:26:32 +08:00
Joffrey JAFFEUX
76569b2018
FIX: ensures post-small-action is using timezone to display dates
2019-05-29 08:45:28 +08:00
Bianca Nenciu
43e33302e1
FIX: Position emoji-picker around d-editor.
2019-05-29 08:27:14 +08:00
Penar Musaraj
7c9fb95c15
Temporarily revert "FEATURE: Support `[description|attachment](upload://<short-sha>)` in MD. ( #7603 )"
...
This reverts commit b1d3c678ca
.
We need to make sure post_upload records are correctly stored.
2019-05-28 16:37:01 -04:00
Osama Sayegh
f3c07e27d9
FIX: correct translations for logs error rate notice ( #7622 )
...
The problem here is that hour and minute were passed to the %{duration} variable which made them impossible to translate in other languages.
I wonder if it's worth having 2 almost identical translations just for "reached" and "exceeded"? Perhaps we could combine them in one copy?
2019-05-28 22:10:51 +03:00
Bianca Nenciu
91ff8684fd
FIX: Use the right property for post ID.
2019-05-28 22:00:58 +03:00
Kris
67d8ceedf1
Remove unused variable
2019-05-28 14:31:52 -04:00
Kris
c57ab12238
UX: Move preview button to bottom right of mobile composer
2019-05-28 14:19:33 -04:00
Joffrey JAFFEUX
bc14452585
FIX: ensures events have access to correct context ( #7621 )
2019-05-28 19:40:28 +02:00
Guo Xiang Tan
b1d3c678ca
FEATURE: Support `[description|attachment](upload://<short-sha>)` in MD. ( #7603 )
2019-05-28 11:18:21 -04:00
Robin Ward
9bdfaa195e
FIX: We shouldn't memoize the last time something is read
2019-05-28 10:51:18 -04:00
Joffrey JAFFEUX
6decdfce5c
DEV: reduces memory footprint of tests - step 1 ( #7591 )
2019-05-28 12:15:12 +02:00
Penar Musaraj
dfcc2e7ad8
Revert "FEATURE: Send notification when member was accepted to group. ( #7503 )"
...
This reverts commit 42c82d544e
.
2019-05-27 15:19:59 -04:00
Penar Musaraj
c108131ad4
Revert "Fix JS error in group summary notification message"
...
This reverts commit b1268e00b8
.
2019-05-27 15:19:38 -04:00
Penar Musaraj
b1268e00b8
Fix JS error in group summary notification message
2019-05-27 14:54:51 -04:00
Robin Ward
d95a68b837
FEATURE: When suspending a user, allow the Delete + Replies action
...
Previously you could only delete the post
2019-05-27 12:27:16 -04:00
Joffrey JAFFEUX
192562745f
DEV: uses focus helper for d-editor tests ( #7610 )
2019-05-27 17:31:11 +02:00
Bianca Nenciu
42c82d544e
FEATURE: Send notification when member was accepted to group. ( #7503 )
2019-05-27 17:28:41 +03:00
Joffrey JAFFEUX
395f0ca126
FIX: attempts to prevent stacked-chart from being cut off ( #7608 )
2019-05-27 15:43:27 +02:00
Bianca Nenciu
e284b6e075
FIX: Update tags on change. ( #7581 )
2019-05-27 16:04:26 +03:00
Joffrey JAFFEUX
d93f753b17
apply prettier on gigantic find and replace ( #7604 )
2019-05-27 10:42:53 +02:00
Joffrey JAFFEUX
bfea922167
DEV: global s/this.get\("(\w+)"\)/this.$1 ( #7592 )
2019-05-27 10:15:39 +02:00
Dan Ungureanu
da39d66e83
DEV: Improve support for plugins. ( #7332 )
...
* DEV: Allow NewPostManager handlers handle PMs.
* DEV: Add custom fields topic option to PostCreator.
* DEV: Add topic_id to serializer data.
* DEV: Wrap topic title from notification item in a span.
2019-05-25 16:53:03 +03:00
Joffrey JAFFEUX
6398ded798
Revert "FIX: ensures selection is lookedup into async content ( #7586 )"
...
This reverts commit c238f0d223
.
2019-05-25 15:50:41 +02:00
Robin Ward
4b796eebe0
UX: Try tweaking how soon images are lazily loaded
2019-05-24 15:52:48 -04:00
Kris
dbd14a805c
UX: Wrap long names on user admin page
2019-05-24 13:39:16 -04:00
Penar Musaraj
963f6fbd40
Add icon for "Move to Inbox" footer button
2019-05-24 11:53:14 -04:00
Osama Sayegh
e20c30987c
FEATURE: detect theme errors and catch them ( #7589 )
...
* FEATURE: detect theme errors and catch them
* Bump COMPILER_VERSION
* Feedback
* Override eslint no console for one line
* Can't use our ajax method
* remove emoji from translation file
2019-05-24 17:25:55 +03:00
Joffrey JAFFEUX
049561ac49
FIX: introduces onSelectAny (regroup onSelect and onSelectNone) ( #7594 )
2019-05-24 13:11:33 +02:00
Gerhard Schlager
c1e9a70d59
FIX: Fallback locale was not available for extra translations
...
Translations from fallback locales were not sent to the client
for admin_js and wizard_js.
2019-05-24 11:38:26 +02:00
Guo Xiang Tan
1babc3bec6
Follow up to 3388872991
.
2019-05-24 09:02:39 +08:00
Kris
3388872991
UX: Separate section for 2FA settings, more consistent layout
2019-05-24 08:58:12 +08:00
Robin Ward
648af78298
FIX: Linting
2019-05-23 12:16:45 -04:00
Robin Ward
f73988acd2
Remove unused computed property.
2019-05-23 12:06:18 -04:00
Robin Ward
e74cd54fc6
REFACTOR: Replace score bonuses with low/med/high priorities
...
We removed score from the UX so it makes more sense to have sites set
priorities instead of score bonuses.
2019-05-23 11:54:45 -04:00
Régis Hanol
943fdc1762
make eslint happy
2019-05-23 12:51:40 +02:00
Régis Hanol
0cc81f95a5
FIX: popover should use target when no data attributes
2019-05-23 12:41:36 +02:00
Robin Ward
ca03baf2b2
UX: Hide pending score statuses
2019-05-22 11:26:17 -04:00
Joffrey JAFFEUX
cf63a9bb53
FIX: exception when pressing backspace on empty selection ( #7587 )
2019-05-22 17:18:46 +02:00
Joffrey JAFFEUX
c238f0d223
FIX: ensures selection is lookedup into async content ( #7586 )
2019-05-22 17:11:19 +02:00
Joffrey JAFFEUX
40c903ec23
FIX: ie11 exception on new category popup ( #7585 )
2019-05-22 15:17:28 +02:00
Gerhard Schlager
e224100023
FIX: Don't convert :) into Emoji when emojis or emoji shurtcuts are disabled
2019-05-22 11:44:39 +02:00
Joffrey JAFFEUX
0ed1cfd8d9
FIX: ensures we have an elementFromPoint before using it ( #7583 )
2019-05-21 21:26:54 +02:00
Joffrey JAFFEUX
236adc9ccb
FIX: shows parent category name in title anchor ( #7576 )
2019-05-21 08:33:22 +02:00
Osama Sayegh
0b5924d61e
Refactor keyboard shortcuts modal to fix RTL locales ( #7545 )
...
* Refactor keyboard shortcuts modal to fix RTL locales
* Feedback
* Remove lowercase modifier keys
2019-05-21 06:39:32 +03:00
Joffrey JAFFEUX
bc8c77723e
FIX: puts focus-event at application level ( #7568 )
...
Also attempts to use simpler and newer APIs
2019-05-20 13:48:03 +02:00
Gerhard Schlager
b788948985
FEATURE: English locale with international date formats
...
Makes en_US the new default locale
2019-05-20 13:47:20 +02:00
Joffrey JAFFEUX
9bbf421125
FIX: better node check for clickoutside in widgets ( #7573 )
2019-05-20 12:45:33 +02:00
Joffrey JAFFEUX
0ddfeb9c64
FIX: ensures mousetrap is reset with the application ( #7569 )
2019-05-20 10:45:31 +02:00
Joffrey JAFFEUX
b05d7042ae
FIX: prevents events on toolbar when in form ( #7567 )
...
If a button is not of type button, pressing enter inside an `<input>` inside a `<form>` without the action attribute will trigger the first available `<button>` as most browsers default the type of an unspecified button to submit.
This commit also prevents d-editor-modal to be filled when it's hidden.
2019-05-17 11:14:09 +02:00
Guo Xiang Tan
148bfc9be5
DEV: Simplify client and server side code to support removing tags.
...
Follow up to 834c86678f
.
2019-05-17 16:39:20 +08:00
David Taylor
5666316285
FEATURE: Display 'last updated' on dashboard, improve release notes link ( #7560 )
2019-05-17 15:42:45 +10:00
Sam Saffron
25137554ed
FIX: _.include is no longer imported from lodash
...
Instead use toArray and indexOf which is also clearer
2019-05-17 08:58:39 +10:00
Joffrey JAFFEUX
ad4d01233b
DEV: attempts to make d-editor tests more resilient ( #7556 )
2019-05-16 14:42:01 +02:00
Joffrey JAFFEUX
244c03573a
FIX: btn class was duplicated on admin-menu-buttons ( #7555 )
2019-05-16 14:37:53 +02:00
Joffrey JAFFEUX
0c6ebe66ce
EXPERIMENTAL: clicks outside seem unreliable with absolute nodes ( #7557 )
2019-05-16 14:37:37 +02:00
Régis Hanol
a5a4f9dc1a
DEV: make prettier happy
...
(cc @jjaffeux)
2019-05-16 11:38:47 +02:00
Joffrey JAFFEUX
d47bf8b6c4
SECURITY: updates lodash from 1.3.0 to 4.17.5 ( #7546 )
2019-05-16 10:34:19 +02:00
Régis Hanol
501bee56b7
Make prettier happy
2019-05-15 23:46:50 +02:00
Régis Hanol
db89722a98
UX: ignore leading/trailing whitespaces in site settings search
2019-05-15 22:22:20 +02:00
Bianca Nenciu
b9fcb2bcdf
DEV: Add before button hook in post-menu. ( #7550 )
2019-05-15 22:48:23 +03:00
Kris
a3f6c7d6af
REFACTOR: Remove table layout from modals, clean up styles ( #7549 )
2019-05-15 13:26:25 -04:00
Maja Komel
9a17b19636
FIX: don't hide back button at the bottom of timeline ( #7544 )
2019-05-15 19:02:48 +02:00
Joffrey JAFFEUX
d127119549
REFACTOR: user-selector take 2 ( #7540 )
2019-05-14 09:43:29 +02:00
Régis Hanol
7707d5db2d
Revert "REFACTOR: user-selector ( #7529 )"
...
This reverts commit 9a56df89f0
.
2019-05-13 19:39:30 +02:00
Robin Ward
fb1da53dff
FIX: Issue with incorrect heights when cloaking plugin content in posts
...
We noticed this with the house ads plugin. It inserted content after a
post, which was not taken into account when calculating and memoizing
the height of the element.
Co-authored-by: nlalonde
Co-authored-by: pmusaraj
2019-05-13 11:29:21 -04:00
Joffrey JAFFEUX
7326ddea6d
REFACTOR: tags mixin ( #7533 )
2019-05-13 17:05:21 +02:00
Joffrey JAFFEUX
b8db702a02
REFACTOR: admin-user-index route ( #7534 )
2019-05-13 17:04:41 +02:00
Joffrey JAFFEUX
717aa764b6
FIX: more efficient topic-footer-button-api ( #7535 )
2019-05-13 17:04:24 +02:00
Joffrey JAFFEUX
df18243827
FIX: prevents exception if report doest define filters ( #7532 )
2019-05-13 13:34:28 +02:00
Joffrey JAFFEUX
9a56df89f0
REFACTOR: user-selector ( #7529 )
2019-05-13 13:03:12 +02:00
Joffrey JAFFEUX
e64ed9dbc1
REFACTOR: edit-category controller ( #7527 )
2019-05-13 11:30:32 +02:00
Joffrey JAFFEUX
9b75320d63
FIX: track mutations on topic edit category-chooser only on select ( #7528 )
2019-05-13 10:22:28 +02:00
Penar Musaraj
a859ddc77e
Improve theme/component delete modal warning
2019-05-10 14:14:12 -04:00
Joffrey JAFFEUX
c093fa0376
PERF: reduces cpu/memory consumption of sk in some cases ( #7525 )
2019-05-10 17:12:10 +02:00
Joffrey JAFFEUX
4096d559b5
REFACTOR: user-stream model ( #7515 )
2019-05-10 10:05:43 +02:00
Joffrey JAFFEUX
a85b7feef4
REFACTOR: composer controller ( #7516 )
2019-05-10 10:05:29 +02:00
Joffrey JAFFEUX
7aedc92a35
REFACTOR: login-controller ( #7514 )
2019-05-10 10:05:11 +02:00
Gerhard Schlager
34684af195
FIX: Show error message if message exists
2019-05-09 22:12:51 +02:00
Robin Ward
b380ed5282
FEATURE: Claim Reviewables by Topic
...
This is a feature that used to be present in discourse-assign but is
much easier to implement in core. It also allows a topic to be assigned
without it claiming for review and vice versa and allows it to work with
category group reviewers.
2019-05-09 13:40:36 -04:00
Bianca Nenciu
ea3004ef11
UX: Save scroll position in tags topic list. ( #7511 )
2019-05-09 20:39:03 +03:00
Dan Ungureanu
c06b00a54e
FIX: Hide Uncategorized in site menu when disabled. ( #7509 )
2019-05-09 14:08:10 +03:00
Joffrey JAFFEUX
977ffa20f4
FIX: variable is different from key ( #7512 )
2019-05-09 10:03:33 +02:00
Arpit Jalan
427979e7e5
FEATURE: use full screen login by default for social login methods ( #7481 )
2019-05-09 10:03:01 +05:30
Guo Xiang Tan
8ec1f8cf07
DEV: Correct naming convention for JS file.
2019-05-09 10:18:29 +08:00
Maja Komel
24ca074f3f
FIX: short description title on client side when empty description
...
follow-up 77af097c
2019-05-08 17:07:12 +02:00
Joffrey JAFFEUX
54c2f24ee9
REFACTOR: composer model ( #7499 )
2019-05-08 16:53:12 +02:00
Joffrey JAFFEUX
4aaee7ee35
REFACTOR: change-timestamp controller ( #7498 )
2019-05-08 16:26:51 +02:00
Robin Ward
b409dab77f
Rename `flags_default_topics` to `reviewable_default_topics`
...
This functionality regressed with the reviewable update. I took the
opporunity to rename it when fixing it for clarity.
2019-05-08 10:07:10 -04:00
Maja Komel
77af097ce0
FIX: add short description to title on client side
2019-05-08 15:03:33 +02:00
David Taylor
b717e23ceb
FIX: Dynamically adjust scale when rendering wizard canvases
...
This was a typo in fd0de64
2019-05-08 13:14:28 +01:00
Bianca Nenciu
861023f0d6
FIX: Skip attachments in click track.
2019-05-08 11:55:31 +03:00
Guo Xiang Tan
46ea69a73c
UX: Initialize client side category model with right search_priority.
...
This is strictly a UX change since the default value of the column is 0.
2019-05-08 14:16:20 +08:00
Robin Ward
5af7c90bab
FEATURE: Hide Reviewable scores, change score filter to Priority
...
We found score hard to understand. It is still there behind the scenes
for sorting purposes, but it is no longer shown.
You can now filter by minimum priority (low, med, high) instead of
score.
2019-05-07 14:05:23 -04:00
Roman Rizzi
0a66065774
FIX: Move default options that were in the bufferedRender function. This will fix shortcut navigation for discourse-assign ( #7497 )
2019-05-07 12:25:10 -03:00
Penar Musaraj
446ec1b44a
Set input and textarea font size to 16px on iOS ( #7480 )
2019-05-07 10:44:43 -04:00
Bianca Nenciu
98a75906c8
FIX: Close topics deleted by users and ensure topic stubs are destroyed. ( #7430 )
2019-05-07 16:25:52 +03:00
Arpit Jalan
ed70595314
UX: add information about the use of permalinks
2019-05-07 17:13:26 +05:30
Bianca Nenciu
71fb8a4195
DEV: Fix failing click-track tests.
2019-05-07 13:54:12 +03:00
Joffrey JAFFEUX
4bbb34f7cb
REFACTOR: admin-user ( #7475 )
2019-05-07 10:53:21 +02:00
Joffrey JAFFEUX
f73ed45429
REFACTOR: color-scheme model ( #7477 )
2019-05-07 10:51:52 +02:00
Joffrey JAFFEUX
9507eff927
REFACTOR: resumable-upload ( #7474 )
2019-05-07 10:51:11 +02:00
Bianca Nenciu
4ff1195537
FEATURE: Use Beacon API for tracking clicks. ( #7483 )
2019-05-07 16:37:43 +10:00
Guo Xiang Tan
abbc639e0d
FIX: Only unregister service workers that belongs to Discourse.
2019-05-07 13:08:06 +08:00
Arpit Jalan
03169401ff
UX: correct order of site statistics on /about page
2019-05-07 09:50:41 +05:30
Robin Ward
47995d2d89
FIX: Your own likes were missing on posts
2019-05-06 20:03:50 -04:00
Robin Ward
31e100530f
FEATURE: Flag count in post menu
...
This change shows a notification number besides the flag icon in the
post menu if there is reviewable content associated with the post.
Additionally, if there is pending stuff to review, the icon has a red
background.
We have also removed the list of links below a post with the flag
status. A reviewer is meant to click the number beside the flag icon to
view the flags. As a consequence of losing those links, we've removed
the ability to undo or ignore flags below a post.
2019-05-06 16:13:31 -04:00
Dan Ungureanu
33e06dd796
FIX: Make select all and below skip small actions. ( #7425 )
2019-05-06 16:22:11 +03:00
Guo Xiang Tan
8217d5be78
UX: Switch mobile header back for 5s when notification comes in.
2019-05-06 16:58:25 +08:00
Guo Xiang Tan
ba3cf7109c
DEV: Remove unused lines of code.
2019-05-06 13:48:51 +08:00
Sam Saffron
267d129f38
FEATURE: only scroll to bottom for discobot
...
Non discobot replies on PMs triggering scroll cause confusion.
2019-05-06 10:55:58 +10:00
Robin Ward
99a2a769d4
FIX: Conflict error (version was already used)
2019-05-03 16:36:37 -04:00
Robin Ward
15c9b00307
FEATURE: Show edit indicator on review queue
...
If a flagged post has edits, show the pencil icon and pop up the history
window when clicked.
2019-05-03 11:21:33 -04:00
Joffrey JAFFEUX
5f78bbebe9
FIX: forces a reload of emoji list if clicked on more ( #7473 )
...
This is a bit hacky but it's much more simple and reliable than many other solutions and doesnt involve having to manage some variable state.
2019-05-03 16:11:03 +02:00
Penar Musaraj
b948d97c8f
FEATURE: Show diff of local changes before updating remote theme ( #7443 )
2019-05-02 21:43:54 -04:00
Robin Ward
3cb0d27d38
DEV: Upgrade our widget handlebars compiler
...
Now supports subexpressions such as i18n and concat, plus automatic
attaching of widgets similar to ember.
2019-05-02 15:47:57 -04:00
Joffrey JAFFEUX
e696903c31
FIX: uses translatedTitle to check validity of topic footer btn ( #7472 )
2019-05-02 20:56:27 +02:00
Joffrey JAFFEUX
75591664e7
FIX: better handling of category filter deselection ( #7468 )
2019-05-02 10:03:12 +02:00
Guo Xiang Tan
d5c9ac7196
PERF: Use cdn when serving site settings upload.
2019-05-02 15:35:07 +08:00
Guo Xiang Tan
24347ace10
FIX: Properly associate user_profiles background urls via upload id.
...
`Upload#url` is more likely and can change from time to time. When it
does changes, we don't want to have to look through multiple tables to
ensure that the URLs are all up to date. Instead, we simply associate
uploads properly to `UserProfile` so that it does not have to replicate
the URLs in the table.
2019-05-02 14:58:24 +08:00
Sam Saffron
157dc5e298
FEATURE: disable native share API on non tablets/phones
...
Native share API works fantastically on phones/tablets but on full desktop
it is confusing.
2019-05-02 13:18:29 +10:00
Arpit Jalan
b5ea50a154
FIX: use full screen login for new-topic route ( #7467 )
...
DEV: add javascript tests for new-topic and new-message routes
DEV: fix an existing test that was being skipped
2019-05-01 22:54:29 +05:30
Vinoth Kannan
7869a10d18
Revert "FEATURE: Added unlisted topics option to advanced search ( #7447 )"
...
This reverts commit 539723f8ff
since it is failing the build.
2019-05-01 21:06:20 +05:30
Joffrey JAFFEUX
ae493f4722
UX: fills picker with emoji autocomplete state on `more` click ( #7466 )
2019-05-01 16:19:45 +02:00
David Taylor
0e303c7f5d
FEATURE: Automatically generate optimized site metadata icons ( #7372 )
...
This change automatically resizes icons for various purposes. Admins can now upload `logo` and `logo_small`, and everything else will be auto-generated. Specific icons can still be uploaded separately if required.
## Core
- Adds an SiteIconManager module which manages automatic resizing and fallback
- Icons are looked up in the OptimizedImage table at runtime, and then cached in Redis. If the resized version is missing for some reason, then most icons will fall back to the original files. Some icons (e.g. PWA Manifest) will return `nil` (because an incorrectly sized icon is worse than a missing icon).
- `SiteSetting.site_large_icon_url` will return the optimized version, including any fallback. `SiteSetting.large_icon` continues to return the upload object. This means that (almost) no changes are required in core/plugins to support this new system.
- Icons are resized whenever a relevant site setting is changed, and during post-deploy migrations
## Wizard
- Allows `requiresRefresh` wizard steps to reload data via AJAX instead of a full page reload
- Add placeholders to the **icons** step of the wizard, which automatically update from the "Square Logo"
- Various copy updates to support the changes
- Remove the "upload-time" resizing for `large_icon`. This is no longer required.
## Site Settings UX
- Move logo/icon settings under a new "Branding" tab
- Various copy changes to support the changes
- Adds placeholder support to the `image-uploader` component
- Automatically reloads site settings after saving. This allows setting placeholders to change based on changes to other settings
- Upload site settings will be assigned a placeholder if SiteIconManager `responds_to?` an icon of the same name
## Dashboard Warnings
- Remove PWA icon and PWA title warnings. Both are now handled automatically.
## Bonus
- Updated the sketch logos to use @awesomerobot's new high-res designs
2019-05-01 14:44:45 +01:00
Arpit Jalan
c6409fd2cc
FIX: pass correct date arguments to server when exporting CSV
2019-05-01 10:46:30 +05:30
Arpit Jalan
002e1f560a
FIX: initialize empty object if no custom filters are present
2019-05-01 10:27:19 +05:30
Tim Lange
539723f8ff
FEATURE: Added unlisted topics option to advanced search ( #7447 )
2019-05-01 12:31:13 +10:00
Robin Ward
404b35bd04
FEATURE: Category Reviewable by Group
...
Allow a group to review content in a particular category.
2019-04-30 15:23:06 -04:00
Robin Ward
dd29af4475
REFACTOR: `{{avatar}}` and `{{date}}` helpers in vdom templates
...
This is a step towards a nicer flag display under posts.
2019-04-30 15:22:38 -04:00
Roman Rizzi
404666c9e9
DEV: Export the default behaviour of a topic-list-item so it can be reused by the discourse-assign plugin ( #7433 )
2019-04-30 15:36:54 -03:00
David Taylor
583226d295
FIX: Linking to `/new-topic` from `/latest`
...
`/new-topic` redirects back to `/latest`, so the ember router considers this to be a 'refresh'. This triggers the `resetParams()` logic, which would cause the transition to abort, and the composer would never open.
This commit fixes the `resetParams()` logic so that it uses the default values, instead of setting everything to `null`. Therefore the transition is no longer aborted, and the composer opens successfully.
Unfortunately I have not been able to reproduce the issue in a QUnit test.
2019-04-30 16:25:25 +01:00
Joffrey JAFFEUX
8e68244eea
FIX: prevents google to track certain pages ( #7463 )
2019-04-30 15:57:51 +02:00
Joffrey JAFFEUX
726dd0fe37
Revert "FIX: prevents google to track certain pages ( #7455 )"
...
This reverts commit c863e62998
.
2019-04-30 10:17:12 +02:00
Joffrey JAFFEUX
c863e62998
FIX: prevents google to track certain pages ( #7455 )
2019-04-30 13:59:55 +08:00
Guo Xiang Tan
dca7f8ecf2
FIX: Loading more broken on groups page.
...
Regressed in 1f17d52f55
.
2019-04-30 10:35:17 +08:00
Neil Lalonde
a00354f11f
Prettier site-settings/group-list.js.es6
2019-04-29 16:26:13 -04:00
Neil Lalonde
1ba72ccab8
DEV: add site setting type group_list for a list of groups
...
Add a js test
2019-04-29 16:15:22 -04:00
Penar Musaraj
b75720d911
FIX: skip click-tracking for mentions
2019-04-29 12:05:47 -04:00
Joffrey JAFFEUX
5768011cad
FIX: prevents exception in the composer with regexp flags
2019-04-29 16:58:17 +02:00
Penar Musaraj
629ae7a5b7
FIX: Revert tracking links in quotes
2019-04-29 10:30:04 -04:00
Bianca Nenciu
aef35faefc
FIX: Open links in external tabs. ( #7444 )
2019-04-29 10:27:29 -04:00
Penar Musaraj
ca9fd95a08
FIX: Respect "open external links in new window" in quotes and edit history
2019-04-29 10:13:53 -04:00
Joffrey JAFFEUX
286f2abc65
FIX: prevents exception when clicking directly on site text
2019-04-29 12:07:30 +02:00
Tim Lange
574f39f9d0
FIX: Fixed uploadPlaceholder regex failing on not escaped characters ( #7442 )
2019-04-29 12:32:48 +10:00
Joffrey JAFFEUX
6952510fc4
FIX: restores skipHeader computed property
2019-04-26 23:43:49 +02:00
Tim Lange
1486328756
UX: Changed post stream placeholder to animation ( #7434 )
2019-04-26 17:29:48 +01:00
Joffrey JAFFEUX
bcca2b5d73
FEATURE: initial implementation of generic filters for reports
2019-04-26 12:17:10 +02:00
Maja Komel
4b455e741e
DEV: Ember 3.8.0
...
Co-Authored-By: majakomel <maja.komel@gmail.com>
2019-04-26 12:16:21 +02:00
Vinoth Kannan
be0ae2e487
FIX: plain text table detection should work even if html content not found.
2019-04-26 11:16:41 +05:30
Vinoth Kannan
dc2ee78f7a
UX: Only do plain text table detection in outside code if HTML pasting enabled
...
Co-authored-by: Tim Lange <tim.lange@titanhq.de>
PR: https://github.com/discourse/discourse/pull/7436
2019-04-26 09:20:21 +05:30
romanrizzi
34b772575e
FIX: Return 'failed' attribute when catching an ajax error and the attribute is present
2019-04-25 14:49:52 -03:00
Joffrey JAFFEUX
7cbc4c1e46
FIX: uses no tags label for tag-drop header ( #7438 )
2019-04-25 13:16:06 +02:00
Joffrey JAFFEUX
e386fa7674
FIX: ensures we have touches when starting pan event ( #7435 )
2019-04-25 10:36:41 +02:00
Tarek Khalil
d8ff94ecaa
FEATURE: Ignoring users from the preferences page in a cleaner way ( #7289 )
...
* FEATURE: Ignoring users from the preferences page in a cleaner way
2019-04-25 09:26:49 +01:00
Dan Ungureanu
3aa143a52c
SECURITY: Fix tab nabbing.
2019-04-25 00:11:28 +03:00
Tarek Khalil
e4d8d80cf8
FIX: Make sure we hide the first post in a topic by an ignored user ( #7428 )
2019-04-24 16:00:20 +01:00
Penar Musaraj
1a8c6577e0
FIX: refactor padding when exiting composer
...
Previously, when existing composer, the `#main-outlet` element padding was set to zero. This inline style would override any CSS set for that element, causing issues with the mobile footer nav.
The fix removes the inline padding style instead of setting it to zero. It also uses integers for the set values, and removes a duplicate style.
2019-04-24 10:26:35 -04:00
Tarek Khalil
ad61d87ffb
FIX: Do not replace text of collapsed ignore posts ( #7422 )
2019-04-24 13:54:46 +01:00
Penar Musaraj
a452933071
FIX: disable input zoom on search in iOS
2019-04-24 08:41:20 -04:00
Tim Lange
104a9e79f9
UX: User card loading ( #7404 )
2019-04-24 11:55:09 +03:00
Joffrey JAFFEUX
7334362b77
FEATURE: generic theme component bbcode wrapper ( #7400 )
...
Usage:
```
[wrap=name foo=bar]
hello world
[/wrap]
```
2019-04-24 10:37:34 +02:00
Bianca Nenciu
b9339e15a1
FIX: Do not track a elements with no href.
2019-04-23 23:13:23 +03:00
Bianca Nenciu
b81d169e2a
FIX: Do not track user mentions.
2019-04-23 23:08:00 +03:00
Joffrey JAFFEUX
c99faa6b25
FIX: improves locale support in tag-drop ( #7418 )
2019-04-23 17:53:59 +02:00
Joffrey JAFFEUX
d4e788c136
FIX: improves share/invite behavior on mobile and especially iOS ( #7416 )
2019-04-23 17:07:31 +02:00
Tarek Khalil
dc60128355
FIX: Hide ignoring users in preference for users with TL less than a member ( #7415 )
...
* FIX: Hide ignoring users in preference for users with TL less than a member
2019-04-23 14:47:37 +01:00
Gerhard Schlager
a7bc1ecbae
FEATURE: Add support for Unicode usernames and group names
...
Co-authored-by: Joffrey JAFFEUX <j.jaffeux@gmail.com>
2019-04-23 13:00:27 +02:00
Bianca Nenciu
1867f2dda0
FEATURE: Always track clicks using AJAX. ( #7373 )
2019-04-23 12:41:36 +03:00
Dan Ungureanu
c048b71b29
UX: Replace staff notice icon with user-shield.
2019-04-23 10:37:33 +03:00
Guo Xiang Tan
3ac18b92b3
UX: Editing theme name stays active when switching themes.
...
* Also fix length of input field.
2019-04-23 14:57:14 +08:00
Bianca Nenciu
58fe45ffd9
UX: Do not close login modal and search menu on outside mouse up event. ( #7366 )
2019-04-23 13:01:44 +10:00
Arpit Jalan
a63ef4cfc8
FEATURE: better wizard privacy controls ( #7391 )
2019-04-22 19:47:29 +05:30
Dan Ungureanu
f112f279ae
UX: Reorder post admin actions for greater consistency.
2019-04-22 10:57:14 +03:00
Guo Xiang Tan
caeb035b61
FIX: Automatic scrolling in PM not working.
...
See https://stackoverflow.com/questions/18779708/scrolltop-with-animate-not-working
2019-04-22 10:52:46 +08:00
Joffrey JAFFEUX
151da50e7c
FIX: prevents exception when the node doesnt exist anymore ( #7408 )
2019-04-19 18:27:23 +02:00
Dan Ungureanu
57d1dea8a2
FEATURE: Let staff add custom post notices. ( #7377 )
2019-04-19 17:53:58 +03:00
Joe
b150a57383
UX: don't clip staff shield in user cards ( #7398 )
2019-04-19 01:53:23 -07:00
Régis Hanol
19905e587b
Revert "UX: Show user card on load ( #7380 )" ( #7403 )
...
This reverts commit 66789d73c9
.
2019-04-19 10:45:25 +02:00
Tim Lange
66789d73c9
UX: Show user card on load ( #7380 )
2019-04-19 09:20:03 +02:00
Tim Lange
1d0816b2cf
UX: Changed error draft status to icon ( #7369 )
2019-04-19 09:18:01 +02:00
Kris
cbe7166d87
UX: Move total user count
2019-04-19 00:35:50 -04:00
Robin Ward
85d8d5d092
FIX: Lint
2019-04-18 13:49:28 -04:00
Robin Ward
8e77b4d58e
FIX: Replace references to flags in the header with review
2019-04-18 13:25:23 -04:00
Sam Saffron
7068b58e85
PERF: flush topic timings less frequently
...
This is a first step of a performance optimisation, more will follow
Previously we did not properly account for previously read topics while
"rushing" marking times on posts.
The new mechanism now avoids "rushing" sending timings to server if all
the posts were read.
Also to alleviate some server load we only "ping" the server with old timings
once a minute (it used to be every 20 seconds)
2019-04-18 17:31:08 +10:00
Maja Komel
1f17d52f55
UX: new layout for groups page, allow changes to automatic group bio ( #7350 )
2019-04-17 22:44:30 -04:00
Robin Ward
cd2e93b598
FIX: Show when a post has been deleted in the flag review queue
2019-04-17 16:14:36 -04:00
Joe
ee808dc682
UX: replace lightbox loading text with spinner ( #7393 )
2019-04-17 10:24:03 -07:00
Dannii Willis
16bfc29164
Move the trend icons on the admin dashboard inside the span ( #7367 )
...
so that it will have the tooltip as well
2019-04-17 18:11:01 +10:00
Maja Komel
5c795bc480
FIX: prevent anonymous users from changing their email/username/name ( #7311 )
2019-04-17 18:05:02 +10:00
Gerhard Schlager
7e8579b8aa
UX: Add translations for lightbox
2019-04-16 17:03:01 +02:00
Joffrey JAFFEUX
5ec19987b4
FIX: attempts to fix a regression making touchs on emojis less reliable ( #7383 )
2019-04-16 12:31:33 +02:00
Guo Xiang Tan
347663e852
UX: Switch ellipsis direction when expanding web hook event details.
2019-04-16 14:28:23 +08:00
Robin Ward
3ceff0a92a
FEATURE: Send the user a notification when their post is approved
2019-04-15 16:20:16 -04:00
Penar Musaraj
de10bd7fb4
UI: Footer nav fixes
...
- moves footer nav to the header on iPads
- disables scrolling events for iPads
- removes footer nav entirely on Chrome PWAs
- toggles DiscourseHub iOS app status bar styling (dark/light) when opening/closing lightboxes and modals
2019-04-15 15:25:40 -04:00
Robin Ward
fca3044b10
UX: When editing a reviewable, show created_by
2019-04-15 15:11:34 -04:00
Robin Ward
d859e1594e
UX: Add a description for scores
2019-04-15 14:21:25 -04:00
Kris
4b74525446
FIX: Group requests page missing wrapper
2019-04-15 14:16:02 -04:00
Penar Musaraj
14eb8eea01
FIX: Prevent input zooming in iOS
...
Since enabling pinch-to-zoom in iOS (eae22548de
), there was an issue with inputs: Safari auto-zooms inputs with font-size under 16px. Now zooming will be disabled while focus is on an input.
This commit also removes a) a lightbox zoom-enabling event (no longer needed) and b) a comment about iOS zoom issues.
2019-04-15 13:05:43 -04:00
David Taylor
fd0de64e0d
UX: Render wizard previews for high-DPI displays ( #7371 )
...
* UX: Render wizard previews for high-DPI displays
Sets up a canvas element of twice the required dimensions, scales all coordinates by 2x, then shrinks the display in css.
* Use window.devicePixelRatio to determine scale factor
2019-04-15 16:16:05 +10:00
Tim Lange
00ee68f799
FIX: Fixed category reordering using arrow icons ( #7374 )
2019-04-15 10:56:21 +10:00
Robin Ward
a5d9afe397
FEATURE: Include a user's pending posts in the topic view
...
Also includes a refactor to TopicView's serializer which was not
building our attributes using serializers properly.
2019-04-12 14:25:12 -04:00
Penar Musaraj
51630b5187
Footer nav tweaks
2019-04-12 12:29:54 -04:00
David Taylor
268d4d4c82
FEATURE: Multiple SCSS file support for themes ( #7351 )
...
Theme developers can include any number of scss files within the /scss/ directory of a theme. These can then be imported from the main common/desktop/mobile scss.
2019-04-12 11:36:08 +01:00
Dan Ungureanu
0e9a0a31f5
FIX: Show email for staged users in user cards. ( #7354 )
2019-04-12 12:50:43 +03:00
Sam Saffron
9bd3afda5d
FIX: display conextual count on favicon if selected
...
This also corrects the test suite and moves the two notification counts
so they are closer together.
2019-04-12 10:04:23 +10:00
David Taylor
24ef4f7b2b
Remove support for disable_jump_reply user setting ( #7359 )
2019-04-12 09:03:06 +10:00
David Taylor
dc703adad7
FEATURE: Add user preference for title counter mode ( #7364 )
2019-04-12 09:02:18 +10:00
Penar Musaraj
60db57acc0
Make Prettier happy
2019-04-11 14:15:47 -04:00
Penar Musaraj
f060c9b3ff
UI: improvements to footer nav for app and PWAs
...
Adds support for iPad and Chrome PWAs
Better scroll direction logic when reaching bottom of the page
2019-04-11 14:11:26 -04:00
Robin Ward
331a809738
FEATURE: Display the reason for many reviewable items
...
Queued Posts and Users will now display a reason why they are in the
review queue.
2019-04-11 12:04:45 -04:00
Arpit Jalan
7143572e0c
FIX: correctly retrieve 'login required' setting value on wizard ( #7355 )
...
* FIX: correctly retrieve 'login required' setting value on wizard
FEATURE: extract 'invite only' setting in a separate checkbox control
* Update invite_only checkbox locale on wizard.
Co-Authored-By: techAPJ <arpit@techapj.com>
2019-04-11 20:25:08 +05:30
Tim Lange
9a428acce4
UX: Switched composer draft saving to animations ( #7356 )
2019-04-11 10:03:36 -04:00
Joffrey JAFFEUX
7226240df3
UX: full revamp of local-dates form ( #7357 )
2019-04-11 11:14:34 +02:00
Kris
abd34882d5
UX: Better organization of category settings
2019-04-10 23:00:31 -04:00
Dan Ungureanu
7a7c6af21e
FIX: Fallback to last post when the in-view post cannot be detected.
...
In certain situations the detection method fails. For example, it fails
for a topic containing: a long post (~1600px height), gap, small action
(focus on this), hidden reply.
2019-04-11 01:14:59 +03:00
Kris
689c7f5410
Minor reviewable alignment fixes
2019-04-10 14:22:46 -04:00
Kris
1b6f18396b
UX: Simplify merged reviewable table
2019-04-10 13:22:28 -04:00
Tim Lange
fe9c271d44
FIX: Fixed deleted posts layout ( #7348 )
2019-04-10 19:00:39 +02:00
Penar Musaraj
eae22548de
Footer navigation for iOS PWAs and DiscourseHub app ( #7347 )
2019-04-10 12:23:18 -04:00
Roman Rizzi
536b90e0ef
FEATURE: Support searching custom staff actions ( #7346 )
2019-04-10 09:53:17 -03:00
Tarek Khalil
442fb2facb
FEATURE: Remove ignore feature SiteSetting and enable ignore by default ( #7349 )
2019-04-10 12:54:59 +02:00
Roman Rizzi
82e051077d
Show link to the original topic when it was deleted ( #7319 )
...
* Moved i18n keys to core. We show a links that points to the original topic when it was deleted
* Use link-to since it's more idiomatic
2019-04-10 11:25:45 +02:00
Bianca Nenciu
b5008586c5
DEV: Remove HTML parser from Tautologistics. ( #7344 )
2019-04-10 11:21:22 +02:00
Sam Saffron
88f8c9f43e
FIX: when banner is removed update all clients
...
Previously removing a banner raised a null "banner" in the message bus
channel.
Then Ember.Object.create would fail cause it always expects an object in
constructor.
2019-04-10 15:59:29 +10:00
Kris
df85d4593e
UX: Unify admin intro styles for badges/customize, improve mobile
2019-04-09 20:32:24 -04:00
Robin Ward
9ebfdaa356
UX: Unify reviewable scores + history
2019-04-09 16:43:08 -04:00
Kris
8e9d0ceb67
UX: Mobile - fix editor button space, divider, extra upload icon
2019-04-09 13:15:31 -04:00
Tarek Khalil
307499e48b
FIX: Keep highlighted text for quoted replies by ignored users ( #7345 )
2019-04-09 17:33:12 +02:00
Robin Ward
4552d86605
FIX: Broken tests
2019-04-09 08:33:10 -04:00
Joffrey JAFFEUX
a89c90ed5d
FIX: removes link to old dashboard ( #7341 )
2019-04-09 09:24:41 +02:00
Vinoth Kannan
f0f659286f
UX: move up profile picture field next to the username
2019-04-09 11:46:03 +05:30
Robin Ward
bc949cf684
FIX: Display the username instead of {{username}}
2019-04-08 16:46:05 -04:00
Robin Ward
32a0346069
UX: Don't show the username of the first user in the conversation
2019-04-08 16:39:53 -04:00
Robin Ward
cc53f902c6
FIX: Missing translation key for Reviewable -> Deleted
2019-04-08 16:12:41 -04:00
Robin Ward
0fc798c2ef
UX: Show the score status
...
If a review review score has been Approved/Rejected/Ignored then show it
2019-04-08 12:08:18 -04:00
Tarek Khalil
5957991340
FIX: Remove quoted post text and block realtime replies from ignored users ( #7336 )
2019-04-08 17:44:42 +02:00
Tarek Khalil
02394e9170
FIX: assign `decoratorHelper` ( #7338 )
2019-04-08 16:17:09 +01:00
Joffrey JAFFEUX
9d2e2867cc
s/fa-icon/d-icon ( #7337 )
2019-04-08 15:51:38 +02:00
Tarek Khalil
0d2a1fce51
REFACTOR: Pass down `currentUser` to `post-cooked` widget ( #7333 )
...
* REFACTOR: Pass down `currentUser` to `post-cooked` widget
2019-04-08 14:50:53 +01:00
David Taylor
f524f8f811
Remove Yahoo login support from core and deprecate OpenID2.0 ( #7310 )
...
- Plugin developers using OpenID2.0 should migrate to OAuth2 or OIDC. OpenID2.0 APIs will be removed in v2.4.0
- For sites requiring Yahoo login, it can be implemented using the OpenID Connect plugin: https://meta.discourse.org/t/103632
For more information, see https://meta.discourse.org/t/113249
2019-04-08 10:38:25 +01:00
Vinoth Kannan
ca57e18f42
UX: display signup cta even if 'must_approve_users' setting enabled.
2019-04-08 12:27:56 +05:30
Guo Xiang Tan
33fa249fa5
SECURITY: Remove XSS in composer preview when applying image scale buttons.
2019-04-08 11:22:14 +08:00
Robin Ward
a6f283da30
UX: Show tags on flags too
2019-04-05 14:22:45 -04:00
Régis Hanol
06e3b25d04
FIX: 'currentUser' is a property of the 'widget'
2019-04-05 18:43:04 +02:00
Robin Ward
b005a84530
FIX: `decoratorHelper.widget` is not always present
2019-04-05 12:07:24 -04:00
Kris
acce7330a3
Typo fix
2019-04-05 11:23:22 -04:00
Kris
43a905279f
FIX: Layout was off in single-page user-preferences
2019-04-05 10:59:52 -04:00
Robin Ward
cbc311e4ed
UX: Update the reviewable count before the message bus
...
In certain edge cases, the message bus won't send the message to the
user about the updated review count and it can go out of sync.
This patch synchronizes the review count every time:
1. The user visits the "Needs Review" page
2. Every time the user performs an action
2019-04-05 10:35:38 -04:00
Tarek Khalil
19a1d35f66
fix linting ( #7329 )
2019-04-05 15:28:41 +01:00
Tarek Khalil
131eba0366
FIX: Hide post replies content for ignored users ( #7320 )
2019-04-05 16:13:36 +02:00
Joffrey JAFFEUX
0bd480c600
UX: displays exact date on title attribute of topic timer info ( #7326 )
2019-04-05 09:44:10 +02:00
Angus McLeod
6f1652bb53
add header cloak after all panels are added ( #7325 )
2019-04-04 22:54:05 -07:00
Robin Ward
aa4a38b08a
FIX: computed is not used
2019-04-04 17:38:27 -04:00
Neil Lalonde
83996fc8ea
FEATURE: ability to restrict some tags to a category while allowing all others
...
A new checkbox has been added to the Tags tab of the category settings modal
which is used when some tags and/or tag groups are restricted to the category,
and all other unrestricted tags should also be allowed.
Default is the same as the previous behaviour: only allow the specified set of
tags and tag groups in the category.
2019-04-04 16:40:15 -04:00
Kris
9faebfcfe0
UX: Adjust layout, allow additional responsiveness
2019-04-04 16:20:25 -04:00
Robin Ward
dd5b8bd85e
FIX: Show replies to the post, not the topic
...
This makes more sense when reviewing. How many people replied to this
objectionable thing?
2019-04-04 15:13:59 -04:00
Robin Ward
9c8cc73c39
UX: Show user fields when reviewing a user
2019-04-04 14:45:40 -04:00
Robin Ward
a5182b0d6c
FIX: Rewrite old `/admin/flags` links to use the review queue
...
Such links might be in present in old PMs. For example, a notification of
outstanding flags.
New PMs should receive the correct link but this prevents 404s in the
other case.
2019-04-04 10:15:23 -04:00
Bianca Nenciu
63fcd445f4
FIX: Use unfiltered URL when viewing all badges.
2019-04-04 12:35:03 +03:00
Robin Ward
a4ff593506
UX: Slightly improved reviewable user display, plus link to admin if possible
2019-04-03 17:07:48 -04:00
Robin Ward
111a502231
FIX: Deleting Users should work nicely with Reviewable Users
...
"Rejecting" a user in the queue is equivalent to deleting them, which
would then making it impossible to review rejected users. Now we store
information about the user in the payload so if they are deleted things
still display in the Rejected view.
Secondly, if a user is destroyed outside of the review queue, it will
now automatically "Reject" that queue item.
2019-04-03 16:42:39 -04:00
Joffrey JAFFEUX
974007a3cc
FIX: reverts href removal from user/group cards links ( #7318 )
2019-04-03 19:16:48 +02:00
Bianca Nenciu
bb2005d466
FIX: Add more links to bandge cards.
2019-04-03 18:37:11 +03:00
Robin Ward
62956003c3
FEATURE: Allow users to customize bonuses for reviewable types
...
A new settings section in the review queue allows admins to specify that
certain types of flags should be weighted higher than others.
2019-04-03 11:18:34 -04:00
Bianca Nenciu
1e1adb1afa
FIX: Links in badge summary were not clickable. ( #7303 )
2019-04-03 11:35:27 +02:00
Maja Komel
d32aaf374e
UX: add awaiting-approval class to login modal
...
when local logins are disabled and account is awaiting approval
2019-04-03 11:30:43 +02:00
Guo Xiang Tan
d1fa2b71cf
FIX: Letters between words incorrectly highlighted within post.
2019-04-03 15:57:51 +08:00
Kris
14cbbc5e13
UX: Reviewables fixes
2019-04-02 16:25:53 -04:00
Penar Musaraj
44fe2eec03
Better fix for Safari user card position
...
Better than a2c6683e3b
2019-04-02 15:36:47 -04:00
Kris
ba727b2875
UX: Restructure queued posts to match flags, fix text
2019-04-02 14:54:55 -04:00
Kris
2ab6eb58c5
UX: Reviewable layout improvements
2019-04-02 13:51:03 -04:00
Penar Musaraj
15e27d9e2c
Prettier fix
2019-04-02 11:56:21 -04:00
Joffrey JAFFEUX
40e1ba9d9a
FIX: ensures click on emoji in picker doesnt propagate ( #7308 )
2019-04-02 17:40:13 +02:00
Joffrey JAFFEUX
d8dd130477
UX: gives aria-label to topics count in category-row ( #7307 )
2019-04-02 17:38:21 +02:00
Joffrey JAFFEUX
e77b1cf7ff
UX: ensures only <li> are used as top level in breadcrumb ( #7306 )
2019-04-02 17:37:53 +02:00
Penar Musaraj
a2c6683e3b
FIX: inconsistent user card position in Safari
...
User cards triggered in header were incorrectly positioned in Safari desktop.
Using `position()` instead of `offset()` is more consistent, since header is a fixed element in this scenario.
2019-04-02 10:32:50 -04:00
Arpit Jalan
d68d29f37a
FIX: only staff can banner topics
2019-04-02 12:46:55 +05:30
Tim Lange
a9a35d2c19
FIX: Uncategorized pm not allowing edit ( #7276 )
2019-04-02 12:54:53 +08:00
Guo Xiang Tan
4175de5071
UX: Wrap title on search log term page with a proper div.
...
Search log filter selector was not floating right as it should.
2019-04-02 11:55:57 +08:00
Guo Xiang Tan
1a9452f24d
UX: Pass period params when looking at search logs for a given term.
2019-04-02 11:51:41 +08:00
Kris
9603c906ec
Moving staff counters back to the top of profiles
2019-04-01 21:04:37 -04:00
Robin Ward
6470c85fda
UX: Link directly to the post, not to the topic
2019-04-01 14:29:14 -04:00
Penar Musaraj
fdf4145d4b
FEATURE: Delegated authentication via user api keys ( #7272 )
2019-04-01 13:18:53 -04:00
Joffrey JAFFEUX
13a6a04cad
FIX: ensures popover is hidden when changing route ( #7300 )
2019-04-01 16:23:57 +02:00
Joffrey JAFFEUX
4b1b135ede
FIX: handles boolean with popupMenuOption ( #7299 )
...
Handle the case of https://github.com/discourse/DiscoTOC doing this kind of setup:
```
return {
action: "insertDtoc",
icon: "align-left",
label: themePrefix("insert_table_of_contents"),
condition: !composerController.get("model.canCategorize")
};
```
In this case there's no function to call, it's already set.
2019-04-01 16:08:14 +02:00
Joffrey JAFFEUX
e986e96227
DEV: removes old dashboard ( #7295 )
2019-04-01 12:39:49 +02:00
Joe
541a15e357
UX: user-card adjustments for users with hidden profiles ( #7293 )
...
* adds styles for profile hidden message
* Disable profile links for hidden profiles and add message to indicate the profile is hidden
2019-04-01 10:50:48 +02:00
Dan Ungureanu
d59abff2d8
UX: Always use relative age for post notices.
2019-03-31 18:07:05 +03:00
Joe
8b8d528b88
Hide mobile cards when user scrolls ( #7291 )
2019-03-31 11:16:52 +02:00
Robin Ward
c0780434f8
FIX: Better display if the topic is deleted
2019-03-29 16:59:00 -04:00
Robin Ward
a55e7ebe8f
UX: Better display for deleted users in the review queue
2019-03-29 16:52:58 -04:00
Robin Ward
67454c71c9
FIX: Missing translations for agree/disagree details
2019-03-29 14:14:59 -04:00
Kris
814aee343b
UX: Minor profile page restructure
2019-03-29 12:52:42 -04:00
Tim Lange
2c4b3c21a9
UX: Unified emoji escape regex
2019-03-29 12:17:11 -04:00
Bianca Nenciu
31053f30de
FEATURE: Let users delete their own topics. ( #7267 )
2019-03-29 17:10:05 +01:00
Tarek Khalil
d26d1b387e
FEATURE: Add ignore duration selection for user notifications preferences page ( #7269 )
...
* FEATURE: Introducing new UI for tracking User's ignored or muted states
2019-03-29 13:33:08 +00:00
Tarek Khalil
b1cb95fc23
FEATURE: Introduce ignore duration selection ( #7266 )
...
* FEATURE: Introducing new UI for tracking User's ignored or muted states
2019-03-29 10:14:53 +00:00
Guo Xiang Tan
a6d93f6317
FIX: Avoid error on ajax.abort() when client has not opened the request.
2019-03-29 15:38:38 +08:00
Guo Xiang Tan
8cfd887f33
Make eslint happy.
2019-03-29 12:59:40 +08:00
Guo Xiang Tan
4fa8fe575b
UX: Use a step size of 1.
...
Follow up to 634a213e6d
.
2019-03-29 12:14:11 +08:00
Guo Xiang Tan
634a213e6d
FIX: Admin chart y axis labels being rounded up/down when value is small.
2019-03-29 12:03:41 +08:00
Guo Xiang Tan
e2ad374e5b
UX: USe bar chart for admin search logs details page.
...
A bar chart is better when comparing the values across the X axis.
2019-03-29 11:54:49 +08:00
Guo Xiang Tan
947495e70d
Follow up to 8c2fa99f78
.
...
`/search_logs/term?term` is alittle weird looking but unless we add
proper slug support to term, we're going to have to live with this
first.
2019-03-29 10:39:44 +08:00
Guo Xiang Tan
c42df7ddd7
UX: Use the same default period for search logs index and term.
...
If the period is different, clicking through to view a term is confusing
because a different period will show a different set of stats.
2019-03-29 09:59:28 +08:00
Guo Xiang Tan
8c2fa99f78
FIX: Remove `:term` from `admin/search_logs/term/:term` route.
...
Search log terms is a string that can contain characters like `/` which
messes with the route.
2019-03-29 09:48:20 +08:00
Guo Xiang Tan
c836d67cac
UX: Collapse advanced search on mobile when searching.
...
On smaller mobile devices, the height of the advanced search filters takes up
the whole real estate that it requires the user to scroll down
significantly in order to view the results.
2019-03-29 08:59:02 +08:00
Robin Ward
3660b85614
FIX: Regressions in JS test suite
2019-03-28 14:15:52 -04:00
Robin Ward
8c98c18c2b
FIX: Remove old flagging scss, fix more linting
2019-03-28 13:48:35 -04:00
Robin Ward
7ec74afc43
FIX: Lint on JS
2019-03-28 13:36:30 -04:00
Robin Ward
b58867b6e9
FEATURE: New 'Reviewable' model to make reviewable items generic
...
Includes support for flags, reviewable users and queued posts, with REST API
backwards compatibility.
Co-Authored-By: romanrizzi <romanalejandro@gmail.com>
Co-Authored-By: jjaffeux <j.jaffeux@gmail.com>
2019-03-28 12:45:10 -04:00
Gerhard Schlager
d43f4206c7
FEATURE: Add Armenian language
2019-03-28 14:24:14 +01:00
Tim Lange
1b0267b077
FIX: Switching composer action shouldn't trigger abandon popup ( #7261 )
2019-03-27 21:55:09 +01:00
David Taylor
0d3531c2f1
FEATURE: Allow auth providers to define specific icons
...
Previously we relied on the provider name matching the name of the icon. Now icon names are explicitly set. Plugin providers which do not define an icon will get the default "sign-in-alt" icon
2019-03-27 13:25:04 +00:00
Bianca Nenciu
a9798f0c47
FEATURE: Add page for all group membership requests. ( #6909 )
2019-03-27 13:30:59 +02:00
Tarek Khalil
ef2362a30f
FEATURE: Introducing new UI for changing User's notification levels ( #7248 )
...
* FEATURE: Introducing new UI for tracking User's ignored or muted states
2019-03-27 09:41:50 +00:00
Joffrey JAFFEUX
675d950eab
FIX: corrects link to moderators_activity report ( #7265 )
2019-03-27 10:14:42 +01:00
Gerhard Schlager
de011b53b5
UX: Hide link to incoming email when there is no bounce key
...
For example, webhooks mark email log entries as bounced without there ever being an incoming email.
2019-03-26 18:00:27 +01:00
Joffrey JAFFEUX
b2cacc5b0e
FIX: check can_create_tags on mini-tag-chooser as tag-chooser ( #7260 )
2019-03-26 16:45:38 +01:00
Joffrey JAFFEUX
8fb63b2706
FEATURE: unified popover implementation ( #7244 )
2019-03-26 15:43:27 +01:00
Maja Komel
3aa32c3170
FIX: send only one post request when changing topic notification level ( #7254 )
2019-03-26 12:04:33 +01:00
Guo Xiang Tan
e0cb2a434a
Fix regression introduced in dae0bb4c67
.
...
Add tests so it doesn't bite me again.
2019-03-26 17:52:37 +08:00
Guo Xiang Tan
dae0bb4c67
FIX: Post blurb incorrect when search contains a phrase match.
...
If the blurb generated is not around the search term, we will not be
able to highlight it on the client side.
2019-03-26 17:01:52 +08:00
Penar Musaraj
47a0e4b906
UX: improve mobile search
...
Improves usability of header search icon while user is already in full page search in mobile.
Currently, hitting search icon a second time empties input and does not scroll up to show search form.
This commit scrolls up to show form and sets focus on input.
2019-03-25 14:42:54 -04:00
Kris
df279251b7
REFACTOR: More consistent user/group page layouts
2019-03-25 14:40:22 -04:00
Gerhard Schlager
60e6070c27
UX: Show spinner during text replacement
2019-03-25 16:47:55 +01:00
Joe
ec2123809f
FEATURE: user and group cards on mobile ( #7246 )
2019-03-25 13:37:17 +01:00
Bianca Nenciu
f072da1bfe
FEATURE: Add every month / 6 months options to email digest. ( #7247 )
2019-03-25 12:45:01 +02:00
Tim Lange
dcd56cf593
FIX: Fixed changing composer mode escaping title ( #7191 )
2019-03-25 13:14:26 +05:30
Guo Xiang Tan
ac661e856a
FEATURE: Allow categories to be prioritized/deprioritized in search. ( #7209 )
2019-03-25 10:59:55 +08:00
Guo Xiang Tan
ce75e30bf5
UX: Indent category badges to indicate sub-categories.
2019-03-25 10:36:29 +08:00
Tim Lange
da187f0967
FIX: Clear unsaved groups when switching user ( #7236 )
2019-03-22 12:46:36 +01:00
tshenry
48d0465f72
FEATURE: Improve avatar education link ( #7240 )
...
* Make profile_path more direct to setting
* Add id to profile picture setting for easy linking
2019-03-22 02:20:48 -07:00
Sam Saffron
68fe6b8d53
FIX: suppress autocomplete on group filter
2019-03-22 17:02:04 +11:00
Guo Xiang Tan
7aab7e9062
Revert "UX: Don't reload page after saving settings when editing category."
...
This reverts commit dd142eec03
.
We need a fully reload when reordering.
2019-03-22 13:10:30 +08:00
Osama Sayegh
67b96ad2ff
FIX: discourse client should know about Logster (simpler approach) ( #7237 )
...
* Revert "FIX: discourse client should know about Logster (#7232 )"
This reverts commit bfcbc4d2d6
.
* FIX: discourse client should know about Logster (simpler approach)
2019-03-22 08:48:57 +11:00
Régis Hanol
e1e46f0dff
FIX: topic with no tags
2019-03-21 19:40:10 +01:00
Maja Komel
1f1d3909e5
UX: add more tag classes to topic view ( #7228 )
...
adds tag classes where there is already category-* class
2019-03-21 17:49:50 +01:00
Maja Komel
34730a0b16
UX: show if webhook is disabled ( #7217 )
...
+ show in staff logs when webhook is created/updated/destroyed
2019-03-21 16:13:09 +01:00
Osama Sayegh
bfcbc4d2d6
FIX: discourse client should know about Logster ( #7232 )
2019-03-21 16:54:55 +03:00
Tim Lange
d16a0db4e1
UX: Enabled sorting for more columns in admin user list ( #7208 )
2019-03-21 17:16:58 +08:00
Bianca Nenciu
fdd2e7f2e7
FIX: Do not update last seen notification ID when forced to enable 2FA." ( #7222 )
2019-03-21 09:27:22 +01:00
Tim Lange
f7b156ffbd
UX: Better emoji escaping for topic title ( #7218 )
...
* FIX: Fixed failing discourse-prometheus-alert-receiver plugin specs
2019-03-21 09:11:33 +01:00
Gerhard Schlager
41c7423985
UX: Use a less technical term ("replace") for reseeding ( #7223 )
2019-03-21 16:22:07 +11:00
Penar Musaraj
3c7eb74f51
DEV: no delaying topic scroll in tests
2019-03-20 15:24:06 -04:00
Joffrey JAFFEUX
45ef2ec8cd
DEV: do not wait for closed composer event on test ( #7221 )
2019-03-20 20:13:15 +01:00
Kris
88a3b89990
UX: Improve user profile header layout on mobile
2019-03-20 14:56:34 -04:00
Maja Komel
f3d0d8fe7d
Upgrade to Ember 3.7.0
2019-03-20 14:43:25 +01:00
Joe
6f1badc7c9
REFACTOR: user and group card CSS / template refactor ( #6812 )
...
* Check if user is a member of a group or if the group has members
this is used in the template to conditionally show the relevant markup
* Check if user is suspended or if they have a bio
this is used in the template to conditionally show the relevant markup
* Simplify group-card template
* Simplify user-card template
* Refactor user and group cards CSS
* Check if user is new or if user is staff
* Style fixes
- round avatar margin
- use a more standard margin for buttons
- adds lighter font color for new users
- makes some suspension text bold (used to be <b> tags in template)
- ensures images in group bio are responsive
* user card template fixes
- adds quotes to link href attributes
- wraps some strings in tags for more consistent styling
* group card fixes
- adds quotes to link href attributes
- fixes membership button login action
- wraps some strings with tags for consistent styling
* closure action fixes
* closure action fix
* uses core variables instead of new colors and removes unused styles
* Uses better property names
2019-03-20 10:45:49 +01:00
Guo Xiang Tan
8d1709f6b9
FIX: Disable buttons when loading more results on full page search.
...
Follow up to d50deac676
.
2019-03-20 17:20:34 +08:00
tshenry
cc8082138f
Fix typos
2019-03-20 00:06:12 -07:00
Sam Saffron
d46ce0cb21
DEV: speed up ember acceptance tests
...
## Before
```
Acceptance: Composer::Image resizing buttons: 7985ms
Acceptance: Composer::Edit the first post: 3854ms
Acceptance: Composer::Composer with dirty edit can toggle to another edit: 3707ms
Acceptance: Composer::Composer can toggle between edit and reply: 3704ms
Acceptance: Composer::Tests the Composer controls: 3685ms
Acceptance: Composer::Composer draft with dirty reply can toggle to edit: 3670ms
Acceptance: Composer::Composer can toggle layouts (open, fullscreen and draft): 3278ms
Acceptance: Composer::Switching composer whisper state: 3266ms
Acceptance: Composer::Create a topic with server side errors: 3253ms
Acceptance: Composer::Composer with dirty reply can toggle to edit: 3189ms
Acceptance: Composer::Create a Topic: 3168ms
Acceptance: Composer::Create an enqueued Topic: 2767ms
Acceptance: Composer::Posting on a different topic: 2394ms
Acceptance: Composer::Composer can switch between edits: 2318ms
Acceptance: Composer::Create an enqueued Reply: 2317ms
Acceptance: Composer::Create a Reply: 2292ms
Acceptance: Composer::Checks for existing draft: 1696ms
Acceptance: Composer::Composer can toggle between reply and createTopic: 1415ms
Acceptance: Composer::Composer can toggle whispers: 1296ms
Acceptance: Composer::Loading draft also replaces the recipients: 594ms
```
## After
```
Acceptance: Composer::Composer can toggle layouts (open, fullscreen and draft): 2305ms
Acceptance: Composer::Switching composer whisper state: 2205ms
Acceptance: Composer::Composer draft with dirty reply can toggle to edit: 2185ms
Acceptance: Composer::Composer can toggle between edit and reply: 1719ms
Acceptance: Composer::Composer with dirty edit can toggle to another edit: 1682ms
Acceptance: Composer::Composer with dirty reply can toggle to edit: 1657ms
Acceptance: Composer::Composer can toggle between reply and createTopic: 1412ms
Acceptance: Composer::Posting on a different topic: 1341ms
Acceptance: Composer::Edit the first post: 1327ms
Acceptance: Composer::Create an enqueued Reply: 1306ms
Acceptance: Composer::Composer can toggle whispers: 1265ms
Acceptance: Composer::Composer can switch between edits: 1260ms
Acceptance: Composer::Create a Reply: 1259ms
Acceptance: Composer::Create a topic with server side errors: 1183ms
Acceptance: Composer::Checks for existing draft: 1172ms
Acceptance: Composer::Create a Topic: 1130ms
Acceptance: Composer::Image resizing buttons: 921ms
Acceptance: Composer::Create an enqueued Topic: 731ms
Acceptance: Composer::Tests the Composer controls: 654ms
Acceptance: Composer::Loading draft also replaces the recipients: 540ms
```
That is not a typo... image resizing button went from 8 seconds to 1 second
2019-03-20 16:44:00 +11:00
Guo Xiang Tan
d50deac676
FIX: Search spinners hides all results when loading more.
...
Regression from bc81f64a64
.
2019-03-20 13:34:56 +08:00
Bianca Nenciu
50e9a66e89
FIX: Improve UX for second factor enforcement. ( #7207 )
2019-03-20 15:40:25 +11:00
Vinoth Kannan
0861ca7764
FIX: Don't push browser state if navigated from root url to home page url and vice versa
2019-03-19 19:22:06 +05:30
Régis Hanol
6fb49e74a1
Revert "UX: Better emoji escaping for topic title ( #7176 )" ( #7201 )
...
This reverts commit 0d9bc0aaa6
.
2019-03-19 12:02:47 +01:00
Joe
6d7c0c8f13
REFACTOR: scroll-based mobile header switch
...
This refactor addresses the following issues:
1- Moves all relevant logic to the discourse-topic component (matches desktop)
2- Fixes the flicker issue discussed here
3- Fixes a rare occurring issue where tags wrap to a third line if a topic has long category names and lots of tags
4- Fixes header icon jitter on iOS
5- Fixes an issue where sliding out user / hamburger menus on Android leaves the user in a mid-state with half a title and the header panel visible - swiping will now open the menus but have no effect on the header.
6- adds min-width to the small-logo to act as placeholder so that the title doesn't shift if the logo takes a while to load.
Other than that, everything should look and act the same.
2019-03-19 18:39:38 +08:00
Tim Lange
0d9bc0aaa6
UX: Better emoji escaping for topic title ( #7176 )
2019-03-19 09:33:10 +01:00
Guo Xiang Tan
dd142eec03
UX: Don't reload page after saving settings when editing category.
2019-03-19 16:08:32 +08:00
Guo Xiang Tan
bc81f64a64
UX: Show spinner when searching on full page search.
2019-03-19 15:23:27 +08:00
Gerhard Schlager
3fd04df781
FEATURE: Locale support for seeded categories and topics ( #7110 )
2019-03-18 21:09:13 +01:00
Maja Komel
5d20d02ffc
UX: add tag classes to topics in topics list view ( #7198 )
2019-03-18 13:58:29 -04:00
David Taylor
e2d6edd5ff
DEV: Correct email disabled banner tests
...
Followup to acc121fd27
2019-03-18 17:06:29 +00:00
Dan Ungureanu
976ea160e9
FEATURE: Post notices become old after 14 days. ( #7197 )
2019-03-18 18:20:49 +02:00
Gerhard Schlager
c0a7b06777
Make eslint happy
2019-03-18 16:48:09 +01:00
David Taylor
acc121fd27
FIX: Show 'emails disabled' to staff users when disabled for non-staff ( #7187 )
2019-03-18 16:26:18 +01:00
Tim Lange
22c75e1c04
FIX: Fixed edit category description redirecting without saving ( #7192 )
2019-03-18 16:14:17 +01:00