85d74ec8bf
DEV: remove pseudo-class selector in chat channel page object ( #25399 )
...
The channels-list div is only rendered once now so the :first-child pseudo-class can be removed.
2024-01-24 12:24:40 +08:00
8b44270929
DEV: refactor topic-map participants into glimmer component ( #25350 )
...
* DEV: refactor topic-map participants into glimmer components
2024-01-24 12:00:46 +08:00
04d2ec45b4
DEV: remove user thread count route ( #25385 )
...
Removes a now redundant route for the user thread count.
2024-01-24 10:32:34 +08:00
9dfa31202e
DEV: fix typo in `addSidebarSection` API example ( #25393 )
2024-01-23 17:45:48 -05:00
2abf0f483c
Build(deps-dev): Bump selenium-webdriver from 4.16.0 to 4.17.0 ( #25390 )
...
Bumps [selenium-webdriver](https://github.com/SeleniumHQ/selenium ) from 4.16.0 to 4.17.0.
- [Release notes](https://github.com/SeleniumHQ/selenium/releases )
- [Changelog](https://github.com/SeleniumHQ/selenium/blob/trunk/rb/CHANGES )
- [Commits](https://github.com/SeleniumHQ/selenium/compare/selenium-4.16.0...selenium-4.17.0 )
---
updated-dependencies:
- dependency-name: selenium-webdriver
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-01-23 22:52:21 +01:00
b7bebb4eca
Build(deps-dev): Bump selenium-devtools from 0.120.0 to 0.121.0 ( #25389 )
...
Bumps [selenium-devtools](https://github.com/SeleniumHQ/selenium ) from 0.120.0 to 0.121.0.
- [Release notes](https://github.com/SeleniumHQ/selenium/releases )
- [Changelog](https://github.com/SeleniumHQ/selenium/blob/trunk/rb/CHANGES )
- [Commits](https://github.com/SeleniumHQ/selenium/commits )
---
updated-dependencies:
- dependency-name: selenium-devtools
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-01-23 22:52:12 +01:00
b6f64a70f0
UX: Add "filter for more" to icon picker ( #25263 )
...
Repurposes the existing "filter for more" row from the tag drop component.
2024-01-23 21:53:13 +01:00
da2c0cd5c0
Update translations ( #25386 )
2024-01-23 18:29:34 +01:00
4d43ef5186
FEATURE: Enable passkeys by default ( #25340 )
2024-01-23 17:23:26 +01:00
67244a2318
FIX: use site setting to show my threads chat footer tab ( #25277 )
...
Fixes an issue with delayed rendering of the My Threads tab in chat mobile footer.
Previously we made an ajax request to determine the number of threads a user had before rendering the tab, however it is much faster (and better UX) if we can rely on a site setting for this.
The new chat_threads_enabled site setting is set to true when the site has chat channels with threading enabled.
2024-01-23 19:14:46 +08:00
fdf332f3aa
FEATURE: trigger app event for click tracking ( #25381 )
...
* FEATURE: trigger app event for click tracking
* fix the build
2024-01-23 16:32:07 +05:30
eff485e4c0
FIX: renders channels-list wrapper only once ( #25383 )
...
This bug was causing broken layout when using the `header_dropdown` setting instead of `sidebar` as we were rendering `<div class="channels-list"></div>` two times.
2024-01-23 11:33:45 +01:00
9d3800adec
DEV: Implement text() for SidebarChatMyThreadsSection ( #25371 )
...
In normal use, this `text()` getter is never called. However, when running with the Ember inspector, it is eagerly evaluated and hits throws the "not implemented" error in the base class.
2024-01-23 10:16:47 +00:00
3e0e5112b4
UX: remove legacy option copy in nav menu setting ( #25382 )
...
* UX: update copy in nav menu setting
2024-01-23 10:52:26 +01:00
db70e7a842
FIX: Minor bookmark issues ( #25358 )
...
* FIX: Minor bookmark issues
* We were showing "missing %{name} value" when the name for the
bookmark was undefined with title translations
* There was no way to see the bookmark details on hover in chat
for a message where the bookmark icon was in the left gutter.
We can show the title on the bookmark button in the chat message
actions instead.
* Minor fix
* DEV: Test fix
2024-01-23 16:49:41 +10:00
a03f87bdbd
DEV: Move core plugin TL -> group settings ( #25355 )
...
* DEV: Change poll_minimum_trust_level_to_create to group based setting
New setting is poll_create_allowed_groups
c.f. https://meta.discourse.org/t/changes-coming-to-settings-for-giving-access-to-features-from-trust-levels-to-groups/283408
* DEV: Move styleguide_admin_only to group based setting
Not exactly a TL -> group change, but still part of the
overall effort here:
https://meta.discourse.org/t/changes-coming-to-settings-for-giving-access-to-features-from-trust-levels-to-groups/283408
New setting is styleguide_allowed_groups
2024-01-23 11:35:14 +10:00
678e3cfd25
Build(deps-dev): Bump parser from 3.3.0.4 to 3.3.0.5 ( #25376 )
...
Bumps [parser](https://github.com/whitequark/parser ) from 3.3.0.4 to 3.3.0.5.
- [Changelog](https://github.com/whitequark/parser/blob/master/CHANGELOG.md )
- [Commits](https://github.com/whitequark/parser/compare/v3.3.0.4...v3.3.0.5 )
---
updated-dependencies:
- dependency-name: parser
dependency-type: indirect
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-01-23 06:56:51 +08:00
0154064b8d
Build(deps): Bump highline from 3.0.0 to 3.0.1 ( #25353 )
...
Bumps [highline](https://github.com/JEG2/highline ) from 3.0.0 to 3.0.1.
- [Changelog](https://github.com/JEG2/highline/blob/master/Changelog.md )
- [Commits](https://github.com/JEG2/highline/compare/v3.0.0...v3.0.1 )
---
updated-dependencies:
- dependency-name: highline
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-01-23 06:56:40 +08:00
126ed84bbb
DEV: Remove unused chat css ( #25363 )
...
There are no longer any references to `chat-tabs`/`tabpanel` outside this scss files
2024-01-23 06:56:17 +08:00
0478b45fd3
DEV: Print out backtraces of all threads when spec times out on CI ( #25356 )
...
Why this change?
We have been seeing specs time out on GitHub CI but the problem is that
we are unable to debug those timeouts due to a lack of information. This
change seeks to print out the backtraces of all threads right before a
spec times out on CI.
What does this change do?
1. Starts a thread on CI which will wait for a spec to start running.
1. Once a spec starts running, the thread will sleep for
`PER_SPEC_TIMEOUT_SECONDS -1` seconds.
1. After sleeping, the thread checks if the spec is still running and
prints out the backtraces of all threads if it is. Otherwise, the
thread does nothing and runs the next loop.
1. At the end of each spec run, we ensure that the thread is in a
waiting state for the next spec run to start.
Note that there is no need for us to teardown or cleanup the thread
since the process terminates after running all the tests.
2024-01-23 06:55:49 +08:00
c80aca214e
Build(deps): Bump logster from 2.15.0 to 2.16.0 ( #25377 )
...
Bumps [logster](https://github.com/discourse/logster ) from 2.15.0 to 2.16.0.
- [Changelog](https://github.com/discourse/logster/blob/main/CHANGELOG.md )
- [Commits](https://github.com/discourse/logster/compare/v2.15.0...v2.16.0 )
---
updated-dependencies:
- dependency-name: logster
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-01-23 06:54:10 +08:00
5627355c8c
DEV: adds before-header-logo outlet ( #25196 )
2024-01-22 17:17:08 -05:00
7bad0b1d8a
DEV: Trigger DiscourseEvent on push notification send ( #25375 )
2024-01-22 15:30:35 -06:00
4074763efb
DEV: Switch to bundled Ember types ( #25370 )
...
Since Ember 5.1, types are included in the ember-source package (see https://blog.emberjs.com/stable-typescript-types-in-ember-5-1/ )
2024-01-22 20:32:37 +00:00
a709b7e861
FIX: Allow sanitized-HTML in GH issues and categories oneboxes. ( #25374 )
...
Follow-up to d78357917chttps://meta.discourse.org/t/html-is-not-render-on-category-onebox-description/289424 :
2024-01-22 15:25:29 -03:00
a37d26f559
FEATURE: Add support for custom site name in Open Graph metadata ( #25373 )
2024-01-22 13:57:52 -04:00
93264da206
DEV: Add script to generate schema for intermediate DB ( #24484 )
...
This will be used by migration scripts.
2024-01-22 18:45:52 +01:00
4f901cae8f
PERF: Better query performance for user avatar consistency check. ( #25342 )
2024-01-22 18:33:39 +01:00
7157798938
FIX: clear db_backup_port default value
...
The presence of this value with the postgresql default keeps tripping up
people. We shouldn't set this here.
examples:
* https://meta.discourse.org/t/84439/2
* https://meta.discourse.org/t/100604/7
* https://meta.discourse.org/t/223144/6
* https://meta.discourse.org/t/291992/10
2024-01-22 11:39:15 -05:00
d5e3a47d3c
DEV: Reset DiscoursePluginRegistry after spec ( #25369 )
2024-01-22 08:51:36 -06:00
57915d9edc
FIX: Radar chart not widely available. ( #25368 )
...
We added support for radar type charts in #24274 . However, radar charts work with three variables, meaning we can't display any report that way.
Unfortunately, by adding `:radar` to the `Report#modes` variable, I made them widely available.
Related bug report: https://meta.discourse.org/t/report-radar-graph-uncaught-typeerror/292360
2024-01-22 11:21:28 -03:00
f669a6fa4c
FIX: search escape handler should be on keydown ( #25364 )
...
The keydown event fires as soon as the key is pressed down. This is often preferred for actions that need to occur immediately, like stopping a process, closing a modal window, or canceling an ongoing operation. The immediacy of keydown makes it more responsive, as the user doesn't have to fully press and release the key.
Moreover, it allows us to not close chat on escape when the search menu is open.
2024-01-22 15:19:20 +01:00
108aff663e
FIX: User-tips regression in #25361 ( #25367 )
...
It's a set of Tip objects, not ids
2024-01-22 14:45:47 +01:00
62c30e0b5f
DEV: Convert activation-email-form to gjs ( #25343 )
2024-01-22 12:14:10 +01:00
4035513901
DEV: Clean up user-tips service ( #25361 )
...
1. TrackedSet instead of TrackedMap of `true`s
2. Use Set#has for early exit
3. Use the site service instead of Site import
2024-01-22 12:13:02 +01:00
abbc6cf314
DEV: Update shoulda-matchers to 6.1.0 ( #25362 )
...
No need to stay on the git version anymore
2024-01-22 12:12:51 +01:00
3fc06e4345
DEV: Convert activation-controls to gjs ( #25344 )
2024-01-22 12:11:22 +01:00
749b490188
DEV: Convert about-page-users to gjs ( #25341 )
2024-01-22 12:10:59 +01:00
5278734fe2
FIX: Ignore invalid images when shrinking uploads ( #25346 )
2024-01-22 12:10:29 +01:00
ae2d9de164
DEV: Remove "(Ember 5)" suffix from CI job names ( #25347 )
2024-01-22 12:10:17 +01:00
76350c9498
Build(deps-dev): Bump the types group in /app/assets/javascripts with 1 update ( #25351 )
...
* Build(deps-dev): Bump the types group
Bumps the types group in /app/assets/javascripts with 1 update: [@types/ember__routing](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/ember__routing ).
Updates `@types/ember__routing` from 4.0.20 to 4.0.21
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases )
- [Changelog](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/ember__routing/history-location.d.ts )
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/ember__routing )
---
updated-dependencies:
- dependency-name: "@types/ember__routing"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: types
...
Signed-off-by: dependabot[bot] <support@github.com>
* Update lockfiles for ember version flag
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: discoursebuild <build@discourse.org>
2024-01-22 11:54:06 +01:00
d1be9310ed
Build(deps): Bump actions/cache from 3 to 4 ( #25359 )
...
Bumps [actions/cache](https://github.com/actions/cache ) from 3 to 4.
- [Release notes](https://github.com/actions/cache/releases )
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md )
- [Commits](https://github.com/actions/cache/compare/v3...v4 )
---
updated-dependencies:
- dependency-name: actions/cache
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-01-22 11:50:56 +01:00
b3904eab45
FIX: User group check should return true for system user for auto groups ( #25357 )
...
This is a temporary fix to address an issue where the
system user is losing its automatic groups when the server
is running. If any auto groups are provided, and the user is
a system user, then we return true. The system user is admin,
moderator, and TL4, so they usually have all auto groups.
We can remove this when we get to the bottom of why the auto
groups are being deleted.
2024-01-22 14:40:29 +10:00
a870c10e14
UX: `user.account_possessive` was impossible to translate ( #25331 )
2024-01-21 15:42:14 +01:00
aee7197c43
FIX: correctly save scroll position in channel ( #25345 )
...
Due to an incorrect test the previous service was incorrectly implementing the map, and was most importantly not deleting the state when reaching bottom.
2024-01-19 22:49:14 +01:00
ccb5fa1a5a
FIX: correctly exclude muted channels from thread unreads ( #25339 )
2024-01-19 22:05:41 +01:00
a840c295d8
FIX: fixed a bug where keyboard on ios was broken ( #25338 )
...
It was broken on iOS PWA, when you had the keyboard open and would leave the app. When you came back the body was scrolled and it was looking buggy until you close/reopen keyboard.
This commit attempt to reposition the page correctly 200ms after the tab is visible again.
2024-01-19 17:07:59 +01:00
07a0c6c637
DEV: Add additional arg to appEvents triggered on notification click ( #25317 )
2024-01-19 10:01:33 -06:00
3bd88d7586
FIX: ensures active message is cleared on threads opening ( #25337 )
...
No test as this is a very specific edge case, already hard to repro manually.
2024-01-19 16:34:24 +01:00
9365d8b544
FEATURE: save/retrieve scroll position in chat channel ( #25336 )
...
Note this is only saved on each tab session.
2024-01-19 16:34:11 +01:00
David Battersby
Kelv
Kris
dependabot[bot]
Penar Musaraj
Discourse Translator Bot
Arpit Jalan
Joffrey JAFFEUX
David Taylor
chapoi
Martin Brennan
Jarek Radosz
Alan Guo Xiang Tan
Mark VanLandingham
Roman Rizzi
Jean
Selase Krakani
Michael Brown
Gerhard Schlager