f7314f8ab4
DEV: Improve s3 upload image analysis
...
- Introduces uploads:delete_missing_s3 which can be used to "give up" and
delete broken records from the database
- Fixes a bug in fix_missing_s3 - crashing on deleted posts
- Adds more info to analyze_missing_s3
2020-08-27 11:50:07 +10:00
46f5e8aac1
Build(deps): Bump loofah from 2.6.0 to 2.7.0
...
Bumps [loofah](https://github.com/flavorjones/loofah ) from 2.6.0 to 2.7.0.
- [Release notes](https://github.com/flavorjones/loofah/releases )
- [Changelog](https://github.com/flavorjones/loofah/blob/master/CHANGELOG.md )
- [Commits](https://github.com/flavorjones/loofah/compare/v2.6.0...v2.7.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-08-27 09:24:20 +08:00
892e97341b
Build(deps-dev): Bump mock_redis from 0.25.0 to 0.26.0
...
Bumps [mock_redis](https://github.com/sds/mock_redis ) from 0.25.0 to 0.26.0.
- [Release notes](https://github.com/sds/mock_redis/releases )
- [Changelog](https://github.com/sds/mock_redis/blob/master/CHANGELOG.md )
- [Commits](https://github.com/sds/mock_redis/compare/v0.25.0...v0.26.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-08-27 09:24:00 +08:00
63d33f8b7c
Build(deps-dev): Bump shoulda-matchers from 4.3.0 to 4.4.1
...
Bumps [shoulda-matchers](https://github.com/thoughtbot/shoulda-matchers ) from 4.3.0 to 4.4.1.
- [Release notes](https://github.com/thoughtbot/shoulda-matchers/releases )
- [Changelog](https://github.com/thoughtbot/shoulda-matchers/blob/master/CHANGELOG.md )
- [Commits](https://github.com/thoughtbot/shoulda-matchers/compare/v4.3.0...v4.4.1 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-08-27 09:23:44 +08:00
02833e133c
FIX: Suspend API to require `suspend_until` and `reason` params
...
These fields are required when using the UI and if `suspend_until`
params isn't used the user never is actually suspended so we should
require these fields when suspending a user.
2020-08-26 19:05:48 -06:00
95179a5ab6
Button bar needs visible overflow, follow-up to 489443e
2020-08-26 20:52:03 -04:00
489443e3a9
UX: Better handling of long category names and button bar in composer ( #10542 )
2020-08-26 19:38:20 -04:00
7cdef9f793
Remove tag name from classList ( #10540 )
...
* Remove tag name from classList
2020-08-26 17:20:57 -05:00
b12afa9435
Fix spec ( #10539 )
2020-08-26 17:31:02 -04:00
1e6d125db6
FIX: Remove additional paths from robots.txt
...
admin path is protected by guardian and thus inaccessible to crawlers
Follow up to b52143f
2020-08-26 16:52:22 -04:00
618a7ecb35
FIX: `default_tags_muted` site setting won't have tag ids.
...
Instead it only have list of tag names separated by comma.
89fcb75af2
2020-08-26 23:05:29 +05:30
ce2491dc2f
Css class additions ( #10532 )
...
* Category Page / Tag Class Additions
These additions add:
-the name of the tag as a css class to discourse tags.
-'pinned' as a css class to pinned topics in the category view
2020-08-26 12:21:47 -05:00
f5eccdd0b8
FIX: ensures period-chooser is not losing query params ( #10534 )
...
eg repro before:
- visit http://pr-discourse.test/top/weekly?f=foo
- select another period in the period chooser
- f=foo was gone
After this commit it should still be present
2020-08-26 19:01:08 +02:00
ff4de97dfd
REFACTOR: Move `bootbox` to an import instead of global variable ( #10533 )
2020-08-26 12:57:13 -04:00
354014099d
Update copy and remove unused strings
2020-08-26 18:08:41 +02:00
4351fa435e
FIX: Correctly redirect after external login on subfolder sites ( #10529 )
2020-08-26 15:52:21 +01:00
996d5f3b17
Build(deps): Bump omniauth-facebook from 6.0.0 to 7.0.0 ( #10528 )
...
Bumps [omniauth-facebook](https://github.com/mkdynamic/omniauth-facebook ) from 6.0.0 to 7.0.0.
- [Release notes](https://github.com/mkdynamic/omniauth-facebook/releases )
- [Changelog](https://github.com/simi/omniauth-facebook/blob/master/CHANGELOG.md )
- [Commits](https://github.com/mkdynamic/omniauth-facebook/compare/v6.0.0...v7.0.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-08-26 10:17:37 -04:00
ae7ff5eb73
FEATURE: Added sort by username for directory items ( #10482 )
...
* done-sorting-usernames-on-users-page
* sorted-usernames-on-users-page
* spec written
* specs added
2020-08-26 10:14:20 -04:00
6c3b1eb9b9
Update translations
2020-08-26 09:27:35 +00:00
dbfb2a1e11
Minor follow-up bug fix for 5ff6c10.
2020-08-26 17:25:28 +08:00
c792f36966
UX: clarify timezone formatting ( #10526 )
2020-08-26 10:18:55 +02:00
5ff6c10320
FIX: Ensure that topic timers belonging to trashed topics are destroyed.
2020-08-26 16:11:10 +08:00
b60c39fdf0
DEV: search more carefully for missing uploads
...
rake uploads:analyze_missing_s3 was not looking at all places, amend it so
it looks in all the places where uploads could exist.
2020-08-26 17:48:42 +10:00
3cc761ac44
FIX: Clean up toggle closed topic timer when user is not authorized.
2020-08-26 12:59:05 +08:00
83314d1534
DEV: Fix the broken build caused by 1e8f216.
2020-08-26 12:36:51 +08:00
5bca1aec48
FIX: Clean up topic_timers when no longer valid.
...
This was causing a bug where the jobs for the topic_timers will keep
getting enqueued over and over again.
2020-08-26 12:18:51 +08:00
1e8f216e17
FIX: Ensure autoclose based on last post is executed by system user.
2020-08-26 12:08:46 +08:00
ffc5bb7278
Revert "FIX: Topic Timer auto opening closed topics ( #10524 )"
...
This reverts commit 7cfd5f87ff
2020-08-26 09:32:11 +08:00
7cfd5f87ff
FIX: Topic Timer auto opening closed topics ( #10524 )
...
This commit is addressing an issue where it is possible that there could
be multiple topic timer jobs running to close a topic or a weird race
condition state causing a topic that was just closed to be re-opened.
By removing the logic from the Topic Timer model into the Topic Timer
controller endpoint we isolate the code that is used for setting an
auto-open or an auto-close timer to just that functionality making the
topic timer background jobs safer if multiple are running.
Possibly in the future if we would like this logic back in the model a
refactor will be needed where we actually pass in the auto-close and
auto-open action instead of mixing it with the close and open
action that is currently being passed to the controller.
2020-08-26 11:17:12 +10:00
93e136ae0e
UX: show a generic error on upload for XHR status 0 ( #10521 )
...
This indication covers all cases of network errors, not just "cancelled by user".
The post upload component already has its own handling for user-cancelled uploads, but the generic upload component does not.
Tested by stopping my localhost server right before attempting to upload a file.
2020-08-25 12:08:03 -07:00
7277ca6cb6
UX: Add category-title-before to categories-boxes layout
...
Makes it consistent with the other /categories layouts
2020-08-25 13:35:13 -04:00
f670f93223
Build(deps): Bump rubocop-rspec from 1.43.1 to 1.43.2
...
Bumps [rubocop-rspec](https://github.com/rubocop-hq/rubocop-rspec ) from 1.43.1 to 1.43.2.
- [Release notes](https://github.com/rubocop-hq/rubocop-rspec/releases )
- [Changelog](https://github.com/rubocop-hq/rubocop-rspec/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop-hq/rubocop-rspec/compare/v1.43.1...v1.43.2 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-08-25 09:57:45 -04:00
2100de449e
Update spec/components/concern/has_custom_fields_spec.rb
...
Co-authored-by: Régis Hanol <regis@hanol.fr>
2020-08-25 09:52:18 -04:00
7e5290203f
Update spec/components/concern/has_custom_fields_spec.rb
...
Co-authored-by: Régis Hanol <regis@hanol.fr>
2020-08-25 09:52:18 -04:00
c363189858
Accounted for the change while reading the fields added specs to confirm working
2020-08-25 09:52:18 -04:00
352ad826c1
FIX: symbols and strings should be treated similarly while saving custom fields
2020-08-25 09:52:18 -04:00
71e747b160
FIX: QUnit site has to be set before `reset()`
2020-08-25 09:16:32 -04:00
2523a21fc3
FIX: Server side rendering was broken with new `helperContext()`
2020-08-25 09:16:32 -04:00
a3fb732b23
REFACTOR: We can reuse `getOwner` for some container stuff
2020-08-25 09:16:32 -04:00
347a4981a0
REFACTOR: Remove `Discourse` constant from `get-owner`
2020-08-25 09:16:32 -04:00
185ed80702
REFACTOR: Remove `Discourse` constants from nav-item
2020-08-25 09:16:32 -04:00
c068098f75
REFACTOR: Remove container from `User` class
2020-08-25 09:16:32 -04:00
c94ba34882
REFACTOR: Remove `__container__` from Site
2020-08-25 09:16:32 -04:00
ac498ae2a0
REFACTOR: Remove container from ajax
2020-08-25 09:16:32 -04:00
df8ae6891c
REFACTOR: Remove constants from `text` helper
2020-08-25 09:16:32 -04:00
4063cab8c2
REFACTOR: Missed `container`s in `DiscourseURL`
2020-08-25 09:16:32 -04:00
02e8d84e30
REFACTOR: Remove `Discourse` constant from `showModal`
2020-08-25 09:16:32 -04:00
98e5e1cd53
REFACTOR: Remove container from `DiscourseURL`
2020-08-25 09:16:32 -04:00
dae8b9bcfb
FIX: Remove container from utilities
2020-08-25 09:16:32 -04:00
89d766d089
REFACTOR: Remove container from safari-hacks
2020-08-25 09:16:32 -04:00
Sam Saffron
dependabot-preview[bot]
Blake Erickson
Kris
Jordan Vidrine
Joshua Rosenfeld
Vinoth Kannan
Joffrey JAFFEUX
Robin Ward
Gerhard Schlager
David Taylor
jahan-ggn
Discourse Translator Bot
Guo Xiang Tan
Kane York
Penar Musaraj
Faizaan Gagan