Commit Graph

296 Commits

Author SHA1 Message Date
Joffrey JAFFEUX ec2ce8f763
FEATURE: replace period-chooser by a select-kit component 2018-01-15 11:55:16 +01:00
Robin Ward ff2e8c1a51 UX: Don't use a chevron when a dropdown is just an icon 2018-01-12 12:39:42 -05:00
Joffrey JAFFEUX 3a7d2da633
FIX: category badges css refactoring/fixes
This commit fixes multiple css issues with category badges in select-kit and outside of select-kit. It also contains refactoring of components impacted by those changes.
2018-01-11 13:05:29 +01:00
Joffrey JAFFEUX 3ee7b18886
FIX: disable by default limitMatches 2018-01-11 09:54:39 +01:00
Joffrey JAFFEUX 3ec2024466
select-kit refactoring
* improve events naming/handling
* do not explicitly check for true/Fasle
* make sure header is re-computed on toggle
2018-01-11 09:39:51 +01:00
Joffrey JAFFEUX c9921869f1
FIX: adds select-kit api to modify header computed content (#5476)
This api would allow to simply modify header text or icons, eg:

```
      api.modifySelectKit("select-kit")
        .modifyHeaderComputedContent((context, computedContent) => {
          computedContent.title = "Not so evil";
          return computedContent;
        });
```
2018-01-09 10:52:32 +01:00
Robin Ward fbd0d47fce FIX: Don't raise error if I18n key is not found 2018-01-04 14:08:21 -05:00
Joffrey JAFFEUX 8fd683ab19
select-kit DOM mixin refactoring
This commits improves code readability, performance and rendering precision.
2017-12-28 16:12:45 +01:00
Joffrey JAFFEUX f6dc992b0f
FIX: do not apply i18n if already done 2017-12-26 09:51:45 +01:00
Joffrey JAFFEUX 315b9d796d
select-kit refactoring
* better test helper
* more reliable tests
* more consistent use of data-value/data-name/title/aria-label everywhere: header and rows
2017-12-22 13:08:12 +01:00
Joffrey JAFFEUX 6e1dd12390
FIX: load tracked/watched/muted categories on screen loading 2017-12-20 16:13:33 +01:00
Guo Xiang Tan 91e84433ff Take two at fixing JS tests. 2017-12-15 15:46:09 +08:00
Joffrey JAFFEUX 3090c016d0
FIX: do not display used categories as selectable in categories notifications preferences 2017-12-14 14:40:08 +01:00
Joffrey JAFFEUX 8001f68c32
FIX: make sure we don’t show scrollbars on toolbar-popup-menu 2017-12-13 19:01:30 +01:00
Joffrey JAFFEUX c1c31b99ce
Replaces toolbar popup-menu with select-kit 2017-12-13 10:49:32 +01:00
Joffrey JAFFEUX 75463e5a91
FIX: correctly print html entity when used in a locale for none 2017-12-05 19:09:12 -05:00
Robin Ward 3e83c34785 FIX: Don't include `null` class when rendering the pinned dropdown 2017-12-03 16:20:35 -05:00
Joffrey JAFFEUX dbadebacd1
FIX: allows select-kit to search by null value 2017-12-01 20:02:00 +01:00
Robin Ward 823896d698 FIX: Use parseable date format 2017-11-28 14:16:33 -05:00
Robin Ward 23ee3047bf FIX: Future date input selector was not respecting timezone 2017-11-28 13:44:24 -05:00
Joffrey JAFFEUX 49b1df40fc
FIX: various issues when editing category permissions
This commit also adds multiple tests
2017-11-27 19:50:04 +01:00
Joffrey JAFFEUX 329343be06
FIX: various sizing issues on select-kit 2017-11-26 17:21:39 +01:00
Joffrey JAFFEUX 96cdc4e66e
FIX: makes allowInitialValueMutation more restrictive 2017-11-24 13:15:02 +01:00
Joffrey JAFFEUX 63307c303a
FIX: regression preventing to set number of hours before closing
This commit also adds a full test suite for editing topic timer.
2017-11-24 02:48:45 +01:00
Joffrey JAFFEUX 9208909b26 tweak icon-library generation 2017-11-23 18:24:26 +01:00
Joffrey JAFFEUX 616a0dae4e
FIX: removes auto sizing and touchstart support for now 2017-11-23 15:34:52 +01:00
Joffrey JAFFEUX 5b3ecffbb2
FIX: pick date and time was not reseting state 2017-11-23 15:18:27 +01:00
Joffrey JAFFEUX fe94e7c453
FIX: more resilient allowInitiatlValueMutation implementation 2017-11-23 14:39:26 +01:00
Joffrey JAFFEUX d32c95b6e8
FIX: avoid touch on select-kit causing instant closing of it 2017-11-22 16:36:50 +01:00
Joffrey JAFFEUX acdfb3ed03
FIX: don’t convert an object using EachProxy to an array 2017-11-22 14:33:04 +01:00
Joffrey JAFFEUX b14d9529b8
FIX: adds support for name changes tracking 2017-11-22 13:49:45 +01:00
Joffrey JAFFEUX 86b8f6b238
FIX: cast integer on truthy value and not only true
allows castInteger="true" to work
2017-11-22 13:40:22 +01:00
Joffrey JAFFEUX 5a992fe5e7
FIX: makes sure keyboard is disabled on mobile 2017-11-22 12:33:07 +01:00
Joffrey JAFFEUX a3b511f4f5
FIX: simplify keyboard handling 2017-11-22 11:29:30 +01:00
Joffrey JAFFEUX b2b565c2fb
select-kit initial plugin api implementation (0.8.13)
```
api.modifySelectKit("identifier-of-the-select-targeted")
  .modifyContent((context, existingContent) => {})
  .appendContent(() => {})
  .prependContent(() => {})
  .onSelect((context, val) => {});
```
2017-11-22 10:34:12 +01:00
Joffrey JAFFEUX f3db3c7e0b
FIX: future-date-input-row lost datetimes 2017-11-22 08:52:00 +01:00
Joffrey JAFFEUX 761f4afd85
FIX: tab should select and focus next tabindex 2017-11-21 23:28:48 +01:00
Joffrey JAFFEUX 12beb77afa
FIX: make sure the element exists before calling `off`
This commit fixes an issue happening only when running tests under `/qunit` and not with `rake qunit:test`
2017-11-21 19:08:59 +01:00
Joffrey JAFFEUX 7669146897
FIX: force focus input only on expand 2017-11-21 18:23:49 +01:00
Joffrey JAFFEUX 9444c31918
FIX: makes typing indicator visible when possible 2017-11-21 18:07:10 +01:00
Joffrey JAFFEUX 3dfc0777df
FIX: close on click outside 2017-11-21 17:37:13 +01:00
Joffrey JAFFEUX 00e9805e23
FIX: category descriptions should display html 2017-11-21 17:31:26 +01:00
Joffrey JAFFEUX 2087d011df
FIX: fix bugs with keyboard events 2017-11-21 16:59:03 +01:00
Joffrey JAFFEUX 5dd890eb3d
FIX: displayCategoryDescription was not working correctly 2017-11-21 15:38:30 +01:00
Joffrey JAFFEUX b8c95373be
uses right naming for search-advanced-category-chooser component 2017-11-21 14:47:53 +01:00
Joffrey JAFFEUX 39f3dbd945
Introduces select-kit
* renames `select-box-kit` into `select-kit`
* introduces `single-select` and `multi-select` as base components
* introduces {{search-advanced-category-chooser}} as a better component for selecting category in advanced search
* improves events handling in select-kit
* recreates color selection inputs using {{multi-select}} and a custom {{selected-color}} component
* replaces category-selector by a component using select-kit and based on multi-select
* improves positioning of wrapper
* removes the need for offscreen, and instead use `select-kit-header` as a base focus point for all select-kit based components
* introduces a formal plugin api for select-kit based components
* introduces a formal pattern for loading and updating select-kit based components:

```
computeValue()
computeContent()
mutateValue()
```
2017-11-21 11:53:09 +01:00