Discource-C/discourse
1
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-10 05:14:59 +00:00
Code Issues Packages Projects Releases Wiki Activity
discourse/lib
History
Sam a7628c1d74 FIX: use ordered_posts for last post check, not the posts relation 
The `posts` relation on `Topic` is not ordered. Using `Topic.posts.first`
is basically the same as asking for a random post, it will depend on DB
order. This breaks on Topic merge and split for example.

Additionally, a huge problem with that is that it forces active record down
a slow path. `Topic.posts.first` is extremely slow on giant topics, since
it has no default ordering it appears AR materializes the entire set prior
to doing `first`.

This commit also illustrates the importance of testing, initially I only
fixed the second instance of the problem in `post_validator.rb` but testing
revealed that the problem was repeated at the top of the file.

Longer term we should consider a larger change of default ordering the posts
relations so people do not fall down this trap anymore.
2019-01-18 13:18:40 +11:00
..
active_record/connection_adapters
DEV: Improve postgresql fallover and multisite tests.
2019-01-15 12:52:45 +08:00
auth
FIX: Use database to persist metadata during social registration (#6750)
2018-12-10 15:10:06 +00:00
autospec
DEV: Enable Style/SingleLineMethods and Style/Semicolon in Rubocop (#6717)
2018-12-04 11:48:13 +08:00
backup_restore
DEV: upgrades from Ember 2.13 to Ember 3.5.1 (#6808)
2019-01-10 11:06:01 +01:00
common_passwords
Make rubocop happy again.
2018-06-07 13:28:18 +08:00
content_security_policy
FEATURE: allow extending CSP base-uri and object-src
2019-01-09 15:34:14 -05:00
demon
FEATURE: introduce ultra_low priority queue
2019-01-17 14:53:19 +11:00
email
FEATURE: Include "via <site_name>" in email From header
2019-01-04 17:06:19 +01:00
emoji
FEATURE: Allow plugins to add custom emoji translations
2019-01-04 15:27:46 +01:00
es6_module_transpiler
DEV: Enable Style/SingleLineMethods and Style/Semicolon in Rubocop (#6717)
2018-12-04 11:48:13 +08:00
file_store
FIX: Use correct version when generating file path for optimized image (#6871)
2019-01-11 18:35:38 +05:30
freedom_patches
FEATURE: Better handling of quotation marks in site text search
2018-11-12 13:26:41 +01:00
generators
FEATURE: Post deployment migrations. (#6406)
2018-10-08 15:47:38 +08:00
guardian
FIX: Posting without bump raised an error for TL4
2019-01-03 14:14:02 +01:00
highlight_js
DEV: Use yarn to manage Highlight.js dependency
2019-01-14 12:46:35 -05:00
i18n
FEATURE: Better handling of quotation marks in site text search
2018-11-12 13:26:41 +01:00
import
…
import_export
Enable Lint/ShadowingOuterLocalVariable for Rubocop.
2018-09-04 10:16:42 +08:00
javascripts
DEV: Run prettier. (#6420)
2018-09-21 11:02:23 +00:00
middleware
DEV: avoid require_dependency for some libs
2018-12-31 10:53:30 +11:00
migration
DEV: Enable Style/SingleLineMethods and Style/Semicolon in Rubocop (#6717)
2018-12-04 11:48:13 +08:00
onebox
Upgrade to FontAwesome 5 (take two) (#6673)
2018-11-26 16:49:57 -05:00
plugin
FEATURE: Allow plugins to add custom emoji translations
2019-01-04 15:27:46 +01:00
pretty_text
FIX: show generic title when quoting off-topic secure category posts
2018-12-03 09:42:32 +11:00
rate_limiter
Add specs for RateLimiter::LimitExceeded#description.
2018-06-19 07:48:03 +08:00
scheduler
FEATURE: log long running jobs in the defer queue
2018-10-12 17:03:47 +11:00
search
FEATURE: new 'search_ignore_accents' site setting
2018-09-17 10:42:30 +02:00
sidekiq
FIX: queue heartbeats in readonly modes
2018-08-29 12:36:59 +10:00
site_settings
FEATURE: Prohibit S3 bucket reusage
2018-12-17 11:35:28 +01:00
stylesheet
DEV: Enable Style/SingleLineMethods and Style/Semicolon in Rubocop (#6717)
2018-12-04 11:48:13 +08:00
svg_sprite
FEATURE: plugin support for custom icons
2019-01-12 09:59:12 -05:00
tasks
DEV: run "yarn install" before lint tests
2019-01-17 14:17:44 -05:00
theme_store
FEATURE: add branch option to remote theme import
2018-10-09 17:01:08 +11:00
validators
FIX: use ordered_posts for last post check, not the posts relation
2019-01-18 13:18:40 +11:00
wizard
FEATURE: add short_site_description setting to be included in title tag on homepage
2018-12-12 11:46:58 +01:00
admin_confirmation.rb
…
admin_constraint.rb
Revert "FIX: Don't rate limit admin and staff constraints when matching routes."
2018-09-04 14:27:21 +08:00
admin_user_index_query.rb
FEATURE: Second factor backup
2018-06-28 10:12:32 +02:00
age_words.rb
…
archetype.rb
…
auth.rb
DEV: Introduce Auth::ManagedAuthenticator
2018-11-30 11:18:11 +00:00
avatar_lookup.rb
UX: show full name on /latest page
2018-08-23 14:41:06 +05:30
badge_posts_view_manager.rb
Extract badge_posts view management logic into a service object.
2018-09-03 09:51:35 +08:00
badge_queries.rb
FEATURE: Add Wiki Editor badge. (#6511)
2018-10-19 15:30:27 +02:00
base62.rb
remove constant warning in base62 file
2018-01-19 19:52:42 +01:00
browser_detection.rb
FIX: Fix browser detection for Microsoft Edge. (#6516)
2018-10-22 23:15:41 +11:00
cache.rb
FIX: Don't use Redis#keys in production.
2018-12-25 15:12:59 +02:00
canonical_url.rb
…
category_badge.rb
FIX: avoid using absolute positioning for box category style in emails (#6607)
2018-11-15 14:35:50 +01:00
comment_migration.rb
DEV: remove exec_sql and replace with mini_sql
2018-06-19 16:13:36 +10:00
composer_messages_finder.rb
FIX: Relative links in translations should work with subfolder
2018-11-08 23:31:05 +00:00
configurable_urls.rb
…
content_buffer.rb
…
content_security_policy.rb
FEATURE: allow plugins and themes to extend the default CSP (#6704)
2018-11-30 09:51:45 -05:00
cooked_post_processor.rb
FEATURE: Remove full quotes only from new posts. (#6862)
2019-01-17 13:24:32 +11:00
crawler_detection.rb
FIX: cubot android devices were detected as crawlers
2018-06-21 10:56:46 +10:00
current_user.rb
FIX: Do not check for suspicious login when impersonating. (#6534)
2018-11-12 15:34:12 +01:00
custom_renderer.rb
…
custom_setting_providers.rb
…
db_helper.rb
PERF: new 'migrate_to_s3' rake task
2018-12-26 17:34:49 +01:00
directory_helper.rb
…
discourse_cookie_store.rb
…
discourse_diff.rb
FIX: don't add diff classes more than once
2018-04-16 15:41:45 +02:00
discourse_event.rb
…
discourse_hub.rb
DEV: Remove the use of stubs on Rails.logger in our test suite.
2018-10-10 09:34:50 +08:00
discourse_iife.rb
…
discourse_ip_info.rb
FEATURE: adds security tab to dashboard (#6768)
2018-12-14 13:47:59 +01:00
discourse_logstash_logger.rb
FIX: Incorrect formatter used when logstash formatter is enabled.
2018-04-17 12:07:52 +08:00
discourse_plugin_registry.rb
Upgrade to FontAwesome 5 (take two) (#6673)
2018-11-26 16:49:57 -05:00
discourse_plugin.rb
…
discourse_redis.rb
FIX: Don't use Redis#keys in production.
2018-12-25 15:12:59 +02:00
discourse_tagging.rb
FIX: Can't clean a tag if the given string is frozen.
2018-10-15 14:48:45 +08:00
discourse_updates.rb
DEV: Fix rubocop after update.
2019-01-02 05:47:29 +08:00
discourse.rb
FIX: Enabling readonly mode should clear anon cache as well.
2018-12-18 11:56:25 +08:00
disk_space.rb
FEATURE: Improve backup stats on admin dashboard
2018-12-17 11:35:11 +01:00
distributed_cache.rb
REFACTOR: distributed_cache is moved to the message_bus gem
2018-10-15 15:01:45 -04:00
distributed_memoizer.rb
…
distributed_mutex.rb
FIX: correct readonly timeout
2018-09-20 15:15:46 +10:00
edit_rate_limiter.rb
…
email_backup_token.rb
…
email_cook.rb
replace indentation with non-breaking spaces when cooking emails
2017-11-18 17:16:44 +01:00
email_updater.rb
Make rubocop happy again.
2018-06-07 13:28:18 +08:00
email.rb
FEATURE: Include "via <site_name>" in email From header
2019-01-04 17:06:19 +01:00
encodings.rb
Use rchardet instead of charlock_holmes gem
2018-08-01 10:41:20 +02:00
enum_site_setting.rb
…
enum.rb
…
excerpt_parser.rb
FIX: Calculation of text length for <details> in excerpt was wrong
2018-03-12 16:55:23 +01:00
feed_element_installer.rb
FEATURE: Replace SimpleRSS with Ruby RSS module (#5311)
2017-12-06 10:45:09 +11:00
feed_item_accessor.rb
FEATURE: Replace SimpleRSS with Ruby RSS module (#5311)
2017-12-06 10:45:09 +11:00
file_helper.rb
PERF: reduce workload when optimizing images
2019-01-09 12:28:18 +11:00
filter_best_posts.rb
…
final_destination.rb
FIX: preserve github fragment URL
2018-12-19 12:34:47 +05:30
flag_query.rb
Adjusts the minimum_flag_threshold for TL3/TL4 actions
2019-01-04 13:16:44 -05:00
flag_settings.rb
…
gaps.rb
…
global_path.rb
FIX: Incorrect CDN URL for site setting uploads when s3 is enabled.
2019-01-04 07:52:13 +08:00
guardian.rb
REFACTOR: Move option to return emails into the serializer
2019-01-11 11:17:23 -05:00
has_errors.rb
…
headless-ember.js
…
hijack.rb
DEV: avoid require_dependency for some libs
2018-12-31 10:53:30 +11:00
homepage_constraint.rb
FEATURE: Allow the user to select a custom home page (#5268)
2017-11-10 06:45:19 +11:00
html_prettify.rb
Update Rubocop to 0.60
2018-12-04 10:48:16 +01:00
html_to_markdown.rb
FIX: Font tag resulted in wrong email trimming
2018-12-18 11:40:54 +01:00
image_sizer.rb
FIX: raise exception when getting dimensions of missing image
2018-12-03 10:19:49 -05:00
inline_oneboxer.rb
FIX: Cache url data for failed inline oneboxes
2018-11-13 01:44:20 +05:30
introduction_updater.rb
FIX: Wizard tries harder to find existing Welcome Topic
2018-12-06 10:27:22 +01:00
ip_addr.rb
…
js_locale_helper.rb
DEV: Reload current client locale file in development mode
2019-01-15 22:55:51 +01:00
json_error.rb
FEATURE: Support backup uploads/downloads directly to/from S3.
2018-10-15 09:43:31 +08:00
letter_avatar.rb
FIX: don't generate an exception when trying to cleanup unexisting tmp letter avatars
2018-05-30 15:33:58 +02:00
markdown_linker.rb
FIX: subfolder digest emails have incorrect URLs
2018-08-07 16:38:17 -04:00
mem_info.rb
…
message_bus_diags.rb
…
method_profiler.rb
FIX: stop double counting net calls in logs
2018-02-28 10:45:11 +11:00
mini_sql_multisite_connection.rb
Move into MiniSQLMultisiteConnection, and add test for rollback
2018-07-24 09:41:55 +01:00
mobile_detection.rb
…
new_post_manager.rb
FIX: Don't enqueue topics if the user can't create them
2018-11-09 18:24:28 +01:00
new_post_result.rb
…
notification_levels.rb
…
oneboxer.rb
DEV: assign constant to preserve_fragment_url_hosts
2018-12-19 17:37:39 +05:30
onpdiff.rb
…
pbkdf2.rb
more prep work for jRuby
2018-02-26 10:25:58 +11:00
permalink_constraint.rb
…
pinned_check.rb
…
plain_text_to_markdown.rb
FEATURE: convert plain text emails to markdown
2017-12-06 01:47:51 +01:00
plugin_gem.rb
Override problematic .gemrc setting
2018-10-17 15:31:58 +11:00
post_action_creator.rb
…
post_creator.rb
FIX: Set unique post key for a user outside of transaction.
2019-01-08 15:22:22 +08:00
post_destroyer.rb
FIX: defer flags (only) when handling a flag and deleting replies (#6702)
2018-11-29 22:44:18 +05:30
post_enqueuer.rb
…
post_jobs_enqueuer.rb
FEATURE: Remove full quotes only from new posts. (#6862)
2019-01-17 13:24:32 +11:00
post_locker.rb
FEATURE: Staff members can lock posts
2018-01-26 14:01:30 -05:00
post_merger.rb
…
post_revisor.rb
FIX: make staff_edit_locks_post work with download_remote_images_to_local
2018-12-03 14:14:59 +11:00
pretty_text.rb
FIX: Fix mentions for mixed case group names
2018-11-26 15:34:56 +00:00
primary_group_lookup.rb
…
promotion.rb
FIX: Clarify User.group_locked_trust_level.
2018-11-07 10:27:44 +08:00
quote_comparer.rb
FEATURE: Add quote-modified class if a quote has been modified
2018-03-13 13:41:06 -04:00
rate_limiter.rb
correct return value
2018-04-25 08:44:07 +10:00
remap.rb
REFACTOR: move remap out of script into a class
2018-08-15 12:37:52 -04:00
retrieve_title.rb
Make rubocop happy again.
2018-06-07 13:28:18 +08:00
route_format.rb
FIX: RouteFormat is a better class name than RouteFormats
2017-12-21 15:30:32 -05:00
rtl.rb
…
s3_helper.rb
FIX: Add compatibility for bucket folder paths in migrate_to_s3 task (#6855)
2019-01-08 20:04:48 +05:30
score_calculator.rb
PERF: we have no use for topic percent rank
2018-07-05 15:10:19 +10:00
screening_model.rb
…
search.rb
FIX: do not show PM topics when moving posts to an existing public topic (#6876)
2019-01-14 15:00:45 +05:30
secure_session.rb
…
single_sign_on_provider.rb
FIX: move sso provider into its own class so it doesn't interfere with sso client (#6767)
2018-12-19 10:22:10 +01:00
single_sign_on.rb
FIX: move sso provider into its own class so it doesn't interfere with sso client (#6767)
2018-12-19 10:22:10 +01:00
site_setting_extension.rb
DEV: Stablize the multisite tests.
2019-01-16 10:29:36 +08:00
slug.rb
FIX: strip emoji string from slug
2018-04-18 11:32:32 +05:30
socket_server.rb
Improve error messaging in SocketServer.
2018-09-19 09:11:10 +08:00
source_url.rb
…
spam_handler.rb
…
sql_builder.rb
DEV: remove all calls to SqlBuilder use DB.build instead
2018-06-20 17:53:49 +10:00
staff_constraint.rb
Revert "FIX: Don't rate limit admin and staff constraints when matching routes."
2018-09-04 14:27:21 +08:00
staff_message_format.rb
More extensibility for custom silence/suspend messages
2018-01-19 11:35:19 -05:00
stats_socket.rb
…
suggested_topics_builder.rb
tweaks to related message list generation
2018-10-29 16:09:58 +11:00
system_message.rb
…
text_cleaner.rb
FIX: Skip gsub for normalizing whitespaces when text is nil (#6631)
2018-11-20 09:12:32 +01:00
text_sentinel.rb
rename 'min_private_message_{post/title}_length' to 'min_personal_message_{post/title}_length'
2018-02-01 13:25:29 +05:30
theme_javascript_compiler.rb
FIX: Wrap theme javascript inside IIFE to prevent using global namespace
2019-01-17 14:44:10 +00:00
theme_settings_manager.rb
PERF: Eradicate N+1 queries from the theme admin page
2018-12-21 11:03:58 +02:00
theme_settings_parser.rb
FEATURE: introduces list/compact_list components
2018-08-03 16:41:37 -04:00
theme_translation_manager.rb
FEATURE: Support for localized themes (#6848)
2019-01-17 11:46:11 +00:00
theme_translation_parser.rb
FEATURE: Support for localized themes (#6848)
2019-01-17 11:46:11 +00:00
timeline_lookup.rb
PERF: Don't pluck all the columns just to retrieve a single value.
2018-06-27 11:41:35 +08:00
topic_creator.rb
FIX: don't double add users to topic allowed users
2018-12-10 14:45:02 +11:00
topic_list_responder.rb
…
topic_publisher.rb
FIX: Update last_version_at when publishing
2018-03-26 16:06:20 -04:00
topic_query_sql.rb
DEV: Rails 5.2 upgrade and global gem upgrade
2018-06-07 14:21:33 +10:00
topic_query.rb
FIX: remove slow platform detection from server side
2018-12-13 13:57:05 +11:00
topic_retriever.rb
Make rubocop happy again.
2018-06-07 13:28:18 +08:00
topic_subtype.rb
…
topic_view.rb
FIX: remove slow platform detection from server side
2018-12-13 13:57:05 +11:00
topics_bulk_action.rb
FIX: Bulk deleting topics should ignore already deleted topics
2018-08-14 16:37:52 +02:00
trust_level.rb
…
twitter_api.rb
FIX: allow Twitter videos to go fullscreen
2018-07-19 10:22:36 +05:30
unread.rb
…
upload_creator.rb
DEV: speed up posts base imports
2019-01-04 15:30:17 +01:00
upload_fixer.rb
typo in error message
2018-08-10 11:34:01 +10:00
upload_recovery.rb
Fix UploadRecovery from S3 fails with bucket name containing sub-folder.
2018-10-01 19:03:02 +08:00
url_helper.rb
FIX: URLs containing two # would fail to work
2018-12-11 18:03:13 +11:00
user_name_suggester.rb
FIX: don't raise an error on integer usernames
2018-09-10 22:17:56 +05:30
version.rb
Version bump to v2.2.0.beta8
2019-01-14 17:03:18 -05:00
wizard.rb
…