Discource-C/discourse
1
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-06 11:28:18 +00:00
Code Issues Packages Projects Releases Wiki Activity
discourse/spec/components
History
Martin Brennan 3b13f1146b
FIX: Add random suffix to outbound Message-ID for email (#15179) 
Currently the Message-IDs we send out for outbound email
are not unique; for a post they look like:

topic/TOPIC_ID/POST_ID@HOST

And for a topic they look like:

topic/TOPIC_ID@HOST

This commit changes the outbound Message-IDs to also have
a random suffix before the host, so the new format is
like this:

topic/TOPIC_ID/POST_ID.RANDOM_SUFFIX@HOST

Or:

topic/TOPIC_ID.RANDOM_SUFFIX@HOST

This should help with email deliverability. This change
is backwards-compatible, the old Message-ID format will
still be recognized in the mail receiver flow, so people
will still be able to reply using Message-IDs, In-Reply-To,
and References headers that have already been sent.

This commit also refactors Message-ID related logic
to a central location, and adds judicious amounts of
tests and documentation.
2021-12-06 10:34:39 +10:00
..
auth
FEATURE: Apply rate limits per user instead of IP for trusted users (#14706)
2021-11-17 23:27:30 +03:00
common_passwords
DEV: Upgrading Discourse to Zeitwerk (#8098)
2019-10-02 14:01:53 +10:00
concern
FIX: Nil-filled CF arrays were not being deleted (#13518)
2021-06-25 11:34:51 +02:00
email
FIX: Add random suffix to outbound Message-ID for email (#15179)
2021-12-06 10:34:39 +10:00
file_store
FEATURE: Direct S3 multipart uploads for backups (#14736)
2021-11-11 08:25:31 +10:00
freedom_patches
FIX: Ensure id sequences are not reset during db:migrate (#14184)
2021-08-30 12:31:22 +01:00
guardian
FEATURE: Allow admins to permanently delete posts and topics (#14406)
2021-10-13 12:53:23 +03:00
highlight_js
DEV: Upgrading Discourse to Zeitwerk (#8098)
2019-10-02 14:01:53 +10:00
imap
DEV: Move imap_helper to spec/support directory (#14776)
2021-10-29 20:46:25 +02:00
import
DEV: Upgrading Discourse to Zeitwerk (#8098)
2019-10-02 14:01:53 +10:00
middleware
FEATURE: Apply rate limits per user instead of IP for trusted users (#14706)
2021-11-17 23:27:30 +03:00
migration
FIX: Allow post migrations using #change to carry out unsafe migration
2020-05-15 14:23:27 +08:00
plugin
REFACTOR: Improve support for consolidating notifications. (#14904)
2021-11-30 13:36:14 -03:00
pretty_text
SPEC: 'lookup_upload_urls' method should use cdn url if available.
2019-10-14 12:57:33 +05:30
rate_limiter
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
scheduler
DEV: reduce logging when no external id is specified
2020-04-08 12:42:28 +10:00
site_settings
DEV: Remove HTML setting type and sanitization logic. (#14440)
2021-10-04 15:40:35 -03:00
stylesheet
FIX: Order outputted theme stylesheets (#14133)
2021-08-25 09:37:07 +08:00
svg_sprite
DEV: prevents flakky spec when deleting plugin (#14701)
2021-10-25 10:24:21 +02:00
theme_store
FIX: Git should not prompt for credentials (#15062)
2021-11-23 13:54:51 +02:00
validators
FEATURE: Humanize file size error messages (#14398)
2021-09-22 07:59:45 +10:00
wizard
FEATURE: Enable auto dark mode on new instances (#14208)
2021-09-02 14:55:38 -04:00
admin_confirmation_spec.rb
Update rubocop to 2.3.1.
2020-07-24 17:19:21 +08:00
admin_user_index_query_spec.rb
DEV: Correct typos and spelling mistakes (#12812)
2021-05-21 11:43:47 +10:00
archetype_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
cache_spec.rb
FIX: ensures defined expired_in is passed from write to write_entry (#11622)
2021-01-04 10:34:44 +01:00
category_badge_spec.rb
FIX: Correctly escape category description text (#8107)
2019-10-01 12:04:39 -04:00
composer_messages_finder_spec.rb
FEATURE: Make allow_uploaded_avatars accept TL (#14091)
2021-08-24 10:46:28 +03:00
content_buffer_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
cooked_post_processor_spec.rb
DEV: Remove xlink hrefs (#15059)
2021-11-25 15:22:43 +11:00
crawler_detection_spec.rb
FEATURE: Implement browser update in crawler view (#12448)
2021-03-22 19:41:42 +02:00
current_user_spec.rb
FEATURE: Apply rate limits per user instead of IP for trusted users (#14706)
2021-11-17 23:27:30 +03:00
directory_helper_spec.rb
DEV: Upgrading Discourse to Zeitwerk (#8098)
2019-10-02 14:01:53 +10:00
discourse_diff_spec.rb
Escape values of HTML attributes
2021-08-10 10:25:15 -04:00
discourse_event_spec.rb
DEV: Plugin API to add directory columns (#13440)
2021-06-22 13:00:04 -05:00
discourse_hub_spec.rb
DEV: Upgrading Discourse to Zeitwerk (#8098)
2019-10-02 14:01:53 +10:00
discourse_plugin_registry_spec.rb
DEV: Remove deprecated plugins variables importer (#12168)
2021-02-23 16:20:59 -05:00
discourse_redis_spec.rb
DEV: Pass kwargs to the redis gem when calling methods/commands that we don't wrap (#14530)
2021-10-06 17:42:04 +03:00
discourse_spec.rb
SECURITY: Remove ember-cli specific response from application routes (#15155)
2021-12-01 16:10:40 +00:00
discourse_tagging_spec.rb
FIX: Keep existent tags when editing tag topics (#15050)
2021-11-23 13:00:45 +02:00
discourse_updates_spec.rb
FIX: Regression introduced in #14715 (#14842)
2021-11-09 17:20:09 +11:00
distributed_memoizer_spec.rb
DEV: s/\$redis/Discourse\.redis (#8431)
2019-12-03 10:05:53 +01:00
distributed_mutex_spec.rb
DEV: Improve flaky time-sensitive specs (#9141)
2020-03-10 22:13:17 +01:00
email_cook_spec.rb
DEV: Correct typos and spelling mistakes (#12812)
2021-05-21 11:43:47 +10:00
email_updater_spec.rb
DEV: Hash tokens stored from email_tokens (#14493)
2021-11-25 09:34:39 +02:00
enum_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
excerpt_parser_spec.rb
FIX: Make Oneboxer#apply insert block Oneboxes correctly (#11449)
2020-12-14 17:49:37 +02:00
feed_element_installer_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
feed_item_accessor_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
file_helper_spec.rb
DEV: properly clean up temp files in FileHelper spec
2019-05-28 11:33:08 +10:00
filter_best_posts_spec.rb
DEV: Prefabrication (test optimization) (#7414)
2019-05-07 13:12:20 +10:00
final_destination_spec.rb
FIX: Canonical URLs may be relative (#14825)
2021-11-05 14:20:14 -03:00
flag_settings_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
gaps_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
global_path_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
guardian_spec.rb
FEATURE: Mention @here to notify users in topic (#14900)
2021-11-23 22:25:54 +02:00
has_errors_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
hijack_spec.rb
FEATURE: Apply rate limits per user instead of IP for trusted users (#14706)
2021-11-17 23:27:30 +03:00
html_prettify_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
html_to_markdown_spec.rb
FIX: Hoisting linebreaks shouldn't fail for HTML5 elements (#14364)
2021-09-17 10:41:34 +02:00
image_sizer_spec.rb
DEV: Correct typos and spelling mistakes (#12812)
2021-05-21 11:43:47 +10:00
inline_oneboxer_spec.rb
DEV: Correct typos and spelling mistakes (#12812)
2021-05-21 11:43:47 +10:00
js_locale_helper_spec.rb
FEATURE: Add English (UK) as locale (#11768)
2021-01-20 21:32:22 +01:00
json_error_spec.rb
DEV: Correct typos and spelling mistakes (#12812)
2021-05-21 11:43:47 +10:00
letter_avatar_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
method_profiler_spec.rb
DEV: Upgrading Discourse to Zeitwerk (#8098)
2019-10-02 14:01:53 +10:00
new_post_manager_spec.rb
DEV: Correct typos and spelling mistakes (#12812)
2021-05-21 11:43:47 +10:00
new_post_result_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
oneboxer_spec.rb
FIX: Use CDN URL for internal onebox avatars (#15077)
2021-11-25 12:07:34 +00:00
onpdiff_spec.rb
DEV: Correct typos and spelling mistakes (#12812)
2021-05-21 11:43:47 +10:00
pbkdf2_spec.rb
DEV: Load rails_helper in pbkdf2_spec (#14775)
2021-10-29 20:15:10 +02:00
pinned_check_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
plain_text_to_markdown_spec.rb
FIX: use URI.regexp to find URLs in plain text
2019-06-07 01:26:06 +02:00
post_action_creator_spec.rb
PERF: Shave off some test-suite time (#15183)
2021-12-03 14:54:07 -06:00
post_creator_spec.rb
DEV: Ignore bookmarks.topic_id column and remove references to it in code (#14289)
2021-09-15 10:16:54 +10:00
post_destroyer_spec.rb
FIX: Skip post validations for system revisions when author deletes post (#14824)
2021-11-08 09:33:41 +08:00
post_locker_spec.rb
DEV: Upgrading Discourse to Zeitwerk (#8098)
2019-10-02 14:01:53 +10:00
post_merger_spec.rb
FIX: TL4 users cannot delete others posts (#13554)
2021-06-30 15:51:35 +03:00
post_revisor_spec.rb
FIX: Make PostRevisor more consistent (#14841)
2021-11-09 16:29:37 +02:00
presence_channel_spec.rb
DEV: Introduce PresenceChannel API for core and plugin use
2021-08-27 16:26:06 +01:00
pretty_text_spec.rb
SECURITY: Strip unrendered unicode bidirectional chars in code blocks (#15032)
2021-11-22 10:43:03 +10:00
promotion_spec.rb
FIX: check if BasicBadge is enabled for TL1 welcome message (#13983)
2021-08-11 08:39:25 +10:00
quote_comparer_spec.rb
DEV: Prefabrication (test optimization) (#7414)
2019-05-07 13:12:20 +10:00
rate_limiter_spec.rb
No need to disable rate limiter after running tests (#13093)
2021-05-19 16:04:35 +04:00
redis_store_spec.rb
DEV: Implement a faster Discourse.cache
2019-11-27 16:11:49 +11:00
retrieve_title_spec.rb
FIX: increase chunk size to fetch title tag correctly (#14144)
2021-09-03 13:15:58 +05:30
rtl_spec.rb
DEV: Upgrading Discourse to Zeitwerk (#8098)
2019-10-02 14:01:53 +10:00
s3_helper_spec.rb
FIX: Ensure CORS rules exist for S3 using rake task (#14802)
2021-11-08 09:16:38 +10:00
s3_inventory_multisite_spec.rb
DEV: Isolate multisite specs (#13634)
2021-07-07 18:57:42 +02:00
s3_inventory_spec.rb
DEV: Isolate multisite specs (#13634)
2021-07-07 18:57:42 +02:00
score_calculator_spec.rb
DEV: Prefabrication (test optimization) (#7414)
2019-05-07 13:12:20 +10:00
scss_checker_spec.rb
PERF: Eager load Theme associations in Stylesheet Manager.
2021-06-21 11:06:58 +08:00
search_spec.rb
FIX: Use the same mode for chinese search when indexing and querying. (#14780)
2021-11-01 10:14:47 +08:00
secure_session_spec.rb
DEV: correct implementation of expiry api
2019-11-11 11:18:12 +11:00
site_icon_manager_spec.rb
DEV: enable frozen string literal on all files
2019-05-13 09:31:32 +08:00
site_setting_extension_multisite_spec.rb
DEV: Isolate multisite specs (#13634)
2021-07-07 18:57:42 +02:00
site_setting_extension_spec.rb
DEV: Remove site_setting_saved event (#15164)
2021-12-02 09:33:03 -06:00
slug_spec.rb
DEV: Correct typos and spelling mistakes (#12812)
2021-05-21 11:43:47 +10:00
spam_handler_spec.rb
FIX: use allowlist and blocklist terminology (#10209)
2020-07-27 10:23:54 +10:00
suggested_topics_builder_spec.rb
DEV: Default to skipping creating a topic when fabricating categories (#7976)
2019-08-06 11:26:54 +01:00
system_message_spec.rb
FIX: TL2 promotion message and advance training (#10679)
2020-09-22 10:17:52 +10:00
text_cleaner_spec.rb
FEATURE: Correctly convert topic title to uppercase and lowercase for Turkish default locale (#13115)
2021-05-24 18:13:30 +10:00
text_sentinel_spec.rb
FIX: prevents exception when text input is nil (#12922)
2021-05-03 09:21:35 +02:00
theme_settings_manager_spec.rb
DEV: use upload id to save in theme setting instead of URL. (#14341)
2021-09-16 07:58:53 +05:30
theme_settings_parser_spec.rb
DEV: Don't user before(:all)/after(:all) (#13389)
2021-06-15 17:25:06 +02:00
timeline_lookup_spec.rb
DEV: followup to 8edd2b38cb to use existing spec (#11830)
2021-01-25 12:04:27 +01:00
topic_creator_spec.rb
FIX: include new tags in validation if user can create one. (#14744)
2021-10-28 11:59:46 +05:30
topic_publisher_spec.rb
DEV: Improve flaky time-sensitive specs (#9141)
2020-03-10 22:13:17 +01:00
topic_query_spec.rb
FIX: use category's default sort order in latest & unseen filters only. (#14571)
2021-10-12 10:25:03 +05:30
topic_retriever_spec.rb
FEATURE: Stop checking referer for embeds (#13756)
2021-07-16 15:25:49 -03:00
topic_view_spec.rb
DEV: Fix a flaky bookmarks test (#15129)
2021-12-01 08:56:00 +11:00
topics_bulk_action_spec.rb
FEATURE: Dismiss new and unread for PM inboxes.
2021-08-05 12:56:15 +08:00
trashable_spec.rb
DEV: Upgrading Discourse to Zeitwerk (#8098)
2019-10-02 14:01:53 +10:00
trust_level_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
unread_spec.rb
FEATURE: Add last visit indication to topic view page. (#13471)
2021-07-05 14:17:31 +08:00
url_helper_spec.rb
FIX: errors loading secure uploads when secure uploads is disabled (#13047)
2021-06-08 13:25:51 -04:00
user_lookup_spec.rb
REVERT "FIX: do not show private group flair on user avatars" (#13991)
2021-08-10 17:25:11 +05:30
user_name_suggester_spec.rb
DEV: simplify username suggester (#14531)
2021-10-27 14:41:24 +04:00
version_spec.rb
DEV: Fix an apparently "too modern" git command (#10894)
2020-10-12 22:54:56 +02:00