discourse/spec/components/file_store/local_store_spec.rb
Sam Saffron 4ea21fa2d0 DEV: use #frozen_string_literal: true on all spec
This change both speeds up specs (less strings to allocate) and helps catch
cases where methods in Discourse are mutating inputs.

Overall we will be migrating everything to use #frozen_string_literal: true
it will take a while, but this is the first and safest move in this direction
2019-04-30 10:27:42 +10:00

154 lines
4.4 KiB
Ruby

# frozen_string_literal: true
require 'rails_helper'
require 'file_store/local_store'
describe FileStore::LocalStore do
let(:store) { FileStore::LocalStore.new }
let(:upload) { Fabricate(:upload) }
let(:uploaded_file) { file_from_fixtures("logo.png") }
let(:optimized_image) { Fabricate(:optimized_image) }
describe "#store_upload" do
it "returns a relative url" do
store.expects(:copy_file)
expect(store.store_upload(uploaded_file, upload)).to match(/\/uploads\/default\/original\/.+#{upload.sha1}\.png/)
end
end
describe "#store_optimized_image" do
it "returns a relative url" do
store.expects(:copy_file)
expect(store.store_optimized_image({}, optimized_image)).to match(/\/uploads\/default\/optimized\/.+#{optimized_image.upload.sha1}_#{OptimizedImage::VERSION}_100x200\.png/)
end
end
describe "#remove_upload" do
it "does not delete non uploaded" do
FileUtils.expects(:mkdir_p).never
store.remove_upload(upload)
end
it "moves the file to the tombstone" do
begin
upload = UploadCreator.new(
file_from_fixtures("smallest.png"),
"smallest.png"
).create_for(Fabricate(:user).id)
path = store.path_for(upload)
mtime = File.mtime(path)
sleep 0.01 # Delay a little for mtime to be updated
store.remove_upload(upload)
tombstone_path = path.sub("/uploads/", "/uploads/tombstone/")
expect(File.exist?(tombstone_path)).to eq(true)
expect(File.mtime(tombstone_path)).to_not eq(mtime)
ensure
[path, tombstone_path].each do |file_path|
File.delete(file_path) if File.exist?(file_path)
end
end
end
end
describe "#remove_optimized_image" do
it "moves the file to the tombstone" do
begin
upload = UploadCreator.new(
file_from_fixtures("smallest.png"),
"smallest.png"
).create_for(Fabricate(:user).id)
upload.create_thumbnail!(1, 1)
upload.reload
optimized_image = upload.thumbnail(1, 1)
path = store.path_for(optimized_image)
store.remove_optimized_image(optimized_image)
tombstone_path = path.sub("/uploads/", "/uploads/tombstone/")
expect(File.exist?(tombstone_path)).to eq(true)
ensure
[path, tombstone_path].each do |file_path|
File.delete(file_path) if File.exist?(file_path)
end
end
end
end
describe "#has_been_uploaded?" do
it "identifies relatives urls" do
expect(store.has_been_uploaded?("/uploads/default/42/0123456789ABCDEF.jpg")).to eq(true)
end
it "identifies local urls" do
Discourse.stubs(:base_url_no_prefix).returns("http://discuss.site.com")
expect(store.has_been_uploaded?("http://discuss.site.com/uploads/default/42/0123456789ABCDEF.jpg")).to eq(true)
expect(store.has_been_uploaded?("//discuss.site.com/uploads/default/42/0123456789ABCDEF.jpg")).to eq(true)
end
it "identifies local urls when using a CDN" do
Rails.configuration.action_controller.stubs(:asset_host).returns("http://my.cdn.com")
expect(store.has_been_uploaded?("http://my.cdn.com/uploads/default/42/0123456789ABCDEF.jpg")).to eq(true)
expect(store.has_been_uploaded?("//my.cdn.com/uploads/default/42/0123456789ABCDEF.jpg")).to eq(true)
end
it "does not match dummy urls" do
expect(store.has_been_uploaded?("http://domain.com/uploads/default/42/0123456789ABCDEF.jpg")).to eq(false)
expect(store.has_been_uploaded?("//domain.com/uploads/default/42/0123456789ABCDEF.jpg")).to eq(false)
end
end
def stub_for_subfolder
GlobalSetting.stubs(:relative_url_root).returns('/forum')
Discourse.stubs(:base_uri).returns("/forum")
end
describe "#absolute_base_url" do
it "is present" do
expect(store.absolute_base_url).to eq("http://test.localhost/uploads/default")
end
it "supports subfolder" do
stub_for_subfolder
expect(store.absolute_base_url).to eq("http://test.localhost/forum/uploads/default")
end
end
describe "#relative_base_url" do
it "is present" do
expect(store.relative_base_url).to eq("/uploads/default")
end
it "supports subfolder" do
stub_for_subfolder
expect(store.relative_base_url).to eq("/forum/uploads/default")
end
end
it "is internal" do
expect(store.internal?).to eq(true)
expect(store.external?).to eq(false)
end
end