Discource-C/discourse
1
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-11 13:55:07 +00:00
Code Issues Packages Projects Releases Wiki Activity
discourse/spec/models
History
Krzysztof Kotlarek 65a3fdbc57
FIX: randomly failing user_spec (#9754) 
* FIX: randomly falling user_spec

When we evaluate `update_last_seen!` we relay on Redis to not run that code too often

https://github.com/discourse/discourse/blob/master/app/models/user.rb#L753

The problem is that not all specs which are running `update_last_seen!` are not cleaning after themselves

For examples specs in that block https://github.com/discourse/discourse/blob/master/spec/models/user_spec.rb#L901

So it can be replicated when you run a few times
`bundle exec rspec  ./spec/models/user_spec.rb -e "should not update the first seen value if it doesn't exist" -e "should have 0 for days_visited"`

We should delete Redis key after each spec which is evaluating `update_last_seen!`
2020-05-15 09:24:07 +10:00
..
about_spec.rb
PERF: speed up about page render time and limit category mods (#8112)
2019-10-03 21:48:56 +03:00
admin_dashboard_problem_spec.rb
Remove very bad tests
2020-03-06 09:35:55 -05:00
api_key_spec.rb
FEATURE: Hash API keys in the database (#8438)
2019-12-12 11:45:00 +00:00
application_request_spec.rb
DEV: s/\$redis/Discourse\.redis (#8431)
2019-12-03 10:05:53 +01:00
badge_spec.rb
FIX: error customizing text for badges from plugins
2020-04-28 14:34:41 -04:00
badge_type_spec.rb
DEV: Upgrading Discourse to Zeitwerk (#8098)
2019-10-02 14:01:53 +10:00
category_featured_topic_spec.rb
FEATURE: remove support for 'suppress_from_latest' category setting. (#8308)
2019-11-18 12:28:35 +05:30
category_group_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
category_list_spec.rb
FEATURE: Demote muted categories on category list (#9226)
2020-03-17 15:33:15 -05:00
category_spec.rb
FIX: Set category description to first posts cooked value (#9478)
2020-04-20 14:51:49 -05:00
category_user_spec.rb
DEV: Upgrading Discourse to Zeitwerk (#8098)
2019-10-02 14:01:53 +10:00
child_theme_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
color_scheme_color_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
color_scheme_spec.rb
DEV: update rubocop to version 0.77
2019-12-10 11:48:39 +11:00
developer_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
digest_email_site_setting_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
directory_item_spec.rb
DEV: improve flaky spec
2019-10-04 11:11:03 +10:00
discourse_single_sign_on_spec.rb
FEATURE: support SSO website and location overrides
2020-04-28 16:06:35 +10:00
draft_sequence_spec.rb
PERF: Avoid hitting DB when fetching draft sequence of bot user.
2020-05-12 13:56:58 +08:00
draft_spec.rb
FIX: saving drafts unconditionally increases sequence
2020-05-12 16:55:42 +10:00
email_change_request_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
email_log_spec.rb
DEV: Prefabrication (test optimization) (#7414)
2019-05-07 13:12:20 +10:00
email_token_spec.rb
DEV: Prefabrication (test optimization) (#7414)
2019-05-07 13:12:20 +10:00
embeddable_host_spec.rb
DEV: Remove RSS feed polling in favor of plugin (#8233)
2019-11-12 09:49:02 -06:00
emoji_spec.rb
FIX: allows replacement of digits and symbols emojis (#7978)
2019-08-07 11:38:58 +02:00
given_daily_like_spec.rb
DEV: Prefabrication (test optimization) (#7414)
2019-05-07 13:12:20 +10:00
global_setting_spec.rb
DEV: s/\$redis/Discourse\.redis (#8431)
2019-12-03 10:05:53 +01:00
group_history_spec.rb
DEV: Prefabrication (test optimization) (#7414)
2019-05-07 13:12:20 +10:00
group_spec.rb
UX: drop the automatic_membership_retroactive column from groups model. (#9430)
2020-04-22 22:07:39 +05:30
group_user_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
incoming_link_spec.rb
DEV: Prefabrication (test optimization) (#7414)
2019-05-07 13:12:20 +10:00
incoming_links_report_spec.rb
DEV: Prefabrication (test optimization) (#7414)
2019-05-07 13:12:20 +10:00
invite_redeemer_spec.rb
FEATURE: add setting auto_approve_email_domains to auto approve users (#9323)
2020-03-31 23:59:15 +05:30
invite_spec.rb
DEV: Improve flaky time-sensitive specs (#9141)
2020-03-10 22:13:17 +01:00
javascript_cache_spec.rb
DEV: Prefabrication (test optimization) (#7414)
2019-05-07 13:12:20 +10:00
locale_site_setting_spec.rb
DEV: clean up potential locale leak
2019-06-03 12:42:29 +10:00
mailing_list_mode_site_setting_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
notification_spec.rb
DEV: Allow specifying if a notification is high_priority on create (#9660)
2020-05-07 14:35:32 +10:00
optimized_image_spec.rb
DEV: attempt to stabilize flaky spec
2020-03-06 12:57:12 +11:00
permalink_spec.rb
FIX: Permalinks should redirect to category URL including the ID
2020-03-20 22:06:20 +00:00
plugin_store_spec.rb
DEV: Upgrading Discourse to Zeitwerk (#8098)
2019-10-02 14:01:53 +10:00
post_action_spec.rb
DEV: Improve flaky time-sensitive specs (#9141)
2020-03-10 22:13:17 +01:00
post_action_type_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
post_analyzer_spec.rb
FIX: Ignore group mentions inside quotes (#8905)
2020-02-10 18:31:42 +01:00
post_detail_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
post_mover_spec.rb
FIX: when a post is moved copy notifications level (#9311)
2020-03-31 16:19:47 +11:00
post_reply_key_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
post_reply_spec.rb
DEV: update dependencies and add notes about exceptions
2019-12-06 13:00:28 +11:00
post_spec.rb
DEV: Update rubocop-discourse (#9270)
2020-03-26 16:32:41 +01:00
post_timing_spec.rb
FIX: Decrement posts read count when destroying post timings (#8172)
2019-10-08 15:39:23 -03:00
post_upload_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
published_page_spec.rb
FEATURE: Support for publishing topics as pages (#9364)
2020-04-08 12:52:36 -04:00
quoted_post_spec.rb
DEV: Improve flaky time-sensitive specs (#9141)
2020-03-10 22:13:17 +01:00
remote_theme_spec.rb
FEATURE: Allow themes to specify modifiers in their about.json file (#9097)
2020-03-11 13:30:45 +00:00
report_spec.rb
FEATURE: Make report filters reusable (#9444)
2020-04-22 11:52:50 +03:00
reviewable_claimed_topic_spec.rb
FIX: Don't log a claimed topic database error during tests
2020-01-09 12:32:05 -05:00
reviewable_flagged_post_spec.rb
FEATURE: Unassign the review queue topic when a flag is handled
2020-03-24 14:57:44 -07:00
reviewable_history_spec.rb
DEV: Prefabrication (test optimization) (#7414)
2019-05-07 13:12:20 +10:00
reviewable_queued_post_spec.rb
DEV: Allow specifying button class in reviewable action definitions (#8093)
2019-09-18 11:28:59 +01:00
reviewable_score_spec.rb
FIX: Bots accuracy should be zero (#8654)
2020-01-02 13:24:24 -03:00
reviewable_spec.rb
FIX: Prevent column name conflicts in reviewable code (#9753)
2020-05-13 09:05:56 +10:00
reviewable_user_spec.rb
DEV: Prefabrication (test optimization) (#7414)
2019-05-07 13:12:20 +10:00
s3_region_site_setting_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
screened_email_spec.rb
FEATURE: when blocking emails prefer blocking canonical
2020-04-24 14:09:51 +10:00
screened_ip_address_spec.rb
DEV: Prefabrication (test optimization) (#7414)
2019-05-07 13:12:20 +10:00
screened_url_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
search_log_spec.rb
DEV: s/\$redis/Discourse\.redis (#8431)
2019-12-03 10:05:53 +01:00
site_setting_spec.rb
DEV: Add rubocop-rspec (#9288)
2020-03-27 17:35:40 +01:00
site_spec.rb
FEATURE: support to mute all categories by default. (#8295)
2019-11-08 08:28:11 +05:30
skipped_email_log_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
stylesheet_cache_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
tag_group_spec.rb
FIX: remove parent tag from tag group
2020-03-13 12:25:58 -04:00
tag_spec.rb
FEATURE: Tag synonyms
2019-12-04 13:33:51 -05:00
tag_user_spec.rb
FEATURE: Tag synonyms
2019-12-04 13:33:51 -05:00
theme_field_spec.rb
FIX: Using the default_locale in locale fallbacks caused problems
2020-05-06 22:59:07 +02:00
theme_modifier_set_spec.rb
DEV: Allow plugins to add theme modifiers via db migrations (#9192)
2020-03-12 16:35:28 +00:00
theme_spec.rb
FIX: Using the default_locale in locale fallbacks caused problems
2020-05-06 22:59:07 +02:00
top_menu_item_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
top_topic_spec.rb
DEV: correct spec failures in PG 12
2019-11-26 16:39:14 +11:00
topic_allowed_user_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
topic_converter_spec.rb
FIX: Limit personal message participants when converting from topic (#9343)
2020-04-03 16:42:01 +01:00
topic_embed_spec.rb
FEATURE: Nokogumbo (#9577)
2020-05-05 13:46:57 +10:00
topic_featured_users_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
topic_group_spec.rb
FIX: Constraint error when inserting the same topic group twice
2019-12-12 13:10:46 -05:00
topic_invite_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
topic_link_click_spec.rb
DEV: Prefabrication (test optimization) (#7414)
2019-05-07 13:12:20 +10:00
topic_link_spec.rb
PERF: avoid race conditions when creating topic links
2020-05-13 16:05:57 +10:00
topic_list_spec.rb
DEV: Prefabrication (test optimization) (#7414)
2019-05-07 13:12:20 +10:00
topic_participants_summary_spec.rb
DEV: Better topic participants summary spec
2019-11-18 09:43:14 -05:00
topic_posters_summary_spec.rb
DEV: Prefabrication (test optimization) (#7414)
2019-05-07 13:12:20 +10:00
topic_spec.rb
FEATURE: Make report filters reusable (#9444)
2020-04-22 11:52:50 +03:00
topic_tag_spec.rb
DEV: Prefabrication (test optimization) (#7414)
2019-05-07 13:12:20 +10:00
topic_thumbnail_spec.rb
FEATURE: Include optimized thumbnails for topics (#9215)
2020-05-05 09:07:50 +01:00
topic_timer_spec.rb
DEV: Fix topic_timer_spec (#9483)
2020-04-21 14:38:35 +10:00
topic_tracking_state_spec.rb
FIX: the muted message should be sent after edit (#9593)
2020-05-01 08:33:57 +10:00
topic_user_spec.rb
DEV: fix deprecation warnings in specs
2020-01-23 16:37:48 +01:00
topic_view_item_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
translation_override_spec.rb
FIX: Display site text overrides for non '_MF' keys (#8189)
2019-10-17 18:34:07 +02:00
trust_level3_requirements_spec.rb
DEV: Update tl3 spec to remove hard-coded primary keys
2020-04-17 17:24:14 +01:00
unsubscribe_key_spec.rb
DEV: Upgrading Discourse to Zeitwerk (#8098)
2019-10-02 14:01:53 +10:00
upload_spec.rb
FIX: Copying image markdown for secure media loading full image (#9488)
2020-04-24 10:29:02 +10:00
user_action_spec.rb
DEV: Improve flaky time-sensitive specs (#9141)
2020-03-10 22:13:17 +01:00
user_api_key_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
user_archived_message_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
user_auth_token_spec.rb
DEV: Improve flaky time-sensitive specs (#9141)
2020-03-10 22:13:17 +01:00
user_avatar_spec.rb
FIX: reset gravatar cache by adding random param to URL (#9370)
2020-04-08 07:35:42 +10:00
user_badge_spec.rb
PERF: Cache ranks for featured badges, to simplify user serialization (#8698)
2020-01-14 14:26:49 +00:00
user_email_spec.rb
DEV: Upgrading Discourse to Zeitwerk (#8098)
2019-10-02 14:01:53 +10:00
user_export_spec.rb
REVERT: DEV: should ignore missing post uploads when a user export destroyed
2019-07-25 19:41:25 +05:30
user_field_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
user_history_spec.rb
DEV: Prefabrication (test optimization) (#7414)
2019-05-07 13:12:20 +10:00
user_option_spec.rb
DEV: Upgrading Discourse to Zeitwerk (#8098)
2019-10-02 14:01:53 +10:00
user_profile_spec.rb
Revert "FIX: Add missing unique index on user_id for user_profiles."
2019-05-24 12:58:36 +08:00
user_profile_view_spec.rb
DEV: Prefabrication (test optimization) (#7414)
2019-05-07 13:12:20 +10:00
user_search_spec.rb
SECURITY: Check permissions when autocompleting mentions
2019-10-28 11:01:47 +00:00
user_second_factor_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
user_spec.rb
FIX: randomly failing user_spec (#9754)
2020-05-15 09:24:07 +10:00
user_stat_spec.rb
DEV: Improve flaky time-sensitive specs (#9141)
2020-03-10 22:13:17 +01:00
user_summary_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
user_visit_spec.rb
DEV: Prefabrication (test optimization) (#7414)
2019-05-07 13:12:20 +10:00
username_validator_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
watched_word_spec.rb
DEV: Improve flaky time-sensitive specs (#9141)
2020-03-10 22:13:17 +01:00
web_crawler_request_spec.rb
DEV: s/\$redis/Discourse\.redis (#8431)
2019-12-03 10:05:53 +01:00
web_hook_event_spec.rb
DEV: use #frozen_string_literal: true on all spec
2019-04-30 10:27:42 +10:00
web_hook_spec.rb
FEATURE: Webhooks and Event for user being granted a badge
2020-04-08 14:38:30 -07:00