Sam a7628c1d74 FIX: use ordered_posts for last post check, not the posts relation ...

The `posts` relation on `Topic` is not ordered. Using `Topic.posts.first`
is basically the same as asking for a random post, it will depend on DB
order. This breaks on Topic merge and split for example.

Additionally, a huge problem with that is that it forces active record down
a slow path. `Topic.posts.first` is extremely slow on giant topics, since
it has no default ordering it appears AR materializes the entire set prior
to doing `first`.

This commit also illustrates the importance of testing, initially I only
fixed the second instance of the problem in `post_validator.rb` but testing
revealed that the problem was repeated at the top of the file.

Longer term we should consider a larger change of default ordering the posts
relations so people do not fall down this trap anymore.

2019-01-18 13:18:40 +11:00

..

active_record/connection_adapters

DEV: Improve postgresql fallover and multisite tests.

2019-01-15 12:52:45 +08:00

auth

DEV: Style and performance improvements

2018-12-11 09:58:20 +00:00

common_passwords

Add rubocop to our build. (#5004)

2017-07-28 10:20:09 +09:00

concern

FIX: ignore and log bad json values for custom fields

2018-09-13 14:26:30 +05:30

email

FIX: Allow sending test e-mails to any email address when disable_email is set to non-staff (#6792)

2018-12-18 16:12:05 +01:00

file_store

FIX: Heisentest

2019-01-16 15:01:50 -05:00

freedom_patches

FIX: async reload of locales could result in missing translations

2018-10-01 17:14:36 +02:00

guardian

SECURITY: Users can pick non-avatar uploads.

2018-12-18 13:38:25 +08:00

highlight_js

Add rubocop to our build. (#5004)

2017-07-28 10:20:09 +09:00

import

Add rubocop to our build. (#5004)

2017-07-28 10:20:09 +09:00

middleware

FIX: error in response body to blocked crawlers, showing 500 Internal Server Error with status of 403

2018-09-14 15:40:20 -04:00

migration

REFACTOR: use tables instead of custom fields for polls (#6359)

2018-11-19 14:50:00 +01:00

onebox/engine

SECURITY: correct local onebox category checks

2018-02-14 10:40:46 +11:00

plugin

DEV: Enable Style/SingleLineMethods and Style/Semicolon in Rubocop (#6717)

2018-12-04 11:48:13 +08:00

rate_limiter

Add specs for RateLimiter::LimitExceeded#description.

2018-06-19 07:48:03 +08:00

scheduler

dev, give spec a bit more time waiting on timeout

2018-11-19 16:21:39 +11:00

sidekiq

FIX: queue heartbeats in readonly modes

2018-08-29 12:36:59 +10:00

site_settings

DEV: Stablize the multisite tests.

2019-01-16 10:29:36 +08:00

stylesheet

FIX: Fix broken theme field URLs. (#6622)

2018-11-23 16:11:05 +01:00

svg_sprite

FIX: Refactor commit a8c3ca, add test

2018-11-29 19:12:00 -05:00

theme_store

Suppress tar(1)'s output (#6694)

2018-11-28 17:32:19 +01:00

validators

FIX: use ordered_posts for last post check, not the posts relation

2019-01-18 13:18:40 +11:00

wizard

FIX: Use CDN for logos and icons. (#6698)

2018-12-19 10:20:48 +01:00

admin_confirmation_spec.rb

Add rubocop to our build. (#5004)

2017-07-28 10:20:09 +09:00

admin_user_index_query_spec.rb

Improve specs to assert for the right record instead of just a count.

2018-05-17 08:47:24 +08:00

archetype_spec.rb

Add rubocop to our build. (#5004)

2017-07-28 10:20:09 +09:00

avatar_lookup_spec.rb

UX: show full name on /latest page

2018-08-23 14:41:06 +05:30

cache_spec.rb

dashboard next: caching, mobile support and new charts

2018-05-03 15:41:41 +02:00

category_badge_spec.rb

SECURITY: category badges should HTML escape names

2018-06-28 18:15:07 +10:00

composer_messages_finder_spec.rb

Remove unused variable.

2018-10-04 13:21:37 +08:00

content_buffer_spec.rb

Add rubocop to our build. (#5004)

2017-07-28 10:20:09 +09:00

cooked_post_processor_spec.rb

FEATURE: Remove full quotes only from new posts. (#6862)

2019-01-17 13:24:32 +11:00

crawler_detection_spec.rb

FIX: cubot android devices were detected as crawlers

2018-06-21 10:56:46 +10:00

current_user_spec.rb

FEATURE: per client user tokens

2017-02-07 09:22:16 -05:00

directory_helper_spec.rb

Prepare for separation of RSpec helper files

2015-12-01 20:39:42 +00:00

discourse_diff_spec.rb

correct spec regression

2018-01-30 08:54:37 +11:00

discourse_event_spec.rb

Add rubocop to our build. (#5004)

2017-07-28 10:20:09 +09:00

discourse_hub_spec.rb

fix failing spec when HUB_BASE_URL is present

2018-10-15 15:06:02 -04:00

discourse_i18n_spec.rb

FIX: async reload of locales could result in missing translations

2018-10-01 17:14:36 +02:00

discourse_plugin_registry_spec.rb

REFACTOR: Serve auth provider information in the site serializer.

2018-08-06 09:25:48 +01:00

discourse_plugin_spec.rb

More randomly failing specs fixes.

2016-09-05 19:33:03 +08:00

discourse_redis_spec.rb

FIX: Make test less fragile.

2019-01-02 16:33:50 +08:00

discourse_spec.rb

FIX: Enabling readonly mode should clear anon cache as well.

2018-12-18 11:56:25 +08:00

discourse_tagging_spec.rb

FIX: Can't clean a tag if the given string is frozen.

2018-10-15 14:48:45 +08:00

discourse_updates_spec.rb

REFACTOR: Avoid duplicated logic on server and client.

2017-11-21 17:10:04 +08:00

distributed_memoizer_spec.rb

Prepare for separation of RSpec helper files

2015-12-01 20:39:42 +00:00

distributed_mutex_spec.rb

FIX: in redis readonly raise an exception from DistributedMutex

2018-09-19 15:50:58 +10:00

email_cook_spec.rb

FEATURE: convert plain text emails to markdown

2017-12-06 01:47:51 +01:00

email_updater_spec.rb

FEATURE: the hide_email_address_taken setting works with the change email address form in user preferences

2017-10-04 11:41:25 -04:00

enum_spec.rb

Add rubocop to our build. (#5004)

2017-07-28 10:20:09 +09:00

excerpt_parser_spec.rb

FIX: Calculation of text length for <details> in excerpt was wrong

2018-03-12 16:55:23 +01:00

fallback_locale_list_spec.rb

FEATURE: Allow plugins to register a new locale

2018-01-25 14:57:41 +01:00

feed_element_installer_spec.rb

FEATURE: Replace SimpleRSS with Ruby RSS module (#5311)

2017-12-06 10:45:09 +11:00

feed_item_accessor_spec.rb

FEATURE: Replace SimpleRSS with Ruby RSS module (#5311)

2017-12-06 10:45:09 +11:00

file_helper_spec.rb

Include response body when raising an error in FileHelper#download.

2018-09-13 15:43:58 +08:00

filter_best_posts_spec.rb

Add rubocop to our build. (#5004)

2017-07-28 10:20:09 +09:00

final_destination_spec.rb

FIX: preserve github fragment URL

2018-12-19 12:34:47 +05:30

flag_query_spec.rb

Adjusts the minimum_flag_threshold for TL3/TL4 actions

2019-01-04 13:16:44 -05:00

flag_settings_spec.rb

Refactor flag types for more customization

2017-10-19 13:55:23 -04:00

gaps_spec.rb

Add rubocop to our build. (#5004)

2017-07-28 10:20:09 +09:00

global_path_spec.rb

Revert "Revert "FIX: GlobalPath#upload_cdn_path when S3 bucket has a folder (#6523)""

2018-10-24 15:14:01 +11:00

guardian_spec.rb

SECURITY: Require groups to be given when inviting to a restricted category. (#6715)

2018-12-05 16:43:07 +01:00

has_errors_spec.rb

FIX: show proper error message when no user selected for private message

2016-05-05 18:47:08 +05:30

hijack_spec.rb

Add Cache-Control header to CORS (#6490)

2018-10-16 10:46:55 +11:00

html_prettify_spec.rb

FEATURE: stop escaping special chars in title prettify

2017-03-13 10:02:20 -04:00

html_to_markdown_spec.rb

FIX: Font tag resulted in wrong email trimming

2018-12-18 11:40:54 +01:00

image_sizer_spec.rb

FIX: raise exception when getting dimensions of missing image

2018-12-03 10:19:49 -05:00

inline_oneboxer_spec.rb

remove unnecessary expectation lines

2018-11-13 16:52:08 +05:30

js_locale_helper_spec.rb

Update Rubocop to 0.60

2018-12-04 10:48:16 +01:00

json_error_spec.rb

Add rubocop to our build. (#5004)

2017-07-28 10:20:09 +09:00

letter_avatar_spec.rb

Prepare for separation of RSpec helper files

2015-12-01 20:39:42 +00:00

method_profiler_spec.rb

FIX: stop double counting net calls in logs

2018-02-28 10:45:11 +11:00

new_post_manager_spec.rb

FIX: Don't enqueue topics if the user can't create them

2018-11-09 18:24:28 +01:00

new_post_result_spec.rb

Prepare for separation of RSpec helper files

2015-12-01 20:39:42 +00:00

oneboxer_spec.rb

FIX: Generate Onebox for posts of type moderator_action. (#6466)

2018-10-10 18:39:03 +08:00

onpdiff_spec.rb

Add rubocop to our build. (#5004)

2017-07-28 10:20:09 +09:00

pbkdf2_spec.rb

Add rubocop to our build. (#5004)

2017-07-28 10:20:09 +09:00

pinned_check_spec.rb

Add rubocop to our build. (#5004)

2017-07-28 10:20:09 +09:00

plain_text_to_markdown_spec.rb

FEATURE: convert plain text emails to markdown

2017-12-06 01:47:51 +01:00

post_action_creator_spec.rb

Add rubocop to our build. (#5004)

2017-07-28 10:20:09 +09:00

post_creator_spec.rb

FIX: Set unique post key for a user outside of transaction.

2019-01-08 15:22:22 +08:00

post_destroyer_spec.rb

FIX: defer flags (only) when handling a flag and deleting replies (#6702)

2018-11-29 22:44:18 +05:30

post_enqueuer_spec.rb

Prepare for separation of RSpec helper files

2015-12-01 20:39:42 +00:00

post_locker_spec.rb

FEATURE: Staff members can lock posts

2018-01-26 14:01:30 -05:00

post_merger_spec.rb

Improve MessageBus.track_publish to allow filter by channel.

2017-10-02 11:34:57 +08:00

post_revisor_spec.rb

FIX: make staff_edit_locks_post work with download_remote_images_to_local

2018-12-03 14:14:59 +11:00

pretty_text_spec.rb

FEATURE: allow for custom excerpt BBCODE

2018-12-25 17:02:28 +02:00

promotion_spec.rb

FIX: do not send tl1 welcome message when a user has the basic user badge

2018-09-19 12:53:36 -07:00

quote_comparer_spec.rb

FEATURE: Add quote-modified class if a quote has been modified

2018-03-13 13:41:06 -04:00

rate_limiter_spec.rb

Add guard for nil in our RateLimiter.

2018-03-01 13:20:42 +08:00

redis_store_spec.rb

Prepare for separation of RSpec helper files

2015-12-01 20:39:42 +00:00

retrieve_title_spec.rb

PERF: ability to crawl for titles without extra HEAD req

2018-01-29 15:40:12 +11:00

rtl_spec.rb

Nuke all SiteSetting.stubs from our codebase.

2017-07-07 15:09:14 +09:00

s3_helper_spec.rb

FEATURE: Add SiteSetting for s3_configure_tombstone_policy

2018-09-17 10:57:50 +10:00

score_calculator_spec.rb

remove uneeded specs

2018-07-05 15:34:58 +10:00

search_spec.rb

FIX: do not show PM topics when moving posts to an existing public topic (#6876)

2019-01-14 15:00:45 +05:30

secure_session_spec.rb

SECURITY: prevent reuse of password reset

2016-12-19 18:00:22 +11:00

site_setting_extension_spec.rb

DEV: Stablize the multisite tests.

2019-01-16 10:29:36 +08:00

slug_spec.rb

FIX: strip emoji string from slug

2018-04-18 11:32:32 +05:30

spam_handler_spec.rb

Nuke all SiteSetting.stubs from our codebase.

2017-07-07 15:09:14 +09:00

stats_socket_spec.rb

Add rubocop to our build. (#5004)

2017-07-28 10:20:09 +09:00

suggested_topics_builder_spec.rb

Add rubocop to our build. (#5004)

2017-07-28 10:20:09 +09:00

system_message_spec.rb

Add rubocop to our build. (#5004)

2017-07-28 10:20:09 +09:00

text_cleaner_spec.rb

FIX: Skip gsub for normalizing whitespaces when text is nil (#6631)

2018-11-20 09:12:32 +01:00

text_sentinel_spec.rb

rename 'min_private_message_{post/title}_length' to 'min_personal_message_{post/title}_length'

2018-02-01 13:25:29 +05:30

theme_settings_manager_spec.rb

PERF: Eradicate N+1 queries from the theme admin page

2018-12-21 11:03:58 +02:00

theme_settings_parser_spec.rb

FEATURE: introduces list/compact_list components

2018-08-03 16:41:37 -04:00

timeline_lookup_spec.rb

PERF: Don't pluck all the columns just to retrieve a single value.

2018-06-27 11:41:35 +08:00

topic_creator_spec.rb

correct specs

2018-08-27 14:50:56 +10:00

topic_publisher_spec.rb

FIX: Update last_version_at when publishing

2018-03-26 16:06:20 -04:00

topic_query_spec.rb

FIX: Only hide shared draft topics from latest (#6737)

2018-12-07 12:44:23 +00:00

topic_retriever_spec.rb

Add rubocop to our build. (#5004)

2017-07-28 10:20:09 +09:00

topic_view_spec.rb

FIX: remove slow platform detection from server side

2018-12-13 13:57:05 +11:00

topics_bulk_action_spec.rb

Use PostDestroyer to delete topics when performing bulk operation (#5202)

2017-09-28 14:22:49 +02:00

trashable_spec.rb

Add rubocop to our build. (#5004)

2017-07-28 10:20:09 +09:00

trust_level_spec.rb

Enums that are used in tables need to be stable

2016-01-08 20:43:11 +05:30

unread_spec.rb

Add rubocop to our build. (#5004)

2017-07-28 10:20:09 +09:00

url_helper_spec.rb

FIX: URLs containing two # would fail to work

2018-12-11 18:03:13 +11:00

user_name_suggester_spec.rb

FIX: don't raise an error on integer usernames

2018-09-10 22:17:56 +05:30

version_spec.rb

Add rubocop to our build. (#5004)

2017-07-28 10:20:09 +09:00