Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
discourse/spec/serializers
History
Sam Saffron 2987901043
FIX: skip category notification_level unless scoped 
#b19dcac2 improved the serializer so it sends default notification
levels to users to work around cases where a category edit would
would result in clients being left with invalid notification state

Unfortunately this did not address the root issue.

When we edit categories we publish state to multiple users this
means that the serializer is executed unscoped with no user.

The client already handles this case per:

dcad720a4c/app/assets/javascripts/discourse/app/models/site.js (L119-L119)

If a property is not shipped to it, it will leave it alone on the
existing category.


This fix ensures that these wide category info updates do not
include notification state to avoid corruption of local state.
 		2020-06-24 17:08:12 +10:00
..
admin_plugin_serializer_spec.rb DEV: use #frozen_string_literal: true on all spec 2019-04-30 10:27:42 +10:00
admin_user_list_serializer_spec.rb FIX: Admin user list not showing 2FA icon for only security keys enabled (#8839) 2020-02-03 14:37:46 +10:00
basic_group_serializer_spec.rb UX: drop the `automatic_membership_retroactive` column from groups model. (#9430) 2020-04-22 22:07:39 +05:30
basic_group_user_serializer_spec.rb DEV: Prefabrication (test optimization) (#7414) 2019-05-07 13:12:20 +10:00
basic_post_serializer_spec.rb DEV: Move requested_group_id custom field from post to topic (#9127) 2020-03-24 11:12:52 +02:00
basic_user_serializer_spec.rb FIX: correct user serializer user method for extended serializer (#8590) 2019-12-19 09:48:01 -08:00
category_detailed_serializer_spec.rb DEV: Upgrading Discourse to Zeitwerk (#8098) 2019-10-02 14:01:53 +10:00
category_serializer_spec.rb FIX: skip category notification_level unless scoped 2020-06-24 17:08:12 +10:00
category_upload_serializer_spec.rb DEV: Prefabrication (test optimization) (#7414) 2019-05-07 13:12:20 +10:00
current_user_serializer_spec.rb FIX: Muted tags are respected by TopicTrackingState (#8467) 2019-12-10 09:50:05 +11:00
group_show_serializer_spec.rb DEV: Prefabrication (test optimization) (#7414) 2019-05-07 13:12:20 +10:00
new_post_result_serializer_spec.rb Support for custom messages and redirects when creating posts (#8434) 2019-11-29 09:30:54 -05:00
notification_serializer_spec.rb FIX: Include user id in notification webhook (#8195) 2019-10-21 16:24:41 -06:00
post_revision_serializer_spec.rb DEV: Prefabrication (test optimization) (#7414) 2019-05-07 13:12:20 +10:00
post_serializer_spec.rb DEV: correct flaky test relying on possibly valid user id 2020-06-09 17:40:41 +10:00
reviewable_flagged_post_serializer_spec.rb Fix the actual failing test 2019-11-14 16:20:45 -08:00
reviewable_queued_post_serializer_spec.rb FEATURE: Allow viewing of raw emails for reviewable queued posts (#7910) 2019-07-19 11:56:14 -04:00
reviewable_serializer_spec.rb Fix the actual failing test 2019-11-14 16:20:45 -08:00
reviewable_user_serializer_spec.rb DEV: use #frozen_string_literal: true on all spec 2019-04-30 10:27:42 +10:00
single_sign_on_record_serializer_spec.rb DEV: Prefabrication (test optimization) (#7414) 2019-05-07 13:12:20 +10:00
site_serializer_spec.rb DEV: Upgrading Discourse to Zeitwerk (#8098) 2019-10-02 14:01:53 +10:00
suggested_topic_serializer_spec.rb DEV: use #frozen_string_literal: true on all spec 2019-04-30 10:27:42 +10:00
tag_group_serializer_spec.rb FEATURE: Tag synonyms 2019-12-04 13:33:51 -05:00
theme_serializer_spec.rb DEV: use #frozen_string_literal: true on all spec 2019-04-30 10:27:42 +10:00
topic_link_serializer_spec.rb DEV: use #frozen_string_literal: true on all spec 2019-04-30 10:27:42 +10:00
topic_list_item_serializer_spec.rb FIX: composer problem on the categories page (#9508) 2020-04-22 09:24:54 -07:00
topic_list_serializer_spec.rb DEV: Prefabrication (test optimization) (#7414) 2019-05-07 13:12:20 +10:00
topic_view_posts_serializer_spec.rb PERF: optimize lookup of reviewable info in post stream 2019-06-07 18:12:30 +10:00
topic_view_serializer_spec.rb fix spec (#10061) 2020-06-17 15:10:07 +02:00
upload_serializer_spec.rb FIX: add short_path to upload_serializer (#9417) 2020-04-15 09:19:59 +10:00
user_auth_token_serializer_spec.rb DEV: Prefabrication (test optimization) (#7414) 2019-05-07 13:12:20 +10:00
user_bookmark_serializer_spec.rb FIX: Change /bookmarks URL back to topic list and add bookmark poster avatars (#9759) 2020-05-13 14:03:24 +10:00
user_card_serializer_spec.rb FIX: secondary_emails, unconfirmed_emails, group_users are private fields 2020-06-16 12:46:27 +03:00
user_serializer_spec.rb FIX: secondary_emails, unconfirmed_emails, group_users are private fields 2020-06-16 12:46:27 +03:00
user_summary_serializer_spec.rb DEV: use #frozen_string_literal: true on all spec 2019-04-30 10:27:42 +10:00
web_hook_post_serializer_spec.rb DEV: Include raw in post webhook serializer 2020-06-10 11:56:39 -06:00
web_hook_topic_view_serializer_spec.rb FEATURE: Include optimized thumbnails for topics (#9215) 2020-05-05 09:07:50 +01:00
web_hook_user_serializer_spec.rb FEATURE: Improve UX support for multiple email addresses (#9691) 2020-06-10 19:11:49 +03:00