mirror of
https://github.com/discourse/discourse.git
synced 2025-02-19 01:46:01 +00:00
4ea21fa2d0
This change both speeds up specs (less strings to allocate) and helps catch cases where methods in Discourse are mutating inputs. Overall we will be migrating everything to use #frozen_string_literal: true it will take a while, but this is the first and safest move in this direction
86 lines
3.0 KiB
Ruby
86 lines
3.0 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'rails_helper'
|
|
require_dependency 'user'
|
|
|
|
describe AdminUserListSerializer do
|
|
let(:user) { Fabricate(:user_second_factor_totp).user }
|
|
let(:admin) { Fabricate(:admin) }
|
|
let(:guardian) { Guardian.new(admin) }
|
|
|
|
let(:serializer) do
|
|
AdminUserListSerializer.new(user, scope: guardian, root: false)
|
|
end
|
|
|
|
it "returns the right values when user has second factor totp enabled" do
|
|
json = serializer.as_json
|
|
|
|
expect(json[:second_factor_enabled]).to eq(true)
|
|
end
|
|
|
|
context "emails" do
|
|
let(:admin) { Fabricate(:user, admin: true, email: "admin@email.com") }
|
|
let(:moderator) { Fabricate(:user, moderator: true, email: "moderator@email.com") }
|
|
let(:user) { Fabricate(:user, email: "user@email.com") }
|
|
|
|
def serialize(user, viewed_by, opts = nil)
|
|
AdminUserListSerializer.new(
|
|
user,
|
|
scope: Guardian.new(viewed_by),
|
|
root: false,
|
|
emails_desired: opts && opts[:emails_desired]
|
|
).as_json
|
|
end
|
|
|
|
def fabricate_secondary_emails_for(u)
|
|
Fabricate(:secondary_email, user: u, email: "first@email.com")
|
|
Fabricate(:secondary_email, user: u, email: "second@email.com")
|
|
end
|
|
|
|
it "contains an admin's own emails" do
|
|
fabricate_secondary_emails_for(admin)
|
|
json = serialize(admin, admin)
|
|
expect(json[:email]).to eq("admin@email.com")
|
|
expect(json[:secondary_emails]).to contain_exactly("first@email.com", "second@email.com")
|
|
end
|
|
|
|
it "doesn't include a regular user's emails" do
|
|
fabricate_secondary_emails_for(user)
|
|
json = serialize(user, user)
|
|
expect(json[:email]).to eq(nil)
|
|
expect(json[:secondary_emails]).to eq(nil)
|
|
end
|
|
|
|
it "doesn't return emails for a moderator request when moderators_view_emails is disabled" do
|
|
SiteSetting.moderators_view_emails = false
|
|
fabricate_secondary_emails_for(user)
|
|
json = serialize(user, moderator, emails_desired: true)
|
|
expect(json[:email]).to eq(nil)
|
|
expect(json[:secondary_emails]).to eq(nil)
|
|
end
|
|
|
|
it "returns emails for a moderator request when moderators_view_emails is enabled" do
|
|
SiteSetting.moderators_view_emails = true
|
|
fabricate_secondary_emails_for(user)
|
|
json = serialize(user, moderator, emails_desired: true)
|
|
expect(json[:email]).to eq("user@email.com")
|
|
expect(json[:secondary_emails]).to contain_exactly("first@email.com", "second@email.com")
|
|
end
|
|
|
|
it "returns emails for admins when emails_desired is true" do
|
|
fabricate_secondary_emails_for(user)
|
|
json = serialize(user, admin, emails_desired: true)
|
|
expect(json[:email]).to eq("user@email.com")
|
|
expect(json[:secondary_emails]).to contain_exactly("first@email.com", "second@email.com")
|
|
end
|
|
|
|
it "returns a staged user's emails" do
|
|
user.staged = true
|
|
fabricate_secondary_emails_for(user)
|
|
json = serialize(user, admin)
|
|
expect(json[:email]).to eq("user@email.com")
|
|
expect(json[:secondary_emails]).to contain_exactly("first@email.com", "second@email.com")
|
|
end
|
|
end
|
|
end
|