15723 Commits

Author SHA1 Message Date
Jan Bartel
0f23af315c Issue #2599 Fix AsyncServletIOTest
Signed-off-by: Jan Bartel <janb@webtide.com>
2018-05-30 18:15:04 +02:00
Jan Bartel
1509d1c9aa
Issue #2586 update to asm6.2 (#2588)
Issue #2586 update to asm6.2
2018-05-30 11:29:18 +02:00
Greg Wilkins
eb3461fd84
Merge pull request #2582 from LukeButtersFunnelback/jetty-9.4.x
Stop creating unnecessary exceptions with MultiException #2580
2018-05-30 11:18:08 +02:00
Greg Wilkins
4d09806d4e
Issue #2571 HPACK table overflow (#2589)
When an entry that is too large for the dynamic table is added, the entire table should be evicted as per the RFC.  Previously we were throwing a 431 Bad Message.   This will require that the OP should retest #1134.

Signed-off-by: Greg Wilkins <gregw@webtide.com>
2018-05-30 09:22:00 +02:00
Luke Butters
e7b3f6319e Remove the virtual method called from constructor & simulate a builder.
1. The virtual method to stop fillInStackTrace() from being called by the
constructor has been removed.
2. The public no argument constructor for MultiException puts the class
into a builder mode where it just lets you add exceptions.
MultiException created from the constructor should not be thrown because
fillInStackTrace() is not called.
3. In the `ifExceptionThrow*()` methods a new `MultiException` is
created, with the stack trace filled, before it is thrown.

Signed-off-by: Luke Butters <lbutters@funnelback.com>
2018-05-30 17:04:24 +10:00
Olivier Lamy
154298af64
run maven it tests as default #2576
* run maven its test per default #2576

Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
2018-05-30 08:33:25 +10:00
WalkerWatch
65070e6b2a Documentation for GlobalWebAppConfigBinding. Resolves #2207 2018-05-29 13:49:24 -04:00
Greg Wilkins
953611fb72 reverted inadvertant commit with #2585
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2018-05-29 17:31:56 +02:00
Greg Wilkins
436c00b0af Fixed #2585
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2018-05-29 15:48:53 +02:00
Greg Wilkins
4f20447a5a Fixed #2585
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2018-05-29 14:58:05 +02:00
Greg Wilkins
d3b81e5372 Fix for #2583
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2018-05-29 12:41:19 +02:00
Greg Wilkins
2bcc528920 expand spruious tabs in java sources
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2018-05-29 10:40:09 +02:00
Luke Butters
7e3242b5cc Stop creating unnecessary exceptions with MultiException #2580
This doesn't actually stop creating the unnecessary exception instead it
stop running the expensive `fillInStackTrace()` unless we actually need
it.

This does result in the stack trace being set to where we throw the
exception rather than when we create it.

Signed-off-by: Luke Butters <lbutters@funnelback.com>
2018-05-29 13:43:17 +10:00
Olivier Lamy
10070b9af6
Merge pull request #2581 from olamy/upgrade_maven_plugins
[WIP] upgrade javadoc and plugin tools maven plugins
2018-05-29 09:33:58 +10:00
olivier lamy
72ed06a630 upgrade javadoc and plugin tools maven plugins
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
2018-05-29 08:08:37 +10:00
Simone Bordet
216c3b0417
Merge pull request #2558 from lachlan-roberts/jetty-9.4.x-server-stackTraceRemoval
jetty-server exception stack traces
2018-05-28 15:27:53 +02:00
Lachlan Roberts
d13e79a284 Merge remote-tracking branch 'eclipse/jetty-9.4.x' into jetty-9.4.x-server-stackTraceRemoval 2018-05-26 00:35:02 +10:00
Joakim Erdfelt
a6547eaf83 Issue #2559 - Use Configurator declared in ServerEndpointConfig over @ServerEndpoint annotation
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2018-05-25 06:29:33 -05:00
Greg Wilkins
e6e49bdc85 Updated javadoc for callbacks
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2018-05-25 08:01:31 +02:00
Lachlan Roberts
c829ee3210 Issue #2424 - ReadPendingException in testHttpWriteIdleTimeout()
Replacing setBlockingTimeout with setIdleTimeout to fix the ReadPendingException on ServerConnectorTimeoutTest.testHttpWriteIdleTimeout().

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2018-05-23 07:41:20 +10:00
Lachlan Roberts
0664893022 Issue #2542 - Log exception stackTraces instead of printing
replaces some usages of printStackTrace with logging in ConnectorTimeoutTest to avoid printing out the stack trace on passing tests

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2018-05-23 07:39:23 +10:00
Jesse McConnell
09d40dc665
Update docbook.xsl
remove documentation page tracker
2018-05-22 15:21:27 -05:00
Jesse McConnell
718a855911
Update pom.xml
remove the javadoc page tracker
2018-05-22 15:20:17 -05:00
Joakim Erdfelt
bc16b6efae Issue #2559 - Use Configurator declared in ServerEndpointConfig over @ServerEndpoint annotation
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2018-05-22 09:44:20 -05:00
Simone Bordet
462679910f Fixes #2544 - Test Failure: LowResourcesMonitorTest.testMaxLowResourceTime().
Rewrote the test to not write to the server,
thus avoiding connection resets.

The rewrite also clarified what the test was testing.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2018-05-22 12:55:03 +02:00
Joakim Erdfelt
04c1447f88 Merge branch 'jetty-9.4.x' of github.com:eclipse/jetty.project into jetty-9.4.x 2018-05-21 16:34:06 -05:00
Joakim Erdfelt
4f947c7ee5 Issue #2556 - Adding Testcase to verify report
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2018-05-21 16:32:56 -05:00
Simone Bordet
6b7f4c91db
Merge pull request #2552 from eclipse/jetty-9.4.x-2549-ConsumeAll
Issue #2549 ConsumeAll forced EOF or EarlyEOF
2018-05-18 09:18:57 +02:00
Simone Bordet
1fc1ac89e2 Fixes #2545 - Slow HTTP2 per-stream download performance.
Moved the initialization of the SETTINGS frame to a common place
shared by both the low-level HTTP2Client and the higher level
HttpClientTransportOverHTTP2.

Did the same with HTTP2 server ConnectionFactories.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2018-05-18 09:06:49 +02:00
Greg Wilkins
c69ab6bd56 Issue #2549 ConsumeAll forced EOF or EarlyEOF
Cleanup after review

Signed-off-by: Greg Wilkins <gregw@webtide.com>
2018-05-18 16:39:44 +10:00
Greg Wilkins
bf8dd121b0 reduced test race
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2018-05-18 10:20:47 +10:00
Greg Wilkins
252ab9facf
Jetty 9.4.x 2550 coalesce ranges (#2551)
Issue #2550 coalesce ranges

Author: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
Signed-off-by: Greg Wilkins <gregw@webtide.com>
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2018-05-18 08:45:54 +10:00
Olivier Lamy
07b3367519 #2472 it looks https://central.maven.org/maven2 does not work anymore (#2538)
* #2472 it looks https://central.maven.org/maven2 does not work anymore

Signed-off-by: olivier lamy <oliver.lamy@gmail.com>

* #2472 add unit test we correctly download files from default repo

Signed-off-by: olivier lamy <oliver.lamy@gmail.com>

* use maven format to download alpn boot jar modules

Signed-off-by: olivier lamy <oliver.lamy@gmail.com>

* change default to https://repo1.maven.org/maven2 #2472

Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
2018-05-18 08:21:29 +10:00
Greg Wilkins
b93cc5abb6 Issue #2549 ConsumeAll forced EOF or EarlyEOF
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2018-05-17 13:05:13 +10:00
Greg Wilkins
715a637c2b
Issue #2532 Better handling of tokens in parser (#2533)
Issue #2532 Better handling of tokens in parser

Handle TCHAR and VCHAR from abnf separately

Signed-off-by: Greg Wilkins <gregw@webtide.com>
2018-05-17 09:50:49 +10:00
Greg Wilkins
aa97518d0b Merge remote-tracking branch 'origin/jetty-9.3.x' into jetty-9.4.x 2018-05-17 08:27:45 +10:00
Greg Wilkins
be8ff431a4 Merge remote-tracking branch 'origin/jetty-9.2.x' into jetty-9.3.x
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2018-05-17 08:16:39 +10:00
Greg Wilkins
a285deea42 Issue #2529 RFC2616 vs RFC7230 cleanup
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2018-05-17 08:00:53 +10:00
Simone Bordet
16b7359ae5 Fixes #2548 - Possible deadlock failing HTTP/2 stream creation.
Now failing the callback outside of the synchronized block.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2018-05-16 22:18:47 +02:00
Simone Bordet
01f7aecc4e Fixes #2546 - Incorrect parsing of PROXY protocol v2.
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2018-05-16 21:33:22 +02:00
Simone Bordet
744f9054b3 Fixes #2547 - Review usages of ServerSocket[Channel].accept().
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2018-05-16 18:40:10 +02:00
Simone Bordet
7a7aa0f1b1 Fixes #2536 - Broken ClientConnectTest.testConnectionTimeout_Concurrent.
Using try-with-resources to keep the Socket instance
from being GCd before the test finishes.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2018-05-16 14:48:05 +02:00
Simone Bordet
804b770581 Issue #2536 - Broken ClientConnectTest.testConnectionTimeout_Concurrent.
Updated the code to show more information when it fails.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2018-05-16 14:25:14 +02:00
Greg Wilkins
4cc8f4dcf6 Issue #2346 Revert stack logging
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2018-05-16 17:21:06 +10:00
Greg Wilkins
820b5752d7 Issue #2525 fixed jetty.xml
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2018-05-16 14:32:41 +10:00
Greg Wilkins
621b946b10 Issue #2540 ignore flaky test
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2018-05-16 14:09:22 +10:00
Simone Bordet
d8795350a4 Issue #2525 - Clean up SharedBlockingCallback.
Cosmetics.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2018-05-15 17:05:24 +02:00
Simone Bordet
faaa64c5b4
Merge pull request #2528 from eclipse/jetty-9.4.x-2525-SharedBlockingCallback
Issue #2525 Clean up SharedBlockingCallback
2018-05-15 11:00:28 +02:00
Greg Wilkins
88f8bcf4a5 Merge branch 'jetty-9.4.x' into jetty-9.4.x-2525-SharedBlockingCallback 2018-05-15 11:46:31 +10:00
Olivier Lamy
27de5e4753
Merge pull request #2534 from olamy/bugfix/fix_javadoc_call
remove link to self javadoc which cause failure
2018-05-15 11:04:59 +10:00