Commit Graph

18910 Commits

Author SHA1 Message Date
Lachlan Roberts 25dafa6d7a Update VERSION.txt with CVE-2021-34429.
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2021-07-29 15:04:20 +10:00
Greg Wilkins 735e97d5c7
Non blocking ReservedThreadExecutor (#6535)
A call to offer must never block, nor even yield, since to do so give an opportunity for the allocated CPU core to change, defeating the whole purpose of the class.
There is also some reasonable level of diagnostic warnings if a reserved thread misses too many offers consecutively, based on tracking the state of the reserved thread.

Remove the stack data structure entirely.  ReservedThreads all poll the same SynchronousQueue and tryExecute does a non blocking offer.

Added test for busy shrinking

Remember last time we hit zero reserved threads

Co-authored-by: Simone Bordet <simone.bordet@gmail.com>
2021-07-29 09:46:48 +10:00
Ludovic Orban ea5c8ed994 #6491 do not depend on awaitility
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
2021-07-28 09:24:47 +02:00
Ludovic Orban 020770f82d #6541 improve testConcurrentAccess perf
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
2021-07-28 09:24:47 +02:00
Ludovic Orban 9726a0987f #6541 improve testTake perf
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
2021-07-28 09:24:47 +02:00
Joakim Erdfelt cbb3a550cc
Merge pull request #6549 from eclipse/jetty-9.4.x-remove-dead-useragents-file
Remove unused (and currently empty) useragents file
2021-07-27 12:53:23 -05:00
Joakim Erdfelt 90e8b2a358
Merge pull request #6548 from eclipse/jetty-9.4.x-6545-refresh-mimetypes
Issue #6545 - Add more mime-types
2021-07-27 11:47:55 -05:00
Joakim Erdfelt 9626dbab35
Remove unused (and currently empty) useragents file
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2021-07-27 10:33:54 -05:00
Joakim Erdfelt dae361ff26
Issue #6545 - Add more mime-types
+ Adding webp + avif + apng based on current
  `Accept` header offerings from current browsers.

Firefox 90.0
`Accept: text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,*/*;q=0.8`

Chrome 92.0.4515.107
`Accept: text/html,application/xhtml+xml,application/xml;q=0.9,image/avif,image/webp,image/apng,*/*;q=0.8,application/signed-exchange;v=b3;q=0.9`

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2021-07-27 10:31:44 -05:00
Ludovic Orban 88c383e54b #6491 add test
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
2021-07-27 11:51:08 +02:00
Ludovic Orban 64a7dda668 #6491 introduce HttpParser.isTerminated()
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
2021-07-27 11:51:08 +02:00
Ludovic Orban 54763edf33 #6491 add defensive check
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
2021-07-27 11:51:08 +02:00
Joakim Erdfelt cd20770548
Merge pull request #6419 from eclipse/jetty-9.4.x-remove-disabled-tls-tests
Issue #5684 - Client and HttpServerTestBase disabled test cleanup
2021-07-23 13:01:19 -05:00
Joakim Erdfelt 6782b24d29
Merge pull request #6525 from eclipse/jetty-9.4.x-6520-errorhandler-valid-xhtml-xml
Issue #6520 - Fixing ErrorHandler output of text/html
2021-07-16 20:14:37 -05:00
Joakim Erdfelt 22c4855aaa
Issue #6520 - Fixing ErrorHandler output of text/html
+ Updating tests to ensure that output is xml verified
+ Updating output to use `<hr>` element properly.

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2021-07-16 14:01:03 -05:00
Joakim Erdfelt c6d8bfc973
Merge pull request #6517 from eclipse/jetty-9.4.x-classpathpatterntest-prepend-not-needed
Issue #6515 - Adding Test to ensure that ClasspathPattern doesn't need prepend anymore
2021-07-16 13:35:34 -05:00
Joakim Erdfelt 56cd2800d6
Issue #6515 - Adding Test to ensure that ClasspathPattern doesn't need prepend anymore.
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2021-07-14 12:18:45 -05:00
Lachlan 9d6db9e098
Merge pull request #6416 from eclipse/jetty-9.4.x-6366-OpenID-IdentityService
Issue #6366 - document how set IdentityService for OpenID support
2021-07-14 16:12:58 +10:00
Olivier Lamy a448e46ad7
jetty 9.4.x hazelcast remote distribution test (#6068)
* Add distribution test using a remote hazelcast only client true and false, false is failing with CNFE

Signed-off-by: Olivier Lamy <oliver.lamy@gmail.com>
2021-07-13 21:03:54 +10:00
Jan Bartel bbdc459c59
Issue #6430 Upgrade to jasper 8.5.68 (#6435)
* Issue #6430 Upgrade to jasper 8.5.68

Signed-off-by: Jan Bartel <janb@webtide.com>
2021-07-12 11:20:08 +10:00
Lachlan 93d58a9bda
Merge pull request #6508 from eclipse/jetty-9.4.x-6277-updateVersionTxt
Issue #6277 - update VERSION.txt with SessionListener CVE number (9.4)
2021-07-09 15:17:25 +10:00
Joakim Erdfelt 2cf5428869
Merge pull request #6488 from eclipse/jetty-9.4.x-6487-expose-chainend-servletholder
Issue #6487 - expose ServletHolder in ChainEnd
2021-07-08 16:19:16 -05:00
Lachlan Roberts 1cde3d0fee Issue #6277 - update VERSION.txt with CVE number
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2021-07-08 17:19:36 +10:00
Ludovic Orban 8c2116c185 #6443 wait for handshake to be done before closing the socket
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
2021-07-07 17:14:23 +02:00
Joakim Erdfelt ac81aa3d00
Merge pull request #6502 from eclipse/release-9.4.43
Merge Release 9.4.43
2021-07-07 08:20:59 -05:00
Joakim Erdfelt 1dd66adf6f
Issue #6487 - expose ServletHolder in ChainEnd
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2021-06-30 12:25:35 -05:00
Joakim Erdfelt e37a708c40 Updating to version 9.4.44-SNAPSHOT 2021-06-30 06:30:31 -05:00
Joakim Erdfelt 526006ecfa Updating to version 9.4.43.v20210629 2021-06-30 05:57:49 -05:00
Lachlan 40535f1cd7
Merge pull request #6486 from eclipse/jetty-9.4.x-6470-MessageInputStreamEOF
Issue #6470 - prevent EOF being released back into pool in MessageInputStream
2021-06-30 19:24:44 +10:00
Lachlan Roberts 039a539aa0 Issue #6470 - prevent EOF being released back into pool
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2021-06-30 16:39:00 +10:00
Simone Bordet f045b5a3ba
Issue #6473 - Improve alias checking in PathResource. (#6477)
* Issue #6473 - Improve alias checking in PathResource.

* Reverted %-escape handling for URI query parts.
* Performing canonicalization in ServletContext.getResource(),
  and improving alias checking in ContextHandler.getResource().
* Performing canonicalization checks in Resource.addPath() to avoid
  navigation above of the root.
* Test added and fixed.
* Various cleanups.
* Improved javadoc and comments

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Co-authored-by: Greg Wilkins <gregw@webtide.com>
2021-06-29 15:40:45 +02:00
Ludovic Orban 16d8b239cf #6455 disable MaxDuration mechanism in testConnectionMaxUsage as it clashes with the test's assertions
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
2021-06-28 11:01:17 +02:00
Greg Wilkins 122a78aafc
Issue #6473 - canonicalPath refactor & fix alias check in PathResource (#6474)
Reduce multiple canonicalPath calls with single alias check in PathResource
Revert to decoding and the normalizing URLs so that subsequent canonicalPath calls are noops. 
Co-authored-by: Lachlan Roberts <lachlan@webtide.com>
2021-06-28 17:10:11 +10:00
Lachlan a02ade7709
Merge pull request #6456 from eclipse/jetty-9.4.x-6383-FileBufferedResponseHandler
Merge fix to BufferedResponseHandlerTest to 9.4.x
2021-06-28 10:52:46 +10:00
Lachlan a3effb19c4
Issue #6447 - Deprecate support for UTF16 encoding in URIs (#6467)
- Merge from PR #6457.
- Also brought some other ComplianceModes back to disable ambiguous empty segments, and ambiguous encodings.

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2021-06-24 17:16:56 +10:00
Lachlan 97b52e4e23
Merge pull request #6462 from eclipse/jetty-9.4.x-documentationFix
fix documentation format in community.adoc
2021-06-23 22:50:29 +10:00
Lachlan Roberts 4289716807 fix documentation format in community.adoc
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2021-06-23 15:02:25 +10:00
Lachlan 152217a939
Merge pull request #6459 from eclipse/jetty-9.4.x-remove-irc
Fix #6442 Remove IRC
2021-06-23 15:00:01 +10:00
Jan Bartel 7f0b69a9d5
Issue #6426 Upgrade to spifly 1.3.3 (#6449) (#6458)
Signed-off-by: Jan Bartel <janb@webtide.com>
2021-06-23 08:43:51 +10:00
Greg Wilkins 7fde68d1d1
Update community.adoc 2021-06-22 17:14:59 +10:00
Greg Wilkins 678af90623
Fix #6442 Remove IRC
Fix #6442 Remove IRC from contributing documentation
2021-06-22 16:45:43 +10:00
Lachlan Roberts e14047839d Issue #6383 - Make FileBufferedInterceptor package private
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2021-06-22 10:03:57 +10:00
Lachlan Roberts c490a10621 Issue #6383 - Fix flaky test FileBufferedResponseHandlerTest
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2021-06-22 10:03:08 +10:00
Jan Bartel 52a72eea85
Issue #6425 Upgrade to asm 9.1 (#6439) (#6448)
Signed-off-by: Jan Bartel <janb@webtide.com>
2021-06-22 09:46:29 +10:00
Simone Bordet 734d3b672c Fixes #6382 - HttpClient TimeoutException message reports transient values.
Now using consistently HttpConversation.getTimeout() to report the accurate value.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2021-06-21 17:10:47 +02:00
Joakim Erdfelt bb24f0ff5c
Issue #5684 - Improve warning about DNS Hijacking during testing.
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2021-06-18 16:26:47 -05:00
Joakim Erdfelt 704abc6271
Issue #5684 - more disabled test cleanup
+ Assumption based on existence of
  possible DNS Hijacking
+ Alternate logic for client side
  protocol and cipher suite mismatch
  behavior on server side based
  on client side protocol existence
  of TLSv1.3

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2021-06-18 16:23:03 -05:00
Joakim Erdfelt 738d3a9f80
Merge pull request #6420 from eclipse/jetty-9.4.x-minidev-version-bump
Bump (test scoped) net.minidev:json-smart version from 2.3 to 2.4.7
2021-06-17 07:44:45 -05:00
Greg Wilkins 265886543f
QueuedThreadPool always interrupts threads in doStop
Fix #6400 QueuedThreadPool always interrupts threads in stop
Even if there is no timeout, always interrupt pool threads to attempt to stop them.
 + Refactored exit condition for Runner main loop to make it clearer that it always checks running status
 + More comments to explain counts
 + Fixed inner loop of ReservedThread to ensure it always checks running status
 + Adjusted timing of the test to make it less flakey. Still a worry!
2021-06-17 07:54:21 +10:00
Joakim Erdfelt b30fee93d5
Bump (test scoped) net.minidev:json-smart version from 2.3 to 2.4.7 due to security alert.
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2021-06-16 16:23:14 -05:00