Commit Graph

17558 Commits

Author SHA1 Message Date
Joakim Erdfelt 363d5f2df3 Updating to version 9.4.24.v20191120 2019-11-20 15:25:01 -06:00
Joakim Erdfelt ba1fe2826d
Merge pull request #4335 from eclipse/jetty-9.4.x-improve-error-handler-output
Issue #4334 - Improve testing of ErrorHandler behavior
2019-11-20 15:21:07 -06:00
Joakim Erdfelt cf0df6e3ff
Issue #4334 - Improve testing of ErrorHandler behavior
+ Cleanup from PR review

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2019-11-20 13:17:17 -06:00
Joakim Erdfelt cba60d2e37
Fixing typo in stalebot message
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2019-11-20 09:58:44 -06:00
Joakim Erdfelt 87eefa344a
Fixes #3083 - Aligning default in ini to XML default
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2019-11-20 09:54:24 -06:00
Joakim Erdfelt 9e40fc9a6f
Issue #4334 - Improve testing of ErrorHandler behavior
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2019-11-20 09:47:33 -06:00
Joakim Erdfelt dc03431de2 Merge branch 'release-9.4.23' into jetty-9.4.x 2019-11-20 07:14:53 -06:00
Lachlan cff6bb444a
Issue #4128 - test the decoding of OpenId Credentials (#4166)
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2019-11-20 14:23:19 +11:00
Simone Bordet d44a6935ef Issue #4331 - Improve handling of HttpOutput.close() for pending writes.
Added test case that verifies the current behavior (abort the response
in case complete() is called with a pending write()).

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2019-11-19 17:09:04 +01:00
olivier lamy 9ab6a073fa we do not need those repositories now
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
2019-11-19 20:28:43 +10:00
Simone Bordet e89e8ae16e Improved toString() for ConnectionPool implementations.
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2019-11-19 10:43:09 +01:00
Lachlan Roberts cef80aca2e Revert "jetty-websocket-tests code cleanup"
This reverts commit 044a899a99.
2019-11-19 19:14:54 +11:00
olivier lamy 6db5f3be8d force clean
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
2019-11-19 18:13:18 +10:00
Lachlan Roberts 044a899a99 jetty-websocket-tests code cleanup
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2019-11-19 18:30:44 +11:00
Joakim Erdfelt 61cbb7529d
Removing duplicate log output
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2019-11-18 16:44:48 -06:00
Joakim Erdfelt 453d41940b Updating to version 9.4.24-SNAPSHOT 2019-11-18 13:52:51 -06:00
Joakim Erdfelt abbccc65d6 Updating to version 9.4.23.v20191118 2019-11-18 13:09:44 -06:00
Joakim Erdfelt 8a30543845
Merge pull request #4326 from eclipse/jetty-9.4.x-4325-deprecate-NoSsl-SniX509
Issue #4325 - X509ExtendedKeyManager exceptions on non-Server SSL
2019-11-18 12:55:24 -06:00
Joakim Erdfelt f4d387e0d6
Issue #4325 - X509ExtendedKeyManager exceptions on non-Server SSL
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2019-11-18 12:13:05 -06:00
Joakim Erdfelt 55ad1074bd
Issue #4325 - X509ExtendedKeyManager exceptions on non-Server SSL
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2019-11-18 10:58:12 -06:00
Simone Bordet bf2482a7ea Moved implementation from Adapter classes to default methods in
the interface to avoid binary compatibility problems in case the
interface is changed.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2019-11-18 10:29:55 +01:00
Simone Bordet 65063da638
Merge pull request #4322 from eclipse/jetty-9.4.x-3869-update-asm-7.2
Issue #3869 Update to asm 7.2
2019-11-18 11:39:17 +03:00
Jan Bartel ac63c121b6 Issue #3869 Update to asm 7.2
Signed-off-by: Jan Bartel <janb@webtide.com>
2019-11-18 16:49:15 +11:00
Jan Bartel 318246eb24
Issue #4156 Remove use of PlaceHolderSession for simultaneous session loading (#4304)
* Issue #4156 Remove use of PlaceHolderSession for simultaneous session loading.
2019-11-18 09:06:38 +11:00
olivier lamy e69eea86c8 make rerunFailingTestsCount a property so we can change it on cli if needed
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
2019-11-18 07:20:42 +10:00
Olivier Lamy 905deeb49a
Jetty 9.4.x rerun failing tests count set to 3 and upgrade surefire which supports it for junit5 (#4320)
* rerunFailingTestsCount and test surefire 3.0.0-M4 fixing it for junit5

Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
2019-11-18 07:10:44 +10:00
Joakim Erdfelt 46dbfda52e
Introducing stalebot.yml anew (again)
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2019-11-15 15:19:47 -06:00
Joakim Erdfelt 3c42bbedbc
Removing stalebot.yml temporarily
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2019-11-15 15:19:13 -06:00
Joakim Erdfelt b5a430fbf9
Dropping colons
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2019-11-14 11:42:19 -06:00
Joakim Erdfelt 2bc5cacd49
Updating template for os/type
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2019-11-14 11:42:19 -06:00
Joakim Erdfelt f89f81a363
Updating templates based on feedback
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2019-11-14 11:32:33 -06:00
Joakim Erdfelt 402f499f19
Adding TCK to skipped labels
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2019-11-14 11:17:08 -06:00
Joakim Erdfelt d66fe9ac0c
Adding ISSUE_TEMPLATE
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2019-11-14 11:17:08 -06:00
Joakim Erdfelt c44e7c5eb1
Merge pull request #4299 from eclipse/jetty-9.4.x-4248-websocketclient-success-flag
Fixes #4248 - WebSocketClient UpgradeResponse.isSuccess never set true
2019-11-14 09:42:45 -06:00
Simone Bordet 0d0b346140 Updated ALPN modules for Java >= 11 so that
they can be easily merged to Jetty 10.0.x.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2019-11-14 09:48:28 +01:00
Greg Wilkins 32931fac7b
Issue #4247 SameSite Session Cookie (#4271)
* Issue #4247 SameSite Session Cookie

Allows sameSite cookie settings to be configured in SessionCookieConfig comments

Signed-off-by: Greg Wilkins <gregw@webtide.com>

* Issue #4247 SameSite Session Cookies

Use non versioned cookie

Signed-off-by: Greg Wilkins <gregw@webtide.com>

* Issue #4247 SameSite Session Cookies

Added test and fixed getCommentWithAttributes

Signed-off-by: Greg Wilkins <gregw@webtide.com>

* Issue #4247 - Updating unit tests for HttpCookie

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

* Issue #4247 SameSite Session Cookie

While it may be best practise to always use Secure cookies when SameSite is None, there is nothing in the RFC that mandates it and thus I don't believe we should prevent such a configuration.  If browsers enforce this, then users will find out soon enough... and if browsers change, then we are not required to do a new release to match.

Signed-off-by: Greg Wilkins <gregw@webtide.com>

* Issue #4247 SameSite Session Cookie

For cookie comments with multiple SameSite attributes, the most strict
value is used. So `Strict` has precedence over `Lax` which has
precedence over `None`.

Signed-off-by: Greg Wilkins <gregw@webtide.com>
2019-11-14 11:56:40 +11:00
Greg Wilkins b24c6ce68d
Issue #2340 ServletContext cleanup (#4307)
* Issue #2340 ServletContext cleanup

A minor cleanup of the ServletContext implementation classes.

Signed-off-by: Greg Wilkins <gregw@webtide.com>

* Issue #2340 ServletContext cleanup

cleanup after review

Signed-off-by: Greg Wilkins <gregw@webtide.com>
2019-11-14 11:52:03 +11:00
Simone Bordet 89a4f92411
Merge pull request #4302 from eclipse/jetty-9.4.x-4301-demand_beforecontent_not_forwarded
Fixes #4301 - Demand beforeContent is not forwarded.
2019-11-14 01:42:28 +03:00
Simone Bordet c8d98459c0
Merge pull request #4270 from eclipse/jetty-9.4.x-4258-ratecontrol_per_connection
Fixes #4258 - RateControl should be per-connection.
2019-11-14 01:20:05 +03:00
Joakim Erdfelt a44a46f3f1
Adding stalebot integration
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2019-11-13 15:43:48 -06:00
Joakim Erdfelt 6b96e3db21
Adding stalebot integration
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2019-11-13 15:42:07 -06:00
Joakim Erdfelt 5479ed030f
Issue #4248 - Using ServletUpgradeResponse.setSuccess(true) for servlet side
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2019-11-13 15:33:00 -06:00
Joakim Erdfelt 6a6206d8e4
Issue #4248 - Deprecating UpgradeResponse setSuccess / isSuccess
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2019-11-13 15:32:23 -06:00
Lachlan ef0dc735bb
Merge pull request #4308 from eclipse/jetty-9.4.x-4236-RedirectCode
Issue #4236 - move redirect code calculation to utility method
2019-11-14 07:38:39 +11:00
Joakim Erdfelt 9c9e842cd7
Merge pull request #4300 from eclipse/jetty-9.4.x-4296-websocketclient-double-decode
Fixes #4296 - WebSocketClient cannot connect with "%25" in query
2019-11-13 10:54:07 -06:00
Simone Bordet 9e18e9e0ab
Merge pull request #4309 from eclipse/jetty-9.4.x-4305-no_application_protocol
Fixes #4305 - Jetty server shall alert fatal no_application_protocol …
2019-11-13 18:58:49 +03:00
Simone Bordet e3f31a86a2 Fixed flaky test testUpload_Multipart().
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2019-11-13 16:46:11 +01:00
Simone Bordet e7e7a30e11 Fixes #4305 - Jetty server shall alert fatal no_application_protocol if no client application protocol is supported.
Now catching any exception and returning null so JSSE returns the
no_application_protocol to the client.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2019-11-13 10:28:51 +01:00
Lachlan Roberts 4e43258785 Issue #4236 - move redirect code to utility method
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2019-11-13 17:19:09 +11:00
Greg Wilkins 4f6585562f
Issue #4161 WriteLifeCycle
Removed PersistentFileUploadDownloadTest as issue was replicated with DelayedServerTest
2019-11-13 15:37:31 +11:00