Simone Bordet
b48873f33b
Issue #4170 - Client-side alias selection based on SSLEngine.
...
Cosmetics.
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2019-10-09 10:23:22 +02:00
Simone Bordet
0fc5ec9d18
Merge pull request #4171 from eclipse/jetty-9.4.x-4170-client_side_alias_selection
...
Fixes #4170 - Client-side alias selection based on SSLEngine.
2019-10-09 09:30:37 +02:00
Greg Wilkins
0bd71a4359
Pathwatcher Concurrent modification #4174 ( #4175 )
...
There is a race between the doStop clearing the key map and the watching thread
checking isRunning before iterating over the key map.
While more sophisticated approaches could be used, I think that is best to defer
until this class is reworked entirely. For now just using a ConcurrentHashMap will
avoid the exception and the closing of the pathwatcher will prevent watching forever.
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2019-10-09 13:58:16 +11:00
Greg Wilkins
31a0180133
Improve debug logging of gzip inflation
...
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2019-10-09 11:51:13 +11:00
Greg Wilkins
8087e29211
Reverted getSession(id) to public
...
This method is used by third party session handlers.
Reverts change made as part of #3913
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2019-10-09 11:46:43 +11:00
Chris Walker
3328a28f09
Added instructions for a shaded start.jar maven dependency. Resolves #2407
2019-10-08 15:21:59 -04:00
Simone Bordet
742f564332
Fixes #4170 - Client-side alias selection based on SSLEngine.
...
Fixed setting of host/port in AbstractConnectorHttpClientTransport
and HttpProxy so that the creation of SSLEngine can use the proper
host/port pair, and can be subsequently used in TLS components.
Introduced SslContextFactory X509ExtendedKeyManagerWrapper and
X509ExtendedTrustManagerWrapper as utility classes used internally
and in tests.
The test case for this issue required 3 keystores, so other test
classes have been refactored to use the new keystores.
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2019-10-08 18:32:23 +02:00
Simone Bordet
7164171674
Issue #2429 - Review HttpClient backpressure semantic.
...
Restored tests that were commented out.
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2019-10-08 09:54:41 +02:00
Greg Wilkins
1c5a53a512
test async gzip close
...
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2019-10-08 18:14:17 +11:00
Simone Bordet
f68ed50405
Merge pull request #4106 from eclipse/jetty-9.4.x-2429-httpclient_backpressure
...
Issue #2429 - Review HttpClient backpressure semantic.
2019-10-08 09:10:51 +02:00
Lachlan
0403f0bc85
Merge pull request #4133 from travisspencer/feature-4132
...
Issue #4132 - Allow token and authorization endpoints to be configured
2019-10-08 13:46:21 +11:00
Travis Spencer
1d5ceee267
Issue #4132 Allow token and authorization endpoints to be configured
...
Signed-off-by: Travis Spencer <travis@curity.io>
2019-10-08 01:04:34 +02:00
Simone Bordet
a4603c4237
Issue #2429 - Review HttpClient backpressure semantic.
...
Updated after review.
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2019-10-08 00:52:11 +02:00
Lachlan
6e698df4d3
Merge pull request #4135 from travisspencer/4134-fix-aud
...
Issue #4134 - Validate audience (aud) claim as list or string, not just string
2019-10-08 09:28:22 +11:00
Lachlan
acf4eeff65
Merge pull request #4129 from travisspencer/fix-4128
...
Issue #4128 - Add missing padding and use URL decoder
2019-10-08 09:17:12 +11:00
Travis Spencer
1c6202658e
Validate aud claim as list or string, not just string
...
Signed-off-by: Travis Spencer <travis@curity.io>
2019-10-06 18:00:32 +02:00
Travis Spencer
8b37a8f7fe
Issue #4128 - Add missing padding and use URL decoder
...
Signed-off-by: Travis Spencer <travis@curity.io>
2019-10-05 18:06:26 +02:00
Jesse Wilson
d4270d9e97
Better advice for skipping tests in README.md ( #4157 )
...
This causes test artifacts to be built even though tests are not run.
Signed-off-by: Jesse Wilson <jwilson@squareup.com>
2019-10-05 08:32:16 +10:00
Lachlan Roberts
d95c825c5c
Issue #3558 - only notify WS onError if onClose has not been called
...
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2019-10-04 11:13:38 +10:00
Simone Bordet
ef05f730e6
Issue #4115 - Drop HTTP/2 pseudo headers.
...
Added Javadocs.
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2019-10-03 16:58:16 +02:00
Simone Bordet
3be178c966
Merged 'jetty-9.4.x' into 'jetty-9.4.x-2429-httpclient_backpressure'.
2019-10-03 13:17:39 +02:00
Simone Bordet
609c144ae0
Fixes #4115 - Drop HTTP/2 pseudo headers.
...
Invalid HTTP/2 headers are now causing an error rather than being ignored.
HTTP2Flusher now catches HpackException.StreamException and generates a
RST_STREAM frame, rather than just closing the connection.
Modified HpackEncoder to throw HpackException in case of encoding failure.
Introduced HpackEncoder.validateEncoding (defaults true) so validation of
the headers can be disabled (useful for tests).
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2019-10-03 12:45:55 +02:00
Joakim Erdfelt
c19d33dc59
Merge pull request #4149 from eclipse/jetty-9.4.x-4121-qtp-threadfactory
...
Issue #4121 - ThreadFactory support in QTP
2019-10-02 14:43:08 -05:00
Joakim Erdfelt
ed9031bd30
Merge pull request #4143 from eclipse/jetty-9.4.x-4141-classcastexception-request-async
...
Fixes #4141 - Servlet not async + async Filter + wrapped request
2019-10-02 13:49:21 -05:00
Joakim Erdfelt
b121ba786b
Issue #4121 - Tests for ThreadFactory support in QTP
...
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2019-10-02 13:37:22 -05:00
Joakim Erdfelt
b82b337e8e
Merge branch 'jetty-9.4.x' into jetty-9.4.x-4121-qtp-threadfactory
2019-10-02 12:55:25 -05:00
Simone Bordet
2f06976e41
Fixed flaky test and code cleanup.
...
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2019-10-02 17:06:45 +02:00
Joakim Erdfelt
dd18c698f5
Issue #4121 - ThreadFactory support in QTP
...
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2019-10-02 07:46:12 -05:00
Greg Wilkins
813fcb79ab
Jetty 9.4.x 4105 4121 4122 queued thread pool ( #4146 )
...
Several QTP fixes:
* #4105 Threads without jobs now check if they should idle die before waiting rather than before, this allows idling under steady load. 3ad6780
* #4121 ThreadFactory behaviour supported by doing thread config within newThread call. 7b306d7
* #4122 Always clear the interrupted status. c37a4ff
task = queue.poll(timeout);
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2019-10-02 22:07:00 +10:00
Simone Bordet
7810f2dec2
Reverted 82a00524d1
.
...
The connection upgrade check is necessary both after the parsing and
after the handling. After the parsing covers HTTP/2 prior knowledge
"PRI * HTTP/2" case; after the handling covers the WebSocket case.
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2019-10-02 10:18:06 +02:00
Joakim Erdfelt
bb939f6f71
Merge pull request #4145 from eclipse/jetty-9.4.x-4144-naked-request-cast
...
Fixing #4144 - handle wrapped requests better
2019-10-01 19:06:07 -05:00
Joakim Erdfelt
e9ac2c8c97
Fixing #4144 - handle wrapped requests better
...
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2019-10-01 17:49:30 -05:00
Joakim Erdfelt
7d533bdabc
Adding missing copyright header.
...
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2019-10-01 17:30:24 -05:00
Joakim Erdfelt
0a5c710bdd
Fixes #4141 - Servlet not async + async Filter + wrapped request
...
+ Fixing ClassCastException
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2019-10-01 17:24:27 -05:00
Joakim Erdfelt
6fc42d8ba2
Merge branch 'release-9.4.21' into jetty-9.4.x
2019-10-01 13:35:43 -05:00
Simone Bordet
a380f6b7b9
Merge pull request #4081 from eclipse/jetty-9.4.x-HttpConnection_UpgradeCheck
...
Remove unnecessary Connection upgrade check
2019-10-01 18:10:23 +02:00
Simone Bordet
72d1a297a0
Merge pull request #4109 from mofleury/jetty-9.4.x
...
Support meaningful JMX ObjectNames for HttpDestinations by avoiding race condition at creation
2019-10-01 17:31:45 +02:00
Simone Bordet
5b829a10e4
Cosmetics.
...
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2019-10-01 17:23:29 +02:00
Lachlan
fef5975b86
Merge pull request #4108 from eclipse/jetty-9.4.x-4104-WSSession_SendAfterClose
...
Issue #4104 - WebSocketSession will reject outgoing frames if closed
2019-10-01 15:46:16 +10:00
Lachlan
4fff51361d
Merge pull request #4101 from eclipse/jetty-9.4.x-4096-ReservedThreadExecutor_stop
...
Issue #4096 - allow thread to exit ReservedThreadExecutor on stop
2019-10-01 15:44:37 +10:00
Lachlan
e80ee375b6
Merge pull request #4131 from travisspencer/fix-4130
...
Issue #4130 - Don't add scopes if none are provided
2019-10-01 10:28:28 +10:00
Simone Bordet
062afc59ad
Merge pull request #4126 from eclipse/jetty-9.4.x-3787-httpclient_eofexception_instead_of_sslhandshakeexception
...
Issue #3787 - Jetty client throws EOFException instead of SSLHandshakeException on certificate errors
2019-09-30 08:54:23 +02:00
Simone Bordet
a85a18e0d8
Fixes #3787 - Jetty client throws EOFException instead of SSLHandshakeException on certificate errors.
...
Fixed indent.
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2019-09-30 08:53:12 +02:00
Marc-Olivier Fleury
8e51a4d532
adjusted formatting to follow standards
...
Signed-off-by: Marc-Olivier Fleury <mofleury@gmail.com>
2019-09-30 08:34:54 +02:00
Travis Spencer
201264d17b
Don't add scopes if none are provided
...
Signed-off-by: Travis Spencer <travis@curity.io>
2019-09-28 18:05:48 +02:00
Simone Bordet
4d3423e88f
Fixes #3787 - Jetty client throws EOFException instead of SSLHandshakeException on certificate errors.
...
Marked the test with @Tag("external") since it
contacts the external server tools.ietf.org.
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2019-09-27 15:18:57 +02:00
Simone Bordet
ad2770ddc2
Fixes #3787 - Jetty client throws EOFException instead of SSLHandshakeException on certificate errors.
...
Updates after review.
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2019-09-27 00:15:34 +02:00
Simone Bordet
2c75e876a3
Fixes #3787 - Jetty client throws EOFException instead of SSLHandshakeException on certificate errors.
...
Now exceptions thrown by fill() or flush() are stored in a field.
Further fill() operations will rethrow the original exception rather
than returning -1.
Returning -1 to application was causing them to close() with a generic
failure that was triggering the EOFException reported in this issue.
Now applications see the original exception and can close() with the
proper cause.
Re-enabled HostnameVerificationTest that was reproducing this issue
reliably but was @Disabled a while back and never re-enabled.
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2019-09-26 18:30:43 +02:00
Simone Bordet
d12df30df7
Issue #3787 - Jetty client throws EOFException instead of SSLHandshakeException on certificate errors.
...
Code cleanups.
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2019-09-26 18:18:13 +02:00
Joakim Erdfelt
7807eafad9
Updating to version 9.4.22-SNAPSHOT
2019-09-26 10:46:28 -05:00