Simone Bordet
2e633a4e86
Fixes #4217 - SslConnection.DecryptedEnpoint.flush eternal busy loop.
...
Releasing the encrypted output buffer so that it can be re-acquired
with an expanded capacity.
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2019-10-17 19:41:52 +02:00
Lachlan Roberts
337b6c1439
Issue #4138 - Changes from review
...
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2019-10-17 15:59:21 +11:00
Greg Wilkins
894fc9b115
Issue #4208 - Content-Length in 304 ( #4211 )
...
* Issue #4208 Content-Length in 304
Added tests for RFC7230 section 3.3.2 for 304 and HEAD responses with content length.
Fixed HttpGenerator to set content-length in 304 response
Fixed insufficient content written check for 304
Signed-off-by: Greg Wilkins <gregw@webtide.com>
* Issue #4208 Content-Length in 304
Use contentLengthField
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2019-10-17 14:26:19 +11:00
Simone Bordet
869184c827
Merge pull request #4200 from eclipse/jetty-9.4.x-4190-deadlock_httpoutput_close
...
Fixes #4190 Jetty hangs after thread blocked in SharedBlockingCallbac…
2019-10-16 23:35:52 +02:00
Simone Bordet
2efce33fbe
Merge pull request #4202 from eclipse/jetty-9.4.x-4201-httpclient_throw_sslhandshakeexception
...
Fixes #4201 - Throw SSLHandshakeException in case of TLS handshake fa…
2019-10-16 23:31:12 +02:00
Joakim Erdfelt
fe545f1af9
Merge pull request #4192 from eclipse/jetty-9.4.x-4191-min-gzip-size
...
Issue #4191 - GzipHandler.minGzipSize cannot be lower then 23.
2019-10-16 13:27:58 -07:00
Simone Bordet
94aff6b848
Merged branch 'jetty-9.3.x' into 'jetty-9.4.x'.
2019-10-16 22:14:22 +02:00
Simone Bordet
abc92e5c5d
Merged branch 'jetty-9.2.x' into 'jetty-9.3.x'.
2019-10-16 21:53:17 +02:00
Simone Bordet
c9bf1744a5
Updated ALPN version for JDK 8u231 and 8u232.
...
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2019-10-16 21:11:46 +02:00
Simone Bordet
20e0453da8
Merged branch 'jetty-9.4.x' into 'jetty-9.4.x-4201-httpclient_throw_sslhandshakeexception'.
2019-10-16 18:51:15 +02:00
Simone Bordet
4d0bae2351
Merge pull request #4210 from eclipse/jetty-9.4.x-4209-unused_tls_connection_not_closed_java11
...
Jetty 9.4.x 4209 unused tls connection not closed java11
2019-10-16 18:23:45 +02:00
Simone Bordet
1e360244a5
Fixes #4209 - Unused TLS connection is not closed in Java 11.
...
Added workarounds for the Java 11 behavior.
In fill(), call closeInbound() if we filled -1 and the handshake
did not start yet. This avoids to send a ClientHello to the peer
even if we are closing.
In flush(), if the handshake status is NEED_UNWRAP but we are
closing, force a wrap().
Added test cases.
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2019-10-16 13:10:40 +02:00
Greg Wilkins
7cc552013e
Issue #4191 Min GzipSize
...
updates from review from OP.
reverted static DEFAULT_MIN_GZIP_SIZE
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2019-10-16 22:07:51 +11:00
Simone Bordet
4769de8a2b
Issue #4209 - Unused TLS connection is not closed in Java 11.
...
Code cleanup.
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2019-10-16 13:02:24 +02:00
Greg Wilkins
2ee874a8ac
Merge remote-tracking branch 'origin/jetty-9.4.x' into jetty-9.4.x-4191-min-gzip-size
...
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2019-10-16 22:00:52 +11:00
Greg Wilkins
031df2bd2e
simplified javadoc
...
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2019-10-16 18:19:22 +11:00
Greg Wilkins
b7c9384291
fixed test
...
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2019-10-16 18:16:39 +11:00
Lachlan Roberts
039fb38070
Issue #4138 - use HttpClient for OpenID Authentication
...
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2019-10-16 16:26:21 +11:00
Greg Wilkins
1881683726
Issue #4191 Min GzipSize
...
updates from review in absence of OP.
Make break even size a warning rather than a hard limit.
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2019-10-16 16:22:14 +11:00
Jan Bartel
20e7aa01f2
Issue #4183 Handle null class location for ClasspathPattern. ( #4197 )
...
Signed-off-by: Jan Bartel <janb@webtide.com>
2019-10-16 14:14:49 +11:00
Greg Wilkins
73924d2774
Issue #4188 Spin in close of GzipHandler ( #4198 )
...
* Issue #4188 Spin in close of GzipHandler
Cleanup and simplify code
Signed-off-by: Greg Wilkins <gregw@webtide.com>
* Issue #4188 Spin in close of GzipHandler
Fix slice code. Added unit test for it.
Signed-off-by: Greg Wilkins <gregw@webtide.com>
* Issue #4188 Spin in close of GzipHandler
Fixed last slice.
Signed-off-by: Greg Wilkins <gregw@webtide.com>
* cleanup from review
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2019-10-16 14:12:52 +11:00
Jan Bartel
92c8bb8dd5
Issue #4158 Re-enable support for duplicate session cookies. ( #4168 )
...
* Issue #4158 Re-enable support for duplicate session cookies.
Signed-off-by: Jan Bartel <janb@webtide.com>
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2019-10-16 14:08:51 +11:00
Greg Wilkins
2eb251a4b8
fix logging defaults to INFO
...
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2019-10-16 13:53:57 +11:00
Lachlan Roberts
fd004817d4
Merge remote-tracking branch 'travisspencer/openid-feature-use-http-client' into jetty-9.4.x-4189-OpenIdHttpClient
2019-10-16 09:54:42 +11:00
Joakim Erdfelt
fa25d560b3
Fixing typo
...
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2019-10-15 13:52:39 -05:00
Joakim Erdfelt
9c49b03806
Adding missing license header
...
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2019-10-15 13:32:59 -05:00
Simone Bordet
3ce87f717c
Fixes #4201 - Throw SSLHandshakeException in case of TLS handshake failures.
...
Now rethrowing other exceptions as SSLHandshakeException
if they happen during the TLS handshake.
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2019-10-15 16:44:30 +02:00
Simone Bordet
6b26ac9ee9
Fixes #4190 Jetty hangs after thread blocked in SharedBlockingCallback.block() called by HttpOutput.close.
...
Now releasing the buffer when in CLOSING state.
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2019-10-15 15:47:03 +02:00
Simone Bordet
83185334e0
Merge pull request #4182 from eclipse/jetty-9.4.x-4142-RateControl
...
Issue #4142 - module config for http2 maxSettingsKeys and RateControl
2019-10-15 13:00:26 +02:00
Lachlan Roberts
5329ecf5be
Issue #4142 - changes from review
...
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2019-10-15 21:56:54 +11:00
Simone Bordet
a0e90bab96
Fixes #4190 Jetty hangs after thread blocked in SharedBlockingCallback.block() called by HttpOutput.close.
...
Now handling correctly the CLOSING case in HttpOutput.close().
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2019-10-15 12:45:10 +02:00
Lachlan Roberts
4f640387f2
Issue #4142 - changes from review
...
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2019-10-15 21:09:01 +11:00
Lachlan Roberts
709e05a19f
Issue #4142 - changes from review
...
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2019-10-15 19:08:45 +11:00
Travis Spencer
46d3a371cf
Use HttpClient instead of HttpURLConnection
...
Signed-off-by: Travis Spencer <travis@curity.io>
2019-10-15 08:50:33 +02:00
Lachlan Roberts
5ff79b0bf1
Issue #4142 - changes from review
...
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2019-10-15 11:23:53 +11:00
contextshuffling
320e848c57
Fixes #4195 : making test assertion more stable ( #4196 )
...
Signed-off-by: contextshuffling <contextshuffling@gmail.com>
2019-10-15 07:54:09 +11:00
Joakim Erdfelt
0fbb507841
Issue #4191 - GzipHandler.minGzipSize cannot be lower then 23.
...
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2019-10-14 13:21:01 -05:00
Greg Wilkins
f09e03c586
Issue #4156 - Session Already in Cache during forwarding ( #4159 )
...
* Issue #4156 - Adding test to replicate issue
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
* Issue #4156 Session already in cache
+ check validity of sessions in getSession(SessionHandler)
+ do not replace session in doScope if SessionHandler is the same.
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2019-10-14 11:18:37 +11:00
Lachlan Roberts
a96fb176f6
Issue #4142 - module config for http2 maxSettingsKeys and RateControl
...
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2019-10-11 11:24:48 +11:00
Simone Bordet
ec56739d3c
Merge pull request #4180 from eclipse/jetty-9.4.x-4179-SendCallback-gc
...
Issue #4179 SendCallback GC
2019-10-10 12:45:30 +02:00
Simone Bordet
cd57af4caf
Merge pull request #4116 from eclipse/jetty-9.4.x-4115-drop_http2_pseudo_headers
...
Fixes #4115 - Drop HTTP/2 pseudo headers.
2019-10-10 12:15:58 +02:00
Simone Bordet
687873cb7b
Issue #4115 - Drop HTTP/2 pseudo headers.
...
Fixed NPE if the method was missing.
Renamed lowCase -> lowerCase.
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2019-10-10 11:11:36 +02:00
Simone Bordet
cf687457e7
Issue #4177 - Configure HTTP proxy with SslContextFactory.
...
Small fixes after merge.
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2019-10-10 10:41:42 +02:00
Greg Wilkins
ce41c122a6
Issue #4176 setHeader after sendError ( #4181 )
...
* Issue #4176 setHeader after sendError
SendError now makes the response immutable for headers and status.
Signed-off-by: Greg Wilkins <gregw@webtide.com>
* Issue #4176 setHeader after sendError
cleanup after review
better names
Signed-off-by: Greg Wilkins <gregw@webtide.com>
* Issue #4176 setHeader after sendError
better name
Signed-off-by: Greg Wilkins <gregw@webtide.com>
* Issue #4176 setHeader after sendError
even better name
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2019-10-10 19:35:28 +11:00
Simone Bordet
53ed8f346c
Merge pull request #4178 from eclipse/jetty-9.4.x-4177-http_proxy_sslcontextfactory
...
Fixes #4177 - Configure HTTP proxy with SslContextFactory.
2019-10-10 10:02:48 +02:00
Simone Bordet
a73568df28
Fixes #4177 - Configure HTTP proxy with SslContextFactory.
...
Updates after review.
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2019-10-10 10:00:17 +02:00
Lachlan
00baa7147e
Merge pull request #4153 from eclipse/jetty-9.4.x-3558-websocket_onErrorAfterClose
...
Issue #3558 - only notify WS onError if onClose has not been called
2019-10-10 15:27:11 +11:00
Greg Wilkins
faac5d7f04
Issue #4179 SendCallback GC
...
The HttpConnection.SendCallback nulls it's reference to buffers and callbacks after completion to assist with easy GC, since the connection callback is a long lived instance.
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2019-10-10 09:09:53 +11:00
Simone Bordet
6acc9f7be5
Issue #4115 - Drop HTTP/2 pseudo headers.
...
Updates after review.
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2019-10-09 21:01:30 +02:00
Simone Bordet
c8175ec107
Fixes #4177 - Configure HTTP proxy with SslContextFactory.
...
It is now possible to pass a `SslContextFactory.Client` to HttpProxy
so that it is possible to use a keystore for the proxy communication
and another keystore for the server communication.
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2019-10-09 17:37:00 +02:00