d44a6935ef
Issue #4331 - Improve handling of HttpOutput.close() for pending writes.
...
Added test case that verifies the current behavior (abort the response
in case complete() is called with a pending write()).
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2019-11-19 17:09:04 +01:00
9ab6a073fa
we do not need those repositories now
...
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
2019-11-19 20:28:43 +10:00
e89e8ae16e
Improved toString() for ConnectionPool implementations.
...
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2019-11-19 10:43:09 +01:00
cef80aca2e
Revert "jetty-websocket-tests code cleanup"
...
This reverts commit 044a899a99
2019-11-19 19:14:54 +11:00
6db5f3be8d
force clean
...
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
2019-11-19 18:13:18 +10:00
044a899a99
jetty-websocket-tests code cleanup
...
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2019-11-19 18:30:44 +11:00
61cbb7529d
Removing duplicate log output
...
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2019-11-18 16:44:48 -06:00
8a30543845
Merge pull request #4326 from eclipse/jetty-9.4.x-4325-deprecate-NoSsl-SniX509
...
Issue #4325 - X509ExtendedKeyManager exceptions on non-Server SSL
2019-11-18 12:55:24 -06:00
f4d387e0d6
Issue #4325 - X509ExtendedKeyManager exceptions on non-Server SSL
...
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2019-11-18 12:13:05 -06:00
55ad1074bd
Issue #4325 - X509ExtendedKeyManager exceptions on non-Server SSL
...
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2019-11-18 10:58:12 -06:00
bf2482a7ea
Moved implementation from Adapter classes to default methods in
...
the interface to avoid binary compatibility problems in case the
interface is changed.
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2019-11-18 10:29:55 +01:00
65063da638
Merge pull request #4322 from eclipse/jetty-9.4.x-3869-update-asm-7.2
...
Issue #3869 Update to asm 7.2
2019-11-18 11:39:17 +03:00
ac63c121b6
Issue #3869 Update to asm 7.2
...
Signed-off-by: Jan Bartel <janb@webtide.com>
2019-11-18 16:49:15 +11:00
318246eb24
Issue #4156 Remove use of PlaceHolderSession for simultaneous session loading ( #4304 )
...
* Issue #4156 Remove use of PlaceHolderSession for simultaneous session loading.
2019-11-18 09:06:38 +11:00
e69eea86c8
make rerunFailingTestsCount a property so we can change it on cli if needed
...
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
2019-11-18 07:20:42 +10:00
905deeb49a
Jetty 9.4.x rerun failing tests count set to 3 and upgrade surefire which supports it for junit5 ( #4320 )
...
* rerunFailingTestsCount and test surefire 3.0.0-M4 fixing it for junit5
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
2019-11-18 07:10:44 +10:00
46dbfda52e
Introducing stalebot.yml anew (again)
...
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2019-11-15 15:19:47 -06:00
3c42bbedbc
Removing stalebot.yml temporarily
...
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2019-11-15 15:19:13 -06:00
b5a430fbf9
Dropping colons
...
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2019-11-14 11:42:19 -06:00
2bc5cacd49
Updating template for os/type
...
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2019-11-14 11:42:19 -06:00
f89f81a363
Updating templates based on feedback
...
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2019-11-14 11:32:33 -06:00
402f499f19
Adding TCK to skipped labels
...
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2019-11-14 11:17:08 -06:00
d66fe9ac0c
Adding ISSUE_TEMPLATE
...
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2019-11-14 11:17:08 -06:00
c44e7c5eb1
Merge pull request #4299 from eclipse/jetty-9.4.x-4248-websocketclient-success-flag
...
Fixes #4248 - WebSocketClient UpgradeResponse.isSuccess never set true
2019-11-14 09:42:45 -06:00
0d0b346140
Updated ALPN modules for Java >= 11 so that
...
they can be easily merged to Jetty 10.0.x.
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2019-11-14 09:48:28 +01:00
32931fac7b
Issue #4247 SameSite Session Cookie ( #4271 )
...
* Issue #4247 SameSite Session Cookie
Allows sameSite cookie settings to be configured in SessionCookieConfig comments
Signed-off-by: Greg Wilkins <gregw@webtide.com>
* Issue #4247 SameSite Session Cookies
Use non versioned cookie
Signed-off-by: Greg Wilkins <gregw@webtide.com>
* Issue #4247 SameSite Session Cookies
Added test and fixed getCommentWithAttributes
Signed-off-by: Greg Wilkins <gregw@webtide.com>
* Issue #4247 - Updating unit tests for HttpCookie
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
* Issue #4247 SameSite Session Cookie
While it may be best practise to always use Secure cookies when SameSite is None, there is nothing in the RFC that mandates it and thus I don't believe we should prevent such a configuration. If browsers enforce this, then users will find out soon enough... and if browsers change, then we are not required to do a new release to match.
Signed-off-by: Greg Wilkins <gregw@webtide.com>
* Issue #4247 SameSite Session Cookie
For cookie comments with multiple SameSite attributes, the most strict
value is used. So `Strict` has precedence over `Lax` which has
precedence over `None`.
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2019-11-14 11:56:40 +11:00
b24c6ce68d
Issue #2340 ServletContext cleanup ( #4307 )
...
* Issue #2340 ServletContext cleanup
A minor cleanup of the ServletContext implementation classes.
Signed-off-by: Greg Wilkins <gregw@webtide.com>
* Issue #2340 ServletContext cleanup
cleanup after review
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2019-11-14 11:52:03 +11:00
89a4f92411
Merge pull request #4302 from eclipse/jetty-9.4.x-4301-demand_beforecontent_not_forwarded
...
Fixes #4301 - Demand beforeContent is not forwarded.
2019-11-14 01:42:28 +03:00
c8d98459c0
Merge pull request #4270 from eclipse/jetty-9.4.x-4258-ratecontrol_per_connection
...
Fixes #4258 - RateControl should be per-connection.
2019-11-14 01:20:05 +03:00
a44a46f3f1
Adding stalebot integration
...
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2019-11-13 15:43:48 -06:00
6b96e3db21
Adding stalebot integration
...
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2019-11-13 15:42:07 -06:00
5479ed030f
Issue #4248 - Using ServletUpgradeResponse.setSuccess(true) for servlet side
...
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2019-11-13 15:33:00 -06:00
6a6206d8e4
Issue #4248 - Deprecating UpgradeResponse setSuccess / isSuccess
...
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2019-11-13 15:32:23 -06:00
ef0dc735bb
Merge pull request #4308 from eclipse/jetty-9.4.x-4236-RedirectCode
...
Issue #4236 - move redirect code calculation to utility method
2019-11-14 07:38:39 +11:00
9c9e842cd7
Merge pull request #4300 from eclipse/jetty-9.4.x-4296-websocketclient-double-decode
...
Fixes #4296 - WebSocketClient cannot connect with "%25" in query
2019-11-13 10:54:07 -06:00
9e18e9e0ab
Merge pull request #4309 from eclipse/jetty-9.4.x-4305-no_application_protocol
...
Fixes #4305 - Jetty server shall alert fatal no_application_protocol …
2019-11-13 18:58:49 +03:00
e3f31a86a2
Fixed flaky test testUpload_Multipart().
...
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2019-11-13 16:46:11 +01:00
e7e7a30e11
Fixes #4305 - Jetty server shall alert fatal no_application_protocol if no client application protocol is supported.
...
Now catching any exception and returning null so JSSE returns the
no_application_protocol to the client.
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2019-11-13 10:28:51 +01:00
4e43258785
Issue #4236 - move redirect code to utility method
...
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2019-11-13 17:19:09 +11:00
4f6585562f
Issue #4161 WriteLifeCycle
...
Removed PersistentFileUploadDownloadTest as issue was replicated with DelayedServerTest
2019-11-13 15:37:31 +11:00
24df8c59a3
Issue #4279 Writer close deadlock ( #4288 )
...
Do not close the actual writer from closed.
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2019-11-13 11:03:17 +11:00
fe4b9cf366
Issue #4161 Write LifeCycleViolation ( #4294 )
...
* Issue #4161 - TestCase that can replicate problem on OSX
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
* Issue #4161 - Naming Server threadpool (to help with debugging)
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
* Issue #4161 - bumping up test file size to 10 MB
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
* Issue #4161 Write LifeCycleViolation
Do not callback on write completion until after state has been changed and notifications made.
Signed-off-by: Greg Wilkins <gregw@webtide.com>
* Issue #4161 Write LifeCycleViolation
Added a unit test that replicated the problem.
Signed-off-by: Greg Wilkins <gregw@webtide.com>
* Issue #4161 - `EofException: request lifecycle violation` in stderr.
Moved notifications of commit and content listeners back to succeeded().
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
* Issue #4161 - Improved Logging for test-integration
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
* Issue #4161 - Reducing size of test file
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2019-11-13 11:02:12 +11:00
aa57463175
Fixes #4301 - Demand beforeContent is not forwarded.
...
Now correctly handling no demand before the content
in FCGI and HTTP2 transports.
Fixed HttpRequest to correctly forward onBeforeContent()
to wrapped listeners.
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2019-11-12 23:33:21 +01:00
3def3415ed
Merge pull request #4289 from eclipse/jetty-9.4.x-4287-move-getUriLastPathSegment
...
Issue #4287 - Move getUriLastPathSegment() to URIUtil
2019-11-12 14:51:23 -06:00
ba1724ae34
Fixes #4258 - RateControl should be per-connection.
...
Updates after review.
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2019-11-12 17:46:19 +01:00
2d50c92979
Fixes #4296 - WebSocketClient cannot connect with "%25" in query
...
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2019-11-12 10:22:19 -06:00
544ad0a28a
Fixes #4248 - WebSocketClient UpgradeResponse.isSuccess never set true
...
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2019-11-12 10:14:51 -06:00
4825832a53
Merge pull request #4286 from eclipse/jetty-9.4.x-4277-httpclient_async_gzip
...
Fixes #4277 - Reading streamed gzipped body never terminates.
2019-11-12 19:04:05 +03:00
d22f5b1d9d
Issue #4282 - Review HttpParser handling in case of no content.
...
Removed TODOs.
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2019-11-12 17:02:05 +01:00
454175af1a
Merge pull request #4293 from eclipse/jetty-9.4.x-4282-review_httpparser_nocontent
...
Issue #4282 - Review HttpParser handling in case of no content.
2019-11-12 17:55:40 +03:00
Simone Bordet
olivier lamy
Lachlan Roberts
Joakim Erdfelt
Jan Bartel
Greg Wilkins