Commit Graph

9280 Commits

Author SHA1 Message Date
Jan Bartel d580c3279b Make LoginService tests use single database and drop and recreate tables 2014-07-18 17:02:41 +10:00
Joakim Erdfelt e9a77b6ac7 Work with derby internal caching of "derby.system.home" system property.
+ Turns out, changing "derby.system.home" is unreliable.
+ Using 'directory' based jdbc urls for derby to avoid finding content
  in the classloader too.
+ Use a common derby "System Home" for all tests.
+ Segregate all database creation into own, test-specific, database.
2014-07-17 21:57:57 -07:00
Joakim Erdfelt a09d05ee9d Better cleanup of LoginService tests 2014-07-17 20:55:58 -07:00
Joakim Erdfelt dcee2bd5c4 Adding dstest manual creation, not letting derby create it 2014-07-17 20:50:30 -07:00
Greg Wilkins 30fcce1cdc 434536 Improved Customizer javadoc 2014-07-18 12:18:29 +10:00
Greg Wilkins 5c7f3e7c0d 432815 Fixed selector stop race 2014-07-18 12:05:32 +10:00
Joakim Erdfelt c4c8426069 439507 - Possible timing side-channel when comparing MD5-Credentials
+ Using correct digestMismatch logic
+ Fixing test cases:
  + No longer reuses / shares directories
  + Is now Windows build/test compatible
  + No longer deleteOnExit() the test data
    (let maven clean and/or test init do that)
  + Empty directories are now verified
  + Using server.getURI() instead of URL string manipulation
2014-07-17 17:55:22 -07:00
Joakim Erdfelt e39adb337f 439672 support using Apache commons daemon for managing Jetty
Signed-off-by: marko asplund <marko.asplund@gmail.com>
2014-07-17 08:37:50 -07:00
Simone Bordet a7e87c5eed Updated NPN and ALPN to JDK 7u65 and 8u11. 2014-07-17 11:48:19 +02:00
Jan Bartel 405fd05a6e 439369 Deprecate CrossContextPseudoSession 2014-07-17 18:36:35 +10:00
Jan Bartel 3975d1170a 439753 ConstraintSecurityHandler has dead code for processing constraints 2014-07-17 18:23:14 +10:00
Greg Wilkins a89419fd3f 434536 Improved Customizer javadoc 2014-07-17 16:09:42 +10:00
Greg Wilkins a2a333ba53 435653 encode async dispatched requestURI 2014-07-17 15:51:22 +10:00
Greg Wilkins 2d52280179 436987 limited range of default acceptors and selectors 2014-07-17 14:29:58 +10:00
Greg Wilkins b13be9cfa6 438327 Remove hard coded Allow from OPTIONS * 2014-07-17 13:40:21 +10:00
Greg Wilkins 6bc08000c7 439066 javadoc setStopAtShutdown 2014-07-17 13:29:54 +10:00
Greg Wilkins 94ac37f8c2 439067 Javadoc for graceful server stop 2014-07-17 13:29:54 +10:00
Jan Bartel 182436301b 439438 DataSourceLoginService does not refresh passwords when changed in database 2014-07-17 12:54:35 +10:00
Greg Wilkins 12b522d796 439507 Avoid timing leak in MD5 compare
Also-by: Benny Baumann<BenBE@cacert.org>
2014-07-17 12:42:59 +10:00
Greg Wilkins 3a5e67ce9e Making ShutdownThread actually stop 2014-07-17 10:50:54 +10:00
Greg Wilkins 591eedcb59 [FindBugs] Include explicit typing whereever possible
+ No cleanup regarding unchecked types (yet)
2014-07-17 10:47:49 +10:00
Greg Wilkins 0c66f3a68e [FindBugs] Ensure resources are closed/freed properly
Removing dumb connector.close during server.getURI()
2014-07-17 10:00:26 +10:00
Greg Wilkins ec310dca90 Fixes to Hash Sessions for 'Stream Closed' errors 2014-07-17 09:45:12 +10:00
Greg Wilkins ce63ab2290 Ensure everything is finalized properly, especially that the lock is unlocked
The issue here was that due to the method call there was no guarantee that the unlock was reached in case of an exception.
Restructuring the code like this provides this guarantee
2014-07-17 08:51:45 +10:00
Greg Wilkins c19a14a4a2 [FindBugs] Ensure proper lazy-initialization even if this costs some performance 2014-07-17 08:35:40 +10:00
Joakim Erdfelt cecb8d6d04 Minor typo fix 2014-07-17 08:31:08 +10:00
Greg Wilkins 937ef10718 [FindBugs] outer if statement alreayd catches max_cached_files 2014-07-17 08:31:08 +10:00
Joakim Erdfelt 5be27516a4 [FindBugs] Remove unnecessary template specialization 2014-07-17 08:31:08 +10:00
Jan Bartel 1dcb7dd986 439194 Do not configure fake server for jetty:run-forked 2014-07-17 08:28:38 +10:00
Joakim Erdfelt 4bf7e9e440 [FindBugs] remove unused imports 2014-07-17 08:17:42 +10:00
Joakim Erdfelt ce48e7094d [FindBugs] Use java.utils.Arrays.hashCode
The method hashCode() of an raw array ignores the length and contents of the array
which yields equal hashCodes for arrays containing different items or varying in length.

This avoids unnecessarily returning equal hashCodes when the objects are actually different.
2014-07-17 08:17:18 +10:00
Joakim Erdfelt 347075ed2d [FindBugs] Possible Null Pointer Dereferences by values passed from caller 2014-07-17 08:16:57 +10:00
Joakim Erdfelt 1d0c370152 [FindBugs] Possible Null Pointer Dereferences by values passed from caller 2014-07-17 08:16:41 +10:00
Joakim Erdfelt a3c363832b [FindBugs] complaints about non-Boolean object used in %b format parameter 2014-07-17 08:14:55 +10:00
Greg Wilkins 409389ba6e 439652 GzipHandler super.doStart 2014-07-16 16:45:02 +10:00
Greg Wilkins 5f033b48d5 438204 leave IPv6 addresses [] wrapped in getServerName 2014-07-16 16:39:02 +10:00
Jan Bartel 50f11bea09 439663 Allow mappings to be declared before servlet/filter 2014-07-16 15:53:07 +10:00
Joakim Erdfelt dd5cdab54c 439540 - setReuseAddress() in ServerConnector.java is not coded properly
+ Adding unit test to confirm existing behavior of
  ServerConnector.setReuseAddress(boolean) and ServerConnector.open()
2014-07-15 17:02:51 -07:00
Simone Bordet 745f757552 Guarded calls to LOG.debug() with if (LOG.isDebugEnabled()) to reduce allocation of varargs Object[]. 2014-07-15 18:49:14 +02:00
Jesse McConnell 406eba7e26 testing autopush 2014-07-14 11:16:35 -05:00
Jan Bartel 28998e4913 439399 Scan tlds for apache jasper standard taglib with jetty-maven-plugin 2014-07-11 17:38:31 +10:00
Jan Bartel 5f77a0ef72 439394 load-on-startup with value 0 not preserved for quickstart 2014-07-11 16:25:32 +10:00
Jan Bartel d5c210f1c3 439390 Ensure jsp scratchdir is created same way for quickstart and non-quickstart 2014-07-11 16:06:40 +10:00
Jan Bartel 644eccab8b 439387 Ensure empty servlet-class never generated for quickstart 2014-07-11 14:16:24 +10:00
Jan Bartel c674c41003 438895 Add mvn jetty:effective-web-xml goal 2014-07-10 17:29:03 +10:00
Jan Bartel b13859c641 Fix javadoc for jetty:run mojo to point to correct documentation. 2014-07-10 17:29:03 +10:00
Greg Wilkins 55ca09a00e 438190 findbug improvements 2014-07-10 14:41:32 +10:00
Joakim Erdfelt 0c7de2e5bd 438331 - AbstractLogger.debug(String,long) infinite loop
+ Breaking infinit loop
2014-07-09 08:54:10 -07:00
Jan Bartel 5969638e69 439201 GzipFilter and AsyncGzipFilter should strip charset from Content-Type before making exclusion comparison in doFilter 2014-07-09 18:01:07 +10:00
Jan Bartel 10da0e1015 439194 Refactor mvn jetty:run-forked so that it is configurable the same as the other jetty:run-X goals 2014-07-09 15:07:39 +10:00