Hibernate
/
hibernate-orm
mirror of https://github.com/hibernate/hibernate-orm
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

HHH-18046 Fix Hana issue with binary arithmetic parameter operand and skip test for cockroach

This commit is contained in:
Christian Beikov 2024-05-06 12:15:00 +02:00
parent 9ba0dd7af0
commit 19c2c40f82
2 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
hibernate-core/src/main/java/org/hibernate/dialect/HANASqlAstTranslator.java
View File

@ -63,6 +63,11 @@ public class HANASqlAstTranslator<T extends JdbcOperation> extends AbstractSqlAs
} }
} }
@Override
protected void visitArithmeticOperand(Expression expression) {
render( expression, SqlAstNodeRenderingMode.NO_PLAIN_PARAMETER );
}
@SuppressWarnings("removal") @SuppressWarnings("removal")
private boolean isHanaCloud() { private boolean isHanaCloud() {
return ( (AbstractHANADialect) getDialect() ).isCloud(); return ( (AbstractHANADialect) getDialect() ).isCloud();

3
hibernate-core/src/test/java/org/hibernate/orm/test/hql/InferenceTest.java
View File

@ -8,12 +8,14 @@ package org.hibernate.orm.test.hql;
import java.util.List; import java.util.List;
import org.hibernate.dialect.CockroachDialect;
import org.hibernate.query.criteria.HibernateCriteriaBuilder; import org.hibernate.query.criteria.HibernateCriteriaBuilder;
import org.hibernate.query.criteria.JpaCriteriaQuery; import org.hibernate.query.criteria.JpaCriteriaQuery;
import org.hibernate.query.criteria.JpaRoot; import org.hibernate.query.criteria.JpaRoot;
import org.hibernate.testing.junit4.BaseCoreFunctionalTestCase; import org.hibernate.testing.junit4.BaseCoreFunctionalTestCase;
import org.hibernate.testing.orm.junit.JiraKey; import org.hibernate.testing.orm.junit.JiraKey;
import org.hibernate.testing.orm.junit.SkipForDialect;
import org.junit.After; import org.junit.After;
import org.junit.Before; import org.junit.Before;
import org.junit.Test; import org.junit.Test;
@ -83,6 +85,7 @@ public class InferenceTest extends BaseCoreFunctionalTestCase {
@Test @Test
@JiraKey("HHH-18046") @JiraKey("HHH-18046")
@SkipForDialect(dialectClass = CockroachDialect.class, reason = "See https://github.com/cockroachdb/cockroach/issues/123659")
public void testBinaryArithmeticParameterInference() { public void testBinaryArithmeticParameterInference() {
doInHibernate( this::sessionFactory, session -> { doInHibernate( this::sessionFactory, session -> {
HibernateCriteriaBuilder cb = session.getCriteriaBuilder(); HibernateCriteriaBuilder cb = session.getCriteriaBuilder();