Hibernate
/
hibernate-orm
mirror of https://github.com/hibernate/hibernate-orm
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

HHH-8551 - Cannot use with-clause on the RHS of a join

This commit is contained in:
Steve Ebersole 2013-09-26 15:40:49 -05:00
parent 2060e95c40
commit 7c6b358d4f
1 changed files with 11 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
hibernate-core/src/main/java/org/hibernate/hql/internal/ast/HqlSqlWalker.java
View File

@ -400,16 +400,18 @@ public class HqlSqlWalker extends HqlSqlBaseWalker implements ErrorReporter, Par
} }
} }
if (LOG.isDebugEnabled()) LOG.debugf("createFromJoinElement() : %s", if ( LOG.isDebugEnabled() ) {
getASTPrinter().showAsString(fromElement, "-- join tree --")); LOG.debug("createFromJoinElement() : " + getASTPrinter().showAsString(fromElement, "-- join tree --") );
}
} }
private void handleWithFragment(FromElement fromElement, AST hqlWithNode) throws SemanticException { private void handleWithFragment(FromElement fromElement, AST hqlWithNode) throws SemanticException {
try { try {
withClause( hqlWithNode ); withClause( hqlWithNode );
AST hqlSqlWithNode = returnAST; AST hqlSqlWithNode = returnAST;
if (LOG.isDebugEnabled()) LOG.debugf("handleWithFragment() : %s", if ( LOG.isDebugEnabled() ) {
getASTPrinter().showAsString(hqlSqlWithNode, "-- with clause --")); LOG.debug( "handleWithFragment() : " + getASTPrinter().showAsString(hqlSqlWithNode, "-- with clause --") );
}
WithClauseVisitor visitor = new WithClauseVisitor( fromElement, queryTranslatorImpl ); WithClauseVisitor visitor = new WithClauseVisitor( fromElement, queryTranslatorImpl );
NodeTraverser traverser = new NodeTraverser( visitor ); NodeTraverser traverser = new NodeTraverser( visitor );
traverser.traverseDepthFirst( hqlSqlWithNode ); traverser.traverseDepthFirst( hqlSqlWithNode );
@ -421,8 +423,11 @@ public class HqlSqlWalker extends HqlSqlBaseWalker implements ErrorReporter, Par
else { else {
FromElement referencedFromElement = visitor.getReferencedFromElement(); FromElement referencedFromElement = visitor.getReferencedFromElement();
if ( referencedFromElement != fromElement ) { if ( referencedFromElement != fromElement ) {
LOG.warn( "with-clause expressions do not reference the from-clause element to which the with-clause was associated. The query may not work as expected..." LOG.warnf(
+ queryTranslatorImpl.getQueryString() ); "with-clause expressions do not reference the from-clause element to which the " +
"with-clause was associated. The query may not work as expected [%s]",
queryTranslatorImpl.getQueryString()
);
} }
} }