Commit Graph

14660 Commits

Author SHA1 Message Date
Gavin 5ad9677728 remove redundant call 2022-12-03 09:51:02 +01:00
Gavin 85bfed78c3 fix a potential source of NPEs
(though this code path isn't working anyway for other reasons)
2022-12-03 09:51:02 +01:00
Gavin 6596389e55 make @IdGeneratorType accept Generator 2022-12-02 18:44:51 +01:00
Gavin eb6860d9d2 make @IdGeneratorType accept Generator 2022-12-02 17:58:40 +01:00
Gavin 9389295281 improve javadoc for Generator hierarchy
and make SelectGenerator a subclass of IdentityGenerator
2022-12-02 17:58:40 +01:00
Gavin 392b2f2364 update javadoc for InsertGeneratedIdentifierDelegate 2022-12-02 16:09:23 +01:00
Gavin 337919b766 kill off some awful code in IdentifierGeneratorHelper
- should make multi-column (post insert) id generators work by side effect
- also make StandardGenerator a mixin type interface
2022-12-02 16:09:23 +01:00
Gavin 4195772c15 generalize the InsertReturningDelegates to handle arbitrary InDatabaseGenerators
the bit limitation is that an InDatabaseGenerator can be multi-column, but all the
InsertReturningDelegates assume that they map exactly one IDENTITY column
2022-12-02 16:09:23 +01:00
Gavin 7b0ca427dd remove nexus between Generators and InsertGeneratedIdentifierDelegates
this is certain a very debatable move, but I think it's necessary to
keep the layering intact - we don't want this very technical construct
hanging off the side of the Generator APIs, which are user-visible
2022-12-02 16:09:23 +01:00
Gavin 6a630e3515 make PostInsertIdentifierGenerator extend InDatabaseGenerator 2022-12-02 16:09:23 +01:00
Sanne Grinovero 4b2f8ff8ae HHH-15793 Mitigate type pollution on ColumnReference#getExpressionType 2022-12-02 14:25:27 +00:00
Sanne Grinovero ed26c3f8fa HHH-15787 DefaultMergeEventlistener#onMerge is performing runtime services lookup 2022-12-02 11:21:18 +00:00
Sanne Grinovero 329ccaa7a1 HHH-15791 Avoid excessive Session casts to EventSource 2022-12-02 09:40:53 +00:00
Sanne Grinovero 6c2bff76c9
Update migration guide HHH-15791
HHH-15791 Avoid excessive Session casts to EventSource

https://github.com/hibernate/hibernate-orm/pull/5663
2022-12-02 09:38:00 +00:00
Steve Ebersole 6035ab8e66 HHH-15393 - Improve write-paths to use mapping model 2022-12-01 21:40:04 -06:00
Steve Ebersole ee1788c3c3 HHH-15393 - Improve write-paths to use mapping model 2022-12-01 20:01:40 -06:00
Sanne Grinovero 33ce6a3d79 HHH-15790 Refactor casting strategies for HibernateProxy across the codebase 2022-12-01 21:31:55 +00:00
Sanne Grinovero afc35f6c62 HHH-15790 Refactor filter definition in ByteBuddyProxyHelper 2022-12-01 21:31:55 +00:00
Sanne Grinovero fbf469830c HHH-15790 Make HibernateProxy also type-cache friendly 2022-12-01 21:31:55 +00:00
Sanne Grinovero 366a1e9c1d HHH-15790 Apply the new type-cache enhancements to CompositeTracker and CompositeOwner 2022-12-01 21:31:55 +00:00
Sanne Grinovero 3028299b4a HHH-15790 New dispatch approach to manage type checks of enhanced entities 2022-12-01 21:31:55 +00:00
Gavin c595347803 unify timestamp generation in one generator instead of three
shows a nice feature of the constructor-based init
2022-12-01 15:36:05 +01:00
Marco Belladelli be9358e02f HHH-15785 Fix javadoc errors 2022-12-01 14:51:28 +01:00
Andrea Boriero 56eb241dec Fix Oracle OptionalSecondaryTableBatchTest#testManaged failing test 2022-12-01 14:49:22 +01:00
Gavin 4aadbe801c deprecate unused class org.hibernate.mapping.IdGenerator 2022-12-01 13:40:40 +01:00
Gavin 99cbd9a24a minor fix to test 2022-12-01 13:40:40 +01:00
Gavin a8aab7f5f2 HHH-15789 change IdentifierGeneratorFactory to be able to produce plain InMemoryGenerators
this change is sort-of breaky, so I'm not sure about it

cleanups to StandardIdentifierGeneratorFactory

squash
2022-12-01 13:40:40 +01:00
Gavin cced19c7ee HHH-15789 better validation of generators 2022-12-01 13:40:40 +01:00
Gavin 101bee7647 minor cleanups + add a couple of @Deprecated annotations 2022-12-01 13:40:40 +01:00
Andrea Boriero 3396c18178 HHH-15393 Fix compilation error 2022-12-01 10:15:08 +01:00
Steve Ebersole 631d0bad71 HHH-15393 - Improve write-paths to use mapping model 2022-11-30 23:50:39 -06:00
Gavin 26e7393775 HHH-15789 allow any InMemoryGenerator to generate ids 2022-12-01 00:02:18 +01:00
Gavin 7f72696fff HHH-15788 deprecate GenerationTime since it is a dupe of GenerationTiming
...and it was not even being consistently used in its own package!

(@CurrentTimestamp was already using GenerationTiming.)

What a mess.
2022-12-01 00:02:18 +01:00
Gavin 2b50997e71 rename to AnnotationBasedGenerator 2022-12-01 00:02:18 +01:00
Gavin a67cfd039e HHH-15789 unify IdentifierGenerator with value generator stuff 2022-12-01 00:02:18 +01:00
Gavin 1bd082bd3e much better naming 2022-12-01 00:02:18 +01:00
Gavin 82c68d93e9 HHH-15789 make IdentifierGenerator into a sort of value generator 2022-12-01 00:02:18 +01:00
Steve Ebersole 1c083a5863 HHH-15393 - Improve write-paths to use mapping model 2022-11-30 15:36:28 -06:00
Steve Ebersole c04caa18de HHH-15393 - Improve write-paths to use mapping model 2022-11-30 12:59:31 -06:00
Steve Ebersole 175fe0e44d HHH-15393 - Improve write-paths to use mapping model 2022-11-30 09:01:37 -06:00
Marco Belladelli 3abc8c940a HHH-14982 Fix SQL Errors, add javadoc and extend spatial criteria tests 2022-11-30 10:42:03 +01:00
Marco Belladelli 3b14107c49 HHH-14982 CriteriaBuilder extension mechanism and Spatial implementation 2022-11-30 10:42:03 +01:00
Gavin f022d6ef3b HHH-15782 make @ValueGenerationType work with the new "split" hierarchy of value generators
this was a lot easier than I thought it would be
2022-11-30 02:05:38 +01:00
Gavin 82db252422 HHH-15781 deprecate @GenericGenerator(strategy) in favor of @GenericGenerator(type) 2022-11-30 02:05:38 +01:00
Gavin f03a43053d javadoc for @IdGeneratorType and @ValueGenerationType 2022-11-30 02:05:38 +01:00
Gavin 8ce2241153 HHH-15781 make @GenericGenerator typesafe by adding type() member
this annotation is not deprecated, so we should at least make it typesafe
2022-11-30 02:05:38 +01:00
Gavin 3bab26739d javadoc for @GeneratorType and @GenericGenerator 2022-11-30 02:05:38 +01:00
Steve Ebersole 815c4eb4a1 HHH-15393 - Improve write-paths to use mapping model 2022-11-29 16:01:16 -06:00
Gavin 3e6fcdeda3 unify new ValueGenerationStrategy interfaces with existing ValueGeneration stuff
- introduce ValueGenerationStrategy to abstract over IMVGS and IDVGS
- make ValueGeneration a mixin of IMVGS with IDVGS
- make IDVGS accept a Dialect for SQL fragment generation
  (it was based on an obsolete version of ValueGeneration)
- adapt all the code which only handled single-column value generation
  to handle multiple columns, as introduced by IDVGS

Still to do: the whole AnnotationValueGeneration stuff still requires the use
of the mixin interface, and you can't use IMVGS or IDVGS directly. That bit is
going to require a bit more thinking about backward compatibility.
2022-11-29 21:03:58 +01:00
Steve Ebersole 94e2b599e4 HHH-15393 - Improve write-paths to use mapping model 2022-11-29 12:40:54 -06:00