Commit Graph

6021 Commits

Author SHA1 Message Date
Christian Beikov 12f1c7917e HHH-14475 Don't render subquery for collection functions 2021-04-22 12:19:45 +02:00
Burkhard Graves 96980606fd HHH-14475 - select indices from ternary relation is broken since 5.4.13 (at least in mariadb) 2021-04-22 12:19:45 +02:00
Gavin King 179327cd40 [HHH-14031] on H2 1.4.200 and above use localtime/localtimestamp
As suggested by @famod we need to use localtime instead
or current_time because of changes in H2.

In particular the JDBC driver now refuses to convert
TIME/TIMESTAMP WITH TIME ZONE to plain TIME/TIMESTAMP.
2021-04-22 12:18:36 +02:00
Yoann Rodière 8389b1a7a2 HHH-14567 Do not reuse query plans after session filters changed 2021-04-19 17:58:57 +02:00
Yoann Rodière 3bac846de2 HHH-14567 Test enabling filters after query creation but before query execution 2021-04-19 17:58:57 +02:00
Yoann Rodière 4264bc55ac HHH-14563 Remove the DOM4J dependency from hibernate-core 2021-04-19 15:39:35 +02:00
Yoann Rodière 87a3e0a5d8 HHH-14563 Remove a few obsolete references to DOM4J entity-mode
This mode was removed literally a decade ago.
2021-04-19 15:39:35 +02:00
Yoann Rodière b076216e84 HHH-14563 Remove XmlMappingOptions
We don't need that anymore: XML mapping is either enabled or disabled,
there are no other options. So a boolean will do.
2021-04-19 15:39:35 +02:00
Yoann Rodière 6f5f6b32c3 HHH-14563 Remove DOM4J-based XML mapping
Use JAXB-based XML mapping everywhere.
2021-04-19 15:39:35 +02:00
Yoann Rodière 194e53a0fb HHH-14563 Remove legacy tests for DOM4J-based XML mapping 2021-04-19 15:39:35 +02:00
Yoann Rodière 4f7bb75ec7 HHH-14529 Fix access type being ignored when defined at the entity level in orm.xml
That's a bug I introduced when I migrated code from dom4j to jaxb.
2021-04-19 15:39:35 +02:00
Yoann Rodière 5b830f3f5e HHH-14529 Fix invalid order of elements in orm.xml files used for tests
Surprisingly, the XSD does mandate a specific order for some elements,
including "entity", "embeddable" and the children of "attributes".

It turns out we were allowing a wrong order with the dom4j
implementation, but we no longer do with the jaxb implementation.
2021-04-19 15:39:35 +02:00
Yoann Rodière 6723ed4626 HHH-14529 Fix incorrect attribute name for @NamedEntityGraph in JPAXMLOverriddenAnnotationReader 2021-04-19 15:39:35 +02:00
Andrea Boriero 6f75d96a99 HHH-14549 Collection with default field initializer will always be empty 2021-04-19 14:14:48 +02:00
Andrea Boriero 7620e0e395 HHH-14549 Add test for issue 2021-04-19 14:14:48 +02:00
Yoann Rodière ac4f4ff4ad HHH-14529 Implement the (opt-in) orm.xml handling using JAXB 2021-04-15 14:01:28 +02:00
Yoann Rodière 10aee2a9fa HHH-14529 Add a common interface for Jaxb representations of associations 2021-04-15 14:01:28 +02:00
Yoann Rodière 437af3b4da HHH-14529 Add a common interface for JaxbEntity, JaxbMappedSuperclass and JaxbEntityListener 2021-04-15 14:01:28 +02:00
Yoann Rodière b4dd2e272f HHH-14529 Add a few missing methods to the JAXB representation of ManagedType 2021-04-15 14:01:28 +02:00
Yoann Rodière efe5424d35 HHH-14529 Add a few missing enum mappings for orm.xml 2021-04-15 14:01:28 +02:00
Yoann Rodière bbc25cf28b HHH-14529 Add common interface for JaxbEntity and JaxbMappedSuperclass 2021-04-15 14:01:28 +02:00
Yoann Rodière 8ab3a2f7e9 HHH-14529 Configuration and wiring to prefer JAXB over DOM4J for orm.xml handling 2021-04-15 14:01:28 +02:00
Yoann Rodière e8cd9f8917 HHH-14529 Clean up constructors in JPAXMLOverriddenMetadataProvider and related 2021-04-15 14:01:28 +02:00
Yoann Rodière ef6bb2679b HHH-14529 Remove an unused orm.xml file from tests 2021-04-15 14:01:28 +02:00
Yoann Rodière 7291036680 HHH-14529 Copy orm.xml handling code to prepare for the new JAXB-based implementation
We will adapt the code in a later commit; I'm only doing the copy in
this commit in order to keep the review manageable.
2021-04-15 14:01:28 +02:00
Yoann Rodière 55ef4d47f2 HHH-14529 Remove commented-out code related to mapping parsing using dom4j 2021-04-15 14:01:28 +02:00
Yoann Rodière f92275f6c2 HHH-14529 Clarify that most fields are final in JPAOverriddenAnnotationReader 2021-04-15 14:01:28 +02:00
Yoann Rodière 2907c95cbd HHH-14529 Introduce JAXB bindings for JPA's orm.xml
Adapted from Steve's work on the unified JPA/ORM XML mapping. See:
4ff3795e60 (diff-b407928c3aa7ee1f231e0119ff70345caa5f6a83ed6348128c5159afbe3c6df2)
https://github.com/sebersole/hibernate-orm/compare/jandex-binding

Co-authored-by: Steve Ebersole <steve@hibernate.org>
2021-04-15 14:01:28 +02:00
Yoann Rodière 252fb65f95 HHH-14529 Remove an unused xjb file 2021-04-15 14:01:28 +02:00
Yoann Rodière 18f23ee701 HHH-14529 Fix invalid namespace URIs in MappingXsdSupport
Probably copy/pasted from ConfigXsdSupport, and we forgot to add the
"/orm" suffix.
2021-04-15 14:01:28 +02:00
Yoann Rodière fcc63d9ab0 HHH-14529 Stop using two separate BootstrapServiceRegistries for the same SessionFactory in BaseCoreFunctionalTestCase 2021-04-15 14:01:28 +02:00
Yoann Rodière ebb30aa178 HHH-14530 Allow adding pre-parsed XML mappings to MetadataSources
Signed-off-by: Yoann Rodière <yoann@hibernate.org>
2021-04-15 14:01:28 +02:00
Yoann Rodière 571af7bc9e HHH-14557 Test JDBC resources are released on each rollback 2021-04-14 14:15:07 +02:00
Yoann Rodière e03beca97f HHH-14557 Test JDBC resources are released on each commit
Not just on session closing.
2021-04-14 14:15:07 +02:00
Yoann Rodière 3825a671a7 HHH-14557 Always release JDBC connection and resources on rollback 2021-04-14 14:15:07 +02:00
Christian Beikov b166e684e1 Skip certain LockTests for Oracle on GH Actions which don't work there 2021-04-06 16:12:19 +02:00
Gail Badner ad84aaf0bc HHH-14537 : Updated test as requested; added tests that lazy associations with non-existing entity is unaffected. 2021-03-30 11:19:38 -07:00
Gail Badner 3c1e16e06c HHH-14537 EntityNotFoundException thrown when non-existing association with @NotFound(IGNORE) mapped has proxy in PersistenceContext 2021-03-30 11:19:38 -07:00
Gail Badner 9cb9137fb8 HHH-14537 : Added test for issue 2021-03-30 11:19:38 -07:00
Christian Beikov 2b06123635 Try dropping local tables in same connection 2021-03-25 09:20:39 +01:00
Guillaume Smet 2c1aedd176 HHH-12867 Add test case 2021-03-24 09:40:11 +01:00
Steve Ebersole 725faa258f HHH-14509 : Git master -> main branch renaming 2021-03-19 10:59:03 -05:00
Gautham Kumar b4bf58188c HHH-14449 : ResultStream closing is not properly handled 2021-03-18 07:22:42 -05:00
Sanne Grinovero 2c39bc0ac6 HHH-14502 Iterations and memory retention improvements for processing of PropertyContainer metadata 2021-03-15 17:13:27 +00:00
Andrea Boriero 9f22dafe17 HHH-14499 Explicitly listing mapped classes which are @MappedSuperClass might break narrowing down of generics 2021-03-15 16:44:21 +00:00
Andrea Boriero 394d6ab2d4 HHH-14499 Add test for issue 2021-03-15 16:44:21 +00:00
randymay 44d78d9b85 HHH-12076 Fix index out of bounds exception and allow table group joins for collection joins as well 2021-03-12 14:53:13 +01:00
Christian Beikov 52684bba26 Fix concurrency issue in QueryCacheTest 2021-03-12 08:06:33 +01:00
Christian Beikov d1445efd82 HHH-9663 Implement support for orphan removal of assocations within embeddables 2021-03-12 08:06:33 +01:00
Jaanus Hansen 8101e3e47d HHH-9663 added failing test case for Embeddable orphanRemoval 2021-03-12 08:06:33 +01:00
Steve Ebersole 9952c09843 HHH-14491 - Apply default allocation/increment size for @GeneratedValue(AUTO)
HHH-14492 - Prefer sequence-per-entity (hierarchy) for @GeneratedValue(AUTO) by default

- added test as @FailureExpected to track this into 6.0
2021-03-10 16:23:42 -06:00
Christian Beikov a514460bb9 HHH-9182 Cleanup grammar ambiguity issues 2021-03-05 15:20:03 +01:00
Yoann Rodière fb079d077c HHH-14439 Test executing the same query with subselects a second time with different list parameters
Signed-off-by: Yoann Rodière <yoann@hibernate.org>
2021-03-04 08:35:23 +01:00
Yoann Rodière 81071a4594 HHH-14439 Clean up expanded list parameters before re-executing a query
Signed-off-by: Yoann Rodière <yoann@hibernate.org>
2021-03-04 08:35:23 +01:00
Vlad Mihalcea ed3bbf15e4 HHH-13077 - Optimize query plan call count 2021-03-03 08:07:53 -06:00
johnniang 2d5d6061c5 HHH-14473 add test case 2021-03-03 11:06:13 +00:00
johnniang f03dd44107 HHH-14473 Resolve managed class name with class loader as well 2021-03-03 11:06:13 +00:00
Sanne Grinovero f7c85fad4a HHH-14477 Log warnings about the use of Javassist as BytecodeProvider being deprecated 2021-03-03 10:57:35 +00:00
Christian Beikov 44f4f93a29 HHH-9182 Test and fix HQL rules to allow more expression types in aggregate functions 2021-03-03 08:34:12 +01:00
Gail Badner 34a361058d HHH-14390 HHH-14466 : StackOverflowError loading inverse side of associations owned by associated entity ID
Improved code comments as recommended by Steve Ebersole.
2021-03-02 14:13:48 -08:00
Gail Badner cb18fdb4f7 HHH-14390 : StackOverflowError with @Fetch(FetchMode.SELECT) mapped for entity with an ID that is a bidirectional one-to-one eager association
Move fix into FetchStyleLoadPlanBuildingAssociationVisitationStrategy
2021-03-02 14:13:47 -08:00
Gail Badner 2bacaabc37 HHH-14466 : StackOverflowError loading an entity with eager one-to-many if bidirectional and many-to-one side is the ID 2021-03-02 14:13:47 -08:00
Christian Beikov 59735d2329 HHH-14471 Fix concurrency issue due to builder sharing in DynamicBatchingEntityLoader 2021-03-02 18:11:47 +01:00
Christian Beikov 1714c022e2 HHH-11076 Log a warning if uninitialized collection unsets session when filters are enabled 2021-03-02 17:28:13 +01:00
Sanne Grinovero eb639a2d95 HHH-14474 Method AbstractEntityPersister#getAppropriateUniqueKeyLoader also need to change in protected 2021-03-02 13:25:59 +00:00
Sanne Grinovero 17bffb08a5 HHH-14474 Style and formatting improvements 2021-03-02 10:26:58 +00:00
Gavin King 4fad616d4b HHH-14474 Refactor internal visibility to allow Hibernate Reactive to implement non-primary key associations
see https://github.com/hibernate/hibernate-reactive/issues/565
2021-03-02 10:26:47 +00:00
Sanne Grinovero 6868c68278 HHH-14443 Formatting and style fixes 2021-03-01 16:13:02 +00:00
Francois van Delft de3f3c1d74 HHH-14443 Add hashcode to ObjectTypeCacheEntry, so query cache can do a successfull lookup for queryies with AnyTypes 2021-03-01 16:05:38 +00:00
gbadner a90aaa48b4 HHH-14467 Avoid false positives when detecting *ToOne associations that are part of the identifier
Co-authored-by: Yoann Rodière <yoann@hibernate.org>
2021-03-01 08:37:14 +01:00
Gail Badner 021b2741ab HHH-14467 Simplify detection of *ToOne associations that are part of the entity identifier 2021-03-01 08:37:14 +01:00
Yoann Rodière b6b83536e6 HHH-14467 Test referencing an entity whose ID is derived
Signed-off-by: Yoann Rodière <yoann@hibernate.org>
2021-03-01 08:37:14 +01:00
Yoann Rodière 9b991310b5 HHH-14467 Fix relative ordering of second pass for associations and derived IDs
Always execute second pass for associations referencing an entity with
derived ID after the second pass for that entity's derived ID.

Signed-off-by: Yoann Rodière <yoann@hibernate.org>
2021-03-01 08:37:14 +01:00
Gavin King 496e5995b2 deprecate old code for fetching id by natural id 2021-02-24 07:59:57 -06:00
Gavin King 3a24c700fc cache the @NaturalId loaders
and clean up some of the other loader caching code
2021-02-24 07:59:57 -06:00
Gavin King e0ee9f5b0a make it easy for Hibernate Reactive to reuse the @NaturalId stuff 2021-02-24 07:59:57 -06:00
Gavin King e368ac5bab more efficient loading by multiple @NaturalIds 2021-02-24 07:59:57 -06:00
Gavin King 725083b767 more efficient loading by @NaturalId
For entities with a single @NaturalId property only.
Uses a unique key EntityLoader instead of two selects.
2021-02-24 07:59:57 -06:00
Gavin King e38df7ed59 HHH-14464 Expose useful things to enable cleanup of HR code
- expose useful static-y methods in AbstractEntityPersister
- add methods to OptimisticLockStyle to reduce verbosity
- add a useful method to ValueGeneration
2021-02-23 13:36:42 +00:00
Gavin King 578edbfd9f HHH-14464 Make two methods of AbstractEntityPersister protected
for the benefit of Hibernate Reeactive
2021-02-23 13:36:32 +00:00
Steve Ebersole db54fe44db HHH-13658 : Make LazyToOne optional
HHH-13134 : JOIN FETCH does not work properly with enhanced entities
2021-02-22 12:50:44 -06:00
Christian Beikov 91a68c6746 HHH-14460 Validate setter exists for persistent property also with mixed access strategy 2021-02-17 14:06:13 +01:00
Gail Badner 7e2747516a HHH-14389 : Add test case that throw IllegalArgumentException using EntityManager#find by ID when ID is a one-to-one association 2021-02-11 16:04:41 -08:00
Gail Badner 8a01b4dab4 HHH-14390 : StackOverflowError with @Fetch(FetchMode.SELECT) mapped for entity with an ID that is a bidirectional one-to-one eager association 2021-02-11 10:04:54 -08:00
Steve Ebersole 611796c0fc HHH-14450 - Drop ability to disable "enhanced proxies" 2021-02-10 13:11:35 -06:00
Christian Beikov 15caff9cbc Fix PostgreSQL cleanup wrt extensions, fix Oracle cleanup wrt sys objects, always drop id tables in tests, fix global temp table tests, add on commit delete rows for hana dialects 2021-02-10 09:30:48 +01:00
Sanne Grinovero 2eaa0f8c67 HHH-14447 Remove unneccessary type check 2021-02-09 13:35:44 +01:00
Sanne Grinovero 81a9b87ec1 HHH-14447 Add missing EventGroupListeners into FastSessionService and take advantage of them 2021-02-09 13:00:45 +01:00
Yoann Rodière 14e181806f HHH-14444 Encapsulate ID generation in GenerationState for PooledLoThreadLocalOptimizer
This is just a cosmetic change, it doesn't change the behavior at all.

Signed-off-by: Yoann Rodière <yoann@hibernate.org>
2021-02-09 09:17:44 +00:00
Yoann Rodière 511dda7dee HHH-14444 Avoid synchronization for multi-tenant generation in PooledLoThreadLocalOptimizer
Signed-off-by: Yoann Rodière <yoann@hibernate.org>
2021-02-09 09:17:44 +00:00
Yoann Rodière 5c155f3f8d HHH-14444 Avoid synchronization for single-tenant generation in PooledLoThreadLocalOptimizer
Signed-off-by: Yoann Rodière <yoann@hibernate.org>
2021-02-09 09:17:44 +00:00
Yoann Rodière 04a40f8397 HHH-14444 Test concurrent usage of ID generator optimizers
Signed-off-by: Yoann Rodière <yoann@hibernate.org>
2021-02-09 09:17:44 +00:00
Andrea Boriero a094e17d2a HHH-14445 Javassist skip EntityWithMutableAttributesTest, LoadAndUpdateEntitiesWithCollectionsTest, SimpleDynamicUpdateTest, SimpleDynamicUpdateTest 2021-02-08 16:26:09 +01:00
Andrea Boriero cfc7b97250 HHH-14424 When enhanced as a proxy is enabled with dirty checking, on flush uninitialized entities containing collections are updated and all the fields are set to null 2021-02-04 14:09:25 +01:00
Andrea Boriero 26a46b2010 HHH-14424 Add test for issue 2021-02-04 14:09:25 +01:00
Nathan Xu 2cf9ec856c HHH-14384 Fix QueryProducer.createNativeQuery documentation 2021-02-04 11:16:26 +01:00
Gavin King d5b0c167c8 on H2 after 2.0 don't need column type workaround
Apparently H2 correctly reports column types via JDBC metadata
since 2.0, so this workaround is unnecessary.

Also add a default mapping for DECIMAL in superclass, just for
completeness.

cc @famod
2021-02-04 10:34:18 +01:00
Christian Beikov b3ab4c2299 Fix newly added tests for derby 2021-02-03 17:03:47 +01:00
Christian Beikov 1983123d72 Use a shared connection provider for most tests to reduce test time significantly 2021-02-03 17:03:47 +01:00
Christian Beikov 709ac039d1 Drop TypeConfigurationRegistry which was leaking session factories that had a bootstrap error
As far as I can tell, the purpose of TypeConfigurationRegistry was only for serialization, but since the TypeConfiguration UUID is always random, this won't work anyway.
2021-02-03 17:03:47 +01:00
Christian Beikov ffe45ccdd6 Register transaction coordinator as observer when session is waiting for auto close but coordinator is not shared 2021-02-03 17:03:47 +01:00
Christian Beikov 9f460e1c30 HHH-14432 Implement cleanup for EntityManagerFactoryBuilderImpl to close connections on bootstrap errors 2021-02-03 17:03:47 +01:00
Christian Beikov 21c89240d0 HHH-14435 Improve table information extraction (especially for Oracle with enableSynonyms)
Previously Oracle with enableSynonyms ran into a timeout on CI because the JDBC driver issues a rather expensive query. The new implementation issues a dummy query and uses the result set metadata as suggested in various online articles about schema introspection
2021-02-03 17:03:47 +01:00
Christian Beikov a8cddb93e8 HHH-14434 Fix autocommit reset for connection used in DdlTransactionIsolatorNonJtaImpl 2021-02-03 17:03:47 +01:00
Christian Beikov 9135f69c91 HHH-14433 Add possibility to drop local temporary tables to enable connection pooling in tests 2021-02-03 17:03:47 +01:00
Christian Beikov d767d46d05 Fix most tests to work on all DBs and fix a bunch of connection leaks 2021-02-03 17:03:47 +01:00
Christian Beikov 5d9f6936ff HHH-14351 Fix order by type discriminator rendering issue 2021-02-03 17:02:59 +01:00
Christian Beikov d2036cb11a HHH-14351 Test showing that order by type discriminator desc fails 2021-02-03 17:02:59 +01:00
Christian Beikov 52785ce0ed HHH-14408 Defer property type access until integrators ran 2021-02-03 15:18:50 +01:00
Christian Beikov 6fcb83c90d HHH-14408 Test that user type provided by integrator is properly registered 2021-02-03 15:18:50 +01:00
Andrea Boriero d213d675ce HHH-13658 fix failing test on Oracle 2021-02-03 10:11:53 +01:00
Sanne Grinovero 22f858c68b HHH-14428 Could avoid allocating an org.hibernate.internal.SessionFactoryImpl when no options are set 2021-02-01 22:26:38 +00:00
Sanne Grinovero 15d418c332 HHH-14386 Fails to boot if provided CurrentTenantIdentifierResolver is unable to operate during bootstrap 2021-02-01 22:26:38 +00:00
Gail Badner 0e75b4f3b5 HHH-13944 : Added "join fetch" and one-to-many test cases 2021-02-01 14:05:10 -08:00
Andrea Boriero 20008b19bc HHH-13944 HQL/JPQL size() does not work (anymore) with nested expression 2021-02-01 14:05:10 -08:00
Andrea Boriero c99904a606 HHH-13944 Add test for issue 2021-02-01 14:05:10 -08:00
Alexander Iskuskov 19d46d2fed HHH-14421 Fix javadoc for Query.stream() method 2021-02-01 21:43:40 +00:00
Sanne Grinovero 5881b88173 HHH-14418 Revert to previous semantics: EventListenerGroup#clear() to also get rid of the default DuplicationStrategy 2021-01-28 22:20:33 +00:00
Sanne Grinovero 6fa09dd4db HHH-14418 Reduce memory retention of each EventListenerGroup 2021-01-26 10:02:27 +00:00
Yoann Rodière 4c9c2a809a HHH-14404 Remove check for concurrent execution of LogicalConnectionManagedImpl#releaseConnection
It's unlikely to ever happen, and even if it happened, the resulting
exception would probably be rather clear about the fact that the problem
is related to concurrent execution (ConcurrentModificationException
thrown by a Map of resources, for example).

See
https://github.com/hibernate/hibernate-orm/pull/3693#discussion_r560393293

Signed-off-by: Yoann Rodière <yoann@hibernate.org>
2021-01-20 09:26:51 +00:00
Yoann Rodière 8210bc220b HHH-14404 Test setting the connection handling mode through SessionBuilder
Signed-off-by: Yoann Rodière <yoann@hibernate.org>
2021-01-20 09:26:51 +00:00
Yoann Rodière d0b44c48ef HHH-14404 Take into account the connectionHandlingMode passed through SessionBuilder
Signed-off-by: Yoann Rodière <yoann@hibernate.org>
2021-01-20 09:26:51 +00:00
Yoann Rodière d726dcb394 HHH-14326 Test JDBC resources are released before closing the connection
Signed-off-by: Yoann Rodière <yoann@hibernate.org>
2021-01-20 09:26:51 +00:00
Yoann Rodière e5c830da19 HHH-14326 Always close the connection even if releasing JDBC resources fails
Signed-off-by: Yoann Rodière <yoann@hibernate.org>
2021-01-20 09:26:51 +00:00
Yoann Rodière 74433cdec3 HHH-14326 Release JDBC resources before closing the connection
Signed-off-by: Yoann Rodière <yoann@hibernate.org>
2021-01-20 09:26:51 +00:00
Nathan Xu 1e5d64cf79 HHH-14407 NPE in Column.getSqlTypeCode(Mapping mapping) for column 'hib_sess_id' when using PersistentTableBulkIdStrategy 2021-01-15 08:08:14 +01:00
Gail Badner 602926bf9b HHH-13658 : Remove @LazyToOne(NO_PROXY) from classes used with bytecode-proxies enabled. FetchGraphTest#testRandomAccess failed so it was marked @FailureExpected. 2021-01-13 16:13:54 -08:00
Steve Ebersole 0c974991f7 HHH-13658 : make NO_PROXY unnecessary
- Better handle `FetchModeType#LAZY` for to-one associations based on whether bytecode-enhancement-as-proxy is enabled.  Minimize the cases a user is likely to need to use `@LazyToOne`
- See also EAP7-1402
2021-01-13 12:03:44 -06:00
Yanming Zhou 633d0f08d6 HHH-14229 Fix unexpected foreign key creation
before this commit, foreign key is created even ConstraintMode.NO_CONSTRAINT present on the @ManyToOne side
2021-01-11 14:23:35 -08:00
Gail Badner b40d1251e3 HHH-14390 : Added test cases 2021-01-05 19:47:14 -08:00
Gail Badner 30fcb05795 HHH-14389 : Added test case. OneToOneWithDerivedIdentityTest#testFindById reproduces the bug and is annotated with @FailureExpected 2021-01-05 12:32:29 -08:00
Sanne Grinovero 016625eb5d HHH-14385 Allow specifying a target JVM version for compatibility of generated proxies via ByteBuddy 2020-12-22 18:01:27 +00:00
Christian Beikov 9c69ddc8f1 HHH-14380 - Only reorder destination from elements from the same from clause 2020-12-20 10:52:20 +01:00
Jan-Willem Gmelig Meyling 34bacba59e HHH-14380 Test case from https://github.com/Blazebit/blaze-persistence/pull/1237 for subquery in on-clause 2020-12-20 10:52:20 +01:00
jiangHZ cc14c785b9 HHH-13913 An SQL Dialect for PostgreSQL 10 and later. Adds support for Partition table. 2020-12-16 14:39:17 +01:00
Yanming Zhou c9ade2affe HHH-14356 Avoid NPE when booting with xml_mapping_enabled=false
Introduced by HHH-14334
when use Envers with hibernate.xml_mapping_enabled=false
see 34151a9660 (r44735539)
2020-12-14 16:26:12 +00:00
Yoann Rodière 6396cd17a2 HHH-14371 Open java.base/java.lang to the unnamed module in javassist tests
Signed-off-by: Yoann Rodière <yoann@hibernate.org>
2020-12-14 14:02:18 +00:00
Yoann Rodière 7f518cddb3 HHH-14371 Move tests specific to Javassist to the appropriate source set
Otherwise they won't be executed with the appropriate JVM args.

Signed-off-by: Yoann Rodière <yoann@hibernate.org>
2020-12-14 14:02:18 +00:00
Yoann Rodière 8e3bf43a18 HHH-14371 Open java.base/java.security and java/base/java.lang to the unnamed module in tests
Weld needs this, in CDI tests.

Signed-off-by: Yoann Rodière <yoann@hibernate.org>
2020-12-14 14:02:18 +00:00
Yoann Rodière 27c5980a20 HHH-14371 Open java.base/java.nio.charset to the unnamed module in tests
NamingHelper test needs access to Charset.defaultCharset.

Signed-off-by: Yoann Rodière <yoann@hibernate.org>
2020-12-14 14:02:18 +00:00
Yoann Rodière f6a9338f97 HHH-14371 Correctly set JVM args in the JVM running tests
Turns out getJvmArgs() returns a copy, so modifying that copy won't
change the JVM args.

Signed-off-by: Yoann Rodière <yoann@hibernate.org>
2020-12-14 14:02:18 +00:00
Andrea Boriero f468666b6d HHH-14360 Fix failure on Oracle db 2020-12-11 17:16:29 +01:00
Christian Beikov c915168cf1 HHH-14360 Test a fix for NPE due to non-existing previous state in bytecode enhanced dirty attribute resolving 2020-12-09 11:46:43 +01:00
Andrea Boriero dbec10aff1 HHH-14364 UpdateDetachedTest#testUpdateDetachedWithAttachedPersistentSet failing when run on OracleDB 2020-12-08 16:04:07 +01:00
Andrea Boriero bdc3a5cdc7 HHH-14363 MutableTypeEnhancementTestCase failing when run on Oracle DB 2020-12-08 15:45:37 +01:00
Andrea Boriero cf9d4ec3b3 HHH-14242 Fix issue for Dialects supporting row value constructor Syntax but not in the SET clause 2020-11-30 20:59:01 +00:00
Andrea Boriero e7bcc03ede HHH-14251 Fix issue for Dialects not supporting row value constructor Syntax 2020-11-30 20:58:50 +00:00
Andrea Boriero 9376650097 HHH-14251 Invalid SQL for @Embedded UPDATE 2020-11-30 20:58:44 +00:00
Andrea Boriero 900da12419 HHH-14251 Add test for issue 2020-11-30 20:58:37 +00:00
nicklas.wallgren 53a5c7fa97 HHH-14350 MariaDB103Dialect requires the lock wait timeout to be expressed in seconds 2020-11-30 20:38:39 +00:00
Michael Edgar 3de7fb653e HHH-14346 Check declaredPluralAttributes for null before access 2020-11-30 18:49:55 +00:00
Christian Beikov 8ded205b5f HHH-14343 Fix quoting of column names when globally quoted identifiers is active 2020-11-30 17:35:41 +00:00
info@kawoolutions.com 3434293a7e Test case for HHH-14343 2020-11-30 17:35:41 +00:00
Christian Beikov e2dbf52abe Restore collectionsInDefaultFetchGroupEnabled usage in LazyAttributesMetadata 2020-11-30 17:17:58 +00:00
Christian Beikov b08fbdaa6e HHH-14348 Special handling in bytecode enhancement for lazy PersistentCollection fields 2020-11-30 17:17:58 +00:00
Christian Beikov a975fbf5d4 HHH-14319 Create new collection rather than clearing original which is backing PersistentCollection entry of session 2020-11-23 13:23:02 +01:00
Christian Beikov 966d07c2d1 HHH-14319 Test case showing CollectionType.replaceElements wrongly clears backing collection 2020-11-23 13:23:02 +01:00
Yanming Zhou 97b67603ac HHH-14334 Make dom4j jaxb-api optional as possible
dependency dom4j and jaxb-api is optional if xml mapping disabled
continuation of HHH-13204
2020-11-20 16:17:26 +00:00
Christian Beikov 095eef2dcb HHH-14335 Remember the resolved type in SimpleValue#getType instead of resolving multiple times 2020-11-20 10:02:33 +00:00
Sanne Grinovero 93b8095ef6 HHH-14333 Pessimistic Lock causes FOR UPDATE on outer join statements 2020-11-17 20:08:29 +00:00
Sanne Grinovero 4aa7b84a86 HHH-14332 Make it easier for Quarkus SPI to avoid loading XML related resources 2020-11-17 18:01:02 +00:00
Sanne Grinovero 6b55f8ea09 HHH-14329 Amend existing DirtyTrackingTest 2020-11-17 16:11:29 +01:00
Christian Beikov e891a0296c HHH-14329 consider mutable types always as potentially dirty when using DirtinessTracker 2020-11-17 13:22:38 +01:00
Christian Beikov b15974732b HHH-14329 test case showing that DirtinessTracker usage for enhanced entities doesn't respect mutable types 2020-11-17 12:31:00 +01:00
Steve Ebersole be70d49df9 HHH-14325 - Add Query hint for specifying "query spaces" for native queries 2020-11-16 10:34:43 -06:00
Steve Ebersole 37a8d22155 HHH-14325 - Add Query hint for specifying "query spaces" for native queries 2020-11-16 10:32:00 -06:00
Sanne Grinovero f9cce5a767 HHH-14276 Amend style and formatting 2020-11-16 12:12:49 +00:00
Christian Beikov d1ee641e54 HHH-14276 Avoid quoting column name for looking up references during composite identifier second pass 2020-11-16 11:02:34 +00:00
info@kawoolutions.com 04ade27f07 HHH-14276 test case for strange AnnotationException: MapsId in IdClass context 2020-11-16 11:02:34 +00:00
Christian Beikov 8e8844d485 HHH-14322 Fix HBM many-to-one property ref support 2020-11-16 10:07:39 +00:00
Andrea Boriero 3d28893d9a HHH-14257 An Entity A with a map collection having as index an Embeddable with a an association to the Entity A fails with a NPE 2020-11-16 09:12:30 +00:00
Andrea Boriero 64aa8ae60a HHH-14257 Add test for issue 2020-11-16 09:12:30 +00:00
Andrea Boriero 59fede7aca HHH-14225 CVE-2020-25638 Potential for SQL injection on use_sql_comments logging enabled 2020-11-13 13:52:15 +00:00
Steve Ebersole b296459851 HHH-14312 - entity graph is ignored for 'padded' and 'dynamic' batch style entity loader
- Adjusted multi-loading to use LoadPlans (and apply entity-graphs) as well.
- All of the loaders/builder in `org.hibernate.loader.entity` are now no longer used, superseded by `org.hibernate.loader.entity.plan`.  Removed no longer needed code.
- Adjusted multi-load tests that relied on the actual generated SQL *String* - they now explicitly count the number of parameters and use that for assertions
2020-11-11 10:40:59 -06:00
Steve Ebersole 0b2fb4e28b HHH-14312 - entity graph is ignored for 'padded' and 'dynamic' batch style entity loader
- completed fix for HHH-11970
2020-11-11 07:55:41 -06:00
Steve Ebersole 13fb23d44e HHH-14312 - entity graph is ignored for 'padded' and 'dynamic' batch style entity loader 2020-11-10 16:16:33 -06:00
Nathan Xu c874618d30 HHH-14312 fix issue entity graph is ignored for 'padded' batch style entity loader 2020-11-10 16:16:33 -06:00
Andrea Boriero e67874e6ec HHH-13310 getParameterValue() not working for collections 2020-11-10 19:02:01 +00:00
Andrea Boriero 2d7aaa198b HHH-13310 Add test for issue 2020-11-10 19:02:01 +00:00
Yoann Rodière 85b84ef6bd HHH-14315 Force JVM options when using toolchains
Apparently Gradle won't just use the same options as in its own JVM.

Signed-off-by: Yoann Rodière <yoann@hibernate.org>
2020-11-10 11:02:08 +00:00
Yoann Rodière 9616e24c80 HHH-14315 Add optional support for toolchains to the Gradle build
Signed-off-by: Yoann Rodière <yoann@hibernate.org>
2020-11-10 11:02:08 +00:00
Christian Beikov 555299abf1 HHH-14214 Remove unnecessary rule for token type SQL_NODE 2020-11-10 11:43:11 +01:00
Guillaume Smet a393cbd7f5 HHH-14316 Avoid accessing state in DriverManagerConnectionProviderImpl if null 2020-11-09 15:15:06 +00:00
David Ellingsworth 1c6e2b4efb HHH-14216 Add new lines to the end of new files. 2020-11-04 09:25:20 -07:00
David Ellingsworth 24035d7f2c HHH-14216 Implement isDirty for OneToOneType and always check if it is dirty or not. 2020-11-04 09:25:20 -07:00
David Ellingsworth ef5c944c86 HHH-14216 Fix the assemble/disassemble methods of the OneToOneType. 2020-11-04 09:25:20 -07:00
David Ellingsworth aec21d21f8 HHH-14216 Add one-to-one second level cache tests. 2020-11-04 09:25:20 -07:00
Steve Ebersole f45a88cb07 Fixed Javadoc for `BulkOperationCleanupAction.affectedEntity`
- plus minor cleanups
2020-11-03 15:13:09 -06:00
Sanne Grinovero 67fd24ecff Make new EntityLoader buildling methods in AbstractEntityPersister protected for Hibernate Reactive 2020-11-01 23:24:22 +00:00
Sanne Grinovero e6ac4d4876 HHH-14305 Memory optimisations for ReaderCollector implementations 2020-11-01 22:05:57 +00:00
Sanne Grinovero da700f619b HHH-14305 Memory optimisations for EntityMetamodel 2020-11-01 22:05:49 +00:00
Sanne Grinovero 345b503f21 HHH-14305 Memory optimisations for NamedQueryRepository 2020-11-01 22:05:44 +00:00
Sanne Grinovero ad5bec0a54 HHH-14305 Memory optimisations for AbstractEntityPersister#uniqueKeyLoaders 2020-11-01 22:05:40 +00:00
Sanne Grinovero 9f54dae5d2 HHH-14305 Memory optimisation for AbstractPropertyMapping#duplicateIncompatiblePaths 2020-11-01 22:05:35 +00:00
Sanne Grinovero 35c58e9877 HHH-14305 Memory optimisations for AbstractManagedType#declaredPluralAttributes 2020-11-01 22:05:23 +00:00
Sanne Grinovero 2dde4c1710 HHH-14305 Memory optimisation for AbstractEntityPersister#affectingFetchProfileNames 2020-11-01 22:05:16 +00:00
Sanne Grinovero 169a01857c HHH-14305 Reduce memory consumption of AbstractEntityPersister#attributeDefinitions 2020-11-01 22:05:10 +00:00
Sanne Grinovero e9278288a7 HHH-14305 Reduce retained memory consumption of SingleTableEntityPersister 2020-11-01 22:05:03 +00:00
Sanne Grinovero 820fe56aa4 HHH-14305 Memory savings in SingleTableEntityPersister 2020-11-01 22:04:56 +00:00
Sanne Grinovero 0dedcd05db HHH-14305 Avoid referring to an empty ArrayList for AbstractEntityPersister#lobProperties 2020-11-01 22:04:50 +00:00
Sanne Grinovero fb34b720bc HHH-14305 Introduce new method in CollectionsHelper to reduce size of long lived collections 2020-11-01 22:04:47 +00:00
Sanne Grinovero 250db69e8e HHH-14305 Remove unused logger 2020-11-01 22:04:42 +00:00
Sanne Grinovero 81d526e4db HHH-14271 Lazy initialization of UniqueEntityLoader for most LockMode types 2020-11-01 19:31:49 +00:00
Sanne Grinovero c60765a528 HHH-14304 Replacing eager initialization of LockingStrategy within AbstractEntityPersister
And introducing a new ad-hoc collection LazyIndexedMap, useful to
lazily initialize elements which can be indexed by int, such
as the ordinal of enums.
2020-11-01 19:31:43 +00:00
Christian Beikov b24a3cbf2d HHH-14279 Fix join ordering issue that happens for entity key joins when using a WITH/ON clause 2020-10-29 10:26:58 +01:00
Laurent Almeras 4ffb768a7a HHH-14279 Testcase showing key join order is messed up 2020-10-29 10:26:58 +01:00
Sanne Grinovero 6b58d54057 HHH-14293 Reset the ReflectionManager state after SessionFactory is initialized 2020-10-28 16:54:06 +00:00
Sanne Grinovero f3396805d4 HHH-14293 JPAMetadataProvider needs to be able to reset its internal caches 2020-10-28 16:54:01 +00:00
Sanne Grinovero 67a2ed17ca HHH-14292 Avoid defensive copy for keywords set in NormalizingIdentifierHelperImpl 2020-10-28 15:51:49 +00:00
Steve Ebersole 18b3def741 HHH-14291 - Minor changes for NativeQuery and BulkOperationCleanupAction 2020-10-28 10:00:30 -05:00
Sanne Grinovero 503c48cbc7 HHH-14290 Remove capability of loading classes by name from HCANN 2020-10-27 07:13:02 +00:00
Sanne Grinovero a0e4ab72ec HHH-14290 Adjust HCANNHelper to benefit from HCANN-99 2020-10-27 06:34:19 +00:00
Sanne Grinovero abf42f4db0 HHH-14289 Detection of JDBC support for RefCursors was returning false even for Oracle JDBC drivers supporting it 2020-10-26 18:24:23 +00:00
Sanne Grinovero ad6584ff10 HHH-10715 Deleting more dead code 2020-10-25 21:33:30 +00:00
Sanne Grinovero 5b6f3ff3b8 HHH-10715 Remove unused logger instance 2020-10-25 21:33:28 +00:00
Sanne Grinovero e3edcdbe55 HHH-10715 More static and final keywords missing 2020-10-25 21:33:23 +00:00
Sanne Grinovero a7629c4382 HHH-10715 Missing null check after File.listFiles 2020-10-25 21:33:20 +00:00
Sanne Grinovero b518df7da4 HHH-10715 Unreleased statement in IdTableHelper 2020-10-25 21:33:18 +00:00
Sanne Grinovero 96209e0ff6 HHH-10715 A couple of missing final keywords 2020-10-25 21:33:15 +00:00
Sanne Grinovero b13a116a6e HHH-10715 Dead code eliminated 2020-10-25 21:33:13 +00:00
Sanne Grinovero 111e551dcd HHH-10715 Dead code elimination 2020-10-25 21:33:02 +00:00
Sanne Grinovero ba0bf0d619 HHH-10715 Make IdentifierProperty immutable 2020-10-25 21:32:56 +00:00
Sanne Grinovero 7870329b77 HHH-14282 StandardRefCursorSupport can rely on having JDK8 as baseline today 2020-10-25 21:31:17 +00:00
Sanne Grinovero 5091203426 HHH-14278 No longer use the AssertionFailure and StringHelper implementations from HCANN 2020-10-22 20:10:28 +01:00
Andrea Boriero fa5078a915 HHH-14245 ClassCastException for Criteria Collection size selection 2020-10-21 14:45:34 +01:00
Andrea Boriero 98168bd066 HHH-14245 Add test for issue 2020-10-21 14:41:04 +01:00
Scott Marlow dbd13e1389 HHH-14196 Add parsing of persistence.xml/orm.xml documents in the EE 9 namespace
Signed-off-by: Scott Marlow <smarlow@redhat.com>
2020-10-20 15:56:11 +01:00
Sanne Grinovero 97d101b742 HHH-14269 Confusing method names unableToObjectConnectionMetadata and unableToObjectConnectionToQueryMetadata 2020-10-20 12:40:25 +01:00
Daniel Wu d9ec18fad7 HHH-14268 Include stacktrace at WARN level in case of an error occurs when getting the connection metadata 2020-10-20 12:12:48 +01:00
Nathan Xu f17c0f7a03 HHH-14234 fix CI building error on non-H2 dialect 2020-10-19 16:17:37 +02:00
Nathan Xu f8fb0b0069 HHH-14234 fix CI building error on HANA dialect 2020-10-19 08:49:06 +02:00
Nathan Xu 5b8bae5cc7 HHH-14234 fix issue denormalized table should not inherit indexes from parent table 2020-10-18 16:29:08 +02:00
Nathan Xu 962884a8dd HHH-14264 fix bug that entity graph cannot be applied to child entity class 2020-10-18 11:53:16 +02:00
Yanming Zhou 88acc9511b HHH-14253 support ConstraintMode.PROVIDER_DEFAULT
Provide an option to skip foreign key creation for ConstraintMode.PROVIDER_DEFAULT
2020-10-14 09:20:17 +02:00
Jan Schatteman 8d4de09255 HHH-14241 Support ImplicitNamingStrategyComponentPathImpl with IdClass
Signed-off-by: Jan Schatteman <jschatte@redhat.com>
2020-10-09 13:24:17 +02:00
Fabio Massimo Ercoli 03416a8cdd HHH-14241 Test ImplicitNamingStrategyComponentPathImpl with IdClass 2020-10-09 13:24:17 +02:00
Nathan Xu 3a88b1c6b2 HHH-14248 Other minor improvements to ActionQueue 2020-10-08 08:19:49 +01:00
Nathan Xu c3e43ecd11 HHH-14248 Refactor latestBatches from InsertActionSorter's field to temporary variable in its sort method 2020-10-08 08:19:40 +01:00
Andrea Boriero 112d215371 HHH-14249 MultiLineImport fails when script contains blank spaces or tabs at the end of the last sql statement 2020-10-07 08:54:48 +01:00
Andrea Boriero 425ee2d3d5 HHH-14249 Add test for issue 2020-10-07 08:54:48 +01:00
Nathan Xu 05f47ce80b HHH-14227 fix testing failure on Oracle 2020-10-06 08:56:38 +01:00
Nathan Xu d045797aa7 HHH-14227 Add some more tests to cover order of batched insert executions 2020-10-05 13:40:08 +01:00
Nathan Xu 9de5e3e005 HHH-14227 Some additional typos and message improvements 2020-10-05 13:40:08 +01:00
Nathan Xu de6736ba32 HHH-14227 Insert statements are not ordered with entities that use inheritance and reference a subclass 2020-10-05 13:40:08 +01:00
Nathan Xu 733ece81f4 HHH-14231 Fix ClassCastException in ScrollableResultsImpl for primitive array value 2020-09-30 17:56:29 +01:00
Dmitry Gusev 77cf9d5108 HHH-14242 Micro optimisations of ActionQueue: redundant branch evaluation 2020-09-30 17:27:12 +01:00
Sanne Grinovero 71ef49d6b1 Revert "HHH-14240 Stop generating fragments of SQL as uppercase"
This reverts commit 9ac29ab4dc.

See also https://github.com/hibernate/hibernate-orm/pull/3555#issuecomment-701472270
2020-09-30 17:10:42 +01:00
Sanne Grinovero 225e29d2b2 HHH-14217 Minor optimisations in the highlighting formatter implementation 2020-09-30 16:58:29 +01:00
Sanne Grinovero 916513a7eb HHH-14217 Code style 2020-09-30 16:51:27 +01:00
Gavin King cf995a1571 HHH-14217 Add syntax highlighting to the logged SQL
Using ANSI escape codes

Must be explicitly enabled using hibernate.highlight_sql
2020-09-30 16:39:12 +01:00