18978 Commits

Author SHA1 Message Date
Yoann Rodière
abfe6b9b55 HHH-18833 Introduce EnhancementContext#getUnsupportedEnhancementStrategy
This method allows custom contexts to pick the behavior they want when
a class contains getters/setters that do not have a matching field,
making enhancement impossible.

Three behaviors are available:

* SKIP (the default), which will skip enhancement of such classes.
* FAIL, which will throw an exception upon encountering such classes.
* LEGACY, which will restore the pre-HHH-16572 behavior.

I do not think LEGACY is useful at the moment, but I wanted to have
that option in case it turns out HHH-16572 does more harm than good in
Quarkus 3.15.
2024-11-13 17:38:01 +01:00
Marco Belladelli
0ceada1a18 HHH-18647 Fix insert values check for table group joins 2024-11-12 16:23:02 +01:00
Marco Belladelli
d7da2bdd11 HHH-18647 Add test for issue 2024-11-12 16:23:02 +01:00
Marco Belladelli
4870f9cf17 HHH-18816 FK rendering: check parent query specs for group by / order by 2024-11-12 16:22:29 +01:00
Marco Belladelli
b9e47aac56 HHH-18816 Add test for issue 2024-11-12 16:22:29 +01:00
Christian Beikov
556285b735 HHH-18703 Use natural order table numbers for subclass column closure 2024-11-11 11:05:45 +01:00
Vincent Bouthinon
92cbbc5143 HHH-18703 : The JoinedSubclassEntityPersister#getTableNameForColumn method does not return the correct table in the JOINED inheritance strategy.
Cause: one uses a sorted set of tables, the other does not.
2024-11-11 11:05:45 +01:00
Hibernate-CI
e834b39e45 Post-steps for release : 6.6.2.Final 2024-11-07 17:59:42 +00:00
Hibernate-CI
2366b1066e Pre-steps for release : 6.6.2.Final 6.6.2 2024-11-07 17:52:12 +00:00
Scott Marlow
faebabd1f7 HHH-16572 - Skip enhancement for PROPERTY attributes with mismatched field and method names
Signed-off-by: Scott Marlow <smarlow@redhat.com>
2024-11-07 09:51:58 -07:00
Marco Belladelli
ab9e671761 HHH-18564 Handle attribute converters for query literals
Allow both domain and relational forms when an attribute converter is present
2024-11-05 16:59:45 +01:00
Marco Belladelli
6017ae4c69 HHH-18564 Add test for issue 2024-11-05 16:59:45 +01:00
Andrea Boriero
3c8214f365 HHH-18770 Check if the monitoring event was null 2024-11-05 15:20:17 +01:00
gtoison
f58d5af27a HHH-18770 Check if the monitoring event was null
When the JFR partial flush event is disabled (for instance when JFR is
entirely disabled) beginPartialFlushEvent() will return a null event.
2024-11-05 15:20:17 +01:00
gtoison
bdc44dbf4c HHH-18770 test with the jfr module on the classpath but jfr disabled 2024-11-05 15:20:17 +01:00
stringintech
6584eb3d53 HHH-18764 Fix incorrect type resolution in ManyToOneType dirty check 2024-10-29 13:19:01 +01:00
Yoann Rodière
5328e83e03 Fix upload of Devbelocity build scans
Forgot this line.

(cherry picked from commit a63716dab7e1fee56de86f61199ca3fa84c644ab)
2024-10-28 17:42:31 +01:00
Yoann Rodière
8e305582a7 Fix upload of Develocity build scans
Don't tar them, as this was broken: we ended up uploading the
build-scan-data directory instead of the tar, while still expecting a
tar when dowloading, which made everything fail.

We don't need tars anyway, as workflow artifacts are already zipped.

(cherry picked from commit 6551aa59c592b021c4ad3ebab31684d34311e5d7)
2024-10-28 17:42:31 +01:00
Yoann Rodière
97394283ab Do not include the whole Gradle cache in GH Actions caches
We don't need the whole cache, since most (all?) of it is stored on
Develocity already.

Including ./gradle/caches/modules-2 is enough, because that's where
Maven dependencies are stored, and *those* are not stored on Develocity.

(cherry picked from commit 013bb46470f97285ae57190c9ce5201f31105a21)
2024-10-28 17:42:31 +01:00
Yoann Rodière
bd209ce2fd Fix invalid arguments in GitHub Actions for download of build-scan-data artifacts
(cherry picked from commit 62fe772cc0d2c5b0590cd66eb1ce582ba1e5a9cd)
2024-10-28 17:42:31 +01:00
Yoann Rodière
059ae87d67 Improve build cache strategy
Ripped off from Quarkus.

Here's how it will work:

1. We create a cache entry on push only. Pull requests only restore it.
2. We create a new cache entry every day, prefixed with something like
   2024-10-25.
3. When restoring the cache, we try the entry for the day first
   (2024-10-25) and default to the one for the month (2024-10-*).
   Critically, this means we will build each day's cache based on the
   previous day's cache.
4. Atlas infra uses its own, separate cache entries.

Co-Authored-By: Guillaume Smet <guillaume.smet@gmail.com>
(cherry picked from commit 5eaaff2e6367fd4f1071a90eba2e274c800629cd)
2024-10-28 17:42:31 +01:00
Yoann Rodière
61bf908a1c Sanitize user home on GitHub Action job start on Atlas
(cherry picked from commit 4e8eb91562b75fbcc6ecdaaa3efe62b724f71aa4)
2024-10-28 17:42:31 +01:00
Christian Beikov
cf6ac4a67e Don't use the build cache during releases
So that we're extra sure we're not relying on cache left by a previous
Gradle execution.

(cherry picked from commit 543e095cf70396256ebbf2dd9e9d07f80304bebd)
2024-10-28 17:42:31 +01:00
Christian Beikov
12b0392fe2 Rework/simplify GH Actions jobs
* Use `pull_request` instead of `pull_request_target`
* Move Develocity build scan publishing for untrusted code to a separate workflow
* Merge Atlas workflow into the main CI workflow
* Split caches between trusted and untrusted code
* Update secrets to use "Develocity" name instead of "Gradle Enterprise"
* Update comments

Co-Authored-By: Yoann Rodière <yoann@hibernate.org>
(cherry picked from commit df8b16369f9d5bd890b889df02b0082960330b64)
2024-10-28 17:42:31 +01:00
Christian Beikov
3737d87d79 HHH-18773 Deduplicate result initializers to avoid double initialization issues 2024-10-28 13:09:13 +01:00
Christian Beikov
6d93f0eeaf Fix backwards compatibility issue with FunctionReturnTypeResolver 2024-10-26 16:03:12 +02:00
Marco Belladelli
89629bc702 HHH-18494 Always use standard table group in result builder entity
Also ignore placeholder aliases for to-one properties using join-tables, and use the target column name instead
2024-10-25 13:35:02 +02:00
Marco Belladelli
30b0c55e1d HHH-18494 Add test for issue 2024-10-25 13:35:02 +02:00
Gavin King
45ca8f24b0 fix broken code example
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-10-25 08:12:59 +02:00
Gavin King
c03076885c HHH-18761 fix generation of named query method in presence of Jakarta Data
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-10-24 16:20:13 +02:00
Gavin King
383d32e3e6 HHH-18761 add test
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-10-24 16:20:13 +02:00
Karel Maesen
eaca728d60 HHH-18755 - Skip test that causes deadlock
On CockroachDB the method
`testCopyPersistentCollectionReferenceAfterFlush` causes a
deadlock, which is resolved eventually by a TimeoutException.

This problem has been discussed in
https://github.com/cockroachdb/cockroach/issues/61269. The
CockroachDB developers do not see this as a bug that needs to
be fixed. Therefore we skip this test for CockroachDB.
2024-10-23 10:29:08 +02:00
Andrea Boriero
d94087e685 HHH-18719 Previous row state reuse can provide detaches entities to the consumer 2024-10-22 13:31:53 +02:00
Réda Housni Alaoui
77b36f984e HHH-18719 Previous row state reuse can provide detached entities to the consumer 2024-10-22 13:31:53 +02:00
Andrea Boriero
0843f7d3fb HHH-18720 Type check on select columns in union all gives SemanticException when there is a null column 2024-10-22 11:46:31 +02:00
Andrea Boriero
cdca0d34ea HHH-18720 Add test for issue 2024-10-22 11:46:31 +02:00
Andrea Boriero
145fe6ce7b HHH-18702 Exception using @EmbeddedId with @OneToMany that refers to an alternate key column 2024-10-21 18:38:42 +02:00
Andrea Boriero
a9290b27ec HHH-18702 Add test for issue 2024-10-21 18:38:42 +02:00
Andrea Boriero
cef03a3256 HHH-18713 saveOrUpdate changed behaviour with bytecode enhancer 2024-10-21 16:48:50 +02:00
Andrea Boriero
b26441aee8 HHH-18713 Add test for issue 2024-10-21 16:48:50 +02:00
Christian Beikov
2e3b9d5f16 Switch to Hibernate Commons Annotations 7.0.3.Final since 7.0.1.Final had not tag on SCM 2024-10-21 13:41:18 +02:00
Marco Belladelli
7aeb92244e Fix a couple failures on CockroachDB 2024-10-21 11:47:43 +02:00
Jan Schatteman
75885b9dd1 HHH-18739 - Fix for hints in queries containing joins
Signed-off-by: Jan Schatteman <jschatte@redhat.com>
2024-10-18 23:43:06 +02:00
Christian Beikov
db24cf11c5 HHH-18730 Multi-column association in aggregate component doesn't work 2024-10-18 12:57:18 +02:00
Christian Beikov
74501850cb Update to Jakarta Persistence TCK version 3.1.6 2024-10-17 18:24:11 +02:00
Andrea Boriero
ba88d7cf84 HHH-18289 with leads to HibernateException: A collection with cascade= was no longer referenced by the owning entity instance 2024-10-17 13:55:15 +02:00
Andrea Boriero
8eae372ab8 HHH-18389 Add test for issue 2024-10-17 13:55:15 +02:00
Andrea Boriero
4100ee04c3 HHH-18712 Warning about attempts to update an immutable entity for normal (not immutable) entity 2024-10-17 13:36:05 +02:00
Andrea Boriero
80bbea4283 HHH-18131 Composite identifiers with associations stopped working with @IdClass 2024-10-15 11:36:25 +02:00
Andrea Boriero
3aae473eca HHH-18131 Add test for issue 2024-10-15 11:36:25 +02:00