Commit Graph

13135 Commits

Author SHA1 Message Date
Konrad Kügler c7f8813b70 HHH-18689 Test FULL query cache sometimes incomplete 2024-10-28 13:12:49 +01:00
Christian Beikov e024bd0568 HHH-18773 Deduplicate result initializers to avoid double initialization issues 2024-10-28 13:09:10 +01:00
Gavin King b44833b7c9 HHH-18772 introduce AuthException and simplify SQLStateConversionDelegate
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-10-26 16:08:59 +02:00
Gavin King 55255e9d4a finish big refactor of AbstractMultiIdEntityLoader and children
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-10-26 16:08:59 +02:00
Gavin King ae538102f9 minor cleanup in Dialect
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-10-26 16:08:59 +02:00
Gavin King 9828ad7b33 document performance implications of id batching i.e. BatchSize
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-10-26 16:08:59 +02:00
Gavin King 10c83d8370 further cleanups on multi id loaders
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-10-26 16:08:59 +02:00
Gavin King 6c5f577223 partial refactoring of AbstractMultiIdEntityLoader and children
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-10-26 16:08:59 +02:00
Gavin King be895c722b HHH-18767 make MultiIdEntityLoaderArrayParam respect explicit BatchSize
keep ignoring the *implicit* upper limit from the Dialect

refactor a very long method which was extremely hard to understand

Signed-off-by: Gavin King <gavin@hibernate.org>
2024-10-26 16:08:59 +02:00
Gavin King 7f7c861f4b HHH-18767 add BatchSize for use with findMultiple()
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-10-26 16:08:59 +02:00
Jan Schatteman cb0d70309a HHH-17989 - Fix for StatisticsImplementor.closeStatement() never called
Signed-off-by: Jan Schatteman <jschatte@redhat.com>
2024-10-25 14:13:24 +02:00
Marco Belladelli ddf936286f HHH-18494 Always use standard table group in result builder entity
Also ignore placeholder aliases for to-one properties using join-tables, and use the target column name instead
2024-10-25 13:34:59 +02:00
Marco Belladelli 92103ff59c HHH-18494 Add test for issue 2024-10-25 13:34:59 +02:00
Čedomir Igaly bdc0070d97 HHH-18446 Added default SQL type code to LongVarbinaryJdbcType abd LongVarcharJdbcType 2024-10-24 08:57:11 +02:00
Čedomir Igaly b5b195740b HHH-18446 Test case 2024-10-24 08:57:11 +02:00
Christian Beikov 82b20a0e90 HHH-18731 Add generate_series() set-returning function 2024-10-23 18:29:20 +02:00
Steve Ebersole f9d36118ce HHH-18620 - Add @NativeGenerator 2024-10-23 06:44:23 -05:00
Karel Maesen 7bd50db8ad HHH-18755 - Skip test that causes deadlock
On CockroachDB the method
`testCopyPersistentCollectionReferenceAfterFlush` causes a
deadlock, which is resolved eventually by a TimeoutException.

This problem has been discussed in
https://github.com/cockroachdb/cockroach/issues/61269. The
CockroachDB developers do not see this as a bug that needs to
be fixed. Therefore we skip this test for CockroachDB.
2024-10-23 10:25:44 +02:00
Gavin King 76ab5d7d68 some cleanups and javadoc around SchemaManager
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-10-23 10:12:56 +02:00
Gavin King 37ce9bb31c HHH-18753 SessionFactory.createEntityManager() should return Session
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-10-23 08:32:14 +02:00
Gavin King 6c227ed304 Some javadoc about HibernatePersistenceConfiguration
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-10-23 00:31:24 +02:00
Steve Ebersole b1135b537c HHH-18728 - Allow mixed discriminator-value mappings for ANY 2024-10-22 14:57:40 -05:00
Gavin King f82c581990 HHH-18743 make batching explicit for StatelessSession
1. ignore hibernate.jdbc.batch_size setting
2. add insertMultiple() and friends

Signed-off-by: Gavin King <gavin@hibernate.org>
2024-10-22 21:21:49 +02:00
Steve Ebersole dd8e186416 HHH-18644 - New and improved hibernate-maven-plugin 2024-10-22 08:50:09 -05:00
Andrea Boriero 356b7f54bb HHH-18719 Previous row state reuse can provide detaches entities to the consumer 2024-10-22 13:31:58 +02:00
Réda Housni Alaoui 96c61c3837 HHH-18719 Previous row state reuse can provide detached entities to the consumer 2024-10-22 13:31:58 +02:00
Andrea Boriero f2856cf2ec HHH-18671 Fix setting name (spelling) 2024-10-22 12:08:12 +02:00
Andrea Boriero 58254e585c HHH-18720 Type check on select columns in union all gives SemanticException when there is a null column 2024-10-22 11:46:24 +02:00
Andrea Boriero 8e27a8d185 HHH-18720 Add test for issue 2024-10-22 11:46:24 +02:00
Gavin King 1b00f690ce remove two default impls that threw UnsupportedOperationException
added some links in Javadoc

Signed-off-by: Gavin King <gavin@hibernate.org>
2024-10-21 22:38:05 +02:00
Andrea Boriero 0f35a7d14c HHH-18702 Exception using @EmbeddedId with @OneToMany that refers to an alternate key column 2024-10-21 18:38:35 +02:00
Andrea Boriero 9894ed98fc HHH-18702 Add test for issue 2024-10-21 18:38:35 +02:00
Gavin King cc93ed7d62 HHH-18749 deprecate Session.get()
This method is essentially redundant as things stand today,
and I want to open up the possibility of changing its semantics
in the future.

Signed-off-by: Gavin King <gavin@hibernate.org>
2024-10-21 16:59:07 +02:00
Andrea Boriero cbca294770 HHH-18713 HHH-18614 Add test to show issue does not persist with merge 2024-10-21 16:48:15 +02:00
Marco Belladelli bf5c499f68 HHH-18690 Add internal test methods to SchemaTruncatorImpl 2024-10-21 15:13:41 +02:00
Marco Belladelli 810842ac74 HHH-18679 Allow `@Generated(writable=true)` with assigned identifiers 2024-10-21 15:03:21 +02:00
Marco Belladelli 7b81b4d5e5 HHH-18679 Add test for issue 2024-10-21 15:03:21 +02:00
Gavin King e868c8c3cd HHH-18748 Add missing overloads of find() to Session
It was always weird and inconsistent that you sometimes had to use get(),
and this is also better documented this way (i.e. Hibernate-specific
semantics of find() are not documented by EntityManager)

Also add some missing @Overload annotations

Also move some impl down off the interface

Signed-off-by: Gavin King <gavin@hibernate.org>
2024-10-21 11:43:09 +02:00
Gavin King 63d3d32f42 rename findAll -> findMultiple, getAll -> getMultiple 2024-10-20 20:53:19 +02:00
Gavin King 86db807e22 major cleanup to BaseSqmToSqlAstConverter
this class was full of EXTREMELY long methods and lots of typecasts

Signed-off-by: Gavin King <gavin@hibernate.org>
2024-10-20 17:56:43 +02:00
Gavin King 26efd4e530 squash some warnings by filling in <?>
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-10-20 15:00:09 +02:00
Gavin King 5db7629382 improve jdoc of SQM enums
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-10-20 15:00:09 +02:00
Gavin King ddca820f42 HHH-17068 move JoinType to common
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-10-20 15:00:09 +02:00
Gavin King 0393df8761 HHH-17068 move layer-breaking enums from o.h.q.sqm to o.h.q.common
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-10-20 15:00:09 +02:00
Gavin King 63c4f313ca HHH-17068 introduce JoinType to replace use of SqmJoinType in criteria API
fix the layer-breakage

Signed-off-by: Gavin King <gavin@hibernate.org>
2024-10-20 15:00:09 +02:00
Gavin King d5bf8016a8 HHH-18585 move AfterUseAction and BeforeUseAction to an SPI package
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-10-20 15:00:09 +02:00
Gavin King ed7ba223d1 very minor cleanups in Dialect
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-10-20 15:00:09 +02:00
Gavin King 0ba7aec32d modernize code in GraphSemantic and ExecuteUpdateResultCheckStyle 2024-10-19 00:01:03 +02:00
jeonjonghyeok 3d3561ff7e HHH-18739 Do not support join queries when using Mysql 2024-10-18 21:13:43 +02:00
Gavin King 67816c57e3 fix typo in SS jdoc 2024-10-18 21:01:28 +02:00
Jan Schatteman b1795a6f67 HHH-18740 - Deprecate org.hibernate.dialect.hint
Signed-off-by: Jan Schatteman <jschatte@redhat.com>
2024-10-18 19:43:04 +02:00
Gavin King 044d91411f slight improvements to error messages when driver class missing 2024-10-18 14:34:55 +02:00
Gavin King a9fb252e1d deprecate @FractionalSeconds 2024-10-18 13:08:34 +02:00
Christian Beikov 25ddb64a4c HHH-18661 Add unnest() set-returning function and enable XML/JSON based array support on more databases 2024-10-18 10:08:46 +02:00
Christian Beikov 9bb5e64521 HHH-18730 Multi-column association in aggregate component doesn't work 2024-10-18 10:08:46 +02:00
Steve Ebersole d647599fe9 HHH-18733 - Add a prepareMappingModel phase to collection persisters
Co-authored-by: Christian Beikov <christian.beikov@gmail.com>
2024-10-17 07:51:55 -05:00
Andrea Boriero 84cc5f013c HHH-18289 with leads to HibernateException: A collection with cascade= was no longer referenced by the owning entity instance 2024-10-17 13:55:05 +02:00
Andrea Boriero fab98341d3 HHH-18389 Add test for issue 2024-10-17 13:55:05 +02:00
Yanming Zhou 8b5bc445c8 HHH-15422 Pick up ConnectionProvider from BeanContainer if not explicit set 2024-10-17 10:06:30 +02:00
Yanming Zhou 7c315fdbfa HHH-15422 Pick up CurrentTenantIdentifierResolver and MultiTenantConnectionProvider from BeanContainer if not explicit set 2024-10-17 10:06:30 +02:00
Čedomir Igaly 8ca2481df1 HHH-18377 Removed masking that is not needed 2024-10-16 19:19:50 +02:00
Čedomir Igaly 3419f8f3ad HHH-18377 Renamed State record properties with addres 'last' prefix 2024-10-16 19:19:50 +02:00
Čedomir Igaly 6daec2e410 HHH-18377 Holding state in immutable object to allow atomic calculation and change 2024-10-16 19:19:50 +02:00
Čedomir Igaly 2e42db82dd HHH-18377 Simplified UUID v7 generation 2024-10-16 19:19:50 +02:00
Čedomir Igaly d8dd5e7c0d HHH-18377 Fixed bug with sequence resetting 2024-10-16 19:19:50 +02:00
Gavin King 69f8b9af2d HHH-18734 detect erroneous/unsupported use of @SQLRestriction on subclass entity 2024-10-15 23:55:33 +02:00
Andrea Boriero 6913234e0e HHH-18131 Composite identifiers with associations stopped working with @IdClass 2024-10-15 11:36:21 +02:00
Andrea Boriero 1e50105db6 HHH-18131 Add test for issue 2024-10-15 11:36:21 +02:00
Andrea Boriero 36bc892d62 HHH-18681 InterpretationException executing subquery in case-when : o.h.query.sqm.tree.select.SqmSelection.getExpressible() is null 2024-10-15 11:14:09 +02:00
Andrea Boriero 1fedc6e529 HHH-18681 Add test for issue 2024-10-15 11:14:09 +02:00
Gavin King 7afb5a0c50 minor cleanups in TypeSafeActivator 2024-10-12 17:38:24 +02:00
Luca Molteni e48573856e HHH-16861 documentation for HQL `ordinal()` function
Added `ordinal` to QueryLanguage.adoc
Added `ordinal` to Expressions.adoc

Update documentation/src/main/asciidoc/querylanguage/Expressions.adoc

Co-authored-by: Gavin King <gavin@hibernate.org>
2024-10-10 19:09:27 +02:00
Gavin King e9fbf23ec8 HHH-17249 record as a composite type embeddable results in a PropertyNotFoundException 2024-10-10 13:25:14 +02:00
Jan Schatteman bcac1e3299 HHH-18669 - resolve the driver name from the connection metadata, in case it wasn't explicitly set and access to the database metadata is allowed
Signed-off-by: Jan Schatteman <jschatte@redhat.com>
2024-10-09 13:37:19 +02:00
Gavin King 2e2d2948b0 squash some warnings in ReflectHelper + cleanups 2024-10-08 14:57:51 +02:00
Gavin King 9166d73f36 HHH-18704 optimize away equals() search for records + enums 2024-10-08 14:57:51 +02:00
Gavin King 72e0f2968a slight simplification in IncrementGenerator 2024-10-07 20:09:02 +02:00
Gavin King 6e38830cbe clean up lots of warnings in ConfigurationHelper
deprecate some unused methods
add a useful method
2024-10-07 20:09:02 +02:00
Gavin King c18b7c90fe eliminate dupe log message 2024-10-07 20:09:02 +02:00
Christian Beikov c92c2f5f21 HHH-16954 Change name of method parameterList to listParameter 2024-10-07 15:38:55 +02:00
Gavin King 072d3e257b miscellaneous code cleanups and refactoring 2024-10-04 22:05:24 +02:00
Marco Belladelli 3521857ef2 HHH-18450 Handle array result types for multi-valued parameters
Also fix an NPE in SqmSelectionQueryImpl#determineResultType
2024-10-04 16:37:56 +02:00
Marco Belladelli 7893d1066f HHH-18450 Add test for issue 2024-10-04 16:37:56 +02:00
Manuel Siggen 4a65c51326 HHH-18491 Do no try to resume non-existant transaction in doInSuspendedTransaction. 2024-10-04 12:25:35 +02:00
Christian Beikov 7b176df6b7 HHH-18604 Fix some issues with older database versions 2024-10-04 10:46:52 +02:00
Christian Beikov 5b602bdf94 HHH-18645 Handle proxies when resolving from existing entity in batch initializer 2024-10-04 10:29:41 +02:00
Gavin King aa6f88f1b4 move some logging in BatchImpl to typed methods
+ very minor code cleanups in BatchImpl & JdbcCoordinatorImpl
2024-10-04 09:51:52 +02:00
Jan Schatteman a0162f3ee5 HHH-13547 - remove logging of BatchImpl rethrown exceptions
Signed-off-by: Jan Schatteman <jschatte@redhat.com>
2024-10-03 16:43:37 +02:00
Gavin King fa4c43fc34 remove @Deprecated methods of CoreMessageLogger 2024-10-03 13:39:07 +02:00
Marco Belladelli 0c48c12f99 HHH-18321 Avoid search for table group when possible for paths 2024-10-03 10:58:24 +02:00
Marco Belladelli 5ca841c184 HHH-18321 Add test for issue 2024-10-03 10:58:24 +02:00
Christian Bürgi 26495fb600 HHH-18513 fix wrong prePartialFlush calculation in Session Metrics log 2024-10-03 10:48:49 +02:00
Réda Housni Alaoui 965c52390e HHH-18658 Inner join prevents finding an entity instance referencing an empty map 2024-10-02 16:26:15 +02:00
Leon Schenk 0a1a9f757d HHH-18675: Fix for Hibernate codestyle 2024-10-02 16:08:59 +02:00
Leon Schenk bc4804ab09 HHH-18675: Fix for testcase. If property is 'synthetic' then create no attribute for the jpa model. 2024-10-02 16:08:59 +02:00
Leon Schenk fcba4ed25d HHH-18675: Testcase added to Hibernate Project includes a reference testcase without generics. 2024-10-02 16:08:59 +02:00
Marco Belladelli 6ecc2a6c40 Fix a couple failures on CockroachDB 2024-10-02 15:32:14 +02:00
Steve Ebersole ee2d8a3765 HHH-18663 - Upgrade to hibernate-models 0.9.1 2024-10-01 10:54:10 +02:00
Gavin King df735cdebd remove some deprecated methods 2024-10-01 09:56:04 +02:00
Yanming Zhou c66b27d193 HHH-18674 Expose result count of NonUniqueResultException 2024-09-30 20:33:30 +02:00
Steve Ebersole 4f9035e9f8 HHH-18545 - Document "characteristics" of settings 2024-09-30 09:47:30 -05:00
Andrea Boriero d4ef44db00 HHH-18608 NPE in EntityInitializerImpl.resolveInstanceSubInitializers 2024-09-30 15:47:20 +02:00
Andrea Boriero 3d767a11db HHH-18608 Add test for issue 2024-09-30 15:47:20 +02:00
Philippe Marschall e7f5f886c7 HHH-18587 Implement Oracle array functions using set operations
https://hibernate.atlassian.net/browse/HHH-18587
2024-09-30 15:41:36 +02:00
Jan Schatteman 58ee919feb HHH-18643 - Remove support for SAP HANA versions older than 2.0 SPS 05, create a legacy HANA dialect in the community dialects module
Signed-off-by: Jan Schatteman <jschatte@redhat.com>
2024-09-30 14:08:49 +02:00
Luca Molteni f8e4e6e49f HHH-16861 HQL ordinal() function
The `ordinal` function returns the `ordinal` property of Java enums, for both enums mapped as ORDINAL and enums mapped as STRING generating different SQL in each case

`ordinal(field)` is equivalent to `cast(enum as Integer)`, implementation taken from CastStrEmulation when used on ordinal mapped enums.

Lexer and parser don't need to be changed as there is nakedIdentifier that matches custom function names

`ordinal` function is validated to work only on Java enum fields

Use convertToRelationalValue to generate enum value inside the SQL query

Co-authored-by: Christian Beikov <christian.beikov@gmail.com>
2024-09-30 10:57:24 +02:00
Marco Belladelli c5db0d38e7 HHH-18664 Consistent constructor matching logic for row-transformer 2024-09-30 10:04:35 +02:00
Marco Belladelli fc38d88930 HHH-18664 Add test for issue 2024-09-30 10:04:35 +02:00
Andrea Boriero fee9e86579 HHH-18457 Remove deprecated org.hibernate.Metamodel and org.hibernate.metamodel.spi.MetamodelImplementor 2024-09-26 17:33:46 +02:00
Andrea Boriero 5b25d09188 HHH-18409 byte[] instance variables annotated with @NaturalId cannot be found with a natural ID query 2024-09-26 16:51:44 +02:00
Andrea Boriero 71b3cb27d7 HHH-18409 Add test for issue 2024-09-26 16:51:44 +02:00
Andrea Boriero 34b479a719 HHH-18631 AssertionError when loading an entity after removing another, associated entity 2024-09-26 13:13:07 +02:00
Andrea Boriero dd9f79096f HHH-18631 Add test for issue 2024-09-26 13:13:07 +02:00
Marco Belladelli c9621aa9e2 HHH-18377 Fix NPE for private static final field 2024-09-24 17:01:23 +02:00
Marco Belladelli ebcbebac39 HHH-18642 Revert to Statement.RETURN_GENERATED_KEYS for identity only 2024-09-24 15:04:50 +02:00
Andrea Boriero 1adfaf30a5 HHH-18662 Attribute not mentioned in orm.xml ends up not being mapped in Hibernate ORM 7 2024-09-23 14:02:28 -05:00
Andrea Boriero 1327f002cd HHH-18662 Add test for issue 2024-09-23 14:02:28 -05:00
Steve Ebersole c3d7e5f0b5 HHH-18377 - Support for uuid v6 and v7 generated ids 2024-09-23 13:53:27 -05:00
Steve Ebersole 2f335cd786 HHH-18377 - Support for uuid v6 and v7 generated ids 2024-09-23 13:46:10 -05:00
Čedomir Igaly d1cb9c3679 HHH-18377 Test cases to check monofonicity of generated version 6 & version 7 UUID's 2024-09-23 13:31:07 -05:00
Čedomir Igaly 4e85302086 HHH-18377 UUID Version 6 & UUID Version 7 implementations 2024-09-23 13:31:06 -05:00
Steve Ebersole df405d37ab HHH-18620 - Add @NativeGenerator 2024-09-23 13:24:48 -05:00
Andrea Boriero fccbb8d582 HHH-18628 Regression: Unable to determine TableReference 2024-09-23 17:36:13 +02:00
Andrea Boriero a54d7ec804 HHH-18628 Add test for issue 2024-09-23 17:36:13 +02:00
Christian Beikov 450bca6265 HHH-18497 Add special xmlquery and xmlexists functions for DB2 10.5 2024-09-23 15:03:22 +02:00
Christian Beikov 3b07ed91c3 HHH-18497 Add xmlagg function 2024-09-23 15:03:22 +02:00
Christian Beikov af09813ced HHH-18497 Add xmlexists function 2024-09-23 15:03:22 +02:00
Christian Beikov 449d002563 HHH-18497 Add xmlquery function 2024-09-23 15:03:22 +02:00
Christian Beikov 574959a591 HHH-18497 Add xmlpi function 2024-09-23 15:03:22 +02:00
Christian Beikov a37ae66a2e HHH-18497 Add xmlconcat function 2024-09-23 15:03:22 +02:00
Christian Beikov 1abfd4eea6 HHH-18497 Add xmlforest function 2024-09-23 15:03:22 +02:00
Christian Beikov f10ec5db1d HHH-18497 Add xmlcomment function 2024-09-23 15:03:22 +02:00
Christian Beikov 4baba673cb HHH-18497 Add xmlelement function 2024-09-23 15:03:22 +02:00
Christian Beikov 7ff0567383 HHH-18497 Make reserved word identification for JPA compliance more robust 2024-09-23 15:03:22 +02:00
Vladimír Kuruc e2a1434017 Informix tests fixes 2024-09-23 14:40:55 +02:00
Philippe Marschall 7ffd991b80 HHH-18657 Use IF EXISTS in OracleUserDefinedTypeExporter 2024-09-23 14:34:12 +02:00
Marco Belladelli c2728308b5 HHH-18582 Throw explicit error when trying to map nested arrays 2024-09-23 11:16:03 +02:00
Marco Belladelli a21f4bf720 HHH-18582 Add test for issue 2024-09-23 11:16:03 +02:00
Gavin King 975dfa1ed9 disable test on Sybase 2024-09-23 08:42:28 +02:00
Gavin King ad33eb4f64 HHH-18649 test 2024-09-23 08:42:28 +02:00
Gavin King efc50aad00 squash warnings 2024-09-23 08:42:28 +02:00
Gavin King 600288d1bb HHH-18649 populate EntityGraph in static metamodel 2024-09-23 08:42:28 +02:00
Gavin King c863838e72 fix some warnings 2024-09-23 08:42:28 +02:00
Gavin King ec0f78d8c7 HHH-18649 populate TypedQueryReference in static metamodel
also rename two enums since "metamodel" is a word
2024-09-23 08:42:28 +02:00
Gavin King 67e7b895cc squash more warnings 2024-09-22 21:36:10 +02:00
Gavin King 73dba9304d remove redundant modifiers in DialectSpecificSettings 2024-09-21 11:13:38 +02:00
Jan Schatteman 3818b6d99f HHH-17971 - Remove ALLOW_REFRESH_DETACHED_ENTITY
Signed-off-by: Jan Schatteman <jschatte@redhat.com>
2024-09-20 23:59:32 +02:00
Andrea Boriero 052552f3f6 HHH-18515 Unrecognized discriminator value exception when running native query on entity with discriminator column 2024-09-20 13:09:59 +02:00
Andrea Boriero fbb1dd0c00 HHH-18515 Add test for issue 2024-09-20 13:09:59 +02:00
Andrea Boriero 8ebd5a79f5 HHH-18632 Concurrency issue with AbstractEntityPersister#nonLazyPropertyLoadPlansByName 2024-09-20 11:03:00 +02:00
Christian Beikov ec502138b1 HHH-18604 Fix some issues with old SQL Server versions 2024-09-20 09:12:59 +02:00
Marco Belladelli 791152d858 HHH-18617 Avoid reading unowned association key when filters are enabled 2024-09-20 08:46:42 +02:00
Marco Belladelli 4f9a42ba44 HHH-18617 Add test for issue 2024-09-20 08:46:42 +02:00
Marco Belladelli 0330d54795 HHH-18635 Avoid using `bigdatetime` on Sybase jconn when not necessary 2024-09-20 08:43:46 +02:00
Gavin King 1863fc75c4 remove rogue ; 2024-09-19 22:16:55 +02:00
Gavin King e7776049af more fallout from new Generator instantiation lifecycle 2024-09-19 22:16:55 +02:00
Gavin King 18aa8a7c70 don't cache the Generator in the SimpleValue
that way we don't need to re-call initialize()
on the cached instance

also handle canonicalization of generators via
RuntimeModelCreationContext instead of via
deprecated method or SessionFactoryImplementor
2024-09-19 22:16:55 +02:00
Gavin King 8ee09481b3 simplify Generator instantiation lifecycle
remove a bunch of unused parameters from methods in this package
2024-09-19 22:16:55 +02:00
Čedomir Igaly df16ea9694 HHH-18500 If superclass is null, class should not be enhanced, simply return empty collection 2024-09-19 18:58:35 +02:00
Christian Beikov 11d134ae38 HHH-18604 Fix some issues with older database versions 2024-09-19 15:11:37 +02:00
Christian Beikov ddadad2dac HHH-18596 Get rid of ValueHandlingMode hack in query pagination 2024-09-19 14:22:43 +02:00
Christian Beikov 0e5846b805 HHH-18604 Add json_array_insert 2024-09-18 18:43:07 +02:00
Christian Beikov 8dfc2a5a91 HHH-18604 Add json_array_append function 2024-09-18 18:43:07 +02:00
Christian Beikov 4a6c555cd0 HHH-18604 Spotless license header and EOL config 2024-09-18 18:43:07 +02:00
Christian Beikov ab37d1509b HHH-18604 Add json_mergepatch function 2024-09-18 18:43:07 +02:00
Christian Beikov 051bc78ae6 HHH-18604 Add json_insert and json_replace function 2024-09-18 18:43:07 +02:00
Christian Beikov 36066a03e6 HHH-18604 Add json_remove function and fix some Oracle functions 2024-09-18 18:43:07 +02:00
Christian Beikov 17f328609a HHH-18604 Add json_set function 2024-09-18 18:43:07 +02:00
Christian Beikov 7e11d7a809 HHH-18496 Fixup some CI issues 2024-09-18 18:43:07 +02:00
Christian Beikov f6ac53f83f HHH-18496 Hide JSON functions behind feature flag 2024-09-18 18:43:07 +02:00
Christian Beikov 59ae75bb52 HHH-18496 Add json_objectagg 2024-09-18 18:43:07 +02:00
Christian Beikov c58485c4ef HHH-18496 Add json_arrayagg 2024-09-18 18:43:07 +02:00
Christian Beikov 6b4cc28f0e HHH-18496 Add json_query 2024-09-18 18:43:07 +02:00
Christian Beikov 6454aaf055 HHH-18496 Add json_exists and support the passing clause 2024-09-18 18:43:07 +02:00
Christian Beikov 016b463973 HHH-18496 Add json_object and json_array functions 2024-09-18 18:43:07 +02:00
Christian Beikov d5a3f041b3 HHH-18496 Add json_value function 2024-09-18 18:43:07 +02:00
Christian Beikov ff57a6ced0 HHH-18447 Try using native cast for string to boolean 2024-09-18 18:42:10 +02:00
Piotr Wolny b179881847 HHH-18551 Fix memory leak caused by creation of new BasicTypeImpl 2024-09-18 18:36:31 +02:00
Christian Beikov cc72efd0fe HHH-18630 Upgrade H2 to 2.3.232 and H2GIS to 2.2.2 2024-09-18 15:53:35 +02:00
Steve Ebersole 9e89bdd85a Javadoc for GeneratorCreationContext 2024-09-18 08:17:43 -05:00
Marco Belladelli 384bdbc19c Exclude generated sources from spotless 2024-09-18 12:06:40 +02:00
Gavin King fc2b1b9854 HHH-18626 fix error for @Id annotation in @Embeddable class 2024-09-17 19:59:30 +02:00
Gavin King e9bf523ce1 clean up some obsolete code in AbstractEntityPersister 2024-09-17 18:41:41 +02:00
Gavin King 79c8b41298 remove two useless @FailureExpected tests
having failing tests for features we have never supported
isn't actually useful at all, and just slows us down
2024-09-17 08:43:23 +02:00
Gavin King 49a3ecd2c0 moar header updates 2024-09-17 08:43:23 +02:00
Gavin King 8205506104 deal with some warnings 2024-09-17 08:43:23 +02:00
Gavin King 9f59f93b6e mark an override @Deprecated 2024-09-17 08:43:23 +02:00
Gavin King cb8b03d392 report a limitation sooner 2024-09-17 08:43:23 +02:00
Čedomir Igaly 2c607e4bd6 HHH-18322 Fixed compilation error in test case 2024-09-16 16:17:02 -05:00
Čedomir Igaly 289ab0e6ca HHH-18322 Immediately throw InstantiationException when resolving constructor for single null argument 2024-09-16 16:17:02 -05:00
Čedomir Igaly 8bec334ab2 HHH-18322 Fix : when exact constructor is not found, try finding matching one 2024-09-16 16:17:02 -05:00
Cedomir Igaly ab09c672a3 HHH-18322 Test cases showing the problem 2024-09-16 16:17:02 -05:00
Marco Belladelli 95ef45bef8 HHH-18174 Fix junction entity name uses algorithm for subqueries 2024-09-16 14:54:57 -05:00
Marco Belladelli a33ae2d580 HHH-18174 Add test for issue 2024-09-16 14:54:57 -05:00
Gavin King f0f96916ad abbreviated source header 2024-09-16 21:26:00 +02:00
Gavin King bbc325c26f spaces to tabs! 2024-09-16 21:26:00 +02:00
Gavin King a43bcd80a8 enable spotless 2024-09-16 21:26:00 +02:00
Gavin King de921ad473 cleanups by spotless 2024-09-16 21:26:00 +02:00
Andrea Boriero 2f2dbbe2e6 HHH-18489 Lazy, unowned one-to-one associations get loaded eagerly in queries - even with bytecode enhancement 2024-09-16 12:01:30 -05:00
Andrea Boriero b407aa7679 HHH-18489 Test initialization of unowned, lazy one-to-one associations 2024-09-16 12:01:30 -05:00
Yoann Rodière 434b32e494 HHH-18489 Test initialization of unowned, lazy one-to-one associations (and more) in queries 2024-09-16 12:01:30 -05:00
Andrea Boriero 1b0cc59913 HHH-18462 Provide alternatives to deprecated org.hibernate.engine.spi.Mapping 2024-09-16 11:45:54 -05:00
Marco Belladelli e411775c70 Remove problematic template test using type
Note: `string` is an actual type (and keyword) in CockroachDB
2024-09-16 17:15:34 +02:00
Marco Belladelli 9b5f17340f Override CockroachDialect#determineDatabaseVersion implementation 2024-09-16 17:15:34 +02:00
Marco Belladelli e66cbc1d8f Require pgsql 14+ for `compression pglz` column option 2024-09-16 17:15:34 +02:00
Marco Belladelli 829b990585 Fix HANA error where table only contains PK 2024-09-16 17:15:34 +02:00
Marco Belladelli 9071c16e7d HHH-18612 Avoid writing `import.sql` file to classpath 2024-09-16 11:26:00 +02:00
Marco Belladelli 93e74362d5 HHH-18436 Apply plural attribute ordering when creating the join 2024-09-16 11:25:48 +02:00
Marco Belladelli b61628326c HHH-18436 Add test for issue 2024-09-16 11:25:48 +02:00
Marco Belladelli a784ca2027 HHH-18439 Account for null values in query cache hit
Also, solve an assertion error in query result type check when selecting `null` literals
2024-09-16 11:25:30 +02:00
Marco Belladelli 4bf11f8503 HHH-18439 Add test for issue 2024-09-16 11:25:30 +02:00
Marco Belladelli 234bff41b8 HHH-18445 Always preserve correct property order for java records 2024-09-16 11:25:14 +02:00
Marco Belladelli f9a4efaa8f HHH-18445 Add test for issue 2024-09-16 11:25:14 +02:00
Marco Belladelli 3001b7f01d HHH-18484 Account for null generated values for no-op updates 2024-09-16 11:24:54 +02:00
Marco Belladelli 928c786683 HHH-18484 Add test for issue 2024-09-16 11:24:54 +02:00
Gavin King 2e6902ddb2 HHH-17557 native queries return LocalDate and LocalDateTime instead of java.sql types
... by default, with a setting to recover old behavior.
2024-09-15 08:38:21 +02:00
Gavin King 2fc51bd7b2 attempt to untangle some convoluted logic in Query hierarchy 2024-09-15 08:24:43 +02:00
Gavin 52e185b194 HHH-15942 introduce QueryFlushMode for specifying whether a query flushes or not
- replaces FlushModeType in the annotation package
- much less confusing when applied to a Query
  * what do MANUAL and COMMIT mean for a Query?
  * how is AUTO useful for a Query?

- also make Query.getHibernateFlushMode() obey its
  documented semantics by returning the session
  flush mode instead of null when unset
2024-09-15 08:24:43 +02:00
Gavin King 5f8bf125fc HHH-18619 add support for @ForeignKey(options), @UniqueConstraint(options), @Index(options) 2024-09-14 18:49:18 +02:00
Gavin King 19d5895dd6 finally sort out handling of @Id and @Version in query validator
also remove 'this' hacks made obsolete by Steve's work on core
2024-09-14 12:29:10 +02:00
Andrea Boriero d6ab2fd110 HHH-18511 ArrayIndexOutOfBoundsException in ImmutableFetchList 2024-09-14 09:09:25 +02:00
Andrea Boriero 21a69c682e HHH-18511 Add test for issue 2024-09-14 09:09:25 +02:00
Steve Ebersole 4b6822a8bc HHH-18498 - Support for unnamed generators
HHH-18593 - Enforce GeneratedValue GenerationType
HHH-18609 - Use UuidGenerator for GenerationType.UUID
2024-09-13 10:01:00 -05:00
Jan Schatteman 76df41f9be HHH-18537 - Support Session#createNamedSelectionQuery for native-query
Signed-off-by: Jan Schatteman <jschatte@redhat.com>
2024-09-13 10:01:00 -05:00
Steve Ebersole 80b12c46e7 HHH-18535 - Support jakarta.persistence.EntityResult#lockMode 2024-09-13 10:01:00 -05:00
Steve Ebersole e574f88fd6 HHH-18536 - Support implicit "this" alias in HQL 2024-09-13 10:01:00 -05:00
Steve Ebersole 08bd466703 HHH-18498 - Generator on package level does not work when the name is not specified
HHH-18499 - Some new functions in Persistence 3.2 does not work
HHH-18536 - Support implicit "this" alias in HQL
HHH-18537 - Support Session#createNamedSelectionQuery for native-query
2024-09-13 10:01:00 -05:00
Gavin King a82ac08d14 test for @NamedNativeQuery with result set mapping
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-13 10:01:00 -05:00
Gavin King e11ac26cd2 test for @EntityResult(lockMode)
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-13 10:01:00 -05:00
Gavin King 27042f562f test for @SequenceGenerator/@TableGenerator with no name
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-13 10:01:00 -05:00
Gavin King 3c161e0c82 test for JPQL 'this' implicit identification variable
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-13 10:00:59 -05:00
Yanming Zhou 3c4a340c5e HHH-18581 Introduce `supportsBindingNullSqlTypeForSetNull()` and `supportsBindingNullForSetObject()` for `Dialect` to optimize binding null
The method `PreparedStatement.getParameterMetaData().getParameterType(int)` call is expensive for some JDBC driver such as pgJDBC, we should avoid it if the driver supports binding `Types.NULL` for `setNull()` or `null` for `setObject()`.
2024-09-13 14:16:54 +02:00
Yanming Zhou 2e54d95707 HHH-18575 Add test for issue 2024-09-13 14:12:47 +02:00
Yanming Zhou 1d46b87008 HHH-18575 Fix IllegalStateException while passing multi-valued BigDecimal as parameter
Fix
```
java.lang.IllegalStateException: Binding is multi-valued; illegal call to #getBindValue

	at org.hibernate.query.internal.QueryParameterBindingImpl.getBindValue(QueryParameterBindingImpl.java:100)
	at org.hibernate.query.sqm.sql.BaseSqmToSqlAstConverter.resolveSqmParameter(BaseSqmToSqlAstConverter.java:6283)
	at org.hibernate.query.sqm.sql.BaseSqmToSqlAstConverter.consumeSqmParameter(BaseSqmToSqlAstConverter.java:5861)
	at org.hibernate.query.sqm.sql.BaseSqmToSqlAstConverter.consumeSingleSqmParameter(BaseSqmToSqlAstConverter.java:5950)
	at org.hibernate.query.sqm.sql.BaseSqmToSqlAstConverter.processInSingleParameter(BaseSqmToSqlAstConverter.java:8178)
	at org.hibernate.query.sqm.sql.BaseSqmToSqlAstConverter.processInSingleHqlParameter(BaseSqmToSqlAstConverter.java:8135)
	at org.hibernate.query.sqm.sql.BaseSqmToSqlAstConverter.processInListWithSingleParameter(BaseSqmToSqlAstConverter.java:8124)
```
2024-09-13 14:12:47 +02:00
Marco Belladelli 1951c0b993 HHH-18478 Retrieve concrete entity descriptor inside entity initializer's resolve state 2024-09-13 12:41:33 +02:00
Marco Belladelli 03d9671e02 HHH-18478 Add test for issue 2024-09-13 12:41:33 +02:00
Marco Belladelli fc337a9294 HHH-18490 Handle "concrete" generic embeddable attributes defined in mapped superclass
Also, resolve the correct expressible for function return type resolvers based on argument types.
2024-09-13 12:40:56 +02:00
Marco Belladelli 0e71253aa3 HHH-18490 Add test for issue 2024-09-13 12:40:56 +02:00
Marco Belladelli b61ba10afd HHH-18502 Fix compiler method selection for #in(Collection<?> values) 2024-09-13 12:40:32 +02:00
Marco Belladelli 97f9402edb HHH-18502 Add test for issue 2024-09-13 12:40:32 +02:00
Marco Belladelli dbf5d222bb HHH-18469 Use collection element table group when resolving circular bidirectional fetch 2024-09-13 12:39:53 +02:00
Marco Belladelli 564eeead3c HHH-18469 Add test for issue 2024-09-13 12:39:53 +02:00
Marco Belladelli 70137e7f09 HHH-18486 Prioritize custom name-resolvers before defaulting to dynamic 2024-09-13 12:37:49 +02:00
Marco Belladelli 1ae633b5c6 HHH-18486 Add test for issue 2024-09-13 12:37:49 +02:00
Marco Belladelli edc7b5d680 HHH-18178 Validation of CTE source query in `with` method 2024-09-13 12:37:25 +02:00
Marco Belladelli 726ae6a959 HHH-18178 Add test for issue 2024-09-13 12:37:25 +02:00
Marco Belladelli 67269a6137 HHH-18503 Register root table name usage for persisters with physical discriminators 2024-09-13 12:36:59 +02:00
marko-bekhta ecf4c29a60 HHH-18503 Add a test showing the issue 2024-09-13 12:36:59 +02:00
Yanming Zhou 464ad489d6 Mark field `INSTANCE` as private or deprecated for removal if method `instance()` present 2024-09-13 11:03:04 +02:00
Andrea Boriero c181e1913e Revert "HHH-18543 Skip GenericCompositeUserTypeTest for JVM OpenJ9"
This reverts commit 7e4df3f805.
2024-09-13 10:45:58 +02:00
Andrea Boriero d8ad674e7f HHH-18480 ClassCastException when updating a Blob with Oracle 2024-09-12 20:55:00 +02:00
Andrea Boriero 6cc292e9d3 HHH-18480 Add test for issue 2024-09-12 20:55:00 +02:00
Yoann Rodière 4b33d0d067 HHH-18602 Expose `determineDatabaseVersion` in `Dialect` 2024-09-12 12:48:38 -05:00
Andrea Boriero 4bd164222f HHH-18353 ArrayConstructorFunction comparing argument types by reference causes FunctionArgumentException 2024-09-12 15:43:15 +02:00
Andrea Boriero ab11020ed1 HHH-18353 Add test for issue 2024-09-12 15:43:15 +02:00
Andrea Boriero c1d9ac00bf HHH-18565 Mark bytecode enhanced lazy entities as RESOLVED 2024-09-12 14:01:49 +02:00
Andrea Boriero 1a03011d8e HHH-18565 Add test for issue 2024-09-12 14:01:49 +02:00
Matej Pucihar 4518f3daa0 HHH-18565 reproduce issue 2024-09-12 14:01:49 +02:00
Andrea Boriero 952cf531cf HHH-18556 Expressions.nullExpresion() in querydsl result in NPE in SqmExpressible 2024-09-12 13:18:26 +02:00
Andrea Boriero c56d413bf2 HHH-18556 Add test for issue 2024-09-12 13:18:26 +02:00
Gavin King f80ba1fe22 HHH-16880 nail a bit down the handling of converted types in TypecheckUtil 2024-09-11 22:43:06 +02:00
Gavin King 20cd322f37 extract a method in EnumJavaType 2024-09-11 22:43:06 +02:00
Gavin King c57a90e088 cleanup warnings in PersistenceContext
+ code cleanups in CacheEntityLoaderHelper
2024-09-11 08:36:44 +02:00
Gavin King 3a4da8dd85 HHH-18554 also deprecate CascadingActions.LOCK 2024-09-11 07:03:30 +02:00
Gavin King d82913d65f HHH-18544 multiload() and findAll() should return existing proxies 2024-09-11 07:03:30 +02:00
Gavin King 47270d4157 tidy up TypecheckUtil 2024-09-11 01:00:10 +02:00
Gavin King 58a6afe78d remove deprecated FunctionRenderingSupport 2024-09-11 01:00:10 +02:00
Gavin King f2f802645c cleanups related to function registry 2024-09-11 01:00:10 +02:00
Gavin King d269637f77 HHH-18554 deprecate @Cascade and CascadeType 2024-09-10 23:49:55 +02:00
Jan Schatteman 30f2a2045d HHH-18458 - Remove deprecated org.hibernate.EmptyInterceptor
Signed-off-by: Jan Schatteman <jschatte@redhat.com>
2024-09-10 21:41:50 +02:00
Gavin King 1f16a0698e fix more warnings 2024-09-10 17:25:21 +02:00
Gavin King 0c3b8fd819 unexpose the ServiceRegistry on SqmCreationContext + SqlAstCreationContext 2024-09-10 17:25:21 +02:00
Gavin King 25d0922ff9 fix up lots of warnings, esp. unused parameters 2024-09-10 17:25:21 +02:00
Gavin King b4e26b3e32 refactor a bit the BindingContext hierarchy 2024-09-10 17:25:21 +02:00
Gavin King 1abc64fc65 SqmCriteriaNodeBuilder doesn't need to be a SqmCreationContext 2024-09-10 17:25:21 +02:00
Gavin King 4a974fe976 fix up warnings in BasicDotIdentifierConsumer + genericize FullyQualifiedReflectivePathTerminal 2024-09-10 17:25:21 +02:00
Gavin King 0dedc62270 clean up JdbcXxxxJavaTypes 2024-09-10 17:25:21 +02:00
Gavin King 2e4c2ff565 clean up two more enums 2024-09-10 17:25:21 +02:00
Jan Schatteman d0d6f08243 Add cleanup method to test
Signed-off-by: Jan Schatteman <jschatte@redhat.com>
2024-09-10 16:58:46 +02:00
Jan Schatteman 8da3f3700f HHH-18592 - Remove deprecated @TestForIssue
Signed-off-by: Jan Schatteman <jschatte@redhat.com>
2024-09-10 14:09:20 +02:00
Gavin King 4a4c55f830 HHH-17576 fix tests to not demand that fractional seconds are stored for Times 2024-09-10 06:46:25 +02:00
Gavin King 6d64e854e2 HHH-17576 inappropriate use of getDefaultTimestampPrecision() as default precision
This default is only appropriate for timestamps (hence the name) and should not be
used for dates or plain times.
2024-09-10 06:46:25 +02:00
Gavin King 6d4002bd97 reset the ValueHandlingMode after pagination 2024-09-10 00:42:18 +02:00
Gavin King 9f91f2dbff major refactor to horrible instantiation of QueryEngine 2024-09-10 00:42:18 +02:00
Andrea Boriero 53f9321cc0 HHH-18520 Fix issue with dynamic model 2024-09-09 11:17:54 -05:00
Andrea Boriero 92c434dd9b HHH-18520 Upgrade to hibernate-models 0.9.0 2024-09-09 11:17:54 -05:00
Andrea Boriero 3c1b5c7a1d HHH-18520 Upgrade to hibernate-models 0.9.0 + HHH-18521 Leverage hibernate-models ModelsConfiguration 2024-09-09 11:17:54 -05:00
Gavin King 6e2ed7f1a0 HHH-17948 make findAll() accept FindOptions
and add missing options to MultiIdentifierLoadAccess
2024-09-09 17:24:10 +02:00
Gavin King 62e1b0470e HHH-17948 make getAll(), findAll() accept List instead of varargs 2024-09-09 17:24:10 +02:00
Gavin King 7e36768c65 fix warnings in StatelessSessionImpl 2024-09-09 17:24:10 +02:00
Gavin King 362da7ebf1 add javadoc cross links b/w byMultipleIds and findAll
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-09 17:24:10 +02:00
Gavin King 526e282c4c HHH-17948 add Session.findAll(), StatelessSession.getAll()
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-09 17:24:10 +02:00
Gavin King f25060eeac clean up obsolete code in MetadataBuildingProcess 2024-09-09 09:37:06 +02:00
Gavin King 22aba27cff use switch expressions in main enums 2024-09-09 09:00:10 +02:00
Gavin King eed7ec0837 fix a couple of warnings in Configuration 2024-09-09 09:00:10 +02:00
Gavin King 2a904a46b2 fix a minor typing issue in SessionFactoryImpl 2024-09-09 09:00:10 +02:00
Gavin King fc9229e9f4 warning cleanups in Dialects 2024-09-09 09:00:10 +02:00
Gavin King 47f9bcfb24 some code and warning cleanups in Hibernate class 2024-09-09 09:00:10 +02:00
Gavin King 6612868d29 some code and warning cleanups in org.hibernate.boot 2024-09-09 09:00:10 +02:00
Gavin King 04b8d80125
HHH-18492 add Hibernate.isEmpty() for pure convenience
HHH-18492 add Hibernate.isEmpty() for pure convenience

Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-08 23:07:16 +02:00
Gavin King 349b209deb HHH-17739 add tests 2024-09-08 23:02:50 +02:00
Gavin King 6c6c92e88d HHH-17739 fix NPE for field with unsupported collection type
cleanups and warning fixes in TypeConfiguration and BasicValue
2024-09-08 23:02:50 +02:00
Paria f5e1d1cd73
HHH-18470: fix duplicate generated FK names for TABLE_PER_CLASS inheritance 2024-09-08 14:12:14 +02:00
Gavin King ee00217733 HHH-18586 report StaleObjectStateExceptions when batch update fails
and some minor cleanups to the Coordinators

Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-08 14:02:48 +02:00
Gavin King e55c05f0b4 HHH-16954 introduce HibernateCriteriaBuilder.parameterList()
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-07 23:52:44 +02:00
Gavin King 0c1a1e9832 HHH-18584 fix logic for deciding if something is implicitly selectable
implicit joins should not be added to the select list!

Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-07 13:49:27 +02:00
Gavin King 306991f8d9 HHH-18584 disallow "ambiguous" queries for the deprecated createQuery() method
and add support for using 'this' alias to infer the 'select' list (JPA 3.2)

Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-07 13:49:27 +02:00
Gavin King 2630b33261 workaround for Maria reporting that "string" is a keyword
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-06 20:26:05 +02:00
Gavin King 57cfbb6161 simplify quoting algorithm in FilterHelper
and generally refactor logic

eliminate cast to FilterImpl

Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-06 20:26:05 +02:00
Gavin King d1fdb24fb8 minor cleanups to InFlightMetadataCollectorImpl
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-06 20:26:05 +02:00
Gavin King a20fb5663d major rework of Template + battery of new tests
I discovered that the over-complex support for ANSI trim() was
completely broken, unsurprisingly, given the complexity of the
implementation, and the absence of tests.

Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-06 20:26:05 +02:00
Gavin King 35f96d6e90 HHH-18570 reallow use of 'date' and 'time' as regular column names in parsed SQL
attempt to simplify the logic here

Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-06 20:26:05 +02:00
Yanming Zhou cb0268a618 Remove redundant methods `isBatchLoadable()`
The method implementation is identical to default method
2024-09-06 16:28:26 +02:00
Noel Trout 8a88ad7f59 HHH-18571 Fix bug and correctly report effective batching 2024-09-05 14:53:02 +02:00
Noel Trout ff1d5fdb90 HHH-18571 Added test case demonstrating issue 2024-09-05 14:53:02 +02:00
Gavin King 52a9de7cac more @SuppressWarnings cleanups
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-05 10:46:52 +02:00
Gavin King 5748376edc improve an error message
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-05 10:46:52 +02:00
Gavin King 56e0893b3a some misc code cleanups
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-05 10:46:52 +02:00
Gavin King 0dd2defc89 @SuppressWarnings({"UnusedDeclaration"}) -> @SuppressWarnings("unused")
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-05 10:46:52 +02:00
Alex 9cf4bd8251 HHH-18560: added unittest 2024-09-05 10:36:36 +02:00
Alex 944ff41a65 HHH-18560: fix for invalid queries executed on DB2i AS/400 machine 2024-09-05 10:36:36 +02:00
Yanming Zhou b870214ce9 Polishing `EntityVersionMappingImpl`
1. remove unused field `BasicAttributeMapping attributeMapping`
2. remove unused constructor parameter `MappingModelCreationProcess creationProcess`
2024-09-05 09:58:41 +02:00
Gavin King 7c30bbed2b very minor code cleanups
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-04 22:22:58 +02:00
Gavin King eacbd78956 split out SessionFactorySettings and kill off MappingMetamodelImpl.close()
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-04 09:27:46 +02:00
Gavin King 4781c09d0d migrate toward the new PersistenceUnitTransactionType from JPA 3.2
clean up the test base classes etc.

Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-04 09:27:46 +02:00
Gavin King 437b59a57d continue in attempt to clean up EMFBuilderImpl
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-03 19:05:12 +02:00
Gavin King 1f48e8c41d get rid of hangovers from HEM merge
make a rough start on cleaning up EntityManagerFactoryBuilderImpl

Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-03 02:57:37 +02:00
Gavin King 049610b90d split out SessionFactoryRegistryMessageLogger
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-02 19:22:41 +02:00
Gavin King f6ff6fa0f7 code cleanup in Visitors
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-02 11:30:32 +02:00
Gavin King 763401a5c8 clean up the internal DefaultVisitor hierarchy
by removing two obsolete abstract superclasses

Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-02 11:30:32 +02:00
Gavin King 9c75adcffc cleanups in event listeners
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-02 11:30:32 +02:00
Gavin King ec3be767e4 HHH-18553 handle case where managed entity was already removed
just short-circuit and abort the remove()

Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-02 11:30:32 +02:00
Gavin King edf813083e HHH-18553 add a log message
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-02 11:30:32 +02:00
Gavin King 342afd28d4 improve/modernize some error messages
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-02 11:30:32 +02:00
Gavin King f7adc587b2 HHH-18553 add the test
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-02 11:30:32 +02:00
Gavin King 578023e538 HHH-18553 change thrown exception type
and cleanups in DefaultDeleteEventListener

Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-02 11:30:32 +02:00
Andrea Boriero 7e4df3f805 HHH-18543 Skip GenericCompositeUserTypeTest for JVM OpenJ9 2024-09-02 10:00:18 +02:00
Gavin King 052eb0b78c cleanups to EventListenerGroup(Impl)
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-02 00:46:51 +02:00
Gavin King 48fc2ee66d cleanups to EntityEntryContext javadoc
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-02 00:46:51 +02:00
Gavin King 302dd29be1 move check for remove(detached) to SessionImpl for consistency/simplicity
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-02 00:46:51 +02:00
Gavin King f7db3f0005 misc cleanups
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-02 00:46:51 +02:00
Gavin King 09fa8ef76a HHH-18553 flush/evict when there is a managed instance while deleting the detached instance
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-02 00:46:51 +02:00
Gavin King 5c89079f2e consistently pass along session-level lock options
previously, these were respected by a random subset of session methods

Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-01 22:21:33 +02:00
Gavin King 335f7bea9c avoid use of deprecated methods
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-01 22:21:33 +02:00
Gavin King f95182e736 more consistent error message between JPA and plain Hibernate
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-01 22:21:33 +02:00
Gavin King d7aa5f7a78 clean up ExceptionConverterImpl
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-01 22:21:33 +02:00
Gavin King dd16ed61f0 fix and clean up AbstractJPATest
clean up LockTest a little

Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-01 22:21:33 +02:00
Gavin King f805bcec63 cleanups, especially to useless uses of JBoss logging
don't use loggers to generate exception messages

our convention for exception messages is NOT that they begin with HHH-XXXX

it's completely useless to have, like, five of them which do

Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-01 22:21:33 +02:00
Gavin King 83cdeb81b6 HHH-18169 big cleanup of lock/refresh in SessionImpl and collaborators
this was a big mess with no consistency between different overloads of
the same-named method of Session, not to mention different methods

Signed-off-by: Gavin King <gavin@hibernate.org>
2024-09-01 22:21:33 +02:00
Gavin King f45e3db4b0 HHH-18552 clean up inappropriate usages of TransientObjectException
and minor cleanups in StatefulPersistenceContext

Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-31 17:46:11 +02:00
Gavin King 7422c18a94 HHH-18169 disallow refresh/lock for detached instance
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-31 17:46:11 +02:00
Gavin King 1d12dc0499 HHH-18547, HHH-17114 add default implementations to UserType
and deprecate the wrong-signature nullSafeGet() method

Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-31 10:45:48 +02:00
Gavin King 519ffb7c78 some cleanup around SessionFactoryImplementor
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-31 00:22:00 +02:00
Gavin King 67bd785add more misc cleanups
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-31 00:22:00 +02:00
Gavin King ab12b436a2 push down some methods from SessionImplementor to EventSource
just as recommended by the @Deprecated tags added in H6

Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-31 00:22:00 +02:00
Gavin King 681bd09b9d squash warnings in bean LifecycleStrategy stuff
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-30 21:42:15 +02:00
Gavin King 7b8c403df7 clean up ResultSetReturnImpl
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-30 21:42:15 +02:00
Gavin King 252bae18a1 clean up ConnectionProviderInitiator
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-30 21:42:15 +02:00
Gavin King a59f2ac6c8 some cleanup to DatasourceConnectionProviderImpl and multi-tenant version
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-30 20:01:58 +02:00
Gavin King 47c99d5a31 HHH-18538 fix startup logging for DatasourceConnectionProviderImpl and multi-tenant version
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-30 20:01:58 +02:00
Gavin King 8aa37a9d85 fix the typing in ReplicationMode
and improve readability in DefaultReplicateEventListener

even though they are deprecated

Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-30 16:44:22 +02:00
Gavin King e351a00c19 fix a typo in previous commit
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-30 15:46:27 +02:00
Gavin King 72e42817e3 rationalize diverse ways to split strings
+ a couple of other code cleanups

Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-30 13:40:34 +02:00
Gavin King 6787da71af HHH-18548 remove org.hibernate.annotations.QueryHints
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-30 11:14:08 +02:00
Kyrylo Merzlikin ad6f326090 HHH-18516 - Ignore @AttributeOverride for map key when checking type of map value 2024-08-30 09:41:49 +02:00
Tommy Svendsen d39ba13ee4 HHH-18518 Using StringHelper to split versionString instead of regex parsing 2024-08-30 09:32:39 +02:00
Tommy Svendsen 9ac9637daa HHH-18518 change implementation to capture MySQL custom versions better 2024-08-30 09:32:39 +02:00
Marco Belladelli 00680b37fd HHH-18541 Migrate hibernate-envers from hcann to hibernate-models 2024-08-29 13:40:54 -05:00
Gavin King f1d7d86c2d add since to some @Deprecated operations and delete a couple
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-29 19:56:30 +02:00
Gavin King b53728f727 clean up QueryBinder a bit
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-29 19:56:30 +02:00
Yanming Zhou b1fcfdc54e HHH-18538 Improve database connection info from configured DataSource 2024-08-29 18:00:33 +02:00
Anilabha Baral 3159c80146 HHH-17310: Bug with names with digits in CamelCaseToUnderscoresNamingStrategy 2024-08-29 15:35:58 +02:00
Gavin King 850d266c52 HHH-18544 add disabled tests
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-29 15:30:39 +02:00
Gavin King dee06bfcb8 HHH-18539 remove the obsolete test for HHH-13891
we now just throw an exception when the setter is final
(there was some special case for load() which made no sense)

Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-29 15:30:39 +02:00
Gavin King 64622858ab add some @Serial annotations as recommended by IntelliJ
improve a @Deprecated annotation

Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-29 15:30:39 +02:00
Gavin King 11b11c02eb HHH-18540 remove an overload of lock() that's completely useless
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-29 15:30:39 +02:00
Gavin King d38971f75b HHH-18539 update tests after removal of load()
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-29 15:30:39 +02:00
Gavin King 6fe0553fb9 HHH-18540 remove Session.LockRequest
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-29 15:30:39 +02:00
Gavin King bbbaf511ec HHH-18539 remove Session.load()
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-29 15:30:39 +02:00
Yanming Zhou e407c53c86 Remove duplicated space before `when matched`
Running `org.hibernate.orm.test.stateless.UpsertTest`:

Before -> `merge into "UpsertTest$Record" as t using (select cast(? as bigint) id, cast(? as varchar) message) as s on (t.id=s.id) when not matched then insert (id, message) values (s.id, s.message)  when matched then update set message=s.message`
After  -> `merge into "UpsertTest$Record" as t using (select cast(? as bigint) id, cast(? as varchar) message) as s on (t.id=s.id) when not matched then insert (id, message) values (s.id, s.message) when matched then update set message=s.message`
2024-08-29 10:55:30 +02:00
Yanming Zhou 4cef240c5c HHH-6951 IdentifiableType.getIdType() should respect @IdClass
Before this commit, `IdentifiableType.getIdType()` returns unexpected `null` if multiple @Id present.
2024-08-29 10:02:39 +02:00
Gavin King b9f15e888e remove makeCopy() method, since it was annotated @Remove
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-29 01:38:43 +02:00
Gavin King 9e745b4e79 remove more obsolete things annotated @Remove
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-29 01:38:43 +02:00
Gavin King 8eb4d8da0d HHH-18341 fix the issue simply by removing obsolete code
also take the opportunity to "do" a todo

Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-29 00:17:12 +02:00
nathan.xu 3e8f75079a HHH-18385 Remove java.sql.Statement logging in SqlStatementLogger 2024-08-28 22:04:28 +02:00
marko-bekhta 7c594d1412 HHH-18488 Remove table-information-group attribute group in hbm mapping
- just use a list of attributes instead of the group.
2024-08-28 10:36:21 -05:00
marko-bekhta 28988a9a5c HHH-18488 Bump the jboss logging dependency 2024-08-28 10:36:21 -05:00
Vladimír Kuruc 43745c9372
HHH-18531 Fix for Informix timestamp literal error 2024-08-28 17:15:17 +02:00
Marco Belladelli b8b8f011dc HHH-18524 Fix binding of meta-annotated id generators for id-class 2024-08-28 16:21:06 +02:00
Marco Belladelli 6d0c9599e6 HHH-18524 Add test for issue 2024-08-28 16:21:06 +02:00
Gavin King a87e08b2e2 HHH-18487 align behavior of UnsavedValueFactory with semantics of persist()
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-28 14:28:04 +02:00
Gavin King 318e4e6c5d remove unused method marked for removal
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-28 14:28:04 +02:00
Vladimír Kuruc 5975d02e39 Tests with current_timestamp requires Dialect UsesStandardCurrentTimestampFunction feature 2024-08-27 07:10:43 -05:00
Gavin King d90807f9e4 HHH-17117 allow @TenantId to form part of composite key
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-26 21:47:29 +02:00
Steve Ebersole 77a34e6312 HHH-18519 - Add vararg method to HibernatePersistenceConfiguration for supplying mappings 2024-08-26 14:31:23 -05:00
Marco Belladelli 4b06bf63cd HHH-18337 Account for physical naming strategy when querying db sequence
Introduced new signature for `Configurable#configure` which accepts a `GeneratorCreationContext`.
2024-08-26 13:47:24 +02:00
Marco Belladelli 7402e1a153 HHH-18337 Add test for issue 2024-08-26 13:47:24 +02:00
Gavin King d306aadb9d HHH-18517 allow composition of CriteriaDefinitions
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-25 22:18:32 +02:00
Gavin King 4fd9a4f0df HHH-18158 additional test
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-23 22:39:48 +02:00
Gavin King 1f9add32c2 HHH-18512 cleanup code surrounding custom PostgreSQL and Oracle types
Signed-off-by: Gavin King <gavin@hibernate.org>
2024-08-23 18:21:54 +02:00