Commit Graph

10136 Commits

Author SHA1 Message Date
Christian Beikov a316b041f1 HHH-16224 Refactor discovery of exact JDBC drivers, avoid static state in specialized types 2023-03-03 15:13:15 +01:00
Jan Schatteman 2b4201e413 HHH-16180 - Add test and fix (AssertionError when using using native query on table with InheritanceStrategy.JOINED)
Signed-off-by: Jan Schatteman <jschatte@redhat.com>
2023-03-03 09:39:39 +01:00
Christian Beikov c67dbc0013 HHH-16191 Fix issues uncovered by recent not-found fetchin changes 2023-03-03 09:39:39 +01:00
Christian Beikov 6f5102ffd2 HHH-16182 Fix some tests for older databases and adapt assertion for boolean function 2023-03-03 09:39:39 +01:00
Sanne Grinovero 7ce9fb1ee5 Some comments and notes for StandardServiceInitiators 2023-03-02 22:37:19 +00:00
Marco Belladelli 8312db1b9e HHH-16191 Add test and fix checks for skipping resolving polymorphic associated entity instances 2023-03-02 21:12:55 +01:00
Marco Belladelli 10bfcabee2 HHH-16191 change @NotFound semantic, do not force a join but trigger a subsequent select 2023-03-02 21:12:45 +01:00
Marco Belladelli 88a5fd4d28 HHH-16191 Fix eager associations not fetched with native queries 2023-03-02 21:12:45 +01:00
Marco Belladelli 058afd409a HHH-16191 Add test for issue 2023-03-02 21:12:45 +01:00
Jan Schatteman b192d0a234 HHH-16240 - Add test and fix for issue, and refactor TimestampGenerators out of CurrentTimestampGeneration
Signed-off-by: Jan Schatteman <jschatte@redhat.com>
2023-03-02 20:44:53 +01:00
Christian Beikov 0b5e27d133 HHH-16179 Session.find should not apply filters 2023-03-02 20:38:38 +01:00
Andrea Boriero 2c9a508dd2 Fix Sybase UniqueConstraintTest failure 2023-03-02 17:26:21 +01:00
Christian Beikov 373e63f41b HHH-16198 - Fix splitting of SqlAstCreationState 2023-03-02 09:10:35 -06:00
Steve Ebersole 6d9fd28c0f HHH-16198 - Fix splitting of SqlAstCreationState 2023-03-02 09:10:35 -06:00
Marco Belladelli cac60d5ba8 HHH-16211 Remove type inference from like predicate's escape character 2023-03-02 12:18:40 +01:00
Marco Belladelli 507bb7d2c0 HHH-16211 Add test for issue 2023-03-02 12:18:40 +01:00
Steve Ebersole e090480ea1 test cleanup 2023-03-01 17:21:52 -06:00
Steve Ebersole 0c20980be2 HHH-16182 - Converted boolean values not always properly handled in predicates 2023-03-01 13:51:18 -06:00
marko-bekhta 51ef9f494b HHH-16217 Clean up some available settings javadocs 2023-03-01 13:27:35 -06:00
marko-bekhta 844a89a74c HHH-16217 Use only rendered Javadocs for collecting configuration properties 2023-03-01 13:27:34 -06:00
Réda Housni Alaoui 977a6cd987 HHH-15964 Adapt failing tests 2023-03-01 12:07:34 -06:00
Réda Housni Alaoui cf5399998e HHH-15964 Incorrect results for pageable EntityGraph with Hibernate 6.1.6 2023-03-01 12:07:34 -06:00
Davide D'Alto e1a8cc1672 HHH-16243 Change scope of AbstractEntityPersister#generateNonIdAttributeMapping
For Hibernate Reactive
2023-03-01 19:01:50 +01:00
Steve Ebersole 4cc8f04b73 HHH-16229 - Consider pluggability for rendering "JDBC" parameters 2023-03-01 11:56:55 -06:00
Andrea Boriero 6ed48ffff5 HHH-16209 Identically-named association in entity root and embeddable leads to mixup during association loading 2023-03-01 16:57:08 +01:00
Andrea Boriero f728b380a3 HHH-16209 Identically-named association in entity root and embeddable leads to mixup during association loading 2023-03-01 16:57:01 +01:00
Andrea Boriero 5e82db1caa HHH-16209 Reproducer for mixup during loading of identically-named association in entity root and embeddable 2023-03-01 16:56:53 +01:00
Yoann Rodière 6d5c6e002d HHH-16209 Reproducer for mixup during loading of identically-named association in entity root and embeddable 2023-03-01 16:56:46 +01:00
Steve Ebersole cb853c2c3e HHH-16198 - Fix splitting of SqlAstCreationState 2023-03-01 16:55:37 +01:00
Christian Beikov 0469b3b605 Resolve table references before pruning, when the access to the processing state is still there 2023-03-01 16:55:24 +01:00
Andrea Boriero eba0f21d54 HHH-16197 Circular references of the same entity result in different Java objects when caching is enabled and using a query 2023-03-01 16:52:29 +01:00
Andrea Boriero a24cecd2eb HHH-16197 Add test for issue 2023-03-01 16:52:22 +01:00
Andrea Boriero 46c9da1a46 HHH-16193 LazyInitializationException when accessing loaded reference after session is closed using bytecode enhancement 2023-03-01 16:48:34 +01:00
Andrea Boriero 4470e74da3 HHH-16193 Add test for issue 2023-03-01 16:48:34 +01:00
Steve Ebersole 7abc9f712c HHH-15895 - IllegalArgumentException :Cannot create binding for parameter referencen with criteria builder 2023-03-01 16:46:35 +01:00
Andrea Boriero e65ded7a21 HHH-15895 IllegalArgumentException: Cannot create binding for parameter referencen with criteria builder 2023-03-01 16:46:35 +01:00
Andrea Boriero e1779a7662 HHH-15895 Add test for issue 2023-03-01 16:46:35 +01:00
Jan Schatteman c7074d5ac9 HHH-4299 - Add test for issue
Signed-off-by: Jan Schatteman <jschatte@redhat.com>

# Conflicts:
#	hibernate-core/src/test/java/org/hibernate/orm/test/annotations/embeddables/EmbeddableWithGenericAndMappedSuperClassTest.java
2023-03-01 16:40:48 +01:00
Christian Beikov b6eaffeb29 HHH-16195 fix compile error 2023-03-01 13:40:55 +01:00
Marco Belladelli 6c43352871 HHH-16195 Restore logic for declared non-identifier Component properties that use generics
Also remove some duplicate logic for setting declared properties on superclass and add some test cases with embeddables and generics
2023-03-01 13:25:49 +01:00
Marco Belladelli 6189ecb098 HHH-16195 Add test for issue 2023-03-01 13:24:26 +01:00
Davide D'Alto 79c03e784c HHH-16242 Change scopes in AbstractEntityInitializer
and add getters/setters.

Hibernate Reactive needs custom initializers
2023-03-01 13:11:45 +01:00
Andrea Boriero 353d24c7a2 HHH-16230 Wrong data in self-reference using L2C and BatchSize 2023-03-01 11:10:09 +01:00
Andrea Boriero ced18509de HHH-16230 Add test for issue 2023-03-01 11:10:09 +01:00
Georgios Andrianakis fc5ae12d61 Allow access to fields of MutationExecutorPostInsert
This is useful for implementing the reactive version of the class
2023-03-01 10:40:00 +01:00
Marco Belladelli c2ec272ef1 HHH-16130 Add javadoc for dateTrunc 2023-02-28 18:00:52 +01:00
Marco Belladelli a100dfceda HHH-16130 New dateTrunc criteria function 2023-02-28 18:00:52 +01:00
Sanne Grinovero e170eb33d1 HHH-16228 Dialect instance might be wrapped when doing instanceof checks for capabilities
To properly support the idea of wrapping the Dialect, we need
to take this into account whenever an `instanceof` is used
to check for Dialect capabilities.
Also some code is casting to the expected Dialect.
2023-02-27 22:52:43 +00:00
Barry LaFond 2177b32983 method access changes for reactive overrides in AbstractEntityPersister 2023-02-27 20:34:25 +01:00
Andrea Boriero 08e1aae49f HHH-16009 jakarta @OrderBy annotation generates a non-transformed column name in the SQL query for a composite key's field 2023-02-27 17:04:12 +01:00
Andrea Boriero 647fe3d5fa HHH-16009 Code refactoring 2023-02-27 17:04:12 +01:00
Andrea Boriero ffd9c9b0f6 HHH-16009 Add test for issue 2023-02-27 17:04:12 +01:00
Marco Belladelli 546d145d88 HHH-16185 Custom trunc/truncate implementation that handles both numeric and datetimes 2023-02-27 17:02:30 +01:00
Marco Belladelli 821e31b481 HHH-16185 Implement portable date_trunc function emulation and tests 2023-02-27 17:02:29 +01:00
Georgios Andrianakis d922b60a74 Fix logging in AbstractCollectionInitializer
The previous version of the code lead to misleading
log statements being printed when debug logging
was enabled for 'org.hibernate.orm.results.loading.collection'
2023-02-27 14:11:31 +01:00
Andrea Boriero 20212c217c HHH-16202 @OrderBy not applied to collections when @Fetch(value = FetchMode.SUBSELECT) 2023-02-27 14:10:41 +01:00
Andrea Boriero 3683391030 HHH-16202 Add test for issue 2023-02-27 14:10:41 +01:00
shin-mallang 24ec517b7c HHH-16233 Fix logs for mutable non-root entity 2023-02-27 13:36:58 +01:00
Yoann Rodière 7bafc3c6e0 HHH-16177 Test catalog/schema creation/dropping in DefaultCatalogAndSchemaTest 2023-02-27 12:58:27 +01:00
Yoann Rodière 750a663de4 HHH-16177 Take into account the default catalog/schema when creating/dropping catalogs/schemas 2023-02-27 12:58:21 +01:00
Sanne Grinovero 47f13f0cdb HHH-16228 Allow Dialect wrapper to expose the wrapped instance 2023-02-24 22:04:29 +00:00
Sanne Grinovero 2ab68f2164 HHH-16228 Avoid delegating protected methods using during construction 2023-02-24 19:37:28 +00:00
Steve Ebersole 9d833671bb HHH-16227 - Introduce SqmMultiTableMutationStrategyProvider 2023-02-24 09:52:58 -06:00
Sanne Grinovero 3f2e24c3dd HHH-16228 Introduce a Dialect wrapper base class 2023-02-24 13:50:58 +00:00
Steve Ebersole a36f6aa736 HHH-16226 - Introduce JdbcValuesMappingProducerProvider 2023-02-24 07:35:26 -06:00
Sanne Grinovero 02da5a81a8 HHH-16222 Improve warning triggered when the PostgreSQL JDBC driver is not accessible 2023-02-23 14:57:11 +00:00
Sanne Grinovero bce328cb29 HHH-16221 Improve extensibility of CockroachDB and PostgreSQL dialects 2023-02-23 14:57:11 +00:00
Andrea Boriero 56470f4f7c HHH-16175 Fix sybase test failure 2023-02-23 09:09:03 +01:00
Davide D'Alto 16153adde9
HHH-16220 Add MutationExecutorStandard#getNonBatchedStatementGroup
For Hibernate Reactive
2023-02-23 07:40:39 +00:00
Sanne Grinovero ac9f47ae43 HHH-16214 Use a more efficient Map implementation in SqmFunctionRegistry 2023-02-21 19:40:29 +00:00
Steve Ebersole dd5a8c97af Fixed up some SessionFactory-related deprecation warnings 2023-02-21 09:01:21 -06:00
Andrea Boriero 6d69318aae AssertionError in StandardEntityGraphTraversalStateImpl.traverse when using entity graph 2023-02-21 09:13:08 +01:00
Yoann Rodière d0c07bdf89 HHH-16175 Test entity graphs when including either all attributes or no attributes 2023-02-21 09:13:08 +01:00
Gavin 3438d1c966 fix mistake in Oracle timestamp rendering
we need to include the time zone
2023-02-21 08:26:26 +01:00
Gavin King 7ab02c3e5f add tests for casts to/from OffsetDateTime 2023-02-21 08:26:26 +01:00
Andrea Boriero 998bae5791 HHH-16119 Fix test typo 2023-02-20 14:38:40 +01:00
Andrea Boriero fb901051ca HHH-16184 Two queries are execute to initialize empty collections 2023-02-20 14:25:21 +01:00
Andrea Boriero 66ef965320 HHH-16184 Add test for issue 2023-02-20 14:25:14 +01:00
Georgios Andrianakis 6b2281d0ba Apply changes needed for support of @ValueGenerationType in Hibernate Reactive 2023-02-20 09:33:37 +01:00
Marco Belladelli 7e83dba91f HHH-16155 Disable batching when generated properties are found 2023-02-20 09:32:13 +01:00
Marco Belladelli ad6dce7e89 HHH-16155 Add test for issue 2023-02-20 09:32:13 +01:00
Sanne Grinovero 0b0799d567 HHH-16194 Failure to automatically integrate with Bean Validation is excessively noisy 2023-02-17 16:51:10 +00:00
Steve Ebersole fd649a9b4e Misc 2023-02-16 21:02:02 -06:00
Christian Beikov f2deb8f58e HHH-14514 Fix auto eviction of collection cache 2023-02-16 09:09:57 +01:00
Jan Schatteman 2c55a1feb1 HHH-16082 - Correction to the epoch extraction for DB2
Signed-off-by: Jan Schatteman <jschatte@redhat.com>
2023-02-16 09:09:56 +01:00
Jan Schatteman 30ad35643c HHH-16169 - Fix potential NullPointerException in CollectionEntry
Signed-off-by: Jan Schatteman <jschatte@redhat.com>
2023-02-14 18:44:52 +01:00
Jan Schatteman 6f16e4d947 HHH-16082 - Correction to the epoch extraction for HANA
Signed-off-by: Jan Schatteman <jschatte@redhat.com>
2023-02-14 18:42:37 +01:00
Davide D'Alto b2bbc38d2d HHH-16183 Change scopes of private methods in InsertCoordinator 2023-02-14 18:27:49 +01:00
Marco Belladelli 4dfac9ce2d HHH-16080 Add test for issue 2023-02-14 12:24:33 +01:00
Paul Ferraro 16c74bc804 HHH-16172 Expose internal state of 2nd-level cache keys 2023-02-13 21:09:22 +00:00
Christian Beikov 1a9f545e79 HHH-16150 Fix a little issue with SessionFactoryImpl#disintegrate 2023-02-13 18:54:52 +01:00
Yoann Rodière 97d5057751 HHH-16150 Fix schema not being dropped on bootstrap failure with the "create-drop" strategy 2023-02-13 18:54:52 +01:00
Andrea Boriero df4135c7f0 HHH-16119 Named native queries do not work with jakarta.persistence.Tuple result class 2023-02-13 18:54:08 +01:00
Andrea Boriero 3d9b1fb4cf HHH-16119 Add test for issue 2023-02-13 18:54:07 +01:00
Christian Beikov ec778bc632 Replace mockito for some tests with custom spies 2023-02-13 18:42:52 +01:00
Marco Belladelli 21a837fda0 HHH-16109 Don't add limits to named queries when not needed 2023-02-13 17:01:09 +01:00
Marco Belladelli 078c5bdc41 HHH-16109 Add test for issue 2023-02-13 17:01:09 +01:00
Andrea Boriero c6e30f8042 HHH-15990 unable to determine TableReference when associate ManyToOne fetch lazy and NotFound IGNORE 2023-02-13 16:59:21 +01:00
Andrea Boriero 4d433e7c03 HHH-15990 Add test for issue 2023-02-13 16:59:21 +01:00
Christian Beikov 60630fc48d Get rid of most capturing lambdas in write path 2023-02-13 16:57:57 +01:00
Marco Belladelli 7e9902c09e HHH-16170 Check for enums in update statement 2023-02-13 16:56:32 +01:00
Marco Belladelli 108967d26d HHH-16170 Add test for issue 2023-02-13 16:56:32 +01:00
Gavin King bb14d5b288 HHH-16174 support for extract(epoch from ...) in HQL 2023-02-13 16:52:49 +01:00
Jan Schatteman 6c7603f83a HHH-16131 - Correction to workaround for date calculation errors on Oracle (first workaround failed on Oracle 11)
Signed-off-by: Jan Schatteman <jschatte@redhat.com>
2023-02-13 10:20:52 +01:00
Christian Beikov 02a4f91d46 Fix TenantIdTest when VM has nanosecond precision 2023-02-13 10:08:34 +01:00
Gavin King b3b293578e HHH-16133 allow before-execution generators for embeddable properties
and by side-effect allow @TenantId for embeddable properties
2023-02-13 10:08:19 +01:00
Gavin King 48682d4104 very minor jdoc changes 2023-02-13 10:08:19 +01:00
Christian Beikov b1b45a7b7a Use an instant in tests that fits the millisecond resolution of Sybase 2023-02-10 18:22:38 +01:00
Christian Beikov 4c99dbb75c Get rid of capturing lambdas for Bindable#JdbcValueConsumer 2023-02-10 16:08:56 +01:00
Steve Ebersole 15b24d6c14 HHH-16148 - Introduce Immutability (MutabilityPlan) for use with @Mutability
HHH-16141 - Support @Mutability and @Immutable on UserType
HHH-16147 - Support @Mutability and @Immutable on AttributeConverter
HHH-16146 - Improve User Guide documentation for (im)mutability
2023-02-10 08:46:39 -06:00
Christian Beikov de59b44779 Get rid of Clause parameter in JdbcParameterBindings 2023-02-10 15:34:23 +01:00
Andrea Boriero 91e3a38122 HHH-16165 Incorrect SQL generated when using SELECT DISTINCT and @OrderBy 2023-02-10 15:01:40 +01:00
Andrea Boriero 24d1aa67fc HHH-16165 Add test for issue 2023-02-10 15:01:40 +01:00
Marco Belladelli 0e9e631e3e HHH-16137 Fix check when replacing jdbc parameter 2023-02-10 15:00:59 +01:00
Marco Belladelli ad3cd73ada HHH-16137 Add test for issue 2023-02-10 15:00:59 +01:00
Christian Beikov 4a3d6fbc0e Remove identity generation strategy from entity in tests that doesn't need it 2023-02-10 15:00:15 +01:00
Marco Belladelli 1b89defbb6 HHH-16157 Add test for issue and fix duplicate discriminator conditions in join fetch queries 2023-02-09 18:26:50 +01:00
Marco Belladelli 2b3ce400b3 HHH-16037 HHH-16053 Add test for issues 2023-02-09 18:26:50 +01:00
Marco Belladelli d6967ea2cb HHH-15829 Add test for issue 2023-02-09 18:26:50 +01:00
Christian Beikov e8cba53020 HHH-16123 Add another test and fix rendering the pruned subquery in UnionSubclassEntityPersister 2023-02-09 14:02:42 +01:00
Marco Belladelli a25fa21b0c HHH-16123 Add test for issue 2023-02-09 14:02:42 +01:00
Marco Belladelli a66d1a5ec3 HHH-16112 No expectation for one-shot collection delete using update 2023-02-09 10:23:50 +01:00
Marco Belladelli b8dfc42efc HHH-16112 Add test for issue 2023-02-09 10:23:49 +01:00
Gavin King 1ab190134e remove an obsolete constructor no longer called by Quarkus
and delete the stupid InformixDialectTestCase
2023-02-09 10:23:49 +01:00
Marco Belladelli 5ececc8ea9 HHH-16136 Initialize bytecode-enhanced proxy for associated entities 2023-02-08 18:23:54 +01:00
Marco Belladelli e8ec1cdf98 HHH-16136 Add test for issue 2023-02-08 18:23:54 +01:00
Christian Beikov 4e03f320fb HHH-15898 Allow explicit configuration of the UDT column order 2023-02-08 18:07:58 +01:00
Jan Schatteman 7250449aaa Remove calls to deprecated createQuery method from FunctionTests
Signed-off-by: Jan Schatteman <jschatte@redhat.com>
2023-02-08 17:53:25 +01:00
Jan Schatteman 989a127b17 HHH-16131 - Added workaround and test for date calculcation errors on Oracle
Temporarily excluded TiDB from that test (until they fix https://github.com/pingcap/tidb/issues/41052)

Added tidb to the docker_db script

Signed-off-by: Jan Schatteman <jschatte@redhat.com>
2023-02-08 17:53:14 +01:00
Jan Schatteman f33e89133e HHH-16151 - Fix potential NullPointerException in SqmTreePrinter for the like excape character
Signed-off-by: Jan Schatteman <jschatte@redhat.com>
2023-02-08 16:35:02 +01:00
Christian Beikov a71e26e333 HHH-15875 Fix join fetch support for associations within embedded ids 2023-02-08 14:04:41 +01:00
Christian Beikov 2271e18ba5 [HHH-16122] Fix determining the type of a property during type variable resolving for mapped superclasses 2023-02-07 17:51:01 +01:00
Markus Heiden a7448bb15a [HHH-16122] Add test to reproduce problem 2023-02-07 17:50:58 +01:00
Christian Beikov 6861290978 Fix tests for Oracle 11 2023-02-07 17:39:00 +01:00
Steve Ebersole ae238d3032 HHH-16081 - Converted collection-as-basic values are considered immutable
HHH-16132 - Dirty checking broken for collection-as-basic mappings (test)
2023-02-06 13:06:25 -06:00
Marco Belladelli f4e95d96c6 HHH-15733 Change convert logic to default to value for Map collections of basic types 2023-02-06 18:35:53 +01:00
Marco Belladelli 1bb6fcfe1c HHH-15733 Add test for issue 2023-02-06 18:35:53 +01:00
Andrea Boriero c30084010c HHH-16117 Querying entity with collection in Embeddable causes 'A collection with cascade=all-delete-orphan was no longer referenced by the owning entity instance' 2023-02-06 14:41:26 +01:00
Andrea Boriero efe5ee830d HHH-16117 Add test for issue 2023-02-06 14:41:26 +01:00
Andrea Boriero 010b8df7cd HHH-16120 Error advancing (next) ResultSet position 2023-02-06 14:41:26 +01:00
Andrea Boriero 03406be47c HHH-16120 Add test for issue 2023-02-06 14:41:26 +01:00
Andrea Boriero 26ef29bb0d HHH-15944 Joins on non-managed-type polymorphisms don't work 2023-02-06 14:41:26 +01:00
Andrea Boriero 1aa4f177b0 HHH-15944 Add test for issue 2023-02-06 14:41:26 +01:00
Andrea Boriero 1837474f73 HHH-16075 Add test for issue 2023-02-06 14:41:26 +01:00
Andrea Boriero 7f9e48f66a HHH-15970 Add test for issue 2023-02-06 14:41:26 +01:00
Andrea Boriero aad86110e6 HHH-15969 Inheritance: org.hibernate.PropertyAccessException Exception 2023-02-06 14:41:26 +01:00
Andrea Boriero c4dc16a624 HHH-15969 Add test for issue 2023-02-06 14:41:26 +01:00
Marco Belladelli aa5e23311e HHH-15998 Check dynamic instantiation arguments in group by clause 2023-02-06 11:11:30 +01:00
Marco Belladelli 56f2973519 HHH-15991 Add test for issue 2023-02-06 11:11:30 +01:00
Marco Belladelli 45c41fa4dd HHH-15998 Add test for issue 2023-02-06 11:11:30 +01:00
Marco Belladelli 1064577687 HHH-16040 New coercing assembler when types are different from expected 2023-02-06 10:21:29 +01:00
Marco Belladelli 29077e67ab HHH-15916 Add test for issue 2023-02-06 10:21:29 +01:00
Marco Belladelli f051b6dd67 HHH-16040 Add test for issue 2023-02-06 10:21:29 +01:00
Jan Schatteman 86b720fb1f HHH-15665 - Fix and added test for issue
Signed-off-by: Jan Schatteman <jschatte@redhat.com>
2023-02-03 17:39:55 +01:00
Marco Belladelli 2ee4c96852 HHH-16003 Create correct table group for embedded valued paths 2023-02-03 14:43:59 +01:00
Marco Belladelli 7db2dd9d60 HHH-16003 Add test for issue 2023-02-03 14:43:59 +01:00
Christian Beikov 5e8b43edf9 Fix HANA test issues 2023-02-02 19:08:08 +01:00
Yanming Zhou 9a1a703fa9 Fix wrong @Deprecated since version 2023-01-31 15:25:09 +00:00
Steve Ebersole 1b2fd1f8a2 HHH-16113 - Add version checks for MERGE support to dialects 2023-01-27 22:31:01 -06:00
Christian Beikov 7564551f6e HHH-15443 Allow JdbcType to wrap read and write expressions 2023-01-27 14:28:13 -06:00
Steve Ebersole 3281f4522e HHH-16110 - MERGE for optional table update PostgreSQL 2023-01-27 11:31:13 -06:00
Jan Schatteman a6995b50a9 HHH-16020 - Fix for error that surfaced in the LegacyOracleLimitHandler due to the fix for HHH-16020
Signed-off-by: Jan Schatteman <jschatte@redhat.com>
2023-01-27 15:56:45 +01:00
Marco Belladelli 69a5b1faab HHH-15822 Make sure MappedSuperclass can act as type for entity valued paths 2023-01-27 14:59:39 +01:00
Marco Belladelli ebb8e26417 HHH-15822 Add test for issue 2023-01-27 14:59:24 +01:00
Steve Ebersole 1d62d2d66e HHH-16101 - MERGE for optional table updates on Oracle 2023-01-26 12:49:59 -06:00
Steve Ebersole ee8d80a8bd HHH-16069 - Skip CDI for Hibernate extensions by default 2023-01-26 12:19:31 -06:00
Andrea Boriero 6ebafc1cae HHH-16108 NullPointerException when flushing a (simple) entity update for models with bytecode enhancement and multiple one-to-one associations (some lazy) 2023-01-26 18:09:14 +01:00
Yoann Rodière 6bc1b24443 HHH-16108 Test a (simple) entity update for models with bytecode enhancement and multiple one-to-one associations (some lazy)
Stack trace:

java.lang.NullPointerException: Cannot invoke "org.hibernate.metamodel.mapping.SelectableMapping.isFormula()" because "selectable" is null

	at org.hibernate.persister.entity.mutation.UpdateCoordinatorStandard.processSet(UpdateCoordinatorStandard.java:665)
	at org.hibernate.persister.entity.mutation.UpdateCoordinatorStandard.processAttribute(UpdateCoordinatorStandard.java:640)
	at org.hibernate.persister.entity.mutation.UpdateCoordinatorStandard.analyzeUpdateValues(UpdateCoordinatorStandard.java:600)
	at org.hibernate.persister.entity.mutation.UpdateCoordinatorStandard.performUpdate(UpdateCoordinatorStandard.java:256)
	at org.hibernate.persister.entity.mutation.UpdateCoordinatorStandard.coordinateUpdate(UpdateCoordinatorStandard.java:203)
	at org.hibernate.persister.entity.AbstractEntityPersister.update(AbstractEntityPersister.java:2766)
	at org.hibernate.action.internal.EntityUpdateAction.execute(EntityUpdateAction.java:165)
	at org.hibernate.engine.spi.ActionQueue.executeActions(ActionQueue.java:616)
	at org.hibernate.engine.spi.ActionQueue.lambda$executeActions$1(ActionQueue.java:487)
	at java.base/java.util.LinkedHashMap.forEach(LinkedHashMap.java:721)
	at org.hibernate.engine.spi.ActionQueue.executeActions(ActionQueue.java:484)
	at org.hibernate.event.internal.AbstractFlushingEventListener.performExecutions(AbstractFlushingEventListener.java:358)
	at org.hibernate.event.internal.DefaultFlushEventListener.onFlush(DefaultFlushEventListener.java:39)
	at org.hibernate.event.service.internal.EventListenerGroupImpl.fireEventOnEachListener(EventListenerGroupImpl.java:127)
	at org.hibernate.internal.SessionImpl.doFlush(SessionImpl.java:1412)
	at org.hibernate.internal.SessionImpl.managedFlush(SessionImpl.java:485)
	at org.hibernate.internal.SessionImpl.flushBeforeTransactionCompletion(SessionImpl.java:2277)
	at org.hibernate.internal.SessionImpl.beforeTransactionCompletion(SessionImpl.java:1942)
	at org.hibernate.engine.jdbc.internal.JdbcCoordinatorImpl.beforeTransactionCompletion(JdbcCoordinatorImpl.java:426)
	at org.hibernate.resource.transaction.backend.jdbc.internal.JdbcResourceLocalTransactionCoordinatorImpl.beforeCompletionCallback(JdbcResourceLocalTransactionCoordinatorImpl.java:169)
	at org.hibernate.resource.transaction.backend.jdbc.internal.JdbcResourceLocalTransactionCoordinatorImpl$TransactionDriverControlImpl.commit(JdbcResourceLocalTransactionCoordinatorImpl.java:267)
	at org.hibernate.engine.transaction.internal.TransactionImpl.commit(TransactionImpl.java:101)
	at org.hibernate.testing.transaction.TransactionUtil2.inTransaction(TransactionUtil2.java:128)
	at org.hibernate.testing.transaction.TransactionUtil2.lambda$inTransaction$0(TransactionUtil2.java:76)
	at org.hibernate.testing.transaction.TransactionUtil2.inSession(TransactionUtil2.java:35)
	at org.hibernate.testing.transaction.TransactionUtil2.inTransaction(TransactionUtil2.java:74)
	at org.hibernate.testing.junit4.BaseNonConfigCoreFunctionalTestCase.inTransaction(BaseNonConfigCoreFunctionalTestCase.java:590)
	at org.hibernate.orm.test.bytecode.enhancement.lazy.proxy.LazyOneToOneMultiLevelTest.testPersist(LazyOneToOneMultiLevelTest.java:56)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
2023-01-26 18:09:14 +01:00
Andrea Boriero 6c385f7890 HHH-16106 Using BatchEntitySelectFetchInitializer causes PostLoad to be called before references are initialized 2023-01-26 16:14:46 +01:00
Andrea Boriero 10458da711 HHH-16106 Add test for issue 2023-01-26 16:14:46 +01:00
Vedran Prišćan d18cdbec35 HHH-16096 Passing an ExtendedBeanManager which is notified too late leads to initialization error 2023-01-26 09:03:28 -06:00
Marco Belladelli 94b20bafc8 HHH-16070 Check for type parameters when setting declared identifier 2023-01-26 13:52:34 +01:00
Marco Belladelli 3bfb2f66a1 HHH-16070 Add test for issue 2023-01-26 13:52:34 +01:00
Marco Belladelli 7cd6d0422f HHH-16023 Check fetchable declaring type when not found in persister 2023-01-26 13:06:50 +01:00
Marco Belladelli 64b3855c73 HHH-16023 Add test for issue 2023-01-26 13:06:50 +01:00
Sanne Grinovero ae37509b11 HHH-16099 Introduce three-state handling for dirty levels to avoid excessive warnings
We now differentiate between an Attribute which has been marked as "real dirty" from
one which needs to be "treated like dirty", so to not bother end users with a WARN
log when a non-updateable property had not been updated explicitly by them.
2023-01-26 08:35:26 +00:00
Steve Ebersole e27dc5bc47 HHH-16103 - MERGE for optional table updates on SQL Server 2023-01-26 00:41:58 -06:00
Steve Ebersole 5525b8d9b7 HHH-16103 - MERGE for optional table updates on SQL Server 2023-01-26 00:41:58 -06:00
Steve Ebersole a742f5e988 HHH-16069 - Skip CDI for Hibernate extensions by default 2023-01-26 00:29:24 -06:00
Sanne Grinovero 9e033c8aea HHH-16099 Minor refactoring, extract local constants in UpdateCoordinatorStandard 2023-01-25 21:52:21 +00:00
Gavin e00bdc7cb2 fix typo in jdoc 2023-01-25 22:04:03 +01:00
Sanne Grinovero 0b5cb6c649 HHH-16090 BasicResultAssembler logging optimisations 2023-01-25 17:57:26 +00:00
Christian Beikov 033eeb7241 Make session part of JdbcValueBindings 2023-01-25 18:15:11 +01:00
Christian Beikov e841b0aaae Get rid of some capturing lambdas 2023-01-25 18:15:11 +01:00
Steve Ebersole 420e561f21 HHH-16099 - Log about immutable properties only if dirty on update 2023-01-25 11:00:12 -06:00
Marco Belladelli eca3ff13bd HHH-16062 Apply settings and hints to criteria queries 2023-01-25 17:52:33 +01:00
Marco Belladelli 136169d43a HHH-16062 Add test for issue 2023-01-25 17:52:33 +01:00
Yoann Rodière 528d897c4d HHH-16085 Test mapping arrays with @JdbcTypeCode(Type.VARBINARY)
This is useful to revert to pre-6.1 behavior for array mapping in particular.
2023-01-25 17:47:30 +01:00
Christian Beikov e464f53df8 Fix compile error 2023-01-25 17:43:52 +01:00
Andrea Boriero 49779ed4dc HHH-16005 Add test for issue 2023-01-25 17:13:40 +01:00
Andrea Boriero f15d6ee5fb HHH-16025 Using BatchEntitySelectFetchInitializer with caching leads to caching wrong values 2023-01-25 17:05:35 +01:00
Andrea Boriero ac0a27eca2 HHH-16025 Add test for issue 2023-01-25 17:05:35 +01:00
Andrea Boriero b033b88472 HHH-15921 @BatchSize and @IdClass on join column throws exception 2023-01-25 17:05:35 +01:00
Andrea Boriero dbaca049c8 HHH-16039 Add test for issue 2023-01-25 17:05:35 +01:00
Andrea Boriero 8d0729f543 HHH-15921 Add test for issue 2023-01-25 17:05:35 +01:00
Marco Belladelli f9b169242a HHH-16043 Correct single ID and init empty for batch collection loading 2023-01-25 17:01:31 +01:00
Marco Belladelli 17506b7f80 HHH-16043 Add test for issue 2023-01-25 17:01:31 +01:00
Sanne Grinovero 2d7774b9ab HHH-16091 Optimize also AbstractStandardBasicType#compare and #fromString 2023-01-25 14:21:29 +00:00
Sanne Grinovero 12c7252c59 HHH-16091 Make AbstractStandardBasicType#getMutabilityPlan return a constant too 2023-01-25 14:21:29 +00:00
Sanne Grinovero b77bbf0650 HHH-16091 Make AbstractStandardBasicType#getReturnedClass return a constant 2023-01-25 14:21:29 +00:00
Sanne Grinovero 12abcc4c60 HHH-16091 AbstractStandardBasicType to avoid megamorphic dispatch when dealing with AbstractClassJavaType 2023-01-25 14:21:29 +00:00
Sanne Grinovero 1652102c1a HHH-16092 Trim allocation size of CacheKeyImplementation, avoid Objects::deepEquals 2023-01-25 12:00:38 +00:00
Gavin 4ca5902672 mention the query result set cache in the javadoc 2023-01-25 09:52:37 +01:00
Christian Beikov a0d162cde8 Fix test failure by respecting custom insert/delete SQL for secondary tables 2023-01-25 09:32:16 +01:00
Gavin 0bb04b1021 HHH-16089 allow @Synchronize for a collection 2023-01-25 00:19:42 +01:00
Steve Ebersole 2a24876f69 HHH-16084 - MERGE (upsert) for optional table updates - H2 2023-01-24 10:00:54 -06:00
Steve Ebersole 21b7745768 HHH-16084 - MERGE (upsert) for optional table updates - H2 2023-01-24 10:00:54 -06:00
Marco Belladelli 998f2ef21f HHH-15933 Better property owner check + new test case for JoinedSubclass 2023-01-24 14:16:08 +01:00
Marco Belladelli 49690bf4ce HHH-15933 Table reference by name and change referenced property owner 2023-01-24 14:16:08 +01:00
Andrea Boriero a4e2fe57cc HHH-16033 Many-to-Many inverse mapping referencing the same class uses pk instead of fk field for removal 2023-01-24 10:49:31 +01:00
William Burns ea8b0649a2 HHH-16033 Many-to-Many inverse mapping referencing the same class uses pk instead of fk field for removal
* Just reproducer for issue
2023-01-24 10:49:31 +01:00
Andrea Boriero 1638c074d5 HHH-16031 @ManyToMany with @JoinTable(inverseColumn = ...) and SortedSet may results in data loss 2023-01-24 10:49:31 +01:00
Andrea Boriero f4aec1cd0a HHH-16031 @ManyToMany with @JoinTable(inverseColumn = ...) and SortedSet may results in data loss 2023-01-24 10:49:31 +01:00
Yoann Rodière 241fe54d0a HHH-16031 Test @ManyToMany + @JoinTable(inverseColumn) on a SortedSet 2023-01-24 10:49:31 +01:00
Andrea Boriero 0983b47252 HHH-16049 Setting a property to its current value with bytecode enhancement enabled results in unnecessary SQL Update in some (many) cases 2023-01-24 10:40:52 +01:00
Andrea Boriero 3d9a1bce9b HHH-16049 Test setting a property to its current value with bytecode enhancement enabled 2023-01-24 10:40:52 +01:00
Yoann Rodière 5bd1f7c05b HHH-16049 Test setting a property to its current value with bytecode enhancement enabled 2023-01-24 10:40:52 +01:00
Yoann Rodière acbfa0a060 HHH-16049 Restructure lazy-basic tests for easier re-execution and better test reports 2023-01-24 10:40:52 +01:00
Marco Belladelli 12c69c8528 Fix wrong version check in from dual for select only for MySQL 2023-01-24 09:05:04 +01:00
Steve Ebersole 6e442aaed5 HHH-16077 - Added named native queries cannot specify result-class 2023-01-23 21:32:31 -06:00
Steve Ebersole e7b2f9b121 HHH-16077 - Added named native queries cannot specify result-class 2023-01-23 20:26:49 -06:00
Gavin 4a37bf8017 fix another typo 2023-01-23 16:54:34 +01:00
Gavin ea6d76b9b4 fix typos 2023-01-23 16:49:23 +01:00
Gavin 6e590a0149 clean up impl of query hint interpretation
use 'switch' statements
2023-01-23 16:34:10 +01:00
Marco Belladelli 8755129648 HHH-16050 StandardStack optimization using custom array implementation 2023-01-23 11:51:57 +00:00
Andrea Boriero 01db71c272 HHH-16061 SqmDynamicInstantiation warns about dynamic Map instantiation when using an entity 2023-01-23 09:16:55 +01:00
Andrea Boriero e6b94398de HHH-16061 Add test for issue 2023-01-23 09:16:55 +01:00
Gavin e0e3921503 more query space javadoc improvements 2023-01-22 21:25:13 +01:00
Gavin 662594fd5f HHH-16079 rewrite javadoc relating to query spaces + add @Synchronize(logical=false) 2023-01-22 14:50:50 +01:00
Gavin 75f3f699b5 very minor cleanups 2023-01-22 14:50:50 +01:00
Steve Ebersole 35f0c57f07 HHH-15949 - Make MetadataBuilderContributor discoverable 2023-01-20 17:45:11 -06:00
Steve Ebersole b5022f94d3 HHH-15949 - Deprecate MetadataContributor 2023-01-20 16:42:14 -06:00
Steve Ebersole bab25b42e4 HHH-16077 - Added named native queries cannot specify result-class 2023-01-20 15:47:54 -06:00
Sanne Grinovero 94054f6a57 HHH-16072 Restore SPI removal SharedSessionContractImplementor.getTransactionStartTimestamp() 2023-01-20 21:37:55 +00:00
Sanne Grinovero 800873c43d HHH-16058 Removing Environment#getBytecodeProvider 2023-01-20 14:31:08 +00:00
Andrea Boriero 1e21d1c6d1 HHH-16006 Fix checkstyle error 2023-01-20 14:53:41 +01:00
Gavin 1b09d20da0 deprecate config property org.hibernate.flushMode on AvailableSettings
it's actually a JPA hint, and rightfully belongs on HibernateHints
2023-01-20 11:29:59 +01:00
Gavin a986a3806a add convenience method to retrieve Dialect from FunctionContributions
because in fairness this is a little hard to find
2023-01-19 23:57:40 +01:00
Steve Ebersole a552a73632 HHH-16006 - Implement an "additional mapping" contributor SPI 2023-01-19 16:30:46 -06:00
Davide D'Alto e03b3f051a
HHH-16059 Add getters to CteInsertHandler
And the relax scope of a private method.

This way Hibernate Reactive can access them.
2023-01-19 12:28:40 +01:00
Davide D'Alto e2baceb382
HHH-16059 Add getters and relax scopes
extending CteInsertStrategy and CteMutationStrategy
2023-01-19 11:00:38 +01:00
Jan Schatteman f53a29ab12 HHH-16020 - Fix for incorrect offset parameter index and add test for
issue

Signed-off-by: Jan Schatteman <jschatte@redhat.com>
2023-01-18 19:59:07 +01:00
Sanne Grinovero 67dc1ed835 HHH-16052 EntityKey and CollectionKey equality optimisation 2023-01-17 16:47:22 +00:00
Gavin cf65a2d275 improve javadoc for hibernate.hbm2ddl.import_files_sql_extractor 2023-01-17 00:43:52 +01:00
Sanne Grinovero 84a652bfe7 HHH-16051 Avoid stateful lambdas on invocations of Stack#findCurrentFirst 2023-01-16 21:39:15 +00:00
Sanne Grinovero c570b11dcd HHH-16047 Allow reusing of FlushEntityEvent instances 2023-01-16 15:11:15 +00:00
Sanne Grinovero 9f88b56099 HHH-16046 Improve memory safety of mutations in EventListenerGroupImpl
Also avoid for method listeners() to allocate a new List at each use;
 this method was deprecated but it appears it’s still being used in
 various event processors, which is being flagged as a performance issue.
2023-01-15 11:31:27 +00:00
Sanne Grinovero 48df4e15aa HHH-16046 EventListener iterations should avoid using EventListenerGroup#listeners when possible 2023-01-15 11:31:27 +00:00
Gavin a1d43adad4 Oracle does support offsets/zones in datetime literals
+ some minor cleanups
2023-01-14 15:14:04 +01:00
Gavin 6a238adc6c tolerate 'local' keyword in date and time literals
no reason to choke on this, doesn't seem to be ambiguous
2023-01-14 15:14:04 +01:00
Gavin 4a87bc4bb8 use custom-rendered datetime literals on MySQL instead of JDBC escapes 2023-01-14 15:14:04 +01:00
Gavin 2aece6fb95 HHH-16035 use custom-rendered datetime literals on DB2 instad of JDBC escapes
The JDBC escapes didn't play so well with duration arithmetic.
2023-01-14 15:14:04 +01:00
Gavin 8f29ae95c9 more javadoc for Dialect.getFractionalSecondPrecisionInNanos() 2023-01-14 15:14:04 +01:00
Gavin 56774f80d7 fix handling of typestamp arithmetic on Sybase
this was a total inconsistent mess that made no sense
2023-01-14 15:14:04 +01:00
Gavin c852d1ca0d more HQL duration tests 2023-01-14 15:14:04 +01:00
Gavin a9414fa6be disable test for no-longer-allowed literal syntax
I had to disallow this because it was too ambiguous
2023-01-13 16:34:46 +01:00
Gavin ae978b3d10 fix an ambiguity in the grammar of datetime literals
this was my very stupid mistake
2023-01-13 16:34:46 +01:00
Gavin 43cce5fe5e HHH-16035 fix bug with Durations magnitude being off by 10^9 2023-01-13 16:34:46 +01:00
Gavin 2f5f5b9a50 HHH-16035 add a test for cast(duration as Long) + tests for duration arithmetic/literals
(pulls in duration arithmetic tests from other branch)
2023-01-13 16:34:46 +01:00
Gavin 6f7b17d36b HHH-16035 change the default for hibernate.type.preferred_duration_jdbc_type to NUMERIC
There's really no value at all in having h2 as the only platform where Duration
is persisted as 'interval second' by default. People usually use h2 for testing,
and probably actually prefer if the schema is more similar to the schema of
their "real" database.

Also, this tiny change fixes issues 1. and 2. of HHH-16035 as a side-effect.
2023-01-13 16:34:46 +01:00
Matías Santurio 669be6a776 HHH-16038 Fix PersistenceContext.setDefaultReadonly javadoc mistake 2023-01-13 15:02:39 +01:00
Christian Beikov 80b638aeca Introduce getSingleJdbcMapping() and getJdbcMapping(int) to improve JdbcMappingContainer accesses 2023-01-13 09:04:15 +01:00
Sanne Grinovero d64873bde6 HHH-15305 Some dead code elimination and analysis cleanup 2023-01-12 22:24:39 +00:00
Sanne Grinovero 3d4cb14627 HHH-15305 Switch size management in BoundedConcurrentHashMap to use an AtomicInteger 2023-01-12 22:00:36 +00:00
franz1981 7e5c3c8dde HHH-15305 Update custom LIRS implementation based on BoundedConcurrentHashMap 2023-01-12 21:49:08 +00:00
Andrea Boriero 2143ced49e HHH-15604 Identically-named association in entity root and elementcollection of embeddables leads to assertion error 2023-01-12 18:19:38 +01:00
Andrea Boriero b774f80ce9 HHH-15966 ElementCollection with nested Embeddables fails with ArrayIndexOutOfBoundsException 2023-01-12 18:19:38 +01:00
Andrea Boriero 00018731f8 HHH-15604 Identically-named association in entity root and elementcollection of embeddables leads to assertion error 2023-01-12 18:19:38 +01:00
Yoann Rodière cfc7b7ba66 HHH-15604 Test identically-named association in entity root and elementcollection of embeddables 2023-01-12 18:19:38 +01:00
Marco Belladelli b5d58e69ae HHH-15928 Check distinct and sub-queries for SQLServer fetch / offset 2023-01-12 17:22:58 +01:00
Marco Belladelli 21d7d2bb10 HHH-15928 Add test for issue 2023-01-12 17:22:58 +01:00
Marco Belladelli 73da49626d Fix select without from in old versions of MySQL and MariaDB 2023-01-12 17:21:05 +01:00
Andrea Boriero 7b308d048f HHH-15902 @OneToMany relationship with @Where on child table generates wrong sql 2023-01-12 15:23:09 +01:00
Andrea Boriero 3765837b9e HHH-15902 Add test for issue 2023-01-12 15:23:09 +01:00
Sanne Grinovero b037047e24 HHH-16030 Improve name for method EntityInitializer#isInitialized and avoid providing a default implementation 2023-01-12 14:22:05 +00:00
Sanne Grinovero 146f7fc234 HHH-16029 Remove misleading method EntityInitializer#isEntityResultInitializer 2023-01-12 14:22:05 +00:00
Sanne Grinovero b725dc4f20 Prefer using asEntityInitializer() over direct cast 2023-01-12 14:22:05 +00:00
Marco Belladelli 8fa39d773b HHH-16014 Cache treated paths + root logic in copy context for paths 2023-01-12 13:27:58 +01:00
Marco Belladelli b0d03e39e2 HHH-16004 Add test for issue 2023-01-12 13:27:58 +01:00
Andrea Boriero 303da7fca8 HHH-15986 Eager Bidirectional association, initializing an HibernateProxy should associate to the circular association the HibernateProxy itself 2023-01-12 10:34:22 +01:00
Andrea Boriero e0ff430936 HHH-15986 Add test for issue 2023-01-12 10:34:22 +01:00
Gavin a3b2e9b4ae HHH-16028 allow FunctionContributor to be registered programmatically
since we can do this with its friend TypeContributor
2023-01-12 00:36:14 +01:00
Gavin 2e84d51838 HHH-16027 add TypeContributions.contributeAttributeConverter() 2023-01-12 00:36:14 +01:00
Gavin 7444b26db4 HHH-15948 move org.hibernate.metamodel.model.convert to org.hibernate.type.descriptor.converter 2023-01-11 17:56:54 +01:00
Gavin 32c8977406 deprecate layer-breaking method SessionFactory.getSessionFactoryOptions() 2023-01-11 12:50:43 +01:00
Gavin e23318aa95 remove type parameter from StatelessSessionBuilder
this was already done for SessionBuilder, but apparently StatelessSessionBuilder got forgotten
2023-01-11 12:50:43 +01:00
Gavin 1606953a32 make SelfRenderingFunctionSqlAstExpression not blow up with NPE
this doesn't exactly *fix* cases with a nonsensible argument list,
but it at least gives us a chance to produce a more meaningful error
2023-01-11 12:46:18 +01:00
Gavin 296cbb88bd fix queries like 'select ... where ...' with no 'from' clause
this was another bug that resulted from the unnecessary use of
the untypesafe getChild() method in SemanticQueryBuilder. It's
really important that we migrate away from that, who knows how
many other bugs are lurking?
2023-01-11 12:46:18 +01:00
Christian Beikov c402431b9f Fix null constraint violation issue introduced in previous commit 2023-01-11 12:07:33 +01:00
Christian Beikov 82fbbd6c0e Remove unnecessary usage of identity generation to avoid Oracle 11 issues 2023-01-10 18:46:56 +01:00
Steve Ebersole 2a302a59ff Move IndexedConsumer and IndexedBiConsumer to more top-level package 2023-01-10 08:40:28 -06:00
Gavin 5d86d88c03 HHH-16010 fix two bugs in natural id handling found just by inspection of code
- fix place where id and entity had always been passed in reversed order
- fix place where whole state array was passes instead of natural id array
- change the API of NaturalIdResolutions because it never needs the session,
  and the fix involved calling it from a place we did not have one
- and also clean up a bunch of warnings
- improve some visually-ugly code in AbstractEntityEntry
2023-01-10 15:11:32 +01:00
Andrea Boriero 6d15c1d115 HHH-15647 Add test for issue 2023-01-10 10:54:42 +01:00
Steve Ebersole d1a890a9cc HHH-16006 - Implement an "additional mapping" contributor SPI 2023-01-09 18:14:27 -06:00
Steve Ebersole a9ef9045f2 HHH-16006 - Implement an "additional mapping" contributor SPI 2023-01-09 15:41:56 -06:00
Marco Belladelli ab86055565 HHH-15890 Fix shouldEmulateFetchClause method for DB2(i)SqlAstTranslator 2023-01-09 19:01:44 +01:00
Gavin dcc05b8c6c HHH-16008 promote joinTransaction() and isJoinedToTransaction() to SharedSessionContract
so they are available on a StatelessSession
2023-01-09 17:42:42 +01:00
Marco Belladelli 436527b4ba HHH-15982 Check property type when setting bidirectionalAttributeName 2023-01-09 17:33:46 +01:00
Marco Belladelli e26f4d25ab HHH-15982 Refactor tests to use StatementInspector 2023-01-09 17:33:46 +01:00
Gavin bf60dd9d2a add some cross-links to Configuration to javadoc 2023-01-09 13:42:49 +01:00
Gavin a48422ee9b try to make StatementInspector a little more prominent in the javadoc 2023-01-09 13:06:27 +01:00
Andrea Boriero 8b86e082ef HHH-15851 Mixup of entities in refresh with BatchSize 2023-01-09 11:23:02 +01:00
Andrea Boriero 72985d7c4d HHH-15851 Add test for issue 2023-01-09 11:23:02 +01:00
Marco Belladelli 87ba85232f HHH-15982 Fix bidirectional one-to-one detection for mappedBy side 2023-01-09 10:42:25 +01:00
Marco Belladelli 5f08ffed83 HHH-15982 Add parentAccess logic to unique key initializer 2023-01-09 10:42:25 +01:00
Marco Belladelli 39f2482ebf HHH-15950 Add test for issue 2023-01-09 10:42:25 +01:00
Andrea Boriero 6f7b9362d2 HHH-15839 CriteriaBuilder treat method on Path causes ClassCastException 2023-01-09 10:39:42 +01:00
Andrea Boriero f7ae48ad08 HHH-15839 Add test for issue 2023-01-09 10:39:42 +01:00
Gavin 82c94ec142 add BinaryLengthTest
to make sure it's possible to have programs with byte[] fields work across Postgres and others
2023-01-08 15:55:40 +01:00
Gavin 1f0a7e1760 clean some unused imports 2023-01-07 21:43:11 +01:00
Gavin 0007820aba HHH-16000 improve javadoc for @HQLSelect and @SQLSelect 2023-01-07 20:06:48 +01:00
Gavin f8f6e4d541 HHH-16000 Add @HQLSelect annotation as abbreviation for @NamedQuery + @Loader
and deprecate @Loader
2023-01-07 15:02:42 +01:00
Gavin 3ceb91d280 HHH-16000 Add @SQLSelect annotation as abbreviation for @NamedNativeQuery + @Loader 2023-01-07 15:02:42 +01:00
Gavin bfdd7f648b HHH-10557 fix @Loader applied to a collection
the issue here is we have no @CollectionResult for annotation-based result set mappings
2023-01-07 15:02:42 +01:00
Gavin 0db49aa2d5 fix character encoding problem 2023-01-07 15:02:42 +01:00
Marco Belladelli 54402da721 HHH-15985 Custom trunc and round function for PostgreSQL and Cockroach 2023-01-06 15:48:09 +01:00
Gavin ff635b7e99 add a historical note to the jdoc of org.hibernate.usertype 2023-01-06 13:32:37 +01:00
Gavin 5fb04fb6f6 give UserType.replace() a sensible default impl that's essentially always correct 2023-01-06 12:47:48 +01:00
Gavin fe9f909dce add an extended example to UserType jdoc 2023-01-06 12:47:48 +01:00
Gavin a4ad36e7f8 fix escaping in code block 2023-01-06 11:07:35 +01:00
Gavin 8aa1647aa2 add MonetaryAmount example to javadoc 2023-01-06 01:44:35 +01:00
Gavin 1f755e0598 work on the jdoc about type annotations 2023-01-06 01:28:50 +01:00
Gavin ccff90b211 example config files in javadoc, and squash some warnings from jdoc tool 2023-01-05 22:59:01 +01:00
Gavin 5c6127848f link to config properties from overview 2023-01-05 21:30:47 +01:00
Gavin b72d332b34 add temporary table-related settings to AvailableSettings 2023-01-05 21:17:07 +01:00
Gavin ab48dc9ba1 remove an email address I missed 2023-01-05 20:21:01 +01:00
Gavin 663c6c2c71 minor jdoc refresh and deprecations to org.hibernate.id 2023-01-05 20:21:01 +01:00
Jan Schatteman d4cc873ad0 Add useCollectingStatementInspector() to @Jpa and refactor tests that can use it to do so
Signed-off-by: Jan Schatteman <jschatte@redhat.com>
2023-01-05 15:40:24 +01:00
Sanne Grinovero 1e87b3399f HHH-15976 Further optimise InitializersList to avoid resizing collections 2023-01-05 13:47:53 +01:00
Sanne Grinovero 04becd0aa4 HHH-15976 Introduce InitializersList helper and optimise Row processing 2023-01-05 13:47:53 +01:00
Sanne Grinovero e1ecf734c2 Trivial cleanup of dead code 2023-01-05 13:47:53 +01:00
Sanne Grinovero cfeddf8531 Deprecate dead method RowReader#toMemento 2023-01-05 13:47:53 +01:00
Gavin 80feec0c53 use @value instead of @link + delete an obsolete logger 2023-01-05 12:15:27 +01:00
Christian Beikov f0cc803b50 Javadoc for TemporaryTableKind 2023-01-05 11:57:02 +01:00
Gavin 1fd45b607c thorough jdoc review and trivial changes to Dialect 2023-01-05 11:19:16 +01:00
Gavin 6f4fe47c54 update log message about hibernate.create_empty_composites.enabled 2023-01-05 11:19:16 +01:00
Steve Ebersole d7201815d5 HHH-15977 - Deprecate @Persister 2023-01-04 13:36:04 -06:00
Gavin 43316e9101 fix a minor bug in RowIdJdbcType 2023-01-04 20:11:37 +01:00
Gavin b233904c6e add two @Override annotations 2023-01-04 20:11:37 +01:00
Christian Beikov b515ec45a0 Mark @Struct annotation to be incubating 2023-01-04 19:56:15 +01:00
Gavin King 1117436090 Update hibernate-core/src/main/java/org/hibernate/boot/model/FunctionContributor.java
Co-authored-by: Steve Ebersole <steve@hibernate.org>
2023-01-04 19:38:24 +01:00
Gavin ecf4d30c50 make Dialect implement TypeContributor and FunctionContributor
there is little *concrete* benefit to this change, and it's slightly break-y but:

- it removes a dependence on the @Incubating type QueryEngine from Dialect
- we eat our own dogfood, that is, use our own abstractions
- it appears that this was how it was *originally* intended to be
2023-01-04 19:38:24 +01:00
Christian Beikov 9080a387fa Fix HANA test failures on CI 2023-01-04 19:23:34 +01:00
Gavin 80a27ebcbe add a note about integrations to the overview 2023-01-04 17:21:32 +01:00
Gavin 08de2ff104 after all that, we've decided that a better solution is to coerce the enum to the right type
so I'm going to accept both interpretations of the enum, which is better for the user,
and this is also much cleaner implementation-wise

This effectively rolls back most of the previous work on HHH-15711
2023-01-04 17:05:32 +01:00
Gavin 1074891a36 migrate to accessing QueryParameterBindingTypeResolver via MappingMetamodelImplementor
it's just not elegant to have it as a supertype of SessionFactoryImplementor (so deprecate that)
2023-01-04 17:05:32 +01:00
Gavin 196d7a1b5a resolve an issue with ArgumentsValidator and access to the MappingMetamodel
(ideally we should never access the MappingMetamodel from ArgumentsValidator)
2023-01-04 17:05:32 +01:00
Marco Belladelli 9369fbd597 Fix date_trunc function for DB2 10 2023-01-04 16:41:14 +01:00
Christian Beikov 2c724d9172 Fix entity naming for Oracle 11 2023-01-04 16:05:30 +01:00
Christian Beikov 39d876e4d3 Fix array value binding for native queries on DBs that have a TINYINT DDL type 2023-01-04 14:31:25 +01:00
Christian Beikov 85a96de131 Fix identity select statement caching 2023-01-04 14:31:25 +01:00
Gavin e3f1c2741d HHH-15960 make @Comment annotation repeatable and properly test it
I didn't quite nail this one first time round :-/
2023-01-04 13:40:44 +01:00
Andrea Boriero 98957c3509 HHH-15854 Improve CollectionInitializer and EntityDelayedFetchInitializer resolveInstance methods performance when the parent entity is initialized 2023-01-04 12:09:34 +01:00
Andrea Boriero 312d7e11a6 HHH-15794 NullPointerException when constructing mapping model for nested embeddables with not optional ManyToOne 2023-01-04 11:55:56 +01:00
Andrea Boriero 17e48d2ace HHH-15794 Add test for issue 2023-01-04 11:55:56 +01:00
Andrea Boriero a3038f94fa HHH-15967 @OneToOne(mappedBy = ..., fetch = LAZY) in embedded referencing an association within another embedded 2023-01-04 11:11:39 +01:00
Andrea Boriero ecde949c7f HHH-15967 Add test for issue 2023-01-04 11:11:39 +01:00
Marco Belladelli 475e4944df HHH-15866 Handle nested embeddables inside EmbeddedId 2023-01-04 10:52:42 +01:00
Marco Belladelli 60fc0c018a HHH-15866 Handle DependantValue when building embedded attr mapping 2023-01-04 10:52:42 +01:00
Marco Belladelli 461383c8d1 HHH-15866 Add test for issue 2023-01-04 10:52:42 +01:00
Marco Belladelli e39473139e HHH-15865 Fix CI test failures due to GenerationType.IDENTITY 2023-01-04 10:02:00 +01:00
Gavin b7b5fb7559 avoid the use of TypeConfiguration.getServiceRegistry() 2023-01-03 21:06:49 +01:00
Gavin e8f899ffbc avoid the use of TypeConfiguration.getSessionFactory() which is not very typesafe
continue sorting out issues with lifecycle of SessionFactoryImpl and friends
2023-01-03 21:06:49 +01:00
Gavin 91c69d72a7 work on jdoc of Dialect (mostly just formatting) 2023-01-03 21:06:49 +01:00
Gavin d285464302 refresh jdoc for TC and TCA 2023-01-03 21:06:49 +01:00
marko-bekhta b47049f892 HHH-15962 Provide simple default impl for new members of `SchemaManagementTool` interface
- make both `getSchemaTruncator/buildGenerationTargets` as default methods throwing `UnsupportedOperationException`
2023-01-03 10:36:44 +01:00
LLEFEVRE ccf4fac124 HHH-15961 Speed-up Oracle CI build 2023-01-03 10:26:46 +01:00
Gavin 4670087c1a mention XML mappings in overview 2023-01-02 22:26:31 +01:00
Gavin c7a26efed5 more jdoc improvements to annotations 2023-01-02 21:48:47 +01:00
Gavin b7f34795df fix for databases which don't like multiple 'check' keywords
- also check for dupe constraints (for some reason they get added)
2023-01-02 21:45:02 +01:00
Gavin f385fa063a consistently allow multiple @Check constraints
+ improvements to jdoc of @Formula and @Check
2023-01-02 21:45:02 +01:00
Gavin aeabc0e48e eliminate SQL parsing when there are no secondary tables 2023-01-02 21:45:02 +01:00
Gavin 822153948c further reduce direct use of SessionFactory during metamodel building 2023-01-02 21:45:02 +01:00
Gavin 102ef2f469 refactor some functionality out of constructor SessionFactoryImpl into observers 2023-01-02 21:45:02 +01:00
Gavin 7aa92a7c05 allow @Formulas to refer to columns of @SecondaryTables
(this is something that was previously only possible using hbm.xml)

also attempt a partial fixup of the initialization process where SessionFactoryImpl
constructor leaked out an uninitialized reference to itself (it still leaks, but
not as badly)
2023-01-02 21:45:02 +01:00
Gavin 1eba25a466 add some doc to AttributeContainer 2023-01-02 21:45:02 +01:00
Gavin 117851e4a4 add example to @Comment 2023-01-02 21:45:02 +01:00
Gavin 1657c22aca automatically detect when a @Check refers to a @SecondaryTable
- also support named check constraints (multiple of them)
- also support check constraints on collection tables
2023-01-02 21:45:02 +01:00
Gavin abb89a32b1 minor change to code 2023-01-02 21:45:02 +01:00
Gavin c718a46285 improve some error messages 2023-01-02 21:45:02 +01:00
Marco Belladelli 90c767681e HHH-15865 Store attribute metadata for inverse EmbeddedAttributeMapping 2023-01-02 12:07:13 +01:00
Marco Belladelli 8f7b8b8fa2 HHH-15865 Add test for issue 2023-01-02 12:07:13 +01:00
Marco Belladelli 8b7ad24756 HHH-15868 Fix log function test on CockroachDB 2023-01-02 11:21:03 +01:00
Gavin a1853a8c05 HHH-15960 reimplement @Column using the o.h.binder infrastructure and add @Comment(on ="...")
this lets me deprecate @Table(comment = "...") and gets rid of all the passing-Comment-objects-around
2023-01-01 21:36:42 +01:00
Gavin df5980226c HHH-15959 add TypeBinders + fix multiple AttributeBinders on a single field 2023-01-01 21:36:42 +01:00
Gavin e48a8120a9 improve some error messages 2023-01-01 17:25:07 +01:00
Gavin 76b2f92f39 HHH-15958 support the @RowId annotation on DB2 LUW
... and perhaps also on DB2 for z and i (no way to test it)
2023-01-01 17:25:07 +01:00
Gavin 366208924f clean up the JdbcSessionContext SPI + related code
- encapsulate stuff better within JdbcSessionContext
- fix lots of warnings
- deprecate stuff
2023-01-01 16:04:29 +01:00
Gavin 689cca1963 HHH-15958 much better support for @RowId annotation
- the rowid pseudo-column and type are now determined automatically from Dialect
- works (after all these years) in Postgres (and also on h2)
- introduce RowIdJdbcType (not strictly necessary, but a nicety)
2023-01-01 14:20:44 +01:00
Gavin 6da38d0b05 examples of a couple of nice ways to use the Session 2022-12-31 20:15:12 +01:00
Gavin 2576f74ade jdoc for org.hibernate.engine.jdbc.connections.spi 2022-12-31 19:05:06 +01:00
Gavin 6eccc49856 new blurb about OptimisticLocking in package-level doc for annotations 2022-12-31 18:37:11 +01:00
Gavin 5bc6558b07 allow @Nationalized to be used as a meta-annotation 2022-12-31 17:47:20 +01:00
Gavin 6523599106 allow @CollectionIdType to be used as meta-annotation
this was always intended, I believe
2022-12-31 17:47:20 +01:00
Gavin e89015fd8c document the use of typing annotations as meta-annotations 2022-12-31 17:47:19 +01:00
Gavin 60e5b75282 fix the misleading documentation of the @Bag annotation
and improve error reporting when used in a nonsensical way
2022-12-31 17:47:19 +01:00
Gavin a1d52b0bb1 minor cleanups to HCANNHelper 2022-12-31 17:47:19 +01:00
Gavin 327342b39e correct implementation of JPA SharedCacheMode for .hbm.xml
- even though I hate most of its members, I think NONE is pretty useful
- anyway we may as well make it work, since it's trivial
2022-12-31 13:33:26 +01:00
Gavin 1db1c08d3b document a couple of limitations 2022-12-31 13:27:03 +01:00
Gavin 1fe2509b3b minor edits to the jdoc of o.h.boot.spi package 2022-12-31 13:11:22 +01:00
Gavin 699e333ff1 javadoc for MetadataBuildingOptions 2022-12-31 12:31:45 +01:00
Gavin d1c9c4abac very minor doc fixes 2022-12-31 12:07:47 +01:00
Gavin 98d693501a mark Caching and TypeBeanInstanceProducer for potential package moves 2022-12-31 12:06:25 +01:00
Gavin cb103256e1 misc minor doc fixes and compiler warning fixes 2022-12-31 11:25:43 +01:00
Gavin 1d7ecf61c5 improve doc for SqmFunctionDescriptor 2022-12-31 09:58:51 +01:00
Gavin 46dec087fc @link -> @linkplain 2022-12-31 09:30:38 +01:00
Gavin 1a0be6e887 add a code example lifted from the Native Bootstrapping guide to jdoc 2022-12-31 09:27:50 +01:00
Gavin e9f826ee3c improve SchemaAutoTooling enum, making it usable for config 2022-12-31 09:18:56 +01:00
Gavin 66a2f492aa mention dialects in overview 2022-12-31 01:05:13 +01:00
Gavin 0d9a32a9df java-document the use of @Immutable and @Mutability with AttributeConverters 2022-12-31 00:32:39 +01:00
Gavin efd6c8c6fd add cross-refs I missed 2022-12-30 21:59:40 +01:00
Gavin a3059fb9d7 properly document TypeContributor and FunctionContributor 2022-12-30 21:29:16 +01:00
Gavin ce7193696d improve package doc for o.h.query.sqm 2022-12-30 20:13:45 +01:00
Gavin 1a28bb2a3c bootstrapping overview 2022-12-30 19:34:19 +01:00
Gavin 0157d1a1b6 attempt to make better sense of some of this service-related stuff in the docs 2022-12-30 19:32:57 +01:00
Gavin 3381ac2887 document natural ids and generators in annotations package 2022-12-30 16:04:17 +01:00
Gavin 6b4d787caf document the boolean converters 2022-12-30 14:45:28 +01:00
Gavin 263e303829 add documentation about filters 2022-12-30 14:01:09 +01:00
Gavin 9ea6f162fd slight cleanup to the docs for o.h.cache.spi.support 2022-12-30 13:39:18 +01:00
Gavin 61f71030ff incorporate a useful rant about caching in javadoc 2022-12-30 13:24:07 +01:00
Gavin 31f11f4e3c more information about Types in javadoc 2022-12-30 12:37:06 +01:00
Gavin ca25c114be add some missing doc to MetadataBuilder stuff 2022-12-30 00:46:36 +01:00
Gavin fc6db246a8 introduce JpaSettings and improve docs of org.hibernate.jpa.boot 2022-12-30 00:46:36 +01:00
Gavin d6be936da3 improve the documentation for stuff about AttributeConverters and mutability 2022-12-30 00:46:36 +01:00
Gavin 8aba946e77 move FormatMapper and its implementations to a dedicated package
it doesn't belong in the root org.hibernate.type namespace!
2022-12-30 00:46:36 +01:00
Gavin aef9d064db more docs for type package 2022-12-30 00:46:36 +01:00
Gavin c829c84d55 BigDecimalJavaType and BigIntegerJavaType should support conversion to String 2022-12-30 00:46:36 +01:00
Gavin b4b8e955f8 clean up imports 2022-12-30 00:46:36 +01:00
Gavin 7dad0e38e2 better docs for FormatMapper 2022-12-30 00:46:36 +01:00
Gavin 9e8b24f691 very minor 2022-12-30 00:46:36 +01:00
Gavin a03486dc55 deprecate the experimental (and buggy) feature hibernate.create_empty_composites.enabled
see HHH-11936
2022-12-30 00:46:36 +01:00
Gavin b2586d5f2a clean up very obsolete doc of SessionFactoryImpl 2022-12-30 00:46:36 +01:00
Gavin 704c524e7c more minor doc fixes 2022-12-30 00:46:36 +01:00
Gavin 53982b78fb fix incorrect doc of CurrentTenantIdentifierResolver 2022-12-30 00:46:36 +01:00
Gavin 7b493f30fb Configuration improvements
- methods of Configuration should consistently return this
- remove a redundant warning
- add StatementInspector, ColumnOrderingStrategy, CustomEntityDirtinessStrategy to Configuration
  (at least two out of three of these are pretty useful!)
2022-12-30 00:46:36 +01:00
Gavin 2ada31b899 mention naming strategies in overview 2022-12-30 00:46:36 +01:00
Gavin 0bcf19d85b minor changes 2022-12-30 00:46:36 +01:00
Gavin c3a35821bd more doc cleanups 2022-12-30 00:46:36 +01:00
Gavin f8b50b39d7 remove the unused ParameterRegistration stuff in org.hibernate.jpa.spi
these types appear to be already unused in H5!

this can't possibly break anything: anything using it is already broken
2022-12-29 15:04:51 +01:00
Gavin 81a3541d26 clean up the package org.hibernate.engine.transaction
- it had classes/interfaces which are already unused in H5!
- move TransactionObserver and IsolationDelegate to a much
  more sensible location next to TransactionCoordinator

This will break custom implementations of TransactionCoordinator
but I highly doubt there are very many of those!
2022-12-29 15:04:51 +01:00
Gavin c6f0be990c yet more work on the API documentation
- and get rid of people's email addresses, they don't belong in the code
2022-12-29 15:03:09 +01:00
Gavin 5246ec508c delete two unused files 2022-12-29 15:03:09 +01:00
Gavin 95cede87ed further work on the API documentation 2022-12-29 03:30:10 +01:00
Gavin 37042f9b77 documentation improvements, especially to the boot package
also deprecate some unused stuff
2022-12-29 00:39:23 +01:00
Gavin 347ad56772 delete unused ReturnMetadata class 2022-12-29 00:39:23 +01:00
Gavin c7845582d4 delete unused TypeNames class 2022-12-29 00:39:23 +01:00
Gavin 273b1cb251 remove unused interface Loggable 2022-12-29 00:39:23 +01:00
Gavin cc46b622be minor code changes 2022-12-28 15:08:16 +01:00
Gavin 60884a4c3a get rid of "NOTE :" which looks terrible in compiled javadoc
- use @implNot / @apiNot instead
2022-12-28 15:08:16 +01:00
Gavin b3625a34e4 delete two unused classes 2022-12-28 15:08:16 +01:00