WordPress-C
/
WordPress
mirror of https://github.com/WordPress/WordPress.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

REST API: Remove misleading comment in WP_REST_Blocks_Controller->get_item_schema. 

In r56093 schema caching was added above a comment instructing developers not to cache that controller's schema. However, there is no obvious penalty for re-caching schema that is partially derived from a parent.

Caching schema in the same way in every controller is beneficial consistency, and discussion at WCUS2023 contributor day concluded we could remove this comment.

Props ahardyjpl, davidbinda, johnjamesjacoby, TimothyBlynJacobs.

Fixes #59193. See #58657.

Built from https://develop.svn.wordpress.org/trunk@56459


git-svn-id: http://core.svn.wordpress.org/trunk@55971 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This commit is contained in:
K. Adam White 2023-08-24 20:23:16 +00:00
parent 9af3c92a4e
commit 96cd4c4224
2 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
wp-includes/rest-api/endpoints/class-wp-rest-blocks-controller.php
View File

@ -75,7 +75,6 @@ class WP_REST_Blocks_Controller extends WP_REST_Posts_Controller {
return $this->add_additional_fields_schema( $this->schema ); return $this->add_additional_fields_schema( $this->schema );
} }
// Do not cache this schema because all properties are derived from parent controller.
$schema = parent::get_item_schema(); $schema = parent::get_item_schema();
/* /*

2
wp-includes/version.php
View File

@ -16,7 +16,7 @@
* *
* @global string $wp_version * @global string $wp_version
*/ */
$wp_version = '6.4-alpha-56458'; $wp_version = '6.4-alpha-56459';
/** /**
* Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema. * Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.