WordPress-C
/
WordPress
mirror of https://github.com/WordPress/WordPress.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
43,499 Commits 50 Branches 749 Tags 991 MiB
Commit Graph

102 Commits

Author SHA1 Message Date
Helen Hou-Sandí 5fc736f49e Media grid bulk selection styling: 
* Fade content within each attachment item so that focus styling is still clear.
* Less jarring toolbar pinning.
* Tighten up the fade in/out transition.

see #28842.

Built from https://develop.svn.wordpress.org/trunk@29489


git-svn-id: http://core.svn.wordpress.org/trunk@29267 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-14 07:18:15 +00:00
Scott Taylor b5922001b4 Remove debug line from [29484]. 
See #28842.


Built from https://develop.svn.wordpress.org/trunk@29485


git-svn-id: http://core.svn.wordpress.org/trunk@29263 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-14 00:37:15 +00:00
Scott Taylor 9c08ad236a Media Grid: add Bulk Selection mode for deleting attachments. 
* Toolbar is sticky when `select` mode is active
* Selection is toggled when clicking an attachment preview
* Unselected attachments fade out, selected fade in.

See #28842.

Built from https://develop.svn.wordpress.org/trunk@29484


git-svn-id: http://core.svn.wordpress.org/trunk@29262 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-13 22:45:15 +00:00
Scott Taylor 99a10a450e Media Grid: treat Edit Image like a `mode`, which it is, instead of a `state`, which it is not. 
Fixes #29206.

Built from https://develop.svn.wordpress.org/trunk@29483


git-svn-id: http://core.svn.wordpress.org/trunk@29261 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-13 19:26:16 +00:00
Scott Taylor ca03604712 In the Edit Attachment frame, when in Edit Image mode, add a key event for Escape. There are conflicting `keydown` handlers that don't propagate the event to the modal properly. 
Fixes #29121.

Built from https://develop.svn.wordpress.org/trunk@29481


git-svn-id: http://core.svn.wordpress.org/trunk@29259 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-13 18:15:18 +00:00
Scott Taylor ed5d17ab77 Media Grid: remove Router code that doesn't actually ever run. 
See #29121.

Built from https://develop.svn.wordpress.org/trunk@29444


git-svn-id: http://core.svn.wordpress.org/trunk@29222 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-07 22:37:16 +00:00
Scott Taylor 1217efe905 Media Grid: remove Router code that doesn't actually ever run. 
See #29121.

Built from https://develop.svn.wordpress.org/trunk@29443


git-svn-id: http://core.svn.wordpress.org/trunk@29221 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-07 22:33:15 +00:00
Scott Taylor 3f17e7040e Create a new Backbone view, `media.view.Label`, which can be used as a subview in things like toolbars, which need screen reader text. 
Make an initial instance of it for the label for Bulk Actions in Media Grid.

See #29026.

Built from https://develop.svn.wordpress.org/trunk@29434


git-svn-id: http://core.svn.wordpress.org/trunk@29212 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-07 20:09:17 +00:00
Scott Taylor c5dff42d51 Revert [29428] to avoid errors with Add Media for now. 
See #29026.

Built from https://develop.svn.wordpress.org/trunk@29432


git-svn-id: http://core.svn.wordpress.org/trunk@29210 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-07 19:40:15 +00:00
Scott Taylor afb0b3e4ef Media Grid: add screen reader labels with more context to filters and bulk actions. Ditto for list view. 
Props afercia.
Fixes #29026.

Built from https://develop.svn.wordpress.org/trunk@29428


git-svn-id: http://core.svn.wordpress.org/trunk@29206 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-07 05:20:16 +00:00
Scott Taylor f0f4174ed8 Media Grid: remove some unused Trash/Delete handler logic. Rendered useless since [29266] and made official by [29322]. 
See #28819.

Built from https://develop.svn.wordpress.org/trunk@29427


git-svn-id: http://core.svn.wordpress.org/trunk@29205 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-07 05:03:17 +00:00
Scott Taylor 8ed123c97f In `media.view.AttachmentFilters.All`, make `uploaded` conditional upon `media.view.settings.post.id` and include a new filter: `unattached`. 
Drop the `mime-types` filter and related class (which was added for Media Grid) and use `all` instead. 

Props ocean90, wonderboymusic.
Fixes #29065.

Built from https://develop.svn.wordpress.org/trunk@29426


git-svn-id: http://core.svn.wordpress.org/trunk@29204 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-07 04:44:17 +00:00
Scott Taylor 935f10413e Media Grid: expose the `$.Deffered()` object in `media.view.AttachmentsBrowser.updateContent()` so the grid can call `Backbone.history.start()` when models actually exist. 
This is a lot better then `_.delay( this.pray, 1000 )`, but needs continued study.

See #29052.

Built from https://develop.svn.wordpress.org/trunk@29420


git-svn-id: http://core.svn.wordpress.org/trunk@29198 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-06 21:44:17 +00:00
Scott Taylor a58a4da852 Media Grid: display upload errors in a dismissable sidebar. 
See #29037.

Built from https://develop.svn.wordpress.org/trunk@29415


git-svn-id: http://core.svn.wordpress.org/trunk@29193 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-06 19:13:15 +00:00
Scott Taylor 27b0d4cd20 In `media.view.BulkSelectionActionButton.click()`, do not assume that `delete` is the only possible bulk action. 
Fixes #29101.

Built from https://develop.svn.wordpress.org/trunk@29403


git-svn-id: http://core.svn.wordpress.org/trunk@29181 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-06 17:24:19 +00:00
Scott Taylor 27890cc734 Media Grid: don't blow away the Attachment Details modal every time a new model is loaded. 
Props ericlewis.
Fixes #29104.

Built from https://develop.svn.wordpress.org/trunk@29368


git-svn-id: http://core.svn.wordpress.org/trunk@29146 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-03 19:40:17 +00:00
Scott Taylor 696c12bc55 Media Grid: don't select `body` with jQuery when instantiating `media.view.UploaderWindow`. 
Props ericlewis.
See #28965.

Built from https://develop.svn.wordpress.org/trunk@29367


git-svn-id: http://core.svn.wordpress.org/trunk@29145 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-03 19:37:19 +00:00
Sergey Biryukov 0c2fe96a31 Media Grid: Close the modal if the attachment is deleted. 
props ericlewis.
fixes #28819.
Built from https://develop.svn.wordpress.org/trunk@29322


git-svn-id: http://core.svn.wordpress.org/trunk@29103 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-29 14:58:19 +00:00
Dominik Schilling 7bbbbe44c7 Media Grid: Improve lazy loading. 
props kovshenin.
see #24716.
Built from https://develop.svn.wordpress.org/trunk@29312


git-svn-id: http://core.svn.wordpress.org/trunk@29093 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-27 17:58:15 +00:00
Dominik Schilling ab151eca85 Media Grid: Ignore user setting for `content`. 
fixes #29034.
Built from https://develop.svn.wordpress.org/trunk@29305


git-svn-id: http://core.svn.wordpress.org/trunk@29087 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-27 11:44:18 +00:00
Scott Taylor 0e4c8b2b0c Media Grid: when closing the modal, automatically focus the proper attachment by reading the model's ID, which is unique. 
Props adamsilverstein (for the red), wonderboymusic (for the green).
Fixes #28857.

Built from https://develop.svn.wordpress.org/trunk@29299


git-svn-id: http://core.svn.wordpress.org/trunk@29081 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-25 01:00:16 +00:00
Scott Taylor 5be43cfeb1 Media Grid: Manage focus when toggling between the grid and an edit attachment modal 
Props adamsilverstein for the initial patch.
Fixes #28857.

Built from https://develop.svn.wordpress.org/trunk@29282


git-svn-id: http://core.svn.wordpress.org/trunk@29064 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-24 19:05:15 +00:00
Helen Hou-Sandí 795c97d08b Add support for `attachment_fields_to_edit` in the attachment details modal. props ericlewis. fixes #28991, see #24716. 
Built from https://develop.svn.wordpress.org/trunk@29278


git-svn-id: http://core.svn.wordpress.org/trunk@29060 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-23 22:09:18 +00:00
Dominik Schilling 270a57075c Media Grid: Add a date filter. 
props ericlewis.
fixes #28895.
Built from https://develop.svn.wordpress.org/trunk@29271


git-svn-id: http://core.svn.wordpress.org/trunk@29053 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-22 20:47:15 +00:00
Scott Taylor 0702527010 Media Grid: general JS cleanup. 
Props ericlewis.
See #28965.


Built from https://develop.svn.wordpress.org/trunk@29266


git-svn-id: http://core.svn.wordpress.org/trunk@29049 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-22 16:21:15 +00:00
Helen Hou-Sandí 89a8316946 Move the "view" link for attachment details to the sidebar and use more specific language. Removes an unnecessary JS handler. fixes #28977. 
Built from https://develop.svn.wordpress.org/trunk@29263


git-svn-id: http://core.svn.wordpress.org/trunk@29046 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-22 02:20:15 +00:00
Sergey Biryukov 8923bb0c0e Media Grid: Add a View button to Attachment Details modal. 
props adamsilverstein.
fixes #28977.
Built from https://develop.svn.wordpress.org/trunk@29262


git-svn-id: http://core.svn.wordpress.org/trunk@29045 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-22 01:30:16 +00:00
Helen Hou-Sandí 06f5b5a490 Media Grid: 
Instead of a separate bulk selection mode, persistently show a checkbox for each item. Restores the more familiar bulk actions dropdown + action button.

props ericlewis. see #28842.


Built from https://develop.svn.wordpress.org/trunk@29212


git-svn-id: http://core.svn.wordpress.org/trunk@28996 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-17 20:42:15 +00:00
Helen Hou-Sandí b7445ec8a4 Media Grid Attachment Details modal UI improvements: 
* Align better visually with the existing media modal and the post image edit modal.
* Add back a link to the full attachment edit screen (post.php).
* Add a title to the modal and move prev/next buttons next to the more-consistent close button.
* Remove mode tabs (metadata vs. image editing) in favor of the Edit Image button.

Still to come: responsive, IE8 testing and targeted CSS (calc() usage), general CSS cleanup.

props ericlewis, helen, melchoyce. see #28844. fixes #28915.

Built from https://develop.svn.wordpress.org/trunk@29204


git-svn-id: http://core.svn.wordpress.org/trunk@28988 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-17 03:55:15 +00:00
Dominik Schilling 448422f8ae Media Grid improvements: 
* Remove fixed elements.
* Adjusts toolbar and search, fixes #28833.
* Add link to Add New button, fixes #28825.
* Add "Edit Metadata" tab to all items, "Edit Image" only for images
* Make strings translatable.
* First pass for help tab.

see #28850.
Built from https://develop.svn.wordpress.org/trunk@29136


git-svn-id: http://core.svn.wordpress.org/trunk@28920 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-13 16:16:15 +00:00
Scott Taylor 59ffcf668b Media Grid, for audio files: 
* Show `artist` and `album` fields in the Edit Attachment modal
* Sync their values on `change`

See #28839.

Built from https://develop.svn.wordpress.org/trunk@29104


git-svn-id: http://core.svn.wordpress.org/trunk@28890 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-11 20:55:15 +00:00
Scott Taylor 56a70f3b64 Media Grid: after [29085], also handle `MEDIA_TRASH`. 
See #24716.

Built from https://develop.svn.wordpress.org/trunk@29098


git-svn-id: http://core.svn.wordpress.org/trunk@28884 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-11 18:50:14 +00:00
Scott Taylor 6d67479072 Media Grid: 
* Don't store multiple references to the Edit Attachments frame.
* Fix keyboard navigation event delegation and proxy.
* Remove redundant function calls.

See #24716.

Built from https://develop.svn.wordpress.org/trunk@29089


git-svn-id: http://core.svn.wordpress.org/trunk@28875 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-11 06:39:14 +00:00
Scott Taylor c22c49a1ba Media Grid: "Add New" should open and close, not just open. 
See #24716.

Built from https://develop.svn.wordpress.org/trunk@29087


git-svn-id: http://core.svn.wordpress.org/trunk@28873 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-11 05:44:14 +00:00
Scott Taylor ea42b8e48e Media Grid: 
* Move the grid down via CSS transition when the Screen Options slide open.
* Remove some unused CSS for grid options.

See #24716.

Built from https://develop.svn.wordpress.org/trunk@29086


git-svn-id: http://core.svn.wordpress.org/trunk@28872 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-11 05:34:14 +00:00
Scott Taylor ceff8de594 Media Grid: 
* The "Edit Image" link in the attachment modal details is redundant.
* After an attachment is deleted in the modal, automatically move to the next attachment in the library. If there are no attachments left, close the modal.

See #24716.

Built from https://develop.svn.wordpress.org/trunk@29085


git-svn-id: http://core.svn.wordpress.org/trunk@28871 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-11 05:22:14 +00:00
Scott Taylor f6ced74287 Media Grid: while in Bulk Edit mode, any selected attachment should have the blue border, rather than just the last clicked one. 
Props ericlewis.
See #24716.

Built from https://develop.svn.wordpress.org/trunk@29081


git-svn-id: http://core.svn.wordpress.org/trunk@28867 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-10 23:03:14 +00:00
Scott Taylor a89060013b Media Grid: Move toggling of visible fields to Screen Options. This moves us in a better direction... but this will probably need to be massaged again. 
See #24716.

Built from https://develop.svn.wordpress.org/trunk@29077


git-svn-id: http://core.svn.wordpress.org/trunk@28863 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-10 21:00:17 +00:00
Scott Taylor b7c8dee8f5 Media Grid: decouple the Grid and Edit modal frames. Next steps: we shouldn't have to reload the frame while paginating. 
See #24716.

Built from https://develop.svn.wordpress.org/trunk@29076


git-svn-id: http://core.svn.wordpress.org/trunk@28862 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-10 19:39:14 +00:00
Scott Taylor 41f71c7938 Media Grid: add disambiguation between generic frames and routers and the router specifically interacting with the grid's frame. 
See #24716.

Built from https://develop.svn.wordpress.org/trunk@29074


git-svn-id: http://core.svn.wordpress.org/trunk@28860 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-10 18:43:14 +00:00
Scott Taylor 7a438ad0dc Media Grid: make the router work when `?item=` is in the URL on page load. This is still a hack, needs to be event-driven. 
See #24716.

Built from https://develop.svn.wordpress.org/trunk@29073


git-svn-id: http://core.svn.wordpress.org/trunk@28859 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-10 18:25:14 +00:00
Scott Taylor df241d2259 Media Grid: `hasNext` and `hasPrevious` are functions that must be called. Otherwise they are always truthy properties. 
See #24716.

Built from https://develop.svn.wordpress.org/trunk@29072


git-svn-id: http://core.svn.wordpress.org/trunk@28858 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-10 18:10:15 +00:00
Scott Taylor 2af40744ec Avoid JS errors after [29057]. This is not how `_.debounce()` works. 
See #24716.

Built from https://develop.svn.wordpress.org/trunk@29071


git-svn-id: http://core.svn.wordpress.org/trunk@28857 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-10 18:03:15 +00:00
Scott Taylor 6695de8b5b Avoid JS errors after [29057]. When the modal closes, reset the URL. 
See #24716.

Built from https://develop.svn.wordpress.org/trunk@29070


git-svn-id: http://core.svn.wordpress.org/trunk@28856 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-10 17:56:14 +00:00
Scott Taylor ed5fa055e1 Avoid JS errors after [29057]. 
See #24716.

Built from https://develop.svn.wordpress.org/trunk@29069


git-svn-id: http://core.svn.wordpress.org/trunk@28855 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-10 17:51:16 +00:00
Scott Taylor 1a2963fabd Avoid JS errors after [29057]. 
See #24716.

Built from https://develop.svn.wordpress.org/trunk@29068


git-svn-id: http://core.svn.wordpress.org/trunk@28854 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-10 17:49:15 +00:00
Scott Taylor d297258d99 Media Grid, remove unnecessary abstraction: `wp.media.controller._State` 
Props ericlewis.
See #24716.

Built from https://develop.svn.wordpress.org/trunk@29066


git-svn-id: http://core.svn.wordpress.org/trunk@28852 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-10 16:02:15 +00:00
Helen Hou-Sandí 1899cc9c41 Media grid attachment modal: 
* Keyboard navigation.
* History and routes for single items and search results.

props adamsilverstein. see #24716.


Built from https://develop.svn.wordpress.org/trunk@29057


git-svn-id: http://core.svn.wordpress.org/trunk@28845 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-10 06:37:16 +00:00
Helen Hou-Sandí 89dff37759 Media grid: 
* Introduce the concept of bulk editing via a separate mode. Like the list view, only bulk deleting is available. The UI is a little funky, especially with the field display toggles there, but refinements will come.
* Up the max thumbnail size from 120px to 150px.
* Slide-down panel for the add new uploader. Known issue: it doesn't close again.
* Remove the toolbar region in the EditAttachment frame.
* Defer a function call so the grid fills available space.
* Give feedback when no results are found. Also needs styling.

props ericlewis. see #24716.

Built from https://develop.svn.wordpress.org/trunk@29056


git-svn-id: http://core.svn.wordpress.org/trunk@28844 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-10 03:50:17 +00:00
Scott Taylor 9a1ac73c34 Make media grid text fields (data) toggle-able. Checking/unchecking is saved in user settings cookie. 
See #24716.

Built from https://develop.svn.wordpress.org/trunk@28995


git-svn-id: http://core.svn.wordpress.org/trunk@28783 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-04 04:48:15 +00:00
Helen Hou-Sandí 63f9cbd02a Media grid, round 2. Expect much more to come. 
* Instead of a sidebar for details, utilize a modal. The modal experience allows for a larger preview, editing images, audio/video previews, and previous/next navigation, like the theme browser. Think of it as an attachment browser.
* Show some details in the grid view to more easily distinguish items.

props ericlewis, wonderboymusic, JerrySarcastic. see #24716.

Built from https://develop.svn.wordpress.org/trunk@28993


git-svn-id: http://core.svn.wordpress.org/trunk@28781 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-04 03:39:15 +00:00
Scott Taylor 0546378ce8 Make a new file: `media-grid.js`. This will be way more useful in later commits and help reduce churn and bloat in `media-views.js`. 
See #24716.

Built from https://develop.svn.wordpress.org/trunk@28992


git-svn-id: http://core.svn.wordpress.org/trunk@28780 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-04 02:18:14 +00:00