Commit Graph

23230 Commits

Author SHA1 Message Date
Andrew Nacin 031576d79e Introduce a img_caption_shortcode_width filter for controlling the inline style of the image caption shortcode.
props iandunn for the initial patch.
fixes #14380.

Built from https://develop.svn.wordpress.org/trunk@25444


git-svn-id: http://core.svn.wordpress.org/trunk@25365 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-14 20:45:09 +00:00
Andrew Nacin 0fbb5a32ef Don't allow critical scripts to be deregistered on wp-login.php, just as we do in the rest of the admin.
props atimmer.
fixes #25017.

Built from https://develop.svn.wordpress.org/trunk@25443


git-svn-id: http://core.svn.wordpress.org/trunk@25364 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-14 20:21:09 +00:00
Andrew Nacin 9414d6e40e Move to JSON for the plugin and theme update-check API endpoints. see #25311.
Built from https://develop.svn.wordpress.org/trunk@25442


git-svn-id: http://core.svn.wordpress.org/trunk@25363 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-14 19:58:09 +00:00
Andrew Nacin fef6081046 Move to JSON for three api.wordpress.org endpoints. see #25311.
Built from https://develop.svn.wordpress.org/trunk@25441


git-svn-id: http://core.svn.wordpress.org/trunk@25362 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-14 19:31:08 +00:00
Andrew Nacin a7b26bd103 Remove unnecessary printf(). fixes #25321.
Built from https://develop.svn.wordpress.org/trunk@25439


git-svn-id: http://core.svn.wordpress.org/trunk@25361 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-14 19:12:10 +00:00
Scott Taylor daa4b531e8 Fix several esoteric errors related to AJAX unit tests for comments:
* `wp_ajax_get_comments()` relies on the `$post_id` global - even though `$_POST['p']` is passed to every action in the test methods. If `$post_id` is still lingering in between tests and doesn't match `p` in the request, the cap check might pass while the queries for comments will blow up. I added `unset( $GLOBALS['post_id'] )` to `Tests_Ajax_GetComments::setUp()`.
* If the global `$post_id` is empty, but `$_REQUEST['p']` is not, `$post_id` is now set to `absint( $_REQUEST['p'] )` and sanity-checked in `wp_ajax_get_comments()`.
* `map_meta_cap()` always assumes that `get_comment()` succeeds when checking for the `edit_comment` cap. It doesn't. I added sanity checks in a few places where it will break early if `get_post()` or `get_comment()` are empty.
* `wp_update_comment()` always assumes `get_comment()` succeeds. It doesn't. I added a check for empty.

All AJAX unit tests run and pass in debug mode. All general unit tests pass against these changes.

Fixes #25282.


Built from https://develop.svn.wordpress.org/trunk@25438


git-svn-id: http://core.svn.wordpress.org/trunk@25360 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-14 18:36:09 +00:00
Dominik Schilling 32aff2db8a Add 'image' type/extensions to wp_ext2type() and make it case insensitive. props xparham. fixes #25176.
Built from https://develop.svn.wordpress.org/trunk@25437


git-svn-id: http://core.svn.wordpress.org/trunk@25359 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-14 14:34:09 +00:00
Dion Hulse bbd3312389 Account for Windows and CLI instances in wp_guess_url(). Props SergeyBiryukov. See #25317
Built from https://develop.svn.wordpress.org/trunk@25436


git-svn-id: http://core.svn.wordpress.org/trunk@25358 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-14 03:43:10 +00:00
Sergey Biryukov bc1c732a16 Inline documentation for hooks in wp-admin/export.php.
props mordauk.
see #25229.
Built from https://develop.svn.wordpress.org/trunk@25435


git-svn-id: http://core.svn.wordpress.org/trunk@25357 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-14 01:02:10 +00:00
Sergey Biryukov a55d3abd5f Inline documentation for hooks in wp-admin/includes/comment.php.
props mordauk.
see #25229.
Built from https://develop.svn.wordpress.org/trunk@25434


git-svn-id: http://core.svn.wordpress.org/trunk@25356 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-14 01:01:08 +00:00
Scott Taylor 5df8338e0a Fix some undefined index notices related to Comment unit tests:
* There are several places where a `$_POST` index was unchecked before setting a variable
* In `wp_notify_postauthor()`, `$comment` was being returned null, but its properties were being accessed.
* In `check_ajax_referer()`, 3 different values can be checked for nonce on `$_REQUEST`, but only 1 had an `isset()`

See #25282.


Built from https://develop.svn.wordpress.org/trunk@25433


git-svn-id: http://core.svn.wordpress.org/trunk@25355 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-13 22:18:08 +00:00
Scott Taylor e8c656a045 * Avoid notices in `tests/ajax/Autosave` by bailing early when `get_post()` returns nothing.
* Check for the existence of `$_POST['catslist']` before using it in `wp_ajax_autosave()`.

See #25282.


Built from https://develop.svn.wordpress.org/trunk@25430


git-svn-id: http://core.svn.wordpress.org/trunk@25354 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-13 21:22:11 +00:00
Sergey Biryukov a93aa0cb5c Inline documentation for hooks in wp-includes/author-template.php.
props Frank Klein.
see #25229.
Built from https://develop.svn.wordpress.org/trunk@25429


git-svn-id: http://core.svn.wordpress.org/trunk@25353 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-13 19:25:10 +00:00
Sergey Biryukov 7407bd1946 Inline documentation for get_comment_reply_link() and 'comment_reply_link' filter.
props DrewAPicture.
fixes #25310.
Built from https://develop.svn.wordpress.org/trunk@25428


git-svn-id: http://core.svn.wordpress.org/trunk@25352 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-13 19:20:09 +00:00
Dion Hulse dd8e15f612 Upgrader: Allow plugins to short-circuit the package download. Props rmccue and DrewAPicture. Fixes #22378
Built from https://develop.svn.wordpress.org/trunk@25427


git-svn-id: http://core.svn.wordpress.org/trunk@25351 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-13 12:53:08 +00:00
Sergey Biryukov 680a7a596d Avoid a PHP warning in network admin if a constant corresponding to a drop-in is not defined. fixes #25301.
Built from https://develop.svn.wordpress.org/trunk@25425


git-svn-id: http://core.svn.wordpress.org/trunk@25350 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-13 09:37:10 +00:00
Sergey Biryukov 4502b65ac0 Inline documentation for hooks in wp-admin/ms-delete-site.php.
props NikV.
see #25229.
Built from https://develop.svn.wordpress.org/trunk@25424


git-svn-id: http://core.svn.wordpress.org/trunk@25349 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-13 09:11:09 +00:00
Sergey Biryukov c227a3d78a Inline documentation for hooks in wp-includes/shortcodes.php.
props natejacobs.
see #25229.
Built from https://develop.svn.wordpress.org/trunk@25423


git-svn-id: http://core.svn.wordpress.org/trunk@25348 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-13 09:02:09 +00:00
Dion Hulse 89682d2013 WordPress Core Automatic Updates: Pass the Filesystem path as $context to request_filesystem_credentials(). See #22704
Built from https://develop.svn.wordpress.org/trunk@25422


git-svn-id: http://core.svn.wordpress.org/trunk@25347 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-13 06:53:09 +00:00
Dion Hulse 4678d33216 WordPress Core Automatic Updates: Add the first slice of Automatic Upgrades, This is presently disabled, and requires a filter to enable ( 'auto_upgrade_core' ). See #22704
Built from https://develop.svn.wordpress.org/trunk@25421


git-svn-id: http://core.svn.wordpress.org/trunk@25346 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-13 06:19:12 +00:00
Sergey Biryukov 533519086e Better alignment for wp_prepare_revisions_for_js() inline docs. see #25283.
Built from https://develop.svn.wordpress.org/trunk@25420


git-svn-id: http://core.svn.wordpress.org/trunk@25345 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-12 23:15:10 +00:00
Sergey Biryukov b01adf9615 Inline documentation fixes and additions for wp-admin/revision.php and wp-admin/includes/revision.php.
props adamsilverstein.
see #25283.
Built from https://develop.svn.wordpress.org/trunk@25419


git-svn-id: http://core.svn.wordpress.org/trunk@25344 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-12 22:59:08 +00:00
Lance Willett 77614b547f Twenty Fourteen: let authors customize the green "accent" color by changing to a different hex value in the Customizer. Props celloexpressions.
Also add an ID attribute to all `style` elements.

See #25220.
Built from https://develop.svn.wordpress.org/trunk@25418


git-svn-id: http://core.svn.wordpress.org/trunk@25343 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-12 22:06:09 +00:00
Lance Willett b94a54be45 Twenty Fourteen: prefix Genericons enqueue handle so that the theme uses the its own version of the font CSS. Fixes a few display issues when plugins like Jetpack enqueue a different version of Genericons. See #25085.
Built from https://develop.svn.wordpress.org/trunk@25417


git-svn-id: http://core.svn.wordpress.org/trunk@25342 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-12 21:45:08 +00:00
Andrew Nacin 52feff7a75 Clear all transients (regardless of expiration) on all database upgrades. see #20316.
Built from https://develop.svn.wordpress.org/trunk@25416


git-svn-id: http://core.svn.wordpress.org/trunk@25341 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-12 21:14:10 +00:00
Andrew Nacin e6bf2a293f Add populate_network_meta filter to populate_network().
props jeremyfelt.
fixes #25020.

Built from https://develop.svn.wordpress.org/trunk@25414


git-svn-id: http://core.svn.wordpress.org/trunk@25340 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-12 20:49:09 +00:00
Andrew Nacin 717ec20ac7 Fix comma placement in [25179].
props gradyetc.
see #15004, fixes #25298.

Built from https://develop.svn.wordpress.org/trunk@25413


git-svn-id: http://core.svn.wordpress.org/trunk@25339 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-12 20:16:11 +00:00
Helen Hou-Sandí 321268ba9d No space between // and duplicate_hook. see #25229
Built from https://develop.svn.wordpress.org/trunk@25412


git-svn-id: http://core.svn.wordpress.org/trunk@25338 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-12 18:57:10 +00:00
Helen Hou-Sandí bbb18589c0 Inline docs for hooks in `wp-admin/options-writing.php`. props siobhyb. see #25229.
Built from https://develop.svn.wordpress.org/trunk@25411


git-svn-id: http://core.svn.wordpress.org/trunk@25337 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-12 18:53:09 +00:00
Helen Hou-Sandí e9d72209f1 Inline docs for hooks in `wp-includes/nav-menu-template.php`. props Faison. see #25229.
Built from https://develop.svn.wordpress.org/trunk@25410


git-svn-id: http://core.svn.wordpress.org/trunk@25336 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-12 18:48:09 +00:00
Lance Willett 5214954488 Twenty Fourteen: fix comment for `twentyfourteen_excerpt_length()`, props SergeyBiryukov. Fixes #25297.
Built from https://develop.svn.wordpress.org/trunk@25406


git-svn-id: http://core.svn.wordpress.org/trunk@25335 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-12 17:44:10 +00:00
Scott Taylor acf3ee37e3 Fix the failing `Tests_Link::test_wp_get_shortlink()` assertion:
* `wp_get_shortlink()` was firing a notice when reading `$post->ID` while `$post` was null in some cases
* Before the assertions that assume `$GLOBALS['post']` is not set, call `unset( $GLOBALS['post'] );` - there was global spillage from other tests

See #25282.



Built from https://develop.svn.wordpress.org/trunk@25404


git-svn-id: http://core.svn.wordpress.org/trunk@25334 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-12 17:30:10 +00:00
Helen Hou-Sandí 0758df9758 Add file size to attachment publish meta box. props desrosj. fixes #25170.
Built from https://develop.svn.wordpress.org/trunk@25403


git-svn-id: http://core.svn.wordpress.org/trunk@25333 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-12 15:10:09 +00:00
Andrew Nacin 4542e678d2 Return false from wp_get_original_referer() if it is called before wp_validate_redirect() is defined.
see #25294.

Built from https://develop.svn.wordpress.org/trunk@25400


git-svn-id: http://core.svn.wordpress.org/trunk@25331 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-12 13:36:09 +00:00
Andrew Nacin 46611d4282 Return false from wp_get_referer() if it is called before wp_validate_redirect() is defined.
see #25294.

Built from https://develop.svn.wordpress.org/trunk@25399


git-svn-id: http://core.svn.wordpress.org/trunk@25330 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-12 13:33:09 +00:00
Scott Taylor 13d5ff7090 * Fill in undefined var in `Tests_Option_BlogOption`
* Add `defined()` check for `BLOGSUPLOADDIR`
* Suppress deprecated function notices for `is_blog_user()` and `get_dashboard_blog()`
* Check existence of `$user` in `wpmu_log_new_registrations()` before arbitrarily making a database query

Fixes all notices in multisite unit tests.

See #25282.


Built from https://develop.svn.wordpress.org/trunk@25397


git-svn-id: http://core.svn.wordpress.org/trunk@25328 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-12 07:17:11 +00:00
Dion Hulse 641d3b2560 Fix wp_guess_url() to work in every scenario I could find, allows us to use it to determine the correct path to the WordPress Site URL before installation for install.php and setup-config.php redirects. Fixes #24480 Fixes #16884
Built from https://develop.svn.wordpress.org/trunk@25396


git-svn-id: http://core.svn.wordpress.org/trunk@25327 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-12 06:57:09 +00:00
Scott Taylor 6744355f70 * Add `isset()` checks all over `WP_User_Query::prepare_query()` and `WP_User_Query::query()`. When a `WP_User_Query` instance is constructed without passing args, no query vars are filled in, thus `$qv` doesn't contain most of the expected indices.
* Suppress an undefined index notice in `tests/user/query.php`

Fixes #25292.
See #25282.


Built from https://develop.svn.wordpress.org/trunk@25392


git-svn-id: http://core.svn.wordpress.org/trunk@25326 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-12 06:25:09 +00:00
Scott Taylor 71430cd29a Add sanity checks to `get_*_template()` functions to ensure that the return value of `get_queried_object()` is compatible with the assumed context.
Fixes #25291.
See #25282.


Built from https://develop.svn.wordpress.org/trunk@25386


git-svn-id: http://core.svn.wordpress.org/trunk@25325 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-12 05:32:10 +00:00
Dion Hulse 93f7757c24 When the WordPress files are in a subdirectory, correctly redirect the user to the setup-config.php page from the parent directories index.php. Fixes #24480
Built from https://develop.svn.wordpress.org/trunk@25385


git-svn-id: http://core.svn.wordpress.org/trunk@25324 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-12 05:13:08 +00:00
Scott Taylor 072b0f2128 Use `reset()` to access the first element of an array, don't assume there is an item at index `0`.
See #25282.


Built from https://develop.svn.wordpress.org/trunk@25384


git-svn-id: http://core.svn.wordpress.org/trunk@25323 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-12 05:09:09 +00:00
Sergey Biryukov f2391051c7 Inline documentation for hooks in wp-admin/options.php.
props siobhyb.
see #25229.
Built from https://develop.svn.wordpress.org/trunk@25372


git-svn-id: http://core.svn.wordpress.org/trunk@25322 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-12 03:44:08 +00:00
Helen Hou-Sandí 8359c66176 Indicate that the fall-through in `is_serialized()` is deliberate. fixes #24023.
Built from https://develop.svn.wordpress.org/trunk@25371


git-svn-id: http://core.svn.wordpress.org/trunk@25321 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-12 03:41:09 +00:00
Sergey Biryukov b533a2bd94 Consistently call skin methods in WP_Upgrader. fixes #25254.
Built from https://develop.svn.wordpress.org/trunk@25370


git-svn-id: http://core.svn.wordpress.org/trunk@25320 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-12 02:43:10 +00:00
Sergey Biryukov 0232d1cfd8 Fix invalid markup when searching for installed themes. fixes #25288.
Built from https://develop.svn.wordpress.org/trunk@25369


git-svn-id: http://core.svn.wordpress.org/trunk@25319 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-12 00:03:10 +00:00
Scott Taylor 6fb5ef65c0 Avoid a notice by casting `$args['rewrite']` to `array()` before adding a `slug` property and running `array_merge()`.
Fixes #23668.


Built from https://develop.svn.wordpress.org/trunk@25351


git-svn-id: http://core.svn.wordpress.org/trunk@25313 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-11 17:17:11 +00:00
Dion Hulse fc1fc39a89 Fix the action that `set_site_transient()` fires so as not to include the private option prefix. This brings set_site_transient() back in line with it's documented behaviour, and the behaviour of all other transient functions. Fixes #25213
Built from https://develop.svn.wordpress.org/trunk@25350


git-svn-id: http://core.svn.wordpress.org/trunk@25312 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-11 08:46:10 +00:00
Dion Hulse 26ebfca466 Make use of the mbstring.func_overload helper functions in WP_Filesystem so byte lengths are properly determined. See #25259 Fixes #25237
Built from https://develop.svn.wordpress.org/trunk@25349


git-svn-id: http://core.svn.wordpress.org/trunk@25311 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-11 08:27:10 +00:00
Dion Hulse c93eb27bb2 Switch WP_HTTP over to using the mbstring.func_overload helper functions. This change moves the check from within the Streaming-handling function to wrap the individual request, this fixes it for both cURL and Streams and any future changes to the transports which use strlen() on binary data. See #25259 See #16057
Built from https://develop.svn.wordpress.org/trunk@25348


git-svn-id: http://core.svn.wordpress.org/trunk@25310 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-11 08:13:10 +00:00
Dion Hulse 83ebc727e8 Switch unzip_file() over to using the mbstring.func_override helper functions. See #25259
Built from https://develop.svn.wordpress.org/trunk@25347


git-svn-id: http://core.svn.wordpress.org/trunk@25309 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-11 08:09:08 +00:00