Sergey Biryukov
067ee8c476
Remove inaccurate part of {$taxonomy}_add_form_fields action description.
...
props joostdekeijzer.
fixes #31052 .
Built from https://develop.svn.wordpress.org/trunk@31247
git-svn-id: http://core.svn.wordpress.org/trunk@31228 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-19 15:31:23 +00:00
Drew Jaynes
d95586e943
Add missing summaries and descriptions for various functions in wp-admin/includes/upgrade.php.
...
Also generally improve existing parameter, return, and other documentation in various function DocBlocks.
Props morganestes.
Fixes #30825 .
Built from https://develop.svn.wordpress.org/trunk@31246
git-svn-id: http://core.svn.wordpress.org/trunk@31227 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-19 09:15:22 +00:00
Drew Jaynes
e0b3db1e09
Remove a stray period introduced in [31242].
...
Props SergeyBiryukov.
See #31048 .
Built from https://develop.svn.wordpress.org/trunk@31245
git-svn-id: http://core.svn.wordpress.org/trunk@31226 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-19 08:47:24 +00:00
Drew Jaynes
d41e669efe
Ensure the correct list of default tabs for the Plugin Install screen are documented.
...
Props stevenkword.
Fixes #31017 .
Built from https://develop.svn.wordpress.org/trunk@31244
git-svn-id: http://core.svn.wordpress.org/trunk@31225 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-19 08:44:22 +00:00
Drew Jaynes
3a0726d7b8
Add more complete documentation for parameters, globals, and return values to the DocBlocks for `remove_shortcode()`, `shortcode_exists()`, and `do_shortcode()`.
...
Props SergeyBiryukov.
Fixes #31048 .
Built from https://develop.svn.wordpress.org/trunk@31243
git-svn-id: http://core.svn.wordpress.org/trunk@31224 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-19 08:40:24 +00:00
Drew Jaynes
a8e2ae2117
Ensure both parameters and the return for `has_shortcode()` are fully documented.
...
Props cais, SergeyBiryukov
See #31048 .
Built from https://develop.svn.wordpress.org/trunk@31242
git-svn-id: http://core.svn.wordpress.org/trunk@31223 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-19 08:36:25 +00:00
Sergey Biryukov
eff3b8925b
Display correct title in Archives widget if the type of archive was changed using the 'widget_archives_dropdown_args' filter.
...
props floriansimeth for initial patch.
fixes #31024 .
Built from https://develop.svn.wordpress.org/trunk@31241
git-svn-id: http://core.svn.wordpress.org/trunk@31222 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-19 08:26:24 +00:00
Sergey Biryukov
eedb4857ba
Strip HTML tags when searching for installed themes.
...
props enej, SergeyBiryukov, obenland.
fixes #27561 .
Built from https://develop.svn.wordpress.org/trunk@31240
git-svn-id: http://core.svn.wordpress.org/trunk@31221 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-18 20:40:23 +00:00
Sergey Biryukov
247cdad571
attachment_url_to_postid() should always return an integer.
...
props nathan_dawson, ashfame.
fixes #31044 .
Built from https://develop.svn.wordpress.org/trunk@31239
git-svn-id: http://core.svn.wordpress.org/trunk@31220 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-18 20:33:23 +00:00
Drew Jaynes
bee439858b
Minor fix for inline doc syntax in a changelog entry for `wp_get_object_terms()`.
...
See #28688 .
Built from https://develop.svn.wordpress.org/trunk@31238
git-svn-id: http://core.svn.wordpress.org/trunk@31219 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-18 19:05:22 +00:00
Boone Gorges
a639c5905e
Add `@since` annotation for 'orderby' values introduced in [31236].
...
See #28688 .
Built from https://develop.svn.wordpress.org/trunk@31237
git-svn-id: http://core.svn.wordpress.org/trunk@31218 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-18 19:03:24 +00:00
Boone Gorges
42ec13030c
Additional 'orderby' values for `wp_get_object_terms()`.
...
Adds support for ordering by 'taxonomy', 'term_taxonomy_id', and 'parent'.
Props ChriCo.
Fixes #28688 .
Built from https://develop.svn.wordpress.org/trunk@31236
git-svn-id: http://core.svn.wordpress.org/trunk@31217 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-18 18:57:23 +00:00
Andrew Ozz
00436f6886
TinyMCE: fix vertical positioning of the image toolbar when there are several instances of the editor. Props avryl, fixes #31028 .
...
Built from https://develop.svn.wordpress.org/trunk@31235
git-svn-id: http://core.svn.wordpress.org/trunk@31216 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-18 17:56:23 +00:00
Sergey Biryukov
7d2ec003da
Customizer: Replicate behavior from options-reading.php and hide front page options if there are no pages.
...
props Clorith.
fixes #27630 .
Built from https://develop.svn.wordpress.org/trunk@31234
git-svn-id: http://core.svn.wordpress.org/trunk@31215 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-18 06:01:24 +00:00
Boone Gorges
9c99ff8fe3
Add unit tests for 'orderby' and 'order' param of `wp_get_object_terms()`.
...
Built from https://develop.svn.wordpress.org/trunk@31233
git-svn-id: http://core.svn.wordpress.org/trunk@31214 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-17 20:39:44 +00:00
Boone Gorges
a245838c42
Correct `wp_get_object_terms()` documentation.
...
The 'orderby' parameter accepts a number of values that have never been
properly documented.
Built from https://develop.svn.wordpress.org/trunk@31232
git-svn-id: http://core.svn.wordpress.org/trunk@31213 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-17 20:39:23 +00:00
Boone Gorges
03512a2a02
Standardize the docblock for `wp_get_object_terms()`.
...
The enumeration of the `$args` parameter has been moved from the long
description to an array hash associated with the proper `@param` attribute.
Built from https://develop.svn.wordpress.org/trunk@31231
git-svn-id: http://core.svn.wordpress.org/trunk@31212 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-17 20:09:47 +00:00
Boone Gorges
a917a904bd
Move `wp_get_object_terms()` tests into their own file.
...
See #26999 .
Built from https://develop.svn.wordpress.org/trunk@31230
git-svn-id: http://core.svn.wordpress.org/trunk@31211 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-17 20:09:26 +00:00
Sergey Biryukov
34d06ee6b7
Add a changelog entry for the new parameter added in [31228].
...
props DrewAPicture.
fixes #31015 .
Built from https://develop.svn.wordpress.org/trunk@31229
git-svn-id: http://core.svn.wordpress.org/trunk@31210 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-17 17:31:23 +00:00
Sergey Biryukov
4e90a18c7c
Pass $force_reauth value to the 'login_url' filter.
...
props jfarthing84, MikeHansenMe.
fixes #31015 .
Built from https://develop.svn.wordpress.org/trunk@31228
git-svn-id: http://core.svn.wordpress.org/trunk@31209 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-17 17:20:23 +00:00
Sergey Biryukov
8b50aef14c
Customizer: Make "Search widgets" input sticky.
...
props celloexpressions.
fixes #30751 .
Built from https://develop.svn.wordpress.org/trunk@31227
git-svn-id: http://core.svn.wordpress.org/trunk@31208 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-17 13:15:23 +00:00
Sergey Biryukov
823ab1efdf
Customizer: Fix form tag replacement in WP_Customize_Widgets::get_widget_control() after [31200].
...
see #30126 .
Built from https://develop.svn.wordpress.org/trunk@31226
git-svn-id: http://core.svn.wordpress.org/trunk@31207 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-17 13:11:23 +00:00
Sergey Biryukov
768624cb99
Use the site's local time to create the first post during installation.
...
props extendwings.
fixes #29296 .
Built from https://develop.svn.wordpress.org/trunk@31225
git-svn-id: http://core.svn.wordpress.org/trunk@31206 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-17 10:07:23 +00:00
Sergey Biryukov
b87b8f2bb3
Introduce has_header_image() to check whether a header image is set.
...
props GunGeekATX, voldemortensen.
fixes #16268 .
Built from https://develop.svn.wordpress.org/trunk@31224
git-svn-id: http://core.svn.wordpress.org/trunk@31205 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-17 06:34:23 +00:00
Andrew Ozz
9d3ea188d7
Add support for IE conditional comments for WP_Scripts to match the functionality of WP_Styles, including unit tests. Props filosofo, aaroncampbell, ethitter, georgestephanis, valendesigns. Fixes #16024 .
...
Built from https://develop.svn.wordpress.org/trunk@31223
git-svn-id: http://core.svn.wordpress.org/trunk@31204 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-17 01:37:22 +00:00
Andrew Ozz
f609d9d89a
TinyMCE: add breaking out of blockquotes by pressing Enter twice. Togging blockquote on|off with the button and the shortcut is unchanged. Props avryl, fixes #23110 .
...
Built from https://develop.svn.wordpress.org/trunk@31222
git-svn-id: http://core.svn.wordpress.org/trunk@31203 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 23:36:22 +00:00
Scott Taylor
5458a4da21
`wp_set_object_terms()` takes `$taxonomy` as a string. Update `@param`.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31221
git-svn-id: http://core.svn.wordpress.org/trunk@31202 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 23:27:25 +00:00
Scott Taylor
02a1f35ac8
Fix some internal types that are passed to functions to avoid changing the acceptable types passed as arguments to those functions:
...
* In `WP_Importer->is_user_over_quota()`, the default value for the first argument for `upload_is_user_over_quota()` is `true`. Don't bother passing `1`.
* When calling `submit_button()` with no `$name`, pass empty string instead of `false`.
* The default value for the 2nd argument to `get_edit_post_link()` is `'display'`. Because PHP is PHP, passing `true` is the same as passing `'display'` or nothing. Don't bother passing `true`.
* In `WP_User_Meta_Session_Tokens::drop_sessions()`, pass `0` instead of `false` to `delete_metadata()` as the value for `$object_id`, which expects an int.
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31220
git-svn-id: http://core.svn.wordpress.org/trunk@31201 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 22:51:21 +00:00
Scott Taylor
eeda68bbda
Fix some erroneous `@param` annotations.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31219
git-svn-id: http://core.svn.wordpress.org/trunk@31200 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 22:44:25 +00:00
Boone Gorges
fffd8c8e2d
In `get_edit_term_link()`, default to a valid `$object_type`.
...
The $object_type param is used to set the 'post_type' query var, which
determines the post type menu that will be expanded when clicking through to
the term edit page. Not all taxonomies are associated with Posts, so it makes
sense to default to a post_type that the taxonomy is actually associated with.
Props DzeryCZ, juliobox.
Fixes #29251 .
Built from https://develop.svn.wordpress.org/trunk@31218
git-svn-id: http://core.svn.wordpress.org/trunk@31199 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 21:37:23 +00:00
Scott Taylor
0f6d0b84d1
Remove unused local vars in `delete_plugins()`, `delete_theme()`, `WP_Date_Query->validate_date_values()`, `global_terms()`, and `WP_Text_Diff_Renderer_Table->_changed()`.
...
This will clear out the "Unused Code" label in the next Scrutinizer report.
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31217
git-svn-id: http://core.svn.wordpress.org/trunk@31198 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 21:19:22 +00:00
Scott Taylor
7c5038feb6
Calling `->chown()` and `->chgrp()` in `WP_Filesystem_ftpsockets` produces no side-effects. Remove the calls. `->chgrp()` is defined in the super class, and does nothing, can be removed from the child class.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31216
git-svn-id: http://core.svn.wordpress.org/trunk@31197 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 21:10:23 +00:00
Scott Taylor
6fa7021d62
Calling `->chown()` and `->chgrp()` in `WP_Filesystem_FTPext` produces no side-effects. Remove the calls. `->chgrp()` is defined in the super class, and does nothing, can be removed from the child class.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31215
git-svn-id: http://core.svn.wordpress.org/trunk@31196 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 21:07:24 +00:00
Lance Willett
f6fd49b357
Twenty Fifteen: keep sub-menus open when visiting sub-menu pages, to show context when navigating a site.
...
Props jartes, fixes #30722 .
Built from https://develop.svn.wordpress.org/trunk@31214
git-svn-id: http://core.svn.wordpress.org/trunk@31195 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 19:17:22 +00:00
Scott Taylor
b8dd1f9c69
By initializing this array before a loop, Scrutinizer reports 0 (zero) "Coding Style" errors.
...
There are plenty of other kinds of errors, but this label will be cleared out.
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31213
git-svn-id: http://core.svn.wordpress.org/trunk@31194 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 19:13:23 +00:00
Scott Taylor
bc55996a0b
`@param` cleanup:
...
* `get_metadata()` will return literally anything, needs to be `mixed`
* `wp()` and `WP_Query::__construct()` no longer just take a query string
* Clarify a few others
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31212
git-svn-id: http://core.svn.wordpress.org/trunk@31193 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 19:03:23 +00:00
Scott Taylor
cde4c83091
[31210] broke Supportflow on dotorg, which declares these methods as `protected`. Switch to `protected` for the noop methods. The subclasses can make them more visible using `public`.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31211
git-svn-id: http://core.svn.wordpress.org/trunk@31192 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 18:37:24 +00:00
Scott Taylor
3fb283db0a
Add 2 noop methods to `WP_List_Table`: `->column_default()` and `->column_cb()`.
...
`WP_List_Table` is essentially an `abstract` class. Some of its methods throw `die()` warnings if they aren't overridden in a child class.
These noop methods wouldn't be `abstract`, because they are not required in subclasses. However, `WP_List_Table` can call these methods in its own method, `->single_row_columns()`, whether a subclass defined them or not.
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31210
git-svn-id: http://core.svn.wordpress.org/trunk@31191 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 17:42:22 +00:00
Scott Taylor
895794f74d
In `WP_Filesystem_Base` subclasses that set `$wp_base`, remove this dead code.
...
Unused since [8009] - "Make WP_Filesystem work with new directory constants"
There is currently no declared field and no `@property` annotation.
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31209
git-svn-id: http://core.svn.wordpress.org/trunk@31190 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 17:23:22 +00:00
Scott Taylor
b29a20b90a
`WP_Filesystem_Base` should declare `$errors` and `$options` as fields for use by subclasses.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31208
git-svn-id: http://core.svn.wordpress.org/trunk@31189 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 17:10:43 +00:00
Boone Gorges
35f3f7bf63
Bail out of hierarchy loops in `_get_term_children()`.
...
This prevents infinite loops that lead to PHP nesting limit fatal errors.
Props boonebgorges, sgrant.
Fixes #24461 .
Built from https://develop.svn.wordpress.org/trunk@31207
git-svn-id: http://core.svn.wordpress.org/trunk@31188 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 17:10:22 +00:00
Boone Gorges
991bfdebc1
Bail out of hierarchy loops in `_pad_term_counts()`.
...
Taxonomy hierarchy loops should not occur naturally, but when they do, the
logic of `_pad_term_counts()` could result in infinite loops, leading to
timeouts. We avoid this by breaking when a loop is detected.
Fixes #20635 .
Built from https://develop.svn.wordpress.org/trunk@31206
git-svn-id: http://core.svn.wordpress.org/trunk@31187 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 16:46:23 +00:00
Scott Taylor
86f29795a4
Add `<s>` to `$allowedtags` in KSES.
...
From https://developer.mozilla.org/en-US/docs/Web/HTML/Element/s :
"The <strike> element, alter ego of the <s> element is obsolete and should not be used on Web sites any more."
`<strike>` shall remain for BC, but `<s>` should not be stripped from the author (et al) role's HTML input.
Props paulschreiber.
Fixes #30954 .
Built from https://develop.svn.wordpress.org/trunk@31205
git-svn-id: http://core.svn.wordpress.org/trunk@31186 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 16:07:23 +00:00
Scott Taylor
5f9a800110
In `comment_form()`, add the HTML5 `required` attribute next to `aria-required` in fields that utilize it.
...
Props MMN-o.
Fixes #24732 .
Built from https://develop.svn.wordpress.org/trunk@31204
git-svn-id: http://core.svn.wordpress.org/trunk@31185 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 15:56:23 +00:00
Boone Gorges
fb691a449b
In `paginate_links()`, don't override custom format arguments when setting up default 'add_args'.
...
Since 4.1 [29780], the default value of the 'add_args' argument in
`paginate_links()` has been determined by parsing the current URL. This change
had the side effect of overriding custom values of 'format' that changed the
pagination query var, with the result that plugins using `paginate_links()`
with a custom format generated the incorrect links unless explicitly
declaring 'add_args=false' to prevent the default values from overriding. We
fix this behavior by parsing URL query vars into the 'add_args' array only
after the explicit function params have been parsed, and by skipping the
current page's pagination query var when doing this parsing (to avoid the
override).
Props obenland.
Fixes #30831 for trunk.
Built from https://develop.svn.wordpress.org/trunk@31203
git-svn-id: http://core.svn.wordpress.org/trunk@31184 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 15:49:25 +00:00
Scott Taylor
3f8d8cec00
Add `@ignore` to `_wp_scripts_maybe_doing_it_wrong()`.
...
Props DrewAPicture for the thought leadership.
See #20513 .
Built from https://develop.svn.wordpress.org/trunk@31202
git-svn-id: http://core.svn.wordpress.org/trunk@31183 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 05:38:21 +00:00
Scott Taylor
60c285aa22
In `wp_ajax_parse_media_shortcode()`, don't require a global `$post` for all passed shortcodes.
...
`embed` is the only shortcode that requires a post ID. This will allow MCE views to work for `playlist`, `audio`, and `video` outside of the Edit Post screen.
See #30835 .
Built from https://develop.svn.wordpress.org/trunk@31201
git-svn-id: http://core.svn.wordpress.org/trunk@31182 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 05:19:22 +00:00
Scott Taylor
7f8b548df1
In HTML5, the `action` attribute is no longer required. Remove this attribute when empty.
...
The admin HTML is served with the HTML5 doctype.
"The action and formaction content attributes, if specified, must have a value that is a valid non-empty URL potentially surrounded by spaces."
http://www.w3.org/html/wg/drafts/html/master/forms.html#attr-fs-action
Props voldemortensen.
Fixes #30126 .
Built from https://develop.svn.wordpress.org/trunk@31200
git-svn-id: http://core.svn.wordpress.org/trunk@31181 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 04:16:24 +00:00
Gary Pendergast
d0c327443c
When a hyphen `-` or double hyphen `--` was at the start or the end of a string, it wasn't texturized correctly.
...
Fixes #31030
Built from https://develop.svn.wordpress.org/trunk@31199
git-svn-id: http://core.svn.wordpress.org/trunk@31180 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 03:54:24 +00:00
Helen Hou-Sandí
798439c273
Media: Prevent filter selects from jiggling when the spinner shows.
...
props valendesigns.
fixes #30725 for trunk.
Built from https://develop.svn.wordpress.org/trunk@31197
git-svn-id: http://core.svn.wordpress.org/trunk@31178 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 03:00:23 +00:00