0dc073e589
Editor: Only call should_load_block_editor_scripts_and_styles on admin screens
...
Do not call the should_load_block_editor_scripts_and_styles filter on non-admin
screens. This makes it less likely that one will accidentally call
get_current_screen() when it doesn't exist.
Follow-up to [49080].
Props noahtallen.
See #51330 .
Built from https://develop.svn.wordpress.org/trunk@49102
git-svn-id: http://core.svn.wordpress.org/trunk@48864 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-08 01:21:07 +00:00
5cee7eced0
Update jQuery step two:
...
- Add jquery-migrate.js v.3.3.1 to core and load it in debug mode when `SCRIPT_DEBUG` is true.
- Add jquery.min.js, update jquery.js to 3.5.1 non-minified. This should help when debugging.
- Rebuild jQuery UI 1.12.1 and add it to core.
- Fix/adjust tests to match the above changes.
See #50564 .
Built from https://develop.svn.wordpress.org/trunk@49101
git-svn-id: http://core.svn.wordpress.org/trunk@48863 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-07 16:33:25 +00:00
0c64f0c663
Build/Test Tools: Ensure arguments are passed correctly for `test:php-composer` commands.
...
Follow-up to [49099].
Props swissspidy.
See #51456 .
Built from https://develop.svn.wordpress.org/trunk@49100
git-svn-id: http://core.svn.wordpress.org/trunk@48862 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-07 13:21:04 +00:00
6af2d1f4a5
Build/Test Tools: Add NPM script for using the Composer installed version of PHPUnit.
...
The `test:php` NPM script runs the PHP test suite using the system installed version of PHPUnit. In some cases, the version of PHPUnit installed through Composer may be preferred.
Currently, this is true when running the test suite using PHP 8. In order to add support for PHP 8 while maintaining compatibility for PHP 5.6.20, PHPUnit 7.x must be used. But, some modifications are required to be compatible with PHP 8 (see [49037], [48957]).
This change introduces the `test:php-composer` NPM script, which will run the test suite using the composer installed version.
Props desrosj, SergeyBiryukov.
Fixes #51456 .
Built from https://develop.svn.wordpress.org/trunk@49099
git-svn-id: http://core.svn.wordpress.org/trunk@48861 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-07 13:10:05 +00:00
520be16b6e
Docs: Add missing `@return` tag for `wp_xmlrpc_server::_is_greater_than_one()`.
...
Props ankitmaru.
Fixes #51465 .
Built from https://develop.svn.wordpress.org/trunk@49098
git-svn-id: http://core.svn.wordpress.org/trunk@48860 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-07 11:02:03 +00:00
a6ef541df0
Coding Standards: Add missing space in `js/_enqueues/lib/comment-reply.js`.
...
Props saqibameen, hareesh-pillai, imath, davidbaumwald.
Fixes #43907 .
Built from https://develop.svn.wordpress.org/trunk@49097
git-svn-id: http://core.svn.wordpress.org/trunk@48859 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-07 10:38:08 +00:00
aef2b539cd
Docs: Correct `@since` version for `add_allowed_options()`.
...
Follow-up to [48121].
Props coffee2code.
Fixes #51450 .
Built from https://develop.svn.wordpress.org/trunk@49096
git-svn-id: http://core.svn.wordpress.org/trunk@48858 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-06 15:55:05 +00:00
2670a6ad14
Docs: Synchronize descriptions of some query functions and their counterpart methods in `WP` and `WP_Query` classes:
...
* `set_query_var()`
* `get_query_var()`
* `get_queried_object()`
* `get_queried_object_id()`
Switch to third-person singular verbs, per the documentation standards.
See #50768 , #42783 .
Built from https://develop.svn.wordpress.org/trunk@49095
git-svn-id: http://core.svn.wordpress.org/trunk@48857 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-06 08:59:04 +00:00
088aa1e864
Docs: Improve set_query_var() inline docs.
...
Makes the inline docs for set_query_var() consistent with the inline docs for
get_query_var().
See #42783 .
Props stevenlinx, markparnell.
Built from https://develop.svn.wordpress.org/trunk@49094
git-svn-id: http://core.svn.wordpress.org/trunk@48856 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-06 05:40:11 +00:00
274cb9718d
Editor: Rename _should_load_block_editor_scripts_and_styles to wp_should_load_block_editor_scripts_and_styles
...
Follow-up to [49080].
Props zieladam, frank-klein.
See #51330 .
Built from https://develop.svn.wordpress.org/trunk@49093
git-svn-id: http://core.svn.wordpress.org/trunk@48855 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-06 04:18:10 +00:00
dc7bda9620
Docs: Add brackets to function names in some `@see` tags, for consistency.
...
Props ravipatel, davidbaumwald.
Fixes #51441 .
Built from https://develop.svn.wordpress.org/trunk@49092
git-svn-id: http://core.svn.wordpress.org/trunk@48854 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-05 14:03:02 +00:00
bea55db921
Docs: Add missing `@return` tag to `Language_Pack_Upgrader::check_package()`.
...
Synchronize documentation of the `::check_package()` method between `Plugin_Upgrader`, `Theme_Upgrader`, and `Language_Pack_Upgrader`.
Props ankitmaru, mukesh27, desrosj.
Fixes #51448 .
Built from https://develop.svn.wordpress.org/trunk@49091
git-svn-id: http://core.svn.wordpress.org/trunk@48853 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-05 13:44:11 +00:00
1651342d2b
Privacy: Improve clarity of privacy error strings.
...
Primarily this adds "user privacy" to the strings for privacy requests, so they are more easily distinguished from other system actions within logs.
Props garrett-eclipse, carike, birgire.
Fixes #51351 .
Built from https://develop.svn.wordpress.org/trunk@49090
git-svn-id: http://core.svn.wordpress.org/trunk@48852 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-04 03:23:09 +00:00
0f13b2c268
Docs: Add `@since` notes for the `$id` parameter of REST API search controller accepting a string.
...
Follow-up to [49088].
See #51131 .
Built from https://develop.svn.wordpress.org/trunk@49089
git-svn-id: http://core.svn.wordpress.org/trunk@48851 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-03 01:22:11 +00:00
e9b5b1a5bc
REST API: Allow for string ids in the search controller.
...
Previously, the search controller infrastructure required that the id property was an integer. This prevents data models that use a string id from utilizing the search infrastructure.
This commit lifts the restraint that search handlers return integer ids. This will allow for the Post Formats search handler coming in 5.6 to use slugs instead of creating fake ids.
Props stoyangeorgiev.
Fixes #51131 .
Built from https://develop.svn.wordpress.org/trunk@49088
git-svn-id: http://core.svn.wordpress.org/trunk@48850 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-02 17:47:09 +00:00
f426a1fa04
Media: clear inputs after cropping on attachment details screen.
...
Clear the crop selection input fields after the crop action is complete.
Fixes unexpected re-cropping behavior if the crop button was clicked more than once.
Props davidbinda.
Fixes #30155 .
Built from https://develop.svn.wordpress.org/trunk@49087
git-svn-id: http://core.svn.wordpress.org/trunk@48849 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-02 15:11:06 +00:00
f880f14080
Coding Standards: Make checks for an empty post in `wp-includes/post.php` more consistent.
...
See #50767 .
Built from https://develop.svn.wordpress.org/trunk@49086
git-svn-id: http://core.svn.wordpress.org/trunk@48848 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-02 12:37:06 +00:00
b6641140fd
Tests: Fix a linting error in a test.
...
See #50679 .
Built from https://develop.svn.wordpress.org/trunk@49085
git-svn-id: http://core.svn.wordpress.org/trunk@48847 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-01 21:44:09 +00:00
b108d4db71
Media: Don't unnecessarily check for a valid attachment before getting meta.
...
This makes `wp_get_attachment_metadata()` run significantly faster. See ticket for benchmarking.
Props Tkama, donmhico.
Fixes #50679 .
Built from https://develop.svn.wordpress.org/trunk@49084
git-svn-id: http://core.svn.wordpress.org/trunk@48846 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-01 17:55:06 +00:00
e9d572f431
WP Date: Add timezone abbreviation to wp-date settings.
...
Props mkaz.
Fixes #50624 .
Built from https://develop.svn.wordpress.org/trunk@49083
git-svn-id: http://core.svn.wordpress.org/trunk@48845 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-01 17:43:08 +00:00
69b9b23c49
REST API: Support the patternProperties JSON Schema keyword.
...
Props yakimun.
Fixes #51024 .
Built from https://develop.svn.wordpress.org/trunk@49082
git-svn-id: http://core.svn.wordpress.org/trunk@48844 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-01 02:49:12 +00:00
0d52ba511c
Docs: Add missing `@since` entry for `_should_load_block_editor_scripts_and_styles()`.
...
Follow-up to [49080].
See #51330 .
Built from https://develop.svn.wordpress.org/trunk@49081
git-svn-id: http://core.svn.wordpress.org/trunk@48843 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-01 01:14:04 +00:00
96f963a2b9
Editor: Add should_load_block_editor_scripts_and_styles
...
Adds a new should_load_block_editor_scripts_and_styles filter which can be used
by plugins including Gutenberg to more precisely customise when block editor
scripts and styles should be loaded by script-loader.php. Previously, plugins
had to fiddle with $current_screen->is_block_editor().
Props zieladam.
See #51330 .
Built from https://develop.svn.wordpress.org/trunk@49080
git-svn-id: http://core.svn.wordpress.org/trunk@48842 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-01 00:39:04 +00:00
ca7063fd60
Script Loader: Update versions for MediaElement.js and related files.
...
Follow-up to [49070].
See #51315 .
Built from https://develop.svn.wordpress.org/trunk@49079
git-svn-id: http://core.svn.wordpress.org/trunk@48841 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-01 00:04:05 +00:00
1079647d30
Docs: Various docblock improvements related to user and site signup functionality.
...
See #50768
Built from https://develop.svn.wordpress.org/trunk@49078
git-svn-id: http://core.svn.wordpress.org/trunk@48840 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-09-30 21:54:07 +00:00
f7ba7c931c
Build/Test Tools: Remove PHP 8 from allowed failures.
...
With all known unit test issues now addressed, WordPress 5.6 aims to support PHP 8 as much as possible.
See #50913 , #50902 .
Built from https://develop.svn.wordpress.org/trunk@49077
git-svn-id: http://core.svn.wordpress.org/trunk@48839 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-09-30 16:05:06 +00:00
829fc28a93
Code Modernization: Ignore the `_multiwidget` property when collecting widget numbers in `WP_Customize_Manager::import_theme_starter_content()`.
...
PHP 8 changes the way string to number comparisons are performed: https://wiki.php.net/rfc/string_to_number_comparison
In particular, when calling `max()` on an array with numeric values and a non-numeric string, in PHP 8 the string is returned instead of a number.
For `::import_theme_starter_content()`, this resulted in retrieving the `_multiwidget` property instead of the maximum widget number for a particular type.
By explicitly ignoring the `_multiwidget` property, we make sure to retrieve the correct widget number value.
Follow-up to [48960], [49043].
See #50913 .
Built from https://develop.svn.wordpress.org/trunk@49076
git-svn-id: http://core.svn.wordpress.org/trunk@48838 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-09-30 15:46:08 +00:00
09570be924
Docs: Fix typos in some DocBlocks in `js/_enqueues/wp/api.js`.
...
Additionally, rename a variable for clarity.
Props mukesh27.
Fixes #51420 .
Built from https://develop.svn.wordpress.org/trunk@49075
git-svn-id: http://core.svn.wordpress.org/trunk@48837 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-09-30 13:54:06 +00:00
36c3a480c8
Build/Test Tools: Comment out the `xdebug` group test run for PHP 8 for now.
...
Xdebug supports PHP 8 only from version 3.0, which is not released yet.
Once Xdebug 3.0 is released and included in the Docker image, this should be uncommented again.
Follow-up to [48957], [49037].
See #50913 , #50902 .
Built from https://develop.svn.wordpress.org/trunk@49074
git-svn-id: http://core.svn.wordpress.org/trunk@48836 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-09-30 13:14:04 +00:00
bdccfa3a03
Code Modernization: Check if the file to retrieve metadata from in `get_file_data()` was successfully opened.
...
This avoids a fatal error on PHP 8 caused by passing a `false` value to `fread()`, instead of a file resource.
See #50913 .
Built from https://develop.svn.wordpress.org/trunk@49073
git-svn-id: http://core.svn.wordpress.org/trunk@48835 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-09-30 12:20:03 +00:00
e43ff0e991
Code Modernization: Return `false` from `wpdb::query()` if the query was filtered to an empty string using the `query` filter.
...
This avoids a fatal error on PHP 8 caused by passing an empty string to `mysqli_query()`, and maintains the current behaviour.
Follow-up to [48980], [48981].
See #50913 , #50639 .
Built from https://develop.svn.wordpress.org/trunk@49072
git-svn-id: http://core.svn.wordpress.org/trunk@48834 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-09-30 12:09:08 +00:00
b3b8942dfc
Docs: Correct description for `wp_ajax_update_widget()`.
...
Follow-up to [28355].
Props burhandodhy, sabernhardt.
Fixes #44583 .
Built from https://develop.svn.wordpress.org/trunk@49071
git-svn-id: http://core.svn.wordpress.org/trunk@48833 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-09-30 09:44:09 +00:00
f3168fa073
External Libraries: Update MediaElementJS to version 4.2.16.
...
This change brings a handful of bug fixes made since the previous update in [46436]. For a full list of changes included, see https://github.com/mediaelement/mediaelement/compare/4.2.13...4.2.16 .
Props mukesh27, hareesh-pillai, SergeyBiryukov.
Fixes #51315 .
Built from https://develop.svn.wordpress.org/trunk@49070
git-svn-id: http://core.svn.wordpress.org/trunk@48832 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-09-29 15:53:06 +00:00
d660801d27
Tests: Require `imagejpeg()` function in Ajax media editing tests.
...
This outputs a proper message if the requirement is not met, instead of an obscure failure further in the test.
These tests rely on multiple resized copies of a test JPEG image being generated and available.
Follow-up to [49010], [49024], [49025], [49045], [49050], [49052].
See #50639 , #50640 .
Built from https://develop.svn.wordpress.org/trunk@49069
git-svn-id: http://core.svn.wordpress.org/trunk@48831 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-09-29 14:16:07 +00:00
12a36355e6
Code Modernization: Remove a single trailing percent sign before calling `sprintf()` on the `$default` parameter in `get_theme_mod()`.
...
This avoids a "Missing format specifier at end of string" fatal error on PHP 8, and maintains the current behaviour.
See #50913 .
Built from https://develop.svn.wordpress.org/trunk@49068
git-svn-id: http://core.svn.wordpress.org/trunk@48830 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-09-29 10:03:08 +00:00
41681b29b0
Posts, Post Types: Avoid a PHP notice in `wp_get_shortlink()` if the post type is no longer registered.
...
Props apedog.
Fixes #51376 .
Built from https://develop.svn.wordpress.org/trunk@49067
git-svn-id: http://core.svn.wordpress.org/trunk@48829 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-09-28 11:53:08 +00:00
f1f579199b
Docs: Clarify the `false` return value of `get_post_type_archive_link()` and `get_post_type_archive_feed_link()`.
...
See #50768 .
Built from https://develop.svn.wordpress.org/trunk@49066
git-svn-id: http://core.svn.wordpress.org/trunk@48828 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-09-28 11:12:03 +00:00
249451fe08
Docs: Correct formatting for the `autosave()` function return value in `js/_enqueues/wp/autosave.js`.
...
Props dilipbheda, mukesh27.
Fixes #51401 .
Built from https://develop.svn.wordpress.org/trunk@49065
git-svn-id: http://core.svn.wordpress.org/trunk@48827 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-09-28 10:46:05 +00:00
2cbcc5d548
Media: Make the "Copy URL" button implementation more consistent with other instances in core:
...
* Make the "Copied!" text green.
* Make the button verbiage clear that it's copied "to clipboard".
Props garrett-eclipse, mukesh27.
Fixes #51355 .
Built from https://develop.svn.wordpress.org/trunk@49064
git-svn-id: http://core.svn.wordpress.org/trunk@48826 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-09-27 20:48:05 +00:00
bed5797cf6
REST API: Support the multipleOf JSON Schema keyword.
...
Props yakimun.
Fixes #51022 .
Built from https://develop.svn.wordpress.org/trunk@49063
git-svn-id: http://core.svn.wordpress.org/trunk@48825 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-09-27 19:03:05 +00:00
6bdbb8b25c
Media: Check if the item is defined before setting the `skipHistory` property in media frame router.
...
This avoids a JS error when refreshing the "Attachment details" modal for an item that is not currently queried.
Follow-up to [41021].
Props Mista-Flo, mukesh27.
Fixes #51395 .
Built from https://develop.svn.wordpress.org/trunk@49062
git-svn-id: http://core.svn.wordpress.org/trunk@48824 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-09-27 08:50:06 +00:00
c298458751
Docs: Add missing `@return` tags for some `WP_Automatic_Updater` methods:
...
* `::is_vcs_checkout()`
* `::should_update()`
* `::send_core_update_notification_email()`
Props ankitmaru, mukesh27.
Fixes #51385 .
Built from https://develop.svn.wordpress.org/trunk@49061
git-svn-id: http://core.svn.wordpress.org/trunk@48823 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-09-27 08:36:06 +00:00
d36da091c4
Taxonomy: Restore documentation for the `taxonomy` parameter of `wp_list_categories()`.
...
The parameter's default value is different from the one in `WP_Term_Query::__construct()`, and should be documented accordingly.
This also clarifies that the `taxonomy` parameter of `wp_list_categories()` only accepts a string, not an array.
Follow-up to [40903], [41767], [45894], [45895].
Props grapplerulrich, mukesh27, TimothyBlynJacobs, SergeyBiryukov.
Fixes #51378 . See #47896 .
Built from https://develop.svn.wordpress.org/trunk@49060
git-svn-id: http://core.svn.wordpress.org/trunk@48822 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-09-27 08:19:04 +00:00
5c3a734df0
Docs: Correct description for the `taxonomy` parameter of `wp_dropdown_categories()`.
...
Follow-up to [40903], [41767].
Props grapplerulrich, mukesh27, TimothyBlynJacobs.
See #51378 .
Built from https://develop.svn.wordpress.org/trunk@49059
git-svn-id: http://core.svn.wordpress.org/trunk@48821 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-09-27 07:49:06 +00:00
a8b070b56b
Docs: Fix typo in a comment in `js/media/routers/manage.js`.
...
Props mukesh27, garrett-eclipse.
Fixes #51397 .
Built from https://develop.svn.wordpress.org/trunk@49058
git-svn-id: http://core.svn.wordpress.org/trunk@48820 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-09-27 07:38:05 +00:00
bf2edf9cab
External Libraries: Backport a commit from sodium_compat trunk to fix a PHP 8 error.
...
This addresses an "Undefined constant `MB_OVERLOAD_STRING`" fatal error in the `ParagonIE_Sodium_Core_Util::isMbStringOverride()` method.
In PHP 8, the `MB_OVERLOAD_STRING` constant has been removed, along with the `mbstring` function overloading feature.
Fixes #51399 .
Built from https://develop.svn.wordpress.org/trunk@49057
git-svn-id: http://core.svn.wordpress.org/trunk@48819 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-09-27 05:17:05 +00:00
67752b98e0
Upgrade/Install: Update sodium_compat to v1.13.0.
...
This includes a few autoloader fixes and improvements.
A full list of changes in this update can be found on GitHub:
https://github.com/paragonie/sodium_compat/compare/v1.12.1...v1.13.0
See #51399 .
Built from https://develop.svn.wordpress.org/trunk@49056
git-svn-id: http://core.svn.wordpress.org/trunk@48818 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-09-27 04:46:05 +00:00
0db3f859ea
Add ircs and irc6 to the list of allowed protocols.
...
This adds support for the secure and ipv6 variants of the already allowed irc protocol.
Props arealnobrainer, markparnell, ctmartin.
Built from https://develop.svn.wordpress.org/trunk@49055
git-svn-id: http://core.svn.wordpress.org/trunk@48817 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-09-26 21:02:04 +00:00
bf397c8d89
REST API: Correct @since version after [49053].
...
See #51023 .
Built from https://develop.svn.wordpress.org/trunk@49054
git-svn-id: http://core.svn.wordpress.org/trunk@48816 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-09-26 18:56:04 +00:00
9951662ebb
REST API: Support the minProperties and maxProperties JSON Schema keywords.
...
Props yakimun.
Fixes #51023 .
Built from https://develop.svn.wordpress.org/trunk@49053
git-svn-id: http://core.svn.wordpress.org/trunk@48815 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-09-26 18:20:07 +00:00
noisysocks
Andrew Ozz
desrosj
Sergey Biryukov
TimothyBlynJacobs
Adam Silverstein
Helen Hou-Sandí
John Blackbourn