Commit Graph

50373 Commits

Author SHA1 Message Date
Pascal Birchler 117b935b89 I18N: Load translations just-in-time for custom themes and plugins.
In #34114, just-in-time (JIT) translation loading was implemented for projects hosted on WordPress.org. This is now expanded to all other plugins/themes.

Projects with a custom `Text Domain` and `Domain Path` header no longer need to call `load_plugin_textdomain()` or `load_theme_textdomain()`.

This reduces the risk of calling them too late, after some translation calls already happened, and generally makes it easier to properly internationalize a plugin or theme.

This moves the `get_plugin_data()` from `wp-admin/includes/plugin.php` to `wp-includes/functions.php` so it's available during the plugin loading process.

Props swissspidy.
Fixes #62244.
Built from https://develop.svn.wordpress.org/trunk@59461


git-svn-id: http://core.svn.wordpress.org/trunk@58847 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-26 10:16:17 +00:00
Pascal Birchler 6e38205391 I18N: Switch locale to admin locale when sending auto update emails.
If sending an auto update email to the site administrator's email address, look up if a user with the same email exists and switch to that user's locale. If not, explicitly switches to the site locale.

This is a follow-up to [59128] where this was previously added for other types of emails.

Props benniledl, swissspidy.
Fixes #62496.
Built from https://develop.svn.wordpress.org/trunk@59460


git-svn-id: http://core.svn.wordpress.org/trunk@58846 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-26 10:03:17 +00:00
Sergey Biryukov 6f6ddfc80f Coding Standards: Cast `$expired` to an integer in `wp_validate_auth_cookie()`.
This resolves an issue where the string `$expired` value is used both in a comparison and addition with integer values.

Follow-up to [6387], [28424], [45590].

Props justlevine.
See #52217.
Built from https://develop.svn.wordpress.org/trunk@59459


git-svn-id: http://core.svn.wordpress.org/trunk@58845 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-25 19:03:18 +00:00
Bernhard Reiter f03be09041 REST API: Terms: Respect taxonomy's default query args.
It is possible to supply a set of default query `args` to `register_taxonomy()` which will be used when querying a list of terms -- for example, `orderby` in order to specify how the resulting list of terms should be sorted.

The Terms REST API controller previously respected these default query args only if the request included a post ID. This changeset makes it so that the default args will also be respected if no post ID is provided.

Props bernhard-reiter, jsnajdr.
Fixes #62500.
Built from https://develop.svn.wordpress.org/trunk@59458


git-svn-id: http://core.svn.wordpress.org/trunk@58844 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-25 11:16:22 +00:00
Pascal Birchler 8f303471a4 REST API: Remove trailing slashes when preloading requests and there is a query string.
Follow-up to [51648], see #51636.

Props antonvlasenko, swissspidy, spacedmonkey.
Fixes #57048.
Built from https://develop.svn.wordpress.org/trunk@59457


git-svn-id: http://core.svn.wordpress.org/trunk@58843 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-25 10:10:17 +00:00
Sergey Biryukov c67b970348 Coding Standards: Remove extra `unset()` in `rest_handle_options_request()`.
`$args` is defined in the immediately preceding code block, and only contains non-integer keys, so there is never an `$args[0]` to unset.

Follow-up to [44933].

Props justlevine.
See #52217.
Built from https://develop.svn.wordpress.org/trunk@59456


git-svn-id: http://core.svn.wordpress.org/trunk@58842 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-24 18:37:20 +00:00
Sergey Biryukov 6bf8fa1514 Coding Standards: Replace usage of deprecated `wp_get_duotone_filter_svg()`.
This updates `WP_Theme_JSON::get_svg_filters()` to use `WP_Duotone::get_filter_svg_from_preset()` instead of the `wp_get_duotone_filter_svg()` function, deprecated in WordPress 6.3.

Follow-up to [52757], [56101].

Props justlevine.
See #52217.
Built from https://develop.svn.wordpress.org/trunk@59455


git-svn-id: http://core.svn.wordpress.org/trunk@58841 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-23 22:58:21 +00:00
Andrew Ozz 683505a121 Editor: Fix selecting/deselecting multiple unwanted categories when clicking on a Category checkbox on the old Edit Post screen.
Props ffffelix, desrosj, ironprogrammer, neotrope, narenin, zaoyao, im3dabasia1, cbravobernal, azaozz.
Fixes #62504.
Built from https://develop.svn.wordpress.org/trunk@59454


git-svn-id: http://core.svn.wordpress.org/trunk@58840 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-22 20:10:24 +00:00
Sergey Biryukov 7a78121aa0 Coding Standards: Explicitly return `null` instead of coercing `void`.
This addresses two instances where a function that is documented as returning `{someType}|null` doesn't explicitly return `null`.

Affected functions:
* `array_key_first()`
* `WP_REST_Posts_Controller::handle_terms()`

Follow-up to [38832], [52038].

Props justlevine.
See #52217.
Built from https://develop.svn.wordpress.org/trunk@59453


git-svn-id: http://core.svn.wordpress.org/trunk@58839 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-22 19:19:20 +00:00
desrosj e80371660d Build/Test Tools: Create reusable workflow for parsing `.version-support-*.json` files.
This extracts the logic responsible for parsing the `.version-support-*.json` files and returning a list of supported PHP and MySQL versions for a given branch of WordPress into a reusable workflow so that other workflows can make use of the functionality without repeating code.

See #62221.
Built from https://develop.svn.wordpress.org/trunk@59452


git-svn-id: http://core.svn.wordpress.org/trunk@58838 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-22 17:00:21 +00:00
desrosj b29834538e Bundled Theme: Pin schema version to rest of Twenty Twenty-Five.
All JSON files in the theme should be pinned to the appropriate schema version, not just `theme.json`.

Follow up to [59448].

Props im3dabasia1, poena.
Fixes #62455.
Built from https://develop.svn.wordpress.org/trunk@59451


git-svn-id: http://core.svn.wordpress.org/trunk@58837 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-22 13:50:18 +00:00
cbravobernal 261373653c HTML API: Prevent fragment creation on close tag.
Prevent fragments from being created at tag closers.

Follow-up to [59444].

Props jonsurrell, bernhard-reiter.
Fixes #62357.

Built from https://develop.svn.wordpress.org/trunk@59450


git-svn-id: http://core.svn.wordpress.org/trunk@58836 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-22 12:52:19 +00:00
mikachan e0d58b3987 Editor: Warn about empty templates on the frontend for logged in users.
Adds a new function, `wp_render_empty_block_template_warning`, that renders a warning for logged-in users when a block template is empty.

Reviewed by get_dave, richtabor.
Props vcanales, mikachan, peterwilsoncc, richtabor, get_dave, mrfoxtalbot, matveb, arielmaidana, seifradwane, annezazu.
Fixes #62053.
Built from https://develop.svn.wordpress.org/trunk@59449


git-svn-id: http://core.svn.wordpress.org/trunk@58835 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-22 10:57:19 +00:00
desrosj 04111ef54f Bundled Theme: Pin a `theme.json` schema version to Twenty Twenty-Five.
Each theme’s `theme.json` schema version should be pinned to the version that was valid at the time it was released.

Props im3dabasia1, poena, mukesh27.
Fixes #62455.
Built from https://develop.svn.wordpress.org/trunk@59448


git-svn-id: http://core.svn.wordpress.org/trunk@58834 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-21 19:02:23 +00:00
Bernhard Reiter ff3fde39ee HTML API: Add method to create fragment at node.
HTML Fragment parsing always happens with a context node, which may impact how a fragment of HTML is parsed. HTML Fragment Processors can be instantiated with a `BODY` context node via `WP_HTML_Processor::create_fragment( $html )`.

This changeset adds a static method called `create_fragment_at_current_node( string $html_fragment )`. It can only be called when the processor is paused at a `#tag`, with some additional constraints:

- The opening and closing tags must appear in the HTML input (no virtual tokens).
- No "self-contained" elements are allowed ( `IFRAME`, `SCRIPT`, `TITLE`, etc.).

If successful, the method will return a `WP_HTML_Processor` instance whose context is inherited from the node that the method was called from.

Props jonsurrell, bernhard-reiter, gziolo.
Fixes #62357.
Built from https://develop.svn.wordpress.org/trunk@59444


git-svn-id: http://core.svn.wordpress.org/trunk@58830 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-21 13:29:18 +00:00
John Blackbourn 8f1dc00b4d Build/Test Tools: Improve the error message shown when fetching Twemoji fails.
This allows the full error message to be shown from the connection attempt instead of a generic error message.

Fixes #62382

Built from https://develop.svn.wordpress.org/trunk@59443


git-svn-id: http://core.svn.wordpress.org/trunk@58829 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-21 13:18:19 +00:00
Joe McGill 134e355f13 Editor: Avoid unnecessary array_merge in WP_Style_Engine::parse_block_styles().
This adds an `! empty()` check for classnames and declarations to avoid calling array_merge() with an empty value.

Props mukesh27, ramonopoly, aaronrobertshaw.
Fixes #62317.

Built from https://develop.svn.wordpress.org/trunk@59442


git-svn-id: http://core.svn.wordpress.org/trunk@58828 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-20 21:29:22 +00:00
desrosj 37c8e1ae21 Build/Test Tools: Correctly check for Dependabot.
This updates the conditions added in [59370] to skip unnecessary pull request comments when Dependabot is the opening contributor to check for the correct `github.actor` value.

Follow up to [59380].

See #62221.
Built from https://develop.svn.wordpress.org/trunk@59441


git-svn-id: http://core.svn.wordpress.org/trunk@58827 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-20 18:10:23 +00:00
desrosj 6efab4c237 Editor: update npm packages in trunk for 6.7.1.
Syncs Editor packages for WordPress 6.7.1 RC1. Includes the following PRs:

- https://github.com/WordPress/gutenberg/pull/66945
- https://github.com/WordPress/gutenberg/pull/66889
- https://github.com/WordPress/gutenberg/pull/67139 

Reviewed by desrosj.
Merges [59437] to trunk.

Props mmaattiiaass, ramonopoly, mamaduka, get_dave, poena, ntsekouras, mcsf, jsnajdr, 0mirka00, desrosj, joemcgill, cbravobernal, azaozz, room34, mayanktripathi32, im3dabasia1, jonsurrell.
Fixes #62478, #62447. 
Built from https://develop.svn.wordpress.org/trunk@59438


git-svn-id: http://core.svn.wordpress.org/trunk@58824 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-20 16:20:31 +00:00
Sergey Biryukov d37c855db1 I18N: Adjust translator comments in `nav-menu.js`.
Includes:
* Moving the comments directly above `wp.i18n._x()` so that they can be picked up properly.
* Simplifying the context to avoid unnecessarily translating the string twice for the same use case.
* Using the established translator comments format for consistency.

Follow-up to [59428].

See #62402.
Built from https://develop.svn.wordpress.org/trunk@59431


git-svn-id: http://core.svn.wordpress.org/trunk@58817 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-20 11:22:19 +00:00
desrosj c557605794 i18n: Account for `load_*_textdomain()` after JIT loading.
When `load_*_textdomain()` functions are called after WordPress has already attempted just-in-time loading of translations, nothing happens. 

This updates the related logic to retry translation loading when a custom path is set to ensure all translations are available.

Additionally, this also fixes cases where an `en_US.mo` file is provided with non-English strings to override the default language.

Follow up to [59157].

Props swissspidy, peterwilsoncc, desrosj, apermo, sergeybiryukov, wildworks, tigriweb, twvania, looswebstudio, stimul, audrasjb, finntown, bluantinoo, timwhitlock, albigdd.
See #62337.
Built from https://develop.svn.wordpress.org/trunk@59430


git-svn-id: http://core.svn.wordpress.org/trunk@58816 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-20 02:50:24 +00:00
desrosj 85928dc39a Options, Meta APIs: Ensure duplicate salts are properly flagged.
Improvements were made in 6.7 to ensure that salts stored in the database were primed more efficiently.

The logic added to accomplish this suffered from an edge case where array indexes were unexpectedly missing when `wp_salt()` was called recursively.

Follow up to [58837].

Props juliobox, ankitkumarshah, dilipbheda, johnbillion, joemcgill, desrosj.
Fixes #62424.
Built from https://develop.svn.wordpress.org/trunk@59427


git-svn-id: http://core.svn.wordpress.org/trunk@58813 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-20 01:39:19 +00:00
joedolson 41226f1164 Menus: i18n: Fix untranslatable strings in `nav-menu.js`.
Wrap three untranslatable strings in nav menus in JS translation functions.

Follow up to [59265].

Props juliemoynat, swissspidy, yogeshbhutkar, sergeybiryukov, desrosj, tobifjellner, audrasjb, joedolson.
Fixes #62402.
Built from https://develop.svn.wordpress.org/trunk@59426


git-svn-id: http://core.svn.wordpress.org/trunk@58812 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-19 23:25:20 +00:00
Sergey Biryukov e8741c53c8 Toolbar: Allow the Learn WordPress link to be localized.
The Learn WordPress website is supposed to automatically redirect to the correct locale according to the browser's language settings, however that may not work as expected in some cases.

This commit brings consistency with the other WordPress.org links, which can be localized as appropriate.

Follow-up to [56720].

Props timse201, ruturajraval2305, yogeshbhutkar, ajayghaghretiya-multidots, swissspidy, sabernhardt, im3dabasia1, mukesh27.
Fixes #62459.
Built from https://develop.svn.wordpress.org/trunk@59425


git-svn-id: http://core.svn.wordpress.org/trunk@58811 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-19 22:18:21 +00:00
joedolson 70842372b1 Login: Revert selector change in login heading CSS.
In [59138], the login screens were updated to change the `h1` heading from the logo to screen-reader hidden text. Along with that HTML change, we changed the CSS selectors from `.login h1` to `.login .wp-login-logo`. This unnecessary change increased specificity and broke the CSS selectors used by a wide variety of plugins to replace the login logo.

Commit reverts the change in selector back to using the `.login h1` pattern.

Props leecollings, sabernhardt, im3dabasia1, roytanck, sailpete, joedolson. 
Fixes #62410.
Built from https://develop.svn.wordpress.org/trunk@59424


git-svn-id: http://core.svn.wordpress.org/trunk@58810 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-19 21:24:22 +00:00
czapla d54b7924ef HTML API: Use case insensitive tag_name comparison in `::next_tag`.
The HTML API `::next_tag` method now performs case-insensitive matching when searching for tags by name. For example, searching for 'DIV' will match both '<div>' and '<DIV>' tags.

Props jonsurrell, dmsnell.
Fixes #62427.

Built from https://develop.svn.wordpress.org/trunk@59422


git-svn-id: http://core.svn.wordpress.org/trunk@58808 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-19 16:05:17 +00:00
youknowriad e09a15b011 Admin Color Scheme: Update the highlight color in the Modern color scheme.
In the Modern color scheme, the font color on hover in the admin bar is bright green. However, in the WordPress.org site itself, the color used is Blueberry 2. This commits aligns both colors on the more balanced Blueberry color.

Props fushar, Joen.
Fixes #62219.
Built from https://develop.svn.wordpress.org/trunk@59419


git-svn-id: http://core.svn.wordpress.org/trunk@58805 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-19 08:02:16 +00:00
ramonopoly 70b4a18c97 Theme JSON: include block style variations in path only output of get_block_nodes
An `$include_node_paths_only` option to `get_block_nodes()` was introduced to improve performance.

When set to `true`, this option tells the function to only return paths, and not selectors, for consumers that only needed paths to style values.

For one of the conditional blocks, block style variations wasn't included.

This commit adds them to the array of paths following the existing model `$node[]['path' => [], 'variations' => ['path' => []]]`.

Follow-up to [61858].

Props aaronrobertshaw, ramonopoly.
Fixes #62399.



Built from https://develop.svn.wordpress.org/trunk@59418


git-svn-id: http://core.svn.wordpress.org/trunk@58804 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-19 04:44:19 +00:00
Sergey Biryukov c6e76c3c5b Users: Correct “Add New User” page reference on Network Settings screen.
Follow-up to [56515].

Props timse201.
Fixes #62458.
Built from https://develop.svn.wordpress.org/trunk@59417


git-svn-id: http://core.svn.wordpress.org/trunk@58803 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-18 23:38:20 +00:00
czapla c0baa82edc Interactivity API: Remove redundant server state from Interactivity Router
Remove the workaround for a bug that was fixed in https://github.com/WordPress/gutenberg/pull/66183. Previously, if the store was not initialized with a minimal navigation object, the interactivity-router script module would error.

Props jonsurrell, czapla, gziolo.
Fixes 62465#.

Built from https://develop.svn.wordpress.org/trunk@59416


git-svn-id: http://core.svn.wordpress.org/trunk@58802 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-18 20:06:24 +00:00
Felix Arntz a7dda35133 Media: Avoid images with `sizes=auto` to be displayed downsized in supporting browsers.
Based on the user agent stylesheet rules outlined in https://html.spec.whatwg.org/multipage/rendering.html#img-contain-size, images that have `sizes=auto` while applying `width: auto` or `width: fit-content` would be constrained to only 300px width.

This changeset overrides said user agent stylesheet rule with a much larger constraint, to avoid the problem.

Additionally, it introduces a filter `wp_img_tag_add_auto_sizes` which can be used to opt out of the functionality, as an additional measure.

Props joemcgill, flixos90, dooperweb, SirLouen, azaozz, mukesh27, apermo.
Fixes #62413.
See #61847, #62345.

Built from https://develop.svn.wordpress.org/trunk@59415


git-svn-id: http://core.svn.wordpress.org/trunk@58801 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-18 19:52:19 +00:00
Andrew Ozz 6813017f32 Editor: Fix the JS to select, save, and update categories on the old Edit Post screen.
Props: charleslf, im3dabasia1, desrosj, dhruvang21, Zargarov, sainathpoojary, azaozz
Fixes: #62440
Built from https://develop.svn.wordpress.org/trunk@59414


git-svn-id: http://core.svn.wordpress.org/trunk@58800 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-18 19:33:18 +00:00
desrosj 2c691c2fbd Media: Avoid running expensive logic twice using GD.
Support for uploading AVIF was added in [57524]. A new block of conditional logic was added determine which function should be used to create the new image file that resulted in these expensive functions being run twice.

This combines the two conditional logic to ensure the appropriate function is only run once regardless of format.

Props adamsilverstein, glynnquelch.
Fixes #62331.
Built from https://develop.svn.wordpress.org/trunk@59413


git-svn-id: http://core.svn.wordpress.org/trunk@58799 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-18 18:05:18 +00:00
desrosj 74b593f2d2 Editor: Use sentence casing for “Call to action”.
This is more consistent with other strings and occurrences of this string.

Props juanfra, joen, narenin, mukesh27.
See #62414.
Built from https://develop.svn.wordpress.org/trunk@59412


git-svn-id: http://core.svn.wordpress.org/trunk@58798 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-18 17:35:17 +00:00
cbravobernal 72a29cef78 HTML API: Fix normalized doctype pub/sys identifier quotes.
Changeset [59399] fixed missing DOCTYPEs in normalized HTML output. It missed an edge case where public and system identifiers may contain double quotes, in which case they must be quoted with single quotes.

This commit addresses that issue and adds tests.

Follow-up to [59399].

Props jonsurrell, luisherranz, apermo.
Fixes #62396.

Built from https://develop.svn.wordpress.org/trunk@59410


git-svn-id: http://core.svn.wordpress.org/trunk@58796 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-18 13:07:17 +00:00
joedolson 5a2559365d Customizer: Fix layout issues in customizer accordions.
Adjust some CSS characteristics in the customizer accordions to avoid a slight horizontal scroll, allow the chevron icon to be part of the clickable control surface, and resolve a pre-existing padding issue allowing overflow on accordion headings.

Follow up to [59224].

Props laurelfulford, wildworks, domainsupport, sabernhardt, rcreators, desrosj, sainathpoojary. 
Fixes #62313, #62335.
Built from https://develop.svn.wordpress.org/trunk@59409


git-svn-id: http://core.svn.wordpress.org/trunk@58795 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-18 02:55:20 +00:00
Sergey Biryukov 8f92dfad4d Tests: Add missing `@covers` tag for `fetch_feed()` tests.
Includes correcting the test class name as per the naming conventions.

Follow-up to [59382].

See #62280.
Built from https://develop.svn.wordpress.org/trunk@59408


git-svn-id: http://core.svn.wordpress.org/trunk@58794 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-17 13:44:21 +00:00
Sergey Biryukov df05a5564f Coding Standards: Escape attachment URL in `wp-admin/async-upload.php`.
Follow-up to [58279].

Props shyamkariya, pitamdey, nareshbheda, ketanniruke, desrosj.
Fixes #62434.
Built from https://develop.svn.wordpress.org/trunk@59407


git-svn-id: http://core.svn.wordpress.org/trunk@58793 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-16 23:15:29 +00:00
Sergey Biryukov ea47259795 Docs: Add missing commas in a few DocBlocks for various media functions.
Follow-up to [56416].

Props truptikanzariya.
Fixes #62433.
Built from https://develop.svn.wordpress.org/trunk@59406


git-svn-id: http://core.svn.wordpress.org/trunk@58792 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-15 21:11:22 +00:00
John Blackbourn 9bc4fadffa Docs: Correct the spelling of silicon in the local development environment readme.
See #62281

Built from https://develop.svn.wordpress.org/trunk@59405


git-svn-id: http://core.svn.wordpress.org/trunk@58791 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-14 16:46:20 +00:00
desrosj ad2f51c90a Build/Test Tools: Correct upgrade testing workflow name.
The reusable upgrade testing workflow was renamed in [58165], but the event `paths` filters were not updated accordingly.

See #62221.
Built from https://develop.svn.wordpress.org/trunk@59403


git-svn-id: http://core.svn.wordpress.org/trunk@58789 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-13 19:13:14 +00:00
desrosj cf3720d787 Build/Test Tools: Avoid starting the database twice.
The database container is started when the `services` are initially set up. Having a separate step for this sometimes introduces unexpected failures for an unknown reason.

Props johnbillion.
See #62221.
Built from https://develop.svn.wordpress.org/trunk@59402


git-svn-id: http://core.svn.wordpress.org/trunk@58788 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-13 19:08:20 +00:00
Sergey Biryukov a20a5a4516 Coding Standards: Consistently escape URLs in `wp-admin/themes.php`.
Includes:
* Wrapping long lines for better readability.
* Bringing some consistency to the placement of `href` and `aria-label` attributes.
* Adding missing `aria-label` attributes for Live Preview links.

Follow-up to [26726], [52020], [51083].

Props patelketan, sainathpoojary, SergeyBiryukov.
Fixes #62405.
Built from https://develop.svn.wordpress.org/trunk@59400


git-svn-id: http://core.svn.wordpress.org/trunk@58786 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-13 12:27:12 +00:00
Bernhard Reiter 8f5eb7a835 HTML API: Include doctype in full parser serialize.
Output DOCTYPE when calling `WP_HTML_Processor::serialize` on a full document that includes a DOCTYPE.

The DOCTYPE should be included in the serialized/normalized HTML output as it has an impact in how the document is handled, in particular whether the document should be handled in quirks or no-quirks mode.

This only affects the serialization of full parsers at this time because DOCTYPE tokens are currently ignored in all possible fragments. The omission of the DOCTYPE is subtle but can change the serialized document's quirks/no-quirks mode.

Props jonsurrell.
Fixes #62396.
Built from https://develop.svn.wordpress.org/trunk@59399


git-svn-id: http://core.svn.wordpress.org/trunk@58785 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-13 12:20:15 +00:00
cbravobernal 9a99674204 Interactivity API: Allow missing state negation on server
Aligns on the behavior of the negation operator with directives to missing paths in client and in server.

With a directive like the following:
{{{
<div data-wp-bind--hidden="!state.missing.property">
	This should be hidden by the <code>hidden</code> attribute.
</div>
}}}

Both server and client will return with this fix:
{{{
<div data-wp-bind--hidden="!state.missing.property" hidden="">
	This should be hidden by the <code>hidden</code> attribute.
</div>
}}}

Props jonsurrell, luisherranz.
Fixes #62374.


Built from https://develop.svn.wordpress.org/trunk@59398


git-svn-id: http://core.svn.wordpress.org/trunk@58784 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-13 11:19:18 +00:00
desrosj 3ba197a255 Build/Test Tools: Run upgrade tests against 6.7.
Now that 6.7 is generally available, the upgrade tests no longer need to be run against a pre-release version.

See #62221.
Built from https://develop.svn.wordpress.org/trunk@59397


git-svn-id: http://core.svn.wordpress.org/trunk@58783 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-13 00:37:19 +00:00
desrosj d826bdbb7c Build/Test Tools: Prevent orphaned Docker containers.
This updates certain local Docker environment commands to include `--rm`, which instructs `docker compose` to remove the container after running the specified scripts.

Previously only the installation script contained `--rm`. But running `test:php`, `env:start`, or `env:cli` resulted in the container remaining.

Props johnbillion.
Fixes #62395.
Built from https://develop.svn.wordpress.org/trunk@59393


git-svn-id: http://core.svn.wordpress.org/trunk@58779 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-12 17:46:21 +00:00
Bernhard Reiter 0c6d68448b HTML API: Expect closer on foreign content `void` lookalike elements.
Ensure that `expects_closer` returns `false` on tags that look like void HTML tags, but are actually ''not'' void tags in foreign content.

Props jonsurrell, bernhard-reiter.
Fixes #62363.
Built from https://develop.svn.wordpress.org/trunk@59392


git-svn-id: http://core.svn.wordpress.org/trunk@58778 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-12 12:58:16 +00:00
Bernhard Reiter 0be8a89a8f HTML API: Ensure that full processor can seek to earlier bookmarks.
When the HTML Processor seeks to an earlier place, it returns the the beginning of the document and proceeds forward until it reaches the appropriate location. This requires resetting internal state so that the processor can correctly proceed from the beginning of the document.

The seeking reset logic was not adapted to account for the full processor (i.e. when created via `WP_HTML_Processor::create_full_parser()`). This change updates the seek logic to account for the full and fragment parsers as well as other state that has been introduced in the interim and should be reset.

Props jonsurrell, dmsnell, westonruter, mi5t4n.
Fixes #62290.
Built from https://develop.svn.wordpress.org/trunk@59391


git-svn-id: http://core.svn.wordpress.org/trunk@58777 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-12 10:32:17 +00:00
poena c05b42ec1e Twenty Twenty: Correct the border style of the pull quote block in the editor.
This change makes the border of the pull quote block visible in the editor when the user selects a border color or thickness,
by setting the default border style to solid.

Props nidhidhandhukiya, ugyensupport, dhruvang21, sabernhardt, divyeshk71, poena.
Fixes #62301.
Built from https://develop.svn.wordpress.org/trunk@59390


git-svn-id: http://core.svn.wordpress.org/trunk@58776 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-12 05:46:19 +00:00