Remove `role="presentation"` from headings in the customizer. These were needed to avoid confusing semantics when the headings also acted as buttons to control accordions, changed in [59924].
Change responsive CSS to use `screen-reader-text` styling rather than `display: none` so that mobile retains the headings hierarchy.
Props joedolson, hbhalodia, mikinc860, guillaumeturpin, rcreators, tirth03, dhrumilk .
Fixes#62215.
Built from https://develop.svn.wordpress.org/trunk@59825
git-svn-id: http://core.svn.wordpress.org/trunk@59167 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This function and filter complement the existing `wp_should_load_separate_core_block_assets()` with filter `'should_load_separate_core_block_assets'`, which until now was responsible for two different purposes:
1. Loading separate stylesheets for Core blocks, instead of a combined `wp-block-library` stylesheet (as the name indicates).
2. Loading block scripts and stylesheets on demand only if the blocks are included in the page (not indicated by the name).
The new function and filter handles exclusively the 2nd purpose, making it possible to individually adjust both behaviors. For backward compatibility, the return value of `wp_should_load_separate_core_block_assets()` is used as the filterable default for `wp_should_load_block_assets_on_demand()`. Yet, the two filters can now be individually be controlled: For example, a site owner that wants to keep loading the combined `wp-block-library` stylesheet can now do so without giving up on the ability to load block scripts and stylesheets on demand.
Block themes now opt in by default to both features, similar to how they were already doing before via just the one filter. This way, block themes that opt out of loading separate stylesheets for Core blocks will still benefit from loading block scripts and stylesheets on demand, which in the case of block themes is strongly recommended.
Props fabiankaegy, flixos90, gziolo.
Fixes#61965.
Built from https://develop.svn.wordpress.org/trunk@59823
git-svn-id: http://core.svn.wordpress.org/trunk@59165 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Increase the z-index of sidebar submenus in the theme browser screens so that submenus are not placed behind the theme details overlay. Also set a min-height to ensure the overlay covers the entire screen if content is short.
Props codexdemon, amolebonde, yahil, girishpanchal, chintanmachhi207, mp518, janak007, worldweb, ralessio, sabernhardt, boogah, mikinc860, adamsilverstein, subrataemfluence, huzaifaalmesbah, lakshmananphp, amin7, imranhasanraaz, mdibrahimk48.
Fixes#41155.
Built from https://develop.svn.wordpress.org/trunk@59821
git-svn-id: http://core.svn.wordpress.org/trunk@59163 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Introduced caching for the `count_user_posts` function to reduce redundant database queries. This ensures better performance by storing and reusing query results when possible. Additionally, sanitized and sorted the `$post_type` array to avoid invalid queries.
Props spacedmonkey, peterwilsoncc, mamaduka, flixos90, johnjamesjacoby, swissspidy, dilip2615, johnregan3, wpgurudev, desrosj, milindmore22, Krstarica, dilipom13.
Fixes#39242.
Built from https://develop.svn.wordpress.org/trunk@59817
git-svn-id: http://core.svn.wordpress.org/trunk@59159 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Fixes a bug in the manipulation of selectors for block style variations that would result in an incorrect selector and fail to match the appropriate elements on the frontend.
Props aaronrobertshaw, ramonopoly, joemcgill.
Fixes#62471.
Built from https://develop.svn.wordpress.org/trunk@59814
git-svn-id: http://core.svn.wordpress.org/trunk@59156 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This changeset replaces the hardcoded hash symbol with running `maybe_hash_hex_color()` on the full `background-color` value provided via the custom background feature, so the hash is only added if it is needed. By doing so, if a theme developer sets a background color value that uses a hash (#), WordPress won't add an additional hash anymore when outputting the relevant CSS. Duplicate hash symbols (##) can break CSS background color declarations.
Props hovhanneshovakimyan, joyously, poena,
Fixes#40057.
Built from https://develop.svn.wordpress.org/trunk@59813
git-svn-id: http://core.svn.wordpress.org/trunk@59155 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This extension provides the `hash()` function and support for the SHA-256 algorithm, both of which are required for upcoming security related changes. This extension is almost universally enabled, however it is technically possible to disable it on PHP 7.2 and 7.3, hence the introduction of this requirement and the corresponding requirement checks prior to installing or upgrading WordPress.
Props peterwilsoncc, ayeshrajans, dd32, SergeyBiryukov, johnbillion.
Fixes#60638, #62815, #56017
See #21022
Built from https://develop.svn.wordpress.org/trunk@59803
git-svn-id: http://core.svn.wordpress.org/trunk@59145 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Fixes an issue where block style variations containing inner block type and element styles would have those inner styles stripped when the user attempting to save Global Styles does not have the `unfiltered_html` capability.
Props aaronrobertshaw, mukesh27, andrewserong.
Fixes#62372.
Built from https://develop.svn.wordpress.org/trunk@59802
git-svn-id: http://core.svn.wordpress.org/trunk@59144 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Introduce `ignore_sticky` as a boolean argument for the posts endpoint for requests without the sticky posts being stuck. The new argument defaults to `false` with the value of the argument passed to `WP_Query`'s `ignore_sticky_posts` parameter.
Props audrasjb, danielbachhuber, joemcgill, johnbillion, jorbin, mamaduka, rmccue.
Fixes#35907.
Built from https://develop.svn.wordpress.org/trunk@59801
git-svn-id: http://core.svn.wordpress.org/trunk@59143 1a063a9b-81f0-0310-95a4-ce76da25c4cd
`matchdep` was introduced in [25243] to more easily manage `grunt-*` dependencies. The package has effectively been abandoned upstream, and the functionality can be replaced with a simple loop.
Props desrosj, spacedmonkey, swissspidy.
See #62221.
Built from https://develop.svn.wordpress.org/trunk@59797
git-svn-id: http://core.svn.wordpress.org/trunk@59139 1a063a9b-81f0-0310-95a4-ce76da25c4cd
For the Post Editor, preload '/wp/v2/global-styles/' . $global_styles_id with a context corresponding to user caps, that is, 'edit' for users that can edit global styles, and 'view' for everyone else.
Preloading the global styles endpoint according to role context means that admins and non admins, e.g., editors, avoid unnecessary client side requests.
Props ramonopoly.
Fixes#62322.
Built from https://develop.svn.wordpress.org/trunk@59795
git-svn-id: http://core.svn.wordpress.org/trunk@59137 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Updates the enqueued styles in various editors to remove target styles more precisely to where they are needed.
Removes the following stylesheets as dependencies of `wp-edit-blocks`:
* `wp-editor`
* `wp-reusable-blocks`
* `wp-patterns`
The `wp-editor` stylesheet is targeted to the items requiring the CSS:
* `edit-widgets`
* `customize-widgets`
* `edit-site`
Props ellatrix, youknowriad.
Fixes#62266, #62274.
Built from https://develop.svn.wordpress.org/trunk@59793
git-svn-id: http://core.svn.wordpress.org/trunk@59135 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This changeset improves a bunch of error messages, notably replacing the good old cryptic "Something went wrong" message with more helpful information.
Props peterwilsoncc, netweb, karmatosed, JoshuaWold, mrtortai, audrasjb, sukhendu2002, joedolson.
Fixes#43622.
Built from https://develop.svn.wordpress.org/trunk@59790
git-svn-id: http://core.svn.wordpress.org/trunk@59132 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This changeset improves a bunch of WP-Admin error messages, notably replacing the good old cryptic "Something went wrong" message with more helpful information.
Props peterwilsoncc, netweb, karmatosed, JoshuaWold, mrtortai, audrasjb, sukhendu2002, joedolson.
See #43622.
Built from https://develop.svn.wordpress.org/trunk@59789
git-svn-id: http://core.svn.wordpress.org/trunk@59131 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This changeset replaces each occurrence of "Add New {Item}" label with "Add {Item}" in WordPress administration, to make the interface more consistent and simplify the translation effort.
Props jameskoster, audrasjb, ntsekouras, afercia, peterwilsoncc, youknowriad, joedolson, sukhendu2002, jdy68, beryldlg, fxbenard.
See #61219.
Built from https://develop.svn.wordpress.org/trunk@59784
git-svn-id: http://core.svn.wordpress.org/trunk@59126 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Follow up to [59224]. Add CSS to cover usage of the `do_accordion_section()` function when used in extender contexts outside of the existing WordPress core usage.
Props mboynes, jorbin, joemcgill, joedolson.
Fixes#62907.
Built from https://develop.svn.wordpress.org/trunk@59772
git-svn-id: http://core.svn.wordpress.org/trunk@59114 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This fixes a `ReferenceError` caused by a stray Unicode character in the unminified version of moxie.js. This has long been fixed upstream but the library cannot be wholesale updated in WordPress because of an incompatible license change.
Because of this, a new version is being tagged, `1.3.5.1`, and the file header has been updated to make it more clear that the file is a maintained fork with a high level list of changes made.
Props kinggmobb, jorbin, q0rban, azaozz, desrosj, sukhendu2002.
Fixes#59329.
Built from https://develop.svn.wordpress.org/trunk@59770
git-svn-id: http://core.svn.wordpress.org/trunk@59112 1a063a9b-81f0-0310-95a4-ce76da25c4cd
The WordPress Importer plugin has been maintained separately in a repository on GitHub since 2016. However, the unit tests were left in wordpress-develop due to the lack of a CI setup on GitHub.
With GitHub Actions set up for the plugin repository, these tests are now running in two locations. Because they are more relevant to the plugin itself, the tests have been synced, will run weekly through a `schedule` event, and are now being removed from wordpress-develop.
The only remaining test method in the `import` group covers `get_importers()`, which is a function maintained in WordPress Core itself.
Props frank-klein, netweb, dd32, peterwilsoncc, azaozz, desrosj, swissspidy.
Fixes#42668.
Built from https://develop.svn.wordpress.org/trunk@59769
git-svn-id: http://core.svn.wordpress.org/trunk@59111 1a063a9b-81f0-0310-95a4-ce76da25c4cd